June 2010 - Wine-Devel - list.winehq.org

Re: avifil32: Update English resource
by Alexandre Julliard June 15, 2010

June 15, 2010

Ken Sharp <kennybobs(a)o2.co.uk> writes: > @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE > IDS_AVIFILETYPE "Wine AVI-default-filehandler" > IDS_UNCOMPRESSED "uncompressed" > } > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > +/* Same as SUBLANG_DEFAULT */ If they are the same there's no reason to duplicate them. Also you should never submit 60 patches in one go; 10-15 is the maximum for a patch series, and that's only if you are absolutely confident that they are correct. Otherwise send only a couple until you are sure to get it right on the first try. -- Alexandre Julliard julliard(a)winehq.org

5 9

Gcov and PGO
by Peter Davies June 15, 2010

June 15, 2010

After applying my "[RESEND 2] Changes to enable the use of gcov and PGO" patch To use gcov: Run "make EXTRACFLAGS=--coverage LDFLAGS=--coverage" Run program (presumably test suite) Run "gcov file.c" (multiple files like "gcov *.c" doesn't work for some reason) To use PGO Run "make EXTRACFLAGS=-fprofile-generate LDFLAGS=-fprofile-generate" Run sample program (test suite is inappropriate because it doesn't represent normal usage). Run "make clean" Run "make EXTRACFLAGS=-fprofile-use LDFLAGS=-fprofile-use" Peter

1 0

Re: propsys: mention that the functions are stubs
by Hans Leidekker June 15, 2010

June 15, 2010

On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > Hans might have missed that No, to me a fixme that prints a parameter list without further explanation implies that the function is a stub.

5 8

Re: [PATCH 2/2] winspool/tests: Test GetPrinterData/Ex for the printspooler
by testbot＠testbot.winehq.org June 15, 2010

June 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2673 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [8/9] setupapi: Only extract the first MSZIP cabinet file in SetupDecompressOrExtractFile.
by Alexandre Julliard June 15, 2010

June 15, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1458,24 +1458,25 @@ static DWORD decompress_file_lz( LPCWSTR source, LPCWSTR target ) > > static UINT CALLBACK decompress_or_copy_callback( PVOID context, UINT notification, UINT_PTR param1, UINT_PTR param2 ) > { > + static int has_extracted; > + This is not reentrant. Also you need to point out which bugs these patches are fixing that justifies putting them in during code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Changes to enable the use of gcov
by James McKenzie June 15, 2010

June 15, 2010

Peter Davies wrote: > To use gcov you must pass --coverage at both compile and link time. > This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", "make test", > "gcov file.c" is sufficient generate .gcov files. > > Peter: Somehow this patch got munged in transit and will not apply to current git. Can you update it and send it again? James McKenzie

3 2

New Wine stuff in FreeWear.org
by Ismael Barros² June 15, 2010

June 15, 2010

Hello, We have decided to renew our offer of Wine T-shirts, as the current T-shirt has had mostly no success at all, probably because users don't feel identified nor appealed with the design. I'm attaching the pdf with our new proposals (we hope you like them!). We decided to offer the design in black garment, as in our experience it works much better. We want to be transparent, so I'm attaching also a spreadsheet with our expenses, donations and profits for each model. We usually collaborate with FOSS events, sending them stuff from our catalogue for its sale on the event. In these cases, we make a double donation: one to the organization of the event (higher, as they are in charge of the sales) and another one to the corresponding FOSS organization for the sold article. You can see the details in the spreadsheet. If you have no objection, we'll send Wine stuff to the event that require it. Currently, almost all organizations we work with have us linked from their website. This helps boosting the sales, and therefore the donations, so that everybody wins. We would be very glad if we could get a link somewhere at winehq.org, or alternatively a news item, which for us has the downside of having a limited front-page life-span, but works nonetheless. We hope you like and approve the design. Suggestions are welcome. When the design is approved, we'll upload it to our website. Kind regards, Ismael

2 2

Re: [PATCH] atl: allow additioanl struct size on 64bit and test for it
by Alexandre Julliard June 15, 2010

June 15, 2010

Marcus Meissner <marcus(a)jet.franken.de> writes: > Testruns show that on 32bit we have 100 and 132 as struct size, > while on 64bit we have 176, 240, and also 248. > > See this page for a loop from 1..300: > https://testbot.winehq.org/JobDetails.pl?Key=2643 So why aren't you doing that loop in the final test? As it is, it doesn't really prove anything. Also please use sizeof and friends instead of hardcoded numbers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Updating the 1.2 release announcement text
by Dan Kegel June 15, 2010

June 15, 2010

http://wiki.winehq.org/Wine1.2Announcement could use some work if anyone has time...

4 4

Re:Anotated 'make test' log
by Max TenEyck Woodbury June 15, 2010

June 15, 2010

Thank you Dan. > What problem are you trying to solve? Curing my ignorance and rebuild my self-confidence. :) > I gather you're just plowing through the output of 'make test', > looking at each bit of noise, and trying to figure out a way > to improve the tests? Sort of. I needed a place to start, so I started at the top of the log. I expect that to change once I become more sure that I have the mechanics correct. There are several things I'm trying to do. First is to find the place where each 'bit of noise' is generated. I seem to be doing that right. Then I look at why the noise was generated and to show that I've understood why, I wrote a note on how the 'noise' could be turned off without changing the test. I labelled these 'fixup:'. I then looked at the test code and added 'Note:'s where I thought the test could be improved. > While that's a noble quest, and I'd like to encourage people > to improve the tests, it might be more productive to do so > around areas of pain for users. > For instance, you could look at bugs in bugzilla that have > patches attached that aren't committed yet because tests are > needed, and write those tests. > - Dan That sounds useful. I also have a few issues I'd like fixed too. However, it's been more than five years since I've done serious coding; things happened that destroyed my self-confidence. A little reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. - Max

1 0

Inviting users to look for regressions in wine-1.2rc3?
by Dan Kegel June 15, 2010

June 15, 2010

How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. The thread about Wylda's statistics reminded me about http://wiki.winehq.org/PlatinumRegressionHunt We mentioned that in the first 1.0 rc announcement: http://www.winehq.org/announce/1.0-rc1 but not in http://www.winehq.org/announce/1.2-rc1 How 'bout we mention it in the rc4 release announcement and/or blogs?

8 10

Re: Two enhancement requests for winetricks
by James Mckenzie June 15, 2010

June 15, 2010

Jan Hoogenraad <jan-winehq(a)h-i-s.nl> Jun 14, 2010 8:05 AM wrote: >OK. New version of the script: it also finds uppercase filename matches. >It also removed: > > 131072 1999-01-15 04:37 system32/MAPISTUB.DLL > 70656 2008-10-06 23:30 system32/MSVCIRT.DLL > 326656 2008-10-06 23:30 system32/MSVCRT40.DLL > 492304 2008-10-06 23:30 system32/OLEAUT32.DLL These are the files that Wine creates. You may have broken your Wine install now. OLEAUT32.DLL contains partial code that links to a file OLEAUT32.dll.so in the /usr/lib directory (or the file should be there.) James McKenzie

2 2

Re: msvcrt: Add _wmakepath_s implementation
by testbot＠testbot.winehq.org June 15, 2010

June 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2647 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

RFC: Standardize paths in shell32.SHChangeNotify [Bug 18606]
by Andrew Eikum June 14, 2010

June 14, 2010

Hey folks, I have a fix here for bug 18606. I think it's decent, but I could use another few sets of eyes to make sure I didn't miss anything, or even that I'm not way on the wrong track. The problem and solution are described in patch 3. In brief, SHChangeNotify notifies windows when a change to the filesystem occurs that the window asked to be notified about. For example, a window might tell SHChangeNotifyRegister "Inform me about changes to C:\". Bug 18606 occurs because the new directory is passed to SHChangeNotify as '/home/user/.wine/drive_c/New Directory', which doesn't match the IDList created for 'C:\'. This patchset fixes that by converting all paths in SHChangeNotify to UNIX paths, resolving symlinks etc, and comparing the ID lists created from those paths. That way, the paths being compared are standardized and compared fairly. Unfortunately, this is hard to write tests for. You'd have to make an ID list that is significantly different from the one SHChangeNotifyRegister will create, but that actually refers to the same directory. This is easy in Wine, but less obvious in Windows. Suggestions for how to accomplish this are welcome. Logically, though, I think the problem and solution make sense. Please take a look. Any feedback is appreciated. Andrew

1 0

Portuguese translations of Wine back at 100%
by Paul Vriens June 14, 2010

June 14, 2010

Hi, Just a note to thank Ricardo for getting the Portuguese translations back to 100%. -- Cheers, Paul.

1 0

Polish translations of Wine at 100%
by Paul Vriens June 14, 2010

June 14, 2010

Hi, Łukasz did it, Polish translations of Wine reached the 100% mark !!! Great job done. -- Cheers, Paul.

1 0

Make depend
by Peter Davies June 14, 2010

June 14, 2010

How often do I need to run "make depend"? Peter

4 4

Re: mshtml: Check if event_table entry is allocated before using it in remove_event_handler.
by testbot＠testbot.winehq.org June 14, 2010

June 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2632 Your paranoid android. === W2K3R2SESP2 (32 bit events) === events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 === W7PRO (32 bit events) === events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 === W7PROX64 (32 bit events) === events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 === W7PROX64 (64 bit events) === events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0

1 0

Re: [2/2] msi: Add tests for MsiLocateComponent and make them pass.
by testbot＠testbot.winehq.org June 14, 2010

June 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2626 Your paranoid android. === W7PROX64 (32 bit msi) === msi.c:1622: Test failed: Expected C:\imapath, got msi.c:1629: Test failed: Expected C:\imapath, got msi.c:1648: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1649: Test failed: Expected C:\imapath, got msi.c:1650: Test failed: Expected 10, got 260 msi.c:1655: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1656: Test failed: Expected C:\imapath, got msi.c:1657: Test failed: Expected 10, got 260 msi.c:1666: Test failed: Expected C:\imapath, got msi.c:1672: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1673: Test failed: Expected C:\imapath, got msi.c:1674: Test failed: Expected 10, got 260 msi.c:1712: Test failed: Expected C:\imapath, got msi.c:1719: Test failed: Expected C:\imapath, got msi.c:1738: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1739: Test failed: Expected C:\imapath, got msi.c:1740: Test failed: Expected 10, got 260 msi.c:1745: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1746: Test failed: Expected C:\imapath, got msi.c:1747: Test failed: Expected 10, got 260 msi.c:1756: Test failed: Expected C:\imapath, got msi.c:1762: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1763: Test failed: Expected C:\imapath, got msi.c:1764: Test failed: Expected 10, got 260 msi.c:1822: Test failed: Expected C:\imapath, got msi.c:1829: Test failed: Expected C:\imapath, got msi.c:1848: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1849: Test failed: Expected C:\imapath, got msi.c:1850: Test failed: Expected 10, got 260 msi.c:1855: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1856: Test failed: Expected C:\imapath, got msi.c:1857: Test failed: Expected 10, got 260 msi.c:1866: Test failed: Expected C:\imapath, got msi.c:1872: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1873: Test failed: Expected C:\imapath, got msi.c:1874: Test failed: Expected 10, got 260 msi.c:1931: Test failed: Expected C:\imapath, got msi.c:1937: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1938: Test failed: Expected C:\imapath, got msi.c:1939: Test failed: Expected 10, got 260 msi.c:1948: Test failed: Expected C:\imapath, got msi.c:1954: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1955: Test failed: Expected C:\imapath, got msi.c:1956: Test failed: Expected 10, got 260 msi.c:2008: Test failed: Expected C:\imapath, got msi.c:2014: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:2015: Test failed: Expected C:\imapath, got msi.c:2016: Test failed: Expected 10, got 260 msi.c:2025: Test failed: Expected C:\imapath, got msi.c:2031: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:2032: Test failed: Expected C:\imapath, got msi.c:2033: Test failed: Expected 10, got 260 msi.c:2129: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2147: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2162: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2177: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2195: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2224: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2242: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2257: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2272: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2290: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2371: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2377: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2401: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2408: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2442: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2471: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2478: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:7467: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7536: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7603: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7827: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7829: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7888: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7906: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7924: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7926: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7942: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7944: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7961: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7963: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7982: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7984: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8001: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8003: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8119: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8121: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8166: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8168: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8192: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8194: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7827: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7829: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7888: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7906: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7924: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7926: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7942: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7944: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7961: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7963: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7982: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7984: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8001: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8003: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8119: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8121: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8166: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8168: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8192: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8194: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7827: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7829: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7888: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7906: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7924: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7926: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7942: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7944: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7961: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7963: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7982: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7984: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8001: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8003: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8119: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8121: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8166: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8168: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8192: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8194: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8445: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8447: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8567: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8569: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8614: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8616: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8640: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8642: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8445: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8447: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8567: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8569: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8614: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8616: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8640: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8642: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8937: Test failed: Expected patchcode to be unchanged, got {2B8A9453-54F5-4090-A3A4-951258440C67} msi.c:8939: Test failed: Expected targetprod to be unchanged, got {A549CAF1-986B-4834-AD1A-3744EFAB33EC} msi.c:9008: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9010: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9053: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9055: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9599: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9642: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9819: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple"

1 0

Re: [PATCH] atl: Do not fail on Wine64
by Maarten Lankhorst June 14, 2010

June 14, 2010

Hi Marcus, 2010/6/13 Marcus Meissner <marcus(a)jet.franken.de>: > Hi, > > The size is 248 on Wine64 ... (expected 240), so we miss > perhaps a pointer or some alignment. > > Its not fully clear what. > > It at least does not crash when ignoring the size change. Seems wrong to me, does it allow size 240 on 64-bits, or does it allow 248 only? ~Maarten

3 2

RE: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()
by Greg Geldorp June 14, 2010

June 14, 2010

> From: Reece Dunn <msclrhd(a)googlemail.com> > > msxml3 is not present on NT4, so CLSID_XMLHTTPRequest is not > registered. This does not fail on the test page, as the msxml3 tests > are skipped when msxml3.dll is not present. > > It would probably be better to issue a win_skip in this instance, but > it is not relevant to your change. TestBot uses a different algorithm to check if a test should be skipped. Winetest.exe checks the name of the test and obtains the name of the DLL being tested from that (msxml3_test.exe => msxml3.dll). If that DLL is not present, winetest.exe skips the test. TestBot checks the import table of the test executable, and if any of the statically imported DLLs are missing it skips the test. In this case, msxml3.dll is not statically linked, so it will not be skipped by TestBot on NT4. TestBot should probably check the test name too. Ge.

1 0

Two enhancement requests for winetricks
by Joerg-Cyril.Hoehle＠t-systems.com June 14, 2010

June 14, 2010

Hi, Jan Hoogenraad wrote: >Each debugging request for wine states that I should remove all winetricks. AppDB should request something similar: minimal use of winetricks. >However I have no way to tell, and no way to safely remove them. IMHO one solution to your problem is to learn to use different .wine prefixes. Both developers and AppDB users want a repeatable process to make the app run (or crash). If you install all your software into a single .wine hierarchy (like you'd do on MS-Windows), then you cannot tell anyone what you did to make the app work in Wine. All you have is "I started with Wine-0.9.48, upgraded to wine-1.1.6 at some time, now to wine-1.2rc2, used "winetricks X" and Y, perhaps I used "winetricks directx" but I can't remember for sure, I installed apps A, B and C (they may have installed more components) and I edited the registry a few times. Given all that, app Z works fine in on my machine." This is a mess much like a typical MS-Windows installation. With Wine, you can do better than that. What people want to hear from you is as follows: - Create a fresh .wine prefix with wine-X.Y; - Install Indeo Video codecs via "winetricks indeo" because I found out that the app expects them but does not install them itself; - Install the app from CD; - From a DirectX install into a separate .wine-* prefix, solely copy d3dx9_36.dll into system32/ (or the app's directory) - Change setting Y in winecfg, e.g. native d3dx9_36; - App Z works (or crashes like that ...). That is a minimal instruction set. I have like a dozen .wine-* directory hierarchies. I never use .wine itself except for regression testing, such that I can rm -rf ~/.wine and create a fresh one at any time. That's why I don't need an uninstaller. rm -rf ~/.wine-xyz or rm -rf ~/wineapps/... *is* the uninstaller (.wine-xyz/drive_c/Programs/Apps/ symlinks to $HOME/wineapps such that the apps live independently on a particular .wine prefix). Regards, Jörg Höhle

3 2

Re: [PATCH 4/6] shdocvw: Silence QueryService traces in non-interactive runs.
by testbot＠testbot.winehq.org June 14, 2010

June 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2620 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === Timeout === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:295: Test failed: unexpected nsCmdID 28

1 0

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()
by testbot＠testbot.winehq.org June 13, 2010

June 13, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2617 Your paranoid android. === WNT4WSSP6 (32 bit domdoc) === domdoc.c:2743: Test failed: CoCreateInstance(CLSID_XMLHTTPRequest) should have succeeded instead of failing with 0x80040154

3 2

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph
by Austin English June 13, 2010

June 13, 2010

On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > This is patch 1/4 to implement EM_FORMATRANGE. This patch does not change > any of the code but moves code from ME_WrapMarkedParagraphs to > ME_WrapTextParagraph. > > The bug report #6254, which this is a solution to is marked as needed for > Wine 1.2 > > Thanks to Dylan Smith who helped segegrate and clean up the original code > proposed by Tony Rollo and further worked on by Lei Zhang and myself. You forgot the patch. -- -Austin

2 1