June 2010 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

Two enhancement requests for winetricks
by Dan Kegel Feb. 21, 2011

Feb. 21, 2011

OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

6 11

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Wine runs IE7!
by Hans Leidekker Nov. 26, 2010

Nov. 26, 2010

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 21, 2010

Oct. 21, 2010

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Wine without X? Failing in dlls/winex11.drv
by Gerald Pfeifer Sept. 19, 2010

Sept. 19, 2010

Trying to build Wine on a new tester which initially had too few packages installed I ran into the following. In file included from bitblt.c:33: x11drv.h:30:22: error: X11/Xlib.h: No such file or directory x11drv.h:31:27: error: X11/Xresource.h: No such file or directory x11drv.h:32:23: error: X11/Xutil.h: No such file or directory x11drv.h:33:23: error: X11/Xatom.h: No such file or directory x11drv.h:44:21: error: X11/Xmd.h: No such file or directory x11drv.h:45:24: error: X11/Xproto.h: No such file or directory Indeed include/config.h has HAVE_X11_XLIB_H undefined since, well, all these headers indeed are missing. On the other hand, configure did not halt. In fact, configure did not even warn about this situation unlike it does in other cases. How to fix this? Should dlls/winex11.drv just not be built in such a case? Should configure error out? (We do have --without-x, too, though.) Anything else? Currently we do pass configure and then run into a compile failure later on. Gerald

3 3

autoconf 2.62 failure due to AS_VAR_IF
by Gerald Pfeifer Sept. 19, 2010

Sept. 19, 2010

Using autoconf 2.62 on my primary test system I am getting: configure:26081: error: possibly undefined macro: AS_VAR_IF Indeed use of AS_VAR_IF appears relatively new, and it seems this may be similar to AS_VAR_APPEND where we have the following in configure.ac: dnl autoconf versions before 2.63b don't have AS_VAR_APPEND m4_ifdef([AS_VAR_APPEND],,[as_fn_append () { eval $[1]=\$$[1]\$[2]; } AC_DEFUN([AS_VAR_APPEND],[as_fn_append $1 $2])])dnl I assume we need something similar here, too? I am really far from an autoconf hacker -- is this something one of you could look into? Gerald

1 1

Re: Remove code which has been #if 0-ed for 11 years from DOSCONF_Device and DOSCONF_Install. (RESEND)
by Alexandre Julliard Sept. 19, 2010

Sept. 19, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > An alternate patch would be putting #if 0 around the first occurrence > of loadhigh, too, but this code has been marked dead for more than 11 > years, so I really think it can / should go? It doesn't make sense to parse and not do anything with it. If you want to remove dead code you can remove essentially the entire file. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Use GCC's -Wlogical-op if possible
by Austin English Sept. 19, 2010

Sept. 19, 2010

On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer<gerald(a)pfeifer.com> wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep close > an eye on this and to address any issues proactively as part of my nightly > test builds. > > Gerald > > ChangeLog: > Use GCC's -Wlogical-op if possible. > > diff --git a/configure.ac b/configure.ac > index bef311e..3f7a657 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1385,8 +1385,9 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > - WINE_TRY_CFLAGS([-Wwrite-strings]) > + WINE_TRY_CFLAGS([-Wlogical-op]) > WINE_TRY_CFLAGS([-Wtype-limits]) > + WINE_TRY_CFLAGS([-Wwrite-strings]) > > dnl Check for noisy string.h > saved_CFLAGS="$CFLAGS" > > > Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ‘&&’ with non-zero constant will always evaluate as true cert.c:1627: warning: logical ‘||’ with non-zero constant will always evaluate as true -- -Austin

8 18

Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet
by Eric Pouech Aug. 30, 2010

Aug. 30, 2010

Paul Bolle a écrit : > Add support for the qAttached packet. Main benefit is that if gdb was > attached to a debuggee and it quits it will now ask if it should detach > from the debuggee instead of asking whether the debuggee should be > killed. (It still will ask whether the debuggee should be killed if it > launched the debuggee itself). > > Signed-off-by: Paul Bolle <pebolle(a)tiscali.nl> > --- > Would it be better to add a new member to gdbctx instead of using a > separate variable (qAttached_reply)? > yes, inclusion in gdbctx is preferred (and storage should rather be an integer rather than a string pointer) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: [PATCH 2/3] winex11.drv: set global key state
by Alexandre Julliard Aug. 18, 2010

Aug. 18, 2010

Rafał Miłecki <zajec5(a)gmail.com> writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | key_state_table[wVkR]; > } > > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVk; > + req->state = key_state_table[wVk]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVkStripped; > + req->state = key_state_table[wVkStripped]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + You don't want to add 2 extra server calls for every key, especially since the server already receives the necessary information through the key event. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: comctl32: Simplify is_textT by omitting isW.
by Nikolay Sivov Aug. 15, 2010

Aug. 15, 2010

On 5/9/2010 16:43, Gerald Pfeifer wrote: > isW is not actually used by is_textT, so we can simplify listview.c a > bit by omitting the useless parameter. > > > > -static inline BOOL is_textT(LPCWSTR text, BOOL isW) > +static inline BOOL is_textT(LPCWSTR text) > > There's no reason to keep this helper then. It's better to rename is_textW() to is_text() and remove is_textT().

2 1

Re: gdi32: use usp10 to optionally generate glyphs for bidi strings
by Dmitry Timoshkov Aug. 8, 2010

Aug. 8, 2010

Aric Stewart <aric(a)codeweavers.com> wrote: > allows us to be able to make use of the mirroring code and eventually > the shaping code when it is in place. This should be done the other way around. gdi32 should not depend on a high level dll (that creates circular dependencies), gdi32 in Windows doesn't use usp10 either. -- Dmitry.

4 5

re: Anotated 'make test' log
by Dan Kegel July 18, 2010

July 18, 2010

What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive to do so around areas of pain for users. For instance, you could look at bugs in bugzilla that have patches attached that aren't committed yet because tests are needed, and write those tests. - Dan

4 6

xrender.c is does not find fontconfig.h on OS X Tiger
by Mike Kronenberg July 12, 2010

July 12, 2010

Dear List OS X Tiger does has not have fontconfig, so I'm building it in ~/buildwine/usr to keep it out of /usr. I include the headers and libs from ~/buildwine/usr with CPPFLAGS and CFLAGS. This worked fine until 1.2-rc1 and 1.2-rc2. Compiling xrender.c now exits with an error that FC_WEIGHT_THIN etc is not defined. configure leaves me with SONAME_LIBFONTCONFIG='libfontconfig.1.dylib' FONTCONFIGINCL='' in the config.log. No luck even if I export FONTCONFIGINCL="-I//$HOME/buildwine/usr/include/fontconfig -I//$HOME/buildwine/usr/include' which resulted in a correct FONTCONFIGINCL, but the compiling still failed. All the other custom compiled deps are working as usual. Any hint what I might missing? txs Mike

2 2

re: Yagmark and localized Windows
by Dan Kegel July 5, 2010

July 5, 2010

I'd love to have yagmark be more internationalized. I did try to use button codes rather than english strings in wisotool, but sometimes it wasn't possible, and sometimes I didn't try hard enough. Not sure if I tried at all in yagmark yet. According to http://www.autohotkey.com/docs/commands/SetTitleMatchMode.htm Autohotkey supports regular expressions, so for the matching strings that can't be changed to button codes, we could list a bunch of alternatives, e.g. Save As|Enregistrer Sous Then the remaining mess is when we have to send a keystroke, we might need a switch statement to decide which keystroke to send based on the language. For the purposes of benchmarking wine, just setting LANG=en_US.UTF-8 solves the problem, but that doesn't help when you're trying to benchmark Windows. - Dan

5 9

Please review: Patch for non-Linux serial set_baud_rate()
by Ken Thomases July 4, 2010

July 4, 2010

Hi, I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems clearly right and conforms to what I learn from man pages, etc. So, I'm hoping somebody who is more familiar with this functionality can review the attached patch before I formally submit it. Another approach that seems better from my reading of the man pages is to switch to using cfsetspeed() [or cfsetospeed() and cfsetispeed()] instead of having separate branches based on defined(CBAUD). But maybe that has portability problems worse than the current approach. Thanks, Ken

2 2

TRACE () documentation
by James McKenzie July 4, 2010

July 4, 2010

All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you. James McKenzie

4 8

Addition of En resources to non-En resources
by Frédéric Delanoy July 2, 2010

July 2, 2010

Sometimes, when a developer adds a string to En resource file, (s)he adds it as well to all other non-En resource files. Isn't that unnecessary? http://wiki.winehq.org/SublangNeutral says the search order is 1. LANG_NEUTRAL, SUBLANG_NEUTRAL 2. LANG_FRENCH, SUBLANG_FRENCH_BELGIAN 3. LANG_FRENCH, SUBLANG_NEUTRAL 4. LANG_ENGLISH, SUBLANG_ENGLISH_US Would a patch removing En resources in non En rc files be accepted? This would allow for more accurate translation stats. Or doesn't a fallback mechanism always apply? Frédéric

8 25

Re: (Resent) Documentation - Reference to MSDN?
by James Mckenzie July 2, 2010

July 2, 2010

Alexandre Julliard <julliard(a)winehq.org> wrote: > >Erich Hoover <ehoover(a)mines.edu> writes: > >> Alright, well then I won't do it. Is the existing documentation going >> to be stripped at some point? It seems to me like we would benefit >> from more-detailed function descriptions in the auto-generated API >> documentation. I think it would save a lot of time for new developers >> to get their feet wet if they were able to see directly in the source >> what the different functions are supposed to do (as best as we know) >> and exactly what applications will trigger known edge cases (or if >> there's a test for a given situation). > >That's what the source code and test cases are for. If you rely on the >function documentation you are in trouble anyway, nobody bothers to >update it when new behaviors are discovered. > >If you really want to write good API documentation, as opposed to the >current useless one-sentence-per-parameter description, you'd need >probably a text 10 times the size of the source code for each >function. That can't go in the source files. > How about some place on the Wiki along with an implementation status. That way we can also annotate items that are missing in MSDN (I just re-stumbled across something in my latest Richedit tests) as well. This would help greatly in our progress towards current and future implementations of the Windows API. And I agree, adding all of this to the source would make it unwieldy. James McKenzie

5 7

Documentation - Reference to MSDN?
by Max TenEyck Woodbury July 2, 2010

July 2, 2010

I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation) so I have a couple of questions: 1) Would including the URL of the MSDN article be useful/a good idea? 2) Would enumerating coded values and flags be allowed? 3) Where should data structures be documented?

3 2

(Resent) Documentation - Reference to MSDN?
by Max TenEyck Woodbury July 1, 2010

July 1, 2010

I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation) so I have a couple of questions: 1) Would including the URL of the MSDN article be useful/a good idea? 2) Would enumerating coded values and flags be allowed? 3) Where should data structures be documented?

9 17

Creating tests with additional binary modules
by Mariusz Pluciński July 1, 2010

July 1, 2010

Hi, wine-devel I'm working on implementation of Windows Game Explorer interfaces for Wine. The work is in advanced stage now, but I have problem with implementation of conformance tests. Thing I want to test is loading and parsing so-called Game Definition Files. GDF are not separate files, but stored as resources in binary modules (usually in game's main executable). Using GE interfaces, programmer only needs to pass path to binary, and GE automatically loads and process embedded GDF(s). Checking results of routines execution is not problem for me. But thing I test is parser, so I need to pass various GDF files to routine. And, as GDFs are stored in binaries, I will need to create many binaries. They should be created in compile time and available for test's executable while running it. The problem is that I don't know how to do this using wine's mechanisms. How should Makefile.in file look to build additional executable files properly (they should be probably always native win32 executables, even if parameter "crosstest" wasn't specified)? How should I guarantee that these additional executables will be copied into winetest directory (to make them accessible while executing tests)? Thanks in advance Mariusz Pluciński

5 8

updating spec files - which windows version to use?
by Austin English July 1, 2010

July 1, 2010

Howdy, I was looking at http://bugs.winehq.org/show_bug.cgi?id=23421, and wanted to add a stub for it. Using winedump on a Windows 7 shlwapi.dll gives different exports than Windows XP SP3 shlwapi.dll. Which dll should the spec file be updated to match? I'm assuming the latest and greatest, since eventually applications will head that direction. An additional related question. Some of the functions that are ordinals in previous Windows versions are now exported (e.g., ParseUrlA/W seems to have been documented/exported since Vista). Should the spec file be adjusted to match the newer behavior? I'm assuming this will have to wait until after 1.2 to be applied... Thanks! Austin

2 1

Re: [tools/wine.desktop] Add czech translation
by Nikolay Sivov June 30, 2010

June 30, 2010

On 7/1/2010 02:20, Scott Ritchie wrote: > Translation by Sven Augustin > @@ -20,7 +21,12 @@ Name[sr]=Wine - аДаИаЗаАб� Windows аПб�аОаГб�аАаМаА > Name[sr(a)latin]=Wine - dizaФ� Windows programa > Name[hr]=Wine - dizaФ� Windows programa > Exec=wine start /unix %f > +<<<<<<< HEAD > MimeType=application/x-ms-dos-executable;application/x-msi;application/x-win-lnk;application/x-ms-shortcut > +======= > +MimeType=application/x-ms-dos-executable;application/x-msi;application/x-win-lnk; > +>>>>>>> tools/wine.desktop: add Icon=wine to support systems with an icon theme > Icon=wine > NoDisplay=true > StartupNotify=true > + Conflicts?

2 1

Re: (Resent) Documentation - Reference to MSDN?
by James Mckenzie June 30, 2010

June 30, 2010

Erich Hoover <ehoover(a)mines.edu> wrote: >Sent: Jun 30, 2010 12:43 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Alexandre Julliard <julliard(a)winehq.org>, Max TenEyck Woodbury <max(a)mtew.isa-geek.net>, wine-devel(a)winehq.org >Subject: Re: (Resent) Documentation - Reference to MSDN? > >On Wed, Jun 30, 2010 at 1:36 PM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> ... >> How about some place on the Wiki along with an implementation status. That way we can also annotate items that are missing in MSDN (I just re-stumbled across something in my latest Richedit tests) as well. This would help greatly in our progress towards current and future implementations of the Windows API. >> >> And I agree, adding all of this to the source would make it unwieldy. >> > >So something like "http://wiki.winehq.org/WineAPI/<DLL>/<Function>" ? >If that's acceptable I would not mind a system like that, especially >if the links of documented functions are provided in the source. >Documenting these things is a lot of work, so I'm not about to run off >and do all that work if no-one is ever going to take advantage of it. > +1 Acceptable variables should be listed in an order other than the one on MSDN. We don't want a direct copy, but rather OUR findings using the old 'black box' method. James McKenzie

1 0

Re: add russian translation for winerrs messages [try2]
by Dmitry Timoshkov June 30, 2010

June 30, 2010

Vitaly Lipatov <lav(a)etersoft.ru> wrote: > +LanguageNames=(RUS=0x19:winerr) > +CodePages=(FRA=65001:0) 'FRA'? This doesn't look correct. -- Dmitry.

3 3

Re: user32: Recurse into WS_EX_CONTROLPARENT controls in GetDlgItem
by Dmitry Timoshkov June 30, 2010

June 30, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > This fixes bug 22862 which blocks bug 12804 (1.2) > We already do a similar recursion in DEFDLG_FindDefButton and GetNextDlgGroupItem > > I didnt found any other changes in the tests... i expected some more "Test succeeded inside todo block" You need to add explicit tests for GetDlgItem() inside of user32/tests. -- Dmitry.

1 0

Re: user32/tests: Use if(0) instead of a comment to make sure code still compiles
by testbot＠testbot.winehq.org June 29, 2010

June 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3023 Your paranoid android. === W7PRO (32 bit msg) === msg.c:9516: Test failed: wrong qstatus 00110011 msg.c:9523: Test failed: wrong qstatus 00190008 msg.c:9529: Test failed: wrong qstatus 00390020 msg.c:9538: Test failed: wrong qstatus 00790040 msg.c:9559: Test failed: wrong qstatus 00390000 msg.c:9567: Test failed: wrong qstatus 00790040 msg.c:9578: Test failed: wrong qstatus 00390000 msg.c:9589: Test failed: wrong qstatus 00310000 msg.c:9594: Test failed: PeekMessageA should have returned FALSE instead of msg 0113 === W7PROX64 (64 bit msg) === Timeout

1 0

Re: wininet: fix the handling of insufficient buffers in InternetGetCookie*()
by testbot＠testbot.winehq.org June 29, 2010

June 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3020 Your paranoid android. === W98SE (32 bit internet) === internet.c:440: Test failed: A=B present internet.c:442: Test failed: E=F present internet.c:444: Test failed: I=J present internet.c:445: Test failed: K=L present internet.c:452: Test failed: A=B present internet.c:454: Test failed: E=F present internet.c:456: Test failed: I=J present internet.c:457: Test failed: K=L present internet.c:1158: Test failed: Retrieved proxy server should've been L"proxy.example", was: L"\0001\a000\2684X\0fb4h\0200" internet.c:1164: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1192: Test failed: Retrieved flags should've been PROXY_TYPE_DIRECT, was: 5767180 internet.c:1195: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1222: Test failed: Retrieved flags should've been PROXY_TYPE_PROXY | PROXY_TYPE_DIRECT, was: 5767180 internet.c:1225: Test failed: Expected regtype to be REG_DWORD, was: 3 === W2KPROSP4 (32 bit internet) === internet.c:440: Test failed: A=B present internet.c:442: Test failed: E=F present internet.c:444: Test failed: I=J present internet.c:445: Test failed: K=L present internet.c:452: Test failed: A=B present internet.c:454: Test failed: E=F present internet.c:456: Test failed: I=J present internet.c:457: Test failed: K=L present === WXPPROSP3 (32 bit internet) === internet.c:517: Test failed: bad last error {error = 122} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === WVISTAADM (32 bit internet) === internet.c:517: Test failed: bad last error {error = 122} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W2K8SE (32 bit internet) === internet.c:517: Test failed: bad last error {error = 122} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W7PRO (32 bit internet) === internet.c:474: Test failed: bad last error {error = 5023} internet.c:502: Test failed: bad last error {error = 5023} internet.c:517: Test failed: bad last error {error = 5023} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W7PROX64 (32 bit internet) === internet.c:474: Test failed: bad last error {error = 5023} internet.c:502: Test failed: bad last error {error = 5023} internet.c:517: Test failed: bad last error {error = 5023} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122} === W7PROX64 (64 bit internet) === internet.c:474: Test failed: bad last error {error = 5023} internet.c:502: Test failed: bad last error {error = 5023} internet.c:517: Test failed: bad last error {error = 5023} internet.c:545: Test failed: the function failed internet.c:546: Test failed: bad last error {error = 122}

1 0

Using string resources in conformance tests.
by Michael Mc Donnell June 29, 2010

June 29, 2010

Hi wine developers! I've written a conformance test (my first) for bug 17986: BrsFolder_OnCommand make new folder not implemented. The conformance test tests if clicking on the "Make New Folder" button in a SHBrowseForFolder dialog box results in creation of a new folder. I want the test to be localized and work across all newer versions of Windows, but I'm having trouble with it. I use the LoadString function to get the "New folder" string from shell32.dll that is used for creating a new folder. The problem is that the location where it is stored in shell32.dll varies between the different versions of Windows. I can only make the test work on one version at a time. Even the capitalization varies between the different versions of Windows, i.e. "New Folder" vs. "New folder". My question is how should we handle a problem like the one mentioned above? Should we avoid using string resources in conformance test, or should we try to handle the version issues? One solution would be to hard code the string instead of loading it from a resource. This would, however, mean that the test would be skipped on all non-English versions of windows, and it would additionally have to ignore the capitalization differences. Another solution would be to get the string according to the version of Windows. This would, however, pose a problem in wine because it does not emulate any specific Windows version. The location of the string in wine's shell32.dll does not match any version of Windows, and we would therefore also have to detect if the test is running on wine. Has anyone bumped into the same problem, or does anyone know a thread about this on wine-devel? Do you have any comments on what to do? Thanks, Michael Mc Donnell

2 2

Re: [2/2] urlmon: implement HlinkSimpleNavigateToMoniker
by Jacek Caban June 29, 2010

June 29, 2010

On 6/28/10 9:17 PM, André Hentschel wrote: > --- > dlls/urlmon/umon.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c > index e122e07..12b1b0c 100644 > --- a/dlls/urlmon/umon.c > +++ b/dlls/urlmon/umon.c > @@ -734,8 +734,12 @@ HRESULT WINAPI HlinkSimpleNavigateToMoniker(IMoniker *pmkTarget, > LPCWSTR szLocation, LPCWSTR szTargetFrameName, IUnknown *pUnk, > IBindCtx *pbc, IBindStatusCallback *pbsc, DWORD grfHLNF, DWORD dwReserved) > { > - FIXME("stub\n"); > - return E_NOTIMPL; > + URLMoniker *This = MONIKER_THIS(iface); You can't do this. There is no guaranty that the moniker is URL moniker. Jacek

1 0

The WINE Project should solicit grants to hire professional developers
by Richard Yao June 29, 2010

June 29, 2010

Dear All: I am a senior undergraduate applied mathematics/computer science student and this year, I migrated from Windows 7 to Gentoo Linux on my computers. I tried using Linux alternatives to many applications I used on Windows, but not all software has good alternatives, so I have been using WINE for certain things. The WINE project's accomplishments so far have been extremely impressive, but at the same time, WINE's implementation of the Windows API is deficient in many ways and I think that the WINE project will need to improve its own organization before progress toward true API parity with Windows can be made. I can divide WINE's development resources into two groups, volunteer and professional. The volunteer group is predominantly focused on games.The professional group is comprised of CodeWeavers and Google. CodeWeavers does what its customers want it to do, and as such, it has a large focus on games. Google on the other hand, paid CodeWeavers to make some improvements to WINE, mostly for Picasa, but also for Adobe Photoshop CS2, the reason for which I cannot imagine. Google also has its annual Summer of Code program. Each source of manpower has its own special interest and I do not believe that WINE will ever obtain any kind of API parity with Windows as long as this remains the case. With these things in mind, I would like to propose that the WINE project solicit grants from charitable organizations so that it could hire professional developers to augment its existing resources, specifically in the areas for which special interests could care less. If the Wine project could solicit sufficient funding to hire a few dozen developers for a period of several years, then I think that having WINE become as good as Windows would enter the realm of possibility. I know that many people will laugh at my suggestion (especially when they read the organization I suggest that the WINE project contact), but as far as I can tell, the WINE project has not solicited grants to be able to hire professional developers and I think that failing to solicit such grants places a handicap on the WINE project. There exist charitable organizations that seek to fund solutions to "global problems that are ignored by governments and other organizations" (as stated in Wikipedia). Because enabling Windows programs to run on free UNIX operating systems would reduce the cost of computing for all people, including those in third world countries, I am certain that such organizations that would be willing to fund WINE, provided that the WINE project inform them of its existence. The specific organization from which I think that the WINE project should attempt to solicit grant money is the Bill and Melinda Gates Foundation. In consideration of their guiding principles and the fact that they must spend $1.5 billion a year, it seems only logical to me that they would provide funding for the WINE project if asked: http://www.gatesfoundation.org/about/Pages/guiding-principles.aspx http://en.wikipedia.org/wiki/Bill_%26_Melinda_Gates_Foundation#Activities The Bill and Melinda Gates Foundation is not the only organization for which the WINE project could solicit funding, but I think that it is a good place to start. Please consider the possibility of soliciting grants so that the WINE project could hire professional developers. Also, I am not registered on the mailing list, so please CC me any responses made either directly or indirectly to this email, even if it ridicules my suggestion. Yours truly, Richard Yao

3 2

Re: ntdll: add stub for NtSystemDebugControl (try 2)
by Andrew Nguyen June 29, 2010

June 29, 2010

2010/6/28 Austin English <austinenglish(a)gmail.com>: > with correct spec file this time > > -- > -Austin > > > > The spec argument that corresponds to the PULONG prototype argument should also be ptr.

1 0

Re: ntdll: add stub for NtSystemDebugControl
by Andrew Nguyen June 29, 2010

June 29, 2010

On Mon, Jun 28, 2010 at 8:16 PM, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=23431 > > -- > -Austin > > > > The NtSystemDebugControl spec types don't match the prototype arguments.

1 0

Re: configure.ac: Don't try to rm dirs.
by Alexandre Julliard June 28, 2010

June 28, 2010

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > Hi, > > This patch allows to do a make clean in a wine tree configured with > with-wine64 option and fix following errors : > rm: cannot remove `fonts': Is a directory > rm: cannot remove `server': Is a directory These should be symlinks in a wow64 tree. Probably you didn't start from a fresh tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource
by Alexandre Julliard June 28, 2010

June 28, 2010

Wolfram Sang <wolfram(a)the-dreams.de> writes: > According to TestBot (#2851), all non-crashing Windows versions return 0. > > Found while working on Bug 21012. Although this patch doesn't cure this > bug, I think it is still worth adding the check because the pointer > may come from the (always evil ;)) user-application. Do you have an actual application that does this, or is this just hiding a Wine bug? -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: ddraw: Move complex surface destruction into its own function
by Luke Benstead June 28, 2010

June 28, 2010

Ok I wasn't sure as it's pretty trivial. I'll resend along with the others after 1.2. On Jun 28, 2010 8:36 PM, "Henri Verbeet" <hverbeet(a)gmail.com> wrote: On 28 June 2010 20:03, Luke Benstead <kazade(a)gmail.com> wrote: > Needed to properly fix ddraw surfac... That's of course not appropriate during code freeze.

2 1

Re: ddraw: Move complex surface destruction into its own function
by Henri Verbeet June 28, 2010

June 28, 2010

On 28 June 2010 20:03, Luke Benstead <kazade(a)gmail.com> wrote: > Needed to properly fix ddraw surface refcounting as it must be called from > the surface thunks. > That's of course not appropriate during code freeze.

1 0

Re: kernel32: Add NERR_UserNotFound to Norweigan winerr
by Paul Vriens June 28, 2010

June 28, 2010

On 06/28/2010 08:15 PM, Austin English wrote: > See http://bugs.winehq.org/show_bug.cgi?id=11168 > Hi Austin, Applying the patch gives: [paul(a)acer wine-git]$ patch -p 1 -i /home/paul/kernel32_nor.txt (Stripping trailing CRs from patch.) patching file dlls/kernel32/nls/winerr_nor.mc Compiling gives: ../../../wine-git/dlls/kernel32/nls/winerr_nor.mc:3737:2: Error: Unexpected EOF make: *** [nls/winerr_nor.mc.rc] Error 1 You need to add a '.' at the end of the mc file (see the others). -- Cheers, Paul.

2 1

Wine on cygwin now compiles!
by Austin English June 28, 2010

June 28, 2010

Thanks to a few recent commits by AJ (and several commits over the past months by others), wine now builds on Cygwin. Not everything works, of course, but still a neat exercise in recursion. I've put a screenshot of wine's notepad running on XP on bugzilla (http://bugs.winehq.org/show_bug.cgi?id=21181) see: http://bugs2.winehq.org/attachment.cgi?id=28896 -- -Austin

6 7

Fwd: Possible patch for #12706
by Jeff Cook June 28, 2010

June 28, 2010

This is a patch that makes WINE detect snd_usb_audio mics and assign them a mixer and working master control. See bug #12706 for more information about this problem: http://bugs.winehq.org/show_bug.cgi?id=12706 I wasn't able to test it completely because I wasn't able to switch my default input device to the USB mic and no one in IRC is helping with this, but it might make things work because theoretically the only problem was that WINE was ignoring devices that looked like snd_usb_audio's microphones. I suggest that someone who CAN get snd_usb_audio mic as their default test it out and confirm, I would really appreciate that. Thanks to all in IRC who helped me get things this far, especially mlankhorst. This patch is based against the current git HEAD, eaa227c12d8bb. I've also posted it at the aforementioned bug. -- Jeff Cook (801) 231-3157 jeff(a)deserettechnology.com

3 2

Re: user32: Make sure the desktop window is created before caps enumeration.
by Alexandre Julliard June 28, 2010

June 28, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch fixes the problem reported in the bug 21709. That's just hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0