June 2010 - Wine-Devel - list.winehq.org

DIBEngine and gdi32/user32 controls drawing loop performance
by Amico Amico June 20, 2010

June 20, 2010

Hello, since I had a poor performance in drawing many buttons and text input fields at the same time into a window with wine, I applied the DIBEngine patch (http://wiki.winehq.org/DIBEngine) that is available for wine 1.1.44 (http://bugs.winehq.org/attachment.cgi?id=27879) to the 1.1.44 version of wine and started my application program that needs to draw many button and text input fields in a single window with the enviroment variable "WINEDIB=ON wine ./App.exe". Now that the DIBEngine patch is applied a little speedup in the drawing of the buttons and the text input fields is shown, but now the problem is that they are still drawn in blocks of a subset of the total number and then wine waits a little bit, then it draws another block of text input fields and buttons and then wine still waits, then it draws, and so on. The result is that my App.exe application window that is full of buttons and text input fields is drawn in subsequent times, and groups of buttons and input fields are drawn in blocks with a delay between the drawing of a group of controls and the others. The fact that not all the controls are drawn at a time but in more times is frustrating, since the CPU is a core2duo, and I think that it is powerful enough to draw all of the controls in the window at a time, specially with the DIBEngine patch applied and the DIBEngine activated. So I thought that the problem could be in the main event loop that manages the App.exe application window, and in particular the problem could be that the loop yields the drawing of the controls after a certain number of controls have been drawn in order to avoid CPU high load and then the loop starts again to draw other controls after a while and then it stops and yields and waits again, and so on. Where can I modify such a behaviour? In particular my App.exe program use many gdi32 drawing commands for drawing buttons and text input fields, so the files dlls/user32/button.c and dlls/user32/edit.c are involved. I think that the dlls/user32/winproc.c file, where the Code: LRESULT WINAPI EditWndProcA( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) { return wow_handlers.edit_proc( hwnd, msg, wParam, lParam, FALSE ); } function is defined is the file where I should do some changes; this function calls Code: LRESULT EditWndProc_common( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, BOOL unicode ) that is implemented in the dlls/user32/edit.c file, but the fact is that in the EditWndProc_common function there are many cases like this one that manages the various edit messages and window messages sent Code: switch (msg) { case EM_GETSEL: result = EDIT_EM_GetSel(es, (PUINT)wParam, (PUINT)lParam); break; .... and I don't know how to modify the fact that the main loop of the window should handle more messages in order to draw all of the controls at a time and that it should not yield for waiting and then starting drawing again after some time. What can I do? Thanks in advance, AmoxT _________________________________________________________________ Taglia i costi. Chiama e videochiama da Messenger http://www.messenger.it/videoconversazioni.aspx

2 1

[RFC] gameux.dll implementation stub [try 2]
by Mariusz Pluciński June 20, 2010

June 20, 2010

Hi I fixed noted problems with my initial implementation of gameux.dll. The code freeze is still the fact, but I hope for some feedback. Thanks

3 2

new winetricks 20100618: new verbs dxsdk_nov2006, windowscodecs
by Dan Kegel June 20, 2010

June 20, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Dan Kegel Add dxsdk_nov2006, document how to use it etc. at http://kegel.com/wine/cl-howto-win7sdk.html directx9: override dxdiag.exe, too Update divx sha1sum Andrew Nguyen Add windowscodecs Jeff Zaroyko Fix vjrun20 path in non-quiet mode Austin English Update OpenWatcom to version 1.9

6 7

gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
by Scott Ritchie June 20, 2010

June 20, 2010

Screenshot/blog here: http://yokozar.org/blog/archives/225 A bug was fixed recently in Gnome that allows thumbnailers to not be 96x96 pixels. Combine this with a standard Wine icon, icoutils for extracting an exe/dll's embedded icon, and a bit of magic and you can get icons like those above. The version numbers come from the .exe metadata. I think it's really slick, and will try and have it installed by default with Wine 1.2. At the moment it exists as thumbnailer code for Gnome, which means other desktops won't benefit, however provided they can be told to run a script to generate an icon it should be fairly easy to port. Code is available in the gnome-exe-thumbnailer source package here: https://edge.launchpad.net/~ubuntu-wine/+archive/ppa Please note that this is an updated version of the proof of concept gnome-exe-thumbnailer package I put in Lucid (which is ugly and uses the overly large 96x96 icons, and is thus not default and has so far gone unnoticed). Thanks, Scott Ritchie

3 4

Re: [PATCH 3/3] shdocvw: Return IHTMLDocument2's IDispatch in get_Document.
by testbot＠testbot.winehq.org June 19, 2010

June 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2780 Your paranoid android. === WXPPROSP3 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W2K3R2SESP2 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === WVISTAADM (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W2K8SE (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PRO (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PROX64 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PROX64 (64 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex

1 0

Re: [PATCH 3/3] shdocvw: Return IHTMLDocument2's IDispatch in get_Document.
by testbot＠testbot.winehq.org June 19, 2010

June 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2779 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2485: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2485: Test failed: CoCreateInterface failed: 80040154 === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP

1 0

Re: [PATCH] [Mmsystem.drv]: always map parameters for all callback kinds
by Juan Lang June 19, 2010

June 19, 2010

Hi Eric, minor comment on this patch: + case CALLBACK_FUNCTION: + TRACE("Function (32 bit) !\n"); + /* 16 bit func, call it */ + TRACE("Function (16 bit) %x!\n", thunk->callback); The back-to-back traces look a little strange. So does the indenting here. --Juan

1 0

Apologies for the marketing message
by Jeremy White June 19, 2010

June 19, 2010

It's not clear how it happened; it was not intended. These are direct emails James sends periodically to customers reaching the end of their support period. We speculate that someone signed up with the mailing list address as 'their' address. At any rate, by way of apology I'd like to remind everyone that all contributors to Wine are entitled to VIP status with CodeWeavers, which gets you free lifetime subscriptions to CrossOver. (This way, there is no chance James could ever sell you anything <grin>). Write to me if you'd like me to set you up. We are deeply grateful for everyones contributions to Wine, and very sorry for the off topic emails. Cheers, Jeremy

1 0

Re: new winetricks 20100618: new verbs dxsdk_nov2006, windowscodecs
by Vincent Povirk June 19, 2010

June 19, 2010

On Sat, Jun 19, 2010 at 9:31 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > On 6/19/2010 18:25, Vincent Povirk wrote: >>> >>> Is it possible to add this in existing target d3dx dll that will be using >>> new decoder? >>> >> >> Yes, but they'll have to share the decoder for the DDS format somehow. >> It doesn't make much sense for d3dx9 to load d3dx11 for this. >> > > If native d3dx11 uses d3dx9 for that it's not a problem, cause this will be > still separated and both overrides will work. > If not - it's sad, additional winetricks re-registration will be needed, > etc. And if our windowscodecs is complete enough > we should probably forget about all of that and never use its override. Well, we need to register a decoder coclass to do this most cleanly, using WIC's built-in image format detection. These classes aren't present on any native dll's. Even if we didn't use a coclass, we'd need some sort of extension to a builtin dll. Most of the extra formats are only needed by d3dx9 (it seems native d3dx10 and d3dx11 use WIC, so they mostly support the WIC formats). DDS, however, can be loaded in d3dx9, d3dx10, and d3dx11. If we put a coclass for DDS in one of these dll's, the other two will have to load it when a program needs to read a DDS file.

1 0

kernel32 translation question
by Luca Bennati June 19, 2010

June 19, 2010

I found out why it didn't build: a numeric code in the first lines was in a wrong format. But now i need help to know what exactly i need to put there, because i don't know anymore. The lines are these (example got from french file): LanguageNames=(FRA=0x0c:winerr) CodePages=(FRA=65001:0) The problem is only the hexadecimal code in the first line: where i find the right value for ITA? The one i put (incorrectly) was from ita.nls ...

3 2

Re: hhctrl.ocx - null pointer bug
by Dmitry Timoshkov June 19, 2010

June 19, 2010

Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html > sent by Dmitry Timoshkov contains bug resulting in wine crash due to > possible null pointer dereference. Please, see bug report at > http://bugs.winehq.org/show_bug.cgi?id=23247 for more information. You need to fix dlls/hhctrl.ocx/chm.c,LoadWinTypeFromCHM() to fill defaults in all cases instead. Is that a real or just "possible" crash? From your description and the bug report it sounds like a theoretical issue. -- Dmitry.

2 1

Re: hhctrl.ocx - null pointer bug
by Juan Lang June 18, 2010

June 18, 2010

Hi Jaroslav, - if (!*caption) caption = info->pCHMInfo->defTitle; + if (!caption) caption = info->pCHMInfo->defTitle; I suspect a better fix would be: + if (!caption || !*caption) caption = info->pCHMInfo->defTitle; That is, either a NULL caption or an empty one results in info->pCHMInfo->defTitle getting used. --Juan

2 1

New wisotool 20100618: 19 new verbs (blur, spore, photoshop cs5, ...), and 75 old ones
by Dan Kegel June 18, 2010

June 18, 2010

wisotool is a handy winetricks-like script for automatically installing games from .iso or .mds files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for your password so it can mount the .iso file). Wisotool currently supports about 95 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. I'm especially interested in recent or beta games; ideally wisotool would support good games or betas on or near their day of release. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100530: Austin English: New verbs proevolution2010_demo pscs5 pscs5_pickle pscs5_unpickle Dan Kegel: New verbs bioshock_demo blur rom Various bugfixes Eleazar Galano: New verbs avatar_demo braid braid_demo darknesswithin2_demo hegemonypom_demo hphbp_demo nfsps_demo popsot spore Travis Athougies: New verbs 7million msaoe_demo Vincent Pelletier: New verb beneath_a_steel_sky_gog Here's the current help message: Script to install games automatically. Usage: wisotool [options] package [package] ... Options: -q quieter -v verbose -V display Version Packages: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] 7million 7Million (Deep Silver, 2009) [download] [broken on wine] abes_exoddus_gog Abes Exoddus (GOG.com) abes_oddysee_gog Abes Oddysee (GOG.com) assassinscreed Assassins Creed (Ubisoft, 2008) avatar_demo James Camerons Avatar The Game Demo (Ubisoft, 2009) [download] baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) battle_chess_gog Battle Chess (GOG.com) beneath_a_steel_sky_gog Beneath a Steel Sky (GOG.com, free) beyond_good_and_evil_gog Beyond Good and Evil (GOG.com) bfbc2 Battlefield Bad Company 2 (EA, 2010) bioshock Bioshock (2K Games, 2007) bioshock_demo Bioshock Demo (2K Games, 2007) blur Blur (Activision, 2010) braid Braid (Number None, 2009) [download] braid_demo Braid Demo (Number None, 2009) [download] codmw2 Call of Duty Modern Warfare 2 (Activision, 2009) [broken] darknesswithin2_demo Darkness Within 2 Demo (Zoetrope Interactive, 2010) [download] descent_1_2_gog Descent and Descent 2 (GOG.com) descent_3_gog Descent 3 (GOG.com) diablo2 Diablo II (Blizzard, 2000) dragonage Dragon Age: Origins (Bioware, 2009) dukenukem3d_gog Duke Nukem 3D (GOG.com) dukenukemmp_gog Duke Nukem Manhattan Project (GOG.com) earth_2150_trilogy_gog Earth 2150 trilogy (GOG.com) earth_2160_gog Earth 2160 (GOG.com) earthworm_jim_1_2_gog Earthworm Jim 1 & 2 (GOG.com) earthworm_jim_3d_gog Earthworm Jim 3D (GOG.com) empire_earth_gold_gog Empire Earth Gold (GOG.com) evil_genius_gog Evil Genius (GOG.com) fallout_2_gog Fallout 2 (GOG.com) fallout_gog Fallout (GOG.com) fallout_tactics_gog Fallout Tactics (GOG.com) far_cry_gog Far Cry (GOG.com) flatout_gog FlatOut (GOG.com) freespace_2_gog Freespace 2 (GOG.com) freespace_gog Freespace (GOG.com) ghost_master_gog Ghost Master (GOG.com) ground_control_2_gog Ground Control 2 (GOG.com) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) half_life_goty Half Life: Game of the Year Edition (Sierra, 2000) hegemonypom_demo Hegemony: Philip of Macedon Demo (Longbow Games, 2010) [download] help How to use this tool hon Heroes of Newerth (S2 Games, 2010) [download] hphbp_demo Harry Potter & The Half Blood Prince Demo (EA, 2009) [download] lswcs Lego Star Wars Complete Saga (Lucasarts, 2009) manhole The Manhole Masterpiece Edition (Cyan, 1994) masseffect2 Mass Effect 2 (BioWare, 2010) mdk2_gog MDK 2 (GOG.com) mdk_gog MDK (GOG.com) mnbw_demo Mount & Blade Warband Demo (Taleworlds, 2010) [download] morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) msaoe_demo Age of Empires Demo (Microsoft, 1997) [download] neighbours_from_hell_compilation_gog Neighbours From Hell 1 & 2 (GOG.com) nfsps_demo Need For Speed: Pro Street Demo (EA, 2007) operation_flashpoint_goty_gog Operation Flashpoint GOTY (GOG.com) orangebox Orange Box (Valve, 2007) painkiller_black_gog Painkiller Black (GOG.com) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] perimeter_gog Perimeter (GOG.com) plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] popsot Prince of Persia Sands of Time (Ubisoft, 2003) popsot_demo Prince of Persia Sands of Time Demo (Ubisoft, 2003) praetorians_gog Praetorians (GOG.com) procycling08_demo Pro Cycling Manager 2008 Demo (Cyanide, 2008) [download, broken in wine] procycling09_nda Pro Cycling Manager 2009 (Cyanide, 2009) proevolution2010_demo Pro Evolution Soccer 2010 Demo (Konami, 2009) [download] pscs5 Photoshop CS5 Demo (Adobe, 2010) pscs5_pickle save Photoshop CS5 Demo to tarball pscs5_unpickle restore Photoshop CS5 Demo from tarball psychonauts_gog Psychonauts (GOG.com) quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] redneck_rampage_gog Redneck Rampage (GOG.com) robinson_requiem_collection_gog Robinson Requiem & Deus (GOG.com) rom Runes of Magic (Frogster Interactive, 2009) [download] settlers_2_gold_gog The Settlers 2 Gold (GOG.com) shogo_gog Shogo Mobile Armor Division (GOG.com) sims3 The Sims 3 (EA, 2009) splitsecond Split Second (Black Rock Studios, 2010) [wine bug 22865] splitsecond_demo Split Second Demo (Black Rock Studios, 2010) [wine bug 22865] spore Spore (EA, 2008) starcraft Starcraft Battle Chest (Blizzard, 1998) starcraft2 Starcraft II beta (Blizzard, 2010) stfu Starwars: The Force Unleashed (Aspyr, 2009) sto Star Trek Online (Cryptic, 2010) tex_murphy_1_and_2_gog Tex Murphy 1 & 2 (GOG.com) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] unreal_2_se_gog Unreal 2: The awakening Special Edition (GOG.com) unreal_gold_gog Unreal Gold Edition (GOG.com) ut2004_gog Unreal Tournament 2004 (GOG.com) ut_goty_gog Unreal Tournament GOTY (GOG.com) wog World of Goo demo (2D Boy, 2008) [download] wowbc World of Warcraft: Battle Chest (Blizzard, 2008) Pseudopackages: load Load a disc into the iso cache load=KEY Load a disc with given key; only works from commandline at moment ------------------------------------------------------ If the game is not marked with {download} or {loaded} in the menu, you have to insert its disc and give the 'load' command before you can choose that game in the menu. If the game has multiple discs, you have to do this for each disc. ------------------------------------------------------ ------------------------------------------------------ If the game has an install key, you have to enter that when loading the first disc. (You have to do that from the commandline, e.g. sh wisotool load=XXXX-YYYY-ZZZZ.) ------------------------------------------------------

1 0

Happy Father's Day From CodeWeavers: Get CrossOver Mac for 60% Off (This Weekend Only)
by James Ramey June 18, 2010

June 18, 2010

Thank you for your past patronage of CrossOver Mac. We appreciate your business, and I was hoping to tempt you with an enticing offer to continue supporting our software. For this weekend only, you can purchase CrossOver (any version) for 60% off the list price. All you need to do is enter SPECIAL DEAL CODE: FATHERSDAY in the Special Deal Box in the cart screen (has to be the cart screen) of the order process. You'll see the discount applied before you complete your transaction. It's a quick and easy way to save money on your purchase of CrossOver. · A couple of factoids you might want to consider in making this purchase: · CrossOver 9.1 is due out within the next 45 days. CrossOver 9.1 should be an especially good release of CrossOver, and the upgrade to this version is included in your purchase. · CrossOver Mac Professional includes a license for CrossOver Mac Games. CrossOver Mac Games is now playing many new titles including Star Trek On-line. If you have an interest in playing games, you may want to consider purchasing CrossOver Mac Professional using the SPECIAL DEAL CODE. · All volume and educational discounts are still valid with this promotion. If you have an educational entitlement, you'll get your educational discount in addition to the SPECIAL DEAL CODE. Likewise if you purchase more than one license, you'll also get volume discounts. Again, this SPECIAL DEAL CODE is easy to use and will save you money!! · The SPECIAL DEAL CODE expires on Monday, June 21. Don't wait to buy. If you're interested, make your purchase now as this special deal is limited to only past customers and only to this weekend. · If this SPECIAL DEAL CODE isn't your cup of tea, I understand. This is the only e-mail that you will receive from me about renewing your support. You'll receive a nag e-mail or two from our system reminding you to renew your maintenance. Once those have past, we will not contact you again (ever) unless you have signed up for one of our many mailing lists. Finally, everyone at CodeWeavers appreciates your business. We appreciate your patience as we work to make our software ever better. We understand that it's not always easy to use our software and that our software doesn't always provide the support you want or need. We want you to know this and that we are making efforts to make the software better. Again, thank you. We sincerely appreciate your support of our software and our efforts to make our software better. With my best regards, James B. Ramey Vice President, Sales CodeWeavers, Inc. jramey(a)codeweavers.com

1 0

The __WINE__ macro does not identify the Wine platform
by Alan W. Irwin June 18, 2010

June 18, 2010

According to some old discussion (http://www.mail-archive.com/wine-devel(a)winehq.com/msg15669.html) on wine-devel it appears that __WINE__ was going to be the macro used to identify the Wine platform, However, that doesn't appear to work for Windows native MinGW on wine. To show this, I attach results from running wine gcc -E -dM foo.c >| /tmp/wine_gcc_dM.out where foo.c is an empty file, and gcc is the MinGW 4.5.0-1 version. The equivalent command under Linux gcc shows several macros, (e.g., __linux__) are defined to identify that platform, but I cannot find anything in the attached file that similarly identifies the Wine platform. Furthermore, I have compiled and run a simple test code under Wine that shows that __WINE__ is not available (see previous post on wine-users for details). An excellent general motivation for such an identifying macro for wine is given in the above older wine-devel discussion, and I understand the CMake developers have an immediate use for such a macro within the CMake code itself. Is the lack of a macro to identify the wine platform a bug I should report or am I missing something? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

7 11

Re: user32: Lock user32 in alloc_user_handle to fix races with get_user_handle_ptr
by Dan Kegel June 18, 2010

June 18, 2010

On Fri, Jun 18, 2010 at 9:18 AM, Paul Chitescu <paulc(a)voip.null.ro> wrote: > On Friday 18 June 2010 07:04:14 pm Dan Kegel wrote: >> Say, that sounds like a kind of test we should have in our test suite. >> >> What apps does this fix? > > Sysinternal's autoruns.exe which populates a number of list/tree views with a > large number of icons extracted them the exes. It seems to do so from > different threads and it doesn't stop if one thread crashes (I wonder - > intentionally?) > > Unfortunately it's a race condition that doesn't always happen. Adding just a > TRACE suppressed the error. Adding if (...) ERR(...) showed that only 1-2 out > of about 150 icon creations would crash. Thanks for the info.

1 0

Re: advapi32/tests: Fixed -Wsign-compare warnings in security tests (try 2)
by Alexandre Julliard June 18, 2010

June 18, 2010

Marko Nikolic <grkoma(a)gmail.com> writes: > Fixed test failures in 64-bit build. It would be better to choose a more appropriate invalid value for a BOOL variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Force a minimum character size of 1x1 to prevent divisions by zero if setting the font failed
by Alexandre Julliard June 18, 2010

June 18, 2010

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > user32: Force a minimum character size of 1x1 to prevent divisions by zero if > setting the font failed > > Failing to set any font is unusual but can happen - for example: > DISPLAY= wine notepad It sounds like a gdi bug. It should be able to provide metrics even without a display. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by Alexandre Julliard June 18, 2010

June 18, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Fri Jun 18 13:21:56 2010 +0900 > > comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons It would probably be better to not disable buttons that don't need it. What is this fixing? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by James Mckenzie June 18, 2010

June 18, 2010

Aric Stewart <aric(a)codeweavers.com> wrote: > >Alexandre Julliard wrote: >> Aric Stewart <aric(a)codeweavers.com> writes: >> >>> commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 >>> Author: Aric Stewart <aric(a)codeweavers.com> >>> Date: Fri Jun 18 13:21:56 2010 +0900 >>> >>> comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons >> >> It would probably be better to not disable buttons that don't need >> it. What is this fixing? >> > >I can modify the patch to do that. > >This is triggering a bug on the mac that causes the window manager to >loose track of where to send messages causing the resulting dialog to be >unable to get mouse events. > Thank you for taking time to fix this. What is the bug report number so that I can go out and vote for it. I've experienced this lately while running some regression tests and I thought that it was just my system messing up (I've had to reboot it several times in the last week or so.) BTW, 10.6.4 has been released, 700MB download :( James McKenzie

1 0

Re: ddraw: Better validation of IDirectDrawSurface::BltFast parameters.
by Henri Verbeet June 18, 2010

June 18, 2010

On 18 June 2010 15:52, Iain Arnell <iarnell(a)gmail.com> wrote: > - dsty + rsrc->bottom - rsrc->top > This->surface_desc.dwHeight) > + dsty + rsrc->bottom - rsrc->top > This->surface_desc.dwHeight || > + (dstx | dsty) & (1<<(sizeof(DWORD)*8-1)) /* dstx or dsty negative */ ) That's not very pretty. This looks like it's just an integer overflow, so that's probably also how you should handle it.

1 0

Re: Michael Stefaniuc : notepad: Fix an error in the Bulgarian translation.
by Eric Ahn June 18, 2010

June 18, 2010

unsubscribe

1 0

Re: notepad: substitute the page number in the footer
by Alexandre Julliard June 18, 2010

June 18, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * notepad: substitute the page number in the footer This needs to be more generic, there are other possible substitutions. At the very least it should handle escaped ampersands. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Add the Romanian translation. (2nd try)
by Octavian Voicu June 18, 2010

June 18, 2010

On Fri, Jun 18, 2010 at 12:14 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > + IDS_INVALID_CALL_ARG "Apel de procedură sau argument nevalid" > + IDS_SEMICOLON "„;” presupus" > + IDS_LBRACKET "„(” presupus" > + IDS_RBRACKET "„)” presupus" > + IDS_UNTERMINATED_STR "Constantă de șir nedeterminată" > + IDS_NOT_FUNC "Funcție presupusă" > + IDS_NOT_NUM "Număr presupus" > + IDS_OBJECT_EXPECTED "Obiect presupus" > + IDS_NOT_BOOL "Obiect boolean presupus" > + IDS_JSCRIPT_EXPECTED "Obiect JScript presupus" > + IDS_REGEXP_SYNTAX_ERROR "Eroare de sintaxă în expresie rațională" > + IDS_URI_INVALID_CHAR "URI care trebuie codificat conține caractere nevalide" > + IDS_ARRAY_EXPECTED "Obiect matrice presupus" "expresie rațională" should be translated as "expresie regulată" (I've also seen "regulară", but never "rațională") [1] "nevalid" sounds really odd and it's almost never used; imho "invalid" should be used instead [2] "presupus" sounds really confusing; something in the lines of "Se aștepta un obiect" sounds better to me and seems more standard [3] I really think we should try to make translations a bit standard, especially when it comes to technical terms. Octavian [1] http://ro.wikipedia.org/wiki/Expresie_regulat%C4%83 [2] http://ro.wikipedia.org/wiki/Special:C%C4%83utare/Invalid [3] http://translationproject.org/latest/coreutils/ro.po

2 2

Re: jscript: Add the Romanian translation. (2nd try)
by Octavian Voicu June 18, 2010

June 18, 2010

On Fri, Jun 18, 2010 at 12:14 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > + IDS_UNTERMINATED_STR "Constantă de șir nedeterminată" Forgot about this one, maybe try "Constantă șir neterminată" [1]. When not sure how to translate a term, maybe this will help: google for "UNKNOWN TERM ro.po site:http://translationproject.org/". Octavian [1] http://translationproject.org/PO-files/ro/indent-2.2.8.ro.po

1 0

Xinput / DirectInput xbox360 controller support
by Roderick Colenbrander June 18, 2010

June 18, 2010

Hi all, I'm interested in adding Xbox 360 controller support to Wine. For people who don't know how this works and what's so special I will first give a small introduction. The Xbox 360 controller is a normal USB device which you can use from 'xinput*.dll' (typically xinput1_3.dll is used). The xinput API is very easy (and it is the same what is used on the Xbox360) and in total it exports a handful of functions. Basically there is a call to query the capabilities, a call to poll which button was pressed and a call to 'set the controller to a certain state' (rumble stuff) and a few other not so important calls. The dll can ONLY be used for xbox 360 compatible controllers and other controllers should use dinput. In Wine we have a stubbed xinput implementation. Last year Michael Gruber submitted a number of patches which added implementations for most calls but the code wasn't added. I tested his XInput code on current Wine and it actually works well in DirectX SDK examples including force feedback! After he submitted the code there was a short discussion on wine-devel but then it stopped. Michael his xinput code directly interfaces with the Linux input event interface. It was asked whether XInput can't be layered on top of DirectInput but that's not possible since DirectInput doesn't expose all the needed functionality (it doesn't support the Xbox360 force feedback). The other way around is also not possible because XInput is only for Xbox 360 controllers/joysticks while DirectInput also supports keyboard and mouse. I'm wondering how to proceed with XInput. My main issue is the 'joystick access part'. Would it be fine to directly access the controller from Xinput (so we would need multiple hardware backends later on). Code size won't be a problem though since XInput doesn't support much functionality at all (the current mostly working version is less than 500 lines of code; half of that is for the Linux backend). One small issue is though that DirectInput and XInput might have to cooperate since typically games use DirectInput to enumerate all joysticks, see for instance http://msdn.microsoft.com/en-us/library/ee417014%28VS.85%29.aspx Roderick

4 6

Help with simple winelib dll
by Seth Burleigh June 18, 2010

June 18, 2010

Im attempting to build a dll which a windows program running under wine can dynamically load. The dll will be a wrapper around a linux library. In preparation ive tried to follow the instructions here http://www.winehq.org/docs/winelib-guide/bindlls with a simple example but have not succeeded. Below is the contents of the files in my directory and the commands i executed. Can anyone help out? Thanks! MyLinuxFunc.c int MyLinuxFunc(int a,int b) { return a+b; } ----------------------------- MyLinuxFunc.h int MyLinuxFunc(int,int); ----------------------------- libMyLinuxFunc.so ----------------------------- MyWin.dll.spec 2 stdcall MyWinFunc (long long) MyProxyWinFunc ----------------------------- MyWin.c #include <MyLinuxFunc.h> #include <windef.h> int WINAPI MyProxyWinFunc (int a,int b) { return MyLinuxFunc(a,b); } ----------------------------- winemaker . --nosource-fix --dll --single-target MyWin --nomfc -I"." -L"." -iMyLinuxFunc make winegcc -o MyWin.so MyLinuxFunc.o MyWin.o -L. -lMyLinuxFunc MyWin.o: In function `MyProxyWinFunc': MyWin.c:(.text+0x20): undefined reference to `MyLinuxFunc' /usr/lib/wine/libwinecrt0.a(exe_main.o): In function `main': (.text+0xa0): undefined reference to `WinMain' collect2: ld returned 1 exit status winegcc: i486-linux-gnu-gcc failed make: *** [MyWin.so] Error 2

4 7

Brazilian Portuguese translation of winecfg
by Gustavo June 18, 2010

June 18, 2010

Hello, I've updated the translation of winecfg in Brazilian Portuguese. Making comparisons, I also noted that the "Windows Version" (Versão do Windows) drop-down menu disappeared and the Browse... (Localização:) text in the Drives was cut to half when you execute wine with LANG="pt_PT.UTF-8" (the Portuguese from Portugal). I've managed to fix that as well. So I sent two separate patches: one with the Brazilian translation and another with the Portuguese fixes. Let me know if I did anything wrong. Gustavo Henrique Milaré

1 1

Re: comctl32: Update English resource
by Juan Lang June 17, 2010

June 17, 2010

Hi Ken, +LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_CAN + +IDD_TBCUSTOMIZE DIALOG DISCARDABLE 10, 20, 357, 125 +STYLE DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU +CAPTION "Customize Toolbar" +FONT 8, "MS Shell Dlg" +BEGIN + DEFPUSHBUTTON "&Close", IDCANCEL,308,6,44,14 + PUSHBUTTON "R&eset", IDC_RESET_BTN,308,23,44,14 + PUSHBUTTON "&Help", IDC_HELP_BTN,308,40,44,14 + PUSHBUTTON "Move &Up", IDC_MOVEUP_BTN,308,74,44,14 + PUSHBUTTON "Move &Down", IDC_MOVEDN_BTN,308,91,44,14 + LTEXT "A&vailable buttons:", -1,4,5,84,10 + LISTBOX IDC_AVAILBTN_LBOX,4,17,120,100, LBS_NOTIFY | LBS_OWNERDRAWFIXED | LBS_HASSTRINGS | LBS_NOINTEGRALHEIGHT | LBS_DISABLENOSCROLL | WS_BORDER | WS_VSCROLL | WS_HSCROLL | WS_TABSTOP + PUSHBUTTON "&Add ->", IDOK, 131, 42, 44, 14 + PUSHBUTTON "<- &Remove", IDC_REMOVE_BTN,131,62,44,14 + LTEXT "&Toolbar buttons:", -1,182,5,78,10 + LISTBOX IDC_TOOLBARBTN_LBOX, 182,17,120,100,LBS_NOTIFY | LBS_OWNERDRAWFIXED | LBS_HASSTRINGS | LBS_NOINTEGRALHEIGHT | LBS_DISABLENOSCROLL | WS_BORDER | WS_VSCROLL | WS_HSCROLL | WS_TABSTOP +END I don't understand why you would want to create multiple "translations" when their content is identical. If it's because the statistics you're generating claim a particular variant of English is incomplete, then you should fix the tool you're using to generate the statistics: unless there's an actual difference between American English and the variant, there's no need for a translation. --Juan

3 3

Brazilian Portuguese translation
by Gustavo June 17, 2010

June 17, 2010

Hello, I can see that the Brazilian translation is bad, so I'm translating winecfg. I followed the instruction in the wiki [1] to create a .po file. At first I tried to recover from the file Pt.rc rc2po -t En.rc Pt.rc Pt.po but I didn't have much luck, no existing translations are shown. Adding the options --lang=LANG_PORTUGUESE --sublang=SUBLANG_PORTUGUESE_BRAZILIAN or even just --lang=LANG_PORTUGUESE fails to create the file. Not much of a problem, I started from scratch. The problem is, when I use the .po file to create the .rc file po2rc --lang=LANG_PORTUGUESE --sublang=SUBLANG_PORTUGUESE_BRAZILIAN -t En.rc Pt.po Pt.rc only Brazilian Portuguese entries are created, and the Pt.rc file had "Portuguese Portuguese" entries as well. What should I do? Gustavo. [1] http://wiki.winehq.org/Translating

3 4

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior
by lats June 17, 2010

June 17, 2010

When does this unpredictability occur? The tests have always run ok for me.

2 1

wined3d: Add NPOT quirk for GeforceFX 5200
by Roderick Colenbrander June 17, 2010

June 17, 2010

1 0

Re: msvcrt/tests: Re-order tests to work around weird win_skip failure bug. (try 2)
by Alexandre Julliard June 17, 2010

June 17, 2010

Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> writes: > Try 2: Re-order function bodies as well. > > From a51f6b7f855ccb1d9252a3d5e2698cdbe73ad053 Mon Sep 17 00:00:00 2001 > From: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> > Date: Fri, 11 Jun 2010 14:13:52 +0100 > Subject: msvcrt/tests: Re-order tests to work around weird win_skip failure bug. > > Paul Vriens found which test caused the breakage. There's no need to reorder the functions, but there's a need to understand why that test is breaking win_skip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2]kernel32/tests: Test the collation table much more
by Alexandre Julliard June 17, 2010

June 17, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > I added some ranges to test, so it is easy extensible That's still not a very convincing test... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) usp10/tests: Windows 95 does not set invalid glyphs to 0 but instead 0x80
by testbot＠testbot.winehq.org June 17, 2010

June 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2742 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: usp10/tests: Windows 95 does not set invalid glyphs to 0 but instead 0x80
by testbot＠testbot.winehq.org June 17, 2010

June 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2739 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: [PATCH] winspool/tests: Handle the Windows bug in GetPrinterDataEx
by testbot＠testbot.winehq.org June 17, 2010

June 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2720 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: PGO and wine
by Peter Davies June 17, 2010

June 17, 2010

On 16 June 2010 02:37, Dan Kegel <dank(a)kegel.com> wrote: > But does PGO improve performance measurably? > Probably, to test it I need a program that runs wine like a typical program, that I can run autonomously. Anyone have any ideas? Peter

5 4

wrong link between bug and AppDB
by wylda＠volny.cz June 16, 2010

June 16, 2010

Hi, i just made a mistake and linked bug 9264 with http://appdb.winehq.org/objectManager.php?sClass=version&iId=20179. But i wanted to link 19264 instead of 9264. What are the correct steps to fix this mistake? -- Kaspersky Internet Security 2010 + Kaspersky Mobile Security jen za 1199,-Kč. Ochraňte svůj počítač i mobil před zneužitím či ztrátou dat. Kupte si 2 produkty za cenu jednoho. www.kaspersky.cz

2 1

Re: [PATCH] ntdll: The FPU control word for newly created threads is 0x27f.
by Alexandre Julliard June 16, 2010

June 16, 2010

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 36f1499..0d383bd 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -384,6 +384,7 @@ static void start_thread( struct startup_info *info ) > thread_data->pthread_id = pthread_self(); > > signal_init_thread( teb ); > + signal_init_thread_fpu(); > server_init_thread( func ); > pthread_sigmask( SIG_UNBLOCK, &server_block_set, NULL ); This should be done inside signal_init_thread(), that's already meant for platform-specific setup, there's no need to add a separate entry point. Also you may want to do an fninit if new threads are not supposed to inherit FPU state. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] ntdll: The FPU control word for newly created threads is 0x27f.
by Henri Verbeet June 16, 2010

June 16, 2010

I forgot to mention this, but this fixes a regression introduced by commit e6611e22fb037a879205f1330d1a3485f9f18705.

1 0

Re: [RESEND 2] Changes to enable the use of gcov and PGO
by Alexandre Julliard June 16, 2010

June 16, 2010

Peter Davies <ultratwo(a)gmail.com> writes: > @@ -72,7 +72,7 @@ MAKECTESTS = $(TOOLSDIR)/tools/make_ctests$(TOOLSEXT) > WRC = $(TOOLSDIR)/tools/wrc/wrc$(TOOLSEXT) > WMC = $(TOOLSDIR)/tools/wmc/wmc$(TOOLSEXT) > WIDL = $(TOOLSDIR)/tools/widl/widl$(TOOLSEXT) > -WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc $(TARGETFLAGS) -B$(TOOLSDIR)/tools/winebuild --sysroot=$(TOPOBJDIR) @UNWINDFLAGS@ > +WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc $(TARGETFLAGS) -B$(TOOLSDIR)/tools/winebuild --sysroot=$(TOPOBJDIR) @UNWINDFLAGS@ $(LDFLAGS) LDFLAGS are already passed to winegcc where appropriate. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Anotated 'make test' log
by Max TenEyck Woodbury June 16, 2010

June 16, 2010

Dan wrote: > OK. I'd suggest starting by looking at > http://bugs.winehq.org/show_bug.cgi?id=15435 > "Wine logs too verbose, quieter fixme's needed" and sending > in a patch to make one of the overly-verbose fixme's a bit > quieter. Thanks. I'll look at it. > Also, check your mail system; I can't email to you directly, > it bounces. And that's going to be a problem communicating > with other developers. A system disk failed this past weekend and I've been trying to get everything back up. I got test messages through starting about two hours ago. I've been checking the mailing list archive. (Yes, messages do not get properly threaded that way.) I'm also in the process of reinstalling much software. That machine is not very fast... - Max

1 1

Re: [2/9] setupapi: Validate the cabinet filename parameter in SetupIterateCabinetA.
by Alexandre Julliard June 16, 2010

June 16, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > dlls/setupapi/setupcab.c | 7 ++- > dlls/setupapi/tests/Makefile.in | 1 + > dlls/setupapi/tests/setupcab.c | 121 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 128 insertions(+), 1 deletions(-) > create mode 100644 dlls/setupapi/tests/setupcab.c It doesn't work here: wine: Unhandled page fault on write access to 0x6864dd7b at address 0x686a1c89 (thread 003a), starting debugger... Unhandled exception: page fault on write access to 0x6864dd7b in 32-bit code (0x686a1c89). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686a1c89 ESP:0032f6e0 EBP:0032fa68 EFLAGS:00010246( R- -- I Z- -P- ) EAX:6864dd7b EBX:686b2cfc ECX:00000000 EDX:00000024 ESI:6865d68f EDI:0032f838 Stack dump: 0x0032f6e0: 0032f93c 6864dd7b 0032f838 0032fa4c 0x0032f6f0: 686a14e0 00000000 0032f724 ffffffff 0x0032f700: 0032fa40 0032f9e4 0032f768 7bc70be0 0x0032f710: 0000000e 00000002 00000001 0032f93c 0x0032f720: 00110060 acabfeed 00121100 00000000 0x0032f730: 00000000 00038080 2e366338 00706d74 Backtrace: =>0 0x686a1c89 SetupIterateCabinetA+0xc9(CabinetFile="", Reserved=0, MsgHandler=0x6864b9a0, Context=0x0(nil)) [/home/julliard/wine/wine/dlls/setupapi/setupcab.c:588] in setupapi (0x0032fd38) 1 0x6864bd95 test_invalid_parametersA+0x384() [/home/julliard/wine/wine/dlls/setupapi/tests/setupcab.c:108] in setupapi_test (0x0032fd88) 2 0x6864df0e run_test+0x14d(name=<is not available>) [/home/julliard/wine/wine/dlls/setupapi/tests/../../../include/wine/test.h:557] in setupapi_test (0x0032fe48) 3 0x6864e0e2 main+0x131(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/setupapi/tests/../../../include/wine/test.h:607] in setupapi_test (0x0032fe90) 4 0x6864e27c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in setupapi_test (0x0032fea8) 5 0x7b854ebc call_process_entry+0xb() in kernel32 (0x0032fee8) 6 0x7b85756b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:996] in kernel32 (0x0032fef8) 7 0x7bc71a40 call_thread_func+0xb() in ntdll (0x0032ffc8) 8 0x7bc71c10 call_thread_entry_point+0x6f(entry=0x7b857510, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2466] in ntdll (0x0032ffe8) 9 0x7bc4d5ca start_process+0x29(kernel_start=0x7b857510) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x00000000) 0x686a1c89 SetupIterateCabinetA+0xc9 [/home/julliard/wine/wine/dlls/setupapi/setupcab.c:588] in setupapi: movb $0x0,0x0(%eax) 588 *p = '\0'; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: try to not raise exceptions when checking for atl thunks
by Alexandre Julliard June 16, 2010

June 16, 2010

Markus Amsler <markus.amsler(a)oribi.org> writes: > + * Windows checks the following conditions before emulating an ATL thunk: > + * - DEP policy allows emulating > + * - thunk has memory type MEM_PRIVATE and is readable > + * - jmp func is executable > + * - thunk signature (movl, jmp) matches > + * - a "secret" flag is set: > + * The flag gets set before calling WndProc and cleared after WndProc > + * or a thunk was emulated. > + * In Windows XP SP 3 this flag is located at TEB+0xfb4. > */ Where does that information come from? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: kernel32: stop CopyFile from overwriting a file with itself
by Alexandre Julliard June 16, 2010

June 16, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > + if (h2 != INVALID_HANDLE_VALUE) > + { > + BY_HANDLE_FILE_INFORMATION info2; > + if (GetFileInformationByHandle( h2, &info2 )) > + { > + if (info.dwVolumeSerialNumber == info2.dwVolumeSerialNumber && > + info.nFileIndexLow == info2.nFileIndexLow && > + info.nFileIndexHigh == info2.nFileIndexHigh) The volume serial number is not the appropriate check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior
by testbot＠testbot.winehq.org June 16, 2010

June 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2695 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W7PROX64 (64 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to close a window
by Vitaliy Margolen June 16, 2010

June 16, 2010

On 06/15/2010 05:36 AM, Paul Chitescu wrote: > Changelog: > winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to > close a window > + GetCursorPos( &pt ); > + PostMessageW( hwnd, WM_SYSCOMMAND, SC_CLOSE, MAKELPARAM( pt.x, pt.y ) ); You can't do that. Cursor can be anywhere, even outside Wine when WM decides to remove Wine's window. According to MSDN (which means it requires validation) you can pass either -1 or 0 for lparam here. Otherwise I think WM_SYSCOMMAN should be the correct behavior. Vitaliy.

1 0

Re: [PATCH] winspool: Return ERROR_MORE_DATA, when the app probe for the needed buffersize [BUG 19624]
by testbot＠testbot.winehq.org June 16, 2010

June 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2686 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: propsys: mention that the functions are stubs
by James Mckenzie June 15, 2010

June 15, 2010

Hans Leidekker <hans(a)codeweavers.com> wrote: > >On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > >> Just to confirm what André said, if the FIXME does not contain the word >> 'stub', then apistats has no way to know it's a (pseudo-)stub. > >Wouldn't it be sufficient for our purposes to just count every first >fixme in a WINAPI function as a stub? As it is now there's a large >percentage of fixmes that don't include the 'stub' keyword. > I tend to disagree. Stubs should be identified, if possible, for each call. Some calls will not activate a specific sequence of FIXMEs and in some cases, users have become confused as they don't have the technical knowledge to determine why their program is failing. > >> I would further argue that even a human reading the log would have no >> way to know as quite a few implemented functions still dump their parameters. >> So even for humans it's better to add 'stub' to the FIXME message. > >I'd say we need turn those into traces and add fixmes for the >unimplemented parts, if needed. > This actually might be better, but don't TRACES only appear if you are running in debug mode? We do want to inform our user base that a failure happened due to partially implemented code rather than give them the impression that we don't care or only implement code to make certain programs work (hacky code...) Note: This is only a statement of opinion, not a request for direction within the project. If a fixme had 'stub' that means that we have implemented code to 'fake' windows functionality, whereas a real fixme means there is a problem with the code and it needs to be corrected. James McKenzie

2 1