June 2010 - Wine-Devel - list.winehq.org

re: Anotated 'make test' log
by Dan Kegel July 18, 2010

July 18, 2010

What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive to do so around areas of pain for users. For instance, you could look at bugs in bugzilla that have patches attached that aren't committed yet because tests are needed, and write those tests. - Dan

4 6

xrender.c is does not find fontconfig.h on OS X Tiger
by Mike Kronenberg July 12, 2010

July 12, 2010

Dear List OS X Tiger does has not have fontconfig, so I'm building it in ~/buildwine/usr to keep it out of /usr. I include the headers and libs from ~/buildwine/usr with CPPFLAGS and CFLAGS. This worked fine until 1.2-rc1 and 1.2-rc2. Compiling xrender.c now exits with an error that FC_WEIGHT_THIN etc is not defined. configure leaves me with SONAME_LIBFONTCONFIG='libfontconfig.1.dylib' FONTCONFIGINCL='' in the config.log. No luck even if I export FONTCONFIGINCL="-I//$HOME/buildwine/usr/include/fontconfig -I//$HOME/buildwine/usr/include' which resulted in a correct FONTCONFIGINCL, but the compiling still failed. All the other custom compiled deps are working as usual. Any hint what I might missing? txs Mike

2 2

re: Yagmark and localized Windows
by Dan Kegel July 5, 2010

July 5, 2010

I'd love to have yagmark be more internationalized. I did try to use button codes rather than english strings in wisotool, but sometimes it wasn't possible, and sometimes I didn't try hard enough. Not sure if I tried at all in yagmark yet. According to http://www.autohotkey.com/docs/commands/SetTitleMatchMode.htm Autohotkey supports regular expressions, so for the matching strings that can't be changed to button codes, we could list a bunch of alternatives, e.g. Save As|Enregistrer Sous Then the remaining mess is when we have to send a keystroke, we might need a switch statement to decide which keystroke to send based on the language. For the purposes of benchmarking wine, just setting LANG=en_US.UTF-8 solves the problem, but that doesn't help when you're trying to benchmark Windows. - Dan

5 9

Please review: Patch for non-Linux serial set_baud_rate()
by Ken Thomases July 4, 2010

July 4, 2010

Hi, I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems clearly right and conforms to what I learn from man pages, etc. So, I'm hoping somebody who is more familiar with this functionality can review the attached patch before I formally submit it. Another approach that seems better from my reading of the man pages is to switch to using cfsetspeed() [or cfsetospeed() and cfsetispeed()] instead of having separate branches based on defined(CBAUD). But maybe that has portability problems worse than the current approach. Thanks, Ken

2 2

TRACE () documentation
by James McKenzie July 4, 2010

July 4, 2010

All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you. James McKenzie

4 8

Addition of En resources to non-En resources
by Frédéric Delanoy July 2, 2010

July 2, 2010

Sometimes, when a developer adds a string to En resource file, (s)he adds it as well to all other non-En resource files. Isn't that unnecessary? http://wiki.winehq.org/SublangNeutral says the search order is 1. LANG_NEUTRAL, SUBLANG_NEUTRAL 2. LANG_FRENCH, SUBLANG_FRENCH_BELGIAN 3. LANG_FRENCH, SUBLANG_NEUTRAL 4. LANG_ENGLISH, SUBLANG_ENGLISH_US Would a patch removing En resources in non En rc files be accepted? This would allow for more accurate translation stats. Or doesn't a fallback mechanism always apply? Frédéric

8 25

Re: (Resent) Documentation - Reference to MSDN?
by James Mckenzie July 2, 2010

July 2, 2010

Alexandre Julliard <julliard(a)winehq.org> wrote: > >Erich Hoover <ehoover(a)mines.edu> writes: > >> Alright, well then I won't do it. Is the existing documentation going >> to be stripped at some point? It seems to me like we would benefit >> from more-detailed function descriptions in the auto-generated API >> documentation. I think it would save a lot of time for new developers >> to get their feet wet if they were able to see directly in the source >> what the different functions are supposed to do (as best as we know) >> and exactly what applications will trigger known edge cases (or if >> there's a test for a given situation). > >That's what the source code and test cases are for. If you rely on the >function documentation you are in trouble anyway, nobody bothers to >update it when new behaviors are discovered. > >If you really want to write good API documentation, as opposed to the >current useless one-sentence-per-parameter description, you'd need >probably a text 10 times the size of the source code for each >function. That can't go in the source files. > How about some place on the Wiki along with an implementation status. That way we can also annotate items that are missing in MSDN (I just re-stumbled across something in my latest Richedit tests) as well. This would help greatly in our progress towards current and future implementations of the Windows API. And I agree, adding all of this to the source would make it unwieldy. James McKenzie

5 7

Documentation - Reference to MSDN?
by Max TenEyck Woodbury July 1, 2010

July 1, 2010

I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation) so I have a couple of questions: 1) Would including the URL of the MSDN article be useful/a good idea? 2) Would enumerating coded values and flags be allowed? 3) Where should data structures be documented?

3 2

(Resent) Documentation - Reference to MSDN?
by Max TenEyck Woodbury July 1, 2010

July 1, 2010

I've been reading the Wine code and noticed that some of the external interfaces are practically undocumented. I did a web search on some of the names and found descriptions in MSDN. I realize that copying the information from MSDN directly into the code is a poor idea (like copyright violation) so I have a couple of questions: 1) Would including the URL of the MSDN article be useful/a good idea? 2) Would enumerating coded values and flags be allowed? 3) Where should data structures be documented?

9 17

Creating tests with additional binary modules
by Mariusz Pluciński July 1, 2010

July 1, 2010

Hi, wine-devel I'm working on implementation of Windows Game Explorer interfaces for Wine. The work is in advanced stage now, but I have problem with implementation of conformance tests. Thing I want to test is loading and parsing so-called Game Definition Files. GDF are not separate files, but stored as resources in binary modules (usually in game's main executable). Using GE interfaces, programmer only needs to pass path to binary, and GE automatically loads and process embedded GDF(s). Checking results of routines execution is not problem for me. But thing I test is parser, so I need to pass various GDF files to routine. And, as GDFs are stored in binaries, I will need to create many binaries. They should be created in compile time and available for test's executable while running it. The problem is that I don't know how to do this using wine's mechanisms. How should Makefile.in file look to build additional executable files properly (they should be probably always native win32 executables, even if parameter "crosstest" wasn't specified)? How should I guarantee that these additional executables will be copied into winetest directory (to make them accessible while executing tests)? Thanks in advance Mariusz Pluciński

5 8