June 2010 - Wine-Devel - list.winehq.org

Re: Fully translate partially translated modules in Polish
by Jacek Caban June 3, 2010

June 3, 2010

Hi Łukasz, Great work, but it needs some polishing:-) First of all, please split the patch to the series of smaller patches, preferably one per module. On 6/3/10 11:51 AM, Łukasz Wojniłowicz wrote: > --- > dlls/mshtml/Pl.rc | 18 +- > dlls/setupapi/Pl.rc | 23 + > dlls/shell32/shell32_Pl.rc | 25 +- > dlls/wininet/wininet_Pl.rc | 25 +- > programs/notepad/Pl.rc | 21 +- > programs/reg/Pl.rc | 6 + > programs/regedit/Pl.rc | 14 +- > programs/taskmgr/Pl.rc | 1063 ++++++++++++++++++++----------------- > programs/wineboot/wineboot_Pl.rc | 11 + > programs/winecfg/Pl.rc | 35 +- > programs/winhlp32/Pl.rc | 29 +- > programs/wordpad/Pl.rc | 40 +- > 12 files changed, 762 insertions(+), 548 deletions(-) > mode change 100644 => 100755 programs/taskmgr/Pl.rc > > diff --git a/dlls/mshtml/Pl.rc b/dlls/mshtml/Pl.rc > index 8aa357e..b5713f8 100644 > --- a/dlls/mshtml/Pl.rc > +++ b/dlls/mshtml/Pl.rc > @@ -1,6 +1,7 @@ > /* > * Copyright 2005-2006 Jacek Caban > * Copyright 2008 Mikolaj Zalewski > + * Copyright 2010 £ukasz Wojni³owicz > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -34,9 +35,9 @@ STYLE DS_MODALFRAME | DS_CENTER | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMEN > CAPTION "Instalator Wine Gecko" > FONT 8, "MS Shell Dlg" > { > - LTEXT "Wine could not find a Gecko package which is needed for applications embedding HTML " \ > - "to work correctly. Wine can automatically download and install it for you.\n\n" \ > - "Note: it's recommended to use distro packages instead. See http://wiki.winehq.org/Gecko for details.", > + LTEXT "Wine nie znalaz³o paczki Gecko potrzebnej do prawid³owego dzia³ania aplikacji " \ > That doesn't sound grammatically correct to me. I'd say that it should be "Wine nie znalazł..." or better "Nie znaleziono...". > + "zawieraj¹cych kod HTML . Wine mo¿e automatycznie pobraæ i zainstalowaæ t¹ paczkê dla ciebie.\n\n" \ > + "Notka: Lepiej jednak u¿yæ paczki z twojej dystrybucji. Po szczegó³y zajrzyj na http://wiki.winehq.org/Gecko.", > "Uwaga: " would be better choice IMO. Thanks, Jacek

1 0

Re: Removed sign comparison warning.
by Michael Stefaniuc June 3, 2010

June 3, 2010

Hello Marko, thank you for your patch and welcome to Wine development. While in general patches to make Wine use proper types are accepted there is a slight problem with this patch. On 06/01/2010 11:42 PM, grkoma(a)gmail.com wrote: > From: Marko Nikolic<grkoma(a)gmail.com> > > --- > libs/wine/config.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libs/wine/config.c b/libs/wine/config.c > index 6bb87b0..c04b704 100644 > --- a/libs/wine/config.c > +++ b/libs/wine/config.c > @@ -146,10 +146,10 @@ static char *get_runtime_bindir( const char *argv0 ) > #ifdef linux > for (size = 256; ; size *= 2) > { > - int ret; > + ssize_t ret; > if (!(bindir = malloc( size ))) break; > if ((ret = readlink( "/proc/self/exe", bindir, size )) == -1) break; > - if (ret != size) > + if ((size_t)ret != size) /* Safe to cast, ret is> 0 here */ Having to use a cast to silence a -Wsign-compare is worse than keeping the warning; especially as that is an extra warning not included in the -Wall used by Wine. Though in this specific case by using the proper types the warning can be eliminated without resorting to casts. > { > if (!(p = memrchr( bindir, '/', ret ))) break; > if (p == bindir) p++; bye michael

2 1

Re: Fully translate partially translated modules in Polish
by Paul Vriens June 3, 2010

June 3, 2010

Hi Łukasz On 06/03/2010 11:51 AM, Łukasz Wojniłowicz wrote: > --- > dlls/mshtml/Pl.rc | 18 +- > dlls/setupapi/Pl.rc | 23 + > dlls/shell32/shell32_Pl.rc | 25 +- > dlls/wininet/wininet_Pl.rc | 25 +- > programs/notepad/Pl.rc | 21 +- > programs/reg/Pl.rc | 6 + > programs/regedit/Pl.rc | 14 +- > programs/taskmgr/Pl.rc | 1063 ++++++++++++++++++++----------------- > programs/wineboot/wineboot_Pl.rc | 11 + > programs/winecfg/Pl.rc | 35 +- > programs/winhlp32/Pl.rc | 29 +- > programs/wordpad/Pl.rc | 40 +- > 12 files changed, 762 insertions(+), 548 deletions(-) I think it's better to send separate patches (so 1 per module) although I must admit I don't have such an issue with this as they are translations. Nonetheless it could be worthwhile resending them to potentially avoid any delay once AJ comes back (and maybe he wants them to be split). > mode change 100644 => 100755 programs/taskmgr/Pl.rc > You have to resend anyway because this change is not needed. Thanks for helping the Polish translation get to 100% !! -- Cheers, Paul.

1 0

Re: advapi32/tests: Fixed -Wsign-compare warnings in security tests.
by testbot＠testbot.winehq.org June 3, 2010

June 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2444 Your paranoid android. === W7PROX64 (64 bit security) === security.c:922: Test failed: Access and/or AccessStatus were changed! security.c:939: Test failed: Access and/or AccessStatus were changed! security.c:950: Test failed: Access and/or AccessStatus were changed! security.c:961: Test failed: Access and/or AccessStatus were changed! security.c:972: Test failed: Access and/or AccessStatus were changed! security.c:994: Test failed: Access and/or AccessStatus were changed! security.c:1009: Test failed: Access and/or AccessStatus were changed! security.c:1022: Test failed: Access and/or AccessStatus were changed! security.c:1035: Test failed: Access and/or AccessStatus were changed!

1 0

Re: [msi/tests] Testcases for CREATE TABLE
by testbot＠testbot.winehq.org June 3, 2010

June 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2443 Your paranoid android. === W98SE (32 bit db) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit db) === Timeout

3 2

Re: msi: Update the version strings to match Windows Installer 4.5.
by Hans Leidekker June 3, 2010

June 3, 2010

On Thu, 2010-06-03 at 03:01 -0500, Andrew Nguyen wrote: > This pleases the Actel Libero IDE installer. > --- > dlls/msi/version.rc | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) I think we should delay this until 1.2 is released because it may trigger some installers to use unimplemented functionality in msi.

2 1

Re: gameux: Add declaration of IGameExplorer2 interface
by Vincent Povirk June 2, 2010

June 2, 2010

I think you want to leave the configure change out of this patch. 2010/6/1 Mariusz Pluciński <vshader(a)gmail.com>: > --- > configure | 1 + > configure.ac | 1 + > include/gameux.idl | 16 ++++++++++++++++ > 3 files changed, 18 insertions(+), 0 deletions(-) > > > > > > >

4 6

msacm32: Remove dead "code" from rc files.
by Frédéric Delanoy June 2, 2010

June 2, 2010

7 years old untouched cruft

1 0

Release schedule
by Alexandre Julliard June 2, 2010

June 2, 2010

Folks, The weekly rc schedule won't be quite weekly this week, I'll be out for the next few days so there won't be a release this Friday. The weekly schedule will resume with rc3 next Friday. Don't let that stop you, there are still enough regressions for everybody... -- Alexandre Julliard julliard(a)winehq.org

1 0

GPU driver version reporting
by Seth Shelnutt June 2, 2010

June 2, 2010

I am trying to get folding at home gpu client working. The issue we are having now is that it detects the driver version and says it is not right, and it won't proceed. I've searched through the lines of a WINEDEBUG=+trace and I think the issue is: 0009:trace:d3d:init_driver_info OS version 5.1. 0009:trace:d3d_caps:init_driver_info Found card 10de:05e2 in driver DB. 0009:trace:d3d_caps:init_driver_info Reporting (fake) driver version 0x0006000f-0x000b21aa. It could also be from: 0009:trace:reg:NtSetValueKey (0x14,L"Driver",1,0xff883b94,20) 0009: set_key_value( hkey=0014, type=1, namelen=12, name=L"Driver", data={57,00,49,00,4e,00,45,00,20,00,53,00,43,00,53,00,49,00,00,00} ) But I think that is just trying to set a registry key, not get a registry key (i.e. the driver version from the registry). What I can't figure out is what version this is reporting. I've searched but I can't find this driver DB, so I don't know what 0x0006000f-0x000b21aa corespondent too. Can someone point me in the right directions? Thanks, Seth Shelnutt

3 4