June 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
by James Mckenzie June 24, 2010

June 24, 2010

Henri Verbeet <hverbeet(a)gmail.com wrote: > >On 24 June 2010 18:11, Misha Koshelev <misha680(a)gmail.com> wrote: >> Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I >>will just go down the list of 1.2 milestone bugs for now and see if I can help. >> >Yeah, milestone bugs should generally be ok, as well as any open regressions. > Some of the regression bugs are pre-Wine 1.0. Sad, but if you can fix those, it would greatly help bring Wine code up-to-date. James McKenzie

2 1

Re: [PATCH] [try 4] ddraw: Grow indexbuffer as needed
by Stefan Dösinger June 24, 2010

June 24, 2010

> + while(size < IndexCount * sizeof(WORD)) > + { > + size <<= 1; > + } Thinking about it, is there a reason for growing the buffer in power of two sizes, and not simply set it to the size required for the draw call? E.g. if the app passes index data with a size somewhere between 2^31 and 2^32-1(which still still fits in the UINT variable) the power of two growing will try to create a 2^32 byte buffer which overflows and fails. So you're cutting the possible index buffer size in half. (Of course if an app actually tries to create a >2GB index buffer we have bigger problems than the UINT, especially in a 32 bit process)

2 2

Re: Porting WIne to D
by James Mckenzie June 24, 2010

June 24, 2010

Gert van den Berg <wine-devel(a)mohag.net> wrote: >Like the D website says: >Who D is Not For > * Realistically, nobody is going to convert million line C or C++ >programs into D. Since D does not compile unmodified C/C++ source >code, *D is not for legacy apps*. (However, D supports legacy C API's >very well. D can connect directly to any code that exposes a C >interface.) That should rule out moving Wine to D for a long time. 9 Million + lines of code would make this a lengthy, but not impossible, task. > >D also specifically drops 16-bit support, which might cause problems >for the Win16 / DOS parts of Wine... Another show-stopper for those folks using Wine to run Windows 2.x/3.x programs. James McKenzie

2 1

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
by Misha Koshelev June 24, 2010

June 24, 2010

> > On 24 June 2010 05:18, Misha Koshelev <misha680 at gmail.com> wrote: > > Dan suggested tests ok during code freeze so blame Dan for my patches ;) > Certainly will. wine-devel is an open mailing list, and posting is > easy. You'll probably want to check with something like "git shortlog > -s -n" if the advice you're getting is actually worth taking. The way > I see it, you have more experience with getting patches accepted > yourself. More to the point, if you look at > http://source.winehq.org/patches/, you'll see 62909 is marked as > "Deferred", so resending in a slightly different form isn't going to > help much. Ah I see thank you. I take it this means deferred until post-code freeze (please correct me if incorrect). > > > As for the patch itself, I'm not convinced there's value in having a > separate file for "Shape Drawing Functions", these are clearly mesh > constructors. I thought the original patch was mostly ok in that > regard, although there are (very) minor issues like using %d for > unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 > over simply "IDirect3DDevice9 *". > Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone bugs for now and see if I can help. Post code freeze, I can then start on the d3dx9 stuff as I am really not akin to having my own private repo as of yet and I think that going from a private repo to getting patches into Wine itself might be a little more difficult than I'd like - rather than doing it all at once... So thus for now work on 1.2 milestones. Then D3DX9. Off to work... Misha

2 1

Re: kernel32: Update Gaelic resource
by Michael Stefaniuc June 24, 2010

June 24, 2010

Hello Ken, Ken Sharp wrote: > From: Ken Sharp <kennybobs(a)o2.co.uk> > Date: Tue, 15 Jun 2010 09:42:05 +0100 > Subject: kernel32: Update Gaelic resource the patch changes the file encoding to UTF-8 without changing the "#pragma code_page" too. Though Alexandre already rejected codepage changes to the NLS files during the 1.2 freeze as too risky changes; NLS files are more than just translations. The best thing is to resend the changes without the codepage change. thanks bye michael

1 0

Re: kernel32: Update Gaelic resource
by Dmitry Timoshkov June 24, 2010

June 24, 2010

Ken Sharp <kennybobs(a)o2.co.uk> wrote: > diff --git a/dlls/kernel32/nls/gae.nls b/dlls/kernel32/nls/gae.nls > index 6e19ff4..a005be3 100644 > --- a/dlls/kernel32/nls/gae.nls > +++ b/dlls/kernel32/nls/gae.nls Looks like you are using UTF-8 while the file is in code page 1252. -- Dmitry.

1 0

Porting WIne to D
by Christopher Selph June 24, 2010

June 24, 2010

Hi everyone, new here. I have been fooling around with the idea of porting WIne to the D programming language. What do you think would be the chances of sucess? D has the speed of C, but is a garbage collected language and OOP. D: http://www.digitalmars.com/d Chris

5 4

Re: [PATCH] ddraw: Grow indexbuffer as needed (now with overflow check)
by Stefan Dösinger June 24, 2010

June 24, 2010

Am 24.06.2010 um 11:30 schrieb Mikko Rasa: > On 24.06.2010 12:07, Stefan Dösinger wrote: >> >> Am 23.06.2010 um 21:57 schrieb Mikko Rasa: >>> + if(!size) >>> + { >>> + ERR("UINT overflow while trying to grow indexbuffer to hold %u indices\n", IndexCount); >>> + return D3DERR_TOOMANYPRIMITIVES; >>> + } >>> + } >> You have to release the ddraw lock before returning from the function(LeaveCriticalSection(&ddraw_cs)) > > Doh. Fixed that; anything else that should be rectified before I resubmit? Nothing I can spot so far

1 0

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
by Henri Verbeet June 24, 2010

June 24, 2010

On 24 June 2010 05:18, Misha Koshelev <misha680(a)gmail.com> wrote: > Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like "git shortlog -s -n" if the advice you're getting is actually worth taking. The way I see it, you have more experience with getting patches accepted yourself. More to the point, if you look at http://source.winehq.org/patches/, you'll see 62909 is marked as "Deferred", so resending in a slightly different form isn't going to help much. As for the patch itself, I'm not convinced there's value in having a separate file for "Shape Drawing Functions", these are clearly mesh constructors. I thought the original patch was mostly ok in that regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply "IDirect3DDevice9 *".

1 0

Re: [PATCH 2/7] d3dx9: Add IUnknown method calls to ID3DXMesh.
by Henri Verbeet June 24, 2010

June 24, 2010

On 24 June 2010 05:18, Misha Koshelev <misha680(a)gmail.com> wrote: > +#if !defined(__cplusplus) || defined(CINTERFACE) > +/*** IUnknown methods ***/ > +#define ID3DXMesh_QueryInterface(p,a,b) (p)->lpVtbl->QueryInterface(p,a,b) > +#define ID3DXMesh_AddRef(p) (p)->lpVtbl->AddRef(p) > +#define ID3DXMesh_Release(p) (p)->lpVtbl->Release(p) > +#else > +/*** IUnknown methods ***/ > +#define ID3DXMesh_QueryInterface(p,a,b) (p)->QueryInterface(a,b) > +#define ID3DXMesh_AddRef(p) (p)->AddRef() > +#define ID3DXMesh_Release(p) (p)->Release() > +#endif > + Which version of the DX SDK do these match?

1 0