July 2010 - Wine-Devel - list.winehq.org

Re: comctl32: Simplify is_textT by omitting isW.
by Nikolay Sivov Aug. 15, 2010

Aug. 15, 2010

On 5/9/2010 16:43, Gerald Pfeifer wrote: > isW is not actually used by is_textT, so we can simplify listview.c a > bit by omitting the useless parameter. > > > > -static inline BOOL is_textT(LPCWSTR text, BOOL isW) > +static inline BOOL is_textT(LPCWSTR text) > > There's no reason to keep this helper then. It's better to rename is_textW() to is_text() and remove is_textT().

2 1

Re: gdi32: use usp10 to optionally generate glyphs for bidi strings
by Dmitry Timoshkov Aug. 8, 2010

Aug. 8, 2010

Aric Stewart <aric(a)codeweavers.com> wrote: > allows us to be able to make use of the mirroring code and eventually > the shaping code when it is in place. This should be done the other way around. gdi32 should not depend on a high level dll (that creates circular dependencies), gdi32 in Windows doesn't use usp10 either. -- Dmitry.

4 5

wiki slightly broken still?
by Dan Kegel Aug. 3, 2010

Aug. 3, 2010

Creating new wiki pages seems broken today...

9 15

Re: GetVolumeInformationA: please test this on MS-Windows
by Andrew Eikum Aug. 3, 2010

Aug. 3, 2010

On 07/29/2010 03:43 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Andrew, > >>Run on a Win98SE VM. The E drive is a CDROM drive. > Thank you very much for the result. I added the broken(GetLastError()) for Win9x > based on your data. > > Now is your chance to repeat the test with > https://testbot.winehq.org/JobDetails.pl?Key=4014 > (either as .patch file or the binary from testbot). > This is valuable because testbot skips most new tests, lacking another drive, > giving no proof that the fixed patch indeed works without errors on win9x. > If it fails, please report to wine-devel as I already submitted the new patch. Hi Jörg, No failures with the testbot executable. Run under the same Win98SE VM, again from the E: drive. Andrew

3 7

New winetricks 20100731: new verbs eadm eufonts gfw glut ie8 safari secur32 xlive
by Dan Kegel July 31, 2010

July 31, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: New verbs eadm eufonts gfw (aka xlive) ie8 safari secur32 Turning off MouseWarpOverride should be 'disable' not 'disabled'. (Issue 138) flash, ogg: support silent installs Lots of updates and minor fixes Dan Kegel: New verb glut Mathieu Malaterre: update cmake to 2.8.2 (issue 136)

2 2

Re: [2/2] Try2: imagehlp: Implement ImageGetDigestStream
by Paul Vriens July 31, 2010

July 31, 2010

Hi Andrey, On 07/18/2010 12:39 PM, Andrey Turkin wrote: > +static BOOL IMAGEHLP_ReportImportSection( IMAGE_SECTION_HEADER *hdr, > + DWORD num_sections, BYTE *map, DWORD fileSize, DWORD DigestLevel, > + DIGEST_FUNCTION DigestFunction, DIGEST_HANDLE DigestHandle ) > +{ > + BOOL ret = FALSE; > + DWORD offset, size, base; > + PBYTE import; import is defined here but not used any further down the line. > + > + /* Get import data */ > + offset = IMAGEHLP_GetSectionOffset( hdr, num_sections, ".idata",&size, > +&base ); > + if( !offset ) > + return FALSE; > + > + /* If CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO is set, the entire > + * section is reported. Otherwise, the debug info section is > + * decoded and reported piecemeal. See tests. However, I haven't been > + * able to figure out how the native implementation decides which values > + * to report. Either it's buggy or my understanding is flawed. > + */ > + if( DigestLevel& CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO ) > + ret = IMAGEHLP_ReportSectionFromOffset( offset, size, map, fileSize, > + DigestFunction, DigestHandle ); > + else > + { > + FIXME("not supported except for CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO\n"); > + SetLastError(ERROR_INVALID_PARAMETER); > + ret = FALSE; > + } > + HeapFree( GetProcessHeap(), 0, import ); Only freed. Can 'import' be removed? Coverity complained. -- Cheers, Paul.

1 0

Re: d3dx9: D3DXCreateMeshFVF
by Misha Koshelev July 31, 2010

July 31, 2010

> Instead of implementing D3DXCreateMeshFVF, wouldn't it be better to > implement D3DXCreateMesh and call the latter from D3DXCreateMeshFVF by > previously using D3DXDeclaratorFromFVF? > > D3DXCreateMeshFVF would be pretty straight then: > 1. get the const LPD3DVERTEXELEMENT9 *pDeclaration from the supplied FVF > 2. call D3DXCreateMesh > > BTW, D3DXGetFVFVertexSize could then also be forwarded to > D3DXGetDeclVertexSize and the code simplified. Thank you Thank you. Yes indeed this is the approach that has been recommended by Henri Verbeet as well. Specifically, after the D3DXCreateSphere patch (in some form) is applied to git: http://bugs2.winehq.org/attachment.cgi?id=29947 You can see two patches for tests here: http://bugs2.winehq.org/attachment.cgi?id=29948 http://bugs2.winehq.org/attachment.cgi?id=29949 The only caveat is that we must first implement D3DXFVFFromDeclarator at the very least, as the CreateIndexBuffer call must be (to my understanding) supplied an FVF. Thank you Misha

1 1

d3dx9: D3DXCreateMeshFVF
by Luis Buquets July 31, 2010

July 31, 2010

Instead of implementing D3DXCreateMeshFVF, wouldn't it be better to implement D3DXCreateMesh and call the latter from D3DXCreateMeshFVF by previously using D3DXDeclaratorFromFVF? D3DXCreateMeshFVF would be pretty straight then: 1. get the const LPD3DVERTEXELEMENT9 *pDeclaration from the supplied FVF 2. call D3DXCreateMesh BTW, D3DXGetFVFVertexSize could then also be forwarded to D3DXGetDeclVertexSize and the code simplified.

1 0

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite. (Try 2)
by testbot＠testbot.winehq.org July 30, 2010

July 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4080 Your paranoid android. === WXPPROSP3 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a No test summary line found === W2K3R2SESP2 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a No test summary line found === WVISTAADM (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a No test summary line found === W2K8SE (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a No test summary line found === W7PRO (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a No test summary line found === W7PROX64 (32 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a No test summary line found === W7PROX64 (64 bit hlsl) === hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a Timeout

2 1

Re: [website] Wine 1.3.0 freigegeben
by Frédéric Delanoy July 30, 2010

July 30, 2010

2010/7/30 André Hentschel <nerv(a)dawncrow.de>: > --- > news/de/2010073001.xml | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) > create mode 100644 news/de/2010073001.xml > > -- > > Best Regards, André Hentschel I know you're sending the German translation, but patches commit logs should stay in English IMHO. Imagine everyone sending a log message with their own mother tongue... what would you do in you received a patch with a commit log in, say, Korean... Regards, Frédéric

1 0