July 2010 - Wine-Devel - list.winehq.org

Re: d3d9: add a few tests for GetAdapterDisplayModeEx
by Louis Lenders July 7, 2010

July 7, 2010

On 7 July 2010 23:39, Louis Lenders <xerox_xerox2000 at yahoo.co.uk> wrote: > + todo_wine ok(mode_ex.ScanLineOrdering == D3DSCANLINEORDERING_PROGRESSIVE, >"ScanLineOrdering is %d instead of %d\n", mode_ex.ScanLineOrdering, >D3DSCANLINEORDERING_PROGRESSIVE); > + todo_wine ok(rotation == D3DDISPLAYROTATION_IDENTITY, "rotation is %d >instead of %d\n", rotation, D3DDISPLAYROTATION_IDENTITY); >These obviously depend on the actual setup of the machine running the >test. yeah, you have a suggestion how to change the test, or should i just leave them out of the test? >It also seems likely that you're supposed to initialize >mode_ex.Size before making the GetAdapterDisplayModeEx() call. I did that in the test: test shows that it fails if mode_ex.Size is null, when it is set to sizeof(D3DDISPLAYMODEEX) it returns D3D_OK

2 1

Re: d3d9: add a few tests for GetAdapterDisplayModeEx
by Henri Verbeet July 7, 2010

July 7, 2010

On 7 July 2010 23:39, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > + todo_wine ok(mode_ex.ScanLineOrdering == D3DSCANLINEORDERING_PROGRESSIVE, "ScanLineOrdering is %d instead of %d\n", mode_ex.ScanLineOrdering, D3DSCANLINEORDERING_PROGRESSIVE); > + todo_wine ok(rotation == D3DDISPLAYROTATION_IDENTITY, "rotation is %d instead of %d\n", rotation, D3DDISPLAYROTATION_IDENTITY); These obviously depend on the actual setup of the machine running the test. It also seems likely that you're supposed to initialize mode_ex.Size before making the GetAdapterDisplayModeEx() call.

1 0

fyi d3dx work
by Misha Koshelev July 7, 2010

July 7, 2010

I did end up going with a github repo as I've finally figured out git pretty well (thanks a lot to you guys!) It is here: http://github.com/misha680/wine/commits/master In any case, feel free to peruse if interested. Hopefully when 1.2 is done I can start submitting to wine. Henri especially has been quite helpful with COM interface advice for DirectX, and I appreciate this very much. Misha

1 0

Re: [PATCH 2/2] d3dx9: Test penultimate declaration element in D3DXDeclaratorFromFVFTest.
by James Mckenzie July 7, 2010

July 7, 2010

Alexandre Julliard <julliard(a)winehq.org> wrote: >James McKenzie <jjmckenzie51(a)earthlink.net> writes: > >> Misha Koshelev wrote: >>> --- >>> dlls/d3dx9_36/tests/mesh.c | 6 +++--- >>> 1 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c >>> index a2fb6d8..2952e23 100644 >>> --- a/dlls/d3dx9_36/tests/mesh.c >>> +++ b/dlls/d3dx9_36/tests/mesh.c >>> @@ -262,7 +262,7 @@ static void D3DXDeclaratorFromFVFTest(void) >>> if (hr == D3D_OK) >>> { >>> - for (i=0; i<4; i++) >>> + for (i=0; i<5; i++) >>> >> I don't know about everyone else here, but I prefer to use less than >> or equal to, which I think is what was intended here. This >> positively states the upper bound, which is what I was taught in >> programming classes a long time ago (when ANSI C was still 89...) >> >> Thus this would be >> >> for (i=0; i<=4; i++) > >There's no reason that this would be any better. Please don't give >advice based on folklore you heard in programming classes. > That 'folklore' is called a best practice for programming in 'c'. Maybe things have changed since 1995, but I don't think this is one of them. However, each programmer has their own programming 'style'. They are neither right/wrong, but some are actually better than others. I could really 'bitch' about some of the tests, but this is not the place to do so, nor would it advance this project. I was trying to hand out advice, which YOU obviously think is wrong. Sorry, but I have book to back me up, it is called "Programming in ANSI C" and is dated in 1994. James McKenzie

1 0

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)
by James Mckenzie July 7, 2010

July 7, 2010

Misha Koshelev <misha680(a)gmail.com> wrote: > >Ok per Dan's comments back to <last as this looks nicer. > Misha: Alexandre rejects 'white space' changes, that is changes that fix indentation, remove extraneous or trailing spaces and tabs unless there is another change needed. If there is a needed change in this file, go ahead and fixup white space around the change. Otherwise, hold onto this change in case you need to use it in the future. Your other change was accepted by Alexandre and was committed. James McKenzie

1 0

Re: kernel32 translation
by Gustavo July 7, 2010

July 7, 2010

Em 7 de julho de 2010 05:36, Michael Stefaniuc <mstefani(a)redhat.com> escreveu: > Hello Gustavo, > > Gustavo wrote: >> I'm approaching 100% of translation of wine to Brazilian Portuguese :D > Cool, great job! > >> As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in >> Brazilian Portuguese is actually translated in European Portuguese. As I >> can see, only the "default sublanguages" languages have that file >> translated, so it is supposed to stay that way, isn't it? > Not really. LANG_PORTUGUESE, SUBLANG_PORTUGUESE is the NEUTRAL form not > DEFAULT. DEFAULT sublang for Portuguese is SUBLANG_PORTUGUESE_BRAZILIAN. > You can see it on > http://source.winehq.org/transl/resfile.php?lang=016%3A01&resfile=dlls%2Fke… > "resource MESSAGE #1: Translation inherited from Portuguese (Neutral)" > > If the pt_BR translation of those messages is different you can copy > winerr_ptg.mc to winerr_ptb.mc and adapt it for > SUBLANG_PORTUGUESE_BRAZILIAN. The magic number for pt_BR is: > LanguageNames=(PTB=0x0116:winerr) Ok, I understand, but wouldn't it be 0x0416? That's what it says in locale_rc.rc: #include "nls/ptb.nls" /* 0x0416 LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN */

3 5

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 3)
by Frédéric Delanoy July 7, 2010

July 7, 2010

On Wed, Jul 7, 2010 at 15:55, Misha Koshelev <misha680(a)gmail.com> wrote: > Ok, sorry, fixed per Henri's _and_ James' comments. > > Misha > > p.s. If I can ask for a _huge_ favor, I read wine-devel online and I guess I miss some of the messages. If you guys wouldn't mind > cc'ing me on my patches just in case much appreciated. Thx. > --- > dlls/d3dx9_36/tests/mesh.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c > index 8e4e26d..a2fb6d8 100644 > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -269,7 +269,7 @@ static void D3DXDeclaratorFromFVFTest(void) > ok(decl[i].Method == exp1[i].Method, "Returned method %d, expected %d\n", decl[i].Method, exp1[i].Method); > ok(decl[i].Usage == exp1[i].Usage, "Returned usage %d, expected %d\n", decl[i].Usage, exp1[i].Usage); > ok(decl[i].UsageIndex == exp1[i].UsageIndex, "Returned usage index %d, expected %d\n", decl[i].UsageIndex, exp1[i].UsageIndex); > - ok(decl[i].Offset == exp1[i].Offset, "Returned offset %d, expected %d\n", decl[1].Offset, exp1[i].Offset); > + ok(decl[i].Offset == exp1[i].Offset, "Returned offset %d, expected %d\n", decl[1].Offset, exp1[i].Offset); > } > ok(decl[5].Stream == 0xFF, "Returned too long vertex declaration\n"); /* end element */ > } > -- > 1.7.1 Formatting-only patches are not accepted by AJ. See http://wiki.winehq.org/DeveloperFaq#head-1e5a50563dbdb221702cbde246b23f5de0… Frédéric

1 0

Re: shlwapi/tests: set last error like Win7
by Alexandre Julliard July 7, 2010

July 7, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > This only applies to SHFormatDateTimeA, not to SHFormatDateTimeW... There's no reason to do this. 0 is not a valid last error anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)
by Marcus Meissner July 7, 2010

July 7, 2010

On Wed, Jul 07, 2010 at 10:28:17AM -0500, Misha Koshelev wrote: > Ok per Dan's comments back to <last as this looks nicer. > > This is my last try on these patches unless I hear from Alexandre. > > Misha > --- > dlls/d3dx9_36/tests/mesh.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c > index 8e4e26d..a2fb6d8 100644 > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -269,7 +269,7 @@ static void D3DXDeclaratorFromFVFTest(void) > ok(decl[i].Method == exp1[i].Method, "Returned method %d, expected %d\n", decl[i].Method, exp1[i].Method); > ok(decl[i].Usage == exp1[i].Usage, "Returned usage %d, expected %d\n", decl[i].Usage, exp1[i].Usage); > ok(decl[i].UsageIndex == exp1[i].UsageIndex, "Returned usage index %d, expected %d\n", decl[i].UsageIndex, exp1[i].UsageIndex); > - ok(decl[i].Offset == exp1[i].Offset, "Returned offset %d, expected %d\n", decl[1].Offset, exp1[i].Offset); > + ok(decl[i].Offset == exp1[i].Offset, "Returned offset %d, expected %d\n", decl[1].Offset, exp1[i].Offset); In general whitespace changes have nearly no chance of acceptance. Especially in this late RC phase of 1.2. Fix whitespace issues in code you change, leave it alone otherwise. Ciao, Marcus

1 0

Re: sane.ds: Change "ns" to "ms" in resource files
by Alexandre Julliard July 7, 2010

July 7, 2010

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Apparently the English resource file should show "ms" (microseconds) > instead of "ns". This error has been copied too all the .rc files. "ms" doesn't mean microseconds. -- Alexandre Julliard julliard(a)winehq.org

4 6