July 2010 - Wine-Devel - list.winehq.org

Re: [4/5] d3d9: Skip YUV tests when encountering a broken driver
by Henri Verbeet July 5, 2010

July 5, 2010

On 3 July 2010 23:59, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + ok(broken(TRUE), "U and V channels swapped on Non-Windows driver\n"); > + skip("Windows driver confuses U and V channels, skipping test\n"); You should use win_skip().

1 0

Re: [2/5] d3d9: The depth clamp test fails on Nvidia Windows drivers
by Henri Verbeet July 5, 2010

July 5, 2010

I'm not sure blindly marking these as broken is the way to go. Either way, ddraw and d3d8 have the same failure.

1 0

Re: [1/5] d3d9: Ignore a Windows 7 failure in the d3d9 depth clamp test
by Henri Verbeet July 5, 2010

July 5, 2010

You might as well just set the initial value to 1.0. Note that this seems to succeed on at least some setups though: http://test.winehq.org/data/4d3aec55ea41cb0f47a9da82de1665ad1b16f3de/win7_W… Also, does this work for the d3d8 version of the test?

1 0

re: Missing romanian characters in some fonts + winetricks feature request
by Dan Kegel July 5, 2010

July 5, 2010

The right place for winetricks feature requests is the winezeug issue tracker. I've filed http://code.google.com/p/winezeug/issues/detail?id=134 for the eu font update request.

2 2

Re: kernel32.dll: implementation of GetVolumePathNamesForVolumeNameA/W
by Dmitry Timoshkov July 4, 2010

July 4, 2010

Tuomo Mattila <tuomom(a)ee.oulu.fi> wrote: > +BOOL WINAPI GetVolumePathNamesForVolumeNameA(LPCSTR volumename, LPSTR volumepathname, DWORD buflen, PDWORD returnlen) > +{ > + > + BOOL ret = FALSE; > + WCHAR* volumenameW = 0; > + LPWSTR volumepathnameW = 0; > + > + if (volumename == 0 || volumepathname == 0 || returnlen == 0) > + { > + SetLastError(RPC_X_NULL_REF_POINTER); > + return FALSE; > + } It's a common practice to use NULL for pointers, and not 0. Something tells me that RPC_xxxx error code has nothing to do here, do you have a test case for that? > + memset(volumepathname, 0, buflen); Is there any reason that you zero out the whole 'volumepathname' here? > + volumepathnameW = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, buflen*sizeof(WCHAR)); > + if (volumepathnameW == 0) return FALSE; Same for 'volumepathnameW' here. > + if ((volumenameW = FILE_name_AtoW(volumename, TRUE)) == 0) return FALSE; > + > + ret = GetVolumePathNamesForVolumeNameW(volumenameW, volumepathnameW, buflen, returnlen); > + if (*returnlen > 0) > + FILE_name_WtoA(volumepathnameW, (*returnlen), volumepathname, (*returnlen)); There is no need to put '*returnlen' in braces. Besides, '*returnlen' may differ for multibyte and unicode strings. -- Dmitry.

1 0

Re: libs/wine: get_decomposition is not used in that file
by Dmitry Timoshkov July 4, 2010

July 4, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > --- a/libs/wine/sortkey.c > +++ b/libs/wine/sortkey.c > @@ -19,7 +19,6 @@ > */ > #include "wine/unicode.h" > > -extern int get_decomposition(WCHAR src, WCHAR *dst, unsigned int dstlen); > extern const unsigned int collation_table[]; There is a commented out reference to get_decomposition() in that file, so you need to remove it as well. But better make it used, and figure out why it was commented out in the first place. -- Dmitry.

1 0

FAQ on Nautilus needed?
by David Gerard July 4, 2010

July 4, 2010

http://wiki.winehq.org/FAQ#head-d3f53179ea4e0d7c90cf330e50030b1e14b63811 10.3. Nautilus can delete your home directory when you empty the trash! This affected GNOME 2.21.90-91. This is a rather old version of GNOME. Hass this problem come up in recent times? Is there any current *nix that uses GNOME 2.21.90 or 2.21.91? - d.q

2 1

re: base addresses of kernel32
by Dan Kegel July 4, 2010

July 4, 2010

>> the Makefile has: >> EXTRADLLFLAGS = -Wb,-F,KERNEL32.dll -Wl,--image-base,0x7b800000 > >Is there a good reason for this? Otherwise, this opens a security >vulnerability in Wine that does not exist in Windows.... This is the way Windows worked before Vista. (Does Vista actually randomize where even ntdll is?) BTW our CreateRemoteThread conformance test checks whether the module has been loaded at a different address, and skips if it has...

3 2

Please review: Patch for non-Linux serial set_baud_rate()
by Ken Thomases July 4, 2010

July 4, 2010

Hi, I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems clearly right and conforms to what I learn from man pages, etc. So, I'm hoping somebody who is more familiar with this functionality can review the attached patch before I formally submit it. Another approach that seems better from my reading of the man pages is to switch to using cfsetspeed() [or cfsetospeed() and cfsetispeed()] instead of having separate branches based on defined(CBAUD). But maybe that has portability problems worse than the current approach. Thanks, Ken

2 2

TRACE () documentation
by James McKenzie July 4, 2010

July 4, 2010

All: Is there documentation anywhere on how to use the TRACE command? I am trying to print out the contents of a UNICODE string using this commnd. Thank you. James McKenzie

4 8