July 2010 - Wine-Devel - list.winehq.org

Re: [2/2] d3dx9: Implement D3DXCreateTextureFromFileInMemoryEx
by Henri Verbeet July 27, 2010

July 27, 2010

On 26 July 2010 23:05, Owen Rudge <owen(a)owenrudge.net> wrote: > + if ((filter & 0xFFFF) > D3DX_FILTER_BOX && filter != D3DX_DEFAULT) > + return D3DERR_INVALIDCALL; > + > + if ((mipfilter & 0xFFFF) > D3DX_FILTER_BOX && mipfilter != D3DX_DEFAULT) > + return D3DERR_INVALIDCALL; > + > + if (!filter || !mipfilter) > + return D3DERR_INVALIDCALL; I think those should be handled implicitly by D3DXLoadSurfaceFromFileInMemory() / D3DXFilterTexture(). Provided you check the return values anyway. > + if (filter == D3DX_DEFAULT) > + filter = D3DX_FILTER_TRIANGLE | D3DX_FILTER_DITHER; > + > + if (mipfilter == D3DX_DEFAULT) > + mipfilter = D3DX_FILTER_BOX; Same. > + if (width == 0 || width == D3DX_DEFAULT_NONPOW2) > + width = imginfo.Width; Probably depends on the device supporting NPOT textures again. > + if ((pool != D3DPOOL_DEFAULT) && (usage != D3DUSAGE_DYNAMIC)) Dynamic textures are a device capability.

1 0

Re: [1/2] d3dx9: Implement missing D3DXCreateTextureFromFile functions
by Henri Verbeet July 27, 2010

July 27, 2010

On 26 July 2010 23:05, Owen Rudge <owen(a)owenrudge.net> wrote: > +HRESULT WINAPI D3DXCreateTextureFromFileInMemory(LPDIRECT3DDEVICE9 device, > + LPCVOID srcdata, > + UINT srcdatasize, > + LPDIRECT3DTEXTURE9 *texture) Please don't use those, just write "IDirect3DTexture9 **", "const void *", etc. Also, srcdatasize is unsigned. > + TRACE("(void): relay\n"); That's doesn't really match the function arguments.

1 0

Re: mshtml: Improve status messages sent to IOleInPlaceFrame
by Jacek Caban July 27, 2010

July 27, 2010

Hi Alexander, On 7/26/10 11:36 AM, Alexander Nicolaysen Sørnes wrote: > In preparation for adding a status bar to Wine's IE - static const WCHAR wszDone[] = {'D','o','n','e',0}; + static WCHAR wszDone[40] = { 0 }; + + if(!wszDone[0]) + LoadStringW(hInst, IDS_DONE, wszDone, sizeof(wszDone)/sizeof(wszDone[0])); IOleInPlaceFrame_SetStatusText(doc_obj->frame, wszDone); SetStatusText call really deserves a helper function that would take care of loading the string resources instead of duplicating the code. @@ -44,6 +45,7 @@ typedef struct { task_t header; HTMLDocumentObj *doc; BOOL set_download; + BSTR url; } download_proc_task_t; You don't need this, URL is stored in HTMLWindow object at this point. Jacek

2 1

Re: [2/2] ntdll: Fix the status code for ProcessDebugObjectHandle class in NtQueryInformationProcess when the debugger is ab
by testbot＠testbot.winehq.org July 27, 2010

July 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3961 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: dmusic: use a previously unused variable (try 3)
by Octavian Voicu July 27, 2010

July 27, 2010

On Tue, Jul 27, 2010 at 9:36 AM, Austin English <austinenglish(a)gmail.com> wrote: > Try 3: Use tabs, not spaces. > Try 2: return hr, free memory There's still a memory leak in this function if IDirectMusicPortImpl_QueryInterface fails. Would be nice to fix that also :) Octavian

1 0

[website] Update French translation of 'About Wine' page
by Frédéric Delanoy July 27, 2010

July 27, 2010

1 0

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)
by Michael Stefaniuc July 27, 2010

July 27, 2010

Hello Austin, Austin English wrote: > There were no test results on winehq today. Seems everyone's exceeding > 1.5. Guess some new tests today have a lot of output... wouldn't it make more sense to have a global variable 'max_filesize' instead of duplicating the magic constants all over the place? > diff --git a/programs/winetest/send.c b/programs/winetest/send.c > index 11c9f33..9fc4b81 100644 > --- a/programs/winetest/send.c > +++ b/programs/winetest/send.c > @@ -155,11 +155,11 @@ send_file_direct (const char *name) > goto abort1; > } > filesize = GetFileSize( file, NULL ); > - if (filesize > 1.5*1024*1024) { > + if (filesize > 1.75*1024*1024) { > report (R_WARNING, > - "File too big (%.1f MB > 1.5 MB); submitting partial report.", > + "File too big (%.1f MB > 1.75 MB); submitting partial report.", > filesize/1024.0/1024); > - filesize = (DWORD) 1.5*1024*1024; > + filesize = (DWORD) 1.75*1024*1024; > } > > report (R_STATUS, "Sending header"); > @@ -298,11 +298,11 @@ send_file_wininet (const char *name) > } > > filesize = GetFileSize( file, NULL ); > - if (filesize > 1.5*1024*1024) { > + if (filesize > 1.75*1024*1024) { > report (R_WARNING, > - "File too big (%.1f MB > 1.5 MB); submitting partial report.", > + "File too big (%.1f MB > 1.75 MB); submitting partial report.", > filesize/1024.0/1024); > - filesize = 1.5*1024*1024; > + filesize = 1.75*1024*1024; > } > > report (R_STATUS, "Opening HTTP connection to " SERVER_NAME); bye michael

1 0

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)
by Paul Vriens July 27, 2010

July 27, 2010

On 07/27/2010 03:48 AM, Austin English wrote: > There were no test results on winehq today. Seems everyone's exceeding > 1.5. Guess some new tests today have a lot of output... > I do see output for July 26th or am I missing something? We could use a volunteer to implement compression for the winetest reports. -- Cheers, Paul.

3 2

Re: kernel32: add a test for CreateFileA() (try 3)
by Andrew Nguyen July 27, 2010

July 27, 2010

On Tue, Jul 27, 2010 at 12:53 AM, Austin English <austinenglish(a)gmail.com> wrote: > Addressing Nikolay and Dmitry's comments. > > Passed wtb: > https://testbot.winehq.org/JobDetails.pl?Key=3947 > > -- > -Austin > > > You forgot to attach the patch.

1 0

Re: dmusic: remove unused variable (try 2)
by Andrew Nguyen July 27, 2010

July 27, 2010

On Tue, Jul 27, 2010 at 12:59 AM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > > The source file seems to use tabs for indentation, so your patch should do the same.

1 0