August 2010 - Wine-Devel - list.winehq.org

Re: [3/3] d3dcompiler: Move D3DAssemble tests from d3dx9_36.
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4739 Your paranoid android. === WINEBUILD (build) === Reconfig failed

1 0

Re: [4/4] oleaut32/tests: Some tests for IPicture::get_Handle()
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4738 Your paranoid android. === W7PROX64 (64 bit olepicture) === olepicture.c:796: Test failed: got 0 olepicture.c:808: Test failed: got 0

1 0

Re: [3/4] oleaut32/olepicture: Fix ::get_hPal() behaviour for certain picture types
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4737 Your paranoid android. === W7PROX64 (64 bit olepicture) === olepicture.c:765: Test failed: got 0 olepicture.c:777: Test failed: got 0

1 0

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized
by Stefan Dösinger Aug. 24, 2010

Aug. 24, 2010

Hi, Can you add a test that tests in which mode ddraw is after such a call? Specfically, try to create a double buffered primary surface. If this succeeds, ddraw is in fullscreen mode. If ddraw is in normal mode you'll get DDERR_NOEXCLUSIVEMODE (or similar) back. Am 24.08.2010 um 10:00 schrieb David Adam: > Fixed a typo > > A+ > > David > <0001-SetCooperativeLevel-with-Full-screen-exclusive-norma.patch>

2 5

re: wine.inf: added .NET InstallRoot key
by Dan Kegel Aug. 24, 2010

Aug. 24, 2010

What is our intent with adding all these registry keys? It seems as if they are helpful for installing mono, but might get in the way of installing MS .net. If that's the intent, do y'all want me to make the dotnet20 winetricks verb remove any registry keys that confuse the dotnet20 installer?

5 6

Re: msvcrt:locale Remove todo_wine and add broken when necessary
by Octavian Voicu Aug. 24, 2010

Aug. 24, 2010

On Tue, Aug 24, 2010 at 12:44 PM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > - todo_wine ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of China.936") > + ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of China.936") > + || broken(!strcmp(ret, "Chinese_People's Republic of China.936")) broken() only works for tests that fail on some Windows versions; it has no effect on Wine, see [1]. Proper way to fix this bug is to make setlocale replicate Windows behavior. Octavian [1] http://source.winehq.org/git/wine.git/?a=blob;f=include/wine/test.h;h=1a980…

2 1

Wine Gecko 1.1.0 RC1
by Luca Bennati Aug. 24, 2010

Aug. 24, 2010

Applied the patch to master, recompiled ok. I put the rc1 cab in /usr/share/wine/gecko/, as always. In the creation of a new prefix, it gave me an err which wasn't there before: err:mshtml:init_xpcom AutoRegister(NULL) failed: 80070057 but 'wine iexplore' works better than before (sites that crashed wine before don't crash it anymore). I investigated it a bit recreating a new prefix with 'WINEDEBUG=+mshtml winecfg' and here's the log: wine: created the configuration directory '/home/luca/.wine' trace:mshtml:register_server (1) trace:mshtml:load_gecko () trace:mshtml:install_cab (L"Z:\\usr\\bin\\..\\share\\wine\\gecko\\wine_gecko-1.1.0-rc1-x86.cab") trace:mshtml:check_version "Wine Gecko 1.1.0-rc1" trace:mshtml:load_xpcom (L"C:\\windows\\system32\\gecko\\1.1.0-rc1\\wine_gecko") fixme:system:SetProcessDPIAware stub! trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsISupports 0x33d374) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33d214) trace:mshtml:nsDirectoryServiceProvider_GetFile ("GreD" 0x33d2ec 0x33d2e8) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33d214) trace:mshtml:nsDirectoryServiceProvider_GetFile ("XCurProcD" 0x33d2ec 0x33d2e8) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33bfc4) trace:mshtml:nsDirectoryServiceProvider_GetFile ("PrfDef" 0x33c09c 0x33c098) warn:mshtml:nsDirectoryServiceProvider_QueryInterface ({2f977d4b-5485-11d4-87e2-0010a4e75ef2} 0x33bff4) warn:mshtml:nsDirectoryServiceProvider_QueryInterface ({2f977d4b-5485-11d4-87e2-0010a4e75ef2} 0x33bff4) fixme:iphlpapi:NotifyAddrChange (Handle 0xf5e914, overlapped 0xf5e918): stub trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33bc64) trace:mshtml:nsDirectoryServiceProvider_GetFile ("AChrom" 0x33bd3c 0x33bd38) err:mshtml:init_xpcom AutoRegister(NULL) failed: 80070057 trace:mshtml:nsIOService_GetProtocolHandler ("file" 0x33cff8) trace:mshtml:nsIOService_NewURI ("file:///C:/windows/system32/gecko/1.1.0-rc1/wine_gecko/components/nsTryToClose.js" (null) (nil) 0x33d15c) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33ccb4) trace:mshtml:nsDirectoryServiceProvider_GetFile ("ProfDS" 0x33cd8c 0x33cd88) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33ccb4) trace:mshtml:nsDirectoryServiceProvider_GetFile ("ProfD" 0x33cd8c 0x33cd88) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33ccb4) trace:mshtml:nsDirectoryServiceProvider_GetFile ("ProfLDS" 0x33cd8c 0x33cd88) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33ccb4) trace:mshtml:nsDirectoryServiceProvider_GetFile ("ProfLD" 0x33cd8c 0x33cd88) trace:mshtml:nsIOService_NewURI ("resource://gre/modules/XPCOMUtils.jsm" (null) (nil) 0x33acb8) trace:mshtml:nsDirectoryServiceProvider_QueryInterface (IID_nsIDirectoryServiceProvider 0x33851c) trace:mshtml:nsDirectoryServiceProvider_GetFile ("CurProcD" 0x3385f4 0x3385f0) trace:mshtml:nsIOService_NewFileURI (0x7613b8 0x338674) trace:mshtml:nsIOService_NewFileURI (0x7613b8 0x338674) trace:mshtml:nsIOService_NewURI ("jar:chrome/toolkit.jar!/res/" (null) 0x75f6c8 0x3386e4) trace:mshtml:nsIOService_ExtractScheme ("jar:chrome/toolkit.jar!/res/" 0x3363d0) trace:mshtml:nsIOService_NewURI ("chrome/toolkit.jar!/res/" "" 0x75f6c8 0x7613cc) trace:mshtml:nsIOService_NewURI not wraping trace:mshtml:nsIOService_NewChannelFromURI (0x75fa90 0x33acb4) trace:mshtml:nsIOService_NewChannelFromURI Could not get nsWineURI: 80004002 trace:mshtml:nsIOService_NewChannel ("file:///C:/windows/system32/gecko/1.1.0-rc1/wine_gecko/modules/XPCOMUtils.jsm" (null) (nil) 0x33acb4) trace:mshtml:close_gecko () wine: configuration in '/home/luca/.wine' has been updated. Hope it helps :)

2 1

Re: mscoree: improve GetCORVersion
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4727 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized
by Henri Verbeet Aug. 24, 2010

Aug. 24, 2010

This looks suspicious to me, you have to assume the code wasn't just added for the hell of it, even though with ddraw you're never quite sure. Do other ddraw versions behave the same? Please don't add trailing spaces, neither in the code nor in TRACEs.

2 1

Re: explorerframe/tests: Add a trailing '\n' to an ok() call.
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4711 Your paranoid android. === W2K8SE (32 bit nstc) === nstc.c:1889: Test failed: Got event 7, count 0 nstc.c:1891: Test failed: Got event 4, count 0 nstc.c:1898: Test failed: Got event 6, count 1 nstc.c:1904: Test failed: Got event 4, count 0 nstc.c:1956: Test failed: Got event 7, count 0 nstc.c:1965: Test failed: Item not expanded. nstc.c:1968: Test failed: itemstate is 0x00000000 nstc.c:1985: Test failed: itemstate is 0x00000000 nstc.c:2111: Test failed: Got event 7, count 0 nstc.c:2118: Test failed: itemstate is 0x00000000 nstc.c:2142: Test failed: itemstate is 0x0000000c nstc.c:2157: Test failed: itemstate is 0x0000000c nstc.c:2171: Test failed: itemstate is 0x00000004 nstc.c:2183: Test failed: itemstate is 0x00000004 nstc.c:2240: Test failed: Got event 7, count 0 nstc.c:2245: Test failed: Got (0x80004005) nstc.c:2246: Test failed: psi is 00000000

1 0

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4710 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/5] server: move is_removeable to fd_ops
by Mike Kaplinskiy Aug. 24, 2010

Aug. 24, 2010

2 1

How managing crashing tests ?
by GOUJON Alexandre Aug. 24, 2010

Aug. 24, 2010

Hi guys, A patch has been committed today saying "Make .. crashing like it does on native". I know we have to follow (genuine) Windows behavior but I'm wondering how to handle these cases. For instance, how to add a test crashing on every Windows ? Is it useful ? I mean, none program can rely on it .. since it crashes. Anyway, I've seen mainly two approaches - if(0) - /* comment the crashing ok() */ What's the difference ? And why not #if 0 ? I maybe lack some basic C knowledges but I think that /**/ and #if 0 are not added to the executable (from preprocessing stage). If it's right, it means we can then 'enable' these blocks maybe with (gdb) edit something And what about a test crashing on a specific Windows ? I guess #ifdef CRASHES_ON_NT40 is not an elegant way (even if it's currently used). Commenting such tests prevent us to check wine behavior on 'working' Windows. I attempted to use __TRY ... __EXCEPT_PAGE_FAULT in a test but it got rejected. Any advice ? Thanks

2 2

Re: ddraw/tests: New visual back buffer flipping tests. (resend)
by Octavian Voicu Aug. 24, 2010

Aug. 24, 2010

2010/8/23 Oldřich Jedlička <oldium.pro(a)seznam.cz>: > + // Check it out You have a C++ style comment in this patch and I don't think it's allowed. Octavian

3 2

Re: user32: Optimize the storage of default values
by Dmitry Timoshkov Aug. 24, 2010

Aug. 24, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > -static const char * const DefSysColors[] = > +static struct { > + const char *name; > + const COLORREF rgb; > +} DefSysColors[] = It should be 'static const struct {'. -- Dmitry.

1 0

RFC: test of 16 bit wine (DOS)
by Morten Rønne Aug. 24, 2010

Aug. 24, 2010

Hi I have been working on creating tests for the 16 bit implementation of wine, and now I have come so far that I would like some comments on the way I have chosen to do it. 16 bit programs require a compiler that is able to create the old style address method in order to be able to test those parts of wine. I have been told by Dmitry Timoshkov that I should use OpenWatcom for that. So that is what I have done. OpenWatcom also supports building DOS32 (using a number of extenders) and WIN 3.x programs. Since the DOS program can't run in the current test enviroment, because that is new style 32 bit address method, I am using a wrapper program which start the old style program from the 32 bit environment. The wrapper also makes it possible to do a skip message in case the needed DOS program is missing (due to no OpenWatcom compiler). In order to be able to create a stand-alone DOS program I have modified the wine/test.h file so that certain parts got omitted, while others were added. This means that writing a DOS test will be the same as writing normal 32 bit tests, except that you include a different test include file. The current version uses the define __WINE_WINE_DOS16_TEST_H from the include file that defines the DOS environment, since I haven't been able to find a better name. Suggestions for a better name are most welcome. The DOS test it self, is only a very simple one because I consider this more a proof of concept than a full test. Also a full test will require a number of changes in the current 16 bit tree to move a number of definitions from .c files to .h files so the test can reference them. Once this have been commited work can start towards making more complete test of the 16 bit environment. I hope that the naming will make Wine Testbot able to detect changes to the test suite. As can be seen above the OpenWatcom compiler is needed to build the DOS 16 bit programs. Currently only Linux 32 bit platform is supported. The compiler can't be built on 64 bit yet, this includes Mac. The easiest way to install the compiler is to download the binary installer from: http://www.openwatcom.org/index.php/Download Select one of the mirrors and download the file: open-watcom-c-linux-1.9 Ignore the fact that the main download page points to other places to get the linux version. This is a binary program that you have to run. It will ask you were to install OpenWatcom and all files will be installed under that tree. After that you must add a definition of WATCOM to your shell profile, pointing it to the directory you selected. After that change PATH to search in $WATCOM/binl as the LAST thing. Watcom includes programs that are called the same as some wine programs (wrc for one), so be sure you don't find these by searching OpenWatcom last. As a note I can tell that Debian have rejected the Sybase license (under which OpenWatcom is released) as not being free, and therefore there will be no official debian packages of OpenWatcom. Best Regards Morten Rønne

2 1

Re: ddraw/tests: New visual back buffer flipping tests. (try 2)
by Octavian Voicu Aug. 24, 2010

Aug. 24, 2010

2010/8/24 Oldřich Jedlička <oldium.pro(a)seznam.cz>: > + ok((GetRValue(color) == 0xFF && GetGValue(color) == 0xFF && GetBValue(color) == 0xFF) || > + broken(GetRValue(color) == 0xFF && GetGValue(color) == 0 && GetBValue(color) == 0), // broken driver > + "got R %02X G %02X B %02X, expected R FF G FF B FF\n", > + GetRValue(color), GetGValue(color), GetBValue(color)); I hate to be the bearer of bad news, but you missed one :)

2 1

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your paranoid android. === WINEBUILD (build) === Make failed

3 3

Re: ddraw: SetCooperativeLevel with Full screen + exclusive + normal is authorized
by testbot＠testbot.winehq.org Aug. 23, 2010

Aug. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4696 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: gdiplus: add a stub for GdipWindingModeOutline
by Vincent Povirk Aug. 23, 2010

Aug. 23, 2010

You need to add it to the .spec file too. On Mon, Aug 23, 2010 at 4:45 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > >

2 1

Re: d3dx9: Implement D3DXDeclaratorFromFVF.
by Henri Verbeet Aug. 23, 2010

Aug. 23, 2010

On 20 August 2010 21:16, Misha Koshelev <misha680(a)gmail.com> wrote: > Thank you for your helpful feedback on my tests. > > This is based mostly on dlls/d3d9/vertexdeclaration.c with some > changes specific to D3DXDeclaratorFromFVF. > > Again, if there are any suggested changes please let me know. > As you already mentioned, this is pretty much another copy/paste implementation, including e.g. the useless macros and typedef.

2 4

re: New winetricks 20100822: new verb lucida
by Dan Kegel Aug. 23, 2010

Aug. 23, 2010

Jacek wrote: > I still hope that gecko will be removed from winetricks at some point. > It clearly doesn't belong to winetricks. That would be nice. Does every distro install wine-gecko yet? > Also fakeie6 doesn't make sense anymore. We set these registries > by default for over 2.5 years now. OK, deleted. - Dan

2 1

Re: configure: Enable prelink on x86_64
by Alexandre Julliard Aug. 23, 2010

Aug. 23, 2010

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From 98e8cc5d0b5b2d397c1d904d2537c326ed36d43c Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Stefan=20D=C3=B6singer?= <stefan(a)codeweavers.com> > Date: Sun, 22 Aug 2010 19:49:58 +0200 > Subject: [PATCH 4/4] Enable prelink on x86_64 Which app needs this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: avifil32: Removed sign comparison warning (sizeof expresions)
by Michael Stefaniuc Aug. 23, 2010

Aug. 23, 2010

Marko Nikolic wrote: > sizeof expresion always return unsigned type, so it is casted > when comparing with signed values. This is ugly. > --- > dlls/avifil32/wavfile.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/avifil32/wavfile.c b/dlls/avifil32/wavfile.c > index fd6d9ec..3fc934c 100644 > --- a/dlls/avifil32/wavfile.c > +++ b/dlls/avifil32/wavfile.c > @@ -803,7 +803,7 @@ static HRESULT WINAPI IAVIStream_fnSetFormat(IAVIStream *iface, LONG pos, > TRACE("(%p,%d,%p,%d)\n", iface, pos, format, formatsize); > > /* check parameters */ > - if (format == NULL || formatsize <= sizeof(PCMWAVEFORMAT)) > + if (format == NULL || formatsize <= (LONG)sizeof(PCMWAVEFORMAT)) IMHO gcc is *wrong* in emitting a warning there. sizeof(PCMWAVEFORMAT) is a compile time constant and gcc can see that sizeof(PCMWAVEFORMAT) falls well inside the number range expressible by a LONG. Logically there is no difference between formatsize <= sizeof(PCMWAVEFORMAT) and formatsize <= 16 One gives a bogus warning and the other doesn't. bye michael

4 6

Re: [PATCH 1/3] msvcp90/tests: Added basic_string<char> tests (try2)
by testbot＠testbot.winehq.org Aug. 23, 2010

Aug. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4681 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: New winetricks 20100822: new verb lucida
by James Mckenzie Aug. 23, 2010

Aug. 23, 2010

Scott Ritchie <scott(a)open-vote.org> wrote: >Sent: Aug 23, 2010 6:37 AM >To: Wine Devel <wine-devel(a)winehq.org> >Subject: Re: New winetricks 20100822: new verb lucida > >On 08/23/2010 05:01 AM, Jacek Caban wrote: >> Hi Dan, >> >> On 8/22/10 8:57 PM, Dan Kegel wrote: >>> Dan Kegel: >>> gecko: make it work even if WINE isn't set. (How did this get >>> through?) >> >> I still hope that gecko will be removed from winetricks at some point. >> It clearly doesn't belong to winetricks. >> >> Also fakeie6 doesn't make sense anymore. We set these registries by >> default for over 2.5 years now. >> > >Well on Ubuntu at least installing the Wine package will pull in the >wine-gecko package and all will be well in the world. This is the >ultimate path forward, I think. > Any word from the RedHat/CentOS/Fedora crowd? I have to fix the video on my laptop (it's just messed up) and then I can check if this happens on CentOS 5.5 as well. James McKenzie

1 0

Re: [PATCH] ntdll: set correct protection flags on sections in builtin DLLs
by Alexandre Julliard Aug. 23, 2010

Aug. 23, 2010

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -1406,7 +1409,18 @@ static void load_builtin_callback( void *module, const char *filename ) > } > virtual_create_system_view( module, nt->OptionalHeader.SizeOfImage, > VPROT_SYSTEM | VPROT_IMAGE | VPROT_COMMITTED | > - VPROT_READ | VPROT_WRITECOPY | VPROT_EXEC ); > + VPROT_READ | VPROT_WRITECOPY | VPROT_EXEC, &view ); > + > + sec = (IMAGE_SECTION_HEADER*)((char*)&nt->OptionalHeader+nt->FileHeader.SizeOfOptionalHeader); > + for (i=0;i<nt->FileHeader.NumberOfSections;i++) { > + DWORD flags = VPROT_SYSTEM | VPROT_IMAGE | VPROT_COMMITTED; > + > + if (sec[i].Characteristics & IMAGE_SCN_MEM_EXECUTE) flags |= VPROT_EXEC; > + if (sec[i].Characteristics & IMAGE_SCN_MEM_READ) flags |= VPROT_READ; > + if (sec[i].Characteristics & IMAGE_SCN_MEM_WRITE) flags |= VPROT_WRITE; > + if (sec[i].Characteristics & IMAGE_SCN_MEM_SHARED) flags |= VPROT_WRITECOPY; > + VIRTUAL_SetProt( view, (char*)module + sec[i].VirtualAddress, sec[i].Misc.VirtualSize, flags ); I don't think you want to actually change the permissions, our headers don't necessarily match the real ELF sections. (BTW, could you please convince your mailer to set a valid Message-Id?) -- Alexandre Julliard julliard(a)winehq.org

2 2

New winetricks 20100822: new verb lucida
by Dan Kegel Aug. 23, 2010

Aug. 23, 2010

Another fortnight, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English mdac26: can't download anymore, so make it a synonym for mdac27 firefox: fix install. (filenames can have spaces. Patch by depesz. Issue 153.) lucida: add new font verb lucida mingw: fix PATH Andrew Nguyen wsh57: Fix the wsh57 dependency check and remove calls to load_wsh56 helper. Dan Kegel: gecko: make it work even if WINE isn't set. (How did this get through?)

4 3

Re: [PATCH 4/6] shell32: Implement IExplorerBrowser::Advise and IExplorerBrowser::Unadvise.
by Alexandre Julliard Aug. 23, 2010

Aug. 23, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > +#define EBE_IMPL(iface) \ > + ((IExplorerBrowserEventsImpl*)iface) > [...] > +static ULONG WINAPI IExplorerBrowserEvents_fnAddRef(IExplorerBrowserEvents *iface) > +{ > + return InterlockedIncrement(&(EBE_IMPL(iface)->ref)); That's ugly, declare a proper This pointer instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] libport: Add msvc isnan and isinf implementations
by Alexandre Julliard Aug. 23, 2010

Aug. 23, 2010

Stefan Dösinger <stefan(a)codeweavers.com> writes: > @@ -31,6 +31,14 @@ int isinf(double x) > return (!(finite(x) || isnand(x))); > } > > +#elif defined(HAVE_FLOAT_H) && defined(_MSC_VER) > +#include <float.h> You should use proper configure checks instead of _MSC_VER, like we do for other similar cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer
by testbot＠testbot.winehq.org Aug. 23, 2010

Aug. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4676 Your paranoid android. === WVISTAADM (32 bit gameexplorer) === gameexplorer.c:450: Test failed: cannot find expected registry value gameexplorer.c:468: Test failed: cannot find expected registry value

1 0

Re: [2/6] wincodec.idl: invent an ICNS encoder CLSID
by Alexandre Julliard Aug. 23, 2010

Aug. 23, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * wincodec.idl: invent an ICNS encoder CLSID If it's invented it shouldn't be in a public header. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: Remove unused last parameter from TOOLTIPS_EnumToolsT.
by Nikolay Sivov Aug. 23, 2010

Aug. 23, 2010

On 8/23/2010 00:51, Gerald Pfeifer wrote: > --- > dlls/comctl32/tooltips.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index 688d3b5..d17f067 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1177,8 +1177,7 @@ TOOLTIPS_DelToolT (TOOLTIPS_INFO *infoPtr, const TTTOOLINFOW *ti, BOOL isW) > } > > static LRESULT > -TOOLTIPS_EnumToolsT (const TOOLTIPS_INFO *infoPtr, UINT uIndex, TTTOOLINFOW *ti, > - BOOL isW) > +TOOLTIPS_EnumToolsT (const TOOLTIPS_INFO *infoPtr, UINT uIndex, TTTOOLINFOW *ti) > { > TTTOOL_INFO *toolPtr; > > @@ -2176,8 +2175,7 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) > uMsg == TTM_DELTOOLW); > case TTM_ENUMTOOLSA: > case TTM_ENUMTOOLSW: > - return TOOLTIPS_EnumToolsT (infoPtr, (UINT)wParam, (LPTTTOOLINFOW)lParam, > - uMsg == TTM_ENUMTOOLSW); > + return TOOLTIPS_EnumToolsT (infoPtr, (UINT)wParam, (LPTTTOOLINFOW)lParam); > case TTM_GETBUBBLESIZE: > return TOOLTIPS_GetBubbleSize (infoPtr, (LPTTTOOLINFOW)lParam); > This needs to be implemented properly instead of being removed. Significant part is here: --- /* ti->lpszText = toolPtr->lpszText; */ ti->lpszText = NULL; /* FIXME */ --- which needs some tests. It's really doubtful that text is not returned when A/W messages exist.

1 0

Re: [5/5] gdiplus: Test flags of loaded images.
by testbot＠testbot.winehq.org Aug. 22, 2010

Aug. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4650 Your paranoid android. === WVISTAADM (32 bit image) === No test summary line found === W7PRO (32 bit image) === image.c:103: Test failed: Expected 00012010, got 00013010 image.c:103: Test failed: Expected 00013088, got 00013010 === W7PROX64 (32 bit image) === image.c:103: Test failed: Expected 00012010, got 00013010 image.c:103: Test failed: Expected 00013088, got 00013010 === W7PROX64 (64 bit image) === image.c:103: Test failed: Expected 00012010, got 00013010 image.c:103: Test failed: Expected 00013088, got 00013010

2 1

Re: msvideo: Forward MCIWndCreate16 to MCIWndCreateA (2nd)
by Alexandre Julliard Aug. 22, 2010

Aug. 22, 2010

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + HINSTANCE hinst32; > + if (hinst16 == GetModuleHandle16("msvideo.dll")) > + hinst32 = GetModuleHandleA("msvfw32.dll"); > + else > + hinst32 = HINSTANCE_32(GetExePtr( hinst16 )); This doesn't seem right. Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: appwiz.cpl: Removed sign comparison warning
by Nikolay Sivov Aug. 22, 2010

Aug. 22, 2010

On 8/20/2010 20:04, Marko Nikolic wrote: > Changed variable type to match function return type. > --- > dlls/appwiz.cpl/appwiz.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c > index ffd2b24..1b3370b 100644 > --- a/dlls/appwiz.cpl/appwiz.c > +++ b/dlls/appwiz.cpl/appwiz.c > @@ -406,7 +406,7 @@ static void UpdateButtons(HWND hWnd) > { > APPINFO *iter; > LVITEMW lvItem; > - DWORD selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, LVM_GETNEXTITEM, -1, > + LRESULT selitem = SendDlgItemMessageW(hWnd, IDL_PROGRAMS, LVM_GETNEXTITEM, -1, > LVNI_FOCUSED | LVNI_SELECTED); > BOOL enable_modify = FALSE; > There's no need for that, return value means integer item index. What are you fixing with that?

2 3

Re: [4/5] gdiplus: Set bitmap has alpha flag based on format.
by testbot＠testbot.winehq.org Aug. 22, 2010

Aug. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4649 Your paranoid android. === WVISTAADM (32 bit image) === No test summary line found

1 0

Re: wineboot: More architectures and vendorIDs in create_hardware_registry_keys
by André Hentschel Aug. 22, 2010

Aug. 22, 2010

> +#ifdef __i386__ > + /* get VendorID from CPUID, eax = 0 */ > + unsigned int regs[3]; Hello Konrad, you are generating declerations after some code here. -- Best Regards, André Hentschel

2 2

problem with ./configure & libGLU vs. libice-dev
by wylda＠volny.cz Aug. 22, 2010

Aug. 22, 2010

Hi, isn't there a problem with wine's configure script? I'm running on new Debian Squezee and noticed (luckily), that when libice-dev is installed, than ./configure can't find "-lGLU". But libice-dev doesn't have any influence on file "libGLU.so.1". So why configure says me "-lGLU... not found" when file "/usr/lib/libGLU.so.1" is present? Desperate W.

4 5

Re: [PATCH 2/5] ddraw/tests: New visual back buffer flipping tests. (try 5, resend)
by Stefan Dösinger Aug. 21, 2010

Aug. 21, 2010

This test contains a C++ comment, please remove it. Otherwise it looks ok, as does patch 1 Am 18.08.2010 um 22:01 schrieb Oldřich Jedlička: > --- > dlls/ddraw/tests/visual.c | 123 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 123 insertions(+), 0 deletions(-) > > diff --git a/dlls/ddraw/tests/visual.c b/dlls/ddraw/tests/visual.c > index 290cb76..aecc2ab 100644 > --- a/dlls/ddraw/tests/visual.c > +++ b/dlls/ddraw/tests/visual.c > @@ -2920,6 +2920,128 @@ static void depth_clamp_test(IDirect3DDevice7 *device) > ok(SUCCEEDED(hr), "SetViewport failed, hr %#x.\n", hr); > } > > +static void DX1_BackBufferFlipTest(void) > +{ > + HRESULT hr; > + int ret; > + IDirectDraw *DirectDraw1 = NULL; > + IDirectDrawSurface *Primary = NULL; > + IDirectDrawSurface *Backbuffer = NULL; > + WNDCLASS wc = {0}; > + DDSURFACEDESC ddsd; > + DDBLTFX ddbltfx; > + COLORREF color; > + const DWORD white = 0xffffff; > + const DWORD red = 0xff0000; > + BOOL attached = FALSE; > + > + wc.lpfnWndProc = DefWindowProc; > + wc.lpszClassName = "DX1_BackBufferFlipTest_wc"; > + RegisterClass(&wc); > + window = CreateWindow("DX1_BackBufferFlipTest_wc", "DX1_BackBufferFlipTest", > + WS_MAXIMIZE | WS_VISIBLE | WS_CAPTION , 0, 0, 640, 480, 0, 0, 0, 0); > + > + hr = DirectDrawCreate( NULL, &DirectDraw1, NULL ); > + ok(hr==DD_OK || hr==DDERR_NODIRECTDRAWSUPPORT, "DirectDrawCreate returned: %x\n", hr); > + if(FAILED(hr)) goto out; > + > + hr = IDirectDraw_SetCooperativeLevel(DirectDraw1, window, DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN); > + ok(hr==DD_OK, "SetCooperativeLevel returned: %x\n", hr); > + if(FAILED(hr)) goto out; > + > + hr = IDirectDraw_SetDisplayMode(DirectDraw1, 640, 480, 32); > + if(FAILED(hr)) { > + /* 24 bit is fine too */ > + hr = IDirectDraw_SetDisplayMode(DirectDraw1, 640, 480, 24); > + } > + ok(hr==DD_OK || hr == DDERR_UNSUPPORTED, "SetDisplayMode returned: %x\n", hr); > + if (FAILED(hr)) { > + goto out; > + } > + > + memset(&ddsd, 0, sizeof(DDSURFACEDESC)); > + ddsd.dwSize = sizeof(DDSURFACEDESC); > + ddsd.dwFlags = DDSD_CAPS; > + ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE; > + > + hr = IDirectDraw_CreateSurface(DirectDraw1, &ddsd, &Primary, NULL); > + ok(hr==DD_OK, "IDirectDraw_CreateSurface returned: %08x\n", hr); > + > + memset(&ddsd, 0, sizeof(DDSURFACEDESC)); > + ddsd.dwSize = sizeof(DDSURFACEDESC); > + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | DDSD_PIXELFORMAT; > + ddsd.ddsCaps.dwCaps = DDSCAPS_BACKBUFFER; > + ddsd.dwWidth = 640; > + ddsd.dwHeight = 480; > + ddsd.ddpfPixelFormat.dwSize = sizeof(ddsd.ddpfPixelFormat); > + ddsd.ddpfPixelFormat.dwFlags = DDPF_RGB; > + U1(ddsd.ddpfPixelFormat).dwRGBBitCount = 32; > + U2(ddsd.ddpfPixelFormat).dwRBitMask = 0x00ff0000; > + U3(ddsd.ddpfPixelFormat).dwGBitMask = 0x0000ff00; > + U4(ddsd.ddpfPixelFormat).dwBBitMask = 0x000000ff; > + > + hr = IDirectDraw_CreateSurface(DirectDraw1, &ddsd, &Backbuffer, NULL); > + todo_wine ok(hr==DD_OK, "IDirectDraw_CreateSurface returned: %08x\n", hr); > + if(FAILED(hr)) goto out; > + > + hr = IDirectDrawSurface_AddAttachedSurface(Primary, Backbuffer); > + todo_wine ok(hr == DD_OK || broken(hr == DDERR_CANNOTATTACHSURFACE), > + "Attaching a back buffer to a front buffer returned %08x\n", hr); > + if (FAILED(hr)) goto out; > + > + attached = TRUE; > + > + memset(&ddbltfx, 0, sizeof(ddbltfx)); > + ddbltfx.dwSize = sizeof(ddbltfx); > + U5(ddbltfx).dwFillColor = red; > + hr = IDirectDrawSurface_Blt(Backbuffer, NULL, NULL, NULL, DDBLT_COLORFILL | DDBLT_WAIT, &ddbltfx); > + ok(hr == DD_OK, "IDirectDrawSurface_Blt returned: %x\n", hr); > + > + U5(ddbltfx).dwFillColor = white; > + hr = IDirectDrawSurface_Blt(Primary, NULL, NULL, NULL, DDBLT_COLORFILL | DDBLT_WAIT, &ddbltfx); > + ok(hr == DD_OK, "IDirectDrawSurface_Blt returned: %x\n", hr); > + > + // Check it out > + color = getPixelColor_GDI(Primary, 5, 5); > + ok(GetRValue(color) == 0xFF && GetGValue(color) == 0xFF && GetBValue(color) == 0xFF, > + "got R %02X G %02X B %02X, expected R FF G FF B FF\n", > + GetRValue(color), GetGValue(color), GetBValue(color)); > + > + color = getPixelColor_GDI(Backbuffer, 5, 5); > + ok(GetRValue(color) == 0xFF && GetGValue(color) == 0 && GetBValue(color) == 0, > + "got R %02X G %02X B %02X, expected R FF G 00 B 00\n", > + GetRValue(color), GetGValue(color), GetBValue(color)); > + > + hr = IDirectDrawSurface_Flip(Primary, NULL, DDFLIP_WAIT); > + todo_wine ok(hr == DD_OK, "IDirectDrawSurface_Flip returned 0x%08x\n", hr); > + > + if (hr == DD_OK) > + { > + color = getPixelColor_GDI(Primary, 5, 5); > + ok(GetRValue(color) == 0xFF && GetGValue(color) == 0 && GetBValue(color) == 0, > + "got R %02X G %02X B %02X, expected R FF G 00 B 00\n", > + GetRValue(color), GetGValue(color), GetBValue(color)); > + > + color = getPixelColor_GDI(Backbuffer, 5, 5); > + ok((GetRValue(color) == 0xFF && GetGValue(color) == 0xFF && GetBValue(color) == 0xFF) || > + broken(GetRValue(color) == 0xFF && GetGValue(color) == 0 && GetBValue(color) == 0), // broken driver > + "got R %02X G %02X B %02X, expected R FF G FF B FF\n", > + GetRValue(color), GetGValue(color), GetBValue(color)); > + } > + > + out: > + > + if (Backbuffer) > + { > + if (attached) > + IDirectDrawSurface_DeleteAttachedSurface(Primary, 0, Backbuffer); > + IDirectDrawSurface_Release(Backbuffer); > + } > + if (Primary) IDirectDrawSurface_Release(Primary); > + if (DirectDraw1) IDirectDraw_Release(DirectDraw1); > + if (window) DestroyWindow(window); > +} > + > START_TEST(visual) > { > HRESULT hr; > @@ -2983,6 +3105,7 @@ START_TEST(visual) > > D3D3_ViewportClearTest(); > p8_primary_test(); > + DX1_BackBufferFlipTest(); > > return ; > > -- > 1.7.2 > > >

2 1

Specifying Reply-To header in patches email using git-send-email?
by Frédéric Delanoy Aug. 21, 2010

Aug. 21, 2010

I've tried for some time to specify the wine-devel Reply-To using git-send-email, with little success so far Any idea how this might be done? Here's how my git config looks like: [sendemail] <smtp server config> from = user <email> to = wine-patches <wine-patches(a)winehq.org> assume8bitEncoding = UTF-8 suppresscc = self chainreplyto = false thread = false suppressfrom = true Frédéric

3 5

Re: [PATCH 2/2] quartz: implement IBaseFilter_FindPin
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4627 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

dlls/d3dx9_36/bytecodewriter.c oddity
by Gerald Pfeifer Aug. 21, 2010

Aug. 21, 2010

Metteo et al, I noticed d3dx9_36/bytecodewriter.c can be simplified as follows, but somewhat tells me this may rather point out a problem somewhere in that code, so I am not sending this to wine-patches. (The only functional difference should be the missing WARN in some cases, and I could restore that if desired, but...see above.) Thoughts? Guidance? Gerald diff --git a/dlls/d3dx9_36/bytecodewriter.c b/dlls/d3dx9_36/bytecodewriter.c index 07f96e7..e7bd8a5 100644 --- a/dlls/d3dx9_36/bytecodewriter.c +++ b/dlls/d3dx9_36/bytecodewriter.c @@ -1035,7 +1035,7 @@ static const struct bytecode_backend vs_1_x_backend = { static void instr_ps_1_0123_texld(struct bc_writer *This, const struct instruction *instr, struct bytecode_buffer *buffer) { - DWORD idx, srcidx; + DWORD idx; struct shader_reg reg; DWORD swizzlemask; @@ -1074,17 +1074,6 @@ static void instr_ps_1_0123_texld(struct bc_writer *This, /* map the temp dstreg to the ps_1_3 texture temporary register */ This->funcs->dstreg(This, &instr->dst, buffer, instr->shift, instr->dstmod); } else if(instr->src[0].type == BWRITERSPR_TEMP) { - if(instr->src[0].regnum == T0_REG) { - srcidx = 0; - } else if(instr->src[0].regnum == T1_REG) { - srcidx = 1; - } else if(instr->src[0].regnum == T2_REG) { - srcidx = 2; - } else if(instr->src[0].regnum == T3_REG) { - srcidx = 3; - } else { - WARN("Invalid address data source register r%u\n", instr->src[0].regnum); - } swizzlemask = (3 << BWRITERVS_SWIZZLE_SHIFT) | (3 << (BWRITERVS_SWIZZLE_SHIFT + 2)) |

2 2

Re: crypt32: Correct CryptVerifyMessageSignature's use of pcbDecoded
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4624 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 5/5] shell32: Implement IExplorerBrowser::SetRect.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4604 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 4/5] shell32: Implement IExplorerBrowser::Initialize.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4603 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 3/5] shell32: Add IShellBrowser stub.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4602 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 2/5] shell32/tests: Add initial tests for the IExplorerBrowser control.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4601 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH] ntdll/tests: Add tests for RtlIpv4AddressToString / RtlIpv4AddressToStringEx [try 5]
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4600 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: advpakc/tests: Removed sign comparison warning in advpack tests
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4599 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 7/8] msvcp90/tests: Added basic_string<char> tests
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4597 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 2/2] d3dcompiler: Add D3DCreateBlob() test.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4596 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH try 2] ntdll: IMAGE_REL_BASED_HIGH, IMAGE_REL_BASED_LOW and IMAGE_REL_BASED_HIGHLOW should be supported on win64.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4595 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [7/7] comctl32/imagelist: Fail to create imagelist with zero or negative image dimensions
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4594 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [6/7] comctl32/imagelist: Fail in ImageList_GetIconSize on null parameters
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4593 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [5/7] comctl32/tests: More imagelist tests to show broken parameter validation
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4592 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [4/7] comctl32/imagelist: Fix failure code for IImageList_Remove()
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4591 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [3/7] comctl32/imagelist: Fix failure code for IImageList_Draw()
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4590 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [2/7] comctl32/tests: Use reduced IMAGELISTDRAWPARAMS structure size for tests
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4589 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [1/7] comctl32/tests: Use better names for test functions, discover some new test failures
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4588 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: oleau32: Try both SYS_WIN64 and SYS_WIN32 syskind in QueryPathOfRegTypeLib on win64.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4582 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: gdi32: Properly set ERROR_NOACCESS when GetObject receives invalid arguments
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4581 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 4/4] explorerframe: Some additional basic tests.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4578 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 3/4] explorerframe: Implement EnsureItemVisible.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4577 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 2/4] explorerframe: Implement HitTest
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4576 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH] comctl32/tests: DateTimePicker and MonthCalendar controls only support Gregorian calendar.
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4574 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [5/5] urlmon/tests: Added tests for IUriBuilder_GetFragment
by testbot＠testbot.winehq.org Aug. 21, 2010

Aug. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4571 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [website]Japanese Translation for "About Wine" page
by Jeremy Newman Aug. 20, 2010

Aug. 20, 2010

I'll accept this patch when we also have a JA translation of the Front landing page. No point having other pages translated without at least that. -Newman On 08/17/2010 11:00 PM, kikuchy.h(a)gmail.com wrote: > From: Hiroshi Kikuchi<kikuchy.h(a)gmail.com> > > I want to join wine project. Nice to meet you. > Hiroshi Kikuchi > --- > templates/ja/about.template | 27 +++++++++++++++++++++++++++ > 1 files changed, 27 insertions(+), 0 deletions(-) > create mode 100644 templates/ja/about.template > > diff --git a/templates/ja/about.template b/templates/ja/about.template > new file mode 100644 > index 0000000..b83fad7 > --- /dev/null > +++ b/templates/ja/about.template > @@ -0,0 +1,27 @@ > + > + > + > +<h1 class="title">Wine について</h1> > + > +<p>Wine は、 Windows のソフトウェアを Windows 以外のOSで動作させるものです。Wine を使えば、Windows でするように Windows アプリケーションのインストールと実行が出来るようになります。</p> > + > +<p>Wine は現在活発に開発されています。まだ全てのプログラムが動作する訳ではありませんが、すでに<a href="http://wiki.winehq.org/UsageStatistics" title="Wine Usage Statistics">何人もの人たちが</a> Wine を使ってソフトウェアを動かしています。</p> > + > +<h3>オープンソース、そしてユーザーによる支援</h3> > + > +<p>Wine は未来永劫<a href="http://wiki.winehq.org/Licensing" title="Wine licensing">フリーソフト</a>です。Wine のソースコードのおよそ半分がボランティアによって書かれています。残り半分は商業的利潤のため、特にサポートがあるバージョンの Wine を発売している<a href="http://www.codeweavers.com/products/" title="Codeweavers Crossover Office">Codeweavers</a>によって支えられています。</p> > + > +<p>Wine はユーザーコミュニティに大きく頼っています。ユーザーのテストが私たちの、プログラムの動作状況を記録した<a href="http://appdb.winehq.org/" title="Wine Application Database">アプリケーションデータベース</a>を埋めてくれていますし、<a href="http://forums.winehq.org/" title="WineHQ Forums">フォーラム</a>の質問に対する答えも全てボランティアによるものです。</p> > + > +<h3>こちらもご覧ください:</h3> > +<ul> > +<li><a href="http://wiki.winehq.org/ImportanceOfWine">Wine が重要な理由</a></li> > +<li><a href="http://wiki.winehq.org/Debunking_Wine_Myths">Wine にまつわるウソ・ホント</a></li> > +<li><a href="http://wiki.winehq.org/WineHistory">Wine プロジェクトの歴史</a></li> > +<li><a href="http://wiki.winehq.org/ProjectOrganization">Organization and Leadership</a></li> > +</ul> > + > +<hr> > +<div class="link-container"> > +<p class="right-link">Wine の歴史:<a href="{$root}/history">次へ</a></p> > +</div> > > > >

1 0

RE: The Test Bot seems to be having issues
by Greg Geldorp Aug. 20, 2010

Aug. 20, 2010

Hi Thomas, > From: Thomas Mallaly > > First off, I'm not sure who should be contacted about this, but, it appears > that the test bot has got itself stuck while trying to run tests on a patch > submitted last night. Sorry, hadn't noticed it got stuck. Usually it doesn't need much baby-sitting, so I don't keep a close look on it. You can always use the "Feedback" link on the TestBot home page. > The job in question is here [1], it's been over 12 > hours since any progress has been made on it and no other submissions have > run since then. Also, the Windows 98SE has been "reverting" this whole time, > so I'm not sure if this is the culprit or not. > > I also hate to admit that the job in question is from one of my patches I > sent in last night (although I'm pretty sure it doesn't have anything to do > with the quality of the code in the patch ;-) ). The Win9x VMs are on a different (physical) machine, it appears there was a network problem between the Test Bot host and the machine hosting the Win9x VMs. The Win98SE VM getting stuck in the "reverting" state is the cause of the problems, nothing to do with your patch. > Anyways, I'm hoping that somebody in charge of the test bot might be able to > fix the traffic jam it's causing. It's back up and running again, trying to catch up. Ge.

2 1

CVS gateway down for good
by Alexandre Julliard Aug. 20, 2010

Aug. 20, 2010

Folks, The git->CVS gateway broke again, so I'm going to pull the plug on it. It doesn't make sense for me to spend more time fixing something that sees so little usage at this point. If you are still using CVS, you'll have to switch to git (or volunteer to host the gateway yourself...) Sorry about the inconvenience. -- Alexandre Julliard julliard(a)winehq.org

1 0

The Test Bot seems to be having issues
by Thomas Mullaly Aug. 20, 2010

Aug. 20, 2010

Hi all, First off, I'm not sure who should be contacted about this, but, it appears that the test bot has got itself stuck while trying to run tests on a patch submitted last night. The job in question is here [1], it's been over 12 hours since any progress has been made on it and no other submissions have run since then. Also, the Windows 98SE has been "reverting" this whole time, so I'm not sure if this is the culprit or not. I also hate to admit that the job in question is from one of my patches I sent in last night (although I'm pretty sure it doesn't have anything to do with the quality of the code in the patch ;-) ). Anyways, I'm hoping that somebody in charge of the test bot might be able to fix the traffic jam it's causing. [1] https://testbot.winehq.org/JobDetails.pl?Key=4570 <https://testbot.winehq.org/JobDetails.pl?Key=4570> -- Thomas Mullaly thomas.mullaly(a)gmail.com

2 2

Re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if it does not contain controls. [try 2]
by Alexandre Julliard Aug. 20, 2010

Aug. 20, 2010

"Mikhail Maroukhine" <mikolg(a)yandex.ru> writes: > GetNextDlgTabItem returns hwndDlg if it does not contain controls and > searching next item. > GetNextDlgTabItem returns the first child if next TABSTOP control not > found. > > And returns 0 in both cases if searching prev item It breaks the tests: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so propsheet.c && touch propsheet.ok propsheet.c:312: Test failed: Focus should have been set to the Next button. Expected: 12324, Found: 65535 propsheet.c:363: Test failed: Focus should have been set to the Next button. Expected: 12324, Found: 65535 make[1]: *** [propsheet.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32/enhmfdrv: Do not leak a HDC
by Alexandre Julliard Aug. 20, 2010

Aug. 20, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > --- > dlls/gdi32/enhmfdrv/init.c | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) It would be cleaner to move the CreateDCW call where it's needed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Improved a FIXME in WCMD_filesize64
by Alexandre Julliard Aug. 20, 2010

Aug. 20, 2010

"Konrad Wartke" <kwartke(a)googlemail.com> writes: > cmd: Improved a FIXME in WCMD_filesize64 by using a better algorithm. It's not much better. Anyway, this should be done by using one of the existing formatting functions, maybe VarFormatNumber. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 7/8] msvcp90/tests: Added basic_string<char> tests
by Alexandre Julliard Aug. 20, 2010

Aug. 20, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -0,0 +1,30 @@ > +/* > + * Copyright 2010 Piotr Caban for CodeWeavers > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +/* basic_string<char, char_traits<char>, allocator<char>> */ > +#define BUF_SIZE_CHAR 16 > +typedef struct _basic_string_char > +{ > + void *allocator; > + union _data { > + char buf[BUF_SIZE_CHAR]; > + char *ptr; > + } data; > + size_t size; > + size_t res; > +} basic_string_char; Unless there's going to be a ton of definitions in there used by many different files, it's better to put that sort of thing directly in the C file to make it easier to build stand-alone. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Properly set ERROR_NOACCESS when GetObject receives invalid arguments
by Octavian Voicu Aug. 19, 2010

Aug. 19, 2010

On Thu, Aug 19, 2010 at 4:56 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Broken programs will crash on wine if they, for example, pass > arguments to GetObject in the wrong order. > This fixes bug #18864. > + if (buffer && ((ULONG_PTR)buffer >> 16) == 0) Wouldn't a __TRY ... __EXCEPT_PAGE_FAULT be better / safer? Octavian

2 1

PDB files generated by Intel C++ Compiler
by Peter Urbanec Aug. 19, 2010

Aug. 19, 2010

I have some x64 binaries and associated PDBs that have been generated using Intel C++ Compiler 11.1. These PDBs cause issues such as this: 1 0x00000000781cc1ba in msvcr80 (+0x9c1b9) (0x00007ff047a4c840) fixme:dbghelp_msc:codeview_fetch_type Cannot locate type 670 err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols 2 0x000000006189a00d in lua5.1 (+0xa00c) (0x00007ff047a4c840) Now, from a quick look at mscvpdb.h, it looks like these PDBs contain datatypes with 64-bit near pointers, however wine does not seem to understand this mode. How would one go about adding support for this type of PDB? I actually don't have access to the Intel C++ Compiler to do much testing. :-(

2 1

winepath bug without arguments?
by Jerome Leclanche Aug. 19, 2010

Aug. 19, 2010

Hi After fixing a bug in MPQEdit related to opening directories, I noticed winepath returns a different result with and without quotes: adys(a)azura:~/.wine/drive_c$ winepath -w adys(a)azura:~/.wine/drive_c$ winepath -w "" C:\ With quotes it returns the current directory. Is that intended? If not I'll open a bug... J. Leclanche

3 2

Re: [01/11] d3dx10: Add stub for d3dx10_43
by Henri Verbeet Aug. 19, 2010

Aug. 19, 2010

On 18 August 2010 23:01, Owen Rudge <orudge(a)codeweavers.com> wrote: > +BOOL WINAPI D3DX10CheckVersion(UINT d3dsdkvers, UINT d3dxsdkvers) > +{ > + if ((d3dsdkvers == D3D10_SDK_VERSION) && (d3dxsdkvers == 43)) > + return TRUE; > + > + return FALSE; > +} Is it really safe to assume D3D10_SDK_VERSION will always keep the same value? (I know d3dx9 does it as well.) For d3d9 the SDK version changed between d3d9b and d3d9c, for example.

2 2

Re: [PATCH 3/5] ddraw/tests: New CreateSurface for 3D DDSCAPS_BACKBUFFER tests. (try 5, resend)
by Stefan Dösinger Aug. 19, 2010

Aug. 19, 2010

Hi, Can you try to create a d3d device with this surface? In the first d3d version this works by querying the d3d device ID from the surface. Patch 4 looks OK. Thank you for your persistence with the patches by the way! Cheers, Stefan Am 18.08.2010 um 22:01 schrieb Oldřich Jedlička: > --- > dlls/ddraw/tests/d3d.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 82 insertions(+), 0 deletions(-) > > diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c > index 53ef04b..a83b0d5 100644 > --- a/dlls/ddraw/tests/d3d.c > +++ b/dlls/ddraw/tests/d3d.c > @@ -3536,6 +3536,87 @@ static void FindDevice(void) > "Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", hr); > } > > +static void BackBuffer3DCreateSurfaceTest(void) > +{ > + DDSURFACEDESC ddsd; > + DDSURFACEDESC created_ddsd; > + DDSURFACEDESC2 ddsd2; > + IDirectDrawSurface *surf; > + IDirectDrawSurface4 *surf4; > + IDirectDrawSurface7 *surf7; > + HRESULT hr; > + IDirectDraw2 *dd2; > + IDirectDraw4 *dd4; > + IDirectDraw7 *dd7; > + DDCAPS ddcaps; > + > + const DWORD caps = DDSCAPS_BACKBUFFER | DDSCAPS_3DDEVICE; > + const DWORD expected_caps = DDSCAPS_BACKBUFFER | DDSCAPS_3DDEVICE | DDSCAPS_VIDEOMEMORY | DDSCAPS_LOCALVIDMEM; > + > + memset(&ddcaps, 0, sizeof(ddcaps)); > + ddcaps.dwSize = sizeof(DDCAPS); > + hr = IDirectDraw_GetCaps(DirectDraw1, &ddcaps, NULL); > + if (!(ddcaps.ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY)) > + { > + skip("DDraw reported no VIDEOMEMORY cap. Broken video driver? Skipping surface caps tests.\n"); > + return ; > + } > + > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; > + ddsd.dwWidth = 64; > + ddsd.dwHeight = 64; > + ddsd.ddsCaps.dwCaps = caps; > + memset(&ddsd2, 0, sizeof(ddsd2)); > + ddsd2.dwSize = sizeof(ddsd2); > + ddsd2.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; > + ddsd2.dwWidth = 64; > + ddsd2.dwHeight = 64; > + ddsd2.ddsCaps.dwCaps = caps; > + memset(&created_ddsd, 0, sizeof(created_ddsd)); > + created_ddsd.dwSize = sizeof(DDSURFACEDESC); > + > + hr = IDirectDraw_CreateSurface(DirectDraw1, &ddsd, &surf, NULL); > + todo_wine ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface failed: 0x%08x\n", hr); > + if (surf != NULL) > + { > + hr = IDirectDrawSurface_GetSurfaceDesc(surf, &created_ddsd); > + ok(SUCCEEDED(hr), "IDirectDraw_GetSurfaceDesc failed: 0x%08x\n", hr); > + todo_wine ok(created_ddsd.ddsCaps.dwCaps == expected_caps, > + "GetSurfaceDesc returned caps %x, expected %x\n", created_ddsd.ddsCaps.dwCaps, > + expected_caps); > + IDirectDrawSurface_Release(surf); > + } > + > + hr = IDirectDraw_QueryInterface(DirectDraw1, &IID_IDirectDraw2, (void **) &dd2); > + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: 0x%08x\n", hr); > + > + hr = IDirectDraw2_CreateSurface(dd2, &ddsd, &surf, NULL); > + ok(hr == DDERR_INVALIDCAPS, "IDirectDraw2_CreateSurface didn't return %x08x, but %x08x\n", > + DDERR_INVALIDCAPS, hr); > + > + IDirectDraw2_Release(dd2); > + > + hr = IDirectDraw_QueryInterface(DirectDraw1, &IID_IDirectDraw4, (void **) &dd4); > + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: 0x%08x\n", hr); > + > + hr = IDirectDraw4_CreateSurface(dd4, &ddsd2, &surf4, NULL); > + ok(hr == DDERR_INVALIDCAPS, "IDirectDraw4_CreateSurface didn't return %x08x, but %x08x\n", > + DDERR_INVALIDCAPS, hr); > + > + IDirectDraw4_Release(dd4); > + > + hr = IDirectDraw_QueryInterface(DirectDraw1, &IID_IDirectDraw7, (void **) &dd7); > + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: 0x%08x\n", hr); > + > + hr = IDirectDraw7_CreateSurface(dd7, &ddsd2, &surf7, NULL); > + ok(hr == DDERR_INVALIDCAPS, "IDirectDraw7_CreateSurface didn't return %x08x, but %x08x\n", > + DDERR_INVALIDCAPS, hr); > + > + IDirectDraw7_Release(dd7); > +} > + > START_TEST(d3d) > { > init_function_pointers(); > @@ -3571,6 +3652,7 @@ START_TEST(d3d) > TextureLoadTest(); > ViewportTest(); > FindDevice(); > + BackBuffer3DCreateSurfaceTest(); > D3D1_releaseObjects(); > } > > -- > 1.7.2 > > >

1 0

Re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if it does not contain controls.
by Alexandre Julliard Aug. 19, 2010

Aug. 19, 2010

"Mikhail Maroukhine" <mikolg(a)yandex.ru> writes: > @@ -1695,7 +1696,19 @@ HWND WINAPI GetNextDlgTabItem( HWND hwndDlg, HWND hwndCtrl, > */ > if (!hwndCtrl && fPrevious) return 0; > > - return DIALOG_GetNextTabItem(hwndDlg,hwndDlg,hwndCtrl,fPrevious); > + nextItem = DIALOG_GetNextTabItem(hwndDlg,hwndDlg,hwndCtrl,fPrevious); > + > + /* if next tab item not found return the first child even if it does not have TABSTOP > + Checked on XP > + */ > + if (!nextItem && !fPrevious) nextItem = GetWindow(hwndDlg,GW_CHILD); > + > + /* if there is no controls on hwndDlg return hwndDlg > + Checked on XP > + */ > + if (!nextItem && !fPrevious) nextItem = hwndDlg; > + > + return nextItem; You should test the fPrevious case too, it's probably similar. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleau32: Use correct sysking in QueryPathOfRegTypeLib.
by Alexandre Julliard Aug. 19, 2010

Aug. 19, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/oleaut32/typelib.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) It breaks the 64-bit tests: ../../../../wine/tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so ../../../../wine/dlls/oleaut32/tests/typelib.c && touch typelib.ok typelib.c:784: Test failed: QueryPathOfRegTypeLib(3.0) returned 8002801d typelib.c:784: Test failed: QueryPathOfRegTypeLib(3.1) returned 8002801d typelib.c:784: Test failed: QueryPathOfRegTypeLib(3.22) returned 8002801d typelib.c:784: Test failed: QueryPathOfRegTypeLib(3.37) returned 8002801d typelib.c:784: Test failed: QueryPathOfRegTypeLib(3.40) returned 8002801d typelib.c:784: Test failed: QueryPathOfRegTypeLib(65535.65535) returned 8002801d make: *** [typelib.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 5, resend)
by Stefan Dösinger Aug. 19, 2010

Aug. 19, 2010

Am 18.08.2010 um 22:01 schrieb Oldřich Jedlička: > + if(DDSD->ddsCaps.dwCaps & DDSCAPS_FRONTBUFFER) { > + WARN("Application tried to create an explicit front buffer\n"); > LeaveCriticalSection(&ddraw_cs); > return DDERR_INVALIDCAPS; > } This test seems redundant now. The ddraw1 thunk removes the flag, and all other thunks check for the frontbuffer flag on their own.

1 0

have all MCI tests in winmm/tests/ or distributed across mci*/tests/?
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 19, 2010

Aug. 19, 2010

Hi, although my patch creates mcicda/tests/ I'd like to query whether it would make more sense to have all mci tests grouped in winmm/tests/. Pro: + Future fixes to winmm/mci.c would affect winmm/tests/*.c only. E.g. when I'll make "stop all" work I'd have to touch mcicda/tests/mcicda.c as well to eliminate the todo_wine there. Same when I'll patch mciparse to accept [TT:]MM:SS:FF format. + When Maarten will write mciqtz tests, perhaps resources could be reused to execute mciavi tests as well (the file creation code need not be duplicated). Similar tests could be written for: "open foo.avi" (mciavi) and "open foo.avi type mpegvideo" (mciqtz) or "open foo.wav" (micwave) and "open foo.wav type mpegvideo" although there's some difference in behaviour. + The functions test_notification could be in one file only, not repeated. I can rewrite my current mcicda/tests/mcicda.c patch to live in winmm/tests/. What do you think? Jörg Höhle

2 1

Re: [1/2] user32: add a way to poll for messages on extra handles
by Alexandre Julliard Aug. 19, 2010

Aug. 19, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > diff --git a/dlls/user32/driver.c b/dlls/user32/driver.c > index f2f9892..05c83d4 100644 > --- a/dlls/user32/driver.c > +++ b/dlls/user32/driver.c > @@ -126,6 +126,7 @@ static const USER_DRIVER *load_driver(void) > GET_USER_FUNC(WindowMessage); > GET_USER_FUNC(WindowPosChanging); > GET_USER_FUNC(WindowPosChanged); > + GET_USER_FUNC(GetExtraMessageHandles); That's ugly, it doesn't correspond to anything in the Windows API. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll/tests: Add tests for RtlIpv4AddressToString / RtlIpv4AddressToStringEx [try 4]
by Alexandre Julliard Aug. 19, 2010

Aug. 19, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > + ok( (res == (void *)~0) || > + broken(res == (NULL + len)), /* XP and w2003 */ You can't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] comctl32/tests: DateTimePicker and MonthCalendar controls only support Gregorian calendar.
by Nikolay Sivov Aug. 19, 2010

Aug. 19, 2010

On Thu, Aug 19, 2010 at 9:50 AM, Austin Lund <austin.lund(a)gmail.com> wrote: > http://www.microsoft.com/middleeast/msdn/ArabicCalendar.aspx Hi, Austin. This information is outdated probably. There's a message to set a calendar for MonthCal at least, see: http://msdn.microsoft.com/en-us/library/bb760995%28VS.85%29.aspx Not sure about DateTimePicker, it uses Monthcal internally so a calendar could still be switched. Anyway this won't work on pre-Vista and without a manifest for v6, but you could enable tests using V6 loading helpers that we have already and MCM_SETCALID message, so tests will run on Arabic or some Asian boxes.

2 1

Re: [PATCH 5/5] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 5, resend)
by testbot＠testbot.winehq.org Aug. 19, 2010

Aug. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4557 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1619: Test failed: Got color 000a246a, expected 00ff0040 or near visual.c:1625: Test failed: Got color 006b8bbd, expected 00ff0080 or near === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 1/5] ddraw/tests: Add test for bad size of surface caps in CreateSurface. (try 5, resend)
by testbot＠testbot.winehq.org Aug. 19, 2010

Aug. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4553 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 2/2] gameux/tests: verifying registry values created by GameExplorer (try 2)
by testbot＠testbot.winehq.org Aug. 19, 2010

Aug. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4552 Your paranoid android. === W98SE (32 bit gameexplorer) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit gameexplorer) === Timeout === WXPPROSP3 (32 bit gameexplorer) === Timeout

1 0

Re: ntdll: IMAGE_REL_BASED_HIGH, IMAGE_REL_BASED_HIGH and IMAGE_REL_BASED_HIGHLOW are supported on win64.
by testbot＠testbot.winehq.org Aug. 19, 2010

Aug. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4548 Your paranoid android. === W98SE (32 bit rtl) === Failure running script in VM: Exceeded timeout limit of 315 sec

1 0

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file
by Vincent Povirk Aug. 18, 2010

Aug. 18, 2010

> @@ -32,7 +33,6 @@ > > #include "wine/test.h" > > - > static void test_create(BOOL* gameExplorerAvailable, BOOL* gameExplorer2Available) > { > HRESULT hr; Don't put formatting changes in functional patches, please. I think it would be helpful if you passed a string description to your _validate functions so that in case of failure, you can tell where the original call to _validateGameRegistryKey was, instead of just the line containing the ok() call.

3 3

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4540 Your paranoid android. === W98SE (32 bit gameexplorer) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit gameexplorer) === Timeout === WXPPROSP3 (32 bit gameexplorer) === Timeout

4 5

Re: [PATCH 5/6] gameux: Add initial implementation of IGameExplorer2::CheckAccess method
by Mariusz Pluciński Aug. 18, 2010

Aug. 18, 2010

Hello W dniu 16.08.2010 10:00, Mariusz Pluciński pisze: > --- > dlls/gameux/gameexplorer.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > This is patch I sent to wine-patches yesterday. It was marked as "Pending". I know that what I sent is not proper solution. But as I wrote in FIXME, it's in my opinion impossible to implement it properly, cause from what I know Wine does not support parental control. So, instead of doing real check, my function simply always grants access. My question is: what should I do with it? It cannot be left stub, as there's already bug caused by this (bug #23850). And probably every game which uses Game Explorer will behave that same. Should I write test case to demonstrate that native works that same in most cases?

1 0

Re: [PATCH 1/1] d3dx9: Add tests for FVF <-> declaration conversion.
by Alexandre Julliard Aug. 18, 2010

Aug. 18, 2010

Misha Koshelev <misha680(a)gmail.com> writes: > +#define VDECL_CHECK(fcall) \ > + if(fcall != S_OK) \ > + trace(" Test failed on line #%d\n", __LINE__); > + > +#define VDECL_CHECK_FAIL(fcall) \ > + if(fcall != E_FAIL) \ > + trace(" Test failed on line #%d\n", __LINE__); That's ugly. If the goal is to print the line number, you should pass it to the test function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] ntdll: Implement RtlIpv4AddressToString / RtlIpv4AddressToStringEx [try 3]
by Alexandre Julliard Aug. 18, 2010

Aug. 18, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > + in = *pin; What is this for? -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine64 debugger
by Peter Urbanec Aug. 18, 2010

Aug. 18, 2010

Hi, I'm trying to get a fairly complex Win64 application to work with wine. I'm seeing crashes in FindNextFileW/FindNextFileA due to what looks like a 64 bit HANDLE value being truncated to 32 bits. I thought that I would employ winedbg to help me, but I can't get very far. I don't have any luck with winedbg even on a simple x64 Win32 app. For my simplified test, I used MSVC2005 to generate an x64 executable created from the standard MSVC2005 template Win32 application. This is a simple app that just creates an empty window. As simple as one could get for a Win32 test and it executes correctly when run as "./wine Test1.exe". When I try to execute this test app under winedbg, I get an assert failure: ./wine winedbg Test1.exe WineDbg starting on pid 001a ./programs/winedbg/memory.c:37: be_cpu_linearize: Assertion `addr->Mode == AddrModeFlat' failed. wine: Assertion failed at address 0x7fec2fa657c5 (thread 0009), starting debugger... Unhandled exception: assertion failed in 64-bit code (0x00007fec2fa657c5). Any ideas about why I can not use winedbg to run Win32 x64 code? Thanks, Peter Urbanec

4 4

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.
by Hans Leidekker Aug. 18, 2010

Aug. 18, 2010

On Wed, 2010-08-18 at 10:14 +1000, Austin Lund wrote: > #define MAGIC_CRYPTPROV 0xA39E741F > +#define MAGIC_CRYPTKEY 0xA39E741F > +#define MAGIC_CRYPTHASH 0xA39E741F The app might pass a crypto handle of the wrong type, so it would be better to use different magic values.

3 4

Re: wldap32: Fix handling of zero timeout value in ldap_search_extW. (try 2)
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4530 Your paranoid android. === W2KPROSP4 (32 bit parse) === parse.c:101: Test failed: ldap_search_extW failed 0x00000034 parse.c:105: Test failed: ldap_search_extW failed 0x00000051

2 1

Re: [4/5] msi: Handle signature filenames in short|long notation.
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4528 Your paranoid android. === W7PROX64 (32 bit package) === package.c:8348: Test failed: Expected "C:\Program Files\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\", got "C:\Program Files (x86)\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\" === W7PROX64 (64 bit package) === package.c:8385: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8396: Test failed: Expected "C:\winetest\", got "" package.c:8407: Test failed: Expected "C:\winetest\", got "" package.c:8457: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8468: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8477: Test failed: Expected "C:\", got "" package.c:8483: Test failed: Expected "C:\winetest\", got "" package.c:8504: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8513: Test failed: Expected "C:\winetest\FileName1", got ""

1 0