August 2010 - Wine-Devel - list.winehq.org

Re: [3/5] msi/tests: Skip SourceDir tests on win9x.
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4527 Your paranoid android. === W2K3R2SESP2 (32 bit install) === Timeout

1 0

Re: [2/5] msi/tests: Use HKEY_CURRENT_USER instead of HKEY_LOCAL_MACHINE for registry tests.
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4526 Your paranoid android. === W2K3R2SESP2 (32 bit install) === Timeout

1 0

Re: [1/5] msi/tests: Fix some WoW64 test failures.
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4525 Your paranoid android. === W7PROX64 (32 bit package) === package.c:8329: Test failed: Expected "C:\Program Files\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\", got "C:\Program Files (x86)\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\" === W7PROX64 (64 bit package) === package.c:8366: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8377: Test failed: Expected "C:\winetest\", got "" package.c:8388: Test failed: Expected "C:\winetest\", got "" package.c:8438: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8449: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8458: Test failed: Expected "C:\", got "" package.c:8464: Test failed: Expected "C:\winetest\", got "" package.c:8485: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8494: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 18, 2010

Aug. 18, 2010

Hi, what happened to this patch? It's still marked new. Is the discovery too surprising? (Maybe it's the wrong time to ask with AJ still on vacation) Is it not robust enough (lacking testing with network drives)? It explains bugs #20887 and #23355. It may explain intermittent failures in test.winehq/kernel/volume.ok, as success depends on where the test was launched from. >Tests pass on w95,w98,w2k,xp,7. I forgot to add "without skipping the one relevant section", i.e. when started from another drive than C: Of course I invite people here to also perform the test on native. Regards, Jörg Höhle

2 2

Re: wldap32: Fix handling of zero timeout value in ldap_search_extW.
by testbot＠testbot.winehq.org Aug. 18, 2010

Aug. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4524 Your paranoid android. === W98SE (32 bit parse) === parse.c:108: Test failed: ldap_search_extW failed 0x00000059 === WNT4WSSP6 (32 bit parse) === parse.c:108: Test failed: ldap_search_extW failed 0x00000059

1 0

Re: [PATCH 2/3] winex11.drv: set global key state
by Alexandre Julliard Aug. 18, 2010

Aug. 18, 2010

Rafał Miłecki <zajec5(a)gmail.com> writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | key_state_table[wVkR]; > } > > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVk; > + req->state = key_state_table[wVk]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVkStripped; > + req->state = key_state_table[wVkStripped]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + You don't want to add 2 extra server calls for every key, especially since the server already receives the necessary information through the key event. -- Alexandre Julliard julliard(a)winehq.org

3 2

re: winex11.drv: Fix uninitialised values. (valgrind) (try 2)
by Dan Kegel Aug. 17, 2010

Aug. 17, 2010

That's for http://bugs.winehq.org/show_bug.cgi?id=20335 , right? Alexandre's reply to that was "It sounds like it's hashing padding bytes. Probably should be reported to the X.org folks." X is old code, and I don't think anyone has cleaned it up for valgrind yet. That's why I use suppression files like http://winezeug.googlecode.com/svn/trunk/valgrind/valgrind-suppressions which contain blanket suppressions like { bogus_X11_1 Memcheck:Param write(buf) obj:* obj:/usr/lib*/libX11.so.6.2.0 } { bogus_X11_2 Memcheck:Param write(buf) obj:* obj:* obj:/usr/lib*/libX11.so.6.2.0 }

2 1

Re: Should we expect Liberation fonts to be installed?
by Scott Ritchie Aug. 17, 2010

Aug. 17, 2010

On 08/08/2010 06:56 AM, James McKenzie wrote: > Scott Ritchie wrote: >> I was looking through our fairly large collection of open font bugs and >> realized that things might be a lot simpler if we took some opinionated >> positions and just declared certain fonts to be dependencies and >> expected all packagers to provide them. >> >> This is similar to bundling our own Tahoma, except much less work. >> > This might work for Linux, but these fonts are not installed on any > MacOSX version that I'm aware of. This might break Wine useage for > Macs. It might also break it for Solaris as well. > > James McKenzie > It should only break in a way that makes it as bad as it currently is. Thanks, Scott Ritchie

4 5

Re: kernel32: add stub for SetFileValidData
by Alexandre Julliard Aug. 17, 2010

Aug. 17, 2010

Austin English <austinenglish(a)gmail.com> writes: > @@ -1001,6 +1001,16 @@ error: > } > > /*********************************************************************** > + * SetFileValidData (KERNEL32.@) > + */ > +BOOL WINAPI SetFileValidData( HANDLE hFile, LONGLONG ValidDataLength ) > +{ > + FIXME("stub: %p, %llu\n", hFile, ValidDataLength); You can't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32, GetUserObjectInformation implementation with index=UOI_USER_SID (try2, resend)
by Alexandre Julliard Aug. 17, 2010

Aug. 17, 2010

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > New patch after rebase. > Always checks return values. > Tested with Polar Protrainer 5, updater.exe > From dcb91595b33513f8df2cf4d439221d3143c8fac1 Mon Sep 17 00:00:00 2001 > From: Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> > Date: Sat, 24 Jul 2010 17:12:05 +0200 > Subject: GetUserObjectInformation UOI_USER_SID (try 2) This should be retrieved from the server, based on the object security token or something along those lines. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw: Remove useless menu separator
by Octavian Voicu Aug. 17, 2010

Aug. 17, 2010

Not sure if it's useless. I thing it's intended to separate the static part of the menu (Add to favorites) from the dynamically generated list of favorite items that follows (which isn't implemented yet). Octavian

3 2

Re: [PATCH 1/4] msvcp90: Added allocator<char> 64-bit exports
by Alexandre Julliard Aug. 17, 2010

Aug. 17, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -35,6 +35,12 @@ char* __stdcall MSVCP_allocator_char_address(void *this, char *ptr) > return ptr; > } > > +/* ?address@?$allocator(a)D@std@@QEBAPEADAEAD(a)Z */ > +char* __cdecl MSVCP64_allocator_char_address(void *this, char *ptr) > +{ > + return MSVCP_allocator_char_address(this, ptr); > +} > + stdcall and cdecl are equivalent on 64-bit, so you don't need the extra wrappers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: avifil32: Fix EditStreamSetInfo wine checks [try 2]
by Alexandre Julliard Aug. 17, 2010

Aug. 17, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > +#define TEST_SETINFO_(m) \ > + hres = EditStreamSetInfo(stream, &info, sizeof(AVISTREAMINFO) ); \ > + ok( hres == 0, "got 0x%08X, expected 0\n", hres); \ > + hres = AVIStreamInfo(stream, &info2, sizeof(AVISTREAMINFO) ); \ > + ok( hres == 0, "got 0x%08X, expected 0\n", hres); \ > + ok( info2.m == info.m, "EditStreamSetInfo did not update "#m" parameter\n" ); > + > +#define TEST_SETINFO(m) \ > + info.m++; \ > + TEST_SETINFO_(m); \ > + \ > + info.m = 0; \ > + TEST_SETINFO_(m); Please avoid that sort of macros. Add a helper function if necessary, or just spell things out explicitly. -- Alexandre Julliard julliard(a)winehq.org

1 0

iPod synced with iTunes v7.6!
by Russ Mannex Aug. 17, 2010

Aug. 17, 2010

Hello Maarten! I read your post on the WineHQ site. I was wondering if you know whether I am attempting something that simply will not work yet. I am running iTunes 7.7.1 on Wine 1.1.42. These are running on Ubuntu 10.04. iTunes is not showing my iPod. I have tried setting an autodetect drive E: to /media/IPOD, but iTunes seems to not see it there. Any help will be greatly appreciated, even if the answer is "will not work." Thanks. -- Russ Mannex Russ(a)Mannex.com

3 2

Re: [PATCH 1/5] wined3d: separate driver info from GPU info
by Henri Verbeet Aug. 17, 2010

Aug. 17, 2010

On 17 August 2010 03:52, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > --- > dlls/wined3d/directx.c | 276 +++++++++++++++++++++------------------ > dlls/wined3d/wined3d_private.h | 14 ++ > 2 files changed, 163 insertions(+), 127 deletions(-) > This will return inconsistent driver version numbers for Vista, Win7 and 95/98/NT4.

1 0

Re: [2/2] gdiplus: Implement multi-frame image loading.
by testbot＠testbot.winehq.org Aug. 17, 2010

Aug. 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4486 Your paranoid android. === WVISTAADM (32 bit image) === No test summary line found

1 0

Re: [4/6] ipconfig: Partially implement basic adapter information output.
by Juan Lang Aug. 16, 2010

Aug. 16, 2010

Hi Andrew, + static const WCHAR ethernetW[] = {'E','t','h','e','r','n','e','t',0}; + static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',0}; shouldn't these be resources instead? --Juan

2 1

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.
by James Mckenzie Aug. 16, 2010

Aug. 16, 2010

Henri Verbeet <hverbeet(a)gmail.com> wrote: >Sent: Aug 16, 2010 11:06 AM >To: Rico Schüller <kgbricola(a)web.de> >Cc: wine-devel(a)winehq.org >Subject: Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion. > >2010/8/16 Rico Schüller <kgbricola(a)web.de>: >> Yes, this replaces the earlier patch series. I thought this was clear from >> the discussion for try 2. >> >At the very least it's obvious that the other series isn't going to >happen. Whether this series replaces it or is independent doesn't >matter a whole lot at that point. > If the other series is cancelled, it would be nice to state so as well. This conserves AJ's time and efforts. This has happened to me (I found that my code was seriously broken.) James McKenzie

1 0

WineAPI structure plans
by Max TenEyck Woodbury Aug. 16, 2010

Aug. 16, 2010

I think I have a usable structure for the pages on the WineAPI wiki which I am about to lay before you, but first a discussion of the project name... ---- I understand that some people do not particularly approve of the name I have given this project. It is on Sourceforge and a short relevant name was needed. Much of the information to be presented is specific to Wine and will be based on the contents of the Wine repository. The name reflects that dependence. Other projects may want to use the information presented. They are welcome to do so as far as I am concerned. They may also wish to present information specific to their projects. That is an excellent idea and I will help where I can, but I have two reservations: First, I am unlikely to be familiar with the structure of other projects; I will not be able to maintain those contributions. Someone from the other projects will have to take responsibility for maintaining those contributions and coordinate with the members of the project from Wine. Second, where there are differences between the projects, and the other projects are invited to provide their information but not at the expense of the Wine information. I also included a reference to 'API'. More than just the API will be covered, but the API will definitely be included. While Wine is intended to provide an interface functionally equivalent to the Microsoft products, it will differ from their interface in small ways. One of the most important differences will be that this API is open and *not* particularly designed to promote Microsoft's products. References to the Microsoft documentation will be included, but infringement of Microsoft's copyrights is *not* intended and will be corrected as quickly as it can be verified. The project name can be changed if really necessary, but requests to change it should be constructive with an emphasis on how the new name meets the projects needs. ---- There are two major types of information that will be presented. One type of information is annotation, opinion, discussion, description and so on. This will be managed by people. Another type of information is technical and is tied directly to the contents of the Wine project (and other projects when the details have been worked out). My intention is to write scripts that extract and report this kind of information. This information will change as Wine changes. It will be difficult for the scripts to work around the human generated content. To allow the two major kinds of information to mix, they will be kept on separate pages. Specifically, the editable information will be kept on what MediaWiki calls 'sub-pages'. The places where sub-pages are included will be controlled by the scripts. The script writers will need to be informed of where these inclusions should be placed. Also, to keep the number of 'red-links' under control, The scripts will generate initial versions of the sub-pages. Some structure is needed to make the scripts work and to allow people to check the scripts. For that reason, all script generated pages will start with a comment describing the main script responsible for generating the page along with revision information for the script and script components. The comment will also identify the revision of the repository used to generate the page. (Note, the revision information will be for the last time the page content has to be changed, and will not be updated unless the page content, and not the revision information, is changed. Some structure will also be needed for sub-pages and will be set up in the generated initial versions of those pages. That structure consists of a link back to the article that included the sub-page, markings that the page is editable and at least one section header to serve as a handle to enable easy editing of the sub-page. -Max

1 0

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.
by James McKenzie Aug. 16, 2010

Aug. 16, 2010

Rico Schüller wrote: > Hi, > > this patch series implements the ID3DBlob interface. This time the > interface is implemented in the d3dcompiler_43.dll. The function > D3D10CreateBlob from d3d10 is forwarded to the D3DCreateBlob function > in the d3dcompiler_43.dll. Does this replace the ten patch series you submitted on 8/11? This is not clear here. James McKenzie

3 2

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.
by James Mckenzie Aug. 16, 2010

Aug. 16, 2010

Rico Schüller <kgbricola(a)web.de> wrote: >Sent: Aug 16, 2010 10:21 AM >To: wine-devel(a)winehq.org >Subject: Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion. > >Am 15.08.2010 18:26, schrieb James McKenzie: >> Rico Schüller wrote: >>> Hi, >>> >>> this patch series implements the ID3DBlob interface. This time the >>> interface is implemented in the d3dcompiler_43.dll. The function >>> D3D10CreateBlob from d3d10 is forwarded to the D3DCreateBlob function >>> in the d3dcompiler_43.dll. >> >> Does this replace the ten patch series you submitted on 8/11? This is >> not clear here. >> >Yes, this replaces the earlier patch series. I thought this was clear >from the discussion for try 2. > I've learned the hard way to never assume anything and to document everything. If something can be misunderstood it will and will in the most damaging manner. James McKenzie James McKenzie

1 0

RE: Wine users with a CD-ROM drive, please test
by Ge van Geldorp Aug. 16, 2010

Aug. 16, 2010

> From: Joerg Hoehle > > There's no mention of win95/98 in the attachment so I assume these > were not included, or was that because there was no error? Right, they were not included. I ran into some problems trying to attach the .iso to those VMs and gave up. Win9x should die :-). Ge.

1 0

RE: Wine users with a CD-ROM drive, please test
by Greg Geldorp Aug. 16, 2010

Aug. 16, 2010

Hi Joerg, > From: Joerg Hoehle > > I found out that some machines ignore > set c audio all off > which was in the testsuite, while others react to it and even > update the system preferences volume mixer control if > it happens to be open. > > I don't know whether that difference depends on the HW (CD-ROM > driver) or the OS. You can find it out by posting your results here. > > I'm now using > set c audio all on > (which should be the default) > such that all users running the testsuite get to hear something. > > https://testbot.winehq.org/JobDetails.pl?Key=4434 > mcicda.c:612: Test failed: STOP all returned MCIERR_HARDWARE > (I fixed that, but not yet on testbot). I ran mcicda_test from TestBot job 4436 on the TestBot VMs, with a data .iso connected as CD-ROM. Full results in attachment. In short: On NT4, Win2000: mcicda.c:318: Test failed: resume without play: 0=NOERROR On NT4, Win2000, XP, W2K3 mcicda.c:397: Test failed: STATUS position: MCIERR_HARDWARE Ge.

2 1

Re: [3/3] wined3d: Remove isInDraw hack from context_setup_target.
by Henri Verbeet Aug. 16, 2010

Aug. 16, 2010

On 16 August 2010 13:25, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > It is conceptually wrong and actually broken too (as the comment there > said). Just remove the hack now and properly fix any regression > that may come up later by explicitely acquiring the right context where > needed (so, in surface_internal_preload and its callees). Note that isInDraw is mildly awful in itself, and we should probably get rid of it eventually. In most places where it's used it's probably an artifact of the old context management, but that needs to be checked.

2 1

Re: [1/3] wined3d: Call set_render_offscreen at the end of context_setup_target.
by Henri Verbeet Aug. 16, 2010

Aug. 16, 2010

I'm ok with this, but for future reference, if the change isn't entirely obvious a small comment is usually appropriate.

1 0

Re: [PATCH 2/2] jscript: Throw TypeError in in_eval.
by testbot＠testbot.winehq.org Aug. 16, 2010

Aug. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4470 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: urlmon: Return failures from progress callback
by Jacek Caban Aug. 16, 2010

Aug. 16, 2010

Hi Juan, On 8/4/10 11:44 PM, Juan Lang wrote: > Partial fix for bug 21032. > --Juan if(!This->callback) - return; + return E_POINTER; This doesn't seem right. It's fine to call URLDownloadToFile without callback AFAIR. Thanks, Jacek

1 0

Re: [PATCH 1/2] jscript: Throw TypeError in instanceof_expression_eval.
by testbot＠testbot.winehq.org Aug. 16, 2010

Aug. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4469 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Some statistics about the 1.0->1.2 development cycle
by Wolfram Sang Aug. 16, 2010

Aug. 16, 2010

Hello, I am going to speak about my "getting into wine development" at FrosCon (near Bonn/Germany) next weekend. During preparation, I was interested in some numbers, so I roughly modified 'kps' (kernel patch statistics) for wine. The outcome for the 1.0->1.2 cycle can be found here, if somebody is interested (just make sure you read the README first): http://www.the-dreams.de/wine/winekpsstats10-12.tar.gz So far, not too surprising IMHO, although I probably missed a number of people. I am open for comments, if there are some. Have a nice sunday, Wolfram

6 7

Re: [PATCH 1/1] d3dx9: Add tests for FVF <-> declaration conversion.
by Henri Verbeet Aug. 16, 2010

Aug. 16, 2010

This is for the most part just a copy of the corresponding d3d9 test, so I guess it should work, but it also contains most of the flaws from that test, like e.g. returning E_FAIL from a function returning int. There's probably room for improvement in the test setup itself as well.

1 0

Re: kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)
by Greg Geldorp Aug. 16, 2010

Aug. 16, 2010

Hi Joerg, I temporarily attached a second disk to all TestBot VMs and ran the test, both from the C: drive and from the (new) E: drive. Full results attached. In short: everything passes. Ge.

2 1

Re: comctl32: Simplify is_textT by omitting isW.
by Nikolay Sivov Aug. 15, 2010

Aug. 15, 2010

On 5/9/2010 16:43, Gerald Pfeifer wrote: > isW is not actually used by is_textT, so we can simplify listview.c a > bit by omitting the useless parameter. > > > > -static inline BOOL is_textT(LPCWSTR text, BOOL isW) > +static inline BOOL is_textT(LPCWSTR text) > > There's no reason to keep this helper then. It's better to rename is_textW() to is_text() and remove is_textT().

2 1

Re: Wine users with a CD-ROM drive, please test
by Greg Geldorp Aug. 15, 2010

Aug. 15, 2010

> From: <Joerg-Cyril.Hoehle(a)t-systems.com> > > this is my second call for participation, as only Jeff Zaroyko responded to the first one. > > I wrote a testsuite for mcicda (play music from CD-ROM using the MCI). > Wine's testbot job #4330 at > https://testbot.winehq.org/JobDetails.pl?Key=4330 > contains both a patch and binary of what I'd initially want to test about mcida.dll, > solely lacking compatibility fixes that testing on YOUR machine will show to be necessary. I can attach a .iso to each VM and run your tests. Would that help? Keep in mind that almost none of the VMs have sound support. Ge.

8 14

Re: [7/13] comctl32/imagelist: Fail to create imagelist with zero or negative image dimensions
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4453 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: [6/13] comctl32/imagelist: Fail in ImageList_GetIconSize on null parameters
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4452 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: [5/13] comctl32/tests: More imagelist tests to show broken parameter validation
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4451 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: [4/13] comctl32/imagelist: Fix failure code for IImageList_Remove()
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4450 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: [3/13] comctl32/imagelist: Fix failure code for IImageList_Draw()
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4449 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: [2/13] comctl32/tests: Use reduced IMAGELISTDRAWPARAMS structure size for tests
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4448 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1433: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: [1/13] comctl32/tests: Use better names for test functions, discover some new test failures
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4447 Your paranoid android. === WVISTAADM (32 bit imagelist) === imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W2K8SE (32 bit imagelist) === imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PRO (32 bit imagelist) === imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (32 bit imagelist) === imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 === W7PROX64 (64 bit imagelist) === imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 10, 7 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { 47, 31 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -9, -8 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000 imagelist.c:1438: Test failed: BeginDrag failed for { -7, 35 }, 0x00000000

1 0

Re: avifil32: Fix EditStreamSetInfo wine checks
by testbot＠testbot.winehq.org Aug. 15, 2010

Aug. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4442 Your paranoid android. === W98SE (32 bit api) === No test summary line found === WNT4WSSP6 (32 bit api) === No test summary line found === W2KPROSP4 (32 bit api) === No test summary line found === W2K3R2SESP2 (32 bit api) === No test summary line found === WVISTAADM (32 bit api) === No test summary line found === W2K8SE (32 bit api) === No test summary line found === W7PRO (32 bit api) === No test summary line found === W7PROX64 (32 bit api) === No test summary line found === W7PROX64 (64 bit api) === Timeout

1 0

Re: [2/2] ws2_32, WS2_sendto: Avoid error when sending zero byte buffer (try 2)
by Mike Kaplinskiy Aug. 14, 2010

Aug. 14, 2010

Several things: - Don't set errno. For good practice it's more or less read-only. - All the tests have to pass after each patch, so if your tests fail (which they probably should) without your patch, add todo_wine and then remove them in the followup patch (or just send the tests second). - The tests you provided pass without this patch so I'm not convinced that your fix is necessary. errno 107 = ENOTCONN, so while 0 length sends work just fine, they only work when non-zero sends also work. i.e. invalid sends get turned to valid sends on windows when the length is 0. It might be better to test calling WSASendTo with 0 length on unconnected tcp (or udp if tcp doesn't work) sockets. Good luck, Mike. On Sat, Aug 14, 2010 at 5:45 AM, Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> wrote: > This solves #19397. > > > > >

1 0

Re: [(try 2) 02/11] d3d10: Implement D3D10CreateBlob().
by Stefan Dösinger Aug. 13, 2010

Aug. 13, 2010

Am 11.08.2010 um 21:51 schrieb Rico Schüller: > --- a/dlls/d3d10/d3d10_private.h > +++ b/dlls/d3d10/d3d10_private.h > @@ -212,6 +212,17 @@ struct d3d10_effect > struct d3d10_effect_technique *techniques; > }; > > > +extern const struct ID3D10BlobVtbl d3d10_blob_vtbl DECLSPEC_HIDDEN; Do you need the declaration of the vtable in the header? As far as I can see you're not using it anywhere outside d3d10_main.c.

3 2

Fwd: Should we expect Liberation fonts to be installed?
by Paul "TBBle" Hampson Aug. 12, 2010

Aug. 12, 2010

Sorry, I failed at Gmail again. >_< ---------- Forwarded message ---------- From: Paul "TBBle" Hampson <Paul.Hampson(a)pobox.com> Date: 12 August 2010 13:52 Subject: Re: Should we expect Liberation fonts to be installed? To: Scott Ritchie <scott(a)open-vote.org> On 8 August 2010 13:02, Scott Ritchie <scott(a)open-vote.org> wrote: > On 08/03/2010 01:57 PM, Scott Ritchie wrote: >> I was looking through our fairly large collection of open font bugs and >> realized that things might be a lot simpler if we took some opinionated >> positions and just declared certain fonts to be dependencies and >> expected all packagers to provide them. >> >> This is similar to bundling our own Tahoma, except much less work. >> >> >> This bug, for instance, prevents Photoshop from working unless there is >> an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 >> >> Wine doesn't seem to respect system-level fontconfig aliases, so even >> though Liberation Sans is installed on the system Photoshop won't try to >> use it in place of Arial. >> >> But if however we assumed that Liberation Sans was installed, we could >> make things much better: a link/substitution for Arial->Liberation Sans >> could be provided in our own registry (and similarly for Times New Roman >> and Courier). An alternative is to simply symlink to the Liberation >> Fonts in /usr/share/wine/fonts as though they were our own shipped fonts >> (like Tahoma). >> >> This would make Photoshop think Arial was present and keep it >> functional. Ideally the real Arial would be displayed if it was >> installed (eg through winetricks corefonts or by installing the >> distro-provided corefonts package). >> >> >> A related question is whether to show "Arial" in the list of fonts (eg >> notepad) when we're actually just providing a substituted Arial. My >> inclination says no, however I'm not sure how it works internally and >> what an application would expect. >> > > Assuming for a moment this is a good idea, what's the best > implementation? My inclination is to say some registry font links, but > I'm not completely familiar with how that works. > > Will font links in the registry be ignored when the real font is present? (Wine-specific) Font Replacements will be ignored when the real font is present. Those're the ones in HKCU\Software\Wine\Fonts\Replacements and probably the ones you want to use. (Which could be supplanted or supplemented by working FontConfig alias support...) (GDI) Font Links (ie. the same registry entries Windows uses) are fallbacks for missing glyphs. Those're the ones in HKLM\SOFTWARE\Microsoft\FontLink\SystemLink Font Substitutes _probably_ don't get ignored if a real font with that name exists. Those're the ones in HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes and they're pretty purpose-specific. The only entries we want for them in Wine are the ones described at http://blogs.msdn.com/b/michkap/archive/2005/03/20/399322.aspx (which should probably be the default in Wine anyway, at least the Tahoma entry.) (Which by-the-by highlights a mistake in my previous suggestion towards bug 13829) -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com On 12 August 2010 13:52, Paul "TBBle" Hampson <Paul.Hampson(a)pobox.com> wrote: > (Wine-specific) Font Replacements will be ignored when the real font > is present. Those're the ones in HKCU\Software\Wine\Fonts\Replacements > and probably the ones you want to use. (Which could be supplanted or > supplemented by working FontConfig alias support...) To be clear, I think the best first-step solution for this bug is for Wine's Font Replacements code to read the aliases from FontConfig as well as its own registry keys when building its list. (The latter being taken over the former) That would make the problem magically go away on systems that do include appropriately-substitutable fonts. -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com

2 2

Re: Windows Imaging Component
by Roderick Colenbrander Aug. 12, 2010

Aug. 12, 2010

On Thu, Aug 12, 2010 at 4:54 AM, Georgij Kirichenko <kirichenkoga(a)gmail.com> wrote: > This patch add support for decoding Dds, Ppm(and pgm, pbm) and Tga files th > Windows Imaging Component. Each format you are adding requires its own patch. > This patch use dynamic linked FreeImage library, but i'am can't static link > this library. First of all, I'm not so sure we want to use FreeImage. The initial thing about which I'm not sure is the license. You can use it under either a commercial license or under the GPL. The last one at least is usable for us as it would make all of Wine GPL when you link to it. I'm not sure about the 'free image public license terms'. It is not something like a BSD license, but more complicated. Someone would have to look at it whether that would even be usable (commercial versions like Crossover would have issues). >From what I remember TGA, and the PPM family are at least easy (not sure about DDS though, but I believe it is easy as well). If there are good standalone libs like libjpeg, libpng and friends for such libraries which are either BSD or LGPL licensed (or something similar that would be fine). We might also want to do them ourselves if we wanted (and they are relatively trivial). Lets wait for what others are saying. Roderick

1 1

Re: Windows Imaging Component
by Kirill K. Smirnov Aug. 12, 2010

Aug. 12, 2010

1 0

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.
by David Adam Aug. 12, 2010

Aug. 12, 2010

Hello, some comments about this patch + if (hr != S_OK) return FALSE; + else return TRUE; could be simplified as return SUCCEEDED(hr); + trace("HRESULT when creating instance (%x)\n", hr); Since tests are assumed to pass, we dont care about debug informations. So, traces are useless in tests. [It is my opinion. Better developpers could give an opposite opinion] + todo_wine ok(*(ULONG *)pDirectMusicPort != 0, "IDirectMusicPort not set\n"); Why is this cast useful? A+ David 2010/8/9 Austin Lund <austin.lund(a)gmail.com> > > > > >

6 9

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)
by Vitaliy Margolen Aug. 12, 2010

Aug. 12, 2010

On 08/11/2010 08:58 PM, Austin Lund wrote: > > > +static BOOL test_InitAudio(void) > +{ > + hr = IDirectMusicPerformance8_InitAudio(idmusicperformance,NULL,&pDirectSound,NULL,1,128,0x3f,NULL); > + if (hr != S_OK) return FALSE; > + else return TRUE; > +} Please put spaces after comas, as you do in the rest of the file. What are those magic numbers? Please use constants. If they are missing, add them to appropriate header file first. Same thing with return as in prior function.. > +static void test_PChannelInfo(void) Already covered in another thread. Vitaliy.

2 2

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)
by James McKenzie Aug. 12, 2010

Aug. 12, 2010

Austin Lund wrote: Why the try2? It is always nice to put why you are doing this in the git commit notes. AJ is on vakay and will not be back until next week so there are NO reviews ongoing this week, except developer peer ones. James McKenzie

2 1

Re: [PATCH] qmgr/tests: Detect, when the service is disabled
by testbot＠testbot.winehq.org Aug. 11, 2010

Aug. 11, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4405 Your paranoid android. === W98SE (32 bit qmgr) === qmgr.c:46: Test failed: CoCreateInstance failed: 80040154

1 0

Wine users with a CD-ROM drive, please test
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 11, 2010

Aug. 11, 2010

Hi, No more MCIERR_HARDWARE in David's latest test result, hurray! The difference with prior tests is that I temporarily eliminated 3 commands a) resume c b) set c video audio all off c) set c door closed notify We are not done yet. Users who saw that error please feed the following scripts into the mcishell to see which of those 3 commands causes the failure. The mcishell is attached to bug #20232 at http://bugs.winehq.org/show_bug.cgi?id=20232#c10 http://bugs.winehq.org/attachment.cgi?id=24529 wintest.exe mcishell mci.c:1363: Type your commands to the MCI, end with Ctrl-Z The 5 test failures in David's report are unrelated to MCIERR_HARDWARE. >mcicda.c:540: Test failed: status mode after play is playing Weird. I'd have expected Play to terminate within Sleep(3900ms) time. >mcicda.c:297: Test failed: status position initially 00:02:33 I'll take care of that another day. For now I'll just remember that there are disks that don't start at position 00:02:00. Please copy&paste these lines as one piece into a cmd shell so that there's as little delay as possible between commands. # a) resume open cdaudio alias c notify shareable status c mode status c position play c from 00:02:00 to 00:01:00 notify resume c status c mode seek c to start notify status c mode seek c to end # # testsuite uses seek c to MM:SS:FF instead set c time format tmsf play c from 1 stop c Don't forget after each one close c # b) set video audio open cdaudio alias c notify shareable status c mode status c position play c from 00:02:00 to 00:01:00 notify seek c to start notify set c video audio all off status c mode seek c to end # # testsuite uses seek c to MM:SS:FF instead set c time format tmsf play c from 1 stop c # c) set door closed open cdaudio alias c notify shareable status c mode status c position play c from 00:02:00 to 00:01:00 notify seek c to start notify set c door closed notify status c mode seek c to end # # testsuite uses seek c to MM:SS:FF instead set c time format tmsf play c from 1 stop c Thank you for testing, Jörg Höhle

1 0

Request for comments - d3dx9: Add tests for FVF <-> declaration conversion.
by misha680 Aug. 10, 2010

Aug. 10, 2010

Dear All: I have become more busy with schoolwork than I had imagined. However, I would still like, if possible, to finish work on http://bugs.winehq.org/show_bug.cgi?id=22918 It has been suggested that I send patches to the wine-devel list first for feedback. This way, I hope to be able to get developer expertise in these areas, and to be able to understand exactly what is necessary for a given patch. I have, per this comment from Henri: http://bugs.winehq.org/show_bug.cgi?id=22918#c51 written a draft patch for FVF <-> declaration conversion tests. It can be found at the Nabble link below. I will appreciate comments as to what is necessary for this patch (or a similar one) to get accepted. http://wine.1045685.n5.nabble.com/file/n2471306/0001-d3dx9-Add-tests-for-FV… 0001-d3dx9-Add-tests-for-FVF-declaration-conversion.txt I realize there are already three tests for conversion in one direction. I have decided at the moment to leave those as is and focus on getting necessary feedback for getting an appropriate patch accepted. If you have any guidance with regards to this, much appreciated. Thank you Misha p.s. I have uploaded some shell scripts that I use for Wine development here: http://groups.google.com/group/misha680-wine/files I don't know how useful they will be to anyone else, but if anything, it provides an nice backup for my computer. -- View this message in context: http://wine.1045685.n5.nabble.com/Request-for-comments-d3dx9-Add-tests-for-… Sent from the Wine - Devel mailing list archive at Nabble.com.

2 2

Re: [PATCH 1/5] ddraw/tests: Add test for bad size of surface caps in CreateSurface. (try 5)
by Stefan Dösinger Aug. 10, 2010

Aug. 10, 2010

Diff -u doesn't find any difference between try 4 and try 5, and probably older tries. If you're resending them because the older ones weren't applied, that's futile - Alexandre is on vacation. Also it is generally a bad idea to keep resending a unchanged patch. If you think the patch has been lost(e.g. Alexandre is waiting for my review and I am not at home, etc) it is better to ask on Wine-devel what is up with the patches. Am Sonntag 08 August 2010, 07:09:24 schrieb Oldřich Jedlička: > --- > dlls/ddraw/tests/dsurface.c | 138 > +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 138 > insertions(+), 0 deletions(-) > > diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c > index 76bfc7e..8cdcd92 100644 > --- a/dlls/ddraw/tests/dsurface.c > +++ b/dlls/ddraw/tests/dsurface.c > @@ -25,6 +25,7 @@ > > #include <assert.h> > #include "wine/test.h" > +#include "wine/exception.h" > #include "ddraw.h" > #include "d3d.h" > #include "unknwn.h" > @@ -3569,6 +3570,142 @@ static void BackBufferAttachmentFlipTest(void) > DestroyWindow(window); > } > > +static void CreateSurfaceBadCapsSizeTest(void) > +{ > + DDSURFACEDESC ddsd_ok; > + DDSURFACEDESC ddsd_bad1; > + DDSURFACEDESC ddsd_bad2; > + DDSURFACEDESC ddsd_bad3; > + DDSURFACEDESC ddsd_bad4; > + DDSURFACEDESC2 ddsd2_ok; > + DDSURFACEDESC2 ddsd2_bad1; > + DDSURFACEDESC2 ddsd2_bad2; > + DDSURFACEDESC2 ddsd2_bad3; > + DDSURFACEDESC2 ddsd2_bad4; > + IDirectDrawSurface *surf; > + IDirectDrawSurface4 *surf4; > + IDirectDrawSurface7 *surf7; > + HRESULT hr; > + IDirectDraw2 *dd2; > + IDirectDraw4 *dd4; > + IDirectDraw7 *dd7; > + > + const DWORD caps = DDSCAPS_OFFSCREENPLAIN; > + > + memset(&ddsd_ok, 0, sizeof(ddsd_ok)); > + ddsd_ok.dwSize = sizeof(ddsd_ok); > + ddsd_ok.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; > + ddsd_ok.dwWidth = 64; > + ddsd_ok.dwHeight = 64; > + ddsd_ok.ddsCaps.dwCaps = caps; > + memcpy(&ddsd_bad1, &ddsd_ok, sizeof(ddsd_bad1)); > + ddsd_bad1.dwSize--; > + memcpy(&ddsd_bad2, &ddsd_ok, sizeof(ddsd_bad2)); > + ddsd_bad2.dwSize++; > + memcpy(&ddsd_bad3, &ddsd_ok, sizeof(ddsd_bad3)); > + ddsd_bad3.dwSize = 0; > + memcpy(&ddsd_bad4, &ddsd_ok, sizeof(ddsd_bad4)); > + ddsd_bad4.dwSize = sizeof(DDSURFACEDESC2); > + > + memset(&ddsd2_ok, 0, sizeof(ddsd2_ok)); > + ddsd2_ok.dwSize = sizeof(ddsd2_ok); > + ddsd2_ok.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; > + ddsd2_ok.dwWidth = 64; > + ddsd2_ok.dwHeight = 64; > + ddsd2_ok.ddsCaps.dwCaps = caps; > + memcpy(&ddsd2_bad1, &ddsd2_ok, sizeof(ddsd2_bad1)); > + ddsd2_bad1.dwSize--; > + memcpy(&ddsd2_bad2, &ddsd2_ok, sizeof(ddsd2_bad2)); > + ddsd2_bad2.dwSize++; > + memcpy(&ddsd2_bad3, &ddsd2_ok, sizeof(ddsd2_bad3)); > + ddsd2_bad3.dwSize = 0; > + memcpy(&ddsd2_bad4, &ddsd2_ok, sizeof(ddsd2_bad4)); > + ddsd2_bad4.dwSize = sizeof(DDSURFACEDESC); > + > + hr = IDirectDraw_CreateSurface(lpDD, &ddsd_ok, &surf, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface failed: 0x%08x\n", hr); > + IDirectDrawSurface_Release(surf); > + > + hr = IDirectDraw_CreateSurface(lpDD, &ddsd_bad1, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw_CreateSurface(lpDD, &ddsd_bad2, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw_CreateSurface(lpDD, &ddsd_bad3, &surf, NULL); > + ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface didn't return > 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw_CreateSurface(lpDD, &ddsd_bad4, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + > + hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw2, (void **) > &dd2); + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: > 0x%08x\n", hr); + > + hr = IDirectDraw2_CreateSurface(dd2, &ddsd_ok, &surf, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw2_CreateSurface failed: 0x%08x\n", hr); > + IDirectDrawSurface_Release(surf); > + > + hr = IDirectDraw2_CreateSurface(dd2, &ddsd_bad1, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw2_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw2_CreateSurface(dd2, &ddsd_bad2, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw2_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw2_CreateSurface(dd2, &ddsd_bad3, &surf, NULL); > + ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw2_CreateSurface didn't > return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw2_CreateSurface(dd2, &ddsd_bad4, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw2_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + > + IDirectDraw2_Release(dd2); > + > + hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw4, (void **) > &dd4); + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: > 0x%08x\n", hr); + > + hr = IDirectDraw4_CreateSurface(dd4, &ddsd2_ok, &surf4, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw4_CreateSurface failed: 0x%08x\n", hr); > + IDirectDrawSurface4_Release(surf4); > + > + hr = IDirectDraw4_CreateSurface(dd4, &ddsd2_bad1, &surf4, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw4_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw4_CreateSurface(dd4, &ddsd2_bad2, &surf4, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw4_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw4_CreateSurface(dd4, &ddsd2_bad3, &surf4, NULL); > + ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw4_CreateSurface didn't > return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw4_CreateSurface(dd4, &ddsd2_bad4, &surf4, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw4_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + > + IDirectDraw4_Release(dd4); > + > + hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw7, (void **) > &dd7); + ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: > 0x%08x\n", hr); + > + hr = IDirectDraw7_CreateSurface(dd7, &ddsd2_ok, &surf7, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw7_CreateSurface failed: 0x%08x\n", hr); > + IDirectDrawSurface7_Release(surf7); > + > + hr = IDirectDraw7_CreateSurface(dd7, &ddsd2_bad1, &surf7, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw7_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw7_CreateSurface(dd7, &ddsd2_bad2, &surf7, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw7_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw7_CreateSurface(dd7, &ddsd2_bad3, &surf7, NULL); > + ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw7_CreateSurface didn't > return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + hr = IDirectDraw7_CreateSurface(dd7, &ddsd2_bad4, &surf7, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw7_CreateSurface > didn't return 0x%08x, but 0x%08x\n", + DDERR_INVALIDPARAMS, hr); > + > + IDirectDraw7_Release(dd7); > +} > + > START_TEST(dsurface) > { > HRESULT ret; > @@ -3624,5 +3761,6 @@ START_TEST(dsurface) > GetDCFormatTest(); > BackBufferCreateSurfaceTest(); > BackBufferAttachmentFlipTest(); > + CreateSurfaceBadCapsSizeTest(); > ReleaseDirectDraw(); > }

2 2

X Presentation and Synchronization - will it help Wine performance
by Groeschel, Volker Aug. 10, 2010

Aug. 10, 2010

Hi, I wonder if Wine will profit from the new X Presentation and Synchronization feature NVIDIA is working on: http://people.freedesktop.org/~aplattner/x-presentation-and-synchronization… According to the Phoronix article the feature is planed for X.Org Server 1.10: http://www.phoronix.com/scan.php?page=news_item&px=ODM3Ng e.g. when I start several instances of my game with Wine on my computer (AMD X2 with Ubuntu and proprietary NVIDIA graphic drivers), performance breaks down dramatically. As of three instances the third windows freezes or gets near 0 FPS while the same computer with Win XP can run up to eight instances. Many thanks for your good work which helps me to get rid of Windows in my home office ☺

3 2

New and subtle ddraw:dsurface test failure
by wylda＠volny.cz Aug. 10, 2010

Aug. 10, 2010

Hi, i just noticed some new and subtle failure in ddraw:dsurface tests. I don't know how closely you watch and study tests results, so i thought it might be a good idea bring it the the light. Sorry if not ;-) Compared WinXP 277040d92454 vs 8b2a403a7dc3 (latest vs last Friday). Interestingly does not happen on Intel and nVidia 64bit. So the only affected is nVidia 32bit. (For my education) Generally, when the test fails in Windows world, it means that the test is wrongly written or not supported under the tested Windows version? (not blaming anyone, just asking how things work;) And the last question is about MSI failures and timeouts which some boxes suffers... In my case the "powerful" succeeds and the "weak" timeouts here (and not just mine). Shouldn't be the timeout prolonged? Regards, W. PS: I probably missed "gratulation time" for v1.2, so at least i wish all the goodness to 1.3.xx line! And hope i find another free time for buzilla soon.

5 6

Re: winex11.drv: Fix uninitialised values. (valgrind) (try 2)
by Michael Stefaniuc Aug. 10, 2010

Aug. 10, 2010

Hello Austin, Austin Lund wrote: > > ------------------------------------------------------------------------ > From 07bc18edc35c68c8e0da58a70ccd5c8f03584a1a Mon Sep 17 00:00:00 2001 > From: Austin Lund <austin.lund(a)gmail.com> > Date: Tue, 10 Aug 2010 13:03:14 +1000 > Subject: [PATCH] winex11.drv: Fix uninitialised values. (valgrind) > > --- > dlls/winex11.drv/bitmap.c | 2 +- > dlls/winex11.drv/dib.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winex11.drv/bitmap.c b/dlls/winex11.drv/bitmap.c > index 4683fd9..af6c00b 100644 > --- a/dlls/winex11.drv/bitmap.c > +++ b/dlls/winex11.drv/bitmap.c > @@ -351,7 +351,7 @@ LONG CDECL X11DRV_SetBitmapBits( HBITMAP hbitmap, const void *bits, LONG count ) > wine_tsx11_lock(); > image = XCreateImage( gdi_display, visual, physBitmap->pixmap_depth, ZPixmap, 0, NULL, > bitmap.bmWidth, height, 32, 0 ); > - if (!(image->data = HeapAlloc( GetProcessHeap(), 0, image->bytes_per_line * height ))) > + if (!(image->data = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, image->bytes_per_line * height ))) > { > WARN("No memory to create image data.\n"); > XDestroyImage( image ); > diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c > index 11157f1..eda064e 100644 > --- a/dlls/winex11.drv/dib.c > +++ b/dlls/winex11.drv/dib.c > @@ -3535,7 +3535,7 @@ static int X11DRV_DIB_SetImageBits( const X11DRV_DIB_IMAGEBITS_DESCR *descr ) > else { > bmpImage = XCreateImage( gdi_display, visual, descr->depth, ZPixmap, 0, NULL, > descr->infoWidth, lines, 32, 0 ); > - bmpImage->data = HeapAlloc( GetProcessHeap(), 0, lines * bmpImage->bytes_per_line ); > + bmpImage->data = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, lines * bmpImage->bytes_per_line ); > if(bmpImage->data == NULL) { > ERR("Out of memory!\n"); > XDestroyImage( bmpImage ); > both functions are heavily used and you don't want to waste time HEAP_ZERO_MEMORY just to please valgrind. I even wonder why valgrind complains as e.g. in X11DRV_SetBitmapBits() only the default switch case won't initialize the memory at all. bye michael

2 2

Re: [PATCH] quartz: implement AsyncReader_FindPin
by David Adam Aug. 9, 2010

Aug. 9, 2010

Hi, what about if ppPin is NULL? I think that this patch needs test cases to prove that it is correct? David 2010/8/6 Anton Khirnov <wyskas(a)gmail.com> > --- > dlls/quartz/filesource.c | 32 ++++++++++++++++++++++++++++++-- > 1 files changed, 30 insertions(+), 2 deletions(-) > > diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c > index 110415d..00a91c8 100644 > --- a/dlls/quartz/filesource.c > +++ b/dlls/quartz/filesource.c > @@ -548,9 +548,37 @@ static HRESULT WINAPI AsyncReader_EnumPins(IBaseFilter > * iface, IEnumPins **ppEn > > static HRESULT WINAPI AsyncReader_FindPin(IBaseFilter * iface, LPCWSTR Id, > IPin **ppPin) > { > - FIXME("(%s, %p)\n", debugstr_w(Id), ppPin); > + IEnumPins *enumpins; > + HRESULT hr; > > - return E_NOTIMPL; > + hr = AsyncReader_EnumPins(iface, &enumpins); > + if (FAILED(hr)) > + return S_FALSE; > + > + while (hr == S_OK) { > + IPin *pin; > + LPWSTR pinname; > + > + hr = IEnumPins_Next(enumpins, 1, &pin, NULL); > + if (FAILED(hr)) > + break; > + > + hr = IPin_QueryId(pin, &pinname); > + if (SUCCEEDED(hr)) { > + if (!strcmpW(pinname, Id)) { > + *ppPin = pin; > + IPin_AddRef(*ppPin); > + CoTaskMemFree(pinname); > + break; > + } > + CoTaskMemFree(pinname); > + } > + } > + > + IEnumPins_Release(enumpins); > + if (SUCCEEDED(hr)) > + return S_OK; > + return S_FALSE; > } > > static HRESULT WINAPI AsyncReader_QueryFilterInfo(IBaseFilter * iface, > FILTER_INFO *pInfo) > -- > 1.7.1 > > > >

2 1

'winetricks python' and user-submitted small testcases
by Dan Kegel Aug. 8, 2010

Aug. 8, 2010

Waaaay back in 2002, the wine project experimented with writing win32 conformance tests in Perl. Nobody liked it; it was dropped in favor of conformance tests in C, and there was much rejoicing. Today I noticed http://bugs.winehq.org/show_bug.cgi?id=23940 which has a simple win32 test case written in Python. Surprisingly, with 'winetricks python', the test case ran and demonstrated the problem (though since the python script expected you to start another app first, and edit the python to have the other app's window title, it wasn't an unattended test). That particular bug isn't anything special, but I was happy to see that a user who preferred Python was able to successfully send a minimal test case for a win32 problem written in his favorite language, and have someone else successfully run it.

1 0

Re: [PATCH 5/5] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 5)
by testbot＠testbot.winehq.org Aug. 8, 2010

Aug. 8, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4356 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1742: Test failed: Got color 000a246a, expected 00000000 visual.c:1748: Test failed: Got color 006b8bbd, expected 00ff0000 or near visual.c:1751: Test failed: Got color 00ffffff, expected 00000000 visual.c:1757: Test failed: Got color 00ffffff, expected 00800000 or near === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: gdi32: use usp10 to optionally generate glyphs for bidi strings
by Dmitry Timoshkov Aug. 8, 2010

Aug. 8, 2010

Aric Stewart <aric(a)codeweavers.com> wrote: > allows us to be able to make use of the mirroring code and eventually > the shaping code when it is in place. This should be done the other way around. gdi32 should not depend on a high level dll (that creates circular dependencies), gdi32 in Windows doesn't use usp10 either. -- Dmitry.

4 5

Re: [PATCH 1/5] ddraw/tests: Add test for bad size of surface caps in CreateSurface. (try 5)
by testbot＠testbot.winehq.org Aug. 8, 2010

Aug. 8, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4352 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Should we expect Liberation fonts to be installed?
by Scott Ritchie Aug. 8, 2010

Aug. 8, 2010

I was looking through our fairly large collection of open font bugs and realized that things might be a lot simpler if we took some opinionated positions and just declared certain fonts to be dependencies and expected all packagers to provide them. This is similar to bundling our own Tahoma, except much less work. This bug, for instance, prevents Photoshop from working unless there is an Arial font installed: http://bugs.winehq.org/show_bug.cgi?id=9623 Wine doesn't seem to respect system-level fontconfig aliases, so even though Liberation Sans is installed on the system Photoshop won't try to use it in place of Arial. But if however we assumed that Liberation Sans was installed, we could make things much better: a link/substitution for Arial->Liberation Sans could be provided in our own registry (and similarly for Times New Roman and Courier). An alternative is to simply symlink to the Liberation Fonts in /usr/share/wine/fonts as though they were our own shipped fonts (like Tahoma). This would make Photoshop think Arial was present and keep it functional. Ideally the real Arial would be displayed if it was installed (eg through winetricks corefonts or by installing the distro-provided corefonts package). A related question is whether to show "Arial" in the list of fonts (eg notepad) when we're actually just providing a substituted Arial. My inclination says no, however I'm not sure how it works internally and what an application would expect. Thanks, Scott Ritchie

2 3

Re: [PATCH 5/5] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 4)
by testbot＠testbot.winehq.org Aug. 7, 2010

Aug. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4348 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:2970: Test failed: IDirectDraw_CreateSurface returned: 80070057 visual.c:2986: Test failed: IDirectDraw_CreateSurface returned: 88760091 === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 2/5] ddraw/tests: New visual back buffer flipping tests. (try 4)
by testbot＠testbot.winehq.org Aug. 7, 2010

Aug. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4345 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:2970: Test failed: IDirectDraw_CreateSurface returned: 80070057 visual.c:2986: Test failed: IDirectDraw_CreateSurface returned: 88760091

1 0

Re: [PATCH 1/5] ddraw/tests: Add test for bad size of surface caps in CreateSurface. (try 4)
by testbot＠testbot.winehq.org Aug. 7, 2010

Aug. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4344 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: user32: Don't crash for unknown button styles
by Nikolay Sivov Aug. 7, 2010

Aug. 7, 2010

On 8/6/2010 22:22, André Hentschel wrote: > got that case with an MFC application which had a 3state radiobutton with buttonstyle 15(decimal) > with this fix everything is fine as the painting of the button is handled elsewhere, without that fix it crashes as it reads bad data behind the array. > > --- > dlls/user32/button.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/user32/button.c b/dlls/user32/button.c > index 54d54dc..4f629f0 100644 > --- a/dlls/user32/button.c > +++ b/dlls/user32/button.c > @@ -197,7 +197,7 @@ static inline UINT get_button_type( LONG window_style ) > /* paint a button of any type */ > static inline void paint_button( HWND hwnd, LONG style, UINT action ) > { > - if (btnPaintFunc[style]&& IsWindowVisible(hwnd)) > + if (style<= MAX_BTN_TYPE&& btnPaintFunc[style]&& IsWindowVisible(hwnd)) > { > HDC hdc = GetDC( hwnd ); > btnPaintFunc[style]( hwnd, hdc, action ); This needs a test to see what happens visually for style 0xf, maybe we need just to duplicate an entry in paint function table; also while you're at it: static inline UINT get_button_type( LONG window_style ) { return (window_style & 0x0f); } here BS_TYPEMASK should be used instead of 0xf.

2 4

Re: Configuring with -Werror
by André Hentschel Aug. 7, 2010

Aug. 7, 2010

> Configuring with -Werror used to work a while back for me; now that > -Wno-unused-result has been fixed I gave it another try and got this: > > configure: libxrandr 32-bit development files not found, XRandr won't > be supported. > configure: WARNING: Old Mesa headers detected. Consider upgrading your > Mesa libraries. > OpenGL and Direct3D won't be supported. > configure: WARNING: No sound system was found. Windows applications > will be silent. > > After a quick investigation, turns out many configure checks produce > warnings; patch below hacks around it, but I've never dealt with > configure before and apparently fixes need to go in configure.ac -- > anyone wants to give it a proper shot? Sorry for the noise on wine-patches, this should have been gone here... Patch looks ok, but that should only be changed in configure.ac... And the chance to get that in is not very high because AJ not always suppports different compilerflags. -- Best Regards, André Hentschel

1 0

Wine 1.3 packaged for Ubuntu, must be installed explicitly
by Scott Ritchie Aug. 7, 2010

Aug. 7, 2010

I have added a new series of Wine 1.3 packages to the Wine PPA: https://launchpad.net/~ubuntu-wine/+archive/ppa These are for 10.04 (Lucid) only and must be explicitly installed: sudo apt-get install wine1.3 Users who simply install the wine or wine1.2 packages (as in, all existing users) will instead get the stable Wine 1.2 release, which is still packaged there. Thanks, Scott Ritchie

1 0

Configuring with -Werror
by Jerome Leclanche Aug. 7, 2010

Aug. 7, 2010

Configuring with -Werror used to work a while back for me; now that -Wno-unused-result has been fixed I gave it another try and got this: configure: libxrandr 32-bit development files not found, XRandr won't be supported. configure: WARNING: Old Mesa headers detected. Consider upgrading your Mesa libraries. OpenGL and Direct3D won't be supported. configure: WARNING: No sound system was found. Windows applications will be silent. After a quick investigation, turns out many configure checks produce warnings; patch below hacks around it, but I've never dealt with configure before and apparently fixes need to go in configure.ac -- anyone wants to give it a proper shot? Jerome L. diff --git a/configure b/configure index 05a9317..ae29fe4 100755 --- a/configure ++ J. Leclanche / Adys+ b/configure @@ -8430,7 +8430,7 @@ int main () { static typeof(XRRSetScreenConfigAndRate) * func; - ; + if(func); return 0; } _ACEOF @@ -8685,7 +8685,7 @@ int main () { GLenum test = GL_UNSIGNED_SHORT_5_6_5; - ; + if(test); return 0; } _ACEOF @@ -10517,8 +10517,8 @@ if test "x$ac_cv_lib_asound_snd_pcm_hw_params_get_access" = x""yes; then : int main () { -int ret = snd_pcm_hw_params_get_access(NULL, NULL) - ; +int ret = snd_pcm_hw_params_get_access(NULL, NULL); + if(ret); return 0; } _ACEOF

1 0

Re: Wine users with a CD-ROM drive, please test
by Erik Inge Bolsø Aug. 6, 2010

Aug. 6, 2010

No failures on my winxp laptop. No mixed cd handy, so only audio cd tested. mcicda.c:270: CD length 73:35:54 mcicda.c:325: track #1 length 35694ms mcicda.c:392: Tests skipped: Got no mixed data+audio CD. mcicda.c:410: last track length: 04m:25s:41frames mcicda.c:418: last track position: 69m:12s:13frames mcicda: 102 tests executed (0 marked as todo, 0 failures), 1 skipped. -- -erik http://useofwords.blogspot.com/

1 1

Re: [PATCH 1/6] d3dx9_36/tests: Added HLSL test suite.
by Henri Verbeet Aug. 6, 2010

Aug. 6, 2010

On 5 August 2010 00:05, Travis Athougies <iammisc(a)gmail.com> wrote: > +#define CINTERFACE Why do you need this? > +#include <d3d9.h> d3d9.h should be implied by d3dx9.h > +#include <assert.h> > +#include <stdio.h> I don't think you need these either. > +struct vertex > +{ > + float x, y, z; > + float tx, ty; > +}; > + > +const struct vertex quad_vertices[4] = { > + {-1, -1, 0, 0, 1}, > + {-1, 1, 0, 0, 0}, > + {1, -1, 0, 1, 1}, > + {1, 1, 0, 1, 0} > +}; Those aren't floating point values. Also, please use consistent formatting. > +const struct vertex quad_vertices[4] = { ... > +static IDirect3DVertexBuffer9 *quad_geometry; > +static IDirect3DVertexShader9 *vshader_passthru; > +static IDirect3DVertexDeclaration9 *vdeclaration; > +static IDirect3DDevice9 *device; Why is all of that global? > + hres = IDirect3D9_CreateDevice(d3d9_ptr, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, NULL, D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_parameters, &device_ptr); Please break long lines. I realize this particular one is probably somehow my fault because I added it back in 2005 with c26ad82e75e408c302c21228ef08c1af0482326c, and everyone has been (blindly) copying it since, but there are other examples like setup_device() as well. Use 120 as maximum line length, 100 to be safe. > + hres = IDirect3DVertexBuffer9_Lock(quad_geometry, 0, sizeof(quad_vertices), (void**)&temp_geometry_vertices, 0); You don't need that cast. > + hres = D3DXCompileShader(vshader_passthru_hlsl, strlen(vshader_passthru_hlsl), > + NULL, NULL, "vshader", "vs_1_1", 0, > + &compiled, &errors, 0); > + if(FAILED(hres)) > + { > + vshader_passthru = NULL; That doesn't make sense, vshader_passthru is already NULL at that point. > + hr = D3DXCompileShader(shader, strlen(shader), > + NULL, NULL, "test", profile, > + 0, &compiled, &errors, constants); > + ok (hr == D3D_OK, "Pixel shader %s compilation failed: %s\n", shader, (char*) (errors?ID3DXBuffer_GetBufferPointer(errors):"")); This casts away const. > diff --git a/include/d3dx9shader.h b/include/d3dx9shader.h > index c8380bc..c54d27c 100644 > --- a/include/d3dx9shader.h > +++ b/include/d3dx9shader.h > @@ -296,6 +296,17 @@ HRESULT WINAPI D3DXAssembleShader(LPCSTR data, > LPD3DXBUFFER* shader, > LPD3DXBUFFER* error_messages); > > +HRESULT WINAPI D3DXCompileShader(LPCSTR src_data, > + UINT data_len, > + const D3DXMACRO* defines, > + LPD3DXINCLUDE include, > + LPCSTR function_name, > + LPCSTR profile, > + DWORD flags, > + LPD3DXBUFFER* shader, > + LPD3DXBUFFER* error_messages, > + LPD3DXCONSTANTTABLE* constant_table); > + This should be in a separate patch. The patch has some more issues, they shouldn't be hard to spot.

1 0

Re: [PATCH 2/5] gameux: Add stub of IGameStatisticsMgr implementation (try 2)
by Nikolay Sivov Aug. 6, 2010

Aug. 6, 2010

On 8/3/2010 13:58, Mariusz Pluciński wrote: > --- > dlls/gameux/Makefile.in | 1 + > dlls/gameux/factory.c | 5 ++ > dlls/gameux/gamestatistics.c | 153 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/gameux/gameux_private.h | 1 + > dlls/gameux/regsvr.c | 9 +++ > 5 files changed, 169 insertions(+), 0 deletions(-) > create mode 100644 dlls/gameux/gamestatistics.c > + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), openType, pOpenResult, ppiStats); > + FIXME("stub\n"); > + return E_NOTIMPL; No need for duplicated traces, add one FIXME with full parameter output in it.

3 3

The WineAPI wiki.
by Max TenEyck Woodbury Aug. 6, 2010

Aug. 6, 2010

I have started the WineAPI wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page Some issues have come up that may need to be discussed here. In particular, there is going to be an 'Overview' section for many articles and I think the information to fill it in should come from the wine source tree. Specifically, I'd like to create 'Overview.wiki' files to contain this information. - Max

3 12

Wine users with a CD-ROM drive, please test
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 6, 2010

Aug. 6, 2010

Hi, this is my second call for participation, as only Jeff Zaroyko responded to the first one. I wrote a testsuite for mcicda (play music from CD-ROM using the MCI). Wine's testbot job #4330 at https://testbot.winehq.org/JobDetails.pl?Key=4330 contains both a patch and binary of what I'd initially want to test about mcida.dll, solely lacking compatibility fixes that testing on YOUR machine will show to be necessary. Please download the executable or compile the patch and execute it in MS-Windows: mcicda_test.exe mcicda mcicda.c:270: CD length 69:23:66 mcicda.c:325: track #1 length 989547ms mcicda.c:375: track #1 length: 16m:29s:41frames mcicda.c:410: last track length: 03m:28s:19frames mcicda.c:418: last track position: 65m:57s:47frames mcicda: 112 tests executed (0 marked as todo, 0 failures), 0 skipped. BTW, I wrote patches to make all these tests succeed in Wine. Before submission, I'd appreciate some more test data. Thank you for your participation, Jörg Höhle

3 3

Re: wiki slightly broken still?
by David Gerard Aug. 6, 2010

Aug. 6, 2010

[to list as well] On 3 August 2010 15:07, Dimi Paun <dimi(a)lattica.com> wrote: > On Tue, 2010-08-03 at 14:30 +0200, Alexandru Băluț wrote: >> How difficult would it be to use ReCaptcha? >> http://www.google.com/recaptcha > Hm, don't know. We could hack our version to support recaptcha, > but I'm not familiar with the code base, and I don't have the > time right now. But I can take patches if someone is willing > to do it. The MoinMoin developers consider TextCHA inherently superior and so have no interest in writing a reCaptcha interface: http://moinmo.in/FeatureRequests/ReCaptcha (Note also the problems people have had with TextCHA: it becomes too much work to write the questions and to answer the questions.) If someone wants reCaptcha in MoinMoin, it appears they will need to write it all themselves. - d.

2 1

[PATCH 5/6] d3dx9_36/tests: Added trigonometric functions test to HLSL test suite
by Joris Huizer Aug. 5, 2010

Aug. 5, 2010

Hello Travis Athougies, In this patch, you have this code: + void *ret = NULL; //... + ret = HeapAlloc(GetProcessHeap(), 0, 4 * samples); + for(i = 0;i < 32;i++) { //... + memcpy((void*) (((DWORD) ret) + (4 * i)), lr.pBits, 4); //... + } I'm not sure, but I think this will cause 64-bit issues (truncating to a 32-bit value?) Even if it doesn't, it seems simpler (more readable) to use a char pointer instead of a void pointer, like + char *ret; //... + ret = HeapAlloc(GetProcessHeap(), 0, 4 * samples); //... + memcpy(ret + (4 * i), lr.pBits, 4); HTH, regards, Joris

2 1

GDB debugging on ARM
by André Hentschel Aug. 4, 2010

Aug. 4, 2010

Hi, what is the best/easiest/fastest way to hack Wine so it does not start winedbg and i can debug it with gdb? my problem is that my WineARM works so far that it tries to run winedbg and uses its own handlers. but i want that not to happen of course it crashes somewhere and then tries to start winedbg... but winedbg is not really implemented yet on arm and its not yet time for it. i just want to debug on assembler level with gdb... "winedbg --gdb" is also not what i want. So my understanding is that Wine somewhere register its exception handlers, but i cant find that code to disable it. Anyone? -- Best Regards, André Hentschel

2 1

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)
by Stefan Dösinger Aug. 4, 2010

Aug. 4, 2010

Am 03.08.2010 um 21:26 schrieb Oldřich Jedlička: > DirectX 1 interface allowed creation of explicit back buffers, so move the > restrictive checks to DirectX 2+ implementations. Don't permit creating of > primary surface back buffer. The patch(as well as 9 and 10) look OK to me. Patch 6 is OK too. Patch 8 is missing a call to wined3d to tell it about the new backbuffer. (Apps will likely still work with the GDI renderer, but not the opengl ddraw renderer)

2 1

Vacation
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Folks, I'll be on vacation until the end of next week, so there won't be any commits for a while. That shouldn't prevent anybody from making progress, as we have seen during the recent code freeze ;-) The next release will be on Friday 20th. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Oldřich Jedlička <oldium.pro(a)seznam.cz> writes: > + __TRY > + { > + hr = IDirectDraw_CreateSurface(lpDD, NULL, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface didn't return 0x%08x, but 0x%08x\n", > + DDERR_INVALIDPARAMS, hr); > + } > + __EXCEPT_PAGE_FAULT > + { > + todo_wine ok(FALSE, "IDirectDraw_CreateSurface dereferenced NULL pointer\n"); > + } > + __ENDTRY You can't use Wine exception macros in tests. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: shdocvw: Add the Polish translation
by Jacek Caban Aug. 4, 2010

Aug. 4, 2010

On 8/4/10 5:45 PM, Łukasz Wojniłowicz wrote: > From: Lukasz Wojnilowicz<Wojnilowicz(a)localhost.localdomain> > > --- > dlls/shdocvw/Makefile.in | 1 + > dlls/shdocvw/Pl.rc | 57 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+), 0 deletions(-) > create mode 100644 dlls/shdocvw/Pl.rc > > diff --git a/dlls/shdocvw/Makefile.in b/dlls/shdocvw/Makefile.in > index 9e2d8e1..f43e02e 100644 > --- a/dlls/shdocvw/Makefile.in > +++ b/dlls/shdocvw/Makefile.in > @@ -35,6 +35,7 @@ RC_SRCS = \ > Ko.rc \ > Lt.rc \ > Nl.rc \ > + Pl.rc \ > Ro.rc \ > Sv.rc \ > Uk.rc \ > diff --git a/dlls/shdocvw/Pl.rc b/dlls/shdocvw/Pl.rc > new file mode 100644 > index 0000000..1dd735b > --- /dev/null > +++ b/dlls/shdocvw/Pl.rc > @@ -0,0 +1,57 @@ > +/* > + * Copyright 2010 �ukasz Wojni�owicz > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "resource.h" > + > +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > + > +IDD_BROWSE_OPEN DIALOG 10, 10, 200, 70 > +STYLE DS_MODALFRAME | WS_CAPTION > +CAPTION "Otw�rz URL" > +FONT 8, "MS Shell Dlg" > +{ > + LTEXT "Podaj adres URL, kt�ry chcesz otworzy� w Internet Explorer",-1,25, 5, 150,15 It should be "(...) Internet Explorerze". > + LTEXT "Otw�rz:", -1, 2, 32, 20, 15 > + EDITTEXT IDC_BROWSE_OPEN_URL, 25, 30, 160, 13 > + DEFPUSHBUTTON "&OK", IDOK, 25, 50, 50, 15 > + PUSHBUTTON "&Anuluj", IDCANCEL, 85, 50, 50, 15 > +} > + > +IDR_BROWSE_MAIN_MENU MENU > +{ > + POPUP "&Plik" > + { > + POPUP "&Nowe" > + { > + MENUITEM "&Okno" ID_BROWSE_NEW_WINDOW > + } > + MENUITEM "&Otw�rz...", ID_BROWSE_OPEN > + MENUITEM "&Zapisz", ID_BROWSE_SAVE > + MENUITEM "Zapisz&jako...", ID_BROWSE_SAVE_AS > + MENUITEM SEPARATOR > + MENUITEM "Wydrukuj&format...", ID_BROWSE_PRINT_FORMAT It should be "Format wydruku". > + MENUITEM "&Drukuj...", ID_BROWSE_PRINT > + MENUITEM "Wydrukuj&podgl�d...", ID_BROWSE_PRINT_PREVIEW It should be "Podglad wydruku". Please be more careful about translations. ID_BROWSE_PRINT_FORMAT and ID_BROWSE_PRINT_PREVIEW are fairly obvious mistakes. Jacek

1 0

Re: shdocvw: Add the Polish translation
by Paul Vriens Aug. 4, 2010

Aug. 4, 2010

Hi Łukasz, On 08/04/2010 05:45 PM, Łukasz Wojniłowicz wrote: > +CAPTION "Otw�rz URL" This file needs the UTF-8 pragma. -- Cheers, Paul.

1 0

RE: WineTestBot and D3D
by Greg Geldorp Aug. 4, 2010

Aug. 4, 2010

> From: Stefan Doesinger > > Greg's testbot looks pretty useful by now, but for me it has one major > problem: It cannot run D3D tests because it is stuck in a virtual machine. > > I understand that the core of Winetestbot will stay in VMs, but is there a > way we can extend it with extra machines? I have a few spare boxes with > different GPUs here that could be used to run the tests. What I need is > basically: > > *) Some magic patchwatcher software I can install on these boxes > *) A Server this software talks to to get patch jobs and report the results > back. > *) Depending on the load, configure my machines to run d3d-related tests only > and leave others to the VMs. > > Now I guess it is important that if one of those extra test boxes dies(e.g. I > turn off my computers when I am away for a while) that this doesn't break the > testbot as a whole because it is waiting for test results. For starters I think > security is not that much of an issue, as long as I can firewall the machine > (via my router) and prevent it from connecting to anything but the testbot > master. > > Does the Testbot infrastructure allow this? Currently, no, it doesn't. But it certainly seems something that can be added. I'll investigate a bit what it will take. Ge.

1 0

Re: [PATCH 1/2] ntdll: Implement RtlIpv4AddressToString / RtlIpv4AddressToStringEx
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -37,8 +37,12 @@ > #include "winternl.h" > #include "wine/debug.h" > #include "wine/exception.h" > +#include "wine/unicode.h" > #include "ntdll_misc.h" > > +#include "winsock2.h" You don't want to include winsock2.h here. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineTestBot and D3D
by Stefan Dösinger Aug. 4, 2010

Aug. 4, 2010

Hi, Greg's testbot looks pretty useful by now, but for me it has one major problem: It cannot run D3D tests because it is stuck in a virtual machine. I understand that the core of Winetestbot will stay in VMs, but is there a way we can extend it with extra machines? I have a few spare boxes with different GPUs here that could be used to run the tests. What I need is basically: *) Some magic patchwatcher software I can install on these boxes *) A Server this software talks to to get patch jobs and report the results back. *) Depending on the load, configure my machines to run d3d-related tests only and leave others to the VMs. Now I guess it is important that if one of those extra test boxes dies(e.g. I turn off my computers when I am away for a while) that this doesn't break the testbot as a whole because it is waiting for test results. For starters I think security is not that much of an issue, as long as I can firewall the machine(via my router) and prevent it from connecting to anything but the testbot master. Does the Testbot infrastructure allow this? Cheers, Stefan

1 0

Re: [PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This fixes bug 18606. > > It's possible to refer to the same file in two different ways with PIDLs > in Wine. This can cause notifications via SHChangeNotify to fail to > trigger. To ensure an apples-to-apples comparison, we convert the > incoming PIDLs and the filters to UNIX paths and compare those if the > PIDLs fail to match. You should never compare Unix paths. If you want to compare file identity you should use stat and compare device+inode. But it's not clear to me that this is the right thing to do here, what is the exact case that is failing? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 3/4] jscript: Fixed Error.toString implementation for non-Error this.
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4288 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: user32: Protect from setting as a window owner one of window's succesors.
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4287 Your paranoid android. === W98SE (32 bit win) === win.c:110: Test failed: Wrong result for GWL_HWNDPARENT 0000076C expected 00000000 win.c:114: Test failed: Wrong result for GW_OWNER 0000076C expected 00000000 win.c:388: Test failed: GWL_HWNDPARENT return value 0000076C expected 0 === W7PRO (32 bit win) === win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01AE fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001AE fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:2668: Test failed: GetActiveWindow() = 00000000 win.c:2668: Test failed: GetFocus() = 00000000 win.c:2694: Test failed: GetActiveWindow() = 00000000 win.c:2694: Test failed: GetFocus() = 00000000 win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A0 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A2 fg 00030050 in hook HCBT_SETFOCUS win.c:2753: Test failed: GetActiveWindow() = 00000000 win.c:2753: Test failed: GetFocus() = 00000000 win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000C016C fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002E01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002F01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A4 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000801A4 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000901A4 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 001801A0 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A8 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000C016C fg 00030050 in hook HCBT_SETFOCUS

3 2

Re: [PATCH] kernel32/tests: Try harder to crash in the debugger test.
by Octavian Voicu Aug. 4, 2010

Aug. 4, 2010

Please ignore this patch. It seems that it does crash all the time, just that sometimes the debugger won't kick in on win64. There is a bug but it's somewhere else. Octavian

1 0

shdocvw: Update Italian translation
by Luca Bennati Aug. 4, 2010

Aug. 4, 2010

2 1

Re: d3dx9_36/tests: Added HLSL test suite. (try 3)
by Henri Verbeet Aug. 4, 2010

Aug. 4, 2010

On 3 August 2010 21:07, Travis Athougies <iammisc(a)gmail.com> wrote: > dlls/d3dx9_36/tests/Makefile.in | 1 + > dlls/d3dx9_36/tests/hlsl.c | 666 +++++++++++++++++++++++++++++++++++++++ > include/d3dx9shader.h | 11 + > 3 files changed, 678 insertions(+), 0 deletions(-) > create mode 100644 dlls/d3dx9_36/tests/hlsl.c > Needs splitting.

1 0

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)
by Stefan Dösinger Aug. 4, 2010

Aug. 4, 2010

Am 03.08.2010 um 21:26 schrieb Oldřich Jedlička: > + whiteBrush = CreateSolidBrush(white); > + ok(whiteBrush != NULL, "CreateBrush returned: %p\n", whiteBrush); > + redBrush = CreateSolidBrush(red); > + ok(redBrush != NULL, "CreateBrush returned: %p\n", redBrush); > + > + hr = IDirectDrawSurface_GetDC(Backbuffer, &dc); > + ok(hr == DD_OK, "IDirectDrawSurface_GetDC returned: %x\n", hr); > + ret = FillRect(dc, &rect, redBrush); > + ok(ret != 0, "FillRect failed\n"); > + hr = IDirectDrawSurface_ReleaseDC(Backbuffer, dc); > + ok(hr == DD_OK, "IDirectDrawSurface_ReleaseDC returned: %x\n", hr); It would be more directdraw-ish to use a colorfill blit instead of getDC + gdi drawing. Tests 1-3 and 5 look OK though.

1 0

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4262 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4261 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4260 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: tools/winebuild: add missing separators
by Andrew Nguyen Aug. 4, 2010

Aug. 4, 2010

On Tue, Aug 3, 2010 at 9:57 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > > The colons aren't decorative separators, but rather determine which short arguments expect a parameter as per the requirements of getopt/getopt_long. With your patch applied: $ tools/winebuild/winebuild -h tools/winebuild/winebuild: option requires an argument -- 'h'

1 0

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4251 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1497: Test failed: Got color 000a246a, expected 000000ff or near visual.c:1503: Test failed: Got color 006b8bbd, expected 000000ff or near visual.c:1509: Test failed: Got color 00ffffff, expected 00000080 or near visual.c:1515: Test failed: Got color 00ffffff, expected 00000080 or near

1 0

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4250 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH] kernel32/tests: Try harder to crash in the debugger test.
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4248 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:309: Test failed: Timed out waiting for the child to crash debugger.c:323: Test failed: wrong exit code : 00000103 debugger.c:334: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtD67.tmp': read=0 debugger.c:339: Test failed: wrong debugger argument count: -32297584 debugger.c:340: Test failed: the child and debugged pids don't match: 2284 != 2046 debugger.c:309: Test failed: Timed out waiting for the child to crash debugger.c:316: Test failed: wrong exit code : 00000103 debugger.c:334: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtE239.tmp': read=0 debugger.c:339: Test failed: wrong debugger argument count: -32297584 debugger.c:340: Test failed: the child and debugged pids don't match: 2384 != 2046 Timeout

1 0

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4246 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4245 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: regedit: Added Hebrew translation
by Alexandre Julliard Aug. 3, 2010

Aug. 3, 2010

Yaron Shahrabani <sh.yaron(a)gmail.com> writes: > Hope everything is cool this time :) > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > + WS_BORDER > +WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" That's not valid syntax. Please try to compile at least the files you are changing, if you can't do a full build. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 2/4] include/shlobj.h: SHILCreateFromPath takes both CSTR and WSTR
by Alexandre Julliard Aug. 3, 2010

Aug. 3, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This is different from the latest PSDK, but Wine's SHILCreateFromPath > accepts both types, so we shouldn't make compiler warnings about it. If there are warnings with the Windows headers there should be warnings with the Wine ones too. -- Alexandre Julliard julliard(a)winehq.org

1 0

wiki slightly broken still?
by Dan Kegel Aug. 3, 2010

Aug. 3, 2010

Creating new wiki pages seems broken today...

9 15

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)
by Vitaliy Margolen Aug. 3, 2010

Aug. 3, 2010

On 08/02/2010 05:48 PM, Jeff Cook wrote: > Moved check to conform with C90. > > + if (mastelem) { > + /* Master control */ ... > + } else { Please follow file's format. Vitaliy

1 0

Re: [PATCH 6/6] winealsa.drv: Open default device only once per card and don't discard non-defaults. (resend)
by Vitaliy Margolen Aug. 3, 2010

Aug. 3, 2010

On 08/02/2010 05:50 PM, Jeff Cook wrote: > - > + You adding trailing spaces here. > + } else { > + default_used = 1; > } > Please follow files' format - curly braces go on separate line. Also you don't need braces for one line "else". Vitaliy.

1 0

Re: [PATCH 3/6] winealsa.drv: Always scan devices, even if a default device exists. (resend)
by Vitaliy Margolen Aug. 3, 2010

Aug. 3, 2010

On 08/02/2010 05:49 PM, Jeff Cook wrote: > --- > dlls/winealsa.drv/waveinit.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > - int scan_devices = (fixedpcmdev == -1); > + /* we always want to scan_devices; otherwise, if a default is set and the > + appropriate registry keys are not set, only the default device will be seen > + by wine. This is undesirable, for instance, if you have separate cards for > + capture and playback, like a USB microphone for capture */ > + int scan_devices = 1; Please make it possible to force old behavior via registry. This was done for a reason - some devices were crashing during initialization, some were taking way too long to initialize. Vitaliy

1 0

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc
by Henri Verbeet Aug. 3, 2010

Aug. 3, 2010

On 31 July 2010 08:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This workaround isn't ideal, Yeah, I don't think this is much of an improvement.

4 4

Re: [PATCH 2/5] explorerframe/nstc: Create the treeview on initialization. (try 2)
by Alexandre Julliard Aug. 3, 2010

Aug. 3, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > +static LRESULT resize_namespacetree(NSTC2Impl *This) > +{ > + RECT rc; > + TRACE("%p\n", This); > + > + GetClientRect(This->hwnd_main, &rc); > + SetWindowPos(This->hwnd_tv, HWND_TOP, rc.left, rc.top, > + rc.right, rc.bottom, SWP_SHOWWINDOW); Again, that's not the correct usage of SetWindowPos. You don't want to show or activate it. What you probably want is MoveWindow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: GetVolumeInformationA: please test this on MS-Windows
by Andrew Eikum Aug. 3, 2010

Aug. 3, 2010

On 07/29/2010 03:43 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Andrew, > >>Run on a Win98SE VM. The E drive is a CDROM drive. > Thank you very much for the result. I added the broken(GetLastError()) for Win9x > based on your data. > > Now is your chance to repeat the test with > https://testbot.winehq.org/JobDetails.pl?Key=4014 > (either as .patch file or the binary from testbot). > This is valuable because testbot skips most new tests, lacking another drive, > giving no proof that the fixed patch indeed works without errors on win9x. > If it fails, please report to wine-devel as I already submitted the new patch. Hi Jörg, No failures with the testbot executable. Run under the same Win98SE VM, again from the E: drive. Andrew

3 7

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4179 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF

2 1

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4188 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4187 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4186 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 2/5] ws2_32/tests: test ConnectEx
by Mike Kaplinskiy Aug. 3, 2010

Aug. 3, 2010

On Mon, Aug 2, 2010 at 11:50 PM, Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> wrote: > --- > dlls/ws2_32/tests/sock.c | 227 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 227 insertions(+), 0 deletions(-) > Shoot, any chance you can just take #1 and take 2-5 from the first batch? That's an outdated not working version of the patches. Otherwise I'll resend tomorrow. Sorry, Mike.

1 0

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4178 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4175 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4174 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: shdocvw: Update French translation
by Frédéric Delanoy Aug. 3, 2010

Aug. 3, 2010

Please discard; has been mangled by misconfigured git 2010/8/2 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shdocvw/Fr.rc | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/shdocvw/Fr.rc b/dlls/shdocvw/Fr.rc > index 94b4a7e..b7326bb 100644 > --- a/dlls/shdocvw/Fr.rc > +++ b/dlls/shdocvw/Fr.rc > @@ -55,6 +55,11 @@ IDR_BROWSE_MAIN_MENU MENU > MENUITEM SEPARATOR > MENUITEM "&Propriétés...", ID_BROWSE_PROPERTIES > } > + POPUP "&Favoris" > + { > + MENUITEM "&Ajouter aux favoris..." ID_BROWSE_ADDFAV > + MENUITEM SEPARATOR > + } > POPUP "&Aide" > { > MENUITEM "À &propos d'Internet Explorer...", ID_BROWSE_ABOUT > -- > 1.7.2 > >

1 0

Re: The WineAPI wiki.
by James Mckenzie Aug. 2, 2010

Aug. 2, 2010

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: >Sent: Aug 2, 2010 4:25 AM >To: wine-devel(a)winehq.org >Subject: Re: The WineAPI wiki. > >On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: >> Max TenEyck Woodbury<max(a)mtew.isa-geek.net> wrote: >> >>> I have started the WineAPI wiki at >>> >>> https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page >> >> You have chosen not very good name. There is no such a thing as Wine API, >> Wine implements Win32 API, and doesn't specify/add anything custom to it. >> The name "WineAPI" implies that Wine defines its own API which is not true, >> and is confusing. >> This should be named, the Windows32/Window64 API as implemented by Wine Documentation site. That is what it is. We have found shortcomings in the MSDN documentation (I'm dealing with this right now in one function call for Richedit.) This should be a collaborative site where Wine developers, Windows on Wine developers and others can place information on what Wine has implemented today, what needs to be implemented (with case code and discoveries) and what Wine cannot implement. >This has been discussed elsewhere on this mailing list. > Agreed. >There is a lot of information specific to Wine, particularly its >internal structure, that is not shared with Microsoft's product. >Further, there is a little confusing and incorrect information in the >Microsoft documentation. Bluntly, the Microsoft documentation is what >they want it to be. We need to document what it really is. > >We have tried to embed API documentation in the source code. That has >not worked as well as it could. Alexandre Julliard has said as much. I >think that having good documentation will help the project. Not having >good documentation can and does hurt Wine in my opinion. I also think >that trying to prevent the creation of that documentation might be >harmful. AJ has stated that documenting the Windows API and internal API calls should NOT be documented just in the source. It bloats the source code terribly and can make code unreadable. I agree that this Wiki should only be used to document the external interfaces to Wine as we implement Windows32/Windows64 API/ABI calls and what we have found in our testing that is different than MSDN. We should NOT duplicate MSDN where is is proper, but rather have a note that states MSDN and other sources have been found to be proper. As to the griping, we need to be public with our progress. This eliminates confusion and also gives new developers a place to start. James McKenzie

3 4

Latest version of ddraw/tests plus fixes
by Oldřich Jedlička Aug. 2, 2010

Aug. 2, 2010

Hi Stefan, Roderick, I've sent my latest version of ddraw/tests plus some fixes right now (it takes some time to get to wine-patches ML), one of them fixes bug #9008. Unfortunately I don't have much spare time (and actually I didn't have it the whole time working on patches), my spare time is almost over now, so I would appreciate some last comments - what to remove (if there is something unacceptable), what to change. But I don't have more time to enhance the backbuffers+3D interaction investigations/tests, sorry. It would be great if you let the fix for bug #9008 go into the wine tree. Thanks! Regards, Oldřich.

1 0

Re: wordpad: Added Hebrew translation.
by Paul Vriens Aug. 2, 2010

Aug. 2, 2010

Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: > Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL > for the dialogs, hope that helps. > > Also found out that menus does not need any special RTL property, they > are self aligned according to the app. What do you mean by that? Running Wordpad in Hebrew still gives me LTR menu styles/justification. The global (per process) RTL settings still need to be implemented for our internal apps. > > Kind regards, > Yaron Shahrabani > > <Hebrew translator> > > > > 0002-wordpad-Added-Hebrew-translation.patch > > > From 8f5dfcb55656e7e4d7943d622234fb37753210f7 Mon Sep 17 00:00:00 2001 > From: Yaron Shahrabani<sh.yaron(a)gmail.com> > Date: Sun, 1 Aug 2010 11:48:23 +0300 > Subject: wordpad: Added Hebrew translation. > > --- > programs/wordpad/He.rc | 282 ++++++++++++++++++++++++++++++++++++++++++ > programs/wordpad/Makefile.in | 1 + > 2 files changed, 283 insertions(+), 0 deletions(-) > create mode 100644 programs/wordpad/He.rc > > diff --git a/programs/wordpad/He.rc b/programs/wordpad/He.rc > new file mode 100644 > index 0000000..091ec98 > --- /dev/null > +++ b/programs/wordpad/He.rc > @@ -0,0 +1,282 @@ > +/* > + * Copyright 2004 by Krzysztof Foltman > + * Hebrew Translation by Yaron Shahrabani<sh.yaron(a)gmail.com>, 2010 Minor, but why did you not use the same format (as we see in most files)? So something like: /* * Hebrew Translation of wordpad * * Copyright 2004 by Krzysztof Foltman * Copyright 2010 Yaron Shahrabani<sh.yaron(a)gmail.com> > +IDD_DATETIME DIALOG 30, 20, 130, 80 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL Eventually we probably have to but I'm not sure what Alexandre thinks about introducing it (now). We probably also have to teach our tools (like the translation site) that detects translation differences/issues to cope with this. > +STRINGTABLE > +BEGIN > + STRING_ALIGN_LEFT, "שמאל" > + STRING_ALIGN_RIGHT, "ימין" > + STRING_ALIGN_CENTER, "מרכז" > +END This piece is already defined starting on line 226 and thus leads to: ../../../wine-git/programs/wordpad/He.rc:279:32: Error: Stringtable ID 1416 already in use -- Cheers, Paul.

3 4

Re: write: Added Hebrew translation
by Paul Vriens Aug. 2, 2010

Aug. 2, 2010

On 08/02/2010 04:57 PM, Yaron Shahrabani wrote: > +++ b/programs/write/He.rc > @@ -0,0 +1,30 @@ > +/* > + * English language support Should be 'Hebrew' of course ;) -- Cheers, Paul.

2 1

Re: [PATCH 1/4] wined3d: separate driver info from GPU info
by Henri Verbeet Aug. 2, 2010

Aug. 2, 2010

On 1 August 2010 05:37, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > struct driver_version_information > { > + WORD vendor; /* reported PCI card vendor ID */ ... > + enum wined3d_display_driver driver; > +}; That doesn't make all that much sense.

2 1

Re: winex11.drv: implement drag and drop from X to OLE (try 3)
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -300,6 +499,66 @@ static void X11DRV_XDND_ResolveProperty(Display *display, Window xwin, Time tm, > wine_tsx11_unlock(); > } > > + /* We get the list of formats in descending order of preference, yet the linked > + * list is a stack so the order is inverted. Reverse the linked list here so > + * that we get the right order. > + */ > + current = XDNDData; You should first convert it to a standard Wine list, then you can use it in either order. > + /* For some strange reason, load-time linking SHELL32.DLL to WINEX11.DRV > + * causes wine to segfault on startup. So rather use run-time linking. > + */ > + shell32 = GetModuleHandleA("SHELL32.DLL"); > + if (shell32 == NULL) > + shell32 = LoadLibraryA("SHELL32.DLL"); A delayed import should work fine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: implement X session management (try 2)
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > +static void SM_Init(void) > +{ > + CreateThread(NULL, 0, manage_session, NULL, 0, NULL); > +} > +#endif /* defined(SONAME_LIBSM) */ You don't want to create a new thread in every process for this. It will cause lots of trouble. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 07/10] explorerframe/nstc: Implement Initialize.
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > + /* Native accepts a NULL prc, so should we. */ > + if(prc) > + SetWindowPos(This->hwnd_main, HWND_TOP, prc->left, prc->top, > + prc->right - prc->left, prc->bottom - prc->top, SWP_SHOWWINDOW); It would be better to create it directly with the correct rectangle. Also SWP_SHOWWINDOW is not useful since the window is created visible. And please don't add comments like "native does this", that should be true of pretty much anything we do. Native behavior should be documented by test cases anyway, not comments. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: Partial implementation of IShellItem::BindToHandler.
by Nikolay Sivov Aug. 2, 2010

Aug. 2, 2010

On 8/2/2010 02:36, David Hedberg wrote: > +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc, IShellFolder **ppsf) > +{ > + IShellFolder *desktop; > + HRESULT ret; > + > + ret = SHGetDesktopFolder(&desktop); > + if (SUCCEEDED(ret)) > + { > + if (_ILIsDesktop(This->pidl)) > + { > + *ppsf = desktop; > + IShellFolder_AddRef(*ppsf); > + } > + else > + { > + ret = IShellFolder_BindToObject(desktop, This->pidl, pbc,&IID_IShellFolder, (void**)ppsf); > + } > + > + IShellFolder_Release(desktop); > + } > + > + return ret; > +} > + > I don't think this explicit check for desktop folder is needed here, as I understand ::BindToObject() it should handle this case internally.

2 4

Re: [PATCH 1/5] include/mswsock: add WS_ prefix if necessary
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > @@ -173,11 +174,28 @@ typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, HANDLE, DWORD, DWORD, LPOVERLA > typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > typedef INT (WINAPI * LPFN_WSARECVMSG)(SOCKET, LPWSAMSG, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > typedef INT (WINAPI * LPFN_WSASENDMSG)(SOCKET, LPWSAMSG, DWORD, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +#else > +typedef BOOL (WINAPI * LPFN_ACCEPTEX)(SOCKET, SOCKET, PVOID, DWORD, DWORD, DWORD, LPDWORD, LPOVERLAPPED); > +typedef BOOL (WINAPI * LPFN_CONNECTEX)(SOCKET, const struct WS_sockaddr *, int, PVOID, DWORD, LPDWORD, LPOVERLAPPED); > +typedef BOOL (WINAPI * LPFN_DISCONNECTEX)(SOCKET, LPOVERLAPPED, DWORD, DWORD); > +typedef VOID (WINAPI * LPFN_GETACCEPTEXSOCKADDRS)(PVOID, DWORD, DWORD, DWORD, struct WS_sockaddr **, LPINT, struct WS_sockaddr **, LPINT); > +typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, HANDLE, DWORD, DWORD, LPOVERLAPPED, LPTRANSMIT_FILE_BUFFERS, DWORD); > +typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > +typedef INT (WINAPI * LPFN_WSARECVMSG)(SOCKET, LPWSAMSG, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +typedef INT (WINAPI * LPFN_WSASENDMSG)(SOCKET, LPWSAMSG, DWORD, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +#endif What you want is the WS() macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] shdocvw: Recurse into directories when adding Favorites
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > @@ -109,10 +109,10 @@ static void add_fav_to_menu(HMENU menu, LPWSTR title, LPCWSTR url) > { > MENUITEMINFOW item; > /* Subtract the number of standard elements in the Favorites menu */ > - INT favcount = GetMenuItemCount(menu) - 2; > + static INT favcount; > LPWSTR urlbuf; The previous version was better, you don't want a static variable for this, you may want to do it multiple times, or the menu may get changed somewhere else. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Send more informative messages to OleInPlaceFrame
by Jacek Caban Aug. 2, 2010

Aug. 2, 2010

On 08/02/10 13:30, Alexander Nicolaysen Sørnes wrote: > These are displayed in Internet Explorer. > > > Alexander N. Sørnes > +LPCWSTR get_statustext(INT id, BOOL has_arg, LPCWSTR arg_in) WHy do you need has_arg argument? Isn't NULL arg_in enough to recognize no argument? +{ + static LPWSTR strings[NUM_STATUS_STRINGS]; + int index = id - IDS_STATUS_DONE; + DWORD maxlen = 255; + DWORD len = maxlen; + LPWSTR* p = &strings[index]; + + if(!*p) + { + if(has_arg) + len *= 3; + + *p = heap_alloc(len * sizeof(WCHAR)); + len = LoadStringW(hInst, id, *p, len); + len++; + + if(!has_arg) + *p = heap_realloc(*p, len * sizeof(WCHAR)); + } + + if(has_arg) + { + LPWSTR p2 = strings[index] + maxlen; + LPCWSTR arg = arg_in; + + if(!arg) + { + const WCHAR empty = 0; + arg = ∅ + ERR("Missing arg for message (id=%d) '%s'\n", id, debugstr_w(strings[index])); + } + snprintfW(p2, (maxlen * 2) - 1, strings[index], arg); + + return p2; + } + + return *p; +} This caching mechanism is broken and not thread safe. + LPCWSTR text = get_statustext(IDS_STATUS_DONE, FALSE, NULL); + IOleInPlaceFrame_SetStatusText(doc_obj->frame, text); The helper function should take care of calling SetStatusText. if(doc->frame) - IOleInPlaceFrame_SetStatusText(doc->frame, NULL /* FIXME */); + { + LPCWSTR text = get_statustext(IDS_STATUS_DOWNLOADINGFROM, TRUE, task->url); + CoTaskMemFree(task->url); + IOleInPlaceFrame_SetStatusText(doc->frame, text); + } You leak task->url here if doc->frame is NULL. Jacek

1 0

Re: [PATCH 4/4] jscript: Use generic property for Error.number.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4153 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] jscript: Fixed test crash on some win9x installations.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4152 Your paranoid android. === WNT4WSSP6 (32 bit jscript) === jscript.c:388: Test failed: CoCreateInstance failed: 80040154 jscript.c:468: Test failed: CoCreateInstance failed: 80040154

1 0

Re: [PATCH 2/4] jscript: Use generic properties for NaN and Infinity implementation.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4151 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: gdi32: Do not crash on an invalid pointer passed to AddFontMemResourceEx.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4149 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: user32: Add a test for GetClassInfo, make it pass under Wine. Take 2.
by testbot＠testbot.winehq.org Aug. 1, 2010

Aug. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4119 Your paranoid android. === WNT4WSSP6 (32 bit class) === class.c:939: Test failed: expected ERROR_NOACCESS, got -559038737

1 0

New winetricks 20100731: new verbs eadm eufonts gfw glut ie8 safari secur32 xlive
by Dan Kegel Aug. 1, 2010

Aug. 1, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: New verbs eadm eufonts gfw (aka xlive) ie8 safari secur32 Turning off MouseWarpOverride should be 'disable' not 'disabled'. (Issue 138) flash, ogg: support silent installs Lots of updates and minor fixes Dan Kegel: New verb glut Mathieu Malaterre: update cmake to 2.8.2 (issue 136)

2 2

New wisotool 20100731: 44 new verbs (aa3, apb, ... masseffect2_demo, ... zen_of_sudoku_demo_steam)
by Dan Kegel Aug. 1, 2010

Aug. 1, 2010

wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except it prompts for your password so it can mount the .iso file, and it prompts you to insert the disk if the .iso file is not found). Wisotool currently supports about 145 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. Thanks to everyone who contributed changes for this release. Not all of these games currently work under wine. Workarounds for specific Wine bugs are applied if available. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100618: Austin English If iso isn't present, offer to make one for the user Generic Steam installer New verbs: aa3 (America's Army 3) apb (All Points Bulletin) arx_fatalis_demo_steam bookworm_adventures_deluxe_demo_steam daytona_usa_evolutions dc2ba (Dora's Carnival 2: Boardwalk Adventure) eets_demo_steam fallout3_goty (Fallout 3: Game of the Year edition) ffxivbench (Final Fantasy XIV benchmark) fifa10 fifa10_demo joint_task_force_demo_steam longest_journey_demo_steam lost_planet_dx10_demo_steam lost_planet_dx9_demo_steam metro2033 multiwinia_demo_steam napoleon_total_war_demo_steam painkiller_demo_steam sega_rally_2 singularity ssdd2 (SpongeBob SquarePants Diner Dash 2 Demo) starcraft2 total_war_and_empire_demo_steam twfc (Transformers: War for Cybertron) wowtrial (World of Warcraft trial) zen_of_sudoku_demo_steam Dan Kegel: Allow specifying a .verb file on commandline New verbs: algodoo_demo deadspace lotsn (Monkey Island: Launch of the Screaming Narwhal) masseffect2_demo secondlife_beta Eleazar Galano: New verbs: cnc3_demo (Command and Conquer 3 Demo) cnc4 fifaonline3_beta hphbp, hphbp_demo (Harry Potter Half Blood Prince) lhp (Lego Harry Potter) moh_beta (Medal of Honor) nfsshift nfsshift_demo oblivion sf4bench Jon Angelo: New verb hod3_jp_demo Thai Nguyen: New verb smbx

1 0