August 2010 - Wine-Devel - list.winehq.org

[PATCH 5/6] d3dx9_36/tests: Added trigonometric functions test to HLSL test suite
by Joris Huizer Aug. 5, 2010

Aug. 5, 2010

Hello Travis Athougies, In this patch, you have this code: + void *ret = NULL; //... + ret = HeapAlloc(GetProcessHeap(), 0, 4 * samples); + for(i = 0;i < 32;i++) { //... + memcpy((void*) (((DWORD) ret) + (4 * i)), lr.pBits, 4); //... + } I'm not sure, but I think this will cause 64-bit issues (truncating to a 32-bit value?) Even if it doesn't, it seems simpler (more readable) to use a char pointer instead of a void pointer, like + char *ret; //... + ret = HeapAlloc(GetProcessHeap(), 0, 4 * samples); //... + memcpy(ret + (4 * i), lr.pBits, 4); HTH, regards, Joris

2 1

GDB debugging on ARM
by André Hentschel Aug. 4, 2010

Aug. 4, 2010

Hi, what is the best/easiest/fastest way to hack Wine so it does not start winedbg and i can debug it with gdb? my problem is that my WineARM works so far that it tries to run winedbg and uses its own handlers. but i want that not to happen of course it crashes somewhere and then tries to start winedbg... but winedbg is not really implemented yet on arm and its not yet time for it. i just want to debug on assembler level with gdb... "winedbg --gdb" is also not what i want. So my understanding is that Wine somewhere register its exception handlers, but i cant find that code to disable it. Anyone? -- Best Regards, André Hentschel

2 1

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)
by Stefan Dösinger Aug. 4, 2010

Aug. 4, 2010

Am 03.08.2010 um 21:26 schrieb Oldřich Jedlička: > DirectX 1 interface allowed creation of explicit back buffers, so move the > restrictive checks to DirectX 2+ implementations. Don't permit creating of > primary surface back buffer. The patch(as well as 9 and 10) look OK to me. Patch 6 is OK too. Patch 8 is missing a call to wined3d to tell it about the new backbuffer. (Apps will likely still work with the GDI renderer, but not the opengl ddraw renderer)

2 1

Vacation
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Folks, I'll be on vacation until the end of next week, so there won't be any commits for a while. That shouldn't prevent anybody from making progress, as we have seen during the recent code freeze ;-) The next release will be on Friday 20th. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Oldřich Jedlička <oldium.pro(a)seznam.cz> writes: > + __TRY > + { > + hr = IDirectDraw_CreateSurface(lpDD, NULL, &surf, NULL); > + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface didn't return 0x%08x, but 0x%08x\n", > + DDERR_INVALIDPARAMS, hr); > + } > + __EXCEPT_PAGE_FAULT > + { > + todo_wine ok(FALSE, "IDirectDraw_CreateSurface dereferenced NULL pointer\n"); > + } > + __ENDTRY You can't use Wine exception macros in tests. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: shdocvw: Add the Polish translation
by Jacek Caban Aug. 4, 2010

Aug. 4, 2010

On 8/4/10 5:45 PM, Łukasz Wojniłowicz wrote: > From: Lukasz Wojnilowicz<Wojnilowicz(a)localhost.localdomain> > > --- > dlls/shdocvw/Makefile.in | 1 + > dlls/shdocvw/Pl.rc | 57 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+), 0 deletions(-) > create mode 100644 dlls/shdocvw/Pl.rc > > diff --git a/dlls/shdocvw/Makefile.in b/dlls/shdocvw/Makefile.in > index 9e2d8e1..f43e02e 100644 > --- a/dlls/shdocvw/Makefile.in > +++ b/dlls/shdocvw/Makefile.in > @@ -35,6 +35,7 @@ RC_SRCS = \ > Ko.rc \ > Lt.rc \ > Nl.rc \ > + Pl.rc \ > Ro.rc \ > Sv.rc \ > Uk.rc \ > diff --git a/dlls/shdocvw/Pl.rc b/dlls/shdocvw/Pl.rc > new file mode 100644 > index 0000000..1dd735b > --- /dev/null > +++ b/dlls/shdocvw/Pl.rc > @@ -0,0 +1,57 @@ > +/* > + * Copyright 2010 �ukasz Wojni�owicz > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "resource.h" > + > +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > + > +IDD_BROWSE_OPEN DIALOG 10, 10, 200, 70 > +STYLE DS_MODALFRAME | WS_CAPTION > +CAPTION "Otw�rz URL" > +FONT 8, "MS Shell Dlg" > +{ > + LTEXT "Podaj adres URL, kt�ry chcesz otworzy� w Internet Explorer",-1,25, 5, 150,15 It should be "(...) Internet Explorerze". > + LTEXT "Otw�rz:", -1, 2, 32, 20, 15 > + EDITTEXT IDC_BROWSE_OPEN_URL, 25, 30, 160, 13 > + DEFPUSHBUTTON "&OK", IDOK, 25, 50, 50, 15 > + PUSHBUTTON "&Anuluj", IDCANCEL, 85, 50, 50, 15 > +} > + > +IDR_BROWSE_MAIN_MENU MENU > +{ > + POPUP "&Plik" > + { > + POPUP "&Nowe" > + { > + MENUITEM "&Okno" ID_BROWSE_NEW_WINDOW > + } > + MENUITEM "&Otw�rz...", ID_BROWSE_OPEN > + MENUITEM "&Zapisz", ID_BROWSE_SAVE > + MENUITEM "Zapisz&jako...", ID_BROWSE_SAVE_AS > + MENUITEM SEPARATOR > + MENUITEM "Wydrukuj&format...", ID_BROWSE_PRINT_FORMAT It should be "Format wydruku". > + MENUITEM "&Drukuj...", ID_BROWSE_PRINT > + MENUITEM "Wydrukuj&podgl�d...", ID_BROWSE_PRINT_PREVIEW It should be "Podglad wydruku". Please be more careful about translations. ID_BROWSE_PRINT_FORMAT and ID_BROWSE_PRINT_PREVIEW are fairly obvious mistakes. Jacek

1 0

Re: shdocvw: Add the Polish translation
by Paul Vriens Aug. 4, 2010

Aug. 4, 2010

Hi Łukasz, On 08/04/2010 05:45 PM, Łukasz Wojniłowicz wrote: > +CAPTION "Otw�rz URL" This file needs the UTF-8 pragma. -- Cheers, Paul.

1 0

RE: WineTestBot and D3D
by Greg Geldorp Aug. 4, 2010

Aug. 4, 2010

> From: Stefan Doesinger > > Greg's testbot looks pretty useful by now, but for me it has one major > problem: It cannot run D3D tests because it is stuck in a virtual machine. > > I understand that the core of Winetestbot will stay in VMs, but is there a > way we can extend it with extra machines? I have a few spare boxes with > different GPUs here that could be used to run the tests. What I need is > basically: > > *) Some magic patchwatcher software I can install on these boxes > *) A Server this software talks to to get patch jobs and report the results > back. > *) Depending on the load, configure my machines to run d3d-related tests only > and leave others to the VMs. > > Now I guess it is important that if one of those extra test boxes dies(e.g. I > turn off my computers when I am away for a while) that this doesn't break the > testbot as a whole because it is waiting for test results. For starters I think > security is not that much of an issue, as long as I can firewall the machine > (via my router) and prevent it from connecting to anything but the testbot > master. > > Does the Testbot infrastructure allow this? Currently, no, it doesn't. But it certainly seems something that can be added. I'll investigate a bit what it will take. Ge.

1 0

Re: [PATCH 1/2] ntdll: Implement RtlIpv4AddressToString / RtlIpv4AddressToStringEx
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -37,8 +37,12 @@ > #include "winternl.h" > #include "wine/debug.h" > #include "wine/exception.h" > +#include "wine/unicode.h" > #include "ntdll_misc.h" > > +#include "winsock2.h" You don't want to include winsock2.h here. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineTestBot and D3D
by Stefan Dösinger Aug. 4, 2010

Aug. 4, 2010

Hi, Greg's testbot looks pretty useful by now, but for me it has one major problem: It cannot run D3D tests because it is stuck in a virtual machine. I understand that the core of Winetestbot will stay in VMs, but is there a way we can extend it with extra machines? I have a few spare boxes with different GPUs here that could be used to run the tests. What I need is basically: *) Some magic patchwatcher software I can install on these boxes *) A Server this software talks to to get patch jobs and report the results back. *) Depending on the load, configure my machines to run d3d-related tests only and leave others to the VMs. Now I guess it is important that if one of those extra test boxes dies(e.g. I turn off my computers when I am away for a while) that this doesn't break the testbot as a whole because it is waiting for test results. For starters I think security is not that much of an issue, as long as I can firewall the machine(via my router) and prevent it from connecting to anything but the testbot master. Does the Testbot infrastructure allow this? Cheers, Stefan

1 0

Re: [PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify
by Alexandre Julliard Aug. 4, 2010

Aug. 4, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This fixes bug 18606. > > It's possible to refer to the same file in two different ways with PIDLs > in Wine. This can cause notifications via SHChangeNotify to fail to > trigger. To ensure an apples-to-apples comparison, we convert the > incoming PIDLs and the filters to UNIX paths and compare those if the > PIDLs fail to match. You should never compare Unix paths. If you want to compare file identity you should use stat and compare device+inode. But it's not clear to me that this is the right thing to do here, what is the exact case that is failing? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 3/4] jscript: Fixed Error.toString implementation for non-Error this.
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4288 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: user32: Protect from setting as a window owner one of window's succesors.
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4287 Your paranoid android. === W98SE (32 bit win) === win.c:110: Test failed: Wrong result for GWL_HWNDPARENT 0000076C expected 00000000 win.c:114: Test failed: Wrong result for GW_OWNER 0000076C expected 00000000 win.c:388: Test failed: GWL_HWNDPARENT return value 0000076C expected 0 === W7PRO (32 bit win) === win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01AE fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001AE fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:2668: Test failed: GetActiveWindow() = 00000000 win.c:2668: Test failed: GetFocus() = 00000000 win.c:2694: Test failed: GetActiveWindow() = 00000000 win.c:2694: Test failed: GetFocus() = 00000000 win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A0 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A2 fg 00030050 in hook HCBT_SETFOCUS win.c:2753: Test failed: GetActiveWindow() = 00000000 win.c:2753: Test failed: GetFocus() = 00000000 win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000C016C fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002E01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002F01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A4 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000801A4 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000901A4 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 001801A0 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A8 fg 00030050 in hook HCBT_SETFOCUS win.c:827: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000C016C fg 00030050 in hook HCBT_SETFOCUS

3 2

Re: [PATCH] kernel32/tests: Try harder to crash in the debugger test.
by Octavian Voicu Aug. 4, 2010

Aug. 4, 2010

Please ignore this patch. It seems that it does crash all the time, just that sometimes the debugger won't kick in on win64. There is a bug but it's somewhere else. Octavian

1 0

shdocvw: Update Italian translation
by Luca Bennati Aug. 4, 2010

Aug. 4, 2010

2 1

Re: d3dx9_36/tests: Added HLSL test suite. (try 3)
by Henri Verbeet Aug. 4, 2010

Aug. 4, 2010

On 3 August 2010 21:07, Travis Athougies <iammisc(a)gmail.com> wrote: > dlls/d3dx9_36/tests/Makefile.in | 1 + > dlls/d3dx9_36/tests/hlsl.c | 666 +++++++++++++++++++++++++++++++++++++++ > include/d3dx9shader.h | 11 + > 3 files changed, 678 insertions(+), 0 deletions(-) > create mode 100644 dlls/d3dx9_36/tests/hlsl.c > Needs splitting.

1 0

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)
by Stefan Dösinger Aug. 4, 2010

Aug. 4, 2010

Am 03.08.2010 um 21:26 schrieb Oldřich Jedlička: > + whiteBrush = CreateSolidBrush(white); > + ok(whiteBrush != NULL, "CreateBrush returned: %p\n", whiteBrush); > + redBrush = CreateSolidBrush(red); > + ok(redBrush != NULL, "CreateBrush returned: %p\n", redBrush); > + > + hr = IDirectDrawSurface_GetDC(Backbuffer, &dc); > + ok(hr == DD_OK, "IDirectDrawSurface_GetDC returned: %x\n", hr); > + ret = FillRect(dc, &rect, redBrush); > + ok(ret != 0, "FillRect failed\n"); > + hr = IDirectDrawSurface_ReleaseDC(Backbuffer, dc); > + ok(hr == DD_OK, "IDirectDrawSurface_ReleaseDC returned: %x\n", hr); It would be more directdraw-ish to use a colorfill blit instead of getDC + gdi drawing. Tests 1-3 and 5 look OK though.

1 0

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4262 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4261 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4260 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: tools/winebuild: add missing separators
by Andrew Nguyen Aug. 4, 2010

Aug. 4, 2010

On Tue, Aug 3, 2010 at 9:57 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > > The colons aren't decorative separators, but rather determine which short arguments expect a parameter as per the requirements of getopt/getopt_long. With your patch applied: $ tools/winebuild/winebuild -h tools/winebuild/winebuild: option requires an argument -- 'h'

1 0

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4251 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1497: Test failed: Got color 000a246a, expected 000000ff or near visual.c:1503: Test failed: Got color 006b8bbd, expected 000000ff or near visual.c:1509: Test failed: Got color 00ffffff, expected 00000080 or near visual.c:1515: Test failed: Got color 00ffffff, expected 00000080 or near

1 0

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4250 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH] kernel32/tests: Try harder to crash in the debugger test.
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4248 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:309: Test failed: Timed out waiting for the child to crash debugger.c:323: Test failed: wrong exit code : 00000103 debugger.c:334: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtD67.tmp': read=0 debugger.c:339: Test failed: wrong debugger argument count: -32297584 debugger.c:340: Test failed: the child and debugged pids don't match: 2284 != 2046 debugger.c:309: Test failed: Timed out waiting for the child to crash debugger.c:316: Test failed: wrong exit code : 00000103 debugger.c:334: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtE239.tmp': read=0 debugger.c:339: Test failed: wrong debugger argument count: -32297584 debugger.c:340: Test failed: the child and debugged pids don't match: 2384 != 2046 Timeout

1 0

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4246 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0