August 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 3)
by testbot＠testbot.winehq.org Aug. 4, 2010

Aug. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4245 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: regedit: Added Hebrew translation
by Alexandre Julliard Aug. 3, 2010

Aug. 3, 2010

Yaron Shahrabani <sh.yaron(a)gmail.com> writes: > Hope everything is cool this time :) > +IDD_EXPORT_TEMPLATE DIALOG 50, 50, 278, 54 > +STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | > + WS_BORDER > +WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" That's not valid syntax. Please try to compile at least the files you are changing, if you can't do a full build. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 2/4] include/shlobj.h: SHILCreateFromPath takes both CSTR and WSTR
by Alexandre Julliard Aug. 3, 2010

Aug. 3, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This is different from the latest PSDK, but Wine's SHILCreateFromPath > accepts both types, so we shouldn't make compiler warnings about it. If there are warnings with the Windows headers there should be warnings with the Wine ones too. -- Alexandre Julliard julliard(a)winehq.org

1 0

wiki slightly broken still?
by Dan Kegel Aug. 3, 2010

Aug. 3, 2010

Creating new wiki pages seems broken today...

9 15

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)
by Vitaliy Margolen Aug. 3, 2010

Aug. 3, 2010

On 08/02/2010 05:48 PM, Jeff Cook wrote: > Moved check to conform with C90. > > + if (mastelem) { > + /* Master control */ ... > + } else { Please follow file's format. Vitaliy

1 0

Re: [PATCH 6/6] winealsa.drv: Open default device only once per card and don't discard non-defaults. (resend)
by Vitaliy Margolen Aug. 3, 2010

Aug. 3, 2010

On 08/02/2010 05:50 PM, Jeff Cook wrote: > - > + You adding trailing spaces here. > + } else { > + default_used = 1; > } > Please follow files' format - curly braces go on separate line. Also you don't need braces for one line "else". Vitaliy.

1 0

Re: [PATCH 3/6] winealsa.drv: Always scan devices, even if a default device exists. (resend)
by Vitaliy Margolen Aug. 3, 2010

Aug. 3, 2010

On 08/02/2010 05:49 PM, Jeff Cook wrote: > --- > dlls/winealsa.drv/waveinit.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > - int scan_devices = (fixedpcmdev == -1); > + /* we always want to scan_devices; otherwise, if a default is set and the > + appropriate registry keys are not set, only the default device will be seen > + by wine. This is undesirable, for instance, if you have separate cards for > + capture and playback, like a USB microphone for capture */ > + int scan_devices = 1; Please make it possible to force old behavior via registry. This was done for a reason - some devices were crashing during initialization, some were taking way too long to initialize. Vitaliy

1 0

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc
by Henri Verbeet Aug. 3, 2010

Aug. 3, 2010

On 31 July 2010 08:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This workaround isn't ideal, Yeah, I don't think this is much of an improvement.

4 4

Re: [PATCH 2/5] explorerframe/nstc: Create the treeview on initialization. (try 2)
by Alexandre Julliard Aug. 3, 2010

Aug. 3, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > +static LRESULT resize_namespacetree(NSTC2Impl *This) > +{ > + RECT rc; > + TRACE("%p\n", This); > + > + GetClientRect(This->hwnd_main, &rc); > + SetWindowPos(This->hwnd_tv, HWND_TOP, rc.left, rc.top, > + rc.right, rc.bottom, SWP_SHOWWINDOW); Again, that's not the correct usage of SetWindowPos. You don't want to show or activate it. What you probably want is MoveWindow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: GetVolumeInformationA: please test this on MS-Windows
by Andrew Eikum Aug. 3, 2010

Aug. 3, 2010

On 07/29/2010 03:43 AM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Andrew, > >>Run on a Win98SE VM. The E drive is a CDROM drive. > Thank you very much for the result. I added the broken(GetLastError()) for Win9x > based on your data. > > Now is your chance to repeat the test with > https://testbot.winehq.org/JobDetails.pl?Key=4014 > (either as .patch file or the binary from testbot). > This is valuable because testbot skips most new tests, lacking another drive, > giving no proof that the fixed patch indeed works without errors on win9x. > If it fails, please report to wine-devel as I already submitted the new patch. Hi Jörg, No failures with the testbot executable. Run under the same Win98SE VM, again from the E: drive. Andrew

3 7

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4179 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF

2 1

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4188 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4187 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4186 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:3027: Test failed: got R FF G 00 B 00, expected R FF G FF B FF === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 2/5] ws2_32/tests: test ConnectEx
by Mike Kaplinskiy Aug. 3, 2010

Aug. 3, 2010

On Mon, Aug 2, 2010 at 11:50 PM, Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> wrote: > --- > dlls/ws2_32/tests/sock.c | 227 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 227 insertions(+), 0 deletions(-) > Shoot, any chance you can just take #1 and take 2-5 from the first batch? That's an outdated not working version of the patches. Otherwise I'll resend tomorrow. Sorry, Mike.

1 0

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4178 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4175 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 2)
by testbot＠testbot.winehq.org Aug. 3, 2010

Aug. 3, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4174 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: shdocvw: Update French translation
by Frédéric Delanoy Aug. 3, 2010

Aug. 3, 2010

Please discard; has been mangled by misconfigured git 2010/8/2 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shdocvw/Fr.rc | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/shdocvw/Fr.rc b/dlls/shdocvw/Fr.rc > index 94b4a7e..b7326bb 100644 > --- a/dlls/shdocvw/Fr.rc > +++ b/dlls/shdocvw/Fr.rc > @@ -55,6 +55,11 @@ IDR_BROWSE_MAIN_MENU MENU > MENUITEM SEPARATOR > MENUITEM "&Propriétés...", ID_BROWSE_PROPERTIES > } > + POPUP "&Favoris" > + { > + MENUITEM "&Ajouter aux favoris..." ID_BROWSE_ADDFAV > + MENUITEM SEPARATOR > + } > POPUP "&Aide" > { > MENUITEM "À &propos d'Internet Explorer...", ID_BROWSE_ABOUT > -- > 1.7.2 > >

1 0

Re: The WineAPI wiki.
by James Mckenzie Aug. 2, 2010

Aug. 2, 2010

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: >Sent: Aug 2, 2010 4:25 AM >To: wine-devel(a)winehq.org >Subject: Re: The WineAPI wiki. > >On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: >> Max TenEyck Woodbury<max(a)mtew.isa-geek.net> wrote: >> >>> I have started the WineAPI wiki at >>> >>> https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page >> >> You have chosen not very good name. There is no such a thing as Wine API, >> Wine implements Win32 API, and doesn't specify/add anything custom to it. >> The name "WineAPI" implies that Wine defines its own API which is not true, >> and is confusing. >> This should be named, the Windows32/Window64 API as implemented by Wine Documentation site. That is what it is. We have found shortcomings in the MSDN documentation (I'm dealing with this right now in one function call for Richedit.) This should be a collaborative site where Wine developers, Windows on Wine developers and others can place information on what Wine has implemented today, what needs to be implemented (with case code and discoveries) and what Wine cannot implement. >This has been discussed elsewhere on this mailing list. > Agreed. >There is a lot of information specific to Wine, particularly its >internal structure, that is not shared with Microsoft's product. >Further, there is a little confusing and incorrect information in the >Microsoft documentation. Bluntly, the Microsoft documentation is what >they want it to be. We need to document what it really is. > >We have tried to embed API documentation in the source code. That has >not worked as well as it could. Alexandre Julliard has said as much. I >think that having good documentation will help the project. Not having >good documentation can and does hurt Wine in my opinion. I also think >that trying to prevent the creation of that documentation might be >harmful. AJ has stated that documenting the Windows API and internal API calls should NOT be documented just in the source. It bloats the source code terribly and can make code unreadable. I agree that this Wiki should only be used to document the external interfaces to Wine as we implement Windows32/Windows64 API/ABI calls and what we have found in our testing that is different than MSDN. We should NOT duplicate MSDN where is is proper, but rather have a note that states MSDN and other sources have been found to be proper. As to the griping, we need to be public with our progress. This eliminates confusion and also gives new developers a place to start. James McKenzie

3 4

Latest version of ddraw/tests plus fixes
by Oldřich Jedlička Aug. 2, 2010

Aug. 2, 2010

Hi Stefan, Roderick, I've sent my latest version of ddraw/tests plus some fixes right now (it takes some time to get to wine-patches ML), one of them fixes bug #9008. Unfortunately I don't have much spare time (and actually I didn't have it the whole time working on patches), my spare time is almost over now, so I would appreciate some last comments - what to remove (if there is something unacceptable), what to change. But I don't have more time to enhance the backbuffers+3D interaction investigations/tests, sorry. It would be great if you let the fix for bug #9008 go into the wine tree. Thanks! Regards, Oldřich.

1 0

Re: wordpad: Added Hebrew translation.
by Paul Vriens Aug. 2, 2010

Aug. 2, 2010

Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: > Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL > for the dialogs, hope that helps. > > Also found out that menus does not need any special RTL property, they > are self aligned according to the app. What do you mean by that? Running Wordpad in Hebrew still gives me LTR menu styles/justification. The global (per process) RTL settings still need to be implemented for our internal apps. > > Kind regards, > Yaron Shahrabani > > <Hebrew translator> > > > > 0002-wordpad-Added-Hebrew-translation.patch > > > From 8f5dfcb55656e7e4d7943d622234fb37753210f7 Mon Sep 17 00:00:00 2001 > From: Yaron Shahrabani<sh.yaron(a)gmail.com> > Date: Sun, 1 Aug 2010 11:48:23 +0300 > Subject: wordpad: Added Hebrew translation. > > --- > programs/wordpad/He.rc | 282 ++++++++++++++++++++++++++++++++++++++++++ > programs/wordpad/Makefile.in | 1 + > 2 files changed, 283 insertions(+), 0 deletions(-) > create mode 100644 programs/wordpad/He.rc > > diff --git a/programs/wordpad/He.rc b/programs/wordpad/He.rc > new file mode 100644 > index 0000000..091ec98 > --- /dev/null > +++ b/programs/wordpad/He.rc > @@ -0,0 +1,282 @@ > +/* > + * Copyright 2004 by Krzysztof Foltman > + * Hebrew Translation by Yaron Shahrabani<sh.yaron(a)gmail.com>, 2010 Minor, but why did you not use the same format (as we see in most files)? So something like: /* * Hebrew Translation of wordpad * * Copyright 2004 by Krzysztof Foltman * Copyright 2010 Yaron Shahrabani<sh.yaron(a)gmail.com> > +IDD_DATETIME DIALOG 30, 20, 130, 80 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL Eventually we probably have to but I'm not sure what Alexandre thinks about introducing it (now). We probably also have to teach our tools (like the translation site) that detects translation differences/issues to cope with this. > +STRINGTABLE > +BEGIN > + STRING_ALIGN_LEFT, "שמאל" > + STRING_ALIGN_RIGHT, "ימין" > + STRING_ALIGN_CENTER, "מרכז" > +END This piece is already defined starting on line 226 and thus leads to: ../../../wine-git/programs/wordpad/He.rc:279:32: Error: Stringtable ID 1416 already in use -- Cheers, Paul.

3 4

Re: write: Added Hebrew translation
by Paul Vriens Aug. 2, 2010

Aug. 2, 2010

On 08/02/2010 04:57 PM, Yaron Shahrabani wrote: > +++ b/programs/write/He.rc > @@ -0,0 +1,30 @@ > +/* > + * English language support Should be 'Hebrew' of course ;) -- Cheers, Paul.

2 1

Re: [PATCH 1/4] wined3d: separate driver info from GPU info
by Henri Verbeet Aug. 2, 2010

Aug. 2, 2010

On 1 August 2010 05:37, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > struct driver_version_information > { > + WORD vendor; /* reported PCI card vendor ID */ ... > + enum wined3d_display_driver driver; > +}; That doesn't make all that much sense.

2 1

Re: winex11.drv: implement drag and drop from X to OLE (try 3)
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -300,6 +499,66 @@ static void X11DRV_XDND_ResolveProperty(Display *display, Window xwin, Time tm, > wine_tsx11_unlock(); > } > > + /* We get the list of formats in descending order of preference, yet the linked > + * list is a stack so the order is inverted. Reverse the linked list here so > + * that we get the right order. > + */ > + current = XDNDData; You should first convert it to a standard Wine list, then you can use it in either order. > + /* For some strange reason, load-time linking SHELL32.DLL to WINEX11.DRV > + * causes wine to segfault on startup. So rather use run-time linking. > + */ > + shell32 = GetModuleHandleA("SHELL32.DLL"); > + if (shell32 == NULL) > + shell32 = LoadLibraryA("SHELL32.DLL"); A delayed import should work fine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: implement X session management (try 2)
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > +static void SM_Init(void) > +{ > + CreateThread(NULL, 0, manage_session, NULL, 0, NULL); > +} > +#endif /* defined(SONAME_LIBSM) */ You don't want to create a new thread in every process for this. It will cause lots of trouble. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 07/10] explorerframe/nstc: Implement Initialize.
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > + /* Native accepts a NULL prc, so should we. */ > + if(prc) > + SetWindowPos(This->hwnd_main, HWND_TOP, prc->left, prc->top, > + prc->right - prc->left, prc->bottom - prc->top, SWP_SHOWWINDOW); It would be better to create it directly with the correct rectangle. Also SWP_SHOWWINDOW is not useful since the window is created visible. And please don't add comments like "native does this", that should be true of pretty much anything we do. Native behavior should be documented by test cases anyway, not comments. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: Partial implementation of IShellItem::BindToHandler.
by Nikolay Sivov Aug. 2, 2010

Aug. 2, 2010

On 8/2/2010 02:36, David Hedberg wrote: > +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc, IShellFolder **ppsf) > +{ > + IShellFolder *desktop; > + HRESULT ret; > + > + ret = SHGetDesktopFolder(&desktop); > + if (SUCCEEDED(ret)) > + { > + if (_ILIsDesktop(This->pidl)) > + { > + *ppsf = desktop; > + IShellFolder_AddRef(*ppsf); > + } > + else > + { > + ret = IShellFolder_BindToObject(desktop, This->pidl, pbc,&IID_IShellFolder, (void**)ppsf); > + } > + > + IShellFolder_Release(desktop); > + } > + > + return ret; > +} > + > I don't think this explicit check for desktop folder is needed here, as I understand ::BindToObject() it should handle this case internally.

2 4

Re: [PATCH 1/5] include/mswsock: add WS_ prefix if necessary
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > @@ -173,11 +174,28 @@ typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, HANDLE, DWORD, DWORD, LPOVERLA > typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > typedef INT (WINAPI * LPFN_WSARECVMSG)(SOCKET, LPWSAMSG, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > typedef INT (WINAPI * LPFN_WSASENDMSG)(SOCKET, LPWSAMSG, DWORD, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +#else > +typedef BOOL (WINAPI * LPFN_ACCEPTEX)(SOCKET, SOCKET, PVOID, DWORD, DWORD, DWORD, LPDWORD, LPOVERLAPPED); > +typedef BOOL (WINAPI * LPFN_CONNECTEX)(SOCKET, const struct WS_sockaddr *, int, PVOID, DWORD, LPDWORD, LPOVERLAPPED); > +typedef BOOL (WINAPI * LPFN_DISCONNECTEX)(SOCKET, LPOVERLAPPED, DWORD, DWORD); > +typedef VOID (WINAPI * LPFN_GETACCEPTEXSOCKADDRS)(PVOID, DWORD, DWORD, DWORD, struct WS_sockaddr **, LPINT, struct WS_sockaddr **, LPINT); > +typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, HANDLE, DWORD, DWORD, LPOVERLAPPED, LPTRANSMIT_FILE_BUFFERS, DWORD); > +typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > +typedef INT (WINAPI * LPFN_WSARECVMSG)(SOCKET, LPWSAMSG, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +typedef INT (WINAPI * LPFN_WSASENDMSG)(SOCKET, LPWSAMSG, DWORD, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +#endif What you want is the WS() macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] shdocvw: Recurse into directories when adding Favorites
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > @@ -109,10 +109,10 @@ static void add_fav_to_menu(HMENU menu, LPWSTR title, LPCWSTR url) > { > MENUITEMINFOW item; > /* Subtract the number of standard elements in the Favorites menu */ > - INT favcount = GetMenuItemCount(menu) - 2; > + static INT favcount; > LPWSTR urlbuf; The previous version was better, you don't want a static variable for this, you may want to do it multiple times, or the menu may get changed somewhere else. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Send more informative messages to OleInPlaceFrame
by Jacek Caban Aug. 2, 2010

Aug. 2, 2010

On 08/02/10 13:30, Alexander Nicolaysen Sørnes wrote: > These are displayed in Internet Explorer. > > > Alexander N. Sørnes > +LPCWSTR get_statustext(INT id, BOOL has_arg, LPCWSTR arg_in) WHy do you need has_arg argument? Isn't NULL arg_in enough to recognize no argument? +{ + static LPWSTR strings[NUM_STATUS_STRINGS]; + int index = id - IDS_STATUS_DONE; + DWORD maxlen = 255; + DWORD len = maxlen; + LPWSTR* p = &strings[index]; + + if(!*p) + { + if(has_arg) + len *= 3; + + *p = heap_alloc(len * sizeof(WCHAR)); + len = LoadStringW(hInst, id, *p, len); + len++; + + if(!has_arg) + *p = heap_realloc(*p, len * sizeof(WCHAR)); + } + + if(has_arg) + { + LPWSTR p2 = strings[index] + maxlen; + LPCWSTR arg = arg_in; + + if(!arg) + { + const WCHAR empty = 0; + arg = ∅ + ERR("Missing arg for message (id=%d) '%s'\n", id, debugstr_w(strings[index])); + } + snprintfW(p2, (maxlen * 2) - 1, strings[index], arg); + + return p2; + } + + return *p; +} This caching mechanism is broken and not thread safe. + LPCWSTR text = get_statustext(IDS_STATUS_DONE, FALSE, NULL); + IOleInPlaceFrame_SetStatusText(doc_obj->frame, text); The helper function should take care of calling SetStatusText. if(doc->frame) - IOleInPlaceFrame_SetStatusText(doc->frame, NULL /* FIXME */); + { + LPCWSTR text = get_statustext(IDS_STATUS_DOWNLOADINGFROM, TRUE, task->url); + CoTaskMemFree(task->url); + IOleInPlaceFrame_SetStatusText(doc->frame, text); + } You leak task->url here if doc->frame is NULL. Jacek

1 0

Re: [PATCH 4/4] jscript: Use generic property for Error.number.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4153 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] jscript: Fixed test crash on some win9x installations.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4152 Your paranoid android. === WNT4WSSP6 (32 bit jscript) === jscript.c:388: Test failed: CoCreateInstance failed: 80040154 jscript.c:468: Test failed: CoCreateInstance failed: 80040154

1 0

Re: [PATCH 2/4] jscript: Use generic properties for NaN and Infinity implementation.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4151 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: gdi32: Do not crash on an invalid pointer passed to AddFontMemResourceEx.
by testbot＠testbot.winehq.org Aug. 2, 2010

Aug. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4149 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: user32: Add a test for GetClassInfo, make it pass under Wine. Take 2.
by testbot＠testbot.winehq.org Aug. 1, 2010

Aug. 1, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4119 Your paranoid android. === WNT4WSSP6 (32 bit class) === class.c:939: Test failed: expected ERROR_NOACCESS, got -559038737

1 0

New winetricks 20100731: new verbs eadm eufonts gfw glut ie8 safari secur32 xlive
by Dan Kegel Aug. 1, 2010

Aug. 1, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: New verbs eadm eufonts gfw (aka xlive) ie8 safari secur32 Turning off MouseWarpOverride should be 'disable' not 'disabled'. (Issue 138) flash, ogg: support silent installs Lots of updates and minor fixes Dan Kegel: New verb glut Mathieu Malaterre: update cmake to 2.8.2 (issue 136)

2 2

New wisotool 20100731: 44 new verbs (aa3, apb, ... masseffect2_demo, ... zen_of_sudoku_demo_steam)
by Dan Kegel Aug. 1, 2010

Aug. 1, 2010

wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except it prompts for your password so it can mount the .iso file, and it prompts you to insert the disk if the .iso file is not found). Wisotool currently supports about 145 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. Thanks to everyone who contributed changes for this release. Not all of these games currently work under wine. Workarounds for specific Wine bugs are applied if available. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100618: Austin English If iso isn't present, offer to make one for the user Generic Steam installer New verbs: aa3 (America's Army 3) apb (All Points Bulletin) arx_fatalis_demo_steam bookworm_adventures_deluxe_demo_steam daytona_usa_evolutions dc2ba (Dora's Carnival 2: Boardwalk Adventure) eets_demo_steam fallout3_goty (Fallout 3: Game of the Year edition) ffxivbench (Final Fantasy XIV benchmark) fifa10 fifa10_demo joint_task_force_demo_steam longest_journey_demo_steam lost_planet_dx10_demo_steam lost_planet_dx9_demo_steam metro2033 multiwinia_demo_steam napoleon_total_war_demo_steam painkiller_demo_steam sega_rally_2 singularity ssdd2 (SpongeBob SquarePants Diner Dash 2 Demo) starcraft2 total_war_and_empire_demo_steam twfc (Transformers: War for Cybertron) wowtrial (World of Warcraft trial) zen_of_sudoku_demo_steam Dan Kegel: Allow specifying a .verb file on commandline New verbs: algodoo_demo deadspace lotsn (Monkey Island: Launch of the Screaming Narwhal) masseffect2_demo secondlife_beta Eleazar Galano: New verbs: cnc3_demo (Command and Conquer 3 Demo) cnc4 fifaonline3_beta hphbp, hphbp_demo (Harry Potter Half Blood Prince) lhp (Lego Harry Potter) moh_beta (Medal of Honor) nfsshift nfsshift_demo oblivion sf4bench Jon Angelo: New verb hod3_jp_demo Thai Nguyen: New verb smbx

1 0