August 2010 - Wine-Devel - list.winehq.org

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized
by testbot＠testbot.winehq.org Aug. 24, 2010

Aug. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4710 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/5] server: move is_removeable to fd_ops
by Mike Kaplinskiy Aug. 24, 2010

Aug. 24, 2010

2 1

How managing crashing tests ?
by GOUJON Alexandre Aug. 24, 2010

Aug. 24, 2010

Hi guys, A patch has been committed today saying "Make .. crashing like it does on native". I know we have to follow (genuine) Windows behavior but I'm wondering how to handle these cases. For instance, how to add a test crashing on every Windows ? Is it useful ? I mean, none program can rely on it .. since it crashes. Anyway, I've seen mainly two approaches - if(0) - /* comment the crashing ok() */ What's the difference ? And why not #if 0 ? I maybe lack some basic C knowledges but I think that /**/ and #if 0 are not added to the executable (from preprocessing stage). If it's right, it means we can then 'enable' these blocks maybe with (gdb) edit something And what about a test crashing on a specific Windows ? I guess #ifdef CRASHES_ON_NT40 is not an elegant way (even if it's currently used). Commenting such tests prevent us to check wine behavior on 'working' Windows. I attempted to use __TRY ... __EXCEPT_PAGE_FAULT in a test but it got rejected. Any advice ? Thanks

2 2

Re: ddraw/tests: New visual back buffer flipping tests. (resend)
by Octavian Voicu Aug. 24, 2010

Aug. 24, 2010

2010/8/23 Oldřich Jedlička <oldium.pro(a)seznam.cz>: > + // Check it out You have a C++ style comment in this patch and I don't think it's allowed. Octavian

3 2

Re: user32: Optimize the storage of default values
by Dmitry Timoshkov Aug. 24, 2010

Aug. 24, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > -static const char * const DefSysColors[] = > +static struct { > + const char *name; > + const COLORREF rgb; > +} DefSysColors[] = It should be 'static const struct {'. -- Dmitry.

1 0

RFC: test of 16 bit wine (DOS)
by Morten Rønne Aug. 24, 2010

Aug. 24, 2010

Hi I have been working on creating tests for the 16 bit implementation of wine, and now I have come so far that I would like some comments on the way I have chosen to do it. 16 bit programs require a compiler that is able to create the old style address method in order to be able to test those parts of wine. I have been told by Dmitry Timoshkov that I should use OpenWatcom for that. So that is what I have done. OpenWatcom also supports building DOS32 (using a number of extenders) and WIN 3.x programs. Since the DOS program can't run in the current test enviroment, because that is new style 32 bit address method, I am using a wrapper program which start the old style program from the 32 bit environment. The wrapper also makes it possible to do a skip message in case the needed DOS program is missing (due to no OpenWatcom compiler). In order to be able to create a stand-alone DOS program I have modified the wine/test.h file so that certain parts got omitted, while others were added. This means that writing a DOS test will be the same as writing normal 32 bit tests, except that you include a different test include file. The current version uses the define __WINE_WINE_DOS16_TEST_H from the include file that defines the DOS environment, since I haven't been able to find a better name. Suggestions for a better name are most welcome. The DOS test it self, is only a very simple one because I consider this more a proof of concept than a full test. Also a full test will require a number of changes in the current 16 bit tree to move a number of definitions from .c files to .h files so the test can reference them. Once this have been commited work can start towards making more complete test of the 16 bit environment. I hope that the naming will make Wine Testbot able to detect changes to the test suite. As can be seen above the OpenWatcom compiler is needed to build the DOS 16 bit programs. Currently only Linux 32 bit platform is supported. The compiler can't be built on 64 bit yet, this includes Mac. The easiest way to install the compiler is to download the binary installer from: http://www.openwatcom.org/index.php/Download Select one of the mirrors and download the file: open-watcom-c-linux-1.9 Ignore the fact that the main download page points to other places to get the linux version. This is a binary program that you have to run. It will ask you were to install OpenWatcom and all files will be installed under that tree. After that you must add a definition of WATCOM to your shell profile, pointing it to the directory you selected. After that change PATH to search in $WATCOM/binl as the LAST thing. Watcom includes programs that are called the same as some wine programs (wrc for one), so be sure you don't find these by searching OpenWatcom last. As a note I can tell that Debian have rejected the Sybase license (under which OpenWatcom is released) as not being free, and therefore there will be no official debian packages of OpenWatcom. Best Regards Morten Rønne

2 1

Re: ddraw/tests: New visual back buffer flipping tests. (try 2)
by Octavian Voicu Aug. 23, 2010

Aug. 23, 2010

2010/8/24 Oldřich Jedlička <oldium.pro(a)seznam.cz>: > + ok((GetRValue(color) == 0xFF && GetGValue(color) == 0xFF && GetBValue(color) == 0xFF) || > + broken(GetRValue(color) == 0xFF && GetGValue(color) == 0 && GetBValue(color) == 0), // broken driver > + "got R %02X G %02X B %02X, expected R FF G FF B FF\n", > + GetRValue(color), GetGValue(color), GetBValue(color)); I hate to be the bearer of bad news, but you missed one :)

2 1

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file
by testbot＠testbot.winehq.org Aug. 23, 2010

Aug. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your paranoid android. === WINEBUILD (build) === Make failed

3 3

Re: ddraw: SetCooperativeLevel with Full screen + exclusive + normal is authorized
by testbot＠testbot.winehq.org Aug. 23, 2010

Aug. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4696 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: gdiplus: add a stub for GdipWindingModeOutline
by Vincent Povirk Aug. 23, 2010

Aug. 23, 2010

You need to add it to the .spec file too. On Mon, Aug 23, 2010 at 4:45 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > >

2 1