August 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion.
by James Mckenzie Aug. 16, 2010

Aug. 16, 2010

Rico Schüller <kgbricola(a)web.de> wrote: >Sent: Aug 16, 2010 10:21 AM >To: wine-devel(a)winehq.org >Subject: Re: [PATCH 1/5] d3d10: Fix d3dcommon.h inclusion. > >Am 15.08.2010 18:26, schrieb James McKenzie: >> Rico Schüller wrote: >>> Hi, >>> >>> this patch series implements the ID3DBlob interface. This time the >>> interface is implemented in the d3dcompiler_43.dll. The function >>> D3D10CreateBlob from d3d10 is forwarded to the D3DCreateBlob function >>> in the d3dcompiler_43.dll. >> >> Does this replace the ten patch series you submitted on 8/11? This is >> not clear here. >> >Yes, this replaces the earlier patch series. I thought this was clear >from the discussion for try 2. > I've learned the hard way to never assume anything and to document everything. If something can be misunderstood it will and will in the most damaging manner. James McKenzie James McKenzie

1 0

RE: Wine users with a CD-ROM drive, please test
by Ge van Geldorp Aug. 16, 2010

Aug. 16, 2010

> From: Joerg Hoehle > > There's no mention of win95/98 in the attachment so I assume these > were not included, or was that because there was no error? Right, they were not included. I ran into some problems trying to attach the .iso to those VMs and gave up. Win9x should die :-). Ge.

1 0

RE: Wine users with a CD-ROM drive, please test
by Greg Geldorp Aug. 16, 2010

Aug. 16, 2010

Hi Joerg, > From: Joerg Hoehle > > I found out that some machines ignore > set c audio all off > which was in the testsuite, while others react to it and even > update the system preferences volume mixer control if > it happens to be open. > > I don't know whether that difference depends on the HW (CD-ROM > driver) or the OS. You can find it out by posting your results here. > > I'm now using > set c audio all on > (which should be the default) > such that all users running the testsuite get to hear something. > > https://testbot.winehq.org/JobDetails.pl?Key=4434 > mcicda.c:612: Test failed: STOP all returned MCIERR_HARDWARE > (I fixed that, but not yet on testbot). I ran mcicda_test from TestBot job 4436 on the TestBot VMs, with a data .iso connected as CD-ROM. Full results in attachment. In short: On NT4, Win2000: mcicda.c:318: Test failed: resume without play: 0=NOERROR On NT4, Win2000, XP, W2K3 mcicda.c:397: Test failed: STATUS position: MCIERR_HARDWARE Ge.

2 1

Re: [3/3] wined3d: Remove isInDraw hack from context_setup_target.
by Henri Verbeet Aug. 16, 2010

Aug. 16, 2010

On 16 August 2010 13:25, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > It is conceptually wrong and actually broken too (as the comment there > said). Just remove the hack now and properly fix any regression > that may come up later by explicitely acquiring the right context where > needed (so, in surface_internal_preload and its callees). Note that isInDraw is mildly awful in itself, and we should probably get rid of it eventually. In most places where it's used it's probably an artifact of the old context management, but that needs to be checked.

2 1

Re: [1/3] wined3d: Call set_render_offscreen at the end of context_setup_target.
by Henri Verbeet Aug. 16, 2010

Aug. 16, 2010

I'm ok with this, but for future reference, if the change isn't entirely obvious a small comment is usually appropriate.

1 0

Re: [PATCH 2/2] jscript: Throw TypeError in in_eval.
by testbot＠testbot.winehq.org Aug. 16, 2010

Aug. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4470 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: urlmon: Return failures from progress callback
by Jacek Caban Aug. 16, 2010

Aug. 16, 2010

Hi Juan, On 8/4/10 11:44 PM, Juan Lang wrote: > Partial fix for bug 21032. > --Juan if(!This->callback) - return; + return E_POINTER; This doesn't seem right. It's fine to call URLDownloadToFile without callback AFAIR. Thanks, Jacek

1 0

Re: [PATCH 1/2] jscript: Throw TypeError in instanceof_expression_eval.
by testbot＠testbot.winehq.org Aug. 16, 2010

Aug. 16, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4469 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Some statistics about the 1.0->1.2 development cycle
by Wolfram Sang Aug. 16, 2010

Aug. 16, 2010

Hello, I am going to speak about my "getting into wine development" at FrosCon (near Bonn/Germany) next weekend. During preparation, I was interested in some numbers, so I roughly modified 'kps' (kernel patch statistics) for wine. The outcome for the 1.0->1.2 cycle can be found here, if somebody is interested (just make sure you read the README first): http://www.the-dreams.de/wine/winekpsstats10-12.tar.gz So far, not too surprising IMHO, although I probably missed a number of people. I am open for comments, if there are some. Have a nice sunday, Wolfram

6 7

Re: [PATCH 1/1] d3dx9: Add tests for FVF <-> declaration conversion.
by Henri Verbeet Aug. 16, 2010

Aug. 16, 2010

This is for the most part just a copy of the corresponding d3d9 test, so I guess it should work, but it also contains most of the flaws from that test, like e.g. returning E_FAIL from a function returning int. There's probably room for improvement in the test setup itself as well.

1 0