August 2010 - Wine-Devel - list.winehq.org

Latest version of ddraw/tests plus fixes
by Oldřich Jedlička Aug. 2, 2010

Aug. 2, 2010

Hi Stefan, Roderick, I've sent my latest version of ddraw/tests plus some fixes right now (it takes some time to get to wine-patches ML), one of them fixes bug #9008. Unfortunately I don't have much spare time (and actually I didn't have it the whole time working on patches), my spare time is almost over now, so I would appreciate some last comments - what to remove (if there is something unacceptable), what to change. But I don't have more time to enhance the backbuffers+3D interaction investigations/tests, sorry. It would be great if you let the fix for bug #9008 go into the wine tree. Thanks! Regards, Oldřich.

1 0

Re: wordpad: Added Hebrew translation.
by Paul Vriens Aug. 2, 2010

Aug. 2, 2010

Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: > Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL > for the dialogs, hope that helps. > > Also found out that menus does not need any special RTL property, they > are self aligned according to the app. What do you mean by that? Running Wordpad in Hebrew still gives me LTR menu styles/justification. The global (per process) RTL settings still need to be implemented for our internal apps. > > Kind regards, > Yaron Shahrabani > > <Hebrew translator> > > > > 0002-wordpad-Added-Hebrew-translation.patch > > > From 8f5dfcb55656e7e4d7943d622234fb37753210f7 Mon Sep 17 00:00:00 2001 > From: Yaron Shahrabani<sh.yaron(a)gmail.com> > Date: Sun, 1 Aug 2010 11:48:23 +0300 > Subject: wordpad: Added Hebrew translation. > > --- > programs/wordpad/He.rc | 282 ++++++++++++++++++++++++++++++++++++++++++ > programs/wordpad/Makefile.in | 1 + > 2 files changed, 283 insertions(+), 0 deletions(-) > create mode 100644 programs/wordpad/He.rc > > diff --git a/programs/wordpad/He.rc b/programs/wordpad/He.rc > new file mode 100644 > index 0000000..091ec98 > --- /dev/null > +++ b/programs/wordpad/He.rc > @@ -0,0 +1,282 @@ > +/* > + * Copyright 2004 by Krzysztof Foltman > + * Hebrew Translation by Yaron Shahrabani<sh.yaron(a)gmail.com>, 2010 Minor, but why did you not use the same format (as we see in most files)? So something like: /* * Hebrew Translation of wordpad * * Copyright 2004 by Krzysztof Foltman * Copyright 2010 Yaron Shahrabani<sh.yaron(a)gmail.com> > +IDD_DATETIME DIALOG 30, 20, 130, 80 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL Eventually we probably have to but I'm not sure what Alexandre thinks about introducing it (now). We probably also have to teach our tools (like the translation site) that detects translation differences/issues to cope with this. > +STRINGTABLE > +BEGIN > + STRING_ALIGN_LEFT, "שמאל" > + STRING_ALIGN_RIGHT, "ימין" > + STRING_ALIGN_CENTER, "מרכז" > +END This piece is already defined starting on line 226 and thus leads to: ../../../wine-git/programs/wordpad/He.rc:279:32: Error: Stringtable ID 1416 already in use -- Cheers, Paul.

3 4

Re: write: Added Hebrew translation
by Paul Vriens Aug. 2, 2010

Aug. 2, 2010

On 08/02/2010 04:57 PM, Yaron Shahrabani wrote: > +++ b/programs/write/He.rc > @@ -0,0 +1,30 @@ > +/* > + * English language support Should be 'Hebrew' of course ;) -- Cheers, Paul.

2 1

Re: [PATCH 1/4] wined3d: separate driver info from GPU info
by Henri Verbeet Aug. 2, 2010

Aug. 2, 2010

On 1 August 2010 05:37, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > struct driver_version_information > { > + WORD vendor; /* reported PCI card vendor ID */ ... > + enum wined3d_display_driver driver; > +}; That doesn't make all that much sense.

2 1

Re: winex11.drv: implement drag and drop from X to OLE (try 3)
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -300,6 +499,66 @@ static void X11DRV_XDND_ResolveProperty(Display *display, Window xwin, Time tm, > wine_tsx11_unlock(); > } > > + /* We get the list of formats in descending order of preference, yet the linked > + * list is a stack so the order is inverted. Reverse the linked list here so > + * that we get the right order. > + */ > + current = XDNDData; You should first convert it to a standard Wine list, then you can use it in either order. > + /* For some strange reason, load-time linking SHELL32.DLL to WINEX11.DRV > + * causes wine to segfault on startup. So rather use run-time linking. > + */ > + shell32 = GetModuleHandleA("SHELL32.DLL"); > + if (shell32 == NULL) > + shell32 = LoadLibraryA("SHELL32.DLL"); A delayed import should work fine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: implement X session management (try 2)
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > +static void SM_Init(void) > +{ > + CreateThread(NULL, 0, manage_session, NULL, 0, NULL); > +} > +#endif /* defined(SONAME_LIBSM) */ You don't want to create a new thread in every process for this. It will cause lots of trouble. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 07/10] explorerframe/nstc: Implement Initialize.
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > + /* Native accepts a NULL prc, so should we. */ > + if(prc) > + SetWindowPos(This->hwnd_main, HWND_TOP, prc->left, prc->top, > + prc->right - prc->left, prc->bottom - prc->top, SWP_SHOWWINDOW); It would be better to create it directly with the correct rectangle. Also SWP_SHOWWINDOW is not useful since the window is created visible. And please don't add comments like "native does this", that should be true of pretty much anything we do. Native behavior should be documented by test cases anyway, not comments. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: Partial implementation of IShellItem::BindToHandler.
by Nikolay Sivov Aug. 2, 2010

Aug. 2, 2010

On 8/2/2010 02:36, David Hedberg wrote: > +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc, IShellFolder **ppsf) > +{ > + IShellFolder *desktop; > + HRESULT ret; > + > + ret = SHGetDesktopFolder(&desktop); > + if (SUCCEEDED(ret)) > + { > + if (_ILIsDesktop(This->pidl)) > + { > + *ppsf = desktop; > + IShellFolder_AddRef(*ppsf); > + } > + else > + { > + ret = IShellFolder_BindToObject(desktop, This->pidl, pbc,&IID_IShellFolder, (void**)ppsf); > + } > + > + IShellFolder_Release(desktop); > + } > + > + return ret; > +} > + > I don't think this explicit check for desktop folder is needed here, as I understand ::BindToObject() it should handle this case internally.

2 4

Re: [PATCH 1/5] include/mswsock: add WS_ prefix if necessary
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > @@ -173,11 +174,28 @@ typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, HANDLE, DWORD, DWORD, LPOVERLA > typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > typedef INT (WINAPI * LPFN_WSARECVMSG)(SOCKET, LPWSAMSG, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > typedef INT (WINAPI * LPFN_WSASENDMSG)(SOCKET, LPWSAMSG, DWORD, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +#else > +typedef BOOL (WINAPI * LPFN_ACCEPTEX)(SOCKET, SOCKET, PVOID, DWORD, DWORD, DWORD, LPDWORD, LPOVERLAPPED); > +typedef BOOL (WINAPI * LPFN_CONNECTEX)(SOCKET, const struct WS_sockaddr *, int, PVOID, DWORD, LPDWORD, LPOVERLAPPED); > +typedef BOOL (WINAPI * LPFN_DISCONNECTEX)(SOCKET, LPOVERLAPPED, DWORD, DWORD); > +typedef VOID (WINAPI * LPFN_GETACCEPTEXSOCKADDRS)(PVOID, DWORD, DWORD, DWORD, struct WS_sockaddr **, LPINT, struct WS_sockaddr **, LPINT); > +typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, HANDLE, DWORD, DWORD, LPOVERLAPPED, LPTRANSMIT_FILE_BUFFERS, DWORD); > +typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > +typedef INT (WINAPI * LPFN_WSARECVMSG)(SOCKET, LPWSAMSG, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +typedef INT (WINAPI * LPFN_WSASENDMSG)(SOCKET, LPWSAMSG, DWORD, LPDWORD, LPWSAOVERLAPPED, LPWSAOVERLAPPED_COMPLETION_ROUTINE); > +#endif What you want is the WS() macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] shdocvw: Recurse into directories when adding Favorites
by Alexandre Julliard Aug. 2, 2010

Aug. 2, 2010

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > @@ -109,10 +109,10 @@ static void add_fav_to_menu(HMENU menu, LPWSTR title, LPCWSTR url) > { > MENUITEMINFOW item; > /* Subtract the number of standard elements in the Favorites menu */ > - INT favcount = GetMenuItemCount(menu) - 2; > + static INT favcount; > LPWSTR urlbuf; The previous version was better, you don't want a static variable for this, you may want to do it multiple times, or the menu may get changed somewhere else. -- Alexandre Julliard julliard(a)winehq.org

1 0