September 2010 - Wine-Devel

Re: winebuild: Don't segfault when running without arguments
by Dmitry Timoshkov Sept. 7, 2010

Sept. 7, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > - if (!spec->dll_name) /* set default name from file name */ > + if (!spec->dll_name && spec->dll_name) /* set default name from file name */ > { > char *p; > spec->dll_name = xstrdup( spec->file_name ); Did you intend to check for spec->file_name? -- Dmitry.

1 0

Re: [6/6] urlmon: Implemented IUriBuilder_{Get/Set}UserName
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5069 Your paranoid android. === WXPPROSP3 (32 bit uri) === uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === WVISTAADM (32 bit uri) === uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === W2K8SE (32 bit uri) === uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0].

1 0

Re: [5/6] urlmon: Some IUri's don't include the userinfo component in the absolute URI string
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5068 Your paranoid android. === WXPPROSP3 (32 bit uri) === uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === WVISTAADM (32 bit uri) === uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === W2K8SE (32 bit uri) === uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0].

1 0

Re: [4/4] msxml3/tests: Basic test for ::setAttributeNode()
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5062 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5998: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5998: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5998: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [3/4] msxml3/tests: Some tests for ::get_ownerDocument() returned document instance
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5061 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5947: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5947: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5947: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [2/4] msxml3/domdoc: Implement IXMLDOMNamedNodeMap::removeQualifiedItem()
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5060 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5869: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5869: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5869: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [1/4] msxml3/tests: Add a helper to create document instance, remove useless output
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5059 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5804: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5804: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5804: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [PATCH 2/2] include: Define C++ operators inside extern "C++" blocks.
by Octavian Voicu Sept. 6, 2010

Sept. 6, 2010

d3c4106d6f6d587ec4b9013692dc1cf6da29c279 still doesn't fix the initial problem (see log below). There is still another problem in shlobj.h caused by the inclusion on shobjidl.h from an extern C block: http://source.winehq.org/git/wine.git/?a=blob;f=include/shlobj.h;h=cda13060… Should I send a patch to move the three includes before extern C? How to reproduce the problem: $ cat test.cpp #include <shlobj.h> $ wineg++ test.cpp In file included from /usr/local/include/wine/windows/propsys.h:164, from /usr/local/include/wine/windows/shobjidl.h:368, from /usr/local/include/wine/windows/shlobj.h:39, from test.cpp:1: /usr/local/include/wine/windows/propkeydef.h: In function ‘bool operator==(const PROPERTYKEY&, const PROPERTYKEY&)’: /usr/local/include/wine/windows/propkeydef.h:61: error: declaration of C function ‘bool operator==(const PROPERTYKEY&, const PROPERTYKEY&)’ conflicts with /usr/local/include/wine/windows/guiddef.h:110: error: previous declaration ‘bool operator==(const GUID&, const GUID&)’ here /usr/local/include/wine/windows/propkeydef.h: In function ‘bool operator!=(const PROPERTYKEY&, const PROPERTYKEY&)’: /usr/local/include/wine/windows/propkeydef.h:65: error: declaration of C function ‘bool operator!=(const PROPERTYKEY&, const PROPERTYKEY&)’ conflicts with /usr/local/include/wine/windows/guiddef.h:114: error: previous declaration ‘bool operator!=(const GUID&, const GUID&)’ here winegcc: g++ failed

1 0

Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation (try2)
by testbot＠testbot.winehq.org Sept. 6, 2010

Sept. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5040 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42

2 1

Re: setupx.dll16: Handle the error case for VCPM_VSTATWRITE in vcpUICallbackProc16. (RESEND)
by Alexandre Julliard Sept. 6, 2010

Sept. 6, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Just realized I did not see a response to this patch. Based on > feedback I received for a different patch, I looked at this patch > again and believe it indeed is easier. > > 1. We only set, but never used cbres, so removing it loses nothing. > 2. With this patch we now set the return value to VCPN_FAIL in this > case. However, this is not the only case in vcpUICallbackProc16; > for example, in another case in this function we pass the return > value of VCP_UI_CopyStart and that returns VCPN_FAIL all over the > place. That doesn't mean it's appropriate in this case. Unless there is evidence that a zero return from VCPM_DISKPREPINFO is supposed to cause an error, it's better not to change the current behavior. -- Alexandre Julliard julliard(a)winehq.org

2 1

msvcrt unimplemented function calls
by Peter Urbanec Sept. 6, 2010

Sept. 6, 2010

I see calls to the following two functions just prior to a crash when testing wine64. Any idea what these are? wine: Call from 0x7b8497d9 to unimplemented function msvcp80.dll.??0?$complex(a)N@std@@QEAA(a)AEBN0@Z, aborting wine: Call from 0x7f7b04cf40d9 to unimplemented function MSVCR80.dll.__C_specific_handler, aborting err:seh:setup_exception stack overflow 2432 bytes in thread 0009 eip 00007f7b04d32341 esp 00007f7b03b10c80 stack 0x7f7b03b10000-0x7f7b03b11000-0x7f7b03c10000 Segmentation fault Thanks.

1 0

Re: wined3d: separate driver info from GPU info (try4)
by Henri Verbeet Sept. 6, 2010

Sept. 6, 2010

On 6 September 2010 00:45, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > - driver_info->version_low = MAKEDWORD_VERSION(8, 6); /* Nvidia RIVA TNT, arbitrary */ > + } You messed up the indentation here, but otherwise I think this looks reasonable.

1 0

re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage
by Dan Kegel Sept. 6, 2010

Sept. 6, 2010

Mikko wrote: > Communicating with an external server is an option, but I don't > know which would be a good server for testing. https://mail.google.com ? Be sure to skip if you can't connect.

1 0

Re: [2/2] attrib/tests: added tests for some flags
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5041 Your paranoid android. === W98SE (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! Timeout Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2KPROSP4 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === WXPPROSP3 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2K3R2SESP2 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === WVISTAADM (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2K8SE (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PRO (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PROX64 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PROX64 (64 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories!

1 0

Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation (try2)
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5039 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42

1 0

Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5038 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42 url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url ' c :dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 43

1 0

Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5037 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42 url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url ' c :dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 43

1 0

Re: [1/5] urlmon: Implemented IUriBuilder_{Get/Set}Fragment (try 2)
by Jacek Caban Sept. 5, 2010

Sept. 5, 2010

Hi Thomas, On 9/5/10 8:10 PM, Thomas Mullaly wrote: > Changes since previous attempt: > > 1. Perform lazy allocation/copy of a URI property when the > IUriBuilder_Get* function is called, instead of always allocating when > the IUriBuilder is created (addresses Jacek's comments). > > 2. Created helper functions for Get/Set calls to the IUriBuilder to cut > back on code duplication. > > 3. Added a bit flag member to the UriBuilder object, so that it can store > which properties have been changed. It looks much better now. There is one problem remaining (that I think can be fixed in a follow-up patch): + This->modified_props |= Uri_HAS_FRAGMENT; + return set_builder_component(&This->fragment,&This->fragment_len, pwzNewValue, '#'); The modifier_props should be set only on success. To achieve so, I think it would be cleaner to pass a flag to be set to set_buildier_component. Jacek

1 0

Re: gdi32/tests: Fix a typ description in test_logpen.
by James McKenzie Sept. 5, 2010

Sept. 5, 2010

Gerald Pfeifer wrote: > winebot claims this is causing a tons of test failures on W98SE, > but that doesn't make sense at all. > > Gerald: What is the job id on the testbot? I don't see a failure message in Wine-Devel. James McKenzie

1 0

Re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage
by Mikko Rasa Sept. 5, 2010

Sept. 5, 2010

The patch list requests me to write tests for this patch. I would do that, but there is a problem: I need a fully initialized schannel security context to use DecryptMessage. To acquire one I need to communicate with a server component. Wine is lacking an implementation of at least the AcceptSecurityContext function, so at the moment I cannot do a self-contained test. Communicating with an external server is an option, but I don't know which would be a good server for testing. Implementing the server-side stuff is another, but might take quite a while and I'd like to see this patch applied soon as it's required to play several recent Ubisoft games. Mikko On 30.08.2010 19:37, Mikko Rasa wrote: > --- > dlls/secur32/schannel.c | 50 ++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 45 insertions(+), 5 deletions(-)

1 0

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE
by Alexandre Julliard Sept. 5, 2010

Sept. 5, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -181,6 +181,30 @@ static inline BSTR bstr_from_xmlChar(const xmlChar *str) > return ret; > } > > +static inline BSTR bstr_trim(const BSTR str) > +{ > + UINT i, j, len = SysStringLen(str); > + BSTR new_str = NULL; > + > + /* str empty or NULL */ > + if(!len) > + goto err; > + > + for(i=0; isspaceW(str[i]) && i<len; i++); > + for(j=len-1; isspaceW(str[j]) && j>=i; j--); > + > + new_str = SysAllocStringLen(str+i, j-i+1); > + if(!new_str) > + goto err; > + > + SysFreeString(str); > + return new_str; > + > + err: > + SysFreeString(str); > + return SysAllocStringLen(NULL, 0); > +} That's ugly and inefficient, especially since the common case is to not modify it. -- Alexandre Julliard julliard(a)winehq.org

6 7

Re: msvcp90: Fix 64-bit compilation warnings
by Alexandre Julliard Sept. 5, 2010

Sept. 5, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase, 12) > basic_string_char* __thiscall MSVCP_basic_string_char_erase( > basic_string_char *this, size_t pos, size_t len) > { > - TRACE("%p %d %d\n", this, pos, len); > + TRACE("%p %d %d\n", this, (int)pos, (int)len); You should be casting to long, otherwise you'll potentially truncate the value. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: winealsa.drv: remove unused variable
by Chris Robinson Sept. 5, 2010

Sept. 5, 2010

On Saturday, September 04, 2010 11:09:03 pm Austin English wrote: > - frames_per_period = snd_pcm_bytes_to_frames(wwi->pcm, > wwi->dwPeriodSize); > + snd_pcm_bytes_to_frames(wwi->pcm, wwi->dwPeriodSize); The whole call can probably be removed if the result isn't used anywhere. The function just returns the number of frames that would fit in the specified byte count for the specified device's format.

1 0

Re: [setupapi] added tests for SetupDiGetINFClassA (try2)
by testbot＠testbot.winehq.org Sept. 4, 2010

Sept. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5026 Your paranoid android. === WNT4WSSP6 (32 bit devinst) === No test summary line found

1 0

Re: attrib.exe: extendended from stub
by Austin English Sept. 4, 2010

Sept. 4, 2010

On Sat, Sep 4, 2010 at 1:53 PM, Konrad Wartke <kwartke(a)googlemail.com> wrote: > attrib.exe: extendended from stub > is now parsing arguments and implements them partly + // FIXME: only display attributes Please use C89 /* comments */. A testsuite for attrib.exe (look at cmd.exe and regedit.exe) would also be helpful. -- -Austin

1 0