September 2010 - Wine-Devel

Re: ddraw: Allow creating back buffer for DirectX 1 interfaces.
by testbot＠testbot.winehq.org Sept. 15, 2010

Sept. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5248 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: msxml3: Implement property SelectionNamespaces for XPath (try #3/resend)
by testbot＠testbot.winehq.org Sept. 15, 2010

Sept. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5247 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

intention of stubs with arch flag, specially in msvcp*
by André Hentschel Sept. 15, 2010

Sept. 15, 2010

Hi all, I used to think the arch flag is only used to say "this function is only available on win32" or to say the same for win64. We do that e.g. in msvcp* dlls. So i am not sure why those stubs like @ stub -arch=win32 function differ so heavy from stubs like @ stub function The last one silently gets ignored, but the one with the arch flag causes winebuild to put some extra assembler code into the dll. So is this intented? If so, i would add ARM code for that case.(And we also should for other platforms) -- Best Regards, André Hentschel

2 2

Re: [Patch 5/5] Add some more schannel tests
by testbot＠testbot.winehq.org Sept. 15, 2010

Sept. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5246 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found

1 0

Different Wine FAQs on winehq
by Frédéric Delanoy Sept. 15, 2010

Sept. 15, 2010

A STFW for wine faq gives as first result this page http://www.winehq.org/site/docs/wine-faq/index (old version of the FAQ) instead of http://wiki.winehq.org/FAQ (linked from home > support) The former contains some outdated information. Shouldn't it be suppressed (after a check to see if does contain helpful information not found elsewhere) ? Frédéric

2 1

Re: [msxml3/tests] Step to the next item on failure as well
by testbot＠testbot.winehq.org Sept. 15, 2010

Sept. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5243 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property
by Paul Vriens Sept. 15, 2010

Sept. 15, 2010

On 09/14/2010 07:20 AM, Nikolay Sivov wrote: > Properly set default value for SelectionLanguage property > Hi Nikolay, I wondered why there were only a few testbot reports on test.winehq.org. Looking at the reports on test.winehq.org (I have an account) shows that the reports are filled (12000+ lines) with: domdoc.c:5649: Tests skipped: can't create CLSID_DOMDocument40 instance This makes sure that the reports are not even considered valid: wine:/home/winehq/opt/winetest/queue/errvyhFy$ more error dissect:error:/home/winehq/opt/winetest/queue/errvyhFy: report reached file limit (runaway test?) -- Cheers, Paul.

1 1

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword
by Dmitry Timoshkov Sept. 15, 2010

Sept. 15, 2010

Marcus Meissner <marcus(a)jet.franken.de> wrote: > + if (!unk) { > + FIXME("hr was %d, but unk is NULL?\n", hr); > + return E_FAIL; > + } IDropTarget_QueryInterface() should be fixed instead. -- Dmitry.

3 5

[PATCH] shell32: use flexible arrays to avoid fortify failures
by Mike Frysinger Sept. 15, 2010

Sept. 15, 2010

Newer versions of gcc/glibc with fortify checks enabled will complain about the handling of the network's szNames field. Currently it is always defined with a length of one which means writing more then a single byte will trigger: In function 'strcpy', inlined from '_ILCreateEntireNetwork' at dlls/shell32/pidl.c:1762:15: warning: call to __builtin___strcpy_chk will always overflow destination buffer and then at runtime, we hit an abort(). Since this field is really serving as the header to an arbitrary buffer, using a flexible array instead should solve the issue. Signed-off-by: Mike Frysinger <vapier(a)gentoo.org> --- note: i couldnt find a statement of what C standard wine aims for. if it is attempting pre-c99, then this will have to be done differently. perhaps introducing a project-wide define like "VARARRAY" which expands into [] for c99+ and [1] for older ... dlls/shell32/pidl.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/pidl.h b/dlls/shell32/pidl.h index 3dbfaa6..bbfacef 100644 --- a/dlls/shell32/pidl.h +++ b/dlls/shell32/pidl.h @@ -172,12 +172,12 @@ typedef struct tagPIDLDATA struct tagFileStruct file; struct { WORD dummy; /*01*/ - CHAR szNames[1]; /*03*/ + CHAR szNames[]; /*03*/ } network; struct { WORD dummy; /*01*/ DWORD dummy1; /*02*/ - CHAR szName[1]; /*06*/ /* terminated by 0x00 0x00 */ + CHAR szName[]; /*06*/ /* terminated by 0x00 0x00 */ } htmlhelp; struct tagPIDLCPanelStruct cpanel; struct tagValueW valueW; -- 1.7.2

3 4

Re: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without an IDOK
by Dmitry Timoshkov Sept. 15, 2010

Sept. 15, 2010

Vladimir Panteleev <thecybershadow(a)gmail.com> wrote: > diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c > index aac8a4d..ee99710 100644 > --- a/dlls/user32/dialog.c > +++ b/dlls/user32/dialog.c > @@ -1221,6 +1221,11 @@ BOOL WINAPI IsDialogMessageW( HWND hwndDlg, LPMSG msg ) > else if (DC_HASDEFID == HIWORD(dw = SendMessageW (hwndDlg, DM_GETDEFID, 0, 0))) > { > HWND hwndDef = GetDlgItem(hwndDlg, LOWORD(dw)); > + if (!hwndDef && LOWORD(dw)==IDOK) > + { > + SendMessageW( hwndDlg, WM_COMMAND, IDOK, 0 ); > + return TRUE; > + } > if (!hwndDef || !IsWindowEnabled(hwndDef)) > return TRUE; > SendMessageW( hwndDlg, WM_COMMAND, MAKEWPARAM( LOWORD(dw), BN_CLICKED ), It would be cleaner to use an existing SendMessage() instead of introducing a duplicate. -- Dmitry.

2 4

Re: msxml3: Implement property SelectionNamespaces for XPath (try #3)
by testbot＠testbot.winehq.org Sept. 15, 2010

Sept. 15, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5234 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6236: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

WineAPI wiki progress.
by Max TenEyck Woodbury Sept. 14, 2010

Sept. 14, 2010

The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Please take a look at it and tell me if you think the content is useful and how it could be improved. None of the analysis of the file content is in place. I plan to start with analysis of the '.spec' files. That should make some of the information on the API available. - Max

1 0

Re: [PATCH 2/2] secur32: Reorganize data returned by schan_DecryptMessage.
by Henri Verbeet Sept. 14, 2010

Sept. 14, 2010

On 14 September 2010 20:28, Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/secur32/schannel.c | 30 ++++++++++++++++++++---------- > 1 files changed, 20 insertions(+), 10 deletions(-) > Personally I thought Mikko's series was nicer, not in the least for actually having tests. (Though I don't think it's good to have a dependency on mail.google.com.)

2 1

Re: [PATCH 1/2] secur32: Improved error handling in schan_DecryptMessage.
by Henri Verbeet Sept. 14, 2010

Sept. 14, 2010

On 14 September 2010 20:27, Piotr Caban <piotr(a)codeweavers.com> wrote: > + else if (ret == GNUTLS_E_DECRYPTION_FAILED) ... > + return SEC_E_MESSAGE_ALTERED; Are those really the same?

2 1

Re: secur32: Reorganize data returned by schan_DecryptMessage.
by Juan Lang Sept. 14, 2010

Sept. 14, 2010

Hi Piotr, - TRACE("context_handle %p, message %p, message_seq_no %d, quality %p\n", + FIXME("context_handle %p, message %p, message_seq_no %d, quality %p\n", Did you intend to leave this change in? --Juan

2 1

Console issues in recent git
by Jerome Leclanche Sept. 14, 2010

Sept. 14, 2010

Anyone else's terminal emulators really acting up since the last git batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if there is a wine process running, until it's killed. This is probably a konsole bug, but still... CC eric. -- J. Leclanche

9 22

Desktop window doesn't span entire screen in multi-monitor setup?
by Damjan Jovanovic Sept. 14, 2010

Sept. 14, 2010

$ xrandr -q Screen 0: minimum 320 x 200, current 2732 x 768, maximum 8192 x 8192 GetWindowRect(GetDesktopWindow(), &r); r.left, r.top, r.right, r.bottom are: 0 0 1366 768 This causes WindowFromPoint() to fail (returns NULL) when the point is on my second monitor, which causes X11 -> Wine drag and drop to also fail since it uses WindowFromPoint(). It seems wineserver doesn't allow the point to fall outside the window from which the search starts, which causes the point to be rejected because the desktop window doesn't contain it. What's the problem here, that the desktop window is too small, or that the window search criteria are too strict? Damjan Jovanovic

2 1

Re: [1/3] dsound: Add support for 32-bit IEEE float buffers
by Chris Robinson Sept. 14, 2010

Sept. 14, 2010

On Monday, September 13, 2010 12:55:43 pm Owen Rudge wrote: > + if (*v < -1.0f) d = -128; > + if (*v < 0.0f) d = *v * 128.0f; > + if (*v >= 0.0f) d = *v * 127.0f; > + if (*v > 1.0f) d = 127; The way these checks are written out can cause problems, particularly with the first two because the if(*v < 0.0f) occurs after the if(*v < -1.0f) check, so it won't properly clamp values below -1.0. Something like this: if (*v < -1.0f) d = -128; else if (*v < 0.0f) d = *v * 128.0f; else if (*v > 1.0f) d = 127; else if (*v >= 0.0f) d = *v * 127.0f; should do fine (along with the 16- and 32-bit variants; the 24-bit one looks fine). You also don't need to keep the float as a pointer, though I imagine the optimizer can handle that.

2 4

Re: [1/2] windowscodecs: support ICO files with embedded PNGs (try 2)
by Vincent Povirk Sept. 14, 2010

Sept. 14, 2010

I'm in the process of reorganizing the ICO decoder to address bug 24301 and take advantage of the rest of WIC. I'd prefer to leave this out until then. It's hard enough as it is, without having to keep PNG icons working too. On Tue, Sep 14, 2010 at 12:20 AM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * windowscodecs: support ICO files with embedded PNGs > > Try 2 uses IWICStream regions instead of reading the file into memory. > > Damjan Jovanovic > > > >

2 1

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property
by testbot＠testbot.winehq.org Sept. 14, 2010

Sept. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5209 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6232: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6232: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6232: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WXPPROSP3 (32 bit domdoc) === Timeout === W2K3R2SESP2 (32 bit domdoc) === Timeout === WVISTAADM (32 bit domdoc) === Timeout === W2K8SE (32 bit domdoc) === Timeout === W7PRO (32 bit domdoc) === Timeout === W7PROX64 (32 bit domdoc) === Timeout === W7PROX64 (64 bit domdoc) === Timeout

1 0

Re: [3/4] msxml3: Fix IXMLDOMNode::get_namespaceURI() for empty URIs
by testbot＠testbot.winehq.org Sept. 14, 2010

Sept. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5208 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [2/4] msxml3: Fix IXMLDOMNode::get_prefix() for empty prefix
by testbot＠testbot.winehq.org Sept. 14, 2010

Sept. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5207 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6187: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [1/4] msxml3: Support elements with namespaces
by testbot＠testbot.winehq.org Sept. 14, 2010

Sept. 14, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5206 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6141: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6141: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6141: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [2/2] ws2_32: Fail when select is called with an invalid fd.
by Mike Kaplinskiy Sept. 13, 2010

Sept. 13, 2010

On Sun, Sep 12, 2010 at 5:23 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > > > @@ -3193,6 +3193,10 @@ int WINAPI WS_select(int nfds, WS_fd_set *ws_readfds, > return SOCKET_ERROR; > } > > + for (i=0; i<count; i++) > + if (pollfds[i].fd == -1) > + return SOCKET_ERROR; You're leaking pollfds here. (As a nitpick - braces for for's that contain more than one line are nice) Mike.

1 0

Re: [Wine] [1.2]-S.T.A.L.K.E.R.:SoC - Remapping keys?
by Jesse Palser Sept. 13, 2010

Sept. 13, 2010

On 9/9/10 8:48 AM, Jesse Palser wrote: > > [1.2]-S.T.A.L.K.E.R.:SoC - Remapping keys? > > Hi, > > I am running Wine 1.2 on Ubuntu 10.04 32bit Linux. > > I wish to remap the movement keys in: > S.T.A.L.K.E.R.: Shadow of Chernobyl, > but when I try, it always maps "Pause" ? You will have to ask this in the Steam support forums. Wine does not activate or deactivate keys. James McKenzie ------------------------------------------------------------------------------------------------------- Hi, I am not talking about activating/deactivating registration keys. I am talking about the control mapping of keyboard keys in the game. Currently when I try to remap a keyboard key in this game, it always selects "Pause" regardless of which keyboard key I press. I would like to map the arrow key for movement, and can not do that. Any ideas? Using Wine 1.2 on Ubuntu 10.04 32bit Linux. Thanks! Jesse

2 1