September 2010 - Wine-Devel

Re: Release plans
by Luis Carlos Busquets Pérez Sept. 13, 2010

Sept. 13, 2010

As a user that only uses wine for playing games built for the Windows platform what I would like the most is d3d10, d3d10.1 and d3d11. It seems that these API's are more similar between themselves than what is the difference between d3d9 and d3d10.

1 0

Re: Release plans
by Dan Kegel Sept. 13, 2010

Sept. 13, 2010

Looks like Alexandre must have fired up his time machine again :-) And as long as it's up and running, how about a look forward at the 1.4 release plans?

5 6

Re: d3d9/tests: Test NVDB (depth bounds test) behavior
by Henri Verbeet Sept. 13, 2010

Sept. 13, 2010

This is fine, except for the 8 space indentation. I wonder though if perhaps it would be more interesting to start with a quad with a depth gradient from 0.0 to 1.0, bottom to top, then set the min/max depth bounds, and draw another fullscreen quad. That way you could easily verify the cutoffs are in roughly the right spots.

1 0

Re: wined3d: Add NVDB support
by Henri Verbeet Sept. 13, 2010

Sept. 13, 2010

2010/9/12 Ričardas Barkauskas <miegalius(a)gmail.com>: > Looks reasonable in general, though there are a few minor issues: > + /* Depth bound test. To query if the card supports instancing CheckDeviceFormat with the special Instancing doesn't have anything to do with this. > + union { > + DWORD d; > + float f; > + } zmin, zmax; Four space indent is enough. You do this in the test patch as well. > + if(stateblock->renderState[WINED3DRS_ENABLEADAPTIVETESSELLATION]) > + FIXME("(WINED3DRS_ENABLEADAPTIVETESSELLATION,%d) not yet implemented\n", stateblock->renderState[WINED3DRS_ENABLEADAPTIVETESSELLATION]); Note that you can just call state_tessellation() here. > { STATE_RENDER(WINED3DRS_ADAPTIVETESS_W), { STATE_RENDER(WINED3DRS_ENABLEADAPTIVETESSELLATION), NULL }, WINED3D_GL_EXT_NONE }, > + { STATE_RENDER(WINED3DRS_ENABLEADAPTIVETESSELLATION), { STATE_RENDER(WINED3DRS_ENABLEADAPTIVETESSELLATION), state_tessellnvdb }, EXT_DEPTH_BOUNDS_TEST }, You have two extra spaces here.

1 0

re: [PATCH 2/7] d3dx9_36/tests: Added HLSL test suite
by Dan Kegel Sept. 13, 2010

Sept. 13, 2010

Henri wrote: > You still have basic formatting errors like trailing spaces, mixing > tabs and spaces, inconsistent "*" placement, etc. > ... unnecessary cast... > wine-patches reviews are supposed to catch non-trivial interactions with > other parts of the code, not trivial whitespace errors. Looking at http://wiki.winehq.org/SubmittingPatches, I didn't see a nice, concise checklist of things to check for, so I added one at the top, and linked to Henri's post. Improvements welcome. - Dan

3 2

Suggestion for the Game Explorer implementation
by אלעד Sept. 13, 2010

Sept. 13, 2010

I have a little suggestion: integrate the Game Explorer with the Games menu of the desktop, so that games i install in wine will be added to the Games menu automaticlly.

2 1

ptrace, pokerstars and Ubuntu 10.10
by Michael Fox Sept. 13, 2010

Sept. 13, 2010

Hi all, There's a problem running wine under the new Ubuntu 10.10 (Maverick). They have enabled kernel security to prevent processes from using ptrace. This affects any wine programs which use ptrace which is surprisingly common. For example I found this bug because PokerStars wouldn't connect to the network. I have filed this as a bug with Ubuntu, but they might choose not to fix it depending on how committed they are to this new security measure. It is filed as: https://bugs.launchpad.net/ubuntu/+source/wine1.2/+bug/636278 There is a simple workaround and it is to add the ptrace capability to wineserver using the command: sudo setcap cap_sys_ptrace=eip /usr/bin/wineserver I tried to submit this as a bug for wine, but it was closed because the maintainer felt there was nothing the wine people could do about the way Ubuntu sets their security. I would like to make the following suggestions: 1. Add a winetricks trick to fix wine on Maverick by executing: "sudo apt-get install setcap; sudo setcap cap_sys_ptrace=eip /usr/bin/wineserver" 2. Add an error message in wine when ptrace fails with error EPERM. This message should suggest the winetrick so the user will find it quickly. In my case it took quite a while to figure out exactly what was going wrong because there is no more terminal output when ptrace fails than when it succeeds. -- - Michael

4 5

Re: [PATCH 2/3] wined3d: store amount of video memory in gpu_description_table
by Roderick Colenbrander Sept. 13, 2010

Sept. 13, 2010

Hi Jesse, I think the 465 change should go in after the gpu table patch. The gpu table patch could be modified but then it would essentially contain two patches (makes regression testing more complicated, though I doubt that would be an issue here). It is trivial to submit a patch after this is in. If you want I can do that. Roderick On Sat, Sep 11, 2010 at 9:34 AM, Evil Jay <evil(a)eternaldusk.com> wrote: > Roderick, > > Would you add the GTX 465 (1GB) to this table? That way the patch I > submitted to add the 465 just 30 minutes earlier can be safely ignored. > > -Jesse > > >

2 1

Running GDI32 tests for Wine on MacOSX 10.6
by James McKenzie Sept. 13, 2010

Sept. 13, 2010

On 9/7/10 11:37 AM, doh123 wrote: > James Mckenzie wrote: >> I agree with both Ryan and you, LD_LIBRARY_PATH is supposed to do absolutely NOTHING under MacOSX. However, Wine needs it for some strange reason. If I leave it out, the built dependency libraries are not found for freetype and fontconfig (and I know that fontconfig is included with MacOSX 10.6 now.) Otherwise, I get a series of freetype cannot be found, install freetype 2.0.5 or higher. I'll look at the Fink setup script to see how they did this. >> > This error can be fixed with DYLD_FALLBACK_LIBRARY_PATH... > > I've uploaded three logging files to pastebin.com: Part #1 of running the gdi32 tests with LD_LIBRARY_PATH set to: $HOME/darwine/wineEnv/usr/lib:/usr/X11R6/lib http://pastebin.com/NyrQxE4Q Part # 2 of the same test http://pastebin.com/dF1PwvHJ Log of running the same tests with DYLD_LIBRARY_PATH set to: $HOME/darwine/wineEnv/usr/lib:/usr/X11R6/lib and DYLD_FALLBACK_LIBRARY_PATH set to: /usr/lib:$HOME/darwine/wineEnv/usr/lib:/usr/X11R6/lib http://pastebin.com/i3Mfh7NB The $HOME/darwine/wineEnv/usr/lib directory contains unaltered builds of the dependencies for Wine (freetype, libgphoto2, etc.) that are separate from Fink builds. Any clue as to why the LD_LIBRARY_PATH is working and the DYLD paths are not? Thank you.

1 0

Re: kernel32: add a stub for GetSystemDEPPolicy()
by Marcus Meissner Sept. 12, 2010

Sept. 12, 2010

On Sun, Sep 12, 2010 at 12:50:39PM -0500, Austin English wrote: > -- > -Austin > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 8a33013..43e339b 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec > @@ -624,6 +624,7 @@ > @ stdcall GetSystemDefaultLCID() > @ stdcall GetSystemDefaultLangID() > @ stdcall GetSystemDefaultUILanguage() > +@ stdcall GetSystemDEPPolicy() > @ stdcall GetSystemDirectoryA(ptr long) > @ stdcall GetSystemDirectoryW(ptr long) > @ stdcall GetSystemInfo(ptr) > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index c1816a8..5990943 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -3385,3 +3385,14 @@ DWORD WINAPI WTSGetActiveConsoleSessionId(void) > FIXME("stub\n"); > return 0; > } > + > +/********************************************************************** > + * GetSystemDEPPolicy (KERNEL32.@) > + */ > +DEP_SYSTEM_POLICY_TYPE WINAPI GetSystemDEPPolicy(void) > +{ > + FIXME("stub\n"); > + return 0; better return one of the Enum values here ... "AlwaysOff" probably, instead of 0 (AlwaysOn). Ciao, Marcus > +} > + > + > diff --git a/include/winbase.h b/include/winbase.h > index ea10696..d8dba1d 100644 > --- a/include/winbase.h > +++ b/include/winbase.h > @@ -1230,6 +1230,13 @@ typedef struct tagHW_PROFILE_INFOW { > DECL_WINELIB_TYPE_AW(HW_PROFILE_INFO) > DECL_WINELIB_TYPE_AW(LPHW_PROFILE_INFO) > > +typedef enum _DEP_SYSTEM_POLICY_TYPE { > + AlwaysOn, > + AlwaysOff, > + OptIn, > + OptOut > +} DEP_SYSTEM_POLICY_TYPE; > + > /* Event Logging */ > > #define EVENTLOG_FULL_INFO 0 >

3 2

RE: Problem with getting account at testbot
by Greg Geldorp Sept. 12, 2010

Sept. 12, 2010

Hi Mariusz, > From: Mariusz Pluciński > > I have a problem with my account at testbot.winehq.org. Long time ago, I > registered my account. To this day I have not received an activation > e-mail. I thought it was maybe rejected, because I was not "well-known > member of the Wine community" that time. > > Today I noticed that I can not send request for account, because "User > already exists". Trying to use "forgotten password" feature gave me > information that my account was not activated. What could I do with > this? I was working on Wine some time without this, but now testbot > account would be very helpful for me. Sorry about that, I must have missed the notification when you first registered. I have now activated your account (you should have received an e-mail about it), just let me know if you still encounter problems. You can either reply directly to this email or use the Feedback link on the website to contact me. Ge.

1 0

Assertion in winebuild
by André Hentschel Sept. 12, 2010

Sept. 12, 2010

Hi, I run in the assertion in function output_stubs in winebuild/import.c obsiouly not on x86/x86_64, but in my rebased(to a more recent wine tree) ARM build in dlls like msvcp80, msvcp90 and up, but not msvcirt or msvcrt and the normal others like ntdll and so on. So i wonder: - how x86/x86_64 are treated different. (really couldn't trace that down, see below) - what is different with e.g. msvcp80 so that non-x86/x86_64 builds get into the assertion? As i can see it is always called in function BuildSpec32File in spec32.c, so some values seem to be modified on non-x86/x86_64 e.g. odp->type -- Best Regards, André Hentschel

1 0

Problem with geting account at testbot
by Mariusz Pluciński Sept. 12, 2010

Sept. 12, 2010

Hello I have a problem with my account at testbot.winehq.org. Long time ago, I registered my account. To this day I have not received an activation e-mail. I thought it was maybe rejected, because I was not "well-known member of the Wine community" that time. Today I noticed that I can not send request for account, because "User already exists". Trying to use "forgotten password" feature gave me information that my account was not activated. What could I do with this? I was working on Wine some time without this, but now testbot account would be very helpful for me. Mariusz Pluciński

2 1

Release plans
by Alexandre Julliard Sept. 12, 2010

Sept. 12, 2010

Folks, There won't be a release this week, since I'll be spending my Friday on an airplane. Release 1.1.44 will be next Friday. If all goes well and I can finish the few remaining bits of 64-bit support, it should be the last release of the 1.1.x series. We'll then enter code freeze and start the 1.2-rc series. The 1.2 final release should thus happen hopefully sometime in June. -- Alexandre Julliard julliard(a)winehq.org

1 0

Macro names instead of numbers in logs
by Florian Köberle Sept. 12, 2010

Sept. 12, 2010

Hello when running a program using wine it's possible to log +message to get informed about all the messages which get sent. This debug channel displays the macro names like WM_NOTIFY instead of numbers. The most other debug channels and the regression tests however display numbers. Functions like SPY_GetMsgName which can make window messages more human readable can be found in dlls/user32/spy.c. Is there a acceptable way of making functions like SPY_GetMsgName available to other libraries and tests? There are about 80 TRACE/trace lines which could be improved: egrep "trace.*hwnd.*lParam" dlls/ -R -i -I|grep -v user32|wc Best regards, Florian

5 10

Keeping people from trying iTunes in Wine?
by Dan Kegel Sept. 11, 2010

Sept. 11, 2010

Watching Twitter, one fairly frequently seems people trying and failing to run iTunes 10 and the like in Wine. Should we let them bash their heads against the wall like that? Maybe we should detect the top ten apps that don't work with Wine, and put up a warning dialog saying they are known not to work, and people shouldn't try. (Kind of like what Windows 7 does when you do something dangerous, e.g. try to look at the contents of drive C:.)

15 19

Re: [PATCH 2/3] wined3d: store amount of video memory in gpu_description_table
by Rico Schüller Sept. 11, 2010

Sept. 11, 2010

Am 11.09.2010 03:59, schrieb Roderick Colenbrander: > /* Geforce 300 midend mobile (Geforce GT 325M/330M use the same core) */ > if (strstr(gl_renderer, "GT 325M") > || strstr(gl_renderer, "GT 330M")) > { > - *vidmem = 1024; > - return CARD_NVIDIA_GEFORCE_GT325M; > + return CARD_NVIDIA_GEFORCE_GT325M; > } > > /* Geforce 200 - midend */ > if (strstr(gl_renderer, "GT 240")) > { > - *vidmem = 512; > return CARD_NVIDIA_GEFORCE_GT240; > } > > /* Geforce 200 lowend */ > if (strstr(gl_renderer, "GT 220")) > { > - *vidmem = 512; /* The GT 220 has 512-1024MB */ > return CARD_NVIDIA_GEFORCE_GT220; > } > /* Geforce 200 lowend (Geforce 305/310 use the same core) */ > @@ -1461,7 +1459,6 @@ static enum wined3d_pci_device select_card_nvidia_binary(const struct wined3d_gl > || strstr(gl_renderer, "Geforce 305") > || strstr(gl_renderer, "Geforce 310")) > { > - *vidmem = 512; > return CARD_NVIDIA_GEFORCE_210; > } > > Hi Roderick, you probably might fix the whitespaces for all occurrences. Cheers Rico

1 0

Does testbot's MingW miscompile winmm:midi tests?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 11, 2010

Sept. 11, 2010

Hi, on test.winehq, WinME systems always report 8 rc=MMSYSERR_INVALPARAM errors. However, when running a MSVC compiled binary (as found in testbot job #4990), no such error occurs. Paul Vriens wrote: >I only see those 8 errors with the winetest executable from >test.winehq.org. My own cross-compiled version is fine, no errors there. Likewise, Octavian Voicu's machines saw no failure with the MSVC binary, but constantly produce red color on testbot. This could - Either be a bug in testbot's MingW (compilation or includes)? What's the difference between testbot compilation and Paul Vriens'? - Some weird memory corruption affecting only WinME? - a bug in my tests? Those INVALPARAM errors happen since May. However my May-19 patch did not change the tests that since fail, so it must be a side effect of something else. 1. dwBytesRecorded is left uninitialised, which may produce random results -- if it were used. 2. dwOffset is now set to 0xDEADBEEF; previously uninitialised. Yet that does not explain why MSVC's and Paul's cross compiled binary succeed. Paul and I found a bug in the mingw includes once. Perhaps that's another instance? How to proceed from here? Jörg Höhle

3 4

Re: msxml3: Implement property SelectionNamespaces for XPath (try #2)
by testbot＠testbot.winehq.org Sept. 10, 2010

Sept. 10, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5183 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6044: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6044: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6044: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [PATCH] Fixed a couple of cases where the console was not reset in cooked mode after a bare console has been created
by Juan Lang Sept. 10, 2010

Sept. 10, 2010

Hi Eric, minor quibble on this patch: #ifdef HAVE_TERMIOS_H # include <termios.h> #endif +#ifdef HAVE_TERMIOS_H +#include <termios.h> +#endif This hunk isn't needed. --Juan

1 0

re: UCS-4 hack not working in resource files.
by Dan Kegel Sept. 10, 2010

Sept. 10, 2010

Please file a bug with a simple example of an rc file that doesn't work.

1 0

UCS-4 hack not working in resource files.
by carlo.bramix＠libero.it Sept. 10, 2010

Sept. 10, 2010

Hello friends, I would like to talk a bit about a (probable) limitation with unicode names when they are used for creating embedded controls in resource files. Let's take for example this piece of code from richedit.h: #if defined(__GNUC__) # define RICHEDIT_CLASS20W (const WCHAR []){ 'R','i','c','h','E','d','i','t','2','0','W',0 } #elif defined(_MSC_VER) # define RICHEDIT_CLASS20W L"RichEdit20W" #else static const WCHAR RICHEDIT_CLASS20W[] = { 'R','i','c','h','E','d','i','t','2','0','W',0 }; #endif Because the famous UCS-4 "issue", the control name is splitted in its single letters. While this can work in almost all situations with C/C++ sources, it is absolutely not possible to put a richedit control in RC files. For example, if I put a Richedit control into a dialog box, it will crash since the letter by letter format won't be recognized by the resource compiler. >From the above example, I was wondering what you think about doing a change like this one: #if defined _MSC_VER || defined RC_INVOKED || sizeof(wchar_t) == 2 # define RICHEDIT_CLASS20W L"RichEdit20W" #elif defined(__GNUC__) # define RICHEDIT_CLASS20W (const WCHAR []){ 'R','i','c','h','E','d','i','t','2','0','W',0 } #else static const WCHAR RICHEDIT_CLASS20W[] = { 'R','i','c','h','E','d','i','t','2','0','W',0 }; #endif We will fall in the first case when the name expressed as string is currently recognized: 1) because we are running under Microsoft Visual C++ 2) because it is used by resource compiler 3) because the string format is currently safe since we are under UCS-2 instead of UCS-4. Perhaps this point is not written as good as you want... I do not know if you prefer to use some informations emitted by configure script or you will prefer to simply check the size of wchar_t. The second case is the specific hack normally used until now with GCC. The third case is the last chance solution, as it was before. I moved the __GNUC__ case after the one used by _MSC_VER because __GNUC__ and RC_INVOKED are both declared in windres. Now I took this fragment from richedit.h as example, but perhaps I have also seen other places where the resource compiler could be "rejected". I believe that this fix actually seems to be very helpful for porting some win32 apps. What do you think? Sincerely, Carlo Bramini.

1 0

Re: fusion:asmname Improve parse_display_name
by Alexandre Julliard Sept. 10, 2010

Sept. 10, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -522,8 +522,18 @@ static HRESULT parse_display_name(IAssemblyNameImpl *name, LPCWSTR szAssemblyNam > if (!str) > return E_OUTOFMEMORY; > > - ptr = strstrW(str, separator); > - if (ptr) *ptr = '\0'; > + ptr = strchrW(str, ','); > + > + if(ptr && *ptr != ' ') > + *ptr = '\0'; It's unlikely that you would get a space here... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: Update Italian translation (try 2)
by Paul Vriens Sept. 10, 2010

Sept. 10, 2010

On 09/09/2010 07:52 PM, Luca Bennati wrote: > Fix for Paul's comment > Hi Luca, You forgot the patch. -- Cheers, Paul.

1 0

dogfood report: Safari runs youtube, firefox doesn't
by Dan Kegel Sept. 9, 2010

Sept. 9, 2010

So I wanted to quickly try youtube in wine to verify sound was working. I think I used to use Firefox for this, so I did sh winetricks firefox flash and fired it up... but it hung. (And it even hung my desktop once; had to use CTL ALT F1, kill firefox, and ALT F7 to recover. It must have hung while holding an X grab, that mysterious problem described in http://bugs.winehq.org/show_bug.cgi?id=23439#c7 ) Sad face. Happily, sh winetricks safari got me a working browser that can do youtube just fine.

3 3