September 2010 - Wine-Devel

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

CD-ROM ioctl support on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com June 6, 2011

June 6, 2011

Hi, what's the state of CD-ROM support on the Mac? ntdll/cdrom.c contains quite a few #ifdef apple. I'm asking because the mcicda currently uses these ioctl: 1. READ_RAW 2. READ_TOC 3. READ_Q -> POSITION MCICDA could be changed to avoid the third one entirely -- when using the dsound output. Would that be enough to use mcicda on MacOS to play music? Thanks for your help, Jörg Höhle

2 3

Two enhancement requests for winetricks
by Dan Kegel Feb. 21, 2011

Feb. 21, 2011

OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

6 11

USB Device Support
by James Mckenzie Feb. 19, 2011

Feb. 19, 2011

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang Jan. 8, 2011

Jan. 8, 2011

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Re: Wine: Use GCC's -Wlogical-op if supported.
by Alexandre Julliard Dec. 11, 2010

Dec. 11, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In the past this has found a dozen or two real issues and lead to some > simplifications. Now the tree is clean in that regard, so we can make > this a default. I still see a ton of warnings here (gcc 4.4.5), mostly because of the glibc string macros. -- Alexandre Julliard julliard(a)winehq.org

2 3

Wine runs IE7!
by Hans Leidekker Nov. 26, 2010

Nov. 26, 2010

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 21, 2010

Oct. 21, 2010

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Ongoing Debian package maintenance.
by Ben Klein Oct. 14, 2010

Oct. 14, 2010

Hello everyone, My health has not improved at all since my last call for help with the Debian package management. I really need someone to take over from me, or at least some help to devise a new set of (semi-)automated build scripts. Any volunteers? Kind regards, Ben

5 11

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.
by Alexandre Julliard Oct. 11, 2010

Oct. 11, 2010

Jeff Cook <jeff(a)deserettechnology.com> writes: > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > } > > /* Add master channel, uncounted channels and an extra for capture */ > - mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + 1; > + /* Do not add the extra channel needed for capture on half-duplex capture cards > + like snd_usb_audio mics */ > + if (micelem && !mastelem && !captelem) > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem; > + else > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem + 1; This statement wasn't exactly clear before, but now it's really impossible to follow. Please rewrite this in a way that makes sense to a casual reader. -- Alexandre Julliard julliard(a)winehq.org

4 3

Debugging 64-bit Wine Apps with winedbg
by Tom Grubbe Oct. 9, 2010

Oct. 9, 2010

Hello, we're the developers of a large 64-bit Windows application that uses Wine 1.3.0 64-bit on Linux. When testing began we discovered several crashes inside our windows code on startup and needed to debug them. But the problem seems to be getting any kind of stack trace information from the 64-bit winedbg. This used to work with the 32-bit version of winedbg. Even if I write a 64-bit "hello world" app that intentionally crashes I still can't get a clean stack trace from winedbg. We get a register dump and a stack dump but no back trace. So in our app, we have to resort to calculating the address of the crash in our DLLs using a MAP file and adding a bunch of printfs to try and locate the source of the SEGV. This is awkward, slow and just a bad way to debug. So here's my question - Has anyone had any luck getting a debugger stack trace using the 64-bit winedbg? Some relevant info: * We build wine 64-bit 1.3.0 ourselves * We're running on RHEL 5.5 (Tikanga) 2.6.18-194.el5 64-bit * We get the same non-results from both release and debug windows binaries * Using winedbg --gdb crashes gdb * We tried using msvsmon.exe to attach to and debug the wine process using Visual Studio but it hasn't been helpful * Setting WINEDEBUG to several debug channels has helped some but is difficult to sift through all the noise So any info on strategies to debug 64-bit Wine applications is welcome, or if you need more info I'll be glad to supply it. Thanks for your help! --Tom Grubbe ESRI

4 6

Wineconf 2010: You're running out of procrastination time...act now! Supplies are limited!
by Jeremy White Sept. 30, 2010

Sept. 30, 2010

Alright, we're now down to about six weeks out. Soon, flights and the rooms will go up in price. So book your travel now! One new favor - if you are coming, please RSVP here: http://www.winehq.org/wineconf/rsvp/ so we can have counts for meals and such. Again, if money is an issue, please write to me; the Wine Party Fund may be able to help. And, as always, the Wiki page has the latest scoop: http://wiki.winehq.org/WineConf2010 and most chatter is happening on the wineconf(a)winehq.org mailing list (except for pushy loud mouthed types like myself :-/). Cheers, Jeremy

1 0

Re: [PATCH 1/4] gameux: initial implementation of loading game statistics
by Alexandre Julliard Sept. 30, 2010

Sept. 30, 2010

Mariusz Pluciński <vshader(a)gmail.com> writes: > +static BOOL GAMEUX_isFileExists(LPCWSTR sFile) > +{ > + HANDLE hFile; > + > + hFile = CreateFileW(sFile, GENERIC_READ, 0, > + NULL, OPEN_EXISTING, 0, NULL); > + > + if(hFile == INVALID_HANDLE_VALUE) > + return FALSE; > + > + CloseHandle(hFile); > + return TRUE; > +} This sort of thing is not a good idea in general, even if it had a more grammatically correct function name ;-) If you need to load a file you have to open it anyway, so you can check for errors at that point. Checking for existence beforehand is only doing duplicate work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Error path issues with "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics."
by Joris Huizer Sept. 30, 2010

Sept. 30, 2010

Hello, I noticed the committed patch "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics." (5cac9d2cb2c020802a56a5b1b28348316f1087ba) The GAMEUX_getAppIdFromGDFPath() function now ends with: + HeapFree(GetProcessHeap(), 0, lpRegistryPath); + + TRACE("found app id: %s, return: %#x\n", debugstr_w(lpApplicationId), hr); + return hr; In most of the error paths, lpRegistryPath is not initialized, so it's pointing to garbage; I think just initializing to NULL should be sufficient; Similarly, in that case, lpApplicationId is not initialized, so it contains garbage; Tracing will probably print some random stack bytes before hitting a zero byte. I'm not completely sure what should be done about this issue; I think it should probably only be traced on success, perhaps tracing the error otherwise; Any ideas? HTH, Joris

2 1

Re: [PATCH 2/2] msxml3: implement preserveWhiteSpace property
by Alexandre Julliard Sept. 30, 2010

Sept. 30, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define WS_CHECK_IGNORED(doc) \ > + ole_check(IXMLDOMDocument2_selectNodes(doc, _bstr_("//*[local-name()='html']"), &list));\ > + ole_check(IXMLDOMNodeList_get_item(list, 0, &node1));\ > + ole_check(IXMLDOMNodeList_get_item(list, 1, &node2));\ > + ole_check(IXMLDOMNodeList_reset(list));\ > + expect_list_and_release(list, "E1.E4.E1.E2.D1 E2.E4.E1.E2.D1");\ > + \ > + ole_check(IXMLDOMNode_get_childNodes(node1, &list));\ > + expect_list_and_release(list, "T1.E1.E4.E1.E2.D1 E2.E1.E4.E1.E2.D1 E3.E1.E4.E1.E2.D1 T4.E1.E4.E1.E2.D1 E5.E1.E4.E1.E2.D1");\ > + IXMLDOMNode_Release(node1);\ > + ole_check(IXMLDOMNode_get_childNodes(node2, &list));\ > + expect_list_and_release(list, "T1.E2.E4.E1.E2.D1 E2.E2.E4.E1.E2.D1 T3.E2.E4.E1.E2.D1 E4.E2.E4.E1.E2.D1 T5.E2.E4.E1.E2.D1 E6.E2.E4.E1.E2.D1 T7.E2.E4.E1.E2.D1");\ > + IXMLDOMNode_Release(node2) Please don't write such large macros. Put this in a helper function instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msxml3/httprequest: Add basic bind callback for moniker binding (try2)
by Alexandre Julliard Sept. 30, 2010

Sept. 30, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +#define DEFINE_THIS2(cls,ifc,iface) ((cls*)((BYTE*)(iface)-offsetof(cls,ifc))) > +#define DEFINE_THIS(cls,ifc,iface) DEFINE_THIS2(cls,lp ## ifc ## Vtbl,iface) Don't do that, follow the standard impl_from_xxx inline function pattern. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11: Add support for animated cursors in X11 driver (try 4).
by Alexandre Julliard Sept. 30, 2010

Sept. 30, 2010

Erich Hoover <ehoover(a)mines.edu> writes: > + /* Build an X cursor out of all of the frames */ > + if (!(images = pXcursorImagesCreate( nFrames ))) goto cleanup; > + for (images->nimage = 0; images->nimage < nFrames; images->nimage++) > + images->images[images->nimage] = imgs[images->nimage]; > wine_tsx11_lock(); > - cursor = pXcursorImageLoadCursor( gdi_display, image ); > - pXcursorImageDestroy( image ); > + cursor = pXcursorImagesLoadCursor( gdi_display, images ); > wine_tsx11_unlock(); > + pXcursorImagesDestroy( images ); /* Note: XcursorImagesDestroy is called on each frame */ The note isn't clear, does it destroy the individual images or not? Either way your cleanup code needs more work. > +cleanup: > + /* Cleanup all of the resources used to obtain the frame data */ > + if (imgs && !cursor) > + { > + int i; > + > + for (i = 0; i < nFrames; i++) > + pXcursorImageDestroy( image ); And this can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Backtraces in crash window
by Jerome Leclanche Sept. 30, 2010

Sept. 30, 2010

Adding copypastable backtraces to the crash window might go a long way to prevent this sort of attachments: http://bugs2.winehq.org/attachment.cgi?id=31033 Maybe under a "Crash information" link or something similar. It wouldn't always do the trick (seeing as most of the time the error only shows in the fixmes, if not the traces), but at least it would get rid of some completely useless attachments, imho. Has this been discussed before? J. Leclanche

2 1

Need to retrieve VS_VERSION_INFO for 16, 32, 64 bit windows binaries
by Kapil Arora Sept. 30, 2010

Sept. 30, 2010

Hi, I've created a small executable on windows which calls GetFileVersionInfo() and VerQueryValue() to extract VS_VERSION_INFO from various windows binary files. I want to use this utility under wine on linux system. Everything works fine for most of the files but for some older dlls I'm not getting correct version information. In the wine sources I found some of the functions for previous (16- bit) version info extraction to be stubs. I tried replacing version.dll in $HOME/.wine/drive_c/windows/system32 with the one on my windows XP box but nothing happens. I still don't get complete information. Is there a way to achieve this. Thanks, Kapil.

2 1

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.
by Jacek Caban Sept. 30, 2010

Sept. 30, 2010

Hi Reece, On 9/30/10 12:20 AM, Reece Dunn wrote: > This addresses a fixme in the jscript code that is currently triggered > when running the Big Fish Games client, with a test. if(V_VT(&constr) != VT_DISPATCH) { - FIXME("throw TypeError\n"); + hres = throw_type_error(ctx->parser->script, ei, IDS_OBJECT_EXPECTED, NULL); VariantClear(&constr); - return E_FAIL; + return hres; It would be cleaner to clear constr before throw_type_error so that you can return its result directly, without storing it in hres. exception_test(function() {"test" in null;}, "TypeError", -2146823281); exception_test(function() {"test" in nullDisp;}, "TypeError", -2146823281); +exception_test(function() {new null;}, "TypeError", -2146823281); While you're at this, it would be nice to add a test (and fix) for nullDisp and test some other types (eg. undefined and number). Jacek

2 1

Re: Right-To-Left (RTL) languages and Wine
by James Mckenzie Sept. 30, 2010

Sept. 30, 2010

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Sep 29, 2010 11:25 AM >To: Shachar Shemesh <shachar(a)shemesh.biz> >Cc: Paul Vriens <paul.vriens.wine(a)gmail.com>, "'wine-devel(a)winehq.org'" <wine-devel(a)winehq.org> >Subject: Re: Right-To-Left (RTL) languages and Wine > >Shachar Shemesh <shachar(a)shemesh.biz> writes: > >> Did I mention that the automatic mirroring is a broken idea >> implemented in a broken way already? > >What do you consider broken about it? > >> Aside from notepad, for which the difference is very small, and most >> people would regard a default LTR control as the correct behavior >> anyway, what other applications are you concerned over? > >Pretty much all of them. For example, Wordpad has combo boxes in the >toolbars, those won't be RTL without changing the process layout. >Winefile and Regedit have treeviews that would need mirroring, etc. > And Microsoft Office appears different in RTL rather than LTR. I used to work with someone that had the Arabic version of these programs and it would switch from RTL when typing in Arabic to LTR when typing in a Latin-based language. As AJ has stated, there is more to do than just 'mirroring' to get RTL into Wine. I remember this was quite difficult to get into OpenOffice.org as well when I was testing it (I think I still have Hebrew and Arabic test files for Writer in OpenDocument (.odt) format.) James McKenzie

3 3

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.
by testbot＠testbot.winehq.org Sept. 30, 2010

Sept. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5608 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: msxml3/httprequest: Add basic bind callback for moniker binding
by testbot＠testbot.winehq.org Sept. 30, 2010

Sept. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5605 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2917: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2917: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x8000ffff

1 0

Right-To-Left (RTL) languages and Wine
by Paul Vriens Sept. 29, 2010

Sept. 29, 2010

Hi, I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English winmine.exe on an Arabic box (thanks to the testbot) the main window will shows as normal LTR window layout with the menu's left justified as well. So eventhough the locale is set to Arabic it doesn't turn 'everything' into RTL. If we don't change the resource files for the RTL languages, that same logic will give us LTR Wine applications or am I wrong here? -- Cheers, Paul.

4 16

Wanted: small C program to drop all capabilities but cap_sys_ptrace
by Scott Ritchie Sept. 29, 2010

Sept. 29, 2010

Ubuntu 10.10 is coming out soon, and its new kernel settings prevent Wine apps from looking at each others' memory. This breaks World of Warcraft, among other things. See: http://bugs.winehq.org/show_bug.cgi?id=24193 What's needed is a very small shim for Wine that can be setuid 0, but then release all capabilities except what Wine actually needs -- what a normal user has, and cap_sys_ptrace. On an Ubuntu system, this is very similar to what DHCP and PING do -- setuid 0, however they drop all privs except cap_net_rawio at the start. Existing code can be used: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/dapper/dhcp3/dapper/ann… http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/dapper/dhcp3/dapper/ann… Basically, I need someone to write this shim for me. The long term solution is probably to just package Wine such that the wine binary itself has cap_sys_ptrace, however currently Ubuntu has no support for this kind of extended attribute in the packaging system so workarounds like the above for DHCP need to be done. I suspect other distros have similar issues. Thanks, Scott Ritchie

5 6

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Stefan Dösinger Sept. 29, 2010

Sept. 29, 2010

Am 26.09.2010 um 19:51 schrieb Travis Athougies: > + data = compute_shader_fullscreen9(device, vshader_passthru, pshader, quad_geometry, > + D3DFMT_A8R8G8B8, 1, 1); > + > + ok(data[0] == D3DCOLOR_ARGB(0, 0, 255, 255), > + "swizzle_test: Got color %08x (should be 0x0000FFFF)\n", data[0]); You leak the returned data here. On the big picture of this, I don't like the void * blob returned from compute_shader_fullscreen. As far as I can see the only position dependent aspect of HLSL is vpos(or rather, the HLSL equivalent). For all others it would be OK to return a ARGB color. > + /* The Direct3D 9 docs state that we cannot lock a render target surface, > + instead we must copy the render target onto this surface to lock it */ I think you can, if you create it with D3DUSAGE_DYNAMIC | D3DUSAGE_RENDERTARGET. If you want the backbuffer to be lockable you'll need some device creation flag whose name I forgot.

3 5

Re: winex11: Add support for animated cursors in X11 driver (try 2).
by Henri Verbeet Sept. 29, 2010

Sept. 29, 2010

I didn't really look at the patch at all, but that's not how HeapReAlloc() works.

2 1

mshtml and friends
by Reece Dunn Sept. 29, 2010

Sept. 29, 2010

Hi, The current state of support for the Internet Explorer components in Wine is good, but there are applications that don't work with it because they are dependent on more of the functionality provided by Internet Explorer via the WebBrowser control. I have had a scan through some of the mshtml code, and see various things not handled -- such as the onload handler of the HTMLBody element -- but I am not very familiar with this area. I am interested in helping out to improve this area -- my aim is to not require the `winetricks ie6` command to get some of these applications (specifically the Big Fish Games client) to a usable state. Therefore, I am wondering if anyone knows where the best place is to start looking (e.g. known areas of missing functionality) or how to debug applications (and interpret WINEDEBUG output) to identify where the issues are. Thanks, - Reece

2 7

Re: [PATCH] mshtml: implement ActiveScriptSite_OnScriptError.
by Jacek Caban Sept. 29, 2010

Sept. 29, 2010

On 9/29/10 9:39 AM, Reece Dunn wrote: > Hi, > > This reports any errors sent to the mshtml ActiveScriptSite > OnScriptError handler to the user and traces it to ERR to aid > debugging. static HRESULT WINAPI ActiveScriptSite_OnScriptError(IActiveScriptSite *iface, IActiveScriptError *pscripterror) { ScriptHost *This = ACTSCPSITE_THIS(iface); - FIXME("(%p)->(%p)\n", This, pscripterror); - return E_NOTIMPL; + EXCEPINFO excep; + HRESULT hr; + + TRACE("(%p)->(%p)\n", This, pscripterror); + + hr = IActiveScriptError_GetExceptionInfo(pscripterror,&excep); + + ERR("ActiveScript Error: %s source: %s\n", + debugstr_w(excep.bstrDescription), debugstr_w(excep.bstrSource)); ERR is not appropriate in this case. + MessageBoxW(NULL, excep.bstrDescription, excep.bstrSource, MB_OK|MB_ICONERROR); This is not how this function should work. If you want to implement it, please start with a test case. It probably should fire onerror event. Jacek

2 1

Re: wined3d: Keep track of textures projection state in compiled pixel shaders. [try 2]
by Henri Verbeet Sept. 29, 2010

Sept. 29, 2010

On 28 September 2010 23:07, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > You still need to use this state in the shader backends, instead of getting it from the stateblock.

1 0

winscard.dll
by viny Sept. 29, 2010

Sept. 29, 2010

Hi all, Is anyone working on winscard.dll ? If not, may I propose patches ? I would like to have a working winscard.dll in wine. -- Vincent

7 10

Wine and security
by Dan Kegel Sept. 29, 2010

Sept. 29, 2010

I keep seeing people asking about wine and security, e.g. http://bugs.winehq.org/show_bug.cgi?id=24550 or http://forum.winehq.org/viewtopic.php?t=9770 or https://answers.launchpad.net/ubuntu/+source/wine/+question/59148 ... It seems worth listing the things one can do to partially lock down wine, so I started a page at http://wiki.winehq.org/SecuringWine which is appropriately morose, yet lists a few things one could do if one really wanted to. Corrections or additions welcome.

2 1

Re: comctl32/tab: Fix DRAWITEMSTRUCT filling when extra item data of a custom size is used (try2)
by testbot＠testbot.winehq.org Sept. 29, 2010

Sept. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5580 Your paranoid android. === W98SE (32 bit tab) === tab.c:1354: Test failed: got 0xdedede, expected 0xdededede === W7PROX64 (64 bit tab) === tab.c:1354: Test failed: got 0xdededede, expected 0xdededede

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try3)
by testbot＠testbot.winehq.org Sept. 29, 2010

Sept. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5575 Your paranoid android. === WVISTAADM (32 bit win) === win.c:835: Test failed: wrong dwStyle: 84cb0000 != 94cb0000 for 000201C0 in hook HCBT_MINMAX win.c:3236: Test failed: Expected GetUpdateRect to return non-zero, got 0 win.c:3237: Test failed: Update rectangle is empty! win.c:3581: Test failed: pixel should be black, color is ffffffff win.c:3601: Test failed: pixel should be black, color is ffffffff win.c:3643: Test failed: wrong update region win.c:3656: Test failed: wrong update region win.c:3674: Test failed: wrong update region win.c:3684: Test failed: wrong update region in excessive scroll win.c:3706: Test failed: wrong update region win.c:3715: Test failed: wrong update region win.c:3724: Test failed: wrong update region win.c:3739: Test failed: wrong update region win.c:3819: Test failed: pixel should be black, color is ffffffff win.c:3823: Test failed: pixel should be black, color is ffffffff win.c:3831: Test failed: rects do not match (0,0-0,0) / (0,0-100,100) win.c:3838: Test failed: wrong update region win.c:3848: Test failed: wrong update region win.c:2322: Test failed: rgn right 0 not inside win rect -31700 win.c:2324: Test failed: rgn bottom 0 not inside win rect -31700 === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = 00000000 win.c:2684: Test failed: GetFocus() = 00000000 win.c:2710: Test failed: GetActiveWindow() = 00000000 win.c:2710: Test failed: GetFocus() = 00000000 win.c:2769: Test failed: GetActiveWindow() = 00000000 win.c:2769: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > + ok( environ != NULL, "Expected the environ global variable to be initialized on startup\n" ); > + ok( _wenviron != NULL, "Expected the _wenviron global variable to be initialized on startup\n" ); This won't test what you want, importing variables is not supported on Wine, you have to load the variables explicitly with GetProcAddress, -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] winex11: Add support for animated cursors in X11 driver.
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -508,35 +517,90 @@ static Cursor create_xcursor_cursor( HDC hdc, ICONINFO *icon, int width, int hei > info->bmiHeader.biYPelsPerMeter = 0; > info->bmiHeader.biClrUsed = 0; > info->bmiHeader.biClrImportant = 0; > - GetDIBits( hdc, icon->hbmColor, 0, height, image->pixels, info, DIB_RGB_COLORS ); > + hbmColor = CreateDIBSection( hdc, info, DIB_RGB_COLORS, (VOID **) &mem_bits, NULL, 0); > + if (!hbmColor) > + { > + ERR("Failed to create DIB section for image!\n"); > + goto cleanup; > + } > + SelectObject( hdc, hbmColor ); > + if (!DrawIconEx( hdc, 0, 0, icon, width, height, istep, NULL, DI_NORMAL )) > + { > + TRACE("Could not draw frame %d (walk past end of frames).\n", istep); > + goto cleanup; > + } > + memcpy(image->pixels, mem_bits, info->bmiHeader.biSizeImage); You should be reusing the info, DC and bitmap objects for all frames instead of always recreating everything from scratch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: widl: Explicitly declare default function's calling convention to avoid win64 problems.
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -369,7 +369,7 @@ static void write_type_v(FILE *h, type_t *t, int is_field, int declonly, const c > if (type_get_type_detect_alias(pt) == TYPE_FUNCTION) { > int i; > const char *callconv = get_attrp(pt->attrs, ATTR_CALLCONV); > - if (!callconv && is_object_interface) callconv = "STDMETHODCALLTYPE"; > + if (!callconv) callconv = is_object_interface ? "STDMETHODCALLTYPE" : "__cdecl"; It may be useful to be able to declare functions that use the native calling convention, I don't think we want to prevent that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().(try 2)
by Henri Verbeet Sept. 28, 2010

Sept. 28, 2010

2010/9/27 Rico Schüller <kgbricola(a)web.de>: > !strcmp("unrecognized", debug_d3dcompiler_d3d_blob_part(part)) Oh, and please don't do that, I think it's very fragile.

1 0

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().(try 2)
by Henri Verbeet Sept. 28, 2010

Sept. 28, 2010

2010/9/27 Rico Schüller <kgbricola(a)web.de>: > --- Wouldn't it be nicer if the "count" parameter to dxbc_init() was more of a hint? I.e., allow the sections array to grow if needed. For parse_dxbc() this works fine, because you know the number of sections in advance, but as you must have noticed, for creating the destination blob it's much more inconvenient.

1 0

Re: [PATCH 2/6] msxml3: ignore whitespace nodes
by Nikolay Sivov Sept. 28, 2010

Sept. 28, 2010

On 9/28/2010 05:37, Adam Martinson wrote: > From 1f8661342ae63290f212429e382b5776e07b9ebc Mon Sep 17 00:00:00 2001 > From: Adam Martinson<amartinson(a)codeweavers.com> > Date: Mon, 27 Sep 2010 19:29:04 -0500 > Subject: [PATCH 2/6] msxml3: ignore whitespace nodes > > --- > dlls/msxml3/msxml_private.h | 15 +++++++++++++++ > dlls/msxml3/node.c | 9 +++++++++ > dlls/msxml3/nodelist.c | 8 ++++++-- > dlls/msxml3/tests/domdoc.c | 14 ++++++++++++++ > 4 files changed, 44 insertions(+), 2 deletions(-) This should be affected by ::preserveWhiteSpace() property I guess.

2 1

Re: ws2_32(3/3): Implement WSAIoctl for SIO_ROUTING_INTERFACE_QUERY
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Juan Lang <juan.lang(a)gmail.com> writes: > This one may cause test failures on systems that don't have a route to > the loopback address. As far as I can tell, Windows systems always > have such a route, whereas on *ix it isn't guaranteed. I'm not sure > how to handle that, as broken() isn't allowed for Wine, and such a > networking configuration is at least strange. If it's really always present on Windows and apps depend on it, you'll have to fake a route. Otherwise just don't test it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32/tests: Send zero byte to any connected IrDA device (resend)
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > Test for bug #19397. > Test only executed, if remote IrDA device is present. > Otherwise test is skipped. (Proposal from Mike Kaplinskiy) I'm not sure this is very useful. It's unlikely to be run on any of the test boxes, and AFAICS this is a kernel bug anyway, it should be a Unix test case not a Wine one. -- Alexandre Julliard julliard(a)winehq.org

1 0