September 2010 - Wine-Devel

Re: [2/3] comctl32/tab: Fix DRAWITEMSTRUCT filling when large enough extra item data is used (try2)
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix DRAWITEMSTRUCT filling when large enough extra item data is used I'd like to see a test with smaller sizes too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (still try3)
by Jacek Caban Sept. 28, 2010

Sept. 28, 2010

Hi Nikolay, + entry = heap_alloc(sizeof(*entry)); + if (!entry) return E_OUTOFMEMORY; + + /* new header */ + list_add_head(&This->reqheaders,&entry->entry); + + return S_OK; It seems like filling the new header's name and value is missing here. Jacek

1 0

Re: [1/2] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()
by Jacek Caban Sept. 28, 2010

Sept. 28, 2010

Hi Nikolay, On 9/28/10 1:30 PM, Nikolay Sivov wrote: > Resent for series completeness. + hr = VariantChangeType(&str,&user, 0, VT_BSTR); + if (hr == S_OK) + { + This->user = SysAllocString(V_BSTR(&str)); + VariantClear(&str); + } You already own the reference to string in str VARIANT, so you can just use it |This->user = V_BSTR(&str);| and remove VariantClear call. + hr = VariantChangeType(&str,&password, 0, VT_BSTR); + if (hr == S_OK) + { + This->password = SysAllocString(V_BSTR(&str)); + VariantClear(&str); + } Same here. Jacek

1 0

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try3)
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try3: fixed some test failures > > Should still be applied over [1/2] patch, let me know if I should > resend both. Yes please, otherwise testbot won't be able to figure out the sequence. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5546 Your paranoid android. === W7PROX64 (64 bit environ) === Timeout

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)
by Dmitry Timoshkov Sept. 28, 2010

Sept. 28, 2010

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > + SetLastError(0xdadadada); > + retval = UpdateWindow(NULL); > + ok( !retval, "Expected 0, got %d\n", retval); > + ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /* win9x */, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); It's better to use a commonly accepted 0xdeadbeef as an invalid last error value, and limit the line length somewhere at 80. -- Dmitry.

3 2

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try2)
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5538 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === W2KPROSP4 (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === WXPPROSP3 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5530 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2683: Test failed: GetActiveWindow() = 00000000 win.c:2683: Test failed: GetFocus() = 00000000 win.c:2709: Test failed: GetActiveWindow() = 00000000 win.c:2709: Test failed: GetFocus() = 00000000 win.c:2768: Test failed: GetActiveWindow() = 00000000 win.c:2768: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd + test
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5529 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2683: Test failed: GetActiveWindow() = 00000000 win.c:2683: Test failed: GetFocus() = 00000000 win.c:2709: Test failed: GetActiveWindow() = 00000000 win.c:2709: Test failed: GetFocus() = 00000000 win.c:2768: Test failed: GetActiveWindow() = 00000000 win.c:2768: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000

1 0

Re: ws2_32(3/3): Implement WSAIoctl for SIO_ROUTING_INTERFACE_QUERY
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5526 Your paranoid android. === W2K3R2SESP2 (32 bit sock) === sock.c:2329: Test failed: gethostbyname("w2k3r2sesp2") returned 127.0.0.1 not 127.12.34.56

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd + test
by Austin English Sept. 27, 2010

Sept. 27, 2010

On Mon, Sep 27, 2010 at 7:27 PM, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, this fixes http://bugs.winehq.org/show_bug.cgi?id=24527 Howdy Louis, + ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || /* win98 */ GetLastError() == 0xdadadada, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); shouldn't that win98 path be enclosed in broken()? -- -Austin

1 0

Re: [1/5] urlmon: Implemented validation of the host name component of a IUriBuilder
by Alexandre Julliard Sept. 27, 2010

Sept. 27, 2010

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > -#define ALLOW_NULL_TERM_SCHEME 0x1 > -#define ALLOW_NULL_TERM_USER_NAME 0x2 > -#define ALLOW_NULL_TERM_PASSWORD 0x4 > +#define ALLOW_NULL_TERM_SCHEME 0x1 > +#define ALLOW_NULL_TERM_USER_NAME 0x2 > +#define ALLOW_NULL_TERM_PASSWORD 0x4 > +#define ALLOW_BRACKETLESS_IP_LITERAL 0x8 > +#define SKIP_IP_FUTURE_CHECK 0x16 > +#define IGNORE_PORT_DELIMITER 0x32 These won't work as flags... -- Alexandre Julliard julliard(a)winehq.org

1 0

Sound on TestBot
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 27, 2010

Sept. 27, 2010

Greg Geldorp wrote: >I've found a way to add a soundcard to most of the TestBot VMs (using >the virtual soundcard driver from VMware View). This is excellent news. It even has MIDI-out! Alas, capture.c:661: found 0 WaveIn devices means that most mci.c tests (which are mostly mciwave tests) are skipped because the tests depend on the ability to record, then play back. mci.c:651: Tests skipped: Please install audio driver. Everything is skipped. Hopefully Francois Gouget will update his vmware machines with these drivers (or the ones Paul Vriens' uses) so that the timeouts will disappear. http://test.winehq.org/data/190c3518d66df44cfa464d8dc1ca3fd50ff6c361/xp_fg-… Earlier this year, Julius Schwartzenberg found out that the timeouts in winmm tests on vmware could be avoided by installing another driver. http://www.winehq.org/pipermail/wine-devel/2010-March/082118.html capture.c:674: Test failed: waveInGetDevCapsA(WAVE_MAPPER): got MMSYSERR_NOERROR capture.c:691: Test failed: waveInGetDevCapsW(1): got MMSYSERR_NOERROR Weird. waveOutGetDevCaps (in wave.c) behaves as expected. Looks like a driver bug. Perhaps one explanation for the WAVE_MAPPER case is found in my mci.c tests: * However some w2k8/w7 machines return no error when there's no wave * input device (perhaps querying waveOutGetNumDevs instead of waveIn?), * still the record command below fails with MCIERR_WAVE_INPUTSUNSUITABLE. * Don't skip here, record will fail below. */ err = mciSendString("set x format tag pcm", NULL, 0, NULL); I should feed testbot a patch to call wave_in_test_device(1) despite numdevs=0 to see what happens. Regards, Jörg Höhle

3 2

Re: [1/3] comctl32/tab: Add a test for TCM_SETITEMEXTRA
by Vitaliy Margolen Sept. 27, 2010

Sept. 27, 2010

On 09/26/2010 05:08 PM, Nikolay Sivov wrote: > Add a test for TCM_SETITEMEXTRA > > > > > +static HWND parent_wnd; > -static void test_curfocus(HWND parent_wnd, INT nTabs) > +static void test_curfocus(void) > { > - hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, nTabs); > + hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, 5); So how is the global better then function parameter? Or a magic number? Vitaliy.

2 3

Re: [4/5] msxml3/httprequest: Store user defined request headers on transaction beginning
by Jacek Caban Sept. 27, 2010

Sept. 27, 2010

Hi Nikolay, On 9/25/10 10:16 PM, Nikolay Sivov wrote: > Store user defined request headers on transaction beginning + buff = CoTaskMemAlloc((size+1)*sizeof(WCHAR)); + if (!buff) return E_OUTOFMEMORY; + + LIST_FOR_EACH_ENTRY(entry,&This->request->reqheaders, struct reqheader, entry) + { + LONG header_size = SysStringLen(entry->header) + SysStringLen(entry->value) + 4 /* colon, space, CRLF */; + + /* get large enough buffer */ + while (freech< header_size) + { + WCHAR *buff2; + + freech += size; + size *= 2; + buff2 = CoTaskMemRealloc(buff, (size+1)*sizeof(WCHAR)); This is very inefficient. You can compute header size before doing allocation, so that no reallocation is needed. And even when doing reallocation, the inner loop may be easily avoided. Jacek

1 0

Re: [1/5] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()
by Jacek Caban Sept. 27, 2010

Sept. 27, 2010

Hi Nikolay, On 9/25/10 10:15 PM, Nikolay Sivov wrote: > Store passed data for IXMLHttpRequest::open() + hr = VariantChangeType(&async,&async, 0, VT_BOOL); + This->async = (hr == S_OK) ? V_BOOL(&async) : FALSE; You mix BOOL and VARIANT_BOOL here. |This->async = (hr == S_OK) && V_BOOL(&async)| will do what you want. + hr = VariantChangeType(&user,&user, 0, VT_BSTR); + if (hr == S_OK) + This->user = SysAllocString(V_BSTR(&user)); You potentially leak here. + hr = VariantChangeType(&password,&password, 0, VT_BSTR); + if (hr == S_OK) + This->password = SysAllocString(V_BSTR(&password)); And here. + { + return SysReAllocString(&entry->value, value) == TRUE ? S_OK : E_OUTOFMEMORY; + You shouldn't compare to TRUE value. This should be |return SysReAllocString(...) ? S_OK : E_OUTOFMEMORY|. + *bind_flags = BINDF_FROMURLMON; Are you sure you need BINDF_FROMURLMON here? This flag is set by urlmon before calling protocol handler. + hr = BindStatusCallback_create(This,&bsc); + if (FAILED(hr)) return hr; + + ERR("%x\n", hr); Debugging code left? Jacek

1 0

Re: d3d9: Add a sRGB format test
by Henri Verbeet Sept. 27, 2010

Sept. 27, 2010

On 25 September 2010 23:45, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + struct > + { > + D3DFORMAT fmt; > + const char *name; > + } > + formats[] = > + { > + { D3DFMT_R5G6B5, "D3DFMT_R5G6B5" }, > + { D3DFMT_X8R8G8B8, "D3DFMT_X8R8G8B8" }, > + { D3DFMT_A8R8G8B8, "D3DFMT_A8R8G8B8" }, > + { D3DFMT_A16B16G16R16F, "D3DFMT_A16B16G16R16F" }, > + { D3DFMT_A32B32G32R32F, "D3DFMT_A32B32G32R32F" }, > + }; This should be static const. I recently fixed a number of these. > + const float quad[] = { > + -1.0, -1.0, 0.1, 0.0, 0.0, > + -1.0, 1.0, 0.1, 1.0, 0.0, > + 1.0, -1.0, 0.1, 0.0, 1.0, > + 1.0, 1.0, 0.1, 1.0, 1.0 > + }; Please use a proper structure?

1 0

hey, saw a job ad that mentions wine!
by Dan Kegel Sept. 27, 2010

Sept. 27, 2010

I do periodic searches in google blogsearch and twitter for references to wine, sometimes I find interesting tidbits that way. Tonight I also tried searching on indeed.com, and one job popped up: http://storagecraft.iapplicants.com/ViewJob-106203.html They're only looking for wine users, but still, it's nice to see.

2 1

Wine test bot failure?
by Travis Athougies Sept. 27, 2010

Sept. 27, 2010

Hi, I was trying to run my HLSL test suite patch through wine test bot and the build failed. However, it's not a compilation failure. Instead it complains about not being able to copy some executable file. Also, the build fails almost instantaneously. It also complains about a missing command. The results are at https://testbot.winehq.org/JobDetails.pl?Key=5449&log_101=1#k101 How can I get this to builid and run? Travis Athougies. -- Travis Athougies

6 9

what's the proper way to define a COM interface that takes function pointers as arguments?
by Vincent Povirk Sept. 26, 2010

Sept. 26, 2010

I am trying to define the ICLRRuntimeHost interface. It has this method: http://msdn.microsoft.com/en-us/library/ms164410.aspx One of the arguments is a function pointer type: http://msdn.microsoft.com/en-us/library/aa964757.aspx Widl fails when I try to define a function pointer type using C syntax. So, what's the proper way to do this? Does widl need to be fixed?

1 1

Re: [PATCH 1/5] gameux: Add implementation of IGameStatistics::SetCategoryTitle
by Nikolay Sivov Sept. 26, 2010

Sept. 26, 2010

On 9/26/2010 16:59, Mariusz Pluciński wrote: > --- > dlls/gameux/gamestatistics.c | 50 > ++++++++++++++++++++++++++++++++++- > dlls/gameux/tests/gamestatistics.c | 14 +++++----- > 2 files changed, 55 insertions(+), 9 deletions(-) > @@ -177,8 +201,30 @@ static HRESULT WINAPI GameStatisticsImpl_SetCategoryTitle( > WORD categoryIndex, > LPCWSTR title) > { > - FIXME("stub\n"); > - return E_NOTIMPL; > + HRESULT hr = S_OK; > + DWORD dwLength; > + GameStatisticsImpl *This = impl_from_IGameStatistics(iface); > + > + TRACE("(%p, %d, %s)\n", This, categoryIndex, debugstr_w(title)); > + > + if(!title || categoryIndex>= MAX_CATEGORIES) > + hr = E_INVALIDARG; Just return here and be done with it, this will save you hr initialization and unnecessary if (SUCCEEDED(hr)) after that. > + > + if(SUCCEEDED(hr)) > + { > + dwLength = lstrlenW(title); > + > + if(dwLength> MAX_CATEGORY_LENGTH) > + { > + hr = S_FALSE; > + dwLength = MAX_CATEGORY_LENGTH; > + } Does it really copy with hr == S_FALSE ? > + > + lstrcpynW(This->stats.categories[categoryIndex].sName, > + title, dwLength+1); > + } > + > + return hr; > } >

2 1

RFC [PATCH] ddraw: Prevent refcount underflow
by Vincent Pelletier Sept. 26, 2010

Sept. 26, 2010

Hi. Attached patch fixes a problem with Beetle Crazy Cup's VideoSetup.exe, which hangs at exit because some code tries to free ddraw surface on which a refcount underflow happened earlier in the execution. Executing it with winedbg shows that the first call causing the underflow is triggered from game's binary: Stopped on breakpoint 3 at 0x7ed494fc ddraw1_Release+0x2c [/home/vincent/git/wine/dlls/ddraw/ddraw.c:476] in ddraw 476 ULONG ref = InterlockedDecrement(&ddraw->ref1); Wine-dbg>print ddraw->ref1 0 Wine-dbg>bt Backtrace: =>0 0x7ed494fc ddraw1_Release+0x2c(iface=0x129e10) [/home/vincent/git/wine/dlls/ddraw/ddraw.c:476] in ddraw (0x0033fd24) 1 0x00401d2c in videosetup (+0x1d2b) (0x0033fd5c) 2 0x0040342b in videosetup (+0x342a) (0x0033fd84) 3 0x004034f5 in videosetup (+0x34f4) (0x0033fda0) 4 0x00402f65 in videosetup (+0x2f64) (0x0033fe04) 5 0x00404a4e in videosetup (+0x4a4d) (0x0033fe90) 6 0x7b8565bc call_process_entry+0xb() in kernel32 (0x0033fea8) 7 0x7b8565bc call_process_entry+0xb() in kernel32 (0x0033fee8) 8 0x7b858a9b start_process+0x5a(peb=0x536430) [/home/vincent/git/wine/dlls/kernel32/process.c:994] in kernel32 (0x0033fef8) 9 0x7bc715f0 call_thread_func+0xb() in ntdll (0x0033ffc8) 10 0x7bc717c0 call_thread_entry_point+0x6f(entry=0x7b858a40, arg=0x7ffdf000) [/home/vincent/git/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0033ffe8) 11 0x7bc4cefa start_process+0x29(kernel_start=0x7b858a40) [/home/vincent/git/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) Points on which I would like opinions: - getting rid of the magic number - need to check after InterlockedDecrement (in doubt I did, but the code is much less readable this way) - couldn't it actually hide a refcount problem in wine ? - if not, then would it be good to extend to other refcounts aswell or include in [a local wrapper for] InterlockedDecrement ? Regards, --- dlls/ddraw/ddraw.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)

2 1

Re: comctl32/treeview: Erase background when painting over supplied hdc
by testbot＠testbot.winehq.org Sept. 26, 2010

Sept. 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5489 Your paranoid android. === W98SE (32 bit treeview) === treeview.c:1293: Test failed: got 0x0

1 0

RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)
by Erich Hoover Sept. 26, 2010

Sept. 26, 2010

I realize it's been some time since I've submitted something for the networking problems with the C&C games, but I believe I've come up with something that resolves the major show-stopping issue that was discussed previously. Here is the original thread, for reference: http://www.winehq.org/pipermail/wine-devel/2009-October/079099.html Specifically, this set of patches is revised to address the problem of throwing away packets destined for the incorrect interface in a multi-threaded/multi-process environment. The approach used here is to create a global (named) POSIX.1-2001 semaphore for each socket with the form wine-ifacelock-FD , where "FD" is the Unix file descriptor corresponding to the socket at hand. These semaphores are only created for UDP sockets bound to a specific interface and are locked/unlocked by both the Wine user-space and the Wine server. These patches are against wine-1.3.3 and are split apart according to function. The most revised portions since the original set are 2/6 (server-side creation of semaphore), 3/6 (locking and unlocking), and 6/6 (server-side locking and unlocking). If I could get some feedback on these patches then I would greatly appreciate it, it'd be really nice to finally get this issue resolved. Thanks in advance! [1/6] ws2_32/tests: Add UDP broadcast tests: http://www.compholio.com/wine-kane/patches/2010-09-18/0001-ws2_32-tests-Add… [2/6] server: Add mechanism for storing an interface ID with a socket: http://www.compholio.com/wine-kane/patches/2010-09-18/0002-server-Add-mecha… [3/6] ws2_32: Patch to selectively bind to interfaces while still allowing broadcast packets: http://www.compholio.com/wine-kane/patches/2010-09-18/0003-ws2_32-Patch-to-… [4/6] ws2_32: Ensure select does not wake up on packets with an interface mismatch: http://www.compholio.com/wine-kane/patches/2010-09-18/0004-ws2_32-Ensure-se… [5/6] ws2_32: Ensure Async WSARecv does not wake up on packets with an interface mismatch: http://www.compholio.com/wine-kane/patches/2010-09-18/0005-ws2_32-Ensure-As… [6/6] server: Ensure Async ReadFile does not wake up on packets with an interface mismatch: http://www.compholio.com/wine-kane/patches/2010-09-18/0006-server-Ensure-As… Erich Hoover ehoover(a)mines.edu

3 6

Request for Assistance/Advice for Richedit EM_SETMARGINS test
by James McKenzie Sept. 25, 2010

Sept. 25, 2010

All: I've been trying to get the attached patch to pass on both the testbot and a copy of WindowsXP that I possess. It appears that the statement in MSDN that the USEFONTINFO information is either incorrect or I'm doing something wrong. The MSDN page for this information is: http://msdn.microsoft.com/en-us/library/bb761649%28VS.85%29.aspx I remember that WindowsXP does have Richedit 3.0 Thank you. James McKenzie

1 0

Re: [5/5] msxml3/httprequest: Implement ::get_status()
by testbot＠testbot.winehq.org Sept. 25, 2010

Sept. 25, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5483 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2922: Test failed: got 0x8000ffff domdoc.c:2939: Test failed: got 0x8000ffff domdoc.c:2945: Test failed: got 0x8000ffff domdoc.c:2961: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x00000000 domdoc.c:3003: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2922: Test failed: got 0x8000ffff domdoc.c:2939: Test failed: got 0x8000ffff domdoc.c:2945: Test failed: got 0x8000ffff domdoc.c:2961: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x00000000 domdoc.c:3003: Test failed: got 0x8000ffff === WXPPROSP3 (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000

1 0

Re: [3/5] msxml3/httprequest: Add basic bind callback for moniker binding
by testbot＠testbot.winehq.org Sept. 25, 2010

Sept. 25, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5482 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2930: Test failed: got 0x8000ffff domdoc.c:2936: Test failed: got 0x8000ffff domdoc.c:2964: Test failed: got 0x00000000 domdoc.c:2979: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2930: Test failed: got 0x8000ffff domdoc.c:2936: Test failed: got 0x8000ffff domdoc.c:2964: Test failed: got 0x00000000 domdoc.c:2979: Test failed: got 0x8000ffff === WXPPROSP3 (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000

1 0

Memory Management
by Luis Carlos Busquets Pérez Sept. 25, 2010

Sept. 25, 2010

Concerning the e-mail http://www.winehq.org/pipermail/wine-devel/2010-April/082900.html it seems that it is broken because in wine there is no way to ensure that the string will be in the lower 2GB. Actually, according to the Windows Memory Management model: http://www.intellectualheaven.com/Articles/WinMM.pdf only the 2 lower Gb are able to be used in user mode in Windows. So actually in Windows OS you have a way to ensure that all user things will be in the lower 2Gb. Is there something similar in WINE, If not, would it not be logical to replicate also that behaviour, so that then d3dxhandle can rely in the MSB? What is more, if there is not that way to ensure that, and I guess that the d3dxx_xx.dll might rely on that to distinguish between strings and d3dxhandle, there might be cases even using the original d3dx, programmes would crash in wine when the wine implementation allocates strings in memory positions where then MSB = 1.

3 2

Re: [2/5] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader()
by testbot＠testbot.winehq.org Sept. 25, 2010

Sept. 25, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5481 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === W2KPROSP4 (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === WXPPROSP3 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000

1 0

WineAPI wiki status update
by Max TenEyck Woodbury Sept. 25, 2010

Sept. 25, 2010

The wiki is at http://sourceforge.net/apps/mediawiki/wineapi/index.php and this address should *not* require a Sourceforge login. At least one person has complained that this project is too Wine specific. They want it to be more generic. I do *not* plan to remove the Wine specific content, but I have labeled it with the prefix 'Wine/' so there will be space for content specific to other projects. I have to admit that the format is pretty UGLY with too much information crammed into too little space. I have received some suggestions on how this can be improved. I intend to act on those suggestions, but not right now. I need to put the content in and assure that it is correct before I get into aesthetics. If someone wants to help with this, let me know. There are now links to every directory and file in the repository and a mechanism is in place to assure that this will continue to be the case. Significant repository entries have their own wiki pages with at least one place where editable content can be added that will not be over-written by the automatic update process. There are also the usual wiki discussion pages. Most of the file related pages are simply place holders at this time, with the exception of '.spec' file pages. Please see the section below on plans before complaining about this. Statistics (very approximate) 400 Directories 3000 Files 55000 APIs identified Plans and problems. The current maintenance process is based on bash scripts with different scripts doing different parts of the analysis. Scheduling is based on a list of work items. The scripts add work items as they are discovered and remove work items as they are finished. If someone wants to try their hand at them, let me know and I'll post them to the wiki. I expect that re-writes in other languages are in order, but I do bash scripts well. My other strong languages are C and C++. I am very interested in learning Python, Perl and others. Some of the pages are HUGE and cause problems when some wiki operations are tried. In particular there are at least two '.spec' files with more than 8000 entries. The scripts need to be taught how to split these monsters into managable pieces. Some of the APIs are class-object based and their names have been mangled in the usual C++ manner. They are currently displayed in their raw form. De-mangling is needed and a separate hierarchy should be established for indexing them. A section in each standard directory has been set aside to hold API descriptions for each executable but are currently empty (and invisible as a result). Once the names have been de-mangled, I plan to fill in these sections. Header and code analysis are on queue after that, as is improving the page format. There are a bunch of old pages without the 'Wine/' prefix. They are being removed. Advice on wiki-bots would be helpful. - Max

1 0

Re: [PATCH] user32: Update Finnish translation.
by Paul Vriens Sept. 25, 2010

Sept. 25, 2010

On 09/25/2010 03:43 PM, Lauri Kenttä wrote: > Hi! > >> Great to see that someone is picking up the Finnish translations >> again (last real contribution is from 2006). > > I'm a bit sorry I didn't have time for this before the 1.2 release, but > better late than never. :) My girlfriend will maybe send patches as > well. No problem. We are all volunteers and a life besides Wine ;) Two volunteers for Finish is even better. > > I seem to remember that you know a lot about these resource things, so > I'll bother you with a few questions: > > - Is it ok to use the same accelerator key for multiple items? Maybe in > different submenus (File> &Save and Other> &Something)? One shouldn't have the same accelerators in one submenu. Different submenu's with same accelerators is no problem. So your example is correct. Maybe we should teach our resource compiler to warn about duplicate accelerators (or maybe even error out). > > - Is there some easy way to know which strings should NOT be > translated, e.g. "Microsoft\\Windows\\GameExplorer" and "OEM Links" and > such? Or does the resource file contain only the things that basically > should be translated? I guess 99% is translatable. The ones you mention have more to do with how a Finish Windows version would show up. These should be translated if users would otherwise be confused. > > - What about the license? FSF doesn't provide a Finnish version. Which > one is best: English only, unofficial translation only, or both? If there is no official LGPL license in your language, you can just use the English one. > > Thanks for your help. > It's is me/us who should thank you! -- Cheers, Paul.

1 0

parallel make broken somehow
by Marcus Meissner Sept. 25, 2010

Sept. 25, 2010

Hi, + make -j4 depend config.status: creating tools/Makefile config.status: creating tools/Makefile make[1]: Entering directory `/usr/src/packages/BUILD/wine-1.3.3.20100924/tools' gcc -c -I. -I. -I../include -I../include -I/usr/include/freetype2 -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wno-unused-result -DLDAP_DEPRECATED=1 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -o makedep.o makedep.c make[1]: Entering directory `/usr/src/packages/BUILD/wine-1.3.3.20100924/tools' gcc -DLDAP_DEPRECATED=1 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -o makedep makedep.o makedep.o: file not recognized: File truncated collect2: ld returned 1 exit status make[1]: *** [makedep] Error 1 make[1]: Leaving directory `/usr/src/packages/BUILD/wine-1.3.3.20100924/tools It seems we start to build tools/ twice at the same time. Ciao, Marcus

2 1

Re: [PATCH] user32: Implement GetMenuBarInfo
by testbot＠testbot.winehq.org Sept. 24, 2010

Sept. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5468 Your paranoid android. === WVISTAADM (32 bit menu) === menu.c:2115: Test failed: test 13: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 13: GetMenuBarInfo.fFocused (1) is wrong === W7PROX64 (32 bit menu) === menu.c:2115: Test failed: test 21: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 21: GetMenuBarInfo.fFocused (1) is wrong menu.c:2128: Test failed: test 21: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2115: Test failed: test 27: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 27: GetMenuBarInfo.fFocused (1) is wrong menu.c:2128: Test failed: test 27: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2115: Test failed: test 30: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 30: GetMenuBarInfo.fFocused (1) is wrong menu.c:2128: Test failed: test 30: GetMenuBarInfo.fBarFocused (1) is wrong

1 0

Re: [PATCH] ole32: Create a FORMATETC if one is not given in OleCreate
by testbot＠testbot.winehq.org Sept. 24, 2010

Sept. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5461 Your paranoid android. === W98SE (32 bit ole2) === ole2.c:1082: Test failed: Expected draw_continue to be called instead of DataObject_DAdvise ole2.c:1091: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1318: Test failed: Method sequence starting from DataObject_DUnadvise not called ole2.c:1026: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1026: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1026: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1390: Test failed: Method sequence starting from DataObject_GetData not called

1 0

Re: Wine test bot failure?
by James Mckenzie Sept. 24, 2010

Sept. 24, 2010

Travis Athougies <iammisc(a)gmail.com> wrote: > >Hi, > >I was trying to run my HLSL test suite patch through wine test bot and >the build failed. However, it's not a compilation failure. Instead it >complains about not being able to copy some executable file. Also, the >build fails almost instantaneously. It also complains about a missing >command. > >The results are at >https://testbot.winehq.org/JobDetails.pl?Key=5449&log_101=1#k101 > Read the log file from the build failure and fix what it tells you to fix. I've encountered plenty of test failures due to incorrect spellings or missing variables because I did not declare them properly. The alternative is to build the testing file using the same method that the testbot does and using it for the upload. James McKenzie

1 0

Can we please have a "packaging" bugzilla component and not close packaging bugs?
by Scott Ritchie Sept. 24, 2010

Sept. 24, 2010

Sometimes it's not 100% clear whether a problem is in the packaging or upstream part of Wine, and packaging bugs are just as much legitimate problems as normal Wine bugs. WineHQ is often the best place to have that discussion as 1) more than one packager would see it, and 2) if we're doing something wrong a developer can tell us too. I think we discussed this idea last wineconf informally, although I'm not sure anyone committed to making it happen. Thanks, Scott Ritchie

3 2

ie6 download failing
by Dan Kegel Sept. 23, 2010

Sept. 23, 2010

Looks like Microsoft has been letting the ie6 download servers rot. Over the last few weeks, 'winetricks ie6' has been hanging occasionally, and today, it's failing right off the bat with wget http://www.microsoft.com/windows/ie/ie6sp1/download/rtw/x86/ie6sites.dat ... Resolving www.microsoft.com... 65.55.12.249 Connecting to www.microsoft.com|65.55.12.249|:80... connected. HTTP request sent, awaiting response... 500 Internal Server Error Personally, I think it's great that ie6 is getting the shaft, but it does make life with wine a bit more difficult. I hope this error is transient.

2 1

Re: [PATCH 1/3] msxml3: Implement SelectionNamespaces property for XPath
by Alexandre Julliard Sept. 23, 2010

Sept. 23, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > Ignore the previous stuff from me, rebased & split into a patch set. > > From bdc1ce7957ee1be31f4b39484285a164bc4ba6b2 Mon Sep 17 00:00:00 2001 > From: Adam Martinson <amartinson(a)codeweavers.com> > Date: Wed, 22 Sep 2010 14:02:47 -0500 > Subject: [PATCH 1/3] msxml3: Implement SelectionNamespaces property for XPath It fails make test: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok XPath error : Invalid context position xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed domdoc.c:514: Test succeeded inside todo block: IXMLDOMNodeList_get_length(list, &len) returned 0 domdoc.c:520: Test succeeded inside todo block: IXMLDOMNodeList_nextNode(list, &node) returned 0 domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000001) XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed wine: Unhandled page fault on write access to 0x00000000 at address 0x7bc48a27 (thread 001c), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc49c6b make: *** [domdoc.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mscoree: Search for Mono in some predefined paths before using the registry. (try 2)
by Alexandre Julliard Sept. 23, 2010

Sept. 23, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > + /* Last: the registry */ > + return get_mono_path_from_registry(path); You probably want to check the registry first, to make it possible to override the global install if necessary. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 8/8] gameux: IGameStatistics::GetMaxStatsPerCategory implementation
by testbot＠testbot.winehq.org Sept. 23, 2010

Sept. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: configure: Detect resolver functionality on FreeBSD.
by Alexandre Julliard Sept. 23, 2010

Sept. 23, 2010

Tijl Coosemans <tijl(a)coosemans.org> writes: > @@ -1270,13 +1270,12 @@ AC_SUBST(RESOLVLIBS,"") > if test "$ac_cv_header_resolv_h" = "yes" > then > ac_save_LIBS="$LIBS" > - LIBS="$LIBS -lresolv" > - AC_LINK_IFELSE([AC_LANG_PROGRAM([[#ifdef HAVE_NETINET_IN_H > -#include <netinet/in.h> > -#endif > -#include <resolv.h>]],[[res_init();]])], > - [AC_DEFINE(HAVE_RESOLV, 1, [Define if you have the resolver library and header]) > - RESOLVLIBS="-lresolv"]) > + AC_SEARCH_LIBS(res_init, resolv, > + AC_DEFINE(HAVE_RESOLV, 1, [Define if you have the resolver library and header])) > + case "$ac_cv_search_res_init" in > + no*) ;; > + *) RESOLVLIBS="$ac_cv_search_res_init" ;; > + esac This breaks on Linux. res_init() can be a macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/8] gameux: IGameStatistics::GetMaxValueLength implementation
by testbot＠testbot.winehq.org Sept. 23, 2010

Sept. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5430 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/8] gameux/tests: Add test of storing and reading game statistics (try2)
by testbot＠testbot.winehq.org Sept. 23, 2010

Sept. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5426 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 5/8] gameux: IGameStatistics::GetMaxNameLength implementation
by testbot＠testbot.winehq.org Sept. 23, 2010

Sept. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5429 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 4/8] gameux: IGameStatistics::GetMaxCategoryLength implementation
by testbot＠testbot.winehq.org Sept. 23, 2010

Sept. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5428 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/8] gameux: Add stub of IGameStatistics interface implementation (resend)
by testbot＠testbot.winehq.org Sept. 23, 2010

Sept. 23, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5427 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)
by James Mckenzie Sept. 23, 2010

Sept. 23, 2010

-----Original Message----- >From: Ricardo Filipe <ricardojdfilipe(a)gmail.com> >Sent: Sep 22, 2010 1:18 PM >To: wine-devel(a)winehq.org >Subject: Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3) > >2010/9/21 Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com>: >> Thanks for the feedback Alexandre. The complexity of the wine APC & >> I/O system never stops amazing me. Third time's the charm? >> >> try 3: correctly use an apc to free internal async structures (which >> would explain why we have the apc parameter...). Strangely moving >> SetEvent & AddCompletion to the apc makes it not work (...an exercise >> for another time) >> try 2: use the new async i/o callbacks >> --- >> dlls/ws2_32/socket.c | 257 +++++++++++++++++++++++++++++++++++++++++++++- >> dlls/ws2_32/tests/sock.c | 14 ++- >> 2 files changed, 263 insertions(+), 8 deletions(-) >> >> >> >> > >thank you for the perseverence to make this possible in the main tree. > > +1. Thank you Mike. James McKenzie

2 1

Re: [PATCH 2/2] comctl32/tests: Default listview width appears to be 1 inch.
by testbot＠testbot.winehq.org Sept. 22, 2010

Sept. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5396 Your paranoid android. === W2K8SE (32 bit listview) === listview.c:4433: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4438: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === W7PROX64 (32 bit listview) === listview.c:4433: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4438: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)
by Ricardo Filipe Sept. 22, 2010

Sept. 22, 2010

2010/9/21 Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com>: > Thanks for the feedback Alexandre. The complexity of the wine APC & > I/O system never stops amazing me. Third time's the charm? > > try 3: correctly use an apc to free internal async structures (which > would explain why we have the apc parameter...). Strangely moving > SetEvent & AddCompletion to the apc makes it not work (...an exercise > for another time) > try 2: use the new async i/o callbacks > --- > dlls/ws2_32/socket.c | 257 +++++++++++++++++++++++++++++++++++++++++++++- > dlls/ws2_32/tests/sock.c | 14 ++- > 2 files changed, 263 insertions(+), 8 deletions(-) > > > > thank you for the perseverence to make this possible in the main tree.

2 1

Re: [1/2] d3dx9_36: D3DXDeclaratorFromFVF returns D3DERR_INVALIDCALL when an invalid declarator is passed.
by Henri Verbeet Sept. 22, 2010

Sept. 22, 2010

On 22 September 2010 03:26, Misha Koshelev <misha680(a)gmail.com> wrote: > Credit for the idea of comparing the result of D3DXDeclaratorFromFVF > to D3DXFVFFromDeclarator goes to Tony Wasserka: > http://repo.or.cz/w/wine/d3dx9TW.git/blob/Merge:/dlls/d3dx9_36/mesh.c > (see line 405, and his comparison is vice versa - i.e., > D3DXDeclaratorFromFVF to D3DXFVFFromDeclarator) > --- That's insane. Any FVF validation should be done before starting the conversion, not afterwards by calling D3DXFVFFromDeclarator().

2 3