September 2010 - Wine-Devel

Re: [PATCH 1/4] kernel32: add test for WaitForSingleObject with lower 2 bits of handles set
by Paul Vriens Sept. 22, 2010

Sept. 22, 2010

On 09/22/2010 07:53 PM, Peter Oberndorfer wrote: > + if(GetVersion()& 0x80000000) > + { > + win_skip("Handles work differently on win9x\n"); > + return; > + } > + > + signaled = CreateEventW(NULL, TRUE, TRUE, NULL); Hi Peter, You could just as easily check for the last error of CreateEventW which would be ERROR_CALL_NOT_IMPLEMENTED on win9x/winME. This is usually prefered above GetVersion(). I must say that I do see other GetVersion() calls in the kernel32 tests. The fact that you are using win_skip will make the tests fail if you run Wine in Win98 mode, but I guess nobody does that. -- Cheers, Paul.

1 0

Re: mscoree: Search for Mono in some predefined paths before using the registry.
by Alexandre Julliard Sept. 22, 2010

Sept. 22, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > + hfind = FindFirstFileW(wildcard, &find_data); > + > + if (hfind == INVALID_HANDLE_VALUE) return FALSE; > + > + do { > + if (find_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > + { > + strcpyW(mono_path, folder); > + strcatW(mono_path, slash); > + strcatW(mono_path, find_data.cFileName); > + > + found = find_mono_dll(mono_path, mono_dll_path, &abi_version); > + } > + } while (!found && FindNextFileW(hfind, &find_data)); That seems quite dangerous. I don't think we want to use any random mono dll we find, especially in a way where we can't predict which one will be used. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] kernel32: add test for WaitForSingleObject with lower 2 bits of handles set
by testbot＠testbot.winehq.org Sept. 22, 2010

Sept. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5404 Your paranoid android. === W2K8SE (32 bit sync) === sync.c:856: Test failed: DeleteTimerQueueTimer sync.c:857: Test failed: ChangeTimerQueueTimer

1 0

Re: About the Gallium Direct3D 10/11 work
by Luca Barbieri Sept. 22, 2010

Sept. 22, 2010

> I do have a concern which I addressed in the Wine Users mailing list: > > Wine is not only used with Linux, it is also used with other *nix implementations, to include the one that use, MacOSX. Will there be a port to this platform or some > sort of 'hook' that will allow the use of your drivers on this platform. If you want to use the Gallium D3D10/11 implementation on Mac OS X, you will need a Gallium driver that can run on Mac OS X. The software renderers probably already work. For hardware acceleration, my proposal is to write a new Gallium driver that uses OpenGL underneath and can thus run on any platform providing OpenGL. I think that implementing such a Gallium driver is easier than implementing D3D10/11 from scratch, and will also benefit Mesa, since it will be possible to test additions to the Gallium interface without needing to write hardware-specific code or writing software rasterization code. I'm not sure if I'll write such a Gallium driver myself. Contributions would be greatly welcome. It's a fun project and certainly much easier than writing an actual hardware driver. Alternatively, you could port the kernel DRM and drivers to Mac OS X and other systems, but that's much harder and much less user friendly. At any rate, nothing stops Wine from also implementing D3D10/11 using WineD3D or OpenGL, and using that if a Gallium driver is not available. Note however that D3D10/11 are totally different from D3D9, so I'm not sure how much you can share (especially if you want a fast implementation, which may be impossible anyway over OpenGL).

1 0

About the Gallium Direct3D 10/11 work
by Luca Barbieri Sept. 22, 2010

Sept. 22, 2010

> If any one wishes to make any comments I'll include those as well as > contacting Luca Barbieri (?) or who ever is relevant to this over at > Gallium3D. Here I am :) As you have read, this is an initial (but working and with most of the code there) implementation of the D3D10/11 APIs. The plan is to ship all the core interfaces (ID3D10Device, ID3D11Device, ID3D11DeviceContext and supporting ones) in Mesa/Gallium, and make it available to native Linux applications. In addition, some Wine dlls will be provided with just the minimal amount of code to hook the Gallium implementation to Wine's HWNDs. They could be shipped either as part of Mesa or as part of Wine. The initial plan would be to ship them as part of Mesa, but if having anything else than Wine ship Wine DLLs is a problem, this could be revisited. Wine would however need to provide all the non-core APIs, such as D3DX and effects, which I don't think anyone will implement for Gallium. The HLSL compiler might come from the GLSL compiler, especially if the Intel team writing it were to decide to support Cg in addition to GLSL. Alternatively Wine could provide it. In the meantime, Microsoft DLLs will be used for all these. > like the fact that it's C++ C++ dramatically increases productivity, especially when implementing COM interfaces, which in C require a lot of unnecessary boilerplate. >needs X11 windows, The current implementation does, but it's very easy to port to anything else supported by Gallium (currently KMS consoles, fbdev and GDI). > and is limited to Mesa drivers, It's limited to Gallium drivers. If desired, this limitation can be circumvented by writing a Gallium driver that uses GL3/4 underneath. I think this could be the best way forward. Even if Wine were to finish its own D3D10/11 implementation over OpenGL, Gallium would still have its own implementation, because going through OpenGL causes massive unnecessary overhead, reliability problems and difficulty of debugging. Furthermore, this allows to provide Direct3D 10/11 features even if Mesa doesn't yet support the corresponding OpenGL features. In fact it's possible that Mesa will make available features like Direct3D 11 tessellation first in the d3d11 state tracker, and only later in the OpenGL state tracker. >from talking to Luca on IRC it sounds > like this is just the "easy" parts like e.g. resource transfers, > texture format conversion and basic draw calls Not at all. This is a full implementation of ID3D10Device, ID3D11Device, ID3D11DeviceContext and all the interfaces required by them, except for deferred contexts and things not yet supported by Gallium. It should support almost everything in the D3D 9.3 feature level, some of the D3D10.0 feature level and almost nothing of the D3D11 feature level. This is mostly due to the current limitations of Gallium. It includes a shader translator which supports all SM4 opcodes, although not all addressing modes and declarations are supported, and it has been tested quite little. Also some things like resinfo and switch/case/default/endswitch aren't yet implemented by most Gallium drivers. It supports texturing with separate resource and samplers by putting every (resource, sampler) pair in a traditional "texture unit". This will change for DX10 hardware once Gallium gets support for distinct resources and samplers. Of course, it's a very young implementation with almost no tests, so it will surely need a lot of small bug fixes to get fully working. It's much more advanced than the Wine implementation, which apparently doesn't seem to even implement OMSetRenderTargets, which is obviously essential for rendering anything. > The *hard* parts are figuring out things > like the shader and effect formats in a clean way. Both are fully documented. Microsoft ships an header for the shaders and source code for Effects11 at least. Shader parsing is already fully done. The "hard part" is doing the Gallium hardware drivers, and making them competitive with the proprietary ones. Implementing Direct3D 10/11 doesn't really have any truly hard part, just a lot of work, especially for the auxiliary parts like the HLSL compiler, D3DX and effects. >Luca took a bit of > a shortcut there by not doing effects at all, and using the DDK for > the shader format. Yes, and that's seem a reasonable move. Effects can be layered on top of the core API and thus are out of the scope of a Gallium state tracker. > That may or may not be ok, depending on what's > actually in the DDK, but I'm not going to take that risk for no good > reason. As far as I can tell, there is no risk. The EULA doesn't even attempt to prevent alternative implementations and it's just an header file, not source code. As far as I can tell, the DDK license does not seem more restrictive than the Windows SDK one > To my knowledge the effect format > isn't documented anywhere.) As far as I know, Microsoft ships full source code for the Direct3D 11 effects implementation at least, and thus it is fully documented in that. Even if Wine developers don't want to just read the Microsoft source code, you can have someone read it and document it. At any rate, reading source code and implementing based on the ideas learned is perfectly legal. Note however that this has _not_ been done for the code in Gallium, especially because it only implements core APIs, and Microsoft (obviously) doesn't release source code for them at all. Even the C++ IUnknown implementation and COM smart pointer is _not_ based on the ones in ATL or MFC, which I haven't even examined. > Suffice it to say that I'm extremely unhappy with > the way D3D development is currently going. I think this is unjustified. Getting a new, working, Direct3D 10 and 11 implementation seems to me quite a positive thing for Wine. It would be great if we could get past this initial impression and have Mesa and Wine work together on this. If you have any concerns, they can be addressed.

1 0

Re: winspool.drv: Support pDevMode field in {Get/Set}Job
by Detlef Riekenberg Sept. 22, 2010

Sept. 22, 2010

Hi Vitaly. Thanks for fixing printing issues. You use sizeof(DEVMODEW) in you patch, but the correct size is: devmodeW->dmSize + devmodeW->dmDriverExtra You should change the FIXME in the comment of get_job_info_2 to a real FIXME, when unicode is FALSE I'm fine with the unicode - only patch for now, as the related code has to move to localspl later (localspl is unicode only). Thanks -- By by ... Detlef

2 1

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values. Take 2.
by testbot＠testbot.winehq.org Sept. 22, 2010

Sept. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5397 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: USB Device Support
by Damjan Jovanovic Sept. 22, 2010

Sept. 22, 2010

On Wed, Sep 15, 2010 at 1:39 AM, Eric Durbin <eadurbin(a)gmail.com> wrote: > > > On Tue, Sep 14, 2010 at 10:48 AM, Damjan Jovanovic <damjan.jov(a)gmail.com> > wrote: >> >> When last I heard from Alexander Morozov (October 2009), he wasn't >> working on those patches much, and had no interest in sending them to >> wine-patches. >> >> I did some work on USB since then, and sent some patches starting from >> around March 2010 (too many attempts to list, search for them). Most >> were rejected. >> >> The USB story goes as follows: >> >> My libusb patch was rejected IIRC because the libusb situation was >> unclear. There's the old libusb-0.1 and the new more powerful >> libusb-1.0. IIRC each *nix hacked up its own specific variation of >> libusb that had to be detected specifically, and some *nixes didn't >> support the libusb-1.0 interface yet (libusb-1.0 itself only supports >> Linux and MacOS when last I checked, and they were doing a Windows >> port). >> >> The ntoskrnl that Wine currently emulates is total bogus: one process >> per driver, drivers all in separate processes from each other. On >> Windows there's a single address space for all drivers and they can >> communicate amongst themselves. I don't think inter-driver >> communication is that crucial initially, but it will be eventually >> (eg. last I heard, the iPod driver stacks on top of USBSTOR.SYS, and >> multi-function USB devices can use a different driver for each >> interface - these may communicate among themselves with private ioctl >> requests). The big problem with the multi process situation is >> hardware sharing: how do you set it up so each driver accesses its own >> and only its own hardware? >> >> Drivers either start on system startup (Wine starts those with the >> first process that starts), or get loaded on-demand as the hardware is >> plugged in. Most drivers should install themselves to be loaded >> on-demand. Who loads those and how? >> >> Windows uses USBHUB.SYS to do device I/O and load drivers on demand. >> Alexandre didn't want that dll because it exports nothing (all its >> features are accessible via internal ioctls), and suggested adding the >> features to USBD.SYS instead, which we already have and which has >> exports. Now USBD.SYS is linked to by most (but not all) USB drivers >> so (most of the time) it automatically gets loaded into each one - >> great right? - but it has no idea which driver it got loaded with, nor >> a straightforward way to determine which device(s!) that driver wants >> to drive. Also, since most drivers only load on-demand, the driver >> will never load, and thus this won't work unless we load those drivers >> on startup instead. The other approach, which I tried, was to get >> Wine's mountmgr.sys to detect USB devices using HAL, then pass them to >> a loaded-on-startup instance of USBHUB.SYS using a Wine-private ioctl, >> which would detect the driver for the device and launch a new instance >> of itself that would make a device object and load the driver to >> attach to it. This was all a bit a hack (USBHUB.SYS uses environment >> variables to tell the child which device and driver to run) and >> Alexandre also didn't the the Wine-private ioctls. Alexander Morozov's >> patch did things the Windows way: all drivers in one ntoskrnl process >> - this won't work properly in Wine for years, if ever, since ntoskrnl >> is so incomplete and one bad driver will crash them all. Another >> possibility could be to keep drivers in separate processes, but allow >> inter-process communication, but I see serializing IRPs between >> processes as being complex and very slow. >> >> Driver installation is also quite a mission. Windows detects that the >> hardware doesn't have a driver installed, and then generates the >> device ID and compatible IDs and searches .INF files for one that can >> support it. Our setupapi needs to be substantially improved to be able >> to do the same, and some newdev.dll and manual INF parsing work to >> install the driver may also be necessary, and I can already think of >> cases where even class installers will be necessary too :-(. >> >> Wine only sends DeviceIoControl to drivers. For anything non-trivial, >> other file-related user-space functions (at least ReadFile, WriteFile) >> need to go to the driver too. The infrastructure for this does not >> even exist yet, and would probably affects wineserver as well. >> >> Regression tests for ntosnkrl.exe and kernel drivers don't exist, and >> are difficult to come up with, since we'd have to compile and load >> drivers on Windows and run tests that don't crash Windows :-). >> >> So the architecture for USB support is tricky to say the least. But >> I'd still like to resume work on my USB patches some time soon, would >> you like to help? > > I'd be willing to help if you want some assistance. I don't know much about > the subject yet, but I'm reading programming the wdm atm. Firstly I'd like to find a cheap simple USB device that we can actually get working quickly. Earlier I was experimenting with my Blackberry driver, but that's not going far quickly, since it's a multi-protocol device (modem, mass storage, and proprietary protocols, etc.). I've got a USB scanner that's unsupported by SANE, but that needs ReadFile/WriteFile which is a lot of work by itself. Same with USB flash sticks. I can get hold of an iPod but that's probably the most complex, needing to stack on top of USBSTOR.SYS IIRC. Ironically drivers for the easy hardware (USB mice) are unnecessary anyway, since the Linux drivers are good enough, and the Windows drivers probably need to be driven from user-space by bits Wine doesn't have. Maybe I should give up and just get something partially working, add the rest later gradually. Any ideas? Then it's largely a matter of design. I think Alexandre's idea (process per driver, host all USB code in USBD.SYS) is good enough initially. Essentially the first steps would be: 1. libusb integration 2. driver loading hacks 3. driver -> devices lookup 4. usb bus enumeration for devices 5. create pdo and fdo for each device 6. AddDevice to driver 7. perform I/O for IRPs coming down from the driver using libusb I/O functions That should get a very basic driver (that only uses the control pipe) working. I'll try to get some of this done later this week/weekend. Damjan

3 11

D3D via Gallium
by Zachary Goldberg Sept. 22, 2010

Sept. 22, 2010

Hello, I found the following article/commit very interesting this morning. Has anybody else been looking at this and put thought into whether it will work with Wine? http://cgit.freedesktop.org/mesa/mesa/commit/?id=92617aeac109481258f0c3863d… http://www.phoronix.com/scan.php?page=article&item=mesa_gallium3d_d3d11&num… -Zach

5 5

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values.
by Alexandre Julliard Sept. 21, 2010

Sept. 21, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/user32/tests/msg.c | 141 +++++++++++++++++++++++++--------------------- > 1 files changed, 77 insertions(+), 64 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:10881: Test succeeded inside todo block: expected 120,120-210,210 got 120,120-210,210 msg.c:11314: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' make[1]: *** [msg.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] mscoree: Store the AppDomain from CorExeMain, for use in other functions.
by Vincent Povirk Sept. 21, 2010

Sept. 21, 2010

On second thought, please don't commit this. It'll be better to design this around the COM interface in .NET 4, and easier to do that while the current code is simple. On Mon, Sep 20, 2010 at 4:15 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

Re: user32: Make sure that SendInput always initializes the time field.
by Alexandre Julliard Sept. 21, 2010

Sept. 21, 2010

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch should fix the problem reported in the bug 24435. I don't think you want to modify the structure passed by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures
by Alexandre Julliard Sept. 21, 2010

Sept. 21, 2010

Mike Frysinger <vapier(a)gentoo.org> writes: > Newer versions of gcc/glibc with fortify checks enabled will complain > about the handling of the network's szNames field. Currently it is > always defined with a length of one which means writing more then a > single byte will trigger: > In function 'strcpy', inlined from '_ILCreateEntireNetwork' at > dlls/shell32/pidl.c:1762:15: > warning: call to __builtin___strcpy_chk will always overflow destination buffer > and then at runtime, we hit an abort(). > > Since this field is really serving as the header to an arbitrary buffer, > using a flexible array instead should solve the issue. What you want is ANYSIZE_ARRAY, which already exists. -- Alexandre Julliard julliard(a)winehq.org

6 12

Re: kernel32: fix use-after-close in create_process
by Dmitry Timoshkov Sept. 21, 2010

Sept. 21, 2010

Dan Kegel <dank(a)kegel.com> wrote: > Spotted by Guillaume ORTEGA. He reports this fixes > http://bugs.winehq.org/show_bug.cgi?id=24101 > > Passes kernel32 tests. That's not a use after close, client's fd passed in the server call is used just as an association of the server side. -- Dmitry.

2 1

Re: ole32: Call the draw_continue function.
by testbot＠testbot.winehq.org Sept. 21, 2010

Sept. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5372 Your paranoid android. === W98SE (32 bit ole2) === ole2.c:1284: Test failed: IViewObject_Draw with draw_continue_false returns 0x00000000 ole2.c:1063: Test failed: Expected draw_continue to be called instead of DataObject_DAdvise ole2.c:1063: Test failed: Expected draw_continue_false to be called instead of DataObject_DAdvise ole2.c:1072: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1072: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1308: Test failed: Method sequence starting from DataObject_DUnadvise not called ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1380: Test failed: Method sequence starting from DataObject_GetData not called

1 0

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values.
by testbot＠testbot.winehq.org Sept. 21, 2010

Sept. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5370 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: ipconfig: Add the Polish translation.
by Paul Vriens Sept. 21, 2010

Sept. 21, 2010

On 09/19/2010 11:11 AM, Łukasz Wojniłowicz wrote: > +#include "ipconfig.h" > + > +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > + > +STRINGTABLE Hi Łukasz, This newly created file is UTF-8 so you should add the needed pragma (or convert to something else). Compiling this one results in: Warning: string "Spos�b u�ycia: ipconfig [ /? | /all ] " seems to be UTF-8 but codepage 1250 is in use. Warning: string "B��d: Nierozpoznany lub niepe�ny wiersz polecenia " seems to be UTF-8 but codepage 1250 is in use. Warning: string "Sufiks DNS konkretnego po��czenia" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Typ w�z�a" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Przekierowywanie IP w��czone" seems to be UTF-8 but codepage 1250 is in use. Warning: string "DHCP w��czone" seems to be UTF-8 but codepage 1250 is in use. The same is true for your "inetcpl: Add the Polish translation" patch. -- Cheers, Paul.

1 1

Re: user32: Do not test window state on the HCBT_SETFOCUS event, it's undefined.
by testbot＠testbot.winehq.org Sept. 21, 2010

Sept. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5367 Your paranoid android. === W98SE (32 bit win) === win.c:2968: Test failed: message 000f available win.c:2980: Test failed: message 000f available win.c:2989: Test failed: message 000f available win.c:2998: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2682: Test failed: GetActiveWindow() = 0000000000000000 win.c:2682: Test failed: GetFocus() = 0000000000000000 win.c:2708: Test failed: GetActiveWindow() = 0000000000000000 win.c:2708: Test failed: GetFocus() = 0000000000000000 win.c:2767: Test failed: GetActiveWindow() = 0000000000000000 win.c:2767: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: UpdateLayeredWindow() should fail on non-layered or already initialized window.
by testbot＠testbot.winehq.org Sept. 21, 2010

Sept. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5366 Your paranoid android. === W98SE (32 bit win) === win.c:2946: Test failed: hwnd 000004C4 message 0112 win.c:2948: Test failed: message 0100 available win.c:2969: Test failed: message 000f available win.c:2981: Test failed: message 000f available win.c:2990: Test failed: message 000f available win.c:2999: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006C01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006E01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000301A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006F01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000501A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000 win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000C016A fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000003301A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000003401A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000002019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000006019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000007019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000008201A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0000000000020198 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000C016A fg 0000000000010092 in hook HCBT_SETFOCUS

1 0

Re: [1/3] dinput: Add top level HID Collection detection to OSX joystick driver
by Vitaliy Margolen Sept. 21, 2010

Sept. 21, 2010

On 09/19/2010 03:21 PM, Zachary Smith wrote: > This Patch: > Here I add find_osx_top_level() to the file, which is designed to identify > top level HID collections. It is independent from patch [2/3] but required > for patch [3/3] Your formatting does not match the rest of the file (curly braces on separate line), no space between opening / closing parentheses and content. And you should merge your 3 patches into one. First two just add dead code. Vitaliy.

2 2

[RFC] mmap override patch
by Chris Robinson Sept. 21, 2010

Sept. 21, 2010

This is a patch that attempts to override mmap, mmap64, and munmap so that host libs can used memory from the Wine heap instead of being restricted to the address space Wine leaves unreserved. It is based on Albert Lee's patch found here: http://bugs.winehq.org/show_bug.cgi?id=13335#c170 It has been enhanced to fix the problem with using off64_t in the wine/library.h header by using ULONGLONG instead, and it should override the aforementioned functions with the correct prototype in 32-bit and 64-bit in a much simpler way. It currently relies on the system having mmap or mmap64 that uses a 64-bit offset type, though if that's a problem, an extra wrapper can probably be made. It also relies on ULONGLONG being a 64-bit type, but from what I can tell, that will always true. If there's a problem with it, or some way it can be improved, please let me know. :)

1 0

BugZilla: Changings for Bug 24177
by Joerg Schiermeier Sept. 20, 2010

Sept. 20, 2010

--- skins/custom/index.css | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/skins/custom/index.css b/skins/custom/index.css index 2c40719..bf064c4 100644 --- a/skins/custom/index.css +++ b/skins/custom/index.css @@ -7,6 +7,8 @@ } div#login_box { position: relative; - top: 205px; +/** -causes an error- + * top: 205px; + */ text-align: left; } \ No newline at end of file -- 1.7.1

2 1

Any recommendations on 64-bit debugging tools?
by Ben Parker Sept. 20, 2010

Sept. 20, 2010

For those of you who have developed 64-bit apps with wine, I'd like to ask what debugging tools and techniques you found most effective in that environment. Anyone have good luck with the 64-bit winedbg or remote debugging using Visual Studio? Thanks, Ben Parker ESRI

1 0

Re: libwine: Make addresses above 0x82000000 available on FreeBSD.
by Alexandre Julliard Sept. 20, 2010

Sept. 20, 2010

Tijl Coosemans <tijl(a)coosemans.org> writes: > With this patch it is possible that a .dll.so is loaded beyond the > 2GiB limit, but this does not seem to be a problem in practice. All > mmap calls from within Wine and thus all .dll stay below 2GiB and core > .dll.so such as ntdll, kernel32, user32,... are also loaded below 2GiB > because they are loaded early and are placed in the 32MiB mentioned > above. Also note that a .dll.so is only loaded above 2GiB when needed, > i.e. the program wouldn't have worked at all without this patch. It is > preferred that Wine at least makes an attempt at running the program > and therefore loosens the restriction on the use of addresses above > 2GiB, especially since it seems to work so far. It would be better to fix this properly. If there's no way to convince FreeBSD's mmap to use all available space, you'll have to move the loader down to make some room. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().
by Henri Verbeet Sept. 20, 2010

Sept. 20, 2010

I think it's close, but not entirely what I had in mind. You can avoid both the callback and some of the data copies if you just let parse_dxbc() create a list / array of sections. So you'd have something like this: struct dxbc_section { DWORD tag; const char *data; SIZE_T data_size; }; struct dxbc { UINT section_size; UINT section_count; struct dxbc_section *sections; }; with parse_dxbc() just calling something like dxbc_add_section() instead of chunk_handler(). The sections can just refer to the original data in the dxbc blob, it's then the responsibility of the caller to either make sure that data stays around for as long as the sections are needed or make a copy of the data. d3dcompiler_get_blob_part() would then just iterate over all the sections and add the relevant ones to a second dxbc struct, which it would pass to dxbc_write_blob() afterwards. I don't think dxbc_remove_section() is very useful in general, you'll pretty much always just want to add sections to a new section list. It's also simply unused in your current patch. dxbc_release() should be called dxbc_destroy(), you're not doing any reference counting, and the naming would be more consistent if you renamed parse_dxbc() to dxbc_parse().

2 3

Re: [PATCH 4/4] gameux: Add stub of IGameStatistics interface implementation
by testbot＠testbot.winehq.org Sept. 20, 2010

Sept. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5355 Your paranoid android. === W98SE (32 bit gamestatistics) === Failure running script in VM: Exceeded timeout limit of 315 sec === W7PRO (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists === W7PROX64 (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists

1 0

Re: [PATCH 2/4] gameux/tests: Add test of storing and reading game statistics
by testbot＠testbot.winehq.org Sept. 20, 2010

Sept. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5354 Your paranoid android. === W98SE (32 bit gamestatistics) === Failure running script in VM: Exceeded timeout limit of 315 sec === W7PRO (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists === W7PROX64 (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists

1 0

Re: [PATCH 6/6] d3dcompiler: Implement D3DGetDebugInfo().
by Henri Verbeet Sept. 20, 2010

Sept. 20, 2010

2010/9/19 Rico Schüller <kgbricola(a)web.de>: > --- I don't think this makes a lot of sense. D3DGetDebugInfo() clearly doesn't return a DXBC, so I think you should just memcpy it into the blob directly instead of trying to abuse dxbc_write(). This change would also make it impossible to write any DXBC containing an SDBG chunk, like e.g. the one you'd be parsing for D3DGetDebugInfo().

2 2

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 2)
by Alexandre Julliard Sept. 20, 2010

Sept. 20, 2010

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > + wsa->read = HeapAlloc( GetProcessHeap(), 0, sizeof(*wsa->read) ); > + if (!wsa->read) > + { > + status = STATUS_NO_MEMORY; > + goto finish; > + } > + wsa->read->hSocket = wsa->accept_socket; > + wsa->read->flags = 0; > + wsa->read->addr = NULL; > + wsa->read->addrlen.ptr = NULL; > + wsa->read->n_iovecs = 1; > + wsa->read->first_iovec = 0; > + /* Includes 1 iovec, and that's all we need */ > + wsa->read->iovec[0].iov_base = wsa->buf; > + wsa->read->iovec[0].iov_len = wsa->data_len; > + SERVER_START_REQ( register_async ) > + { > + req->type = ASYNC_TYPE_READ; > + req->async.handle = wine_server_obj_handle( wsa->accept_socket ); > + req->async.callback = wine_server_client_ptr( WS2_async_recv_accept ); > + req->async.iosb = wine_server_client_ptr( iosb ); > + req->async.arg = wine_server_client_ptr( wsa ); > + status = wine_server_call( req ); > + } > + SERVER_END_REQ; > + > + if (status != STATUS_PENDING) > + goto finish; > + > + return STATUS_SUCCESS; > + > +finish: > + iosb->u.Status = status; > + iosb->Information = 0; > + > + if (wsa->user_overlapped->hEvent) > + SetEvent(wsa->user_overlapped->hEvent); > + if (wsa->cvalue) > + WS_AddCompletion( HANDLE2SOCKET(wsa->listen_socket), wsa->cvalue, iosb->u.Status, iosb->Information ); > + HeapFree( GetProcessHeap(), 0, wsa->read ); > + HeapFree( GetProcessHeap(), 0, wsa ); > + > + return status; > +} You cannot allocate or free memory in an async callback, because it can be called from a signal handler. All needed memory needs to be allocated beforehand, and freed in the user apc callback. -- Alexandre Julliard julliard(a)winehq.org

1 0

Regsvr32 running through Gecko
by James McKenzie Sept. 20, 2010

Sept. 20, 2010

Interestingly enough, when Wine goes to update my .wine prefix, the updater is trying to run regsvr32 through Gecko. Of course, this crashes and the debugger cannot attach to the process as it terminates. err:ole:TLB_ReadTypeLib Loading of typelib L"C:\\windows\\system32\\msdatsrc.tlb" failed with error 2 Is this the desired action or should I 'flush' my .wine and start over? James McKenzie

2 2

Re: user32: Implement support for getting class data GCLP_HBRBACKGROUND on other process window
by Alexandre Julliard Sept. 20, 2010

Sept. 20, 2010

Aleksey Bragin <aleksey(a)reactos.org> writes: > diff --git a/server/class.c b/server/class.c > index 0e402ba..90ab436 100644 > --- a/server/class.c > +++ b/server/class.c > @@ -47,6 +47,7 @@ struct window_class > int local; /* local class? */ > atom_t atom; /* class atom */ > mod_handle_t instance; /* module instance */ > + user_handle_t background; /* background brush handle */ > unsigned int style; /* class style */ > int win_extra; /* number of window extra bytes */ > client_ptr_t client_ptr; /* pointer to class in client address space */ Brushes are not user handles, and it doesn't make much sense to share them since the handles are process-local currently. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] shell32: use flexible arrays to avoid fortify failures
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 20, 2010

Sept. 20, 2010

Hi, Alexandre Julliard wrote: >> it needs to be "foo[]". ANYSIZE_ARRAY is defined as 1 >True, you don't want to change the public one, but you can define a >shell32-specific version of it. At least then it looks like a normal >array declaration. Thank you for pointing to ANYSIZE_ARRAY. Why not cope with the way MS people recommend and use foo[ANYSIZE_ARRAY], together with the FIELD_OFFSET() macro? I found this article useful: http://blogs.msdn.com/b/oldnewthing/archive/2004/08/26/220873.aspx and made a note to use that in future patches. It explains why ANYSIZE_ARRAY MUST be 1. Should somebody submit patches to replace foo[1] with foo[ANYSIZE_ARRAY] where needed in Wine's include/*.h ? E.g. wingdi.h: BITMAPINFO comes to mind, it uses RGBQUAD bmiColors[1]; http://source.winehq.org/source/include/wingdi.h#L1912 ANYSIZE_ARRAY would be a perfect match here. Perhaps one can teach fortify about ANYSIZE_ARRAY? Regards, Jörg Höhle

1 0

Re: [PATCH 1/6] d3dcompiler: Add D3DGetBlobPart() stub.
by Henri Verbeet Sept. 20, 2010

Sept. 20, 2010

2010/9/19 Rico Schüller <kgbricola(a)web.de>: > + FIXME("data %p, data_size %lu, part %#x, flags %u, blob %p stub!\n", data, data_size, part, flags, blob); I think %#x is more appropriate than %u for flags.

1 0

Re: [msi/tests] Prevent a popup on Windows NT
by testbot＠testbot.winehq.org Sept. 20, 2010

Sept. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5346 Your paranoid android. === W2KPROSP4 (32 bit install) === Timeout === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: ipconfig: Add the Polish translation.
by Andrew Nguyen Sept. 19, 2010

Sept. 19, 2010

2010/9/19 Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com>: > +/* > + * IP configuration utility > + * English language support > + * Pedantically, that should probably be "Polish language support".

2 2

Re: kernel32: Remove unused variable
by Vitaliy Margolen Sept. 19, 2010

Sept. 19, 2010

On 09/19/2010 01:47 AM, Luca Bennati wrote: > > Found with scan-build provided by clang/llvm > > diff --git a/dlls/kernel32/virtual.c b/dlls/kernel32/virtual.c > index dcd5b85..a10bb6c 100644 > --- a/dlls/kernel32/virtual.c > +++ b/dlls/kernel32/virtual.c > @@ -648,17 +648,13 @@ BOOL WINAPI IsBadReadPtr( LPCVOID ptr, UINT size ) > __TRY > { > volatile const char *p = ptr; > - char dummy; > UINT count = size; > > while (count > page_size) > { > - dummy = *p; > p += page_size; > count -= page_size; > } > - dummy = p[0]; > - dummy = p[count - 1]; You can't do that. That's the whole point of this function - to test if particular address is readable. Vitaliy.

1 0

Wine without X? Failing in dlls/winex11.drv
by Gerald Pfeifer Sept. 19, 2010

Sept. 19, 2010

Trying to build Wine on a new tester which initially had too few packages installed I ran into the following. In file included from bitblt.c:33: x11drv.h:30:22: error: X11/Xlib.h: No such file or directory x11drv.h:31:27: error: X11/Xresource.h: No such file or directory x11drv.h:32:23: error: X11/Xutil.h: No such file or directory x11drv.h:33:23: error: X11/Xatom.h: No such file or directory x11drv.h:44:21: error: X11/Xmd.h: No such file or directory x11drv.h:45:24: error: X11/Xproto.h: No such file or directory Indeed include/config.h has HAVE_X11_XLIB_H undefined since, well, all these headers indeed are missing. On the other hand, configure did not halt. In fact, configure did not even warn about this situation unlike it does in other cases. How to fix this? Should dlls/winex11.drv just not be built in such a case? Should configure error out? (We do have --without-x, too, though.) Anything else? Currently we do pass configure and then run into a compile failure later on. Gerald

3 3

Re: ws2_32: Fail when select is called with an invalid fd. (try 2)
by Alexandre Julliard Sept. 19, 2010

Sept. 19, 2010

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > Fixed the pollfds leak from try 1. You are still leaking the file descriptors. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [urlmon/tests] Fix test failures on Win9x/WinMe by using more A-functions
by testbot＠testbot.winehq.org Sept. 19, 2010

Sept. 19, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5328 Your paranoid android. === W2K8SE (32 bit url) === url.c:1337: Test failed: unexpected call OnProgress_SENDINGREQUEST

1 0

Re: user32: warnings (around uninitialized variables).
by Alexandre Julliard Sept. 19, 2010

Sept. 19, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -388,6 +388,8 @@ static int DIB_GetBitmapInfo( const BITMAPINFOHEADER *header, LONG *width, > *compr = header->biCompression; > return 1; > } > + > + *width = *height = 0; > ERR("(%d): unknown/wrong size for header\n", header->biSize ); > return -1; > } 0 is not valid for a bitmap, these should never be used in the error case. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by Alexander Morozov Sept. 19, 2010

Sept. 19, 2010

> I have attached DVEdit.log.txt. In addition to problem with loading npf.sys, icdusb2.sys tries to use KeInitializeDeviceQueue which is not implemented and crashes.

2 2

autoconf 2.62 failure due to AS_VAR_IF
by Gerald Pfeifer Sept. 19, 2010

Sept. 19, 2010

Using autoconf 2.62 on my primary test system I am getting: configure:26081: error: possibly undefined macro: AS_VAR_IF Indeed use of AS_VAR_IF appears relatively new, and it seems this may be similar to AS_VAR_APPEND where we have the following in configure.ac: dnl autoconf versions before 2.63b don't have AS_VAR_APPEND m4_ifdef([AS_VAR_APPEND],,[as_fn_append () { eval $[1]=\$$[1]\$[2]; } AC_DEFUN([AS_VAR_APPEND],[as_fn_append $1 $2])])dnl I assume we need something similar here, too? I am really far from an autoconf hacker -- is this something one of you could look into? Gerald

1 1

Re: Remove code which has been #if 0-ed for 11 years from DOSCONF_Device and DOSCONF_Install. (RESEND)
by Alexandre Julliard Sept. 19, 2010

Sept. 19, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > An alternate patch would be putting #if 0 around the first occurrence > of loadhigh, too, but this code has been marked dead for more than 11 > years, so I really think it can / should go? It doesn't make sense to parse and not do anything with it. If you want to remove dead code you can remove essentially the entire file. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Use GCC's -Wlogical-op if possible
by Austin English Sept. 19, 2010

Sept. 19, 2010

On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer<gerald(a)pfeifer.com> wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep close > an eye on this and to address any issues proactively as part of my nightly > test builds. > > Gerald > > ChangeLog: > Use GCC's -Wlogical-op if possible. > > diff --git a/configure.ac b/configure.ac > index bef311e..3f7a657 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1385,8 +1385,9 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > - WINE_TRY_CFLAGS([-Wwrite-strings]) > + WINE_TRY_CFLAGS([-Wlogical-op]) > WINE_TRY_CFLAGS([-Wtype-limits]) > + WINE_TRY_CFLAGS([-Wwrite-strings]) > > dnl Check for noisy string.h > saved_CFLAGS="$CFLAGS" > > > Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ‘&&’ with non-zero constant will always evaluate as true cert.c:1627: warning: logical ‘||’ with non-zero constant will always evaluate as true -- -Austin

8 18

GDI32 Font Test Errors with MacOSX build
by James McKenzie Sept. 19, 2010

Sept. 19, 2010

Just wanted to see if any other Mac Wine user has the time to run the gdi32 tests and see if they get errors in the Font test. Thank you. James Mckenzie

2 1

wine performance wiki page
by Dan Kegel Sept. 19, 2010

Sept. 19, 2010

Wine's performance is good, but in some areas doesn't match that of Windows. I figured a wiki page on the topic would be useful, so I created http://wiki.winehq.org/Performance It was kind of sparse, but Stefan just added a great 3d performance debugging tutorial to it. If there's anything important missing from that page, please feel free to add it. Hopefully this will help people hunt down performance bottlenecks in Wine.

2 2

Winetricks command
by M Hack Sept. 19, 2010

Sept. 19, 2010

I have Ubuntu 10.04 and the repository ppa:ubuntu-wine/ppa installed. When following your instructions (http://wiki.winehq.org/winetricks) to run winetricks I encountered a problem Entering sh winetricks in a terminal window gave me the following error Cannot find wineprefixcreate (wineprefixcreate) With blind luck I tried entering just winetricks which worked, ie sh winetricks is not necessary. The error message was not informative and evidently is a hold over. It would help if this was stated on your wiki Mark <><

2 1

Unused code patch in: "mshtml: Added nsIURL::GetQuery implementation."
by Joris Huizer Sept. 18, 2010

Sept. 18, 2010

Hello, I found a bit of unused code was introduced in commit ffe9cc87c0e759dffe2a19a96a1e5c7746c7ad62 "mshtml: Added nsIURL::GetQuery implementation." + ptr_end = url.lpszExtraInfo+url.dwExtraInfoLength; + for(ptr = url.lpszExtraInfo; ptr < ptr_end; ptr++) { + if(*ptr == '#') + break; + } + + ptr = url.lpszExtraInfo; Either the loop is leftover code, or the last (unconditional) assignment is wrong. HTH, Joris

2 1

Re: [Wine] Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by Mr. Teo En Ming 张恩鸣 o f Singapore Sept. 17, 2010

Sept. 17, 2010

Dear James McKenzie, Yes, I have already applied the USB patches written by Alexander Morozov. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Citizenship: Singapore Citizen/Singaporean Facebook account: Teo En Ming (Zhang Enming) Facebook link: http://www.facebook.com/profile.php?id=100000750083982 Facebook photos: http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100… Facebook videos: http://www.facebook.com/profile.php?id=100000750083982&v=app_2392950137 Mobile Phone (Starhub pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com Location: Bedok Reservoir Road, Singapore ZIP: 470103 My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Mr. Teo En Ming (Zhang Enming) 张恩鸣 of Singapore: http://img543.imageshack.us/img543/5052/mrteoenmingzhangenmingo.jpg On 09/17/2010 11:18 PM, James Mckenzie wrote: > Alexander Morozov<amorozov(a)etersoft.ru> > >> >>> I have attached DVEdit.log.txt. >>> >> In addition to problem with loading npf.sys, icdusb2.sys tries to use >> KeInitializeDeviceQueue which is not implemented and crashes. >> >> > I suppose this is with your USB patches applied? > > [Sending to list in case personal message is bounced by my ISP.] > > James McKenzie > > > >

1 0

Re: Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by Mr. Teo En Ming 张恩鸣 o f Singapore Sept. 17, 2010

Sept. 17, 2010

Dear Alexander Morozov, The debugging output is as follows: err:module:import_dll Library NDIS.SYS (which is needed by L"C:\\windows\\system32\\drivers\\npf.sys") not found err:winedevice:ServiceMain driver L"npf" failed to load fixme:ntoskrnl:KeInitializeSpinLock stub: 0x757e54 wine: Call from 0x7b837072 to unimplemented function ntoskrnl.exe.KeInitializeDeviceQueue, aborting wine: Unhandled page fault on read access to 0xbd1bf7ab at address 0x63b818 (thread 0036), starting debugger... fixme:dbghelp_msc:pe_load_debug_directory This guy has FPO information fixme:ntdll:server_ioctl_file Unsupported ioctl 2d1400 (device=2d access=0 func=500 method=0) fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub ALSA lib seq_hw.c:457:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib pcm.c:2171:(snd_pcm_open_conf) Cannot open shared library /usr/lib/alsa-lib/libasound_module_pcm_pulse.so ALSA lib pcm.c:2171:(snd_pcm_open_conf) Cannot open shared library /usr/lib/alsa-lib/libasound_module_pcm_pulse.so fixme:shell:SIC_IconAppend iconlists out of sync 0x4 0x3 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SIC_IconAppend iconlists out of sync 0x5 0x4 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SIC_IconAppend iconlists out of sync 0x6 0x5 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SIC_IconAppend iconlists out of sync 0x7 0x6 fixme:shell:SIC_IconAppend iconlists out of sync 0x8 0x7 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub Thank you. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Citizenship: Singapore Citizen/Singaporean Facebook account: Teo En Ming (Zhang Enming) Facebook link: http://www.facebook.com/profile.php?id=100000750083982 Facebook photos: http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100… Facebook videos: http://www.facebook.com/profile.php?id=100000750083982&v=app_2392950137 Mobile Phone (Starhub pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com Location: Bedok Reservoir Road, Singapore ZIP: 470103 My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Mr. Teo En Ming (Zhang Enming) 张恩鸣 of Singapore: http://img543.imageshack.us/img543/5052/mrteoenmingzhangenmingo.jpg On 09/17/2010 09:17 PM, Alexander Morozov wrote: > Dear Teo En Ming, > > There may be many reasons for this: > 1) a program uses some not fully implemented setupapi functions to find a > device > 2) a program can not open a device file created by a driver (driver did not > create device file due to some errors) > 3) a program is trying to use Read/WriteFile for device file, this is not > supported now > 4) may be something else > > Try WINEDEBUG=+setupapi,+file,+winedevice,+ntoskrnl,+usbhub > > Best regards, > Alexander Morozov > > On Friday 17 September 2010 14:12:30 Mr. Teo En Ming (Zhang Enming) 张恩鸣 of > Singapore wrote: > >> Dear Alexander Morozov, >> >> From the output of the command "ps -ef | grep wine", we can observe >> that the native Windows USB driver ICDUSB2.sys for the Sony IC Recorder >> gets loaded with winedevice.exe. >> >> enming 18814 18781 0 16:15 ? 00:00:00 >> C:\windows\system32\winedevice.exe ICDUSB2 >> >> However, Digital Voice Editor 3 (under Wine) simply would not detect the >> Sony IC Recorder. The dialog box says: >> >> "Could not communicate with IC Recorder. >> Make sure that the cable is connected properly. >> >> Remove the cable from the IC Recorder and then connect it again. >> >> If another user is operating the Digital Voice Editor, quit the software." >> >

2 2