September 2010 - Wine-Devel

Re: [PATCH 5/5] Add some more schannel tests
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5096 Your paranoid android. === W98SE (32 bit schannel) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit schannel) === Timeout === W2KPROSP4 (32 bit schannel) === Timeout

1 0

Re: [PATCH] Add some more schannel tests
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5095 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found

1 0

Re: [PATCH] Add some more schannel tests
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5092 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found

1 0

Re: kernel32/tests: typo fixes
by Nicolas Le Cam Sept. 7, 2010

Sept. 7, 2010

2010/9/7 Austin English <austinenglish(a)gmail.com> > I initially noticed the wrong hemisphere label, but then the > capitalization was bugging me :-) > > -- > -Austin Hi Austin, @@ -449,18 +449,18 @@ static void test_TzSpecificLocalTimeToSystemTime(void) > tzW.DaylightBias=-60; > tzW.StandardDate.wMonth=10; > tzW.StandardDate.wDayOfWeek=0; /*sunday */ > > You missed that one! -- Nicolas Le Cam

1 0

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete
by Hans Leidekker Sept. 7, 2010

Sept. 7, 2010

Hi Mikko, > diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c > index 78757ac..192f9cb 100644 > --- a/dlls/secur32/schannel.c > +++ b/dlls/secur32/schannel.c > @@ -1244,6 +1244,15 @@ static SECURITY_STATUS SEC_ENTRY schan_DecryptMessage(PCtxtHandle context_handle > if(buffer->cbBuffer < expected_size) > { > TRACE("Expected %u bytes, but buffer only contains %u bytes\n", expected_size, buffer->cbBuffer); > + buffer->BufferType = SECBUFFER_MISSING; > + buffer->cbBuffer = expected_size - buffer->cbBuffer; > + > + // This is a bit weird, but windows does it too > + idx = schan_find_sec_buffer_idx(message, 0, SECBUFFER_EMPTY); > + buffer = &message->pBuffers[idx]; > + buffer->BufferType = SECBUFFER_MISSING; > + buffer->cbBuffer = expected_size - buffer->cbBuffer; > + > TRACE("Returning SEC_E_INCOMPLETE_MESSAGE\n"); > return SEC_E_INCOMPLETE_MESSAGE; > } You should resend this with the patches it depends on and give the patches a sequence number.

2 1

Re: [PATCH] Add some more schannel tests
by Hans Leidekker Sept. 7, 2010

Sept. 7, 2010

> @@ -116,6 +128,10 @@ static void InitFunctionPtrs(void) > if(!secdll) > secdll = LoadLibraryA("security.dll"); > advapi32dll = GetModuleHandleA("advapi32.dll"); > + wsockdll = LoadLibraryA("ws2_32.dll"); > + > + if(!wsockdll) > + printf("Couldn't open ws2_32.dll\n"); > Why are you loading ws2_32 dynamically? > + desc->pBuffers[0].cbBuffer = size; > + desc->pBuffers[0].pvBuffer = malloc(size); Use HeapAlloc/Free instead of malloc/free. > +static int receive_data(SOCKET sock, SecBuffer *buf) > +{ > + unsigned received = 0; > + > + while(1) > + { > + unsigned char *data = buf->pvBuffer; > + unsigned expected = 0; > + int ret; Please stick to 4 space indentation like the rest of the file. > + addr.sin_family = AF_INET; > + addr.sin_addr.s_addr = htonl(0xD1558712); > + addr.sin_port = htons(443); > + ret = pconnect(sock, (struct sockaddr *)&addr, sizeof(struct sockaddr_in)); > + if(ret==SOCKET_ERROR) > + { > + skip("Can't connect to mail.google.com\n"); > + return; > + } You should properly resolve mail.google.com.

2 1

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete
by Juan Lang Sept. 7, 2010

Sept. 7, 2010

Hi Mikko, + // This is a bit weird, but windows does it too You can't use C++-style comments in Wine. You do the same in your tests patch, too. --Juan

2 1

specfiles containing 'str' instead of 'wstr' for some W-functions
by Paul Vriens Sept. 7, 2010

Sept. 7, 2010

Hi, I see some specfiles that contain 'str' instead of the correct 'wstr'. Is it worth sending a patch to fix these? If so, only one? -- Cheers, Paul.

1 0

Re: [PATCH] Fill a SECBUFFER_MISSING buffer if the message is not complete
by Austin English Sept. 7, 2010

Sept. 7, 2010

On Tue, Sep 7, 2010 at 10:44 AM, Mikko Rasa <tdb(a)tdb.fi> wrote: > --- > dlls/secur32/schannel.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Howdy Mikko, > diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c > index 78757ac..192f9cb 100644 > --- a/dlls/secur32/schannel.c > +++ b/dlls/secur32/schannel.c > @@ -1244,6 +1244,15 @@ static SECURITY_STATUS SEC_ENTRY schan_DecryptMessage(PCtxtHandle context_handle > if(buffer->cbBuffer < expected_size) > { > TRACE("Expected %u bytes, but buffer only contains %u bytes\n", expected_size, buffer->cbBuffer); > + buffer->BufferType = SECBUFFER_MISSING; > + buffer->cbBuffer = expected_size - buffer->cbBuffer; > + > + // This is a bit weird, but windows does it too I can't comment on the rest of the patch, but please use C89 /* comments */, not C99 (//). -- -Austin

1 0

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED
by Greg Geldorp Sept. 7, 2010

Sept. 7, 2010

> From: Paul Chitescu <paulc(a)voip.null.ro> > > In a typical Win32 environment the executables don't have relocations since > they load at a fixed address. Old (Visual C 4.x and older) executables had > relocations so they could run on Win32s. Not all that relevant to the patch, but... Newer executables do tend to have relocations. This allows ASLR (Address Space Layout Randomization) on Vista and higher to work. Ge.

1 0

Re: Wine Introduction Page
by James Mckenzie Sept. 7, 2010

Sept. 7, 2010

Ken Thomases <ken(a)codeweavers.com> wrote: >Sent: Sep 7, 2010 9:17 AM >To: James McKenzie <jjmckenzie51(a)earthlink.net> >Cc: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >Subject: Re: Wine Introduction Page > >On Sep 4, 2010, at 2:20 PM, James McKenzie wrote: > >> I know it is in git. I don't want to give out bogus information, that's why the question. I don't have an Intel system >>here with MacOSX 10.4 installed anymore, all of mine are at 10.6.4 >> >> Same thing with XCode. I know that the 2.x is at 2.5 but can Wine still be built with 2.4? I don't have the resources >>available to test. > >It still builds on Tiger, although maintaining that may become problematic over time. > >I don't know about Xcode 2.4, but I'm not aware of any breaking changes between 2.4 and 2.5. I expect it still builds >with 2.4 if that's what a user has. > Thank you. No update necessary for this information then. James McKenzie

1 0

[Fwd: Re: Wine Introduction Page]
by James McKenzie Sept. 7, 2010

Sept. 7, 2010

To the list as well. Can we fix this so that replies go to the list rather than the sender? James McKenzie -------- Original Message -------- Subject: Re: Wine Introduction Page Date: Sat, 04 Sep 2010 12:18:42 -0700 From: James McKenzie <jjmckenzie51(a)earthlink.net> To: Roderick Colenbrander <thunderbird2k(a)gmail.com> References: <4C8286F5.7090207(a)earthlink.net> <AANLkTikVVEyKVSMb17NePtBvW+pHC3tsmvuYYvF_HVWr(a)mail.gmail.com> Roderick Colenbrander wrote: > On Sat, Sep 4, 2010 at 7:50 PM, James McKenzie > <jjmckenzie51(a)earthlink.net> wrote: > >> I was just going over this page and found a few things that I don't know >> about but have questions on for building Wine on the Mac: >> >> The lowest MacOSX version that Wine will build on from the native package is >> stated to be 10.4 (Tiger). Is this still true? >> >> The lowest XCode required is 2.4. Apple stopped supporting this a long time >> ago. I had XCode 2.5 for Tiger. >> >> Can anyone update these? >> >> James McKenzie >> >> >> >> >> > > The website is in git, so feel free to submit patches ;) > I know it is in git. I don't want to give out bogus information, that's why the question. I don't have an Intel system here with MacOSX 10.4 installed anymore, all of mine are at 10.6.4 Same thing with XCode. I know that the 2.x is at 2.5 but can Wine still be built with 2.4? I don't have the resources available to test. James McKenzie

2 1

Re: ntdll: Don't cancel loading on IMAGE_FILE_RELOCS_STRIPPED
by Marcus Meissner Sept. 7, 2010

Sept. 7, 2010

On Tue, Sep 07, 2010 at 04:37:49PM +0200, André Hentschel wrote: > give the file a try when it only links to ordinals instead of just stopping execution here. > --- > dlls/ntdll/virtual.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c > index a42ed5f..0bd3023 100644 > --- a/dlls/ntdll/virtual.c > +++ b/dlls/ntdll/virtual.c > @@ -1232,12 +1232,8 @@ static NTSTATUS map_image( HANDLE hmapping, int fd, char *base, SIZE_T total_siz > const IMAGE_DATA_DIRECTORY *relocs; > > if (nt->FileHeader.Characteristics & IMAGE_FILE_RELOCS_STRIPPED) > - { > WARN_(module)( "Need to relocate module from %p to %p, but there are no relocation records\n", > base, ptr ); > - status = STATUS_CONFLICTING_ADDRESSES; > - goto error; > - } > > TRACE_(module)( "relocating from %p-%p to %p-%p\n", > base, base + total_size, ptr, ptr + total_size ); Have you seen a program needing this? Which? "links to ordinals" is also a wrong comment, as RELOCS are used for relocation addresses within the binary itself (not imports). Ciao, Marcus

3 2

Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?
by misha680 Sept. 7, 2010

Sept. 7, 2010

Sorry for reposting - apparently my original nabble link did not work :( --- Dear All: Sorry to bother... I am working on a D3DXCreateMesh/ID3DXMesh patch, and I encountered a very strange error. Specifically, it seems that when passing a LPD3DVERTEXELEMENT9 * parameter to D3DXCreateMesh, a) in Windows - one can create static const D3DVERTEXELEMENT9 decl1[3] = { {0, 0, D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITION, 0}, {0, 0xC, D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_NORMAL, 0}, D3DDECL_END(), }; and pass (LPD3DVERTEXELEMENT9 *)&decl1 directly. b) in Wine tests - I must first allocate a D3DVERTELEMENT9 *, then call HeapAlloc, and finally copy my original decl1 and pass &decl (pointer to newly allocated structure) for it to work. Any ideas? Here is my git diff http://wine.1045685.n5.nabble.com/file/n2805603/patch patch Thx Misha -- View this message in context: http://wine.1045685.n5.nabble.com/Must-copy-static-const-D3DVERTEXELEMENT9-… Sent from the Wine - Devel mailing list archive at Nabble.com.

4 4

Re: msi/tests: Fix compilation on systems that don't support nameless unions or structs.
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5078 Your paranoid android. === W7PROX64 (64 bit package) === package.c:8387: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8398: Test failed: Expected "C:\winetest\", got "" package.c:8409: Test failed: Expected "C:\winetest\", got "" package.c:8459: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8470: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8479: Test failed: Expected "C:\", got "" package.c:8485: Test failed: Expected "C:\winetest\", got "" package.c:8506: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8515: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [PATCH 2/6] gameux: initial implementation of IGameExplorer::AddGame
by Nikolay Sivov Sept. 7, 2010

Sept. 7, 2010

On 9/3/2010 13:25, Mariusz Pluciński wrote: > --- > dlls/gameux/Makefile.in | 2 +- > dlls/gameux/gameexplorer.c | 254 > +++++++++++++++++++++++++++++++++++++- > dlls/gameux/gameux_private.h | 63 ++++++++++ > dlls/gameux/tests/gameexplorer.c | 18 ++-- > 4 files changed, 322 insertions(+), 15 deletions(-) > +/******************************************************************************* > + * _initGameData > + * > + * Internal helper function. Description available in gameux_private.h file > + */ > +void _initGameData(struct GAME_DATA *GameData) > +{ > + GameData->sGDFBinaryPath = NULL; > + GameData->sGameInstallDirectory = NULL; > +} Do you really need another helper for that? Please use better naming like GAMEUX_* for example. > +void _uninitGameData(struct GAME_DATA *GameData) > +{ > + CoTaskMemFree(GameData->sGDFBinaryPath); > + CoTaskMemFree(GameData->sGameInstallDirectory); > +} Any specific reason you need CoTaskMem* here and not a process heap? > + WCHAR sInstanceId[40]; > + WCHAR sRegistryPath[8192]; Where does this come from? Sizes I mean.

2 2

Re: kernel32: forward GetThreadUILanguage() to GetUserDefaultUILanguage() (try 2)
by Alexandre Julliard Sept. 7, 2010

Sept. 7, 2010

Austin English <austinenglish(a)gmail.com> writes: > @@ -658,6 +658,7 @@ > @ stdcall GetTimeFormatA(long long ptr str ptr long) > @ stdcall GetTimeFormatW(long long ptr wstr ptr long) > @ stdcall GetTimeZoneInformation(ptr) > +@ stdcall GetThreadUILanguage() GetUserDefaultUILanguage You can't do that, the functions are not identical. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] gameux: add support of loading Application Id into registry
by Nikolay Sivov Sept. 7, 2010

Sept. 7, 2010

On 9/3/2010 13:25, Mariusz Pluciński wrote: > +static HRESULT _ParseGameDefinition( > + IXMLDOMElement *lpXMLGameDefinitionElement, > + struct GAME_DATA *GameData) > +{ > + static const WCHAR sGameId[] = {'g','a','m','e','I','D',0}; > + > + HRESULT hr = S_OK; > + BSTR bstrAttribute = NULL; > + VARIANT variant; No need for initializers here. > + hr = IXMLDOMElement_getAttribute(lpXMLGameDefinitionElement, bstrAttribute,&variant); > + if(hr != S_OK || V_VT(&variant) != VT_BSTR) hr = E_FAIL; No need to test for hr != S_OK and alter failure code after that I guess. > + /* load MSXML parser */ > + hr = CoCreateInstance(&CLSID_DOMDocument30, NULL, CLSCTX_INPROC_SERVER, > +&IID_IXMLDOMDocument, (LPVOID*)&lpXMLDocument); Use neutral CLSID_DOMDocument. Minor things - useless comment, and LPVOID* -> void**. > + IXMLDOMDocument *lpXMLDocument = NULL; > + IXMLDOMNode *lpXMLGameDefinitionNode = NULL; > + IXMLDOMElement *lpXMLRootElement = NULL, *lpXMLGameDefinitionElement = NULL; Same here, you don't need to initialize that. Please use shorter names, like 'root', 'document' or something. > + hr = IXMLDOMDocument_get_documentElement(lpXMLDocument,&lpXMLRootElement); > + if(hr == S_FALSE) > + hr = E_FAIL; hr != S_OK works. P.S. it makes sense to test xml parsing part with native msxml first. This will hopefully show some problems with builtin msxml.

2 1

Typo in : wined3d: Translate before scaling for rhw as well in transform_projection().
by Joris Huizer Sept. 7, 2010

Sept. 7, 2010

While skimming through recently committed patches, I noticed this piece: + /* Window Coord 0 is the middle of the first pixel, so translate by 1/2 pixels */ + glTranslatef(63.0f / 128.0f, 63.0f / 128.0f, 0.0f); + checkGLcall("glTranslatef(63.0f / 128.0f, -63.0f / 128.0f, 0.0f)"); In the checkGLcall you changed the sign of the second parameter, but you didn't do this in the glTranslatef call. This seemed a bit strange (and I don't know which one would be right). HTH, Joris

2 1

Using the eventlog API for Wine errors
by Paul Vriens Sept. 7, 2010

Sept. 7, 2010

Hi, I was just reading the emails about the winediag stuff and more particularly AJ's remark about the 'hypothetical GUI'. Would it make sense to really start fleshing out the eventlog API so we can/could log errors (or whatever) in that way? The GUI (or commandline app) could then 'easily' connect to the appropriate eventlog(s). The benefit is that it will make sure the eventlog API is actually implemented and the GUI could tap into historical (until .wine is cleaned) information as well. -- Cheers, Paul.

1 0

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.
by Alexandre Julliard Sept. 7, 2010

Sept. 7, 2010

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Note that personally I don't think it's appropriate for "winediag" to abuse > the __WINE_DBCL_ERR debug class for diagnostic messages. Nothing says that winediag messages have to be ERR. If it's not an important failure that all users have to see, it can be a WARN or a TRACE. The hypothetical diagnostic GUI tool can then display those differently. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: oleaut32: Handle TKIND_COCLASS subtype for VT_PTR/VT_USERDEFINED.
by Vincent Povirk Sept. 7, 2010

Sept. 7, 2010

+ // Use IID of the coclass' default interface Don't use C++ comments. On Mon, Sep 6, 2010 at 10:31 AM, Jan Ohlsen <jan.t.ohlsen(a)gmail.com> wrote: > > --- > dlls/oleaut32/tmarshal.c | 69 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 69 insertions(+), 0 deletions(-) > > > > >

3 2

Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?
by misha680 Sept. 7, 2010

Sept. 7, 2010

Dear All: Sorry to bother... I am working on a D3DXCreateMesh/ID3DXMesh patch, and I encountered a very strange error. Specifically, it seems that when passing a LPD3DVERTEXELEMENT9 * parameter to D3DXCreateMesh, a) in Windows - one can create static const D3DVERTEXELEMENT9 decl1[3] = { {0, 0, D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITION, 0}, {0, 0xC, D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_NORMAL, 0}, D3DDECL_END(), }; and pass (LPD3DVERTEXELEMENT9 *)&decl1 directly. b) in Wine tests - I must first allocate a D3DVERTELEMENT9 *, then call HeapAlloc, and finally copy my original decl1 and pass &decl (pointer to newly allocated structure) for it to work. Any ideas? Here is my git diff http://wine.1045685.n5.nabble.com/file/n2805542/patch patch Thx Misha -- View this message in context: http://wine.1045685.n5.nabble.com/Must-copy-static-const-D3DVERTEXELEMENT9-… Sent from the Wine - Devel mailing list archive at Nabble.com.

2 1

Wine & .NET app
by Vassilis Virvilis Sept. 7, 2010

Sept. 7, 2010

Hi everybody, My name is Vassilis Virvilis and I am trying to get .net app to run under wine. The objective of the questions below is to determine what needs to be implemented in wine in order to support the app. So the app bring its window momentarily and then it crashes with a 'Unsupported color conversion request' How difficult to implement are the following error messages? 1) Where is the code that prints 'Unsupported color conversion request'. I can't find it 2) JpegDecoder_Frame_GetResolution doesn't look terribly difficult to implement. Am I completely misguided? 3) URL_ParseUrl lives in in dlls/shwapi/url.c around 1979. The implementation looks fleshed enough. What is the problem? 4) The GUID are referring to IManaged, IProvideClassInfo, IMarshal, IRpcOptions. What is the implementation scope of these? Here is the log: fixme:actctx:parse_manifest_buffer root element is L"asmv1:assembly", not <assembly> fixme:sync:CreateMemoryResourceNotification (0) stub fixme:shell:URL_ParseUrl failed to parse L"Microsoft.VisualBasic" fixme:shell:URL_ParseUrl failed to parse L"System" fixme:shell:URL_ParseUrl failed to parse L"System.Windows.Forms" fixme:shell:URL_ParseUrl failed to parse L"System.Drawing" fixme:shell:URL_ParseUrl failed to parse L"System.Runtime.Remoting" fixme:shell:URL_ParseUrl failed to parse L"System.Configuration" fixme:shell:URL_ParseUrl failed to parse L"System.Xml" fixme:shell:URL_ParseUrl failed to parse L"mscorlib.resources" fixme:shell:URL_ParseUrl failed to parse L"mscorlib.resources" fixme:shell:URL_ParseUrl failed to parse L"System.Drawing.resources" fixme:shell:URL_ParseUrl failed to parse L"System.Drawing.resources" fixme:gdiplus:GdipGetFamilyName No support for handling of multiple languages! fixme:shell:URL_ParseUrl failed to parse L"LMA.resources" fixme:shell:URL_ParseUrl failed to parse L"LMA.resources" fixme:shell:URL_ParseUrl failed to parse L"LMA.resources" fixme:gdiplus:GdipCreateHalftonePalette stub fixme:shell:URL_ParseUrl failed to parse L"System.Xml.XmlSerializers" fixme:shell:URL_ParseUrl failed to parse L"LMA.resources" fixme:wincodecs:JpegDecoder_Frame_GetResolution (0x16d2dc,0x32dd48,0x32dd40): stub fixme:shell:URL_ParseUrl failed to parse L"LMA.resources" fixme:ole:OLEPictureImpl_QueryInterface () : asking for un supported interface {c3fcc19e-a970-11d2-8b5a-00a0c9b7c9c4} fixme:ole:OLEPictureImpl_QueryInterface () : asking for un supported interface {b196b283-bab4-101a-b69c-00aa00341d07} fixme:ole:OLEPictureImpl_QueryInterface () : asking for un supported interface {00000003-0000-0000-c000-000000000046} fixme:ole:OLEPictureImpl_QueryInterface () : asking for un supported interface {00000144-0000-0000-c000-000000000046} fixme:wincodecs:JpegDecoder_Frame_GetResolution (0x1a9924,0x32de38,0x32de30): stub Unsupported color conversion request Thanks in advance Vassilis Virvilis

4 6

d3dx9: D3DXCreateEffectxx
by Luis Busquets Sept. 7, 2010

Sept. 7, 2010

Please note that the current implementation of the functions D3DXCreateEffectFromFileExW, D3DXCreateEffectFromFileExA, D3DXCreateEffectFromResourceExW, D3DXCreateEffectFromResourceExA returns D3DERR_INVALIDCALL if defines are NULL. Actually, defines is an optional parameter and can indeed be NULL and return D3D_OK if everything else is correct. I guess that that is the same for D3DXCreateEffectCompilerFromFileA, D3DXCreateEffectCompilerFromFileW

1 0

Re: winebuild: Don't segfault when running without arguments
by Dmitry Timoshkov Sept. 7, 2010

Sept. 7, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > - if (!spec->dll_name) /* set default name from file name */ > + if (!spec->dll_name && spec->dll_name) /* set default name from file name */ > { > char *p; > spec->dll_name = xstrdup( spec->file_name ); Did you intend to check for spec->file_name? -- Dmitry.

1 0

Re: [6/6] urlmon: Implemented IUriBuilder_{Get/Set}UserName
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5069 Your paranoid android. === WXPPROSP3 (32 bit uri) === uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === WVISTAADM (32 bit uri) === uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === W2K8SE (32 bit uri) === uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5204: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5381: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5880: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0].

1 0

Re: [5/6] urlmon: Some IUri's don't include the userinfo component in the absolute URI string
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5068 Your paranoid android. === WXPPROSP3 (32 bit uri) === uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === WVISTAADM (32 bit uri) === uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0]. === W2K8SE (32 bit uri) === uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135].str_props[0]. uri.c:5172: Test failed: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136].str_props[0]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://@gov.uk/" on uri_tests[135]. uri.c:5349: Test failed: Error: Expected http://gov.uk/ but got L"http://:@gov.uk/" on uri_tests[136]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 15 on uri_tests[135].str_props[0]. uri.c:5848: Test failed: Error: Expected a length of 14 but got 16 on uri_tests[136].str_props[0].

1 0

Re: [4/4] msxml3/tests: Basic test for ::setAttributeNode()
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5062 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5998: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5998: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5998: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [3/4] msxml3/tests: Some tests for ::get_ownerDocument() returned document instance
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5061 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5947: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5947: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5947: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [2/4] msxml3/domdoc: Implement IXMLDOMNamedNodeMap::removeQualifiedItem()
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5060 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5869: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5869: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5869: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [1/4] msxml3/tests: Add a helper to create document instance, remove useless output
by testbot＠testbot.winehq.org Sept. 7, 2010

Sept. 7, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5059 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:5804: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:5804: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:5804: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0

Re: [PATCH 2/2] include: Define C++ operators inside extern "C++" blocks.
by Octavian Voicu Sept. 6, 2010

Sept. 6, 2010

d3c4106d6f6d587ec4b9013692dc1cf6da29c279 still doesn't fix the initial problem (see log below). There is still another problem in shlobj.h caused by the inclusion on shobjidl.h from an extern C block: http://source.winehq.org/git/wine.git/?a=blob;f=include/shlobj.h;h=cda13060… Should I send a patch to move the three includes before extern C? How to reproduce the problem: $ cat test.cpp #include <shlobj.h> $ wineg++ test.cpp In file included from /usr/local/include/wine/windows/propsys.h:164, from /usr/local/include/wine/windows/shobjidl.h:368, from /usr/local/include/wine/windows/shlobj.h:39, from test.cpp:1: /usr/local/include/wine/windows/propkeydef.h: In function ‘bool operator==(const PROPERTYKEY&, const PROPERTYKEY&)’: /usr/local/include/wine/windows/propkeydef.h:61: error: declaration of C function ‘bool operator==(const PROPERTYKEY&, const PROPERTYKEY&)’ conflicts with /usr/local/include/wine/windows/guiddef.h:110: error: previous declaration ‘bool operator==(const GUID&, const GUID&)’ here /usr/local/include/wine/windows/propkeydef.h: In function ‘bool operator!=(const PROPERTYKEY&, const PROPERTYKEY&)’: /usr/local/include/wine/windows/propkeydef.h:65: error: declaration of C function ‘bool operator!=(const PROPERTYKEY&, const PROPERTYKEY&)’ conflicts with /usr/local/include/wine/windows/guiddef.h:114: error: previous declaration ‘bool operator!=(const GUID&, const GUID&)’ here winegcc: g++ failed

1 0

Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation (try2)
by testbot＠testbot.winehq.org Sept. 6, 2010

Sept. 6, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5040 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42

2 1

Re: setupx.dll16: Handle the error case for VCPM_VSTATWRITE in vcpUICallbackProc16. (RESEND)
by Alexandre Julliard Sept. 6, 2010

Sept. 6, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Just realized I did not see a response to this patch. Based on > feedback I received for a different patch, I looked at this patch > again and believe it indeed is easier. > > 1. We only set, but never used cbres, so removing it loses nothing. > 2. With this patch we now set the return value to VCPN_FAIL in this > case. However, this is not the only case in vcpUICallbackProc16; > for example, in another case in this function we pass the return > value of VCP_UI_CopyStart and that returns VCPN_FAIL all over the > place. That doesn't mean it's appropriate in this case. Unless there is evidence that a zero return from VCPM_DISKPREPINFO is supposed to cause an error, it's better not to change the current behavior. -- Alexandre Julliard julliard(a)winehq.org

2 1

msvcrt unimplemented function calls
by Peter Urbanec Sept. 6, 2010

Sept. 6, 2010

I see calls to the following two functions just prior to a crash when testing wine64. Any idea what these are? wine: Call from 0x7b8497d9 to unimplemented function msvcp80.dll.??0?$complex(a)N@std@@QEAA(a)AEBN0@Z, aborting wine: Call from 0x7f7b04cf40d9 to unimplemented function MSVCR80.dll.__C_specific_handler, aborting err:seh:setup_exception stack overflow 2432 bytes in thread 0009 eip 00007f7b04d32341 esp 00007f7b03b10c80 stack 0x7f7b03b10000-0x7f7b03b11000-0x7f7b03c10000 Segmentation fault Thanks.

1 0

Re: wined3d: separate driver info from GPU info (try4)
by Henri Verbeet Sept. 6, 2010

Sept. 6, 2010

On 6 September 2010 00:45, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > - driver_info->version_low = MAKEDWORD_VERSION(8, 6); /* Nvidia RIVA TNT, arbitrary */ > + } You messed up the indentation here, but otherwise I think this looks reasonable.

1 0

re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage
by Dan Kegel Sept. 6, 2010

Sept. 6, 2010

Mikko wrote: > Communicating with an external server is an option, but I don't > know which would be a good server for testing. https://mail.google.com ? Be sure to skip if you can't connect.

1 0

Re: [2/2] attrib/tests: added tests for some flags
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5041 Your paranoid android. === W98SE (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! Timeout Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2KPROSP4 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === WXPPROSP3 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2K3R2SESP2 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === WVISTAADM (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W2K8SE (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PRO (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PROX64 (32 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories! === W7PROX64 (64 bit attrib) === attrib.c:43: Test failed: Cannot set read-only mode! attrib.c:69: Test failed: Cannot set hidden mode! attrib.c:82: Test failed: Cannot set systen file mode! attrib.c:95: Test failed: Cannot set compressed mode! attrib.c:109: Test failed: Cannot change mode when using wildcard '?'! attrib.c:118: Test failed: Cannot change mode when using wildcard '*'! attrib.c:120: Test failed: Cannot change mode when using wildcard '*'! attrib.c:133: Test failed: Cannot change mode on directories!

1 0

Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation (try2)
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5039 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42

1 0

Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5038 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42 url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url ' c :dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 43

1 0

Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation
by testbot＠testbot.winehq.org Sept. 5, 2010

Sept. 5, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5037 Your paranoid android. === W98SE (32 bit url) === url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 42 url.c:742: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url ' c :dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 43

1 0

Re: [1/5] urlmon: Implemented IUriBuilder_{Get/Set}Fragment (try 2)
by Jacek Caban Sept. 5, 2010

Sept. 5, 2010

Hi Thomas, On 9/5/10 8:10 PM, Thomas Mullaly wrote: > Changes since previous attempt: > > 1. Perform lazy allocation/copy of a URI property when the > IUriBuilder_Get* function is called, instead of always allocating when > the IUriBuilder is created (addresses Jacek's comments). > > 2. Created helper functions for Get/Set calls to the IUriBuilder to cut > back on code duplication. > > 3. Added a bit flag member to the UriBuilder object, so that it can store > which properties have been changed. It looks much better now. There is one problem remaining (that I think can be fixed in a follow-up patch): + This->modified_props |= Uri_HAS_FRAGMENT; + return set_builder_component(&This->fragment,&This->fragment_len, pwzNewValue, '#'); The modifier_props should be set only on success. To achieve so, I think it would be cleaner to pass a flag to be set to set_buildier_component. Jacek

1 0

Re: gdi32/tests: Fix a typ description in test_logpen.
by James McKenzie Sept. 5, 2010

Sept. 5, 2010

Gerald Pfeifer wrote: > winebot claims this is causing a tons of test failures on W98SE, > but that doesn't make sense at all. > > Gerald: What is the job id on the testbot? I don't see a failure message in Wine-Devel. James McKenzie

1 0

Re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage
by Mikko Rasa Sept. 5, 2010

Sept. 5, 2010

The patch list requests me to write tests for this patch. I would do that, but there is a problem: I need a fully initialized schannel security context to use DecryptMessage. To acquire one I need to communicate with a server component. Wine is lacking an implementation of at least the AcceptSecurityContext function, so at the moment I cannot do a self-contained test. Communicating with an external server is an option, but I don't know which would be a good server for testing. Implementing the server-side stuff is another, but might take quite a while and I'd like to see this patch applied soon as it's required to play several recent Ubisoft games. Mikko On 30.08.2010 19:37, Mikko Rasa wrote: > --- > dlls/secur32/schannel.c | 50 ++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 45 insertions(+), 5 deletions(-)

1 0

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE
by Alexandre Julliard Sept. 5, 2010

Sept. 5, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -181,6 +181,30 @@ static inline BSTR bstr_from_xmlChar(const xmlChar *str) > return ret; > } > > +static inline BSTR bstr_trim(const BSTR str) > +{ > + UINT i, j, len = SysStringLen(str); > + BSTR new_str = NULL; > + > + /* str empty or NULL */ > + if(!len) > + goto err; > + > + for(i=0; isspaceW(str[i]) && i<len; i++); > + for(j=len-1; isspaceW(str[j]) && j>=i; j--); > + > + new_str = SysAllocStringLen(str+i, j-i+1); > + if(!new_str) > + goto err; > + > + SysFreeString(str); > + return new_str; > + > + err: > + SysFreeString(str); > + return SysAllocStringLen(NULL, 0); > +} That's ugly and inefficient, especially since the common case is to not modify it. -- Alexandre Julliard julliard(a)winehq.org

6 7

Re: msvcp90: Fix 64-bit compilation warnings
by Alexandre Julliard Sept. 5, 2010

Sept. 5, 2010

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase, 12) > basic_string_char* __thiscall MSVCP_basic_string_char_erase( > basic_string_char *this, size_t pos, size_t len) > { > - TRACE("%p %d %d\n", this, pos, len); > + TRACE("%p %d %d\n", this, (int)pos, (int)len); You should be casting to long, otherwise you'll potentially truncate the value. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: winealsa.drv: remove unused variable
by Chris Robinson Sept. 5, 2010

Sept. 5, 2010

On Saturday, September 04, 2010 11:09:03 pm Austin English wrote: > - frames_per_period = snd_pcm_bytes_to_frames(wwi->pcm, > wwi->dwPeriodSize); > + snd_pcm_bytes_to_frames(wwi->pcm, wwi->dwPeriodSize); The whole call can probably be removed if the result isn't used anywhere. The function just returns the number of frames that would fit in the specified byte count for the specified device's format.

1 0

Re: [setupapi] added tests for SetupDiGetINFClassA (try2)
by testbot＠testbot.winehq.org Sept. 4, 2010

Sept. 4, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5026 Your paranoid android. === WNT4WSSP6 (32 bit devinst) === No test summary line found

1 0

Re: attrib.exe: extendended from stub
by Austin English Sept. 4, 2010

Sept. 4, 2010

On Sat, Sep 4, 2010 at 1:53 PM, Konrad Wartke <kwartke(a)googlemail.com> wrote: > attrib.exe: extendended from stub > is now parsing arguments and implements them partly + // FIXME: only display attributes Please use C89 /* comments */. A testsuite for attrib.exe (look at cmd.exe and regedit.exe) would also be helpful. -- -Austin

1 0