September 2010 - Wine-Devel

re: UCS-4 hack not working in resource files.
by Dan Kegel Sept. 10, 2010

Sept. 10, 2010

Please file a bug with a simple example of an rc file that doesn't work.

1 0

UCS-4 hack not working in resource files.
by carlo.bramix＠libero.it Sept. 10, 2010

Sept. 10, 2010

Hello friends, I would like to talk a bit about a (probable) limitation with unicode names when they are used for creating embedded controls in resource files. Let's take for example this piece of code from richedit.h: #if defined(__GNUC__) # define RICHEDIT_CLASS20W (const WCHAR []){ 'R','i','c','h','E','d','i','t','2','0','W',0 } #elif defined(_MSC_VER) # define RICHEDIT_CLASS20W L"RichEdit20W" #else static const WCHAR RICHEDIT_CLASS20W[] = { 'R','i','c','h','E','d','i','t','2','0','W',0 }; #endif Because the famous UCS-4 "issue", the control name is splitted in its single letters. While this can work in almost all situations with C/C++ sources, it is absolutely not possible to put a richedit control in RC files. For example, if I put a Richedit control into a dialog box, it will crash since the letter by letter format won't be recognized by the resource compiler. >From the above example, I was wondering what you think about doing a change like this one: #if defined _MSC_VER || defined RC_INVOKED || sizeof(wchar_t) == 2 # define RICHEDIT_CLASS20W L"RichEdit20W" #elif defined(__GNUC__) # define RICHEDIT_CLASS20W (const WCHAR []){ 'R','i','c','h','E','d','i','t','2','0','W',0 } #else static const WCHAR RICHEDIT_CLASS20W[] = { 'R','i','c','h','E','d','i','t','2','0','W',0 }; #endif We will fall in the first case when the name expressed as string is currently recognized: 1) because we are running under Microsoft Visual C++ 2) because it is used by resource compiler 3) because the string format is currently safe since we are under UCS-2 instead of UCS-4. Perhaps this point is not written as good as you want... I do not know if you prefer to use some informations emitted by configure script or you will prefer to simply check the size of wchar_t. The second case is the specific hack normally used until now with GCC. The third case is the last chance solution, as it was before. I moved the __GNUC__ case after the one used by _MSC_VER because __GNUC__ and RC_INVOKED are both declared in windres. Now I took this fragment from richedit.h as example, but perhaps I have also seen other places where the resource compiler could be "rejected". I believe that this fix actually seems to be very helpful for porting some win32 apps. What do you think? Sincerely, Carlo Bramini.

1 0

Re: fusion:asmname Improve parse_display_name
by Alexandre Julliard Sept. 10, 2010

Sept. 10, 2010

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -522,8 +522,18 @@ static HRESULT parse_display_name(IAssemblyNameImpl *name, LPCWSTR szAssemblyNam > if (!str) > return E_OUTOFMEMORY; > > - ptr = strstrW(str, separator); > - if (ptr) *ptr = '\0'; > + ptr = strchrW(str, ','); > + > + if(ptr && *ptr != ' ') > + *ptr = '\0'; It's unlikely that you would get a space here... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: Update Italian translation (try 2)
by Paul Vriens Sept. 10, 2010

Sept. 10, 2010

On 09/09/2010 07:52 PM, Luca Bennati wrote: > Fix for Paul's comment > Hi Luca, You forgot the patch. -- Cheers, Paul.

1 0

dogfood report: Safari runs youtube, firefox doesn't
by Dan Kegel Sept. 9, 2010

Sept. 9, 2010

So I wanted to quickly try youtube in wine to verify sound was working. I think I used to use Firefox for this, so I did sh winetricks firefox flash and fired it up... but it hung. (And it even hung my desktop once; had to use CTL ALT F1, kill firefox, and ALT F7 to recover. It must have hung while holding an X grab, that mysterious problem described in http://bugs.winehq.org/show_bug.cgi?id=23439#c7 ) Sad face. Happily, sh winetricks safari got me a working browser that can do youtube just fine.

3 3

Re: winedbg: Only add ContextFlags which are defined
by Dmitry Timoshkov Sept. 9, 2010

Sept. 9, 2010

André Hentschel <nerv(a)dawncrow.de> wrote: > CONTROL and INTEGER are standard defines, but ia64 and ARM don't define CONTEXT_FLOATING_POINT ia64 does define CONTEXT_FLOATING_POINT, ARM probably should also do. -- Dmitry.

2 3

Re: user32: Update Italian translation
by Paul Vriens Sept. 9, 2010

Sept. 9, 2010

On 09/09/2010 04:09 PM, Luca Bennati wrote: > Hi Luca, You need to add the UTF-8 pragma: Warning: string "&Sì" seems to be UTF-8 but codepage 1252 is in use. Warning: string "&Più finestre..." seems to be UTF-8 but codepage 1252 is in use. -- Cheers, Paul.

1 0

Re: msxml3: Implement property SelectionNamespaces for XPath
by Alexandre Julliard Sept. 9, 2010

Sept. 9, 2010

Adam Martinson <amartinson(a)codeweavers.com> writes: > +extern inline const struct list* nsList_from_xmlDocPtr(xmlDocPtr doc); Declaring an extern function inline doesn't make much sense. Also it would be more generally useful if it didn't return a const pointer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/7] urlmon/tests: Removed no longer needed todo_wine's
by Paul Vriens Sept. 9, 2010

Sept. 9, 2010

On 09/09/2010 02:46 AM, Thomas Mullaly wrote: > These todo's should have been removed as I implemented each of the > IUriBuilder_{Get/Set}* functions, but, I forgot about them. Hi Thomas, todo_wine's that succeed are marked as failures so that means these are not fixed on (at least) AJ's box as otherwise previous patches would have been rejected. Judging by the test.winehq.org results there are only todo_wine's and no failures on Wine. -- Cheers, Paul.

2 1

Re: msxml3/tests: add lastChild tests
by testbot＠testbot.winehq.org Sept. 9, 2010

Sept. 9, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5160 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:6040: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === WNT4WSSP6 (32 bit domdoc) === domdoc.c:6040: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 === W2KPROSP4 (32 bit domdoc) === domdoc.c:6040: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154

1 0