September 2010 - Wine-Devel

Re: [2/3] comctl32/tab: Fix DRAWITEMSTRUCT filling when large enough extra item data is used (try2)
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix DRAWITEMSTRUCT filling when large enough extra item data is used I'd like to see a test with smaller sizes too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (still try3)
by Jacek Caban Sept. 28, 2010

Sept. 28, 2010

Hi Nikolay, + entry = heap_alloc(sizeof(*entry)); + if (!entry) return E_OUTOFMEMORY; + + /* new header */ + list_add_head(&This->reqheaders,&entry->entry); + + return S_OK; It seems like filling the new header's name and value is missing here. Jacek

1 0

Re: [1/2] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()
by Jacek Caban Sept. 28, 2010

Sept. 28, 2010

Hi Nikolay, On 9/28/10 1:30 PM, Nikolay Sivov wrote: > Resent for series completeness. + hr = VariantChangeType(&str,&user, 0, VT_BSTR); + if (hr == S_OK) + { + This->user = SysAllocString(V_BSTR(&str)); + VariantClear(&str); + } You already own the reference to string in str VARIANT, so you can just use it |This->user = V_BSTR(&str);| and remove VariantClear call. + hr = VariantChangeType(&str,&password, 0, VT_BSTR); + if (hr == S_OK) + { + This->password = SysAllocString(V_BSTR(&str)); + VariantClear(&str); + } Same here. Jacek

1 0

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try3)
by Alexandre Julliard Sept. 28, 2010

Sept. 28, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try3: fixed some test failures > > Should still be applied over [1/2] patch, let me know if I should > resend both. Yes please, otherwise testbot won't be able to figure out the sequence. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5546 Your paranoid android. === W7PROX64 (64 bit environ) === Timeout

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)
by Dmitry Timoshkov Sept. 28, 2010

Sept. 28, 2010

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > + SetLastError(0xdadadada); > + retval = UpdateWindow(NULL); > + ok( !retval, "Expected 0, got %d\n", retval); > + ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /* win9x */, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); It's better to use a commonly accepted 0xdeadbeef as an invalid last error value, and limit the line length somewhere at 80. -- Dmitry.

3 2

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try2)
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5538 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === W2KPROSP4 (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === WXPPROSP3 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5530 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2683: Test failed: GetActiveWindow() = 00000000 win.c:2683: Test failed: GetFocus() = 00000000 win.c:2709: Test failed: GetActiveWindow() = 00000000 win.c:2709: Test failed: GetFocus() = 00000000 win.c:2768: Test failed: GetActiveWindow() = 00000000 win.c:2768: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd + test
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5529 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2683: Test failed: GetActiveWindow() = 00000000 win.c:2683: Test failed: GetFocus() = 00000000 win.c:2709: Test failed: GetActiveWindow() = 00000000 win.c:2709: Test failed: GetFocus() = 00000000 win.c:2768: Test failed: GetActiveWindow() = 00000000 win.c:2768: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000

1 0

Re: ws2_32(3/3): Implement WSAIoctl for SIO_ROUTING_INTERFACE_QUERY
by testbot＠testbot.winehq.org Sept. 28, 2010

Sept. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5526 Your paranoid android. === W2K3R2SESP2 (32 bit sock) === sock.c:2329: Test failed: gethostbyname("w2k3r2sesp2") returned 127.0.0.1 not 127.12.34.56

1 0