January 2011 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: [patch] Support NULL puLen in VerQueryValue
by Andrew Nguyen Oct. 15, 2011

Oct. 15, 2011

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQueryValue with NULL puLen.

3 2

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

CD-ROM ioctl support on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com June 6, 2011

June 6, 2011

Hi, what's the state of CD-ROM support on the Mac? ntdll/cdrom.c contains quite a few #ifdef apple. I'm asking because the mcicda currently uses these ioctl: 1. READ_RAW 2. READ_TOC 3. READ_Q -> POSITION MCICDA could be changed to avoid the third one entirely -- when using the dsound output. Would that be enough to use mcicda on MacOS to play music? Thanks for your help, Jörg Höhle

2 3

Two enhancement requests for winetricks
by Dan Kegel Feb. 21, 2011

Feb. 21, 2011

OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

6 11

USB Device Support
by James Mckenzie Feb. 19, 2011

Feb. 19, 2011

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

re: Wine FAQ edits
by Dan Kegel Feb. 6, 2011

Feb. 6, 2011

Hi Albert, http://wiki.winehq.org/FAQ?action=diff&rev2=384&rev1=383 looks like it was a pretty big edit. Try smaller ones, and try to do just one kind of change per edit.

7 20

RFC: Adding Mac support to secur32/schannel.c
by Ken Thomases Feb. 3, 2011

Feb. 3, 2011

Hi, I'm planning to add an alternative implementation of schannel (SSL/TLS) support for the Mac. The current implementation is based on GnuTLS. That library is not typically found on Mac OS X. Although packagers can build it and ship it and its dependencies with Wine for Mac OS X, I think it's better (especially for security-related functionality) to use the system-provided library. I'm attaching a patch. It is _not_ intended as a proposed commit. It's just a proof-of-concept that shows the direction that I'm going. I plan to introduce a new internal interface (the schan_imp_* stuff in my patch) and incrementally refactor the code to hide uses of GnuTLS behind that interface. Then, I'm thinking of breaking the GnuTLS implementation out into a separate module, schannel_gnutls.c. Then, I'd add a second implementation module, schannel_mac.c, based on the Mac Secure Transport API (as shown in the patch). Each of the two modules would be made "empty" by preprocessor conditionals, as appropriate. I'd appreciate a review of this general plan. Thanks, Ken

8 18

Re: wined3d: Update clip planes when switching to/from offscreen rendering.
by Stefan Dösinger Feb. 2, 2011

Feb. 2, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 31.01.2011 um 15:13 schrieb Matteo Bruni: > It should fix http://bugs.winehq.org/show_bug.cgi?id=25877 > <0001-wined3d-Update-clip-planes-when-switching-to-from-offs.txt> If we change the shader code to write gl_ClipVertex and result.clip before applying the y inversion then we should be able to avoid this. That should also make it more compatible to fixed function vertex processing - here the clipping is performed before the projection matrix is applied. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNRssNAAoJEN0/YqbEcdMwZv8P+wbbhcamRsg42fMzJ02jKLcT s4p19OqKPZEdVvzsfQCe4e7KGgGdZUefMWsY2ib9AK21cQXB3R9fnyl5TMDcuxuh EojJvAQCVd/hgnz7tserUJT6rS/W08BPsdHM4dgxdnhRTzi2FAc7l3NgFOONJXpG i8HfcmD2AgaGOam6Wriv3SD8fM0zrfmpZdJDH1moCefqptEEWD9adwWRSMhaMvTl rlj1gDR9cRC9fsxur2U1f5NuXN0AY+a+5VPQHElZV2bP9ulheoa9nYuXU+8F7OhK RyIJ2DO4vpaLpEbXW/amtUWnlBSk0n7k3F9w/fcthOmUvlPHOBY7i2Ukf4j84vQD AhpN7Yf4cFZaSV8q/gww+U9H1udelidiTEL05OKQJUohnM1F9/cRnXbXmmA5Nuia rQlcCnm12cw1ClykdrY7B/hDCqGOPnnmPp580kW1LlEtidYyGbG35seyHxNqcNcQ RWlvVsGwvlzgex7qWf9hT34KOcUzMKZdlehfvtQn0Fjrcf+/3s5EvrtG4Mw6qHNh aBFNaeB8LkV36hu71r/1yxsqHO+taYt1/Ho8poANYbOplV9FCpd0nXeK8n7rqCPx L5TVgSJVd4n354FlguuIUAiFlXxcxFN2CJlN2Hd4dwhZZhGBh+4LH+XhjUtzX4ge 15usBq4VUhhssvv6dVys =urcm -----END PGP SIGNATURE-----

3 5

Wine FAQ edits
by Albert Lee Feb. 2, 2011

Feb. 2, 2011

Hi Vitaliy, I notice you have reverted my edits to the FAQ on the wiki ( http://wiki.winehq.org/FAQ?action=info ). As I was trying to clarify the shell metacharacter information and operating system/platform support, and add new file association instructions, I would like to know why this happened and what changes should be done. -Albert

2 3

Re: user32: Test for behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Marvin Jan. 31, 2011

Jan. 31, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8777 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Wine Gecko 1.2.0 beta1
by Jacek Caban Jan. 31, 2011

Jan. 31, 2011

Hi all, We're nearing the time for the next Gecko update. Beta builds are done and available on Sourceforge [1]. To use them, you need to download the .cab file, put it as you usually do into the right directory (most likely wine_gecko-1.2.0-beta1-x86.cab, see [2] for details) and apply the attached patch to recent Wine git version. The plan for release is other than we usually did and we have still some work to do. I hope to do the release short after Firefox 4 release, which is scheduled for the end of February. Firefox is nearing final beta and we will branch together with RC branch for Firefox 4. This should give us more stability in the code base than we usually had. We've never succeeded in avoiding regressions with the new Gecko releases and I hope to improve this situation. This early beta build is one part of the plan. It would be great if you could use it for some time or try some apps with it. I'm most interested in reports about regression, but also general stability and improvements. * Changes - We use Firefox 4 beta11pre codebase - Some regression caused by integration with new parser are fixed (affected among others CS4 installer, STO, EQ2) - IO fixes for custom protocol handlers, mostly affecting .chm files and Outlook If you hit a blank-page bug, some page elements don't work or just a crash, there is a big chance that this build will fix it. Of course it's always nice to test everything regardless if it's currently working or not. * TODO - win64 fix It currently crashes, that's a regression. I've decided to do the beta release anyways, but it's an obvious blocker for further releases. I've put win64 builds on Sourceforge in case anyone is interested in looking at them, but the problem seems to be in the build, not in Wine. - MSI packages This beta still uses .cab files done on Windows. We're planning to do some work on it with Hans and Alexandre so that the final release will use MSI files. - dbghelp fixes winedbg has problems with debug info from Gecko debug build, making debugging possibilities quite limited and backtraces lacking most of the calls. This is not related to Gecko release itself, but still it would be great to have it fixed. - Getting rid of ugly hacks that Firefox uses Esp. API hooks. I don't think it's acceptable for us. - Tests and fixes The more tests, the better. I really hope to get community help here. * For packagers If you're considering building the next Gecko release yourself, it's probably a good idea to try the compilation now. It requires very recent mingw-w64, so a package update (or creating a new package if it's not yet available for the distro) will most likely be needed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.2.0-beta1/ [2] http://wiki.winehq.org/Gecko

2 2

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen Jan. 31, 2011

Jan. 31, 2011

Hi Alexandre Julliard, I see you had another idea of how to correct the RtlCaptureStackBackTrace() function. I tested your implementation with Anarchy Online's item store (ingame web browser based on Awesomium) and with AwesomiumGL (sample app from Awesomium's SDK). With AwesomiumGL I did, after a while (scrolling in an image heavy site), got it to crash: wine: Unhandled page fault on read access to 0xfffffffc at address 0x7bc7586b (thread 002e) To file dlls/ntdll/signal_i386.c, line 2438: frame = (ULONG *)*frame; (inside the skipping loop). And, so, if 'frame' is 0xfffffffc, then the added check, unfortunately, will not cut it. With Anarchy Online, I browsed quite a lot within the item store, changing pages, and finally just left the window open for ~20 minutes. No crash so far, so the correction might have worked for the game or then I just didn't wait long enough ;) Should I still add the try-except blocks to RtlCaptureStackBackTrace() and tests for 0xfffffffc value also? Please advice. Best Regards, Janne

2 1

Re: msvcrt: Add type_info::name_internal_method() as alias for ::name()
by Marvin Jan. 31, 2011

Jan. 31, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8775 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 00543C08 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 00533C78 === WVISTAADM (32 bit msvcr90) === msvcr90: unhandled exception c000001d at 00D5129D === W2K8SE (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 01961298 === W7PRO (32 bit msvcr90) === msvcr90: unhandled exception c000001d at 009212A5 === W7PROX64 (32 bit msvcr90) === msvcr90: unhandled exception c000001d at 005212A4

1 0

Re: [PATCH 2/4] d3d9/tests: Check ColorFill() return codes in color_fill_test() (LLVM/Clang).
by Marvin Jan. 31, 2011

Jan. 31, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8768 Your paranoid android. === WXPPROSP3 (32 bit visual) === No test summary line found

1 0

Re: [PATCH] Clarify 'fixme'...
by Charles Davis Jan. 31, 2011

Jan. 31, 2011

On 1/31/11 12:01 PM, max(a)mtew.isa-geek.net wrote: > @@ -2519,7 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("hash matces - collision check needed.\n"); Typo "matces" -> "matches". Chip

1 0

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().
by Alexandre Julliard Jan. 31, 2011

Jan. 31, 2011

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > If there is no current clipping region ExtSelectClipRgn(hdc, hrgn, RGN_DIFF) > creates its own default clipping region which in most cases doesn't match > neither a visible region nor the window extents attached to the DC. It will get intersected with the visible region anyway, so it shouldn't matter as long as it's large enough. Why does it make a difference? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()
by Alexandre Julliard Jan. 31, 2011

Jan. 31, 2011

Peter Schlaile <peter(a)schlaile.de> writes: > Fix: X11DRV_SetDIBits() shouldn't silently change Bitmap protection, so > we now restore the protection bits, that were present before instead of > always changing to READONLY. No, it needs to be read-only so that we can detect further changes. > Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but > should test for alpha channel != 255. No it shouldn't, 0 is correct. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [3/3] d3d9: account for another different behavior in the viewport test
by Stefan Dösinger Jan. 31, 2011

Jan. 31, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I just noticed that I sent the other two mails with my gmail account, so they got stuck in moderation. This patch should apply on its own, but depending on what Alexandre commits today I'll resend the patches after today's commit wave. Am 31.01.2011 um 11:21 schrieb Stefan Dösinger: > The alternative to this patch is to remove the test entirely, as it now accepts all possible outcomes on windows. I prefer to keep it because the behavior it accepts as non-broken(invalid viewport = "default" viewport) is required by some ddraw apps. We also have a test in ddraw, but it isn't quite as straightforward. > > <0011-d3d9-account-for-another-different-behavior-in-the-v.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNRsifAAoJEN0/YqbEcdMwUSAP/2HphIB7RzKXuS/q52t5mCvt b9yFQ/9ci11GWlzWG7okm72Z+hUdC4bIMPxIalWM7/VKPzsSB7Qg2EvwpMTGq0r5 lAX3WFFqWqCNoAZd7JnQO6LqX0TR4wJOCxIjAYSw+WlZW7tYNVFEsw3mPTUxqggR 88wVQ8C5oBAW3Rns6QGYmxyw+R6Xryh3pdukxBP2DS6jQDkqodq9L6JU24YHHy0z OFEZCIAl8VqhTfgTeO5pqJ7e4ujGyT0U25h8rmIuhMt8DFRdxTSE4agib4haFrLb jLEUAVqjSrV4EX1A+iisryBYCCOGpGT9vYKB5Xw169fzkjd2XMQ9C3udE/VznGWo grcWX9CJxm1XzR/AYuNh+pNSq+wZPxwrlJrOmcW4EC1o1X/OdXr+KtZFX2ldkGwF v6LCel4WPN5G4+mKryNnPMRDPo69ccZr2iKTdMQFs7nm0NZGxPNnj3o7eGDP92pq DNUboQ3EoZ3ow9c8vpfeGgxk647jgJwpeOzUKj7ON3l5XyFvoEAAv2pFwRp/lpn8 3ioLYDePd7VBcf6cT9ckI0Qptx2hM8yRyd1r+qC4jGv8ydQnHmAu+w61cmSrpl3X EYpvHmFYEdkJjDKcn2Z1gYekg4RisXcd/CVBWfZHLudpibEab+3NQp7wb+HwNscu 2P/hz0RIdqEC7BBQf6bJ =Vxnq -----END PGP SIGNATURE-----

1 0

Re: [PATCH] [patch] Already in cache means nothing more to do...
by Alexandre Julliard Jan. 31, 2011

Jan. 31, 2011

max(a)mtew.isa-geek.net writes: > @@ -2519,11 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > - FIXME("entry already in cache - don't know what to do!\n"); > -/* > - * SetLastError(ERROR_FILE_NOT_FOUND); > - * return FALSE; > - */ > + error = ERROR_SUCCESS; The entry is not necessarily the same even if the hash matches. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen Jan. 31, 2011

Jan. 31, 2011

Hi again, I've been working to implement the tests for RtlCaptureStackBackTrace(), but I have encountered a problem. The function, according to MSDN should be available only in Windows XP and newer OSes. Now, when I ran these tests on Testbot using all base VMs, the tests were run also on W2KPROSP4 and WNT4WSSP6. However, the function seems to buggy in those. It throws access violation whenever it is not skipping frames. Here's the test patch I used: http://testbot.winehq.org/GetFile.pl?JobKey=8606&StepKey=1 In both cases, test on patch's line 83 failed and call on line 92 crashed the test. In other VMs the tests succeeded and none crashed. Is there some way I could prevent/skip these tests to be run on Windows NT4 and 2000? Best Regards, Janne Hakonen

3 5

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()
by Vitaliy Margolen Jan. 31, 2011

Jan. 31, 2011

On 01/30/2011 04:16 AM, Peter Schlaile wrote: > Hi, > > find fix for a crash in create_alpha_bitmap() attached. If it's easy to reproduce please create a test that demonstrates the problem. > Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but > should test for alpha channel != 255. This should be a separate patch. Vitaliy.

2 2

RFC: Final Proposed Riched20 EM_SETMARGINS Test
by James McKenzie Jan. 31, 2011

Jan. 31, 2011

All: Constructive Criticism requested so that this can be made better. I've decided to use two loops in the test: One for fonts. Second for actual tests. This allows for quick and easy expansion. The check code for font changes might be removed, but does no harm by remaining. This patch is based on git as of Friday, January 28. I could find no font that changed the Margin from zero for the EC_USEFONTINFO lparam test case. If someone knows of a font that will do so, please advise as well so I can include it. Thank you. James McKenzie

1 0

Re: [PATCH 2/2] mshtml: Added support for recursive script runners
by Marvin Jan. 30, 2011

Jan. 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8753 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Policy regarding 3rd party "windows" distributions and winetest
by Dan Kegel Jan. 30, 2011

Jan. 30, 2011

I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience Agreed?

5 6

MapleStory Wine Bug
by Jack Edmonds Jan. 30, 2011

Jan. 30, 2011

I recently submitted a bug (http://bugs.winehq.org/show_bug.cgi?id=25934) I'm not sure if I did a good job on the submission, but if I did, I was thinking it would be a good first bug to work on so as to introduce me to the Wine source code. I was wondering if someone could help me get started on it.

2 1

Re: user32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Marvin Jan. 30, 2011

Jan. 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8728 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x0111 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg 0x0111 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 4: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x002b instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg 0x002b was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 4: the msg sequence is not complete: expected 8000 - actual 0000 === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH 1/2] winecoreaudio: Don't use Component Manager on Mac OS 10.6.
by Charles Davis Jan. 30, 2011

Jan. 30, 2011

On 1/29/11 6:40 PM, James McKenzie wrote: > Chip: > > I'm assuming that this has been checked on Tiger/Leopard and it works. I checked that it would work if the AudioComponent header weren't present (which it isn't pre-SL). > > I don't have a Leopard system here and I'm reluctant to try it on one of > the systems I have Tiger installed on (it is a PowerPC Mac.) I can't imagine why... :) Chip

1 0

RE: shdocvw: Implement IWebBrowser::ExecWB and IWebBrowser::QueryStatusWB.
by Greg Geldorp Jan. 29, 2011

Jan. 29, 2011

From: Greg Geldorp <ggeldorp(a)vmware.com> > From: Erich Hoover > > On Thu, Jan 27, 2011 at 3:53 AM, Greg Geldorp <ggeldorp(a)vmware.com> wrote: > > > ... > > > Looking at http://test.winehq.org/data/tests/shdocvw:webbrowser.html, > > > the shdocvw:webbrowser test doesn't have a history of occasional > > > crashes. There are a few failures, but none of them are due to access > > > violations. Which kind of indicates that the crash is because of the > > > changes you made. > > > I know it sucks to investigate failures that don't repro consistently, > > > but I do think some more testing would be good here. Of course, if > > > there's any info you need about the VM just let me know. > > > > Well, I commandeered a XP SP3 box this morning and ran that exact same > > set of tests successfully 10,000 times. I don't have access to a Win7 > > box or I would have run the tests on that. Thoughts? > > I'll do a similar test on Win7 tomorrow and let you know the results. I started by running your test binary 10,000 times on W7PROX64. Not a single crash, so that looked kind of promising. Just to be sure, I then ran the binary on a dual-core Win7 x64 machine (the W7PROX64 VM has only one core assigned to it). This resulted in an immediate crash. Tried a few more times, it crashed 9 out of 10 times. To make sure that these crashes are related to your patch, I ran the test without your patch on the same dual-core machine. First few tries didn't produce crashes, I then ran it in a loop 10,000 times. Not a single crash. So, it looks like your patch introduces some multi-threading issue. I haven't investigated further, perhaps I'll have some time over the weekend to dig a bit deeper. Greg.

2 3

Re: winex11.drv: When copying window bits exclude an update region only if the parent doesn't clip its children.
by Alexandre Julliard Jan. 29, 2011

Jan. 29, 2011

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1624,7 +1624,8 @@ static void move_window_bits( struct x11drv_win_data *data, const RECT *old_rect > hdc_src = hdc_dst = GetDCEx( data->hwnd, 0, DCX_CACHE ); > } > > - ExcludeUpdateRgn( hdc_dst, data->hwnd ); > + if (!parent || !(GetWindowLongW( parent, GWL_STYLE ) & WS_CLIPCHILDREN)) > + ExcludeUpdateRgn( hdc_dst, data->hwnd ); I don't see what the parent clipping has to do with this. Could you please explain? -- Alexandre Julliard julliard(a)winehq.org

2 1

Ubuntu 10.04 x86-64 test failures -- dsound:ds3d and mmdevapi
by Reece Dunn Jan. 28, 2011

Jan. 28, 2011

=== Observations === 1/ The dsound:ds3d tests fail when using the ALSA audio driver on 64-bit (K)Ubuntu, but succeed with the OSS audio driver. 2/ The mmdevapi tests fail with a "Device not found"/"No driver" error (hr = 0x88780078) when running with the OSS driver. For the mmdevapi failures, the tests should skip when intercepting a "Device not found" error. === Steps to Reproduce === Machine: Ubuntu 10.04 64-bit with NVidia binary drivers. 1/ Build the latest version of wine with no special options -- `./configure && make` 2/ Remove any previously run test result -- `find . -type f | grep .ok | xargs rm` 3/ Ensure running in a clean wine prefix -- `rm -rf ~/.wine` 4/ Run the tests -- `make test` This will download the gecko package and then fail in the dsound:ds3d tests with: ds3d.c:467: Test failed: buffer size changed after SetFormat() - previous size was 88200, current size is 22052 This error seems to be specific to 64-bit versions of the Ubuntu family, looking at the http://test.winehq.org/data/ results. 5/ Open winecfg -- `./wine winecfg` 6/ Select the Audio tab This should being up a message to recommend a driver (as no driver is set in the registry) and then select the ALSA driver. 7/ Switch the audio driver from ALSA to OSS and press OK. 8/ Re-run the tests -- `make test` This passes the ds3d tests, but fails with: ../../../tools/runtest -q -P wine -M mmdevapi.dll -T ../../.. -p mmdevapi_test.exe.so dependency.c && touch dependency.ok err:quartz:DSoundRender_create Cannot create Direct Sound object (88780078) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88780078 dependency.c:85: Test failed: Activating bf failed: 0x88780078 9/ Open winecfg -- `./wine winecfg` 10/ Switch the audio driver from OSS back to ALSA and press OK. 11/ Re-run the tests -- `make test` The mmdevapi tests now pass. - Reece

3 4

Re: Alexander Scott-Johns : ole32: Add support for rendering METAFILEPICT clipboard objects.
by Nikolay Sivov Jan. 28, 2011

Jan. 28, 2011

On 1/28/2011 21:30, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 0f4fbd30f6bf3d2ef471d3d75307c7fa8a7df137 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=0f4fbd30f6bf3d2ef471d3d75… > > Author: Alexander Scott-Johns<alexander.scott.johns(a)googlemail.com> > Date: Tue Jan 25 15:09:21 2011 +0000 > > ole32: Add support for rendering METAFILEPICT clipboard objects. > > --- > dlls/ole32/clipboard.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 96 insertions(+), 1 deletions(-) > > +/*************************************************************************** > + * get_data_from_metafilepict > + */ > +static HRESULT get_data_from_metafilepict(IDataObject *data, FORMATETC *fmt, HGLOBAL *mem) > +{ > + HGLOBAL copy; > + HRESULT hr; > + FORMATETC mem_fmt; > + STGMEDIUM med; > + > + *mem = NULL; > + > + mem_fmt = *fmt; > + mem_fmt.tymed = TYMED_MFPICT; > + > + hr = IDataObject_GetData(data,&mem_fmt,&med); > + if(FAILED(hr)) return hr; > + > + hr = dup_metafilepict(med.u.hMetaFilePict,&copy); > + if(FAILED(hr)) return hr; 'med' should be released here on failure. > + > + *mem = copy; > + > + ReleaseStgMedium(&med); > + > + return hr; > +} > + > /***********************************************************************

1 0

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry
by Eric Pouech Jan. 28, 2011

Jan. 28, 2011

Le 19/01/2011 13:07, Alexandre Julliard a écrit : > Eric Pouech<eric.pouech(a)orange.fr> writes: > >> you mean hardwiring the missing keys (potentially different according to >> terminal type) in the code? > If they depend on terminal type they belong in terminfo, not in the > registry. > as I said, terminfo is not fully populated it misses lots of ctrl-<key> (left arrow, right arrow...) and has not been updated lately most of the common text editors come with their own config files for example, /etc/inputrc has the missing bindings for libreadline (and of course it depends on $TERM) so, updating terminfo isn't the solution would you consider inclusion in hklm (instead of hkcu) ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: [PATCH 2/2] msvcrt: Use the _set_error_mode value to switch between a dialogbox and stderr for C runtime messages
by Alexandre Julliard Jan. 28, 2011

Jan. 28, 2011

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -134,8 +135,9 @@ static void DoMessageBox(LPCSTR lead, LPCSTR message) > void CDECL _amsg_exit(int errnum) > { > TRACE("(%d)\n", errnum); > - /* FIXME: text for the error number. */ > - if (MSVCRT_app_type == 2) > + > + if ((MSVCRT_error_mode == MSVCRT__OUT_TO_MSGBOX) || > + ((MSVCRT_error_mode == MSVCRT__OUT_TO_DEFAULT) && (MSVCRT_app_type != 1))) If you want to change the app type check that should be a separate patch, with its own justification. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: User32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Vitaliy Margolen Jan. 28, 2011

Jan. 28, 2011

On 01/27/2011 11:51 PM, Alexander LAW wrote: > > > + if (style & WS_VISIBLE) { > + HDC hdc = GetDC(hWnd); > + HBRUSH hbrush; > + RECT client, rc; > + HWND parent = GetParent(hWnd); Please follow the style of the file - curly brace goes on a separate line. Please if you can't set your editor to have tab character equal 8 spaces - don't use tabs! Use space characters only. > + if (!parent) parent = hWnd; > + UINT ctlMessage=((btn_type==BS_PUSHBUTTON || > btn_type==BS_DEFPUSHBUTTON || btn_type==BS_PUSHLIKE)?WM_CTLCOLORBTN: > WM_CTLCOLORSTATIC); This is not c++ inline declarations are not allowed. Please cut this line down it's too long. Also please add corresponding test to msg.c tests to validate the change. Vitaliy.

1 0

Re: winex11.drv: Implement synthesizing the CF_ENHMETAFILE clipboard format from CF_METAFILEPICT.
by Vitaliy Margolen Jan. 28, 2011

Jan. 28, 2011

On 01/27/2011 07:42 PM, Alexander Scott-Johns wrote: > > > > > + FIXME("Called to synthesize unknown format 0x%08x\n", wFormatID); Formats defined as decimal, so you should print it as decimal. > + if ((lpSource = X11DRV_CLIPBOARD_LookupData(CF_ENHMETAFILE)) && lpSource->hData) > + { > + bret = TRUE; > + } Just do "return TRUE". It will remove one level of indentation. > + void *mf_bits = HeapAlloc(GetProcessHeap(), 0, size_mf_bits); > + GetMetaFileBitsEx(pmfp->hMF, size_mf_bits, mf_bits); Please check if allocation succeeded. Vitaliy.

1 0

Re: [PATCH 1/2] msvcrt: Add private define and header tests for _set_error_mode options
by Marvin Jan. 28, 2011

Jan. 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8692 Your paranoid android. === WNT4WSSP6 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2KPROSP4 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === WXPPROSP3 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2K3R2SESP2 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === WVISTAADM (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2K8SE (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PRO (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PROX64 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PROX64 (64 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2

1 0

Re: [1/2] shell32: Implement IShellDispatch::NameSpace
by Marvin Jan. 28, 2011

Jan. 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8684 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] winecoreaudio: Fix deprecation warnings.
by Alexandre Julliard Jan. 28, 2011

Jan. 28, 2011

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -198,10 +222,19 @@ int AudioUnit_CreateInputUnit(void* wwi, AudioUnit* out_au, > UInt32* outFrameCount) > { > OSStatus err = noErr; > +#ifdef HAVE_AUDIOUNIT_AUDIOCOMPONENT_H > + /* Apple has threatened to rip out the Component Manager. > + * Protect ourselves from that. > + */ > + AudioComponentDescription description; > + AudioComponent component; > +#else > ComponentDescription description; > Component component; > +#endif It would be better to have a set of compatibility defines at the top instead of spreading #ifdefs all through the code. And please split independent changes into separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Where can I get OpenCL for Fedora 14.
by Max TenEyck Woodbury Jan. 28, 2011

Jan. 28, 2011

For the first time in several years, I did a fresh install on this machine and I am in the process of getting all the tweaks back in place. Part of that process is assuring that wine's configure script has all the pieces it can use. I have found almost everything. What I am missing is OpenCL (that is C as in Charles). I see stuff for Apple, but not for Fedora.i386 (cpu is intel.core2 and an Nvidia card). Search results are inconclusive - I checked the first five pages and found nothing specifically about .rpm files. Where can I get an .rpm or tarball that contains a usable OpenCL implementation for Fedora 14? Max

6 8

Wine Source Study
by Pankaj Swami Jan. 28, 2011

Jan. 28, 2011

Please help me..... I am last year Computer Engineering student & I want to study wine source code but I'm unable to decide from where to start studying wine source code.........? I have wine source code.

1 0

Another milestone
by Greg Geldorp Jan. 28, 2011

Jan. 28, 2011

Today we had a clean winetest.exe run on all 31 TestBot VMs for the first time. Although there are still failures on other test machines and some tests fail occasionally on TestBot, I still think this is a significant milestone. Hopefully the "Wine" column on http://test.winehq.org/data/ will soon start to show some yellow spots too! Greg.

2 1

Re: msvcrt: Forward _realloc_crt to realloc
by Marvin Jan. 27, 2011

Jan. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8669 Your paranoid android. === WVISTAADM (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 77497580 === W2K8SE (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 778A814C === W7PRO (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 772D2B79 === W7PROX64 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 77E03100 === W7PROX64 (64 bit msvcr90) === No test summary line found

1 0

Re: [4/4] gdi32: Move common code into helper function.
by Nikolay Sivov Jan. 27, 2011

Jan. 27, 2011

On 1/27/2011 12:23, Kusanagi Kouichi wrote: > On 2011-01-26 19:28:29 +0300, Nikolay Sivov wrote: >> On 1/26/2011 19:09, Kusanagi Kouichi wrote: >>> -static LPSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT pByteLen) >>> +static LPWSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT pLen) >>> { >> It's better to change naming too, since it's won't return char >> string anymore. > What name do you think is better? > Is FONT_GetCharsByRange or FONT_GetCharsByRangeAToW OK? I think FONT_GetCharsByRangeW would be fine. Note that I don't know this code, and probably it should be done another way to avoid conversion in a first place (if possible at all).

1 0

Re: shdocvw: Implement IWebBrowser::ExecWB and IWebBrowser::QueryStatusWB.
by Erich Hoover Jan. 27, 2011

Jan. 27, 2011

On Thu, Jan 27, 2011 at 3:53 AM, Greg Geldorp <ggeldorp(a)vmware.com> wrote: > ... > Looking at http://test.winehq.org/data/tests/shdocvw:webbrowser.html, the > shdocvw:webbrowser test doesn't have a history of occasional crashes. > There are a few failures, but none of them are due to access violations. > Which kind of indicates that the crash is because of the changes you > made. > I know it sucks to investigate failures that don't repro consistently, > but I do think some more testing would be good here. Of course, if there's > any info you need about the VM just let me know. Well, I commandeered a XP SP3 box this morning and ran that exact same set of tests successfully 10,000 times. I don't have access to a Win7 box or I would have run the tests on that. Thoughts? Erich Hoover ehoover(a)mines.edu

2 1

Re: [ActiveX] Wine builtin IE crash while login to https://www.alipay.com/
by Jacek Caban Jan. 27, 2011

Jan. 27, 2011

Hi Qian, On 1/26/11 9:06 AM, Qian Hong wrote: > However, sence Wine buitin IE began to support ActiveX, I have also > tested alipay.com with wine buitin IE, just for reporting. Support for ActiveX in Wine IE is a fairly new feature and it still quite limited. Honestly I've tested it mostly with Flash ActiveX version (which was my main interest in implementing it). I don't expect much more to work, but I'd be interested in results of real-world tests with other controls/requirements. Please file a bug about it (in mshtml component) and CC me. Jacek

1 0

Re: [ActiveX]crash while open https://mybank.icbc.com.cn/icbc/perbank/index.jsp use wine buitin IE
by Saulius Krasuckas Jan. 27, 2011

Jan. 27, 2011

* On Thu, 27 Jan 2011, Juan Lang wrote: > > > By the way, will wine builtin IE support vbscript in the future? ICBC > > online bank required vbscript. > > That's a pretty open-ended question. I haven't seen anyone volunteer > to work on this in some time, so I'd say the odds are not so good. ABBYY FormFiller software (used to fill data for electronic tax declaration system at the state level in our country) also requires vbscript.dll to parse data validation rules. There is workaround, though. You just run "winetricks wsh56vb". S.

3 2

Re: shell32/tests: Remove shlwapi dependency
by Marvin Jan. 26, 2011

Jan. 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8618 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: winex11.drv: initialize drawable (clang)
by Henri Verbeet Jan. 25, 2011

Jan. 25, 2011

2011/1/25 André Hentschel <nerv(a)dawncrow.de>: > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > then the if condition is reliable I don't think that can happen unless hwnd is NULL and top is non-NULL, which looks like invalid input to me.

2 1

Re: kernel32: Removing - key from keybindings.
by Trygve Vea Jan. 25, 2011

Jan. 25, 2011

On Tue, Jan 25, 2011 at 8:35 PM, Trygve Vea <trygve.vea(a)gmail.com> wrote: > Fixes bug 25856, introduced in 2a219b948c451213fb4554352b86f3784a8f7e32. > It seems that Eric Pouech already posted an identical patch, which has been applied. This is then unnecessary. I apologize for the noise. -- Trygve Vea

1 0

wine-patches
by Vincent Hardy Jan. 25, 2011

Jan. 25, 2011

Hi, I sent this email on wine-patch but... nothing. Am I doing something wrong ? Am I blacklisted ? Vincent

2 1

Re: po: Update the Dutch translation
by Alexandre Julliard Jan. 25, 2011

Jan. 25, 2011

Sven Baars <sven.wine(a)gmail.com> writes: > Hey, > > All those po editors piss me off. First, the changes I make don't get > saved, then they do get saved but magically disappear when I try to > send them. Now I used poedit, which is apparently the only one that > works, and this one makes whole bunch of changes by itself. > > If this unacceptable, could someone please tell me how to work with > this stuff? Or would it be better to just use a normal editor? Maybe > emacs? And how could I recover the actual changes I made (and not the > ones poedit made) if this patch is not acceptable? You should run it through msgmerge before sending. Something like msgmerge nl.po wine.pot > nl.po.new -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)
by Loïc Maury Jan. 25, 2011

Jan. 25, 2011

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..6a6d8e0 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + /* At this point, we know that we have media, because in Mac OS X, the + * device file is only created when media is present. */ + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

4 5

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 4)
by Loïc Maury Jan. 25, 2011

Jan. 25, 2011

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

1 0

Re: [Bug 25402] Woody Two Legs crashes with unimplemented function msvcr90.dll._wcslwr_s
by Eric Pouech Jan. 25, 2011

Jan. 25, 2011

the spec should read wstr instead of ptr A+ 2011/1/25 <wine-bugs(a)winehq.org> > http://bugs.winehq.org/show_bug.cgi?id=25402 > > Andrew Millington <andrew.millington(a)gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Keywords| |patch > > --- Comment #5 from Andrew Millington <andrew.millington(a)gmail.com> > 2011-01-25 01:23:06 CST --- > After applying http://source.winehq.org/patches/data/70240 it complains > about > unimplemented function d3dx9_36.dll.D3DXFloat32To16Array and that is bug > #25769. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are watching all bug changes. > > > -- -- Eric Pouech

1 0

Re: [PATCH 2/4] wined3d: Add support for the NULL format.
by Stefan Dösinger Jan. 25, 2011

Jan. 25, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 24.01.2011 um 18:41 schrieb Henri Verbeet: > - if (surface) > + if (surface && surface->resource.format->id != WINED3DFMT_NULL) Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a color attachment. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNPqNaAAoJEN0/YqbEcdMwWFwP/0KW7THyiplBKi6csC7b6qWi i7Bi3VG5UMRomIDUyWMTlH+mwLqP7+AchzVYEHAM/blhe5yqemDc2YAN2f2/aNtV cbWoaIilTNF3PKH11wVvtUowidrwHmr9eV+SmHplvhdpJCTGKqU0ZxmNgl2DDiSD iPVfCmL6RE1e5n9i11AH7aQIcZjwPTEQBQlLR5IB1zpcnXab0r7vyTU44f0HkcJ0 785ast6QuG7lawibe7PmRz41VcFCtSMZF3QGgEujAn+frtYhqjVLdP8LITWZ+1mL jPfCWEQX1vlgbdMogykfnKSfm5oxaDMsrU3vMskwUGWFZCX+M7ffHIfy7cpy8HUt YVz4kqeaLr1xeZEsEaAQqjNal1PXoJCJSVA6ckV7VhB0+OkXpcH4i8ifdCtRv1PJ 0V/vryBBQgM9AczBQI8lb1c7w7lQL9EzttpNwbbC3mBTsT3/7EHJRuxR8EStIgzC 8gyTXveyBGuJel8Bwx6M+tBSskCNKFzPN7MKkvIE2+X5NSYj5eI05GSQRMl/eush jZWe+ls9GYgl76bL8+By1RRTsXGizPdW8UnX6HhzMfBErU1Z7IZbbqEiTMgXFOJL 0v0UXfLecE/mHlgrauk7b0C51JMtTXq5uuSOQ8uxFz/t2KcElja6pY4/nkN3DoLe I/cZaSyeQ3B5lTVTeZt/ =UA0G -----END PGP SIGNATURE-----

2 1

Static analysis scan
by Amine Khaldi Jan. 24, 2011

Jan. 24, 2011

Hello folks, I've set up a static analysis scan using clang static analyzer. The results are available at http://austinenglish.com/logs/clang_analyzer/index.html thanks to Austin for the web space. Please feel free to fix the defects. I'll run future scans when the defects get fixed progressively. Have fun ;) With best regards, Amine.

2 1

Re: oleaut32/typelib2: Use implementation pointer to trace ICreateTypeInfo2
by Michael Stefaniuc Jan. 24, 2011

Jan. 24, 2011

Hello Nikolay, On 01/24/2011 01:01 AM, Nikolay Sivov wrote: > Use implementation pointer to trace ICreateTypeInfo2 > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index 8260ef2..5c843a1 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -2322,6 +2321,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnAddVarDesc( > > /* increment the number of variable elements */ > This->typeinfo->cElement += 0x10000; > +ERR("count=%d\n", This->typeinfo->cElement); this looks like some leftover debug line. > > return status; > } bye michael

2 1

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.
by Jacek Caban Jan. 24, 2011

Jan. 24, 2011

On 1/18/11 7:31 PM, Erich Hoover wrote: > On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban <jacek(a)codeweavers.com <mailto:jacek(a)codeweavers.com>> wrote: > ... > I'm not sure what you mean by "hijack the IOleCommandTarget". All we do is implementing client's IOleCommandTarget. It's something different from document's one. > I understand that, but apparently the native implementation (testing on the test bot WXPPROSP3) sends the command to the client > IOleCommandTarget instead of the document IOleCommandTarget (at least under the conditions of the webbrowser tests). That is what I mean by hijacking, the command is going to the "wrong" target. My guess would be that there is some sort of priority mechanism, though I have no idea how it would work (except maybe "if there's a client/container then send to that target, else send to the document target). That sounds reasonable. > I've attached a test where I disabled the client/container, and you > can see that it then gets passed through (QueryStatusWB will return success instead of passing through the client target and returning failure): > https://testbot.winehq.org/JobDetails.pl?Key=8408 Hmm, it means that another run of tests (at least required subset of existing test_WebBrowser) with client's IOleCommandTarget disabled would be interesting. Do you feel like writing it? Otherwise we'd need at least a FIXME in this case. Jacek

2 5

Re: gdi32: Prevent character code from wrapping around.
by Alexandre Julliard Jan. 24, 2011

Jan. 24, 2011

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > If lastChar is 0xffffffff, FONT_GetCharsByRangeA falls into > infinite loop and crash. You probably want more sanity checks (with tests), characters above 0xffff wouldn't make sense anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] To: wine-patches@winehq.org
by Alexandre Julliard Jan. 24, 2011

Jan. 24, 2011

Eric Pouech <eric.pouech(a)orange.fr> writes: > [Kernel32]: in bare console with curses, ensure control stream is sent to tty (even when some fd:s are redirected) There doesn't seem to be much point in initializing input if we can't see the output. On the contrary, I think we should err on the side of not initializing anything unless really necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Questioning the depth_clamp_test in d3d8:visual
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 24, 2011

Jan. 24, 2011

Hi, Trying to understand bugs #10636 and #19773 , I glanced at the d3d8 visual.ok directx test results. It appears that the green colour on test.winehq does not mean much. - All (any exception?) WTB machines skip the tests because d3d8 is not installed. - Same for Francois Gouget's virtual machines. That alone explains green colour. - Wylda's *real* machine #1 (NVidia gfx) produces 5 errors: visual.c:1411: Test failed: color 0x00ffffff. visual.c:1413: Test failed: color 0x00ffffff. visual.c:1415: Test failed: color 0x00ffffff. - "geniuh"'s (NVidia) machine as well. - Saulius' (NVidia) XP and w7 machines shows only these 3 errors. - Wylda's Intel-based machine #2 passes the tests. Hurray! - One unknown win7 machine with Intel gfx also passes them. - Aurimas' machine produces one different error (also Intel gfx). BTW, Wylda recently mentioned that the d3d tests produce vastly different graphics on his 2 machines. My conclusion: the tests only prove that Wine wants to mimic Intel graphics, but they do not account for the variety of observed test results. Danger: one may draw false conclusions from the ok() and wrongly generalize supposed behaviour of the tested functions. Looking at Wine test data (from 1.3.12), it appears that Wine implements exactly the opposite behaviour: the NVidia (+ 1 ATI) machines pass the tests, e.g. behave like Intel on native, while the Intel gfx one (eeepc) produces the 3 errors known from native NVidia! This smells wrong... Regards, Jörg Höhle

3 2

Re: server: fix connect failures on newer kernels
by Marcus Meissner Jan. 24, 2011

Jan. 24, 2011

On Mon, Jan 24, 2011 at 12:21:15AM -0500, Mike Kaplinskiy wrote: > For some reason the newer kernels report POLLOUT|POLLERR|POLLHUP when > connect() fails. Strip the POLLOUT in this case. This (hopefully) > fixes bug 25456. > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 1b81544..3c6425e 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -3965,7 +3965,7 @@ static void test_ConnectEx(void) > closesocket(listener); > listener = INVALID_SOCKET; > > - address.sin_port = 1; > + address.sin_port = htons(1); > > bret = pConnectEx(connector, (struct sockaddr*)&address, addrlen, NULL, 0, &bytesReturned, &overlapped); > ok(bret == FALSE && GetLastError(), "ConnectEx to bad destination failed: " > diff --git a/server/sock.c b/server/sock.c > index d37a316..134efb0 100644 > --- a/server/sock.c > +++ b/server/sock.c > @@ -388,6 +388,9 @@ static void sock_poll_event( struct fd *fd, int event ) > > if (sock->state & FD_CONNECT) > { > + if (event & POLLOUT && event & (POLLERR|POLLHUP)) > + event &= ~POLLOUT; Add more braces to make the operator precedence a bit more clear... (just a style issue though) Ciao, Marcus

2 1

new winetricks 20110123: work around bug in wine-1.3.12. new winetricks-alpha 20110123: ditto, plus new verbs cnc3_demo, guildwars, hphbp_demo, nfsshift_demo, sims3, spotify, vc2005trial
by Dan Kegel Jan. 24, 2011

Jan. 24, 2011

Another week, another winetricks. This release is mainly to add a workaround for http://bugs.winehq.org/show_bug.cgi?id=25838 in wine-1.3.12, which broke winetricks. winetricks-alpha version 20110123 adds the following new verbs: cnc3_demo: Command and Conquer 3 demo guildwars: Guild Wars hphbp_demo: Harry Potter Half Blood Prince demo nfsshift_demo: Need For Speed: Shift demo sims3: The Sims 3 spotify: the popular music service vc2005trial: Visual C++ 2005 Trial winetricks version 20110123 adds no new verbs. Both scripts can be downloaded from winetricks.org at the obvious urls: http://winetricks.org/winetricks http://winetricks.org/winetricks-alpha (The old download url at kegel.com/wine/winetricks still works, too.) Bug tracker and svn repository are at http://winetricks.googlecode.com ----------------------------------- Changelog for winetricks-alpha: Dan Kegel: Work around wine bug 25838 :-( Ported verbs hphbp_demo, sims3 from wisotool Fix mingw PATH (again) Add example to help for 'list' command w_download{,_manual}: get rid of need to specify package name. w_download_manual: open destination folder in desktop for user python26_comtypes: metadata should be "year", not "date". Shortened title for psdkwin7 to fit window. Shannon Vanwagner: New verb spotify Phil Blankenship: Ported verbs cnc3_demo, guildwars, nfsshift_demo, vc2005trial from wisotool. ----------------------------------- Changelog for winetricks: Dan Kegel: Work around wine bug 25838 :-( Austin English: update opensymbol url/sha1sum ----------------------------------- Enjoy!

1 0

wine-1.3.12 broke winetricks :-(
by Dan Kegel Jan. 24, 2011

Jan. 24, 2011

Looks like wine-1.3.12 went out without the fix for http://bugs.winehq.org/show_bug.cgi?id=25838 I've checked a workaround into winetricks, and will do a release, but I bet a few users will be confused...

1 0

3Dmark2001se & heap corruption
by wylda＠volny.cz Jan. 23, 2011

Jan. 23, 2011

Hi, as there is a strong Valgrind wave these days ;) and i failed to find the problem myself here is a little exercise for anyone interested: 1. WINEDEBUG=warn+heap wine 3DMark2001SE.exe 2. Under selected test -> (click) Clear -> (tab) Custom -> (check) "Game2 Dragothic Low Detail" -> OK 3. (click) Benchmark At the end, console is flooded by many: Heap 0x110000: block 0x2c41070 tail overwritten at 0x2c410a1 (byte 0/15 == 0x00) Heap 0x110000: block 0x1c46b08 tail overwritten at 0x1c46b39 (byte 0/39 == 0x00) W.

4 6

re: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Dan Kegel Jan. 23, 2011

Jan. 23, 2011

Hi Janne, I haven't reviewed your code, but I can suggest sending each patch as a separate message to wine-patches, and using titles more like ntdll: test corrupt stack frame in RtlCaptureStackBackTrace() ntdll: handle corrupt stack frame in RtlCaptureStackBackTrace() and mention clearly that this fixes the online store in Anarchy Online (if it does). Also, please send the test patch by itself through winebot before posting and verify that it passes on all flavors of windows. See http://wiki.winehq.org/SubmittingPatches Thanks!

2 1

Re: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)
by Marvin Jan. 23, 2011

Jan. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8488 Your paranoid android. === WNT4WSSP6 (32 bit device) === device.c:168: Test failed: DirectInputCreate() failed: 80040154

3 5

Winetricks game verbs - good or bad? (was: Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, ...)
by Dan Kegel Jan. 23, 2011

Jan. 23, 2011

On Mon, Jan 17, 2011 at 7:33 PM, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > On 01/17/2011 11:30 AM, Dan Kegel wrote: >> New version 20110117-alpha adds the following new verbs: >> >> firefox4 - beta9 of Firefox's new web browser >> ut3 - the first-person shooter Unreal Tournament 3 (requires dvd) > > Isn't that exactly why we marked all other scripts like this a "third party > unsupported tools"? I suspect PlayOnLinux got the cold shoulder because they use old versions of wine, they use their own patches, they don't have a 'real' version control system for game scripts, and they didn't communicate with the wine community. So problem reports from PlayOnLinux users weren't very helpful for Wine developers. Winetricks doesn't encourage users to run old or patched wine, and I'm not a stranger on wine-devel. In fact, if we play our cards right, winetricks might actually reduce the number of clueless support requests. People have trouble following the HOWTOs in the appdb. A winetricks verb for a game should be like a perfectly automated little implementation of the HOWTO, with bug workarounds clearly marked, and skipped automatically when using new enough wine. Better still, since it's automated, we can run it nightly to make sure it doesn't break. What concrete problems do you see with winetricks having verbs for popular games? - Dan

2 3

FYI: GCC-4.6 rebuild tests
by Susan Cragin Jan. 23, 2011

Jan. 23, 2011

GCC-4.6 has more build failures than mine. Here's the info. They don't test wine, apparently. It's not on the list. Maybe I can add it, or get it added. -----Forwarded Message----- >From: Matthias Klose <doko(a)ubuntu.com> >Sent: Jan 19, 2011 10:28 AM >To: ubuntu-devel <ubuntu-devel-announce(a)lists.ubuntu.com>, ubuntu-devel <ubuntu-devel(a)lists.ubuntu.com> >Subject: GCC-4.6 rebuild tests > >[ Note that GCC-4.6 will not be used for natty / 11.04, but > we consider using this version for the O-series / 11.10 ] > >A test rebuild of natty/main using the current GCC version from the trunk was >finished last week. While only one internal compiler error was found, some more >build failures were seen due to new warnings and more strict frontends. A list >of build failure can be seen at > >http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-201101… > >If a package appears in the `superseded' section, it doesn't mean that the build >failure with GCC-4.6 is fixed. > >Some comments and hints for fixes can be found at > > https://wiki.ubuntu.com/GCC4.6 > >Please extend the wiki page if appropriate. > >To work on the build failures, please use either the gcc-snapshot package from >natty or the gcc-4.6 package from the ubuntu-toolchain-r/test PPA. > >A large number of build failures is seen for packages building with -Werror. The >compiler packages above were changed to add a -Wno-error=unused-but-set-variable >when -Werror is found. Despite this local change the these packages need to >build without this local change. > > Matthias > >PS: Fixing build failures with GCC-4.5 in natty should still have priority ;) > >-- >ubuntu-devel-announce mailing list >ubuntu-devel-announce(a)lists.ubuntu.com >https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-announce

2 1

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case
by André Hentschel Jan. 23, 2011

Jan. 23, 2011

Am 23.01.2011 18:20, schrieb Janne Hakonen: > Hi, > > This is my first attempt to post patches to Wine and it would be great if you could review these. > > First patch (0001-2-2-ntdll-Added-try-except-blocks-to-RtlCaptureStackBa.txt) is a correction to a crash situation where application crashes if RtlCaptureStackBackTrace() is called and one of the frame pointers of call stack is invalid, pointing usually to 0xffffffff, sometimes to other invalid locations. > The correction wraps the offending code inside __try â�� __except blocks so that a resulting access violation is caught before it can crash the calling application. > > Second patch (0002-1-2-ntdll-tests-Added-a-test-for-RtlCaptureStackBackTr.txt) is a test case for the correction. > It changes one of the frame pointers to invalid value and then calls RtlCaptureStackBackTrace(). The test fails on Wineâ��s HEAD (without the first patch), but passes successfully on Windows 7. Havenâ��t tested this on other OSes. I created a new signal.c file for the test case under ntdll/tests since I couldnâ��t find more fitting place. > > This crash can be reproduced with Anarchy Online game when trying to open an in-game browser. Also reproducible with AwesomiumGL sample application from Awesomiumâ��s SDK. The crash (among other problems) is reported to bugzilla at: http://bugs.winehq.org/show_bug.cgi?id=25206. > > Best Regards, > Janne Hakonen Hi and welcome to wine development! First i see is that your mail application wrapped the patch ( that is when long likes brake down into the next line ). Then you have a whitespace issue in the makefile i think... further you should consider using IsBadReadPtr instead of try...except, but i'm not sure if that would work. If you solved the issues, you can send the patch to wine-patches(a)winehq.org and can track the status at source.winehq.org/patches -- Best Regards, André Hentschel

2 1

Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen Jan. 23, 2011

Jan. 23, 2011

Hi, This is my first attempt to post patches to Wine and it would be great if you could review these. First patch (0001-2-2-ntdll-Added-try-except-blocks-to-RtlCaptureStackBa.txt) is a correction to a crash situation where application crashes if RtlCaptureStackBackTrace() is called and one of the frame pointers of call stack is invalid, pointing usually to 0xffffffff, sometimes to other invalid locations. The correction wraps the offending code inside __try – __except blocks so that a resulting access violation is caught before it can crash the calling application. Second patch (0002-1-2-ntdll-tests-Added-a-test-for-RtlCaptureStackBackTr.txt) is a test case for the correction. It changes one of the frame pointers to invalid value and then calls RtlCaptureStackBackTrace(). The test fails on Wine’s HEAD (without the first patch), but passes successfully on Windows 7. Haven’t tested this on other OSes. I created a new signal.c file for the test case under ntdll/tests since I couldn’t find more fitting place. This crash can be reproduced with Anarchy Online game when trying to open an in-game browser. Also reproducible with AwesomiumGL sample application from Awesomium’s SDK. The crash (among other problems) is reported to bugzilla at: http://bugs.winehq.org/show_bug.cgi?id=25206. Best Regards, Janne Hakonen

1 0

Re: gdi32/tests: Skip font metrics test on non-English systems
by Dmitry Timoshkov Jan. 23, 2011

Jan. 23, 2011

"Greg Geldorp" <ggeldorp(a)vmware.com> wrote: > --- > dlls/gdi32/tests/font.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) That test is supposed to pass at least on russian locale. On which locale does the test fail for you? -- Dmitry.

2 4

Re: Wine: Downgrade lack of libxslt from configure warning to notice.
by Marcus Meissner Jan. 23, 2011

Jan. 23, 2011

On Wed, Jan 19, 2011 at 11:37:17PM +0100, Gerald Pfeifer wrote: > On Sat, 28 Jun 2008, Gerald Pfeifer wrote: > > [ Still running into this, and compared to the others where we only > > use WINE_NOTICE_WITH, like CUPS or HAL this really seems very low > > importance. ] > > > > On a test system of mine which does not feature too many packages I am > > getting the following: > > > > configure: libsane development files not found, scanners won't be supported. > > configure: libgphoto2 development files not found, digital cameras won't be supported. > > configure: libldap (OpenLDAP) development files not found, LDAP won't be supported. > > configure: libcapi20 development files not found, ISDN won't be supported. > > configure: WARNING: libxslt development files not found, xslt won't be supported. > > > > Looking that libxslt only seems to be used by msxml3, I am wondering > > whether this really is worth a warning? > > > > How about the patch below? > > So I found this older patch of mine in a TODO folder and am wondering > whether it can be considered. It not, that's fine too and I'll remove > it over here; an explicit NACK would be nice in that case. As libxslt missing reduces the msxml3 functionality it is definitely worth a warning. Ciao, Marcus

1 0

USB architecture: driver loading question
by Damjan Jovanovic Jan. 23, 2011

Jan. 23, 2011

Hi There's essentially 2 ways USB could work in Wine[1]: 1. Process per driver, but special-case loading and initializing USBD.SYS Like my previous patchset: http://www.winehq.org/pipermail/wine-patches/2010-November/095883.html http://www.winehq.org/pipermail/wine-patches/2010-November/095884.html 2. Dedicated process for USB, in which USBD.SYS loads first, and it loads USB device drivers (possibly > 1) into the same process as the need arises. What's the right way? Which approach is going to get my patches accepted? Thank you Damjan [1] Because the steps are as follows: 1. USB device is plugged in 2. USB hub driver looks up the driver based on the device class/vendor/product IDs 3. The device driver gets loaded and DriverEntry() gets called on it 4. AddDevice() gets called on the driver, specifying the device 5. Only then, the driver calls things lower in the stack, to do USB I/O The driver needn't load any other driver in its DLL import table, and even if it did, drivers loaded through the import table don't have their DriverEntry() called, so they cannot do anything on load. Even if we rely on most USB drivers loading USBD.SYS, USBD.SYS needs to do steps 1-4 first, but it wouldn't have control passed to it until step 5, hence it can't ever do anything. The only way out is one of the following: 1. Process-per-driver, but when a driver loads USBD.SYS, USBD.SYS is special-cased by winedevice, ie. it has a special export called on it at load which specifies the other driver and gives it a chance to create a separate thread for steps 1-4. 2. Dedicated process for USB, in which USBD.SYS loads first, and it loads USB device drivers (possibly > 1) into the same process as the need arises.

1 0

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 2)
by Loïc Maury Jan. 23, 2011

Jan. 23, 2011

Hello, I have add comment in the code for the patch. Thank you Loïc --- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..d65850d 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +/* At this point, we know that we have media, because in Mac OS X, the + * device file is only created when media is present. */ +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

2 1

winscard
by vince Jan. 22, 2011

Jan. 22, 2011

Hi all, I'm back with a smaller and reworked winscard patch. In respond to Vitaly Margolen (http://www.winehq.org/pipermail/wine-devel/2010-September/087017.html) 1. I used configure to get the so name of the library. 2. I removed trailing spaces. 3. When this patch is approved, I will make a new patch for SCardListReadersA. Is this patch ready for wine-patch ? Thanks for your help. Vincent.

2 1

Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions
by Matteo Bruni Jan. 22, 2011

Jan. 22, 2011

2011/1/20 Travis Athougies <iammisc(a)gmail.com>: > +static void test_setting_basic_table(IDirect3DDevice9 *device) > +{ > + static const D3DXMATRIX mvp = { > + 0.514f, 0.626f, 0.804f, 0.786f, > + 0.238f, 0.956f, 0.374f, 0.483f, > + 0.109f, 0.586f, 0.900f, 0.255f, > + 0.898f, 0.411f, 0.932f, 0.275f}; This throws some warnings here. Apparently you have to put some additional braces around that initializer. + ok(out[0] == (float)iarray[0] && out[4] == (float)iarray[1] && out[8] == (float)iarray[2] && + out[12] == (float)iarray[3], "SetIntArray did not properly set a float array: out={%f, %f, %f, %f}, should" + " be {%d, %d, %d, %d}\n", out[0], out[4], out[8], out[12], iarray[0], iarray[1], iarray[2], iarray[3]); The float casts are unneeded. The tests look generally OK to me otherwise, albeit they are somewhat wordy. Oh, please notice that some tests fail on Windows. The testbot can't create a d3d device so it skips these tests, but on my Win7 box I get this: shader.c:462: Test failed: The first row of mvp was not set correctly, got {0.51 4000, 0.238000, 0.109000, 0.898000}, should be {0.514000, 0.626000, 0.804000, 0. 786000} shader.c:465: Test failed: The second row of mvp was not set correctly, got {0.6 26000, 0.956000, 0.586000, 0.411000}, should be {0.238000, 0.956000, 0.374000, 0 .483000} shader.c:468: Test failed: The third row of mvp was not set correctly, got {0.80 4000, 0.374000, 0.900000, 0.932000}, should be {0.109000, 0.586000, 0.900000, 0. 255000} shader.c:471: Test failed: The fourth row of mvp was not set correctly, got {0.7 86000, 0.483000, 0.255000, 0.275000}, should be {0.898000, 0.411000, 0.932000, 0 .275000} shader.c:530: Test failed: The excess elements of the array were not set correct ly, out={0.000000, 0.000000, 0.000000, 0.000000}, should be {0.010000, 0.020000, 0.030000, 0.040000} shader: 248 tests executed (0 marked as todo, 5 failures), 0 skipped. The matrix seems to have its rows and columns switched (probably this has to do with row-major vs column-major matrix storage - http://msdn.microsoft.com/en-us/library/bb509706%28v=VS.85%29.aspx) So you have to fix your SetMatrixArray implementation to account for that (and update the tests accordingly). The other failing test shows that actually the excess elements are not set, apparently. A last thing. I noticed that you never set the vertex shader in the d3d9 device. I'd say: don't change that. This shows that ID3DXConstantTable doesn't pay attention to the vertex shader currently set and it is responsibility of the application programmer to call these functions with the correct shader program.

3 3

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.
by Damjan Jovanovic Jan. 22, 2011

Jan. 22, 2011

Should we reconsider libicns? Apple's APIs obviously can't be relied upon. On Fri, Jan 21, 2011 at 2:58 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > > For http://bugs.winehq.org/show_bug.cgi?id=25778 > --- > dlls/windowscodecs/icnsformat.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > >

4 4

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray
by Matteo Bruni Jan. 21, 2011

Jan. 21, 2011

2011/1/20 Travis Athougies <iammisc(a)gmail.com>: > + /* D3DXMATRIX is a union, one of whose elements is an array, so it can be cast to a float pointer */ > + if (is_vertex_shader(This->desc.Version)) > + IDirect3DDevice9_SetVertexShaderConstantF(device, desc.RegisterIndex + i, (float *)(matrix + i), > + desc.RegisterCount); > + else > + IDirect3DDevice9_SetPixelShaderConstantF(device, desc.RegisterIndex + i, (float *)(matrix + i), > + desc.RegisterCount); Can't you just pass matrix->m[i] as parameter, instead of that cast?

3 6

Translating a same message used in different contexts
by Akihiro Sagawa Jan. 21, 2011

Jan. 21, 2011

Hi, I'm one of Japanese translators of Wine. A few weeks ago, Wine's string resources were moved to one po format file. So I started translation about it. And now I face to a problem which is a same msgid text used in different contexts, like "Desktop" used in shell32.rc. One of its contexts is a real path name of a desktop (IDS_DESKTOPDIRECTORY). That is "C:\Users\foo\Desktop"'s Desktop. In other contexts, it makes a localized name (IDS_DESKTOP). That is shown in a common dialog box. In the previous Japanese resource, the former was "Desktop" and the latter was localized. However, in the po file, they merged into one! Therefore we need to distinguish above contexts somehow. But I'm afraid I don't familiar with gettext and wrc. Could someone please resolve this issue? Akihiro Sagawa

3 5

RE: shell32/tests: Add tests for IShellDispatch::NameSpace.
by Greg Geldorp Jan. 21, 2011

Jan. 21, 2011

> === W7PROX64 (32 bit shelldispatch) === > shelldispatch.c:80: Test failed: bad title I suppose the title here was "Program Files (x86)", it would be good to print the title that you got (using wine_dbgstr_w()). This test will probably fail when running as 32-bit executable on any Windows 64-bit version. I also expect it to fail on some non-English Windows versions (e.g. I think German uses "Programme" instead of "Program Files"). Greg.

1 0

Re: shell32/tests: Add tests for IShellDispatch::NameSpace.
by Marvin Jan. 21, 2011

Jan. 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8506 Your paranoid android. === W7PROX64 (32 bit shelldispatch) === shelldispatch.c:80: Test failed: bad title

1 0

winepath breakage?
by Dan Kegel Jan. 20, 2011

Jan. 20, 2011

Hi Eric, thanks again for your tireless efforts in debugging and console stuff! Stefan alerted me to the following winetricks breakage: http://bugs.winehq.org/show_bug.cgi?id=25838 Could you have a look and decide who needs to give here - winepath, kernel32, or the poor user scripts? Hopefully not the latter. Thanks, Dan

1 0

Implementing basic_string::substr in msvcp90
by Daniel Mierswa Jan. 20, 2011

Jan. 20, 2011

Hey list, I was wondering how to implement substr in msvcp90/string.c. I followed the already existing code when implementing some operators and other things my application needed but I'm not sure how to construct a new string (rather allocate) and return it as it's the case with substr. Any ideas on this? Thanks in advance. -- Mierswa, Daniel If you still don't like it, that's ok: that's why I'm boss. I simply know better than you do. --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22

1 0

Hebrew PO and some issues
by Yaron Shahrabani Jan. 20, 2011

Jan. 20, 2011

I copied all the strings that shouldn't be translated, if anyone has a better suggestion be my guest. I don't want all the apps that shouldn't be translated listed in the PO. Also I need seperate translations for the same term, Ready should be translated differently among files. There are also strings that are similar between apps I should translate and apps I should so I'm a little confused about it, can I create seperate entries manually? The problem is that if I edit manually these entries will be deleted in the next update... Translating the apps in the old style was way better for me, how can I get back to that? Kind regards, Yaron Shahrabani <Hebrew translator>

1 0

Re: comctl32/tests: Fix failures for 120DPI display
by Nikolay Sivov Jan. 20, 2011

Jan. 20, 2011

On 1/20/2011 13:40, Greg Geldorp wrote: > --- > dlls/comctl32/tests/listview.c | 5 +++-- > dlls/comctl32/tests/rebar.c | 2 +- > dlls/comctl32/tests/treeview.c | 4 ++++ > 3 files changed, 8 insertions(+), 3 deletions(-) > @@ -4163,7 +4163,8 @@ static void test_getcolumnwidth(void) > SendMessage(hwnd, LVM_INSERTITEMA, 0, (LPARAM)&itema); > ret = SendMessage(hwnd, LVM_GETCOLUMNWIDTH, 0, 0); > hdc = GetDC(hwnd); > - todo_wine expect(GetDeviceCaps(hdc, LOGPIXELSX), ret); > +trace("ggeldorp %d %d\n", GetDeviceCaps(hdc, LOGPIXELSX), ret); > + todo_wine expect(((GetDeviceCaps(hdc, LOGPIXELSX) + 15) / 16) * 16, ret); > ReleaseDC(hwnd, hdc); > DestroyWindow(hwnd); > } Minor thing, you forgot to remove a trace.

1 0

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

re: today's git does not compile
by Susan Cragin Jan. 19, 2011

Jan. 19, 2011

>Try switching from -O2 to -O1 with > configure CFLAGS="-g -O1" >and rebuild. Does that help? Yes. That works. >Regardless of whether that gets you past the problem, >please file a bug in launchpad against gcc-4.5. >Ideally they'd want you to run with -save-temps and give >them a copy of pen.i. https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/704633 Here's the bug. I http://www.network-theory.co.uk/docs/gccintro/gccintro_36.html Dan, I can't work the -save-temps option. All three give me "no input files." /wine-git$ gcc -save-temps /wine-git$ gcc -save-temps=cwd (or =obj) gcc: no input files

3 3

setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)
by Qian Hong Jan. 19, 2011

Jan. 19, 2011

Dear All, while testing a USB production tool with unofficial USB patches + native oleaut32.dll, I got a crashing and such logs: wine: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status, aborting wine: Unimplemented function setupapi.dll.CM_Get_DevNode_Status called at address 0x7b839292 (thread 002f), starting debugger... Unhandled exception: unimplemented function setupapi.dll.CM_Get_DevNode_Status called in 32-bit code (0x7b839292). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7b839292 ESP:003158b8 EBP:0031591c EFLAGS:00000246( - -- I Z- -P- ) EAX:7b82540d EBX:7b887ff4 ECX:00000000 EDX:80000100 ESI:80000100 EDI:00000001 Stack dump: 0x003158b8: 0031593c 00000008 00020108 80000100 0x003158c8: 00000001 00000000 7b839292 00000002 0x003158d8: 7ebc3d60 7ebc42a9 00003218 00003218 0x003158e8: 00000001 00000000 989c7900 00000000 0x003158f8: 00000004 7eba6cfb 7ebd2ff4 00000000 0x00315908: 00000000 0031595c 7b83924a 00000111 Backtrace: =>0 0x7b839292 RaiseException+0x52(code=0x80000100, flags=0x1, nbargs=0x2, args=0x31593c) [/home/fracting/wine-git/dlls/kernel32/except.c:84] in kernel32 (0x0031594c) ... Should I post a new bug? Best wishes! -- Regards, Qian Hong - Send from Ubuntu http://www.ubuntu.com/

4 4

re: today's git does not compile
by Susan Cragin Jan. 19, 2011

Jan. 19, 2011

https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/704633 Bug successfully updated and confirmed by a member of Ubuntu's testing team, so we're off to the races.

1 0

kernel32: Correctly parse the input strings for advanced keys.
by James Eder Jan. 19, 2011

Jan. 19, 2011

On systems without the appropriate curses development files, compilation is broken here: gcc -m32 -c -I/home/james/build/wine/wine-git/dlls/kernel32 -I. -I/home/james/build/wine/wine-git/include -I../../include -D__WINESRC__ -D_KERNEL32_ -D_NORMALIZE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o term.o /home/james/build/wine/wine-git/dlls/kernel32/term.c /home/james/build/wine/wine-git/dlls/kernel32/term.c:368:10: error: conflicting types for ‘TERM_FillInputRecord’ /home/james/build/wine/wine-git/dlls/kernel32/console_private.h:40:17: note: previous declaration of ‘TERM_FillInputRecord’ was here make[1]: *** [term.o] Error 1 make[1]: Leaving directory `/home/james/build/wine/wine-32/dlls/kernel32' make: *** [dlls/kernel32] Error 2 Jim

1 0

Fail to use USB-Key/USB-Shield with wine USB patch :cannot start service 'SCardSvr':win error code:0x00000424
by Qian Hong Jan. 19, 2011

Jan. 19, 2011

Dear All, Thanks to the USB patch ( http://goo.gl/qc7ry ) , I have a chance to try weather there is some way to use my usbkey on my Linux. After applying the patch and setting follow the wiki , I still fail to use my usbkey.As I know, the USB patch just work for a few devices, I wonther if my usbkey works too. If possible , I'd like to help to test everything about the wine USB patch to make the usbkey works, also I need your help. Thank you very much :) First of all, let's see something about the usbkey. My usbkey is also called G&D USB-Shield, it is required by ICBC persional internet banking while online trading. Unfortunately, ICBC website is IE-only, ActiveX and VBscript are required. Here is the login entry: http://goo.gl/gWW7Q and the G&D USB-Shield driver for Windows, safesign_icbc_per.exe : http://goo.gl/LM588 ( from http://goo.gl/Ft4Ub) Infact, we don't have to login ICBC for testing the usbkey,because there is a tool called Token Administration Utility, it allow us manager the usbkey with a client program. After install the USB-Shield driver, we can see tokenadmin.exe in "Program Files/ICBCEbankTools/G&D/Management Utility", and that is the Token Administration Utility. Here is the screenshot of tokenadmin.exe on Windows XP: http://goo.gl/raKOm (Sorry for the Chinese in the screenshot, I don't know how to display English in a Chinese version Windows, if anyone know please tell me, I will upload a new screenshot , thanks :) Here is more infomation about the G&B usbkey: lsusb -v http://goo.gl/iOBW7 However, while installing G&B usbkey driver on wine, something is wrong like below: cannot start service 'SCardSvr':win error code:0x00000424 Now, here is the whole process: My enviroment: Ubuntu 10.10 x86_64; wine1.3.11 from git; Applying latest usb patch followed Wine USB wiki; configure & make & install success, no error; Step 1: winetricks-alpha -q mfc42 winetricks-alpha -q crypt32 ( mfc42 and native crypt32.dll are required to install safesign_icbc_per.exe ) Step 2: wine 'safesign_icbc_per.exe' The full log is here : http://goo.gl/fpu3j After this step, we can see the *.sys files: ~/.wine/drive_c/windows/system32/drivers$ ls Chip_smc.sys eps2kt1.sys mountmgr.sys usbic2k.sys Chip_usb.sys ic2kenum.sys usbhub.sys Step 3: Follow the wiki, copy the regist key-value from Windows XP to WIne: Here are all the reg files I imported: http://goo.gl/ZHXfo Step 4: wine tokenadmin.exe It will open a window without useful information,unlike that in Windows XP , here is the screenshot: http://goo.gl/YPYtz And here is the log: wine tokenadmin.exe fixme:winscard:SCardReleaseStartedEvent stub fixme:winscard:SCardEstablishContext (2,(nil),(nil),0x32f2f4) stub fixme:winscard:SCardEstablishContext (2,(nil),(nil),0x659130) stub I have tryed to remove ~/.wine and copy the scardsvr.exe from Windows to wine system32 folder,then do all the thing again, but it seems not work, there is no difference. Would you tell me what shall i do next ? Thanks! Best Wishes! -- Regards, Qian Hong - Send from Ubuntu http://www.ubuntu.com/

5 16