January 2011 - Wine-Devel - list.winehq.org

Re: [3/3] d3d9: account for another different behavior in the viewport test
by Stefan Dösinger Jan. 31, 2011

Jan. 31, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I just noticed that I sent the other two mails with my gmail account, so they got stuck in moderation. This patch should apply on its own, but depending on what Alexandre commits today I'll resend the patches after today's commit wave. Am 31.01.2011 um 11:21 schrieb Stefan Dösinger: > The alternative to this patch is to remove the test entirely, as it now accepts all possible outcomes on windows. I prefer to keep it because the behavior it accepts as non-broken(invalid viewport = "default" viewport) is required by some ddraw apps. We also have a test in ddraw, but it isn't quite as straightforward. > > <0011-d3d9-account-for-another-different-behavior-in-the-v.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNRsifAAoJEN0/YqbEcdMwUSAP/2HphIB7RzKXuS/q52t5mCvt b9yFQ/9ci11GWlzWG7okm72Z+hUdC4bIMPxIalWM7/VKPzsSB7Qg2EvwpMTGq0r5 lAX3WFFqWqCNoAZd7JnQO6LqX0TR4wJOCxIjAYSw+WlZW7tYNVFEsw3mPTUxqggR 88wVQ8C5oBAW3Rns6QGYmxyw+R6Xryh3pdukxBP2DS6jQDkqodq9L6JU24YHHy0z OFEZCIAl8VqhTfgTeO5pqJ7e4ujGyT0U25h8rmIuhMt8DFRdxTSE4agib4haFrLb jLEUAVqjSrV4EX1A+iisryBYCCOGpGT9vYKB5Xw169fzkjd2XMQ9C3udE/VznGWo grcWX9CJxm1XzR/AYuNh+pNSq+wZPxwrlJrOmcW4EC1o1X/OdXr+KtZFX2ldkGwF v6LCel4WPN5G4+mKryNnPMRDPo69ccZr2iKTdMQFs7nm0NZGxPNnj3o7eGDP92pq DNUboQ3EoZ3ow9c8vpfeGgxk647jgJwpeOzUKj7ON3l5XyFvoEAAv2pFwRp/lpn8 3ioLYDePd7VBcf6cT9ckI0Qptx2hM8yRyd1r+qC4jGv8ydQnHmAu+w61cmSrpl3X EYpvHmFYEdkJjDKcn2Z1gYekg4RisXcd/CVBWfZHLudpibEab+3NQp7wb+HwNscu 2P/hz0RIdqEC7BBQf6bJ =Vxnq -----END PGP SIGNATURE-----

1 0

Re: [PATCH] [patch] Already in cache means nothing more to do...
by Alexandre Julliard Jan. 31, 2011

Jan. 31, 2011

max(a)mtew.isa-geek.net writes: > @@ -2519,11 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > - FIXME("entry already in cache - don't know what to do!\n"); > -/* > - * SetLastError(ERROR_FILE_NOT_FOUND); > - * return FALSE; > - */ > + error = ERROR_SUCCESS; The entry is not necessarily the same even if the hash matches. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen Jan. 31, 2011

Jan. 31, 2011

Hi again, I've been working to implement the tests for RtlCaptureStackBackTrace(), but I have encountered a problem. The function, according to MSDN should be available only in Windows XP and newer OSes. Now, when I ran these tests on Testbot using all base VMs, the tests were run also on W2KPROSP4 and WNT4WSSP6. However, the function seems to buggy in those. It throws access violation whenever it is not skipping frames. Here's the test patch I used: http://testbot.winehq.org/GetFile.pl?JobKey=8606&StepKey=1 In both cases, test on patch's line 83 failed and call on line 92 crashed the test. In other VMs the tests succeeded and none crashed. Is there some way I could prevent/skip these tests to be run on Windows NT4 and 2000? Best Regards, Janne Hakonen

3 5

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()
by Vitaliy Margolen Jan. 31, 2011

Jan. 31, 2011

On 01/30/2011 04:16 AM, Peter Schlaile wrote: > Hi, > > find fix for a crash in create_alpha_bitmap() attached. If it's easy to reproduce please create a test that demonstrates the problem. > Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but > should test for alpha channel != 255. This should be a separate patch. Vitaliy.

2 2

RFC: Final Proposed Riched20 EM_SETMARGINS Test
by James McKenzie Jan. 31, 2011

Jan. 31, 2011

All: Constructive Criticism requested so that this can be made better. I've decided to use two loops in the test: One for fonts. Second for actual tests. This allows for quick and easy expansion. The check code for font changes might be removed, but does no harm by remaining. This patch is based on git as of Friday, January 28. I could find no font that changed the Margin from zero for the EC_USEFONTINFO lparam test case. If someone knows of a font that will do so, please advise as well so I can include it. Thank you. James McKenzie

1 0

Re: [PATCH 2/2] mshtml: Added support for recursive script runners
by Marvin Jan. 30, 2011

Jan. 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8753 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Policy regarding 3rd party "windows" distributions and winetest
by Dan Kegel Jan. 30, 2011

Jan. 30, 2011

I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience Agreed?

5 6

MapleStory Wine Bug
by Jack Edmonds Jan. 30, 2011

Jan. 30, 2011

I recently submitted a bug (http://bugs.winehq.org/show_bug.cgi?id=25934) I'm not sure if I did a good job on the submission, but if I did, I was thinking it would be a good first bug to work on so as to introduce me to the Wine source code. I was wondering if someone could help me get started on it.

2 1

Re: user32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Marvin Jan. 30, 2011

Jan. 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8728 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x0111 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg 0x0111 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 4: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x002b instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg 0x002b was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 4: the msg sequence is not complete: expected 8000 - actual 0000 === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH 1/2] winecoreaudio: Don't use Component Manager on Mac OS 10.6.
by Charles Davis Jan. 30, 2011

Jan. 30, 2011

On 1/29/11 6:40 PM, James McKenzie wrote: > Chip: > > I'm assuming that this has been checked on Tiger/Leopard and it works. I checked that it would work if the AudioComponent header weren't present (which it isn't pre-SL). > > I don't have a Leopard system here and I'm reluctant to try it on one of > the systems I have Tiger installed on (it is a PowerPC Mac.) I can't imagine why... :) Chip

1 0

RE: shdocvw: Implement IWebBrowser::ExecWB and IWebBrowser::QueryStatusWB.
by Greg Geldorp Jan. 29, 2011

Jan. 29, 2011

From: Greg Geldorp <ggeldorp(a)vmware.com> > From: Erich Hoover > > On Thu, Jan 27, 2011 at 3:53 AM, Greg Geldorp <ggeldorp(a)vmware.com> wrote: > > > ... > > > Looking at http://test.winehq.org/data/tests/shdocvw:webbrowser.html, > > > the shdocvw:webbrowser test doesn't have a history of occasional > > > crashes. There are a few failures, but none of them are due to access > > > violations. Which kind of indicates that the crash is because of the > > > changes you made. > > > I know it sucks to investigate failures that don't repro consistently, > > > but I do think some more testing would be good here. Of course, if > > > there's any info you need about the VM just let me know. > > > > Well, I commandeered a XP SP3 box this morning and ran that exact same > > set of tests successfully 10,000 times. I don't have access to a Win7 > > box or I would have run the tests on that. Thoughts? > > I'll do a similar test on Win7 tomorrow and let you know the results. I started by running your test binary 10,000 times on W7PROX64. Not a single crash, so that looked kind of promising. Just to be sure, I then ran the binary on a dual-core Win7 x64 machine (the W7PROX64 VM has only one core assigned to it). This resulted in an immediate crash. Tried a few more times, it crashed 9 out of 10 times. To make sure that these crashes are related to your patch, I ran the test without your patch on the same dual-core machine. First few tries didn't produce crashes, I then ran it in a loop 10,000 times. Not a single crash. So, it looks like your patch introduces some multi-threading issue. I haven't investigated further, perhaps I'll have some time over the weekend to dig a bit deeper. Greg.

2 3

Re: winex11.drv: When copying window bits exclude an update region only if the parent doesn't clip its children.
by Alexandre Julliard Jan. 29, 2011

Jan. 29, 2011

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1624,7 +1624,8 @@ static void move_window_bits( struct x11drv_win_data *data, const RECT *old_rect > hdc_src = hdc_dst = GetDCEx( data->hwnd, 0, DCX_CACHE ); > } > > - ExcludeUpdateRgn( hdc_dst, data->hwnd ); > + if (!parent || !(GetWindowLongW( parent, GWL_STYLE ) & WS_CLIPCHILDREN)) > + ExcludeUpdateRgn( hdc_dst, data->hwnd ); I don't see what the parent clipping has to do with this. Could you please explain? -- Alexandre Julliard julliard(a)winehq.org

2 1

Ubuntu 10.04 x86-64 test failures -- dsound:ds3d and mmdevapi
by Reece Dunn Jan. 28, 2011

Jan. 28, 2011

=== Observations === 1/ The dsound:ds3d tests fail when using the ALSA audio driver on 64-bit (K)Ubuntu, but succeed with the OSS audio driver. 2/ The mmdevapi tests fail with a "Device not found"/"No driver" error (hr = 0x88780078) when running with the OSS driver. For the mmdevapi failures, the tests should skip when intercepting a "Device not found" error. === Steps to Reproduce === Machine: Ubuntu 10.04 64-bit with NVidia binary drivers. 1/ Build the latest version of wine with no special options -- `./configure && make` 2/ Remove any previously run test result -- `find . -type f | grep .ok | xargs rm` 3/ Ensure running in a clean wine prefix -- `rm -rf ~/.wine` 4/ Run the tests -- `make test` This will download the gecko package and then fail in the dsound:ds3d tests with: ds3d.c:467: Test failed: buffer size changed after SetFormat() - previous size was 88200, current size is 22052 This error seems to be specific to 64-bit versions of the Ubuntu family, looking at the http://test.winehq.org/data/ results. 5/ Open winecfg -- `./wine winecfg` 6/ Select the Audio tab This should being up a message to recommend a driver (as no driver is set in the registry) and then select the ALSA driver. 7/ Switch the audio driver from ALSA to OSS and press OK. 8/ Re-run the tests -- `make test` This passes the ds3d tests, but fails with: ../../../tools/runtest -q -P wine -M mmdevapi.dll -T ../../.. -p mmdevapi_test.exe.so dependency.c && touch dependency.ok err:quartz:DSoundRender_create Cannot create Direct Sound object (88780078) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88780078 dependency.c:85: Test failed: Activating bf failed: 0x88780078 9/ Open winecfg -- `./wine winecfg` 10/ Switch the audio driver from OSS back to ALSA and press OK. 11/ Re-run the tests -- `make test` The mmdevapi tests now pass. - Reece

3 4

Re: Alexander Scott-Johns : ole32: Add support for rendering METAFILEPICT clipboard objects.
by Nikolay Sivov Jan. 28, 2011

Jan. 28, 2011

On 1/28/2011 21:30, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 0f4fbd30f6bf3d2ef471d3d75307c7fa8a7df137 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=0f4fbd30f6bf3d2ef471d3d75… > > Author: Alexander Scott-Johns<alexander.scott.johns(a)googlemail.com> > Date: Tue Jan 25 15:09:21 2011 +0000 > > ole32: Add support for rendering METAFILEPICT clipboard objects. > > --- > dlls/ole32/clipboard.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 96 insertions(+), 1 deletions(-) > > +/*************************************************************************** > + * get_data_from_metafilepict > + */ > +static HRESULT get_data_from_metafilepict(IDataObject *data, FORMATETC *fmt, HGLOBAL *mem) > +{ > + HGLOBAL copy; > + HRESULT hr; > + FORMATETC mem_fmt; > + STGMEDIUM med; > + > + *mem = NULL; > + > + mem_fmt = *fmt; > + mem_fmt.tymed = TYMED_MFPICT; > + > + hr = IDataObject_GetData(data,&mem_fmt,&med); > + if(FAILED(hr)) return hr; > + > + hr = dup_metafilepict(med.u.hMetaFilePict,&copy); > + if(FAILED(hr)) return hr; 'med' should be released here on failure. > + > + *mem = copy; > + > + ReleaseStgMedium(&med); > + > + return hr; > +} > + > /***********************************************************************

1 0

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry
by Eric Pouech Jan. 28, 2011

Jan. 28, 2011

Le 19/01/2011 13:07, Alexandre Julliard a écrit : > Eric Pouech<eric.pouech(a)orange.fr> writes: > >> you mean hardwiring the missing keys (potentially different according to >> terminal type) in the code? > If they depend on terminal type they belong in terminfo, not in the > registry. > as I said, terminfo is not fully populated it misses lots of ctrl-<key> (left arrow, right arrow...) and has not been updated lately most of the common text editors come with their own config files for example, /etc/inputrc has the missing bindings for libreadline (and of course it depends on $TERM) so, updating terminfo isn't the solution would you consider inclusion in hklm (instead of hkcu) ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: [PATCH 2/2] msvcrt: Use the _set_error_mode value to switch between a dialogbox and stderr for C runtime messages
by Alexandre Julliard Jan. 28, 2011

Jan. 28, 2011

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -134,8 +135,9 @@ static void DoMessageBox(LPCSTR lead, LPCSTR message) > void CDECL _amsg_exit(int errnum) > { > TRACE("(%d)\n", errnum); > - /* FIXME: text for the error number. */ > - if (MSVCRT_app_type == 2) > + > + if ((MSVCRT_error_mode == MSVCRT__OUT_TO_MSGBOX) || > + ((MSVCRT_error_mode == MSVCRT__OUT_TO_DEFAULT) && (MSVCRT_app_type != 1))) If you want to change the app type check that should be a separate patch, with its own justification. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: User32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Vitaliy Margolen Jan. 28, 2011

Jan. 28, 2011

On 01/27/2011 11:51 PM, Alexander LAW wrote: > > > + if (style & WS_VISIBLE) { > + HDC hdc = GetDC(hWnd); > + HBRUSH hbrush; > + RECT client, rc; > + HWND parent = GetParent(hWnd); Please follow the style of the file - curly brace goes on a separate line. Please if you can't set your editor to have tab character equal 8 spaces - don't use tabs! Use space characters only. > + if (!parent) parent = hWnd; > + UINT ctlMessage=((btn_type==BS_PUSHBUTTON || > btn_type==BS_DEFPUSHBUTTON || btn_type==BS_PUSHLIKE)?WM_CTLCOLORBTN: > WM_CTLCOLORSTATIC); This is not c++ inline declarations are not allowed. Please cut this line down it's too long. Also please add corresponding test to msg.c tests to validate the change. Vitaliy.

1 0

Re: winex11.drv: Implement synthesizing the CF_ENHMETAFILE clipboard format from CF_METAFILEPICT.
by Vitaliy Margolen Jan. 28, 2011

Jan. 28, 2011

On 01/27/2011 07:42 PM, Alexander Scott-Johns wrote: > > > > > + FIXME("Called to synthesize unknown format 0x%08x\n", wFormatID); Formats defined as decimal, so you should print it as decimal. > + if ((lpSource = X11DRV_CLIPBOARD_LookupData(CF_ENHMETAFILE)) && lpSource->hData) > + { > + bret = TRUE; > + } Just do "return TRUE". It will remove one level of indentation. > + void *mf_bits = HeapAlloc(GetProcessHeap(), 0, size_mf_bits); > + GetMetaFileBitsEx(pmfp->hMF, size_mf_bits, mf_bits); Please check if allocation succeeded. Vitaliy.

1 0

Re: [PATCH 1/2] msvcrt: Add private define and header tests for _set_error_mode options
by Marvin Jan. 28, 2011

Jan. 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8692 Your paranoid android. === WNT4WSSP6 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2KPROSP4 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === WXPPROSP3 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2K3R2SESP2 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === WVISTAADM (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2K8SE (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PRO (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PROX64 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PROX64 (64 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2

1 0

Re: [1/2] shell32: Implement IShellDispatch::NameSpace
by Marvin Jan. 28, 2011

Jan. 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8684 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] winecoreaudio: Fix deprecation warnings.
by Alexandre Julliard Jan. 28, 2011

Jan. 28, 2011

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -198,10 +222,19 @@ int AudioUnit_CreateInputUnit(void* wwi, AudioUnit* out_au, > UInt32* outFrameCount) > { > OSStatus err = noErr; > +#ifdef HAVE_AUDIOUNIT_AUDIOCOMPONENT_H > + /* Apple has threatened to rip out the Component Manager. > + * Protect ourselves from that. > + */ > + AudioComponentDescription description; > + AudioComponent component; > +#else > ComponentDescription description; > Component component; > +#endif It would be better to have a set of compatibility defines at the top instead of spreading #ifdefs all through the code. And please split independent changes into separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Where can I get OpenCL for Fedora 14.
by Max TenEyck Woodbury Jan. 28, 2011

Jan. 28, 2011

For the first time in several years, I did a fresh install on this machine and I am in the process of getting all the tweaks back in place. Part of that process is assuring that wine's configure script has all the pieces it can use. I have found almost everything. What I am missing is OpenCL (that is C as in Charles). I see stuff for Apple, but not for Fedora.i386 (cpu is intel.core2 and an Nvidia card). Search results are inconclusive - I checked the first five pages and found nothing specifically about .rpm files. Where can I get an .rpm or tarball that contains a usable OpenCL implementation for Fedora 14? Max

6 8

Wine Source Study
by Pankaj Swami Jan. 28, 2011

Jan. 28, 2011

Please help me..... I am last year Computer Engineering student & I want to study wine source code but I'm unable to decide from where to start studying wine source code.........? I have wine source code.

1 0

Another milestone
by Greg Geldorp Jan. 28, 2011

Jan. 28, 2011

Today we had a clean winetest.exe run on all 31 TestBot VMs for the first time. Although there are still failures on other test machines and some tests fail occasionally on TestBot, I still think this is a significant milestone. Hopefully the "Wine" column on http://test.winehq.org/data/ will soon start to show some yellow spots too! Greg.

2 1

Re: msvcrt: Forward _realloc_crt to realloc
by Marvin Jan. 27, 2011

Jan. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8669 Your paranoid android. === WVISTAADM (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 77497580 === W2K8SE (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 778A814C === W7PRO (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 772D2B79 === W7PROX64 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 77E03100 === W7PROX64 (64 bit msvcr90) === No test summary line found

1 0