January 2011 - Wine-Devel - list.winehq.org

Re: [4/4] gdi32: Move common code into helper function.
by Nikolay Sivov Jan. 27, 2011

Jan. 27, 2011

On 1/27/2011 12:23, Kusanagi Kouichi wrote: > On 2011-01-26 19:28:29 +0300, Nikolay Sivov wrote: >> On 1/26/2011 19:09, Kusanagi Kouichi wrote: >>> -static LPSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT pByteLen) >>> +static LPWSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT pLen) >>> { >> It's better to change naming too, since it's won't return char >> string anymore. > What name do you think is better? > Is FONT_GetCharsByRange or FONT_GetCharsByRangeAToW OK? I think FONT_GetCharsByRangeW would be fine. Note that I don't know this code, and probably it should be done another way to avoid conversion in a first place (if possible at all).

1 0

Re: shdocvw: Implement IWebBrowser::ExecWB and IWebBrowser::QueryStatusWB.
by Erich Hoover Jan. 27, 2011

Jan. 27, 2011

On Thu, Jan 27, 2011 at 3:53 AM, Greg Geldorp <ggeldorp(a)vmware.com> wrote: > ... > Looking at http://test.winehq.org/data/tests/shdocvw:webbrowser.html, the > shdocvw:webbrowser test doesn't have a history of occasional crashes. > There are a few failures, but none of them are due to access violations. > Which kind of indicates that the crash is because of the changes you > made. > I know it sucks to investigate failures that don't repro consistently, > but I do think some more testing would be good here. Of course, if there's > any info you need about the VM just let me know. Well, I commandeered a XP SP3 box this morning and ran that exact same set of tests successfully 10,000 times. I don't have access to a Win7 box or I would have run the tests on that. Thoughts? Erich Hoover ehoover(a)mines.edu

2 1

Re: [ActiveX] Wine builtin IE crash while login to https://www.alipay.com/
by Jacek Caban Jan. 27, 2011

Jan. 27, 2011

Hi Qian, On 1/26/11 9:06 AM, Qian Hong wrote: > However, sence Wine buitin IE began to support ActiveX, I have also > tested alipay.com with wine buitin IE, just for reporting. Support for ActiveX in Wine IE is a fairly new feature and it still quite limited. Honestly I've tested it mostly with Flash ActiveX version (which was my main interest in implementing it). I don't expect much more to work, but I'd be interested in results of real-world tests with other controls/requirements. Please file a bug about it (in mshtml component) and CC me. Jacek

1 0

Re: [ActiveX]crash while open https://mybank.icbc.com.cn/icbc/perbank/index.jsp use wine buitin IE
by Saulius Krasuckas Jan. 27, 2011

Jan. 27, 2011

* On Thu, 27 Jan 2011, Juan Lang wrote: > > > By the way, will wine builtin IE support vbscript in the future? ICBC > > online bank required vbscript. > > That's a pretty open-ended question. I haven't seen anyone volunteer > to work on this in some time, so I'd say the odds are not so good. ABBYY FormFiller software (used to fill data for electronic tax declaration system at the state level in our country) also requires vbscript.dll to parse data validation rules. There is workaround, though. You just run "winetricks wsh56vb". S.

3 2

Re: shell32/tests: Remove shlwapi dependency
by Marvin Jan. 26, 2011

Jan. 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8618 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: winex11.drv: initialize drawable (clang)
by Henri Verbeet Jan. 25, 2011

Jan. 25, 2011

2011/1/25 André Hentschel <nerv(a)dawncrow.de>: > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > then the if condition is reliable I don't think that can happen unless hwnd is NULL and top is non-NULL, which looks like invalid input to me.

2 1

Re: kernel32: Removing - key from keybindings.
by Trygve Vea Jan. 25, 2011

Jan. 25, 2011

On Tue, Jan 25, 2011 at 8:35 PM, Trygve Vea <trygve.vea(a)gmail.com> wrote: > Fixes bug 25856, introduced in 2a219b948c451213fb4554352b86f3784a8f7e32. > It seems that Eric Pouech already posted an identical patch, which has been applied. This is then unnecessary. I apologize for the noise. -- Trygve Vea

1 0

wine-patches
by Vincent Hardy Jan. 25, 2011

Jan. 25, 2011

Hi, I sent this email on wine-patch but... nothing. Am I doing something wrong ? Am I blacklisted ? Vincent

2 1

Re: po: Update the Dutch translation
by Alexandre Julliard Jan. 25, 2011

Jan. 25, 2011

Sven Baars <sven.wine(a)gmail.com> writes: > Hey, > > All those po editors piss me off. First, the changes I make don't get > saved, then they do get saved but magically disappear when I try to > send them. Now I used poedit, which is apparently the only one that > works, and this one makes whole bunch of changes by itself. > > If this unacceptable, could someone please tell me how to work with > this stuff? Or would it be better to just use a normal editor? Maybe > emacs? And how could I recover the actual changes I made (and not the > ones poedit made) if this patch is not acceptable? You should run it through msgmerge before sending. Something like msgmerge nl.po wine.pot > nl.po.new -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)
by Loïc Maury Jan. 25, 2011

Jan. 25, 2011

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..6a6d8e0 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + /* At this point, we know that we have media, because in Mac OS X, the + * device file is only created when media is present. */ + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

4 5

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 4)
by Loïc Maury Jan. 25, 2011

Jan. 25, 2011

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

1 0

Re: [Bug 25402] Woody Two Legs crashes with unimplemented function msvcr90.dll._wcslwr_s
by Eric Pouech Jan. 25, 2011

Jan. 25, 2011

the spec should read wstr instead of ptr A+ 2011/1/25 <wine-bugs(a)winehq.org> > http://bugs.winehq.org/show_bug.cgi?id=25402 > > Andrew Millington <andrew.millington(a)gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Keywords| |patch > > --- Comment #5 from Andrew Millington <andrew.millington(a)gmail.com> > 2011-01-25 01:23:06 CST --- > After applying http://source.winehq.org/patches/data/70240 it complains > about > unimplemented function d3dx9_36.dll.D3DXFloat32To16Array and that is bug > #25769. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are watching all bug changes. > > > -- -- Eric Pouech

1 0

Re: [PATCH 2/4] wined3d: Add support for the NULL format.
by Stefan Dösinger Jan. 25, 2011

Jan. 25, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 24.01.2011 um 18:41 schrieb Henri Verbeet: > - if (surface) > + if (surface && surface->resource.format->id != WINED3DFMT_NULL) Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a color attachment. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNPqNaAAoJEN0/YqbEcdMwWFwP/0KW7THyiplBKi6csC7b6qWi i7Bi3VG5UMRomIDUyWMTlH+mwLqP7+AchzVYEHAM/blhe5yqemDc2YAN2f2/aNtV cbWoaIilTNF3PKH11wVvtUowidrwHmr9eV+SmHplvhdpJCTGKqU0ZxmNgl2DDiSD iPVfCmL6RE1e5n9i11AH7aQIcZjwPTEQBQlLR5IB1zpcnXab0r7vyTU44f0HkcJ0 785ast6QuG7lawibe7PmRz41VcFCtSMZF3QGgEujAn+frtYhqjVLdP8LITWZ+1mL jPfCWEQX1vlgbdMogykfnKSfm5oxaDMsrU3vMskwUGWFZCX+M7ffHIfy7cpy8HUt YVz4kqeaLr1xeZEsEaAQqjNal1PXoJCJSVA6ckV7VhB0+OkXpcH4i8ifdCtRv1PJ 0V/vryBBQgM9AczBQI8lb1c7w7lQL9EzttpNwbbC3mBTsT3/7EHJRuxR8EStIgzC 8gyTXveyBGuJel8Bwx6M+tBSskCNKFzPN7MKkvIE2+X5NSYj5eI05GSQRMl/eush jZWe+ls9GYgl76bL8+By1RRTsXGizPdW8UnX6HhzMfBErU1Z7IZbbqEiTMgXFOJL 0v0UXfLecE/mHlgrauk7b0C51JMtTXq5uuSOQ8uxFz/t2KcElja6pY4/nkN3DoLe I/cZaSyeQ3B5lTVTeZt/ =UA0G -----END PGP SIGNATURE-----

2 1

Static analysis scan
by Amine Khaldi Jan. 24, 2011

Jan. 24, 2011

Hello folks, I've set up a static analysis scan using clang static analyzer. The results are available at http://austinenglish.com/logs/clang_analyzer/index.html thanks to Austin for the web space. Please feel free to fix the defects. I'll run future scans when the defects get fixed progressively. Have fun ;) With best regards, Amine.

2 1

Re: oleaut32/typelib2: Use implementation pointer to trace ICreateTypeInfo2
by Michael Stefaniuc Jan. 24, 2011

Jan. 24, 2011

Hello Nikolay, On 01/24/2011 01:01 AM, Nikolay Sivov wrote: > Use implementation pointer to trace ICreateTypeInfo2 > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index 8260ef2..5c843a1 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -2322,6 +2321,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnAddVarDesc( > > /* increment the number of variable elements */ > This->typeinfo->cElement += 0x10000; > +ERR("count=%d\n", This->typeinfo->cElement); this looks like some leftover debug line. > > return status; > } bye michael

2 1

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.
by Jacek Caban Jan. 24, 2011

Jan. 24, 2011

On 1/18/11 7:31 PM, Erich Hoover wrote: > On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban <jacek(a)codeweavers.com <mailto:jacek(a)codeweavers.com>> wrote: > ... > I'm not sure what you mean by "hijack the IOleCommandTarget". All we do is implementing client's IOleCommandTarget. It's something different from document's one. > I understand that, but apparently the native implementation (testing on the test bot WXPPROSP3) sends the command to the client > IOleCommandTarget instead of the document IOleCommandTarget (at least under the conditions of the webbrowser tests). That is what I mean by hijacking, the command is going to the "wrong" target. My guess would be that there is some sort of priority mechanism, though I have no idea how it would work (except maybe "if there's a client/container then send to that target, else send to the document target). That sounds reasonable. > I've attached a test where I disabled the client/container, and you > can see that it then gets passed through (QueryStatusWB will return success instead of passing through the client target and returning failure): > https://testbot.winehq.org/JobDetails.pl?Key=8408 Hmm, it means that another run of tests (at least required subset of existing test_WebBrowser) with client's IOleCommandTarget disabled would be interesting. Do you feel like writing it? Otherwise we'd need at least a FIXME in this case. Jacek

2 5

Re: gdi32: Prevent character code from wrapping around.
by Alexandre Julliard Jan. 24, 2011

Jan. 24, 2011

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > If lastChar is 0xffffffff, FONT_GetCharsByRangeA falls into > infinite loop and crash. You probably want more sanity checks (with tests), characters above 0xffff wouldn't make sense anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] To: wine-patches@winehq.org
by Alexandre Julliard Jan. 24, 2011

Jan. 24, 2011

Eric Pouech <eric.pouech(a)orange.fr> writes: > [Kernel32]: in bare console with curses, ensure control stream is sent to tty (even when some fd:s are redirected) There doesn't seem to be much point in initializing input if we can't see the output. On the contrary, I think we should err on the side of not initializing anything unless really necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Questioning the depth_clamp_test in d3d8:visual
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 24, 2011

Jan. 24, 2011

Hi, Trying to understand bugs #10636 and #19773 , I glanced at the d3d8 visual.ok directx test results. It appears that the green colour on test.winehq does not mean much. - All (any exception?) WTB machines skip the tests because d3d8 is not installed. - Same for Francois Gouget's virtual machines. That alone explains green colour. - Wylda's *real* machine #1 (NVidia gfx) produces 5 errors: visual.c:1411: Test failed: color 0x00ffffff. visual.c:1413: Test failed: color 0x00ffffff. visual.c:1415: Test failed: color 0x00ffffff. - "geniuh"'s (NVidia) machine as well. - Saulius' (NVidia) XP and w7 machines shows only these 3 errors. - Wylda's Intel-based machine #2 passes the tests. Hurray! - One unknown win7 machine with Intel gfx also passes them. - Aurimas' machine produces one different error (also Intel gfx). BTW, Wylda recently mentioned that the d3d tests produce vastly different graphics on his 2 machines. My conclusion: the tests only prove that Wine wants to mimic Intel graphics, but they do not account for the variety of observed test results. Danger: one may draw false conclusions from the ok() and wrongly generalize supposed behaviour of the tested functions. Looking at Wine test data (from 1.3.12), it appears that Wine implements exactly the opposite behaviour: the NVidia (+ 1 ATI) machines pass the tests, e.g. behave like Intel on native, while the Intel gfx one (eeepc) produces the 3 errors known from native NVidia! This smells wrong... Regards, Jörg Höhle

3 2

Re: server: fix connect failures on newer kernels
by Marcus Meissner Jan. 24, 2011

Jan. 24, 2011

On Mon, Jan 24, 2011 at 12:21:15AM -0500, Mike Kaplinskiy wrote: > For some reason the newer kernels report POLLOUT|POLLERR|POLLHUP when > connect() fails. Strip the POLLOUT in this case. This (hopefully) > fixes bug 25456. > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 1b81544..3c6425e 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -3965,7 +3965,7 @@ static void test_ConnectEx(void) > closesocket(listener); > listener = INVALID_SOCKET; > > - address.sin_port = 1; > + address.sin_port = htons(1); > > bret = pConnectEx(connector, (struct sockaddr*)&address, addrlen, NULL, 0, &bytesReturned, &overlapped); > ok(bret == FALSE && GetLastError(), "ConnectEx to bad destination failed: " > diff --git a/server/sock.c b/server/sock.c > index d37a316..134efb0 100644 > --- a/server/sock.c > +++ b/server/sock.c > @@ -388,6 +388,9 @@ static void sock_poll_event( struct fd *fd, int event ) > > if (sock->state & FD_CONNECT) > { > + if (event & POLLOUT && event & (POLLERR|POLLHUP)) > + event &= ~POLLOUT; Add more braces to make the operator precedence a bit more clear... (just a style issue though) Ciao, Marcus

2 1

new winetricks 20110123: work around bug in wine-1.3.12. new winetricks-alpha 20110123: ditto, plus new verbs cnc3_demo, guildwars, hphbp_demo, nfsshift_demo, sims3, spotify, vc2005trial
by Dan Kegel Jan. 24, 2011

Jan. 24, 2011

Another week, another winetricks. This release is mainly to add a workaround for http://bugs.winehq.org/show_bug.cgi?id=25838 in wine-1.3.12, which broke winetricks. winetricks-alpha version 20110123 adds the following new verbs: cnc3_demo: Command and Conquer 3 demo guildwars: Guild Wars hphbp_demo: Harry Potter Half Blood Prince demo nfsshift_demo: Need For Speed: Shift demo sims3: The Sims 3 spotify: the popular music service vc2005trial: Visual C++ 2005 Trial winetricks version 20110123 adds no new verbs. Both scripts can be downloaded from winetricks.org at the obvious urls: http://winetricks.org/winetricks http://winetricks.org/winetricks-alpha (The old download url at kegel.com/wine/winetricks still works, too.) Bug tracker and svn repository are at http://winetricks.googlecode.com ----------------------------------- Changelog for winetricks-alpha: Dan Kegel: Work around wine bug 25838 :-( Ported verbs hphbp_demo, sims3 from wisotool Fix mingw PATH (again) Add example to help for 'list' command w_download{,_manual}: get rid of need to specify package name. w_download_manual: open destination folder in desktop for user python26_comtypes: metadata should be "year", not "date". Shortened title for psdkwin7 to fit window. Shannon Vanwagner: New verb spotify Phil Blankenship: Ported verbs cnc3_demo, guildwars, nfsshift_demo, vc2005trial from wisotool. ----------------------------------- Changelog for winetricks: Dan Kegel: Work around wine bug 25838 :-( Austin English: update opensymbol url/sha1sum ----------------------------------- Enjoy!

1 0

wine-1.3.12 broke winetricks :-(
by Dan Kegel Jan. 24, 2011

Jan. 24, 2011

Looks like wine-1.3.12 went out without the fix for http://bugs.winehq.org/show_bug.cgi?id=25838 I've checked a workaround into winetricks, and will do a release, but I bet a few users will be confused...

1 0

3Dmark2001se & heap corruption
by wylda＠volny.cz Jan. 23, 2011

Jan. 23, 2011

Hi, as there is a strong Valgrind wave these days ;) and i failed to find the problem myself here is a little exercise for anyone interested: 1. WINEDEBUG=warn+heap wine 3DMark2001SE.exe 2. Under selected test -> (click) Clear -> (tab) Custom -> (check) "Game2 Dragothic Low Detail" -> OK 3. (click) Benchmark At the end, console is flooded by many: Heap 0x110000: block 0x2c41070 tail overwritten at 0x2c410a1 (byte 0/15 == 0x00) Heap 0x110000: block 0x1c46b08 tail overwritten at 0x1c46b39 (byte 0/39 == 0x00) W.

4 6

re: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Dan Kegel Jan. 23, 2011

Jan. 23, 2011

Hi Janne, I haven't reviewed your code, but I can suggest sending each patch as a separate message to wine-patches, and using titles more like ntdll: test corrupt stack frame in RtlCaptureStackBackTrace() ntdll: handle corrupt stack frame in RtlCaptureStackBackTrace() and mention clearly that this fixes the online store in Anarchy Online (if it does). Also, please send the test patch by itself through winebot before posting and verify that it passes on all flavors of windows. See http://wiki.winehq.org/SubmittingPatches Thanks!

2 1

Re: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)
by Marvin Jan. 23, 2011

Jan. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8488 Your paranoid android. === WNT4WSSP6 (32 bit device) === device.c:168: Test failed: DirectInputCreate() failed: 80040154

3 5