January 2011 - Wine-Devel - list.winehq.org

wineserver hitting kernel bug?
by André Hentschel Jan. 12, 2011

Jan. 12, 2011

Hi all, i get err:process:start_wineboot failed to start wineboot, err 1359 which of course leads to major problems, i tracked it down to server/process.c in function process_poll_event it hits the line if (event & (POLLERR | POLLHUP)) kill_process( process, 0 ) because event is 0x19 what can cause that? maybe a kernelbug? that's with ext3 and after working around https://bugs.launchpad.net/ubuntu/+source/linux-ti-omap4/+bug/697004/ yes, it is on ARM (pandaboard) uname -a : Linux panda 2.6.35-903-omap4 #19-Ubuntu SMP PREEMPT Wed Nov 17 16:11:04 UTC 2010 armv7l GNU/Linux -- Best Regards, André Hentschel

3 3

Re: windowscodecs/tests: COM cleanup for converter.c.
by Marvin Jan. 11, 2011

Jan. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8249 Your paranoid android. === WXPPROSP3 (32 bit converter) === No test summary line found === WVISTAADM (32 bit converter) === converter: unhandled exception c0000005 at 7749794D === W2K8SE (32 bit converter) === converter: unhandled exception c0000005 at 778A8C6B

1 0

sc2 performance (was: Wine and D3D)
by Dan Kegel Jan. 11, 2011

Jan. 11, 2011

emaentra(a)ngi.it wrote: >If during my tests I set the affinity of the executable (and >subsequently all its threads) to a particular core I have to say that >core gets fully used and FPS are better than general That's interesting. what cpu, gpu, and version of wine do you have, and what is the fps before and after pinning the game to one cpu? You should use, say, the fps on launching into one of the default scenarios without touching anything so that we can get a reproducible measurement. Tell us what mouseclicks to use to replicate your measurement. Or, if you think it's needed, right after launch, select all units and have them start moving, and use the lowest fps seen during those few seconds.

3 3

AppDB: Do not upload screenshots of error messages, installers, game menus
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 11, 2011

Jan. 11, 2011

Hi, the AppDB screenshot submission pages mentions this rule - Do not upload screenshots of error messages, installers, game menus yet it is continuously violated and e.g. screenshots of game menus are accepted, including recently. Is it still a useful rule? If yes, should matching screenshots be removed? While we are at it, should there be a rule about accepting or not screenshots showing bugs such as graphical artefacts? Probably it's better to have a screenshot with bugs than have none. Just curious, Jörg Höhle

3 3

re: crypt32: Fix Quote-Handling (try 2)
by Juan Lang Jan. 11, 2011

Jan. 11, 2011

Hi Christian, on second thought I don't have too much to say about this, other than style comments: take them or leave them. +/* Only use this function internally. */ This comment isn't all that useful. You might indicate that quotes are only needed by CertNameToStr when the string type is CERT_X500_NAME_STR, but that might be clear enough from the code. Also, since CertRDNValueToStr doesn't need quote_string, you should probably invert the order in which they appear in the file. Thanks, --Juan

2 2

Re: crypt32: Added Quoting-Tests
by Juan Lang Jan. 11, 2011

Jan. 11, 2011

Hi Christian, -static BYTE bin1[] = { 0x55, 0x53 }; -static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74, +static BYTE bin1[] = { 0x55, 0x53 }; +static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74, 0x61 }; Please don't introduce whitespace-only changes, it's harder to see what your patch is doing. + { "0", CERT_RDN_PRINTABLE_STRING, + { sizeof(bin9), bin9 }, "abc\"def" }, Since these changes pass on unpatched wine, they don't demonstrate the necessity for your patch. We need tests that show what the existing problem is. --Juan

2 5

Re: advapi32: Only attempt multibyte conversion in SetEntriesInAclA when ptstrName is a string.
by Alexandre Julliard Jan. 11, 2011

Jan. 11, 2011

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > dlls/advapi32/security.c | 19 ++++++++++++------- > 1 files changed, 12 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so security.c && touch security.ok security.c:1449: Tests skipped: Well known SIDs starting from 62 are not implemented security.c:2681: Test failed: SetEntriesInAclA failed: 87 security.c:2682: Test failed: returned acl was NULL security.c:2694: Test failed: SetEntriesInAclA failed: 87 security.c:2695: Test failed: returned acl was NULL security.c:2720: Test failed: SetEntriesInAclA failed: 87 security.c:2721: Test failed: returned acl was NULL security.c:2728: Test failed: SetEntriesInAclA failed: 87 security.c:2729: Test failed: returned acl was NULL make[1]: *** [security.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] comctl32/rebar: Implemented dragging between rows
by Joris Huizer Jan. 11, 2011

Jan. 11, 2011

Hello, In this patch, in function REBAR_HandleUDDrag: + if(yOff < 0) + { + /* Place the band above the current top row */ + DPA_DeletePtr(infoPtr->bands, iHitBand); + hitBand->fStyle &= RBBS_BREAK; + REBAR_GetBand(infoPtr, 0)->fStyle |= RBBS_BREAK; + infoPtr->iGrabbedBand = DPA_InsertPtr( + infoPtr->bands, 0, hitBand); + } It looks like that should have been: hitBand->fStyle &= ~RBBS_BREAK; HTH, Joris

1 0

Re: [4/7] kernel32/tests: Demonstrate an input event handling peculiarity with WriteConsoleInputW.
by Eric Pouech Jan. 11, 2011

Jan. 11, 2011

Hi Andrew, I think the test should be enhanced by checking the information about mouse position it seems that windows coalesce two mouse messages, but does it also occur when the position is different (a cursory look seems to indicate that you resend the same coordinate for mouse move) I'd expect coalesce operation to happen only if coordinates are the same A+ 2011/1/11 Andrew Nguyen <anguyen(a)codeweavers.com> > --- > dlls/kernel32/tests/console.c | 165 > +++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 159 insertions(+), 6 deletions(-) > > > > > > > -- -- Eric Pouech

2 1

Re: po: Fix rc->po misconverted iccvid French translation
by Alexandre Julliard Jan. 11, 2011

Jan. 11, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > po/fr.po | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) There are many more issues to fix. One of the motivations for po files is to reduce the patch churn caused by translations, so please don't send a separate patch for each string, do a review pass over the whole file and fix everything you can. The po format makes it easy to find places that need work. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [3/7] kernel32: Improve parameter validation for ReadConsoleOutputAttribute.
by Marvin Jan. 11, 2011

Jan. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8233 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: fusion/tests: Add some tests for IAssemblyCache_QueryAssemblyInfo.
by Marvin Jan. 11, 2011

Jan. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8223 Your paranoid android. === W7PROX64 (32 bit asmcache) === No test summary line found

1 0

Re: gdiplus: Support for indexed formats in GdipBitmapSetPixel
by Paul Vriens Jan. 11, 2011

Jan. 11, 2011

On 01/11/2011 02:26 AM, MP wrote: > + case PixelFormat8bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; > + case PixelFormat4bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; > + case PixelFormat1bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; Hi, Didn't check the other part of the patch for correctness but you are calling the same function here for 3 different formats. -- Cheers, Paul.

1 0

Re: crypt32: Fix Quote-Handling
by Juan Lang Jan. 10, 2011

Jan. 10, 2011

Hi Christian, > As tested on Windows(R) 7 Home Premium x64, "CertRDNValueToStr" Doesn't > handle the quoting. > Instead it's made on "CertNameToStr" with CERT_X500_NAME_STR flag. Adding tests that demonstrate that would help a great deal. A minor comment regarding the patch itself: +/* Only use this function internally. */ +static DWORD QuoteCertRDNValueToStrA(DWORD dwValueType, PCERT_RDN_VALUE_BLOB pValue, Don't use Hungarian notation for internal functions, it's hard to distinguish them from Win32 API functions. --Juan

2 1

Re: makefiles: Ignore mo files
by Alexandre Julliard Jan. 10, 2011

Jan. 10, 2011

Luca Bennati <lucak3(a)gmail.com> writes: > They get automatically generated if you use poedit to translate This should go in your local config, .gitignore is for files generated by the standard build process. -- Alexandre Julliard julliard(a)winehq.org

1 0

Spammer on Wike
by Vitaliy Margolen Jan. 9, 2011

Jan. 9, 2011

Would Wiki admin please ban 201.21.186.95 ip? This user been spamming for the past several days. Vitaliy.

1 0

user32/test failing in cursoricon with proper results
by James Mckenzie Jan. 9, 2011

Jan. 9, 2011

All: I just ran the user32 tests to validate what I am seeing with my richedit test in progress but the test failed in the cursoricon check with valid results. Before I open a bug report, can anyone on a Mac validate that they receive 23 errors with valid test results? Thank you. James McKenzie

2 1

Re: Wine and D3D
by Emanuele Oriani Jan. 9, 2011

Jan. 9, 2011

Hi Stefan, First of all thanks for the answer. It's a shame you lost that presentation, but it'd be great if you could in some way point out what are the current issues and where we spend CPU time (did I understand correctly). I don't have much free time, but would be more than happy to contribute as much as I can. About SC2 specifically, how do I execute the +d3d9,tid command line? Keep in mind SC2.exe is a (child detached) process spawned by the 'parent' launcher (it's not so straightforward to execute it without launcher because of dlls and other stuff) so would it be like: wine +d3d9,tid SC2Switcher.exe (where SC2Switcher.exe is the launcher)? More information about the CPU usage. If during my tests I set the affinity of the executable (and subsequently all its threads) to a particular core I have to say that core gets fully used and FPS are better than general... apparently with multiple cores set the OS tries to balance the workload, thus decreasing the FPS. I'll be looking into dlls/wined3d/context.c as well. Thanks again, Cheers, Ps. When I said multiple threads directly invoke SleepEx, didn't mean it's a bad thing, just we have like 10+ threads which are inactive 95~99% of the time... and themselves set into this state I reckon. On 08/01/11 23:20, Stefan Dösinger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > I am afraid some of your conclusions are not correct, more about that at the end of the mail. Basically most of the performance issues are caused by wined3d and the opengl driver requiring too much CPU time. That slows down the game as-is, and means that the GPU can never live up to its full potential(except if you have a really weak GPU). > > Unfortunately that is not one single bug, but rather 10-15 issues that sum up - and that is just covering the simplest possible rendering cases(just draw a few vertices), by adding extra stuff like textures, dynamic resources, render target switches, etc there will be many more. Fixing that will require a lot of work. > > I gave a talk about this topic at wineconf 2010, but unfortunately there was no recording and I even lost my slides. However, one thing survived: My very basic drawprim benchmark at https://84.112.174.163/git/?p=perftest;a=summary (self-signed certificate). With it you can benchmark how fast wine can dispatch draw calls and optimize this very basic functionality. Once this benchmark is fixed we'll have to write many more for other d3d features(shader changes, resource loading, texture changes, thread switching, etc etc etc). So it is a lot of work. Coding help is always welcome of course :-) > > Cheers, > Stefan > > Am 08.01.2011 um 19:34 schrieb Emanuele Oriani: >> My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. >> >> And, potentially they're using multi-threaded rendering as well. > Not as far as I know, but it is easy to check: Run the game with +d3d9,+tid and see if there are d3d drawing calls from multiple threads. If the game switches threads every now and then I wouldn't count it as multithreaded, if it constantly calls d3d from more than one thread it is multithreaded. >> I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. > No, not necessarily. The threads may be waiting for something, e.g. user input or network messages. Waiting threads don't have to be a bug, quite to the contrary. > >> This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). >> Could it be related to the rendering infrastructure? > I doubt it, I guess that depends on the cpufreq settings and your CPU. I'd expect cpufreq to clock down all but one core. > >> I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). >> During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. >> What happened with that? >> How is currently multi-threaded D3D rendering implemented in wine? > It is implemented pretty much in the way I outlined it in 2006. dlls/wined3d/context.c is responsible for multithreading, see context_acquire() and context_release(). > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.16 (Darwin) > > iQIcBAEBAgAGBQJNKPE3AAoJEN0/YqbEcdMwo9EP/jfJyeZlVx0AsHoxWLtZ77OV > ttBwCsIKs4IqJyJXgv8hNkeNQaDwk0QoJqxHkw/2AlGDO2sdaNR9EGbRMTmtH3OP > 8x+UeiEntJRP3zHamxRxCus6F86cEqfca9PV/PYiVLSCdIb7v2i091n4z6o2nk7t > b5yutdJsMx7jgH1QLCluS2dWs50SgFw/UXgs3nTGmg0vPefhDd4846uBKgi+yCL9 > Ol5RcRz8N8VxD3dJTCgjKt8kPxlIRFiIB9Og3F9T4UowmVMTiYKvuJ/TTz/jAgTe > zHzNqwNjSXScupRTFWV9EesJZKkYY5+GO0JVX1OXMWbeWG0vdmgaAsUhkLc4PHIF > kFUdAnx9uOlu//F5opL9LGzwiyTfsAXNVstEs7m1jCpBoed80OfZMFNY0wH5wN9h > 3c5kWIY1UoIaWkeMNLt+O3k6Xwsbfl0UAo6tgBxzx6sBff6MNxzCR6mZdz+hwhE7 > eekK3N+r5nvOp9yuCQTdm+PEoaH/uPRPTqt2Z8zhABeZMdrzjcXghWRc+7dkwFic > nw7qKEGoXW0zt+p58HAM8PbhMlhp6L784U3/Td11y7moXlcPh7MiaUcgYq1kBALf > nOaBinWgGmzhvU5ub6l6HwAMpZl6MEKn0GeHBUMBuLhEgYdXG/l7K4hxXgYvyulg > ySRGDcxFEqJezQPHNg9w > =diUG > -----END PGP SIGNATURE----- >

2 1

ntdll/cdrom : implement CDROM_Verify to work on Mac Os
by maury loïc Jan. 9, 2011

Jan. 9, 2011

Hello, it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. merci Loïc --- dlls/ntdll/cdrom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..185f397 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

3 3

Re: [1/1][user32.dll]Adding Arabic Translation resources
by Yaron Shahrabani Jan. 9, 2011

Jan. 9, 2011

Hi Nowres, just looked at your patch, there are some things missing, when you translate a dialog you should add EXSTYLE WS_EX_LAYOUTRTL. For example, instead of this header: +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "إخ&تيار النافذة" +FONT 8, "MS Shell Dlg" It should be like this: +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +EXSTYLE WS_EX_LAYOUTRTL +CAPTION "إخ&تيار النافذة" +FONT 8, "MS Shell Dlg" Kind regards, Yaron Shahrabani <Hebrew translator> 2011/1/9 Nowres <nss.zpeedzter(a)gmail.com> > From a5d9d1e4599ce5a6c2f45df7948182401526f997 Mon Sep 17 00:00:00 2001 > From: Nowres Rafid <nss.zpeedzter(a)gmail.com> > Date: Sun, 9 Jan 2011 00:54:00 +0000 > Subject: [user32]Adding Arabic translation resources > > --- > dlls/user32/Makefile.in | 1 + > dlls/user32/resources/user32_Ar.rc | 89 > ++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+), 0 deletions(-) > create mode 100644 dlls/user32/resources/user32_Ar.rc > > diff --git a/dlls/user32/Makefile.in b/dlls/user32/Makefile.in > index 3dbde26..e33d83e 100644 > --- a/dlls/user32/Makefile.in > +++ b/dlls/user32/Makefile.in > @@ -51,6 +51,7 @@ C_SRCS = \ > wsprintf.c > > RC_SRCS = \ > + resources/user32_Ar.rc \ > resources/user32_Bg.rc \ > resources/user32_Ca.rc \ > resources/user32_Cs.rc \ > diff --git a/dlls/user32/resources/user32_Ar.rc > b/dlls/user32/resources/user32_Ar.rc > new file mode 100644 > index 0000000..5dd397c > --- /dev/null > +++ b/dlls/user32/resources/user32_Ar.rc > @@ -0,0 +1,89 @@ > +/* > + * User32 > + * Arabic language support > + * > + * Copyright 2010 Nowres Rafid > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + */ > + > +#include "resources.h" > + > +/* UTF-8 */ > +#pragma code_page(65001) > + > +LANGUAGE LANG_ARABIC, SUBLANG_DEFAULT > + > +SYSMENU MENU > +{ > + MENUITEM "إسترجا&ع", 61728 > + MENUITEM "تحري&ك", 61456 > + MENUITEM "حج&م", 61440 > + MENUITEM "تصغي&ر", 61472 > + MENUITEM "تكبي&ر", 61488 > + MENUITEM SEPARATOR > + MENUITEM "إغلا&ق\tAlt-F4", 61536 > + MENUITEM SEPARATOR > + MENUITEM "Wine معلومات حو&ل", 61761 > +} > + > +EDITMENU MENU > +{ > + POPUP "" > + BEGIN > + MENUITEM "إلغاء التغيير&ات", EM_UNDO > + MENUITEM SEPARATOR > + MENUITEM "ق&ص", WM_CUT > + MENUITEM "نس&خ", WM_COPY > + MENUITEM "لصق&", WM_PASTE > + MENUITEM "مس&ح", WM_CLEAR > + MENUITEM SEPARATOR > + MENUITEM "تحد&يد الكل", EM_SETSEL > + END > +} > + > +MSGBOX DIALOG 100, 80, 216, 168 > +STYLE DS_MODALFRAME | DS_NOIDLEMSG | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +BEGIN > + ICON "", 1088, 8, 20, 16, 16, WS_CHILD | WS_VISIBLE > + LTEXT "", 100, 32, 4, 176, 48, WS_CHILD | WS_VISIBLE | WS_GROUP | > SS_NOPREFIX > + PUSHBUTTON "موافق&", 1, 16, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إلغ&اء", 2, 64, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إنه&اء", 3, 112, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إعادة المحاول&ة", 4, 160, 56, 40, 14, WS_CHILD | > WS_VISIBLE | WS_TABSTOP > + PUSHBUTTON "تجاه&ل", 5, 208, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "نع&م", 6, 256, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "ك&لا", 7, 304, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "أعد& المحاولة", 10, 352, 56, 40, 14, WS_CHILD | > WS_VISIBLE | WS_TABSTOP > + PUSHBUTTON "إستمرا&ر", 11, 400, 56, 40, 14, WS_CHILD | WS_VISIBLE > | WS_TABSTOP > + PUSHBUTTON "مس&اعدة", 9, 448, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > +END > + > +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 > +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "إخ&تيار النافذة" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LISTBOX MDI_IDC_LISTBOX, 5, 7, 222, 90, WS_VSCROLL | > WS_HSCROLL /* defined in mdi.h */ > + DEFPUSHBUTTON "مو&افق", IDOK, 75, 100, 35, 14 > + PUSHBUTTON "إلغ&اء", IDCANCEL, 120, 100, 35, 14 > +END > + > + > +STRINGTABLE > +{ > + IDS_ERROR "خطأ" > + IDS_MDI_MOREWINDOWS "نوا&فذ أخرى" > +} > -- > 1.7.1 > > > > >

1 0

Wine and D3D
by Emanuele Oriani Jan. 8, 2011

Jan. 8, 2011

Hi wine developers, I'm a wine user and StarCraft II player. Unluckily Blizzard has left D3D only mode in win32 executable. The game doesn't use CPU/GPU at 100%, but on Linux what happens is that we have a lot less FPS than windows. To get some more FPS, like 50% more, we set one core (or all cores) to max frequency and then we set the 'affinity' of SC2.exe to that core only (to set the affinity I created a simple executable). This way performance is better indeed, but nowhere near windows. (I've opened a bug for this matter http://bugs.winehq.org/show_bug.cgi?id=24558 ). My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. And, potentially they're using multi-threaded rendering as well. I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). Could it be related to the rendering infrastructure? I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. What happened with that? How is currently multi-threaded D3D rendering implemented in wine? Thanks again, Cheers, Ema! ;-) Ps. Thanks to wine and a simple 'fprinft' I managed to easily instrument the SleepEx function and gather such valuable information. Now I'd like to do the same for D3D part, understand why the main renderer thread goes to sleep (or not) and if it goes to sleep actively or it's waiting on some mutex, or something else.

1 0

wiki work, wine64 portability issues
by Thomas Heckel Jan. 8, 2011

Jan. 8, 2011

Hi all, I was just cleaning up some "Janitorial" sections on wine wiki. Now several questions arise: Just for interest I looked for a kind of wine64 portability guide to link to the http://wiki.winehq.org/PortabilityFixes . Are there any documents with source patterns which have been fixed to get Wine 64-bit ready? I think some of the listed janitorial tasks are already finished. E.g. there weren't any commits for 16bit separation for a longer time (Alexandre?). I don't have any overview if this tasks are really finished or if there are still some sections remaining? As a proposal to be discussed for the "wiki people": I would like to make a category "CategoryAbout" to collect the wiki articles which are (should) directly linked from the about page on the winheq.org site. I think this would be a good first way to solve the still existing old/duplicated pages between wiki and winheq.org pages. What do you think? Thanks in advance, Thomas

1 0

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang Jan. 8, 2011

Jan. 8, 2011

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Wine and D3D
by Emanuele Oriani Jan. 8, 2011

Jan. 8, 2011

Hi wine developers, I'm a wine user and StarCraft II player. Unluckily Blizzard has left D3D only mode in win32 executable. The game doesn't use CPU/GPU at 100%, but on Linux what happens is that we have a lot less FPS than windows. To get some more FPS, like 50% more, we set one core (or all cores) to max frequency and then we set the 'affinity' of SC2.exe to that core only (to set the affinity I created a simple executable). This way performance is better indeed, but nowhere near windows. (I've opened a bug for this matter http://bugs.winehq.org/show_bug.cgi?id=24558 ). My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. And, potentially they're using multi-threaded rendering as well. I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). Could it be related to the rendering infrastructure? I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. What happened with that? How is currently multi-threaded D3D rendering implemented in wine? Thanks again, Cheers, Ema! ;-) Ps. Thanks to wine and a simple 'fprinft' I managed to easily instrument the SleepEx function and gather such valuable information. Now I'd like to do the same for D3D part, understand why the main renderer thread goes to sleep (or not) and if it goes to sleep actively or it's waiting on some mutex, or something else.

1 0

Forum/mailing list link broken?
by Rosanne DiMesio Jan. 7, 2011

Jan. 7, 2011

Replies from the mailing list are not showing up on the forum in some cases. A user mentioned it in this thread: http://forum.winehq.org/viewtopic.php?t=10782. I checked the mailing list archives, and there are other threads that have replies from mailing list users that never appeared on the forum. -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 5