January 2011 - Wine-Devel - list.winehq.org

re: How to find out locking problem
by Dan Kegel Jan. 3, 2011

Jan. 3, 2011

Sometimes it helps to run winedbg from another window and get the stacks of all running processes with the command bt all With luck, you can then see which two code paths are competing for the lock.

5 6

Re: [02/13] kernel32: Avoid checking the output parameter for GetNumberOfConsoleInputEvents.
by Alexandre Julliard Jan. 3, 2011

Jan. 3, 2011

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -991,9 +991,7 @@ BOOL WINAPI GetNumberOfConsoleInputEvents( HANDLE handle, LPDWORD nrofevents ) > req->handle = console_handle_unmap(handle); > req->flush = FALSE; > if ((ret = !wine_server_call_err( req ))) > - { > - if (nrofevents) *nrofevents = reply->read; > - } > + *nrofevents = reply->read; That sort of change is in general not a good idea. Most of these functions have an exception handler on Windows so NULL pointers get caught. Even if the handler has been removed in Win7, that doesn't mean there aren't apps that depend on it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] urlmon: Add some error handling to the http protocol. (try 2)
by Jacek Caban Jan. 3, 2011

Jan. 3, 2011

Hi David, The patch looks much better now, but needs a bit more. BTW, this would be better tested on protocol level (like we do in protocol.c) than moniker binding, but this will do too. On 1/3/11 3:47 AM, David Hedberg wrote: > Try 2: Better tests, among other things. > --- > dlls/urlmon/http.c | 173 +++++++++++++++++++++++++++++++++++++- > dlls/urlmon/tests/url.c | 211 +++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 373 insertions(+), 11 deletions(-) > > @@ -2546,11 +2670,19 @@ static void test_BindToStorage(int protocol, DWORD flags, DWORD t) > SET_EXPECT(QueryInterface_IHttpNegotiate); > SET_EXPECT(QueryInterface_IWindowForBindingUI); > SET_EXPECT(QueryService_IWindowForBindingUI); > + SET_EXPECT(GetWindow_IWindowForBindingUI); > SET_EXPECT(BeginningTransaction); > SET_EXPECT(QueryInterface_IHttpNegotiate2); > SET_EXPECT(GetRootSecurityId); > SET_EXPECT(OnProgress_FINDINGRESOURCE); > SET_EXPECT(OnProgress_CONNECTING); > + if(flags& BINDTEST_INVALID_CN) { > + SET_EXPECT(QueryInterface_IHttpSecurity); > + SET_EXPECT(QueryService_IHttpSecurity); > + SET_EXPECT(OnSecurityProblem); > + if(SUCCEEDED(onsecurityproblem_hres)) > + SET_EXPECT(GetWindow_IHttpSecurity); > + } > } > if(!no_callback) { > if(test_protocol == HTTP_TEST || test_protocol == HTTPS_TEST || test_protocol == FTP_TEST > @@ -2600,6 +2732,47 @@ static void test_BindToStorage(int protocol, DWORD flags, DWORD t) > ok(hres == INET_E_DATA_NOT_AVAILABLE, > "IMoniker_BindToStorage failed: %08x, expected INET_E_DATA_NOT_AVAILABLE\n", hres); > ok(unk == NULL, "istr should be NULL\n"); > + }else if(flags& BINDTEST_INVALID_CN) { > + if(invalid_cn_accepted) { > + todo_wine CHECK_NOT_CALLED(QueryInterface_IHttpSecurity); > + todo_wine CHECK_NOT_CALLED(QueryService_IHttpSecurity); > + todo_wine CHECK_NOT_CALLED(OnSecurityProblem); > + }else { > + CHECK_CALLED(QueryInterface_IHttpSecurity); > + CHECK_CALLED(QueryService_IHttpSecurity); > + CHECK_CALLED(OnSecurityProblem); > + if(onsecurityproblem_hres != S_OK || security_problem == ERROR_INTERNET_SEC_CERT_ERRORS) { > + CHECK_NOT_CALLED(QueryInterface_IInternetBindInfo); > + CHECK_NOT_CALLED(QueryService_IInternetBindInfo); > + CHECK_CALLED(QueryInterface_IHttpNegotiate); > + CHECK_CALLED(BeginningTransaction); > + CHECK_CALLED(QueryInterface_IHttpNegotiate2); > + CHECK_CALLED(GetRootSecurityId); > + CLEAR_CALLED(GetWindow_IWindowForBindingUI); > + CLEAR_CALLED(QueryInterface_IWindowForBindingUI); > + CLEAR_CALLED(QueryService_IWindowForBindingUI); > + if(onsecurityproblem_hres == S_FALSE) { > + if(security_problem == ERROR_INTERNET_SEC_CERT_ERRORS) > + CLEAR_CALLED(OnProgress_FINDINGRESOURCE); > + else > + CHECK_CALLED(OnProgress_FINDINGRESOURCE); > + CHECK_CALLED(GetWindow_IHttpSecurity); > + }else { > + todo_wine CHECK_NOT_CALLED(OnProgress_FINDINGRESOURCE); > + CHECK_NOT_CALLED(GetWindow_IHttpSecurity); > + } > + } > + } > + if(binding_hres != S_OK) { > + ok(hres == binding_hres, "Got %08x\n", hres); > + ok(unk == NULL, "Got %p\n", unk); > + }else if(invalid_cn_accepted) { > + todo_wine ok(hres == S_OK, "IMoniker_BindToStorage failed: %08x\n", hres); > + todo_wine ok(unk != NULL, "unk == NULL\n"); > + }else { > + ok(hres == S_OK, "IMoniker_BindToStorage failed: %08x\n", hres); > + ok(unk != NULL, "unk == NULL\n"); > + } This is making tests even harder to maintain than they are now. I guess you're duplicating checking called function here because of returning on failure a few lines later. It's the return that shouldn't be there. You can change it to if(FAILED(hres) && !(flags & BINDTEST_INVALID_CN)) return; if you don't want to deal with existing problems in error handling. Jacek

1 0

Re: [2/3] kernel32: Added stubs for IDN functions
by Alexandre Julliard Jan. 3, 2011

Jan. 3, 2011

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > @@ -1219,6 +1219,11 @@ > @ stdcall lstrlen(str) lstrlenA > @ stdcall lstrlenA(str) > @ stdcall lstrlenW(wstr) > +@ stdcall NormalizeString(long wstr long wstr long) > +@ stdcall IsNormalizedString(long wstr long) > +@ stdcall IdnToAscii(long wstr long wstr long) > +@ stdcall IdnToNameprepUnicode(long wstr long wstr long) > +@ stdcall IdnToUnicode(long wstr long wstr long) Please insert them at the correct location, the entry points are sorted. Also output parameters can't be wstr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [03/13] kernel32: Improve parameter validation for WriteConsoleInputW.
by Marvin Jan. 3, 2011

Jan. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8070 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

2 1

Re: [5/6] kernel32: Avoid checking the output parameter for WriteConsoleOutputCharacterW. (try 2)
by Marvin Jan. 3, 2011

Jan. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8085 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [4/6] kernel32: Improve parameter validation for WriteConsoleInputA. (try 2)
by Marvin Jan. 3, 2011

Jan. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8084 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [3/6] kernel32: Improve parameter validation for WriteConsoleInputW. (try 2)
by Marvin Jan. 3, 2011

Jan. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8083 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [10/13] kernel32: Avoid checking the output parameter for FillConsoleOutputAttribute.
by Marvin Jan. 3, 2011

Jan. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8077 Your paranoid android. === WXPPROSP3 (32 bit console) === No test summary line found === W7PROX64 (64 bit console) === Failure running script in VM: Exceeded timeout limit of 315 sec

1 0

Re: [13/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputAttribute.
by Marvin Jan. 3, 2011

Jan. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8080 Your paranoid android. === WVISTAADM (32 bit console) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W7PROX64 (32 bit console) === No test summary line found

1 0