October 2011 - Wine-Devel - list.winehq.org

Re: mscoree: Implement ICorDebug SetManagedHandler
by Alexandre Julliard Oct. 5, 2011

Oct. 5, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -99,8 +99,28 @@ static HRESULT WINAPI CorDebug_Terminate(ICorDebug *iface) > static HRESULT WINAPI CorDebug_SetManagedHandler(ICorDebug *iface, ICorDebugManagedCallback *pCallback) > { > RuntimeHost *This = impl_from_ICorDebug( iface ); > - FIXME("stub %p %p\n", This, pCallback); > - return E_NOTIMPL; > + HRESULT hr; > + > + TRACE("%p (%p)\n", This, pCallback); > + > + if(!pCallback) > + return E_INVALIDARG; > + > + if(This->pCallback2) > + ICorDebugManagedCallback2_Release(This->pCallback2); > + > + if(This->pCallback) > + ICorDebugManagedCallback_Release(This->pCallback); > + > + hr = ICorDebugManagedCallback_QueryInterface(pCallback, &IID_ICorDebugManagedCallback2, (void**)&This->pCallback2); > + if(hr == S_OK) > + { > + This->pCallback = pCallback; > + > + ICorDebugManagedCallback_AddRef(This->pCallback); > + } You can't release the old interfaces before the new ones are in place. -- Alexandre Julliard julliard(a)winehq.org

1 0

[Question] Built-in indeo drivers
by Maxim Oct. 5, 2011

Oct. 5, 2011

Hi crews, I want to propose a solution for the well-known problem with Indeo codecs. Details here: http://www.ligos.com/index.php/home/support/indeosupport/ There is a bunch of (old) games still using indeo in their cut scenes. For that reason the installation of the Intel DLLs is required. Unfortunately, old indeo codecs prior the version 5 contain bugs and their support has been discontinued for years. Moreover, Microsoft has disabled indeo in the latest OSes due to security issues. I volunteer myself to create an open-source bult-in replacement for indeo v3,4 and 5 based on my patches for ffmpeg. The code will be reworked in order to remove ffmpeg/libav library dependencies. Only decoding will be implemented. Encoding would require a huge amount of time and it doesn't worth it... Would be such a patch appreciated? Best regards Maxim Poliakovski

2 1

Re: comctl32/tests: Removed sign comparison warning in datetime tests.
by Joris Huizer Oct. 5, 2011

Oct. 5, 2011

On 10/05/2011 04:43 PM, Marko Nikolic wrote: > static void test_mccolor_types(HWND hWndDateTime, int mccolor_type, const char* mccolor_name) > { > - LRESULT r; > - COLORREF theColor, prevColor; > + //LRESULT r; > + COLORREF theColor, prevColor, crColor; > Please avoid C++/C99-style comments in Wine code In this case you should remove the 'r' variable instead of commenting it out.

2 1

Re: netapi32: add stub for NetScheduleJobEnum
by Austin English Oct. 5, 2011

Oct. 5, 2011

On Wed, Oct 5, 2011 at 11:35, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > this fixes a crash in app SysIsdpector (http://download.eset.com/download/sysinspector/32/ENU/SysInspector.exe) You should've made this a series, otherwise the build fails: -- -Austin ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Wed, Oct 5, 2011 at 11:41 Subject: Re: 79589: netapi32: add stub for NetScheduleJobEnum To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/134 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: netapi32.c:23: error: lmat.h: No such file or directory make[1]: *** [depend] Error 1 make: *** [dlls/netapi32/__depend__] Error 2

1 0

Re: [PATCH 1/4 (resend)] audio: Load winmm only on demand
by Alexandre Julliard Oct. 5, 2011

Oct. 5, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > resend: Fix subject, to make buildbot happy. > > dlls/winealsa.drv/Makefile.in | 2 +- > dlls/winealsa.drv/midi.c | 21 ++++++++++++++++++++- > dlls/winecoreaudio.drv/Makefile.in | 2 +- > dlls/winecoreaudio.drv/coreaudio.c | 2 +- > dlls/winecoreaudio.drv/midi.c | 21 ++++++++++++++++++++- > dlls/wineoss.drv/Makefile.in | 2 +- > dlls/wineoss.drv/midi.c | 21 ++++++++++++++++++++- > 7 files changed, 64 insertions(+), 7 deletions(-) Making winmm a delayed import should work just as well, with no code changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

[Question] Built-in indeo drivers
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 5, 2011

Oct. 5, 2011

Maxim Poliakovski wrote: >I volunteer myself to create an open-source Go ahead! Some apps still crash in Wine because their installers don't install them, and not every user is able to figure out from the fixme messages what's missing. OSS is not enough, your license must be compatible with Wine's. I don't know whether Indeo is covered by patents and whether that may cause trouble. Which Wine video codec is recommended for copy&paste? iccvid? Encoding only is like iccvid. Regards, Jörg Höhle

1 0

Vista/w2k8/w7 users, please test mmdevapi base render test
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 5, 2011

Oct. 5, 2011

Hi, please run on native machines my newest mmdevapi tests at http://testbot.winehq.org/JobDetails.pl?Key=14691 You'll find both patch and .exe there. I've split my former test in two. This is part one, without the GetPosition tests. WINETEST_DEBUG does not matter in part 1. wine mmdevapi_test.exe render I'd be pleased if you could test this with various configurations: - with exclusive mode disabled in the MS control panel - with non-standard settings in the MS control panel - with 5:1 audio chosen (if possible) in the MS control panel - audio entirely disabled - sound card without capture (does "capture only" exist?) Please report any failures such that I can later submit this part one test, given confidence that it's been tested with a variety of configurations. Thank you for testing, Jörg Höhle

4 3

Re: ws2_32: Patch to selectively bind to interfaces while still allowing broadcast packets (try 2)
by Marcus Meissner Oct. 4, 2011

Oct. 4, 2011

On Tue, Oct 04, 2011 at 10:51:26AM -0600, Erich Hoover wrote: > Real Name: > Erich Hoover > > Description: > I know it's been quite a while, but I'm back with another solution > for Bug #7929. This patch uses SO_BINDTODEVICE in order to bind a > socket to a specific interface while still allowing broadcast packets > (a Linux-only feature). While this feature normally requires root > privileges, it can also be enabled by giving wine-preloader the > CAP_NET_RAW capability. Should insufficient permissions be available, > the patch outputs an appropriate error message notifying the user that > broadcast packets will not function properly. Frankly, no sane distributor will ever do this. Ciao, Marcus > Changelog: > ws2_32: Patch to selectively bind to interfaces while still > allowing broadcast packets. > From f4c904b9b21da7664eff33be918da71795db01af Mon Sep 17 00:00:00 2001 > From: Erich Hoover <ehoover(a)mines.edu> > Date: Tue, 4 Oct 2011 10:43:06 -0600 > Subject: ws2_32: Selectively bind UDP sockets to interfaces while still allowing broadcast packets. > > --- > dlls/ws2_32/socket.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 94 insertions(+), 0 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index f0313fc..174ec15 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -2101,6 +2101,94 @@ static int WINAPI WS2_WSARecvMsg( SOCKET s, LPWSAMSG msg, LPDWORD lpNumberOfByte > } > > /*********************************************************************** > + * interface_bind (INTERNAL) > + * > + * Bind the given socket exclusively to a specific interface. > + */ > +static int interface_bind( int fd, struct sockaddr *addr ) > +{ > + struct sockaddr_in *in_sock = (struct sockaddr_in *) addr; > + PIP_ADAPTER_INFO adapters = NULL, adapter; > + unsigned int sock_type = 0, optlen; > + int ret = FALSE; > + DWORD adap_size; > + > + if (in_sock->sin_addr.s_addr == htonl(WS_INADDR_ANY)) > + { > + /* Not binding to specific interface, use default route */ > + goto cleanup; > + } > + optlen = sizeof(sock_type); > + if (getsockopt(fd, SOL_SOCKET, SO_TYPE, &sock_type, &optlen) == -1 > + || sock_type != SOCK_DGRAM) > + { > + /* Not a UDP socket, interface-specific bind is irrelevant. */ > + goto cleanup; > + } > + /* Obtain the size of the IPv4 adapter list and allocate structure memory */ > + if (GetAdaptersInfo(NULL, &adap_size) != ERROR_BUFFER_OVERFLOW) > + { > + ERR("Failed to get the size of the adapter list, " > + "bound broadcast packets will not work on this socket.\n"); > + goto cleanup; > + } > + adapters = HeapAlloc(GetProcessHeap(), 0, adap_size); > + if (adapters == NULL) > + { > + ERR("Failed to allocate the adapter list, " > + "bound broadcast packets will not work on this socket.\n"); > + goto cleanup; > + } > + /* Obtain the IPv4 adapter list */ > + if (GetAdaptersInfo(adapters, &adap_size) != NO_ERROR) > + { > + ERR("Failed to obtain the adapter list, " > + "bound broadcast packets will not work on this socket.\n"); > + goto cleanup; > + } > + /* Search the IPv4 adapter list for the appropriate binding IP */ > + for (adapter = adapters; adapter != NULL; adapter = adapter->Next) > + { > + char *ip = adapter->IpAddressList.IpAddress.String; > + in_addr_t adapter_addr = (in_addr_t) inet_addr(ip); > + > + if (in_sock->sin_addr.s_addr == adapter_addr) > + { > +#ifdef SO_BINDTODEVICE > + struct ifreq ifr; > + > + memset(&ifr, 0, sizeof(ifr)); > + lstrcpynA(ifr.ifr_name, adapter->AdapterName, sizeof(ifr.ifr_name)); > + if (setsockopt(fd, SOL_SOCKET, SO_BINDTODEVICE, (void*)&ifr, sizeof(ifr)) == 0) > + { > + /* Success! All packets sent on this socket will go through the > + * specified interface. */ > + TRACE("Bound to interface '%s' (corresponds to local address %s).\n", > + adapter->AdapterName, inet_ntoa(in_sock->sin_addr)); > + ret = TRUE; > + break; > + } > + > + /* If we are unable to bind to a specific interface then notify the > + * user that broadcast packets will not work for this socket. The > + * user can correct this by giving CAP_NET_RAW access to the > + * wine-preloader binary. */ > + ERR("SO_BINDTODEVICE failed (requires CAP_NET_RAW), " > + "broadcast packets will not work on this socket.\n"); > +#else /* SO_BINDTODEVICE */ > + WARN("SO_BINDTODEVICE is unsupported on this platform, " > + "broadcast packets will not work on this socket.\n"); > +#endif /* SO_BINDTODEVICE */ > + break; > + } > + } > + > +cleanup: > + HeapFree(GetProcessHeap(), 0, adapters); > + return ret; > +} > + > +/*********************************************************************** > * bind (WS2_32.2) > */ > int WINAPI WS_bind(SOCKET s, const struct WS_sockaddr* name, int namelen) > @@ -2151,6 +2239,12 @@ int WINAPI WS_bind(SOCKET s, const struct WS_sockaddr* name, int namelen) > "INADDR_ANY instead.\n"); > in4->sin_addr.s_addr = htonl(WS_INADDR_ANY); > } > + else if (interface_bind(fd, &uaddr.addr)) > + { > + /* Bound to a specific interface, change the binding > + * address so that broadcast packets work properly */ > + in4->sin_addr.s_addr = htonl(WS_INADDR_ANY); > + } > } > if (bind(fd, &uaddr.addr, uaddrlen) < 0) > { > -- > 1.7.1 > >

2 1

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile
by Frédéric Delanoy Oct. 4, 2011

Oct. 4, 2011

2011/10/4 Dan Kegel <dank(a)kegel.com>: > + * handle_type: type of hIn handle > + * 0 if file, 1 if console, anything else if unknown (autodetect) > > I suspect you want an enum for that. Well I thought about that, but found it a bit overkill for such a limited set of possible values. Also, if I used sthg like enum CMD_HANDLE_TYPE { CMD_HT_FILE = 0, CMD_HT_CONSOLE = 1, CMD_HT_UNKNOWN = 2 } , I'd have to add error checking for unknown parameters passed to WCMD_ReadFile, or never check for CMD_HT_UNKNOWN, and just use it as default value. So TBH I don't think an enum is really necessary (especially since it's just a corner case; all "similar" functions use a BOOL is_console_handle, covering cases 0 and 1. I wouldn't want to change those)

4 6

re: kernel32: Implement GetVolumePathName.
by Dan Kegel Oct. 4, 2011

Oct. 4, 2011

Fails test here? ../../../tools/runtest -q -P wine -M ntdll.dll -T ../../.. -p ntdll_test.exe.so file.c && touch file.ok Unhandled exception: page fault on read access to 0x00212b18 in 32-bit code (0x7bc47995). Backtrace: =>0 HEAP_CreateFreeBlock+0xbb(subheap=0x110014, ptr=0x122b48, size=0xeffd0) [dlls/ntdll/heap.c:583] 1 HEAP_ShrinkBlock+0x42(subheap=0x110014, pArena=0x122b08, size=0x38) [dlls/ntdll/heap.c:685] 2 RtlAllocateHeap+0x2a8(heap=0x110000, flags=0x2, size=0x38) [dlls/ntdll/heap.c:1699] 3 RtlDosPathNameToNtPathName_U+0x35c(dos_path="C:\windows\system32", ntpath=0x32fbb4, file_part=(nil), cd=(nil)) [dlls/ntdll/path.c:394] 4 GetVolumePathNameW+0x107(filename="C:\windows\system32", volumepathname="?Ir\sandbox\slave\(", buflen=0x14) [dlls/kernel32/volume.c:1767] 5 test_file_name_information+0x179() [dlls/ntdll/tests/file.c:1304] 6 func_file+0x374() [dlls/ntdll/tests/file.c:1726] 7 run_test+0x9e(name="file.c") [include/wine/test.h:556] 8 main+0x23a(argc=<?>, argv=0x1103c8) [include/wine/test.h:624] 0x7bc47995 HEAP_CreateFreeBlock+0xbb [dlls/ntdll/heap.c:583] in ntdll: movl 0x0(%eax),%eax 583 (*(DWORD *)((char *)ptr + size) & ARENA_FLAG_FREE))

4 5

Re: [2/2] gdi32/tests: fix MSVC build in bitmap.c
by Marvin Oct. 4, 2011

Oct. 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14695 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 00416287 === W2KPROSP4 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 00416287 === WXPPROSP3 (32 bit bitmap) === bitmap: unhandled exception 80000003 at 7C90120E === W2K3R2SESP2 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 7C83F11C === WVISTAADM (32 bit bitmap) === bitmap: unhandled exception c0000005 at 7749653F === W2K8SE (32 bit bitmap) === bitmap: unhandled exception c0000005 at 00000000 === W7PRO (32 bit bitmap) === bitmap: unhandled exception c0000005 at 772D5A15 === W7PROX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 00000000 === TEST64_W7SP1 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77593CDB === W7PROX64 (64 bit bitmap) === Timeout === TEST64_W7SP1 (64 bit bitmap) === Timeout

1 0

Regression by author list?
by Damjan Jovanovic Oct. 4, 2011

Oct. 4, 2011

Hi Where do we find that list of regressions by author, that was in Alexandre's keynote at Wineconf? Thank you Damjan Jovanovic

2 1

unable to compile wine from latest git
by Vijay Kiran Kamuju Oct. 4, 2011

Oct. 4, 2011

Hi, I just downloaded the git and tried compile it. I just issued `make` command after doing `./configure` But it gave the below errors: make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/tools/wrc' make[1]: Entering directory `/media/PENDRIVE/devel/repo/wine/include' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/include' make[1]: Entering directory `/media/PENDRIVE/devel/repo/wine/dlls/adsiid' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/dlls/adsiid' rm -f dlls/libd3dcompiler.def && cp -p d3dcompiler_43/libd3dcompiler.def dlls/libd3dcompiler.def cp: cannot stat `d3dcompiler_43/libd3dcompiler.def': No such file or directory make: *** [dlls/libd3dcompiler.def] Error 1 Since the build of wine has changed a bit, i am unable to understand how to fix this issue. Thanks, Vijay

3 6

re: [1/3] kernel32/tests: Test K32GetProcessImageFileNameA() and improve the QueryFullProcessImageNameA() tests.
by Dan Kegel Oct. 3, 2011

Oct. 3, 2011

Build fails here with -Werror: process.c: In function ‘test_GetProcessImageFileNameA’: process.c:1646: error: unused variable ‘image’ You seem to have two copies of that variable, one shadowing the other?

1 0

Alexandre's keynote
by Jeremy White Oct. 2, 2011

Oct. 2, 2011

Thanks to Jon Parshall's hard work, we have Alexandre's keynote available here: http://www.youtube.com/watch?v=2rdDvMonTnQ Remember to have your libation at hand so you can play the game... <grin> Cheers, Jeremy

6 6

Re: [po]updated korean resource(2011-09-30)
by Francois Gouget Oct. 1, 2011

Oct. 1, 2011

On Fri, 30 Sep 2011, Hwang YunSong(황윤성) wrote: [...] > #: winecfg.rc:88 > -#, fuzzy > msgid "(None)" > -msgstr "없음" > +msgstr "(없음)" I think you're missing a closing parenthesis here. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ question = ( to ) ? be : ! be; -- Wm. Shakespeare

1 0

Script for bisecting conformance test failures
by Francois Gouget Oct. 1, 2011

Oct. 1, 2011

Would something like this be useful to include in Wine? If that's deemed interesting I can clean it up and submit it. I'm posting it here early in case it's useful for WineConf. It's a tool which you can use with git bisect to find the patch that causes a regression in a conformance test. It's used like this: git bisect start <bad> <good> git bisect run ./tools/testbisect dlls/gdi32/tests bitmap Come back a bit later and you have the bad patch. It can also be used with flaky tests by specifying the number of times to run a test. So if a test fails in 30% of the time you could only consider that it works if it succeeds 10 times in a row. You can even grep for a specific error if the test has other errors you don't care about. Finally you can also use it without git just to figure out if a test is flaky or not. For instance: $ ./tools/testbisect dlls/random/tests flaky 100 100 Failed 42 time(s) in 100 run(s) -> definitely flaky -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Indifference will certainly be the downfall of mankind, but who cares?

1 0

re: [PATCH 2/2] cmd: Handle truncation for console reads
by Dan Kegel Oct. 1, 2011

Oct. 1, 2011

What's motivating this change? Are you quite sure you know how ReadConsole behaves? I bet one could write a test for this that used SendInput to send keystrokes to be read by ReadConsole, and verify the end of line and end of buffer behavior...

2 1

re: [PATCH 1/2] cmd: Improve WCMD_fgets documentation
by Dan Kegel Oct. 1, 2011

Oct. 1, 2011

+ * We can't use the native f* functions because of the filename syntax differences + * between DOS and Unix. That doesn't belong in a function comment; it's an implementation detail that belongs, at most, inside the function.

2 1

Favorite bug: deadlock preventing backtraces?
by Dan Kegel Sept. 30, 2011

Sept. 30, 2011

On one of my boxes, if I run winmm/midi.ok in a loop, it will eventually deadlock/crash ( http://bugs.winehq.org/show_bug.cgi?id=28388 ): err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main process heap section" wait timed out in thread 0022, blocked by 001f, retrying (60 sec) wine: Critical section 00110060 wait failed at address 0x7bc3484a (thread 0022), starting debugger... err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main process heap section" wait timed out in thread 0022, blocked by 001f, retrying (60 sec) Sadly, no backtrace follows ( http://bugs.winehq.org/show_bug.cgi?id=28265 ). Since I'm not around when it finally happens, I haven't tried btall yet. I suppose I should write a shell script to watch for that error message in the log, and run btall then... any better ideas? (I did try giving winedbg a private heap, didn't seem to prevent the deadlock.)

2 2