October 2011 - Wine-Devel - list.winehq.org

Re: [3/6] wined3d: Use the destination palette when blitting between P8 surfaces
by Henri Verbeet Oct. 13, 2011

Oct. 13, 2011

On 13 October 2011 01:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Native transfers the 8 bit data without modifications to the destination > surface and does the palette lookup when showing the final front buffer > contents on the screen. Which makes much more sense.

2 2

Re: [1/6] wined3d: YUV formats are block-based
by Henri Verbeet Oct. 13, 2011

Oct. 13, 2011

On 13 October 2011 01:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/d3d9/tests/surface.c b/dlls/d3d9/tests/surface.c > diff --git a/dlls/ddraw/tests/overlay.c b/dlls/ddraw/tests/overlay.c These tests don't prove anything, they pass on current Wine as well. > + {WINED3DFMT_YUY2, 2, 1, 4, FALSE }, > + {WINED3DFMT_UYVY, 2, 1, 4, FALSE }, > + /* YV12 actually has 2x2 blocks with 6 bytes per block, but the blocks > + * are spread across the surface. */ > + {WINED3DFMT_YV12, 1, 1, 1, FALSE}, Blocks with 1 height aren't really blocks.

2 1

Re: wined3d: Refuse to create a shader unsupported by the backend.
by Alexandre Julliard Oct. 13, 2011

Oct. 13, 2011

Matteo Bruni <mbruni(a)codeweavers.com> writes: > --- > dlls/d3d9/tests/shader.c | 22 ++++++++++++++++++++-- > dlls/wined3d/device.c | 2 ++ > dlls/wined3d/shader.c | 19 +++++++++++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 4 files changed, 42 insertions(+), 2 deletions(-) It breaks the tests here: ../../../tools/runtest -q -P wine -M d3d10.dll -T ../../.. -p d3d10_test.exe.so effect.c && touch effect.ok effect.c:2661: Test failed: D3D10CreateEffectFromMemory failed! wine: Unhandled page fault on read access to 0x00000000 at address 0x6869a2a3 (thread 0024), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] server/named_pipe.c: remove the ps_disconnected_server state, if DisconnectNamedPipe is called, the server i
by Marvin Oct. 13, 2011

Oct. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14877 Your paranoid android. === WXPPROSP3 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K3R2SESP2 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === WVISTAADM (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K8SE (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PRO (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (64 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (64 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368

1 0

Re: [PATCH 4/5] kernel32, ntdll: implement most of GetNamedPipeHandleState (try 3)
by Marvin Oct. 13, 2011

Oct. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14876 Your paranoid android. === WXPPROSP3 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K3R2SESP2 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === WVISTAADM (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K8SE (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PRO (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (64 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (64 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368

1 0

For review please: wineps.drv: Implement PS_USERSTYLE on printers
by Daniel Oct. 13, 2011

Oct. 13, 2011

Hello guys. I would like to get a little review on this patch, a follow up to the patches that fix this problem on the screen. Specifically, I'm most concerned about making sure my dynamically allocated memory is freed under all conditions and there's no potential snafus that I'm not aware of. Then, of course, if somebody sees something off, please do comment. It does indeed completely fix http://bugs.winehq.org/show_bug.cgi?id=26091 (printed a cute piece of music with dashed lines). Thanks all! Daniel

2 1

Re: wined3d: recognize "Brian Paul" as a mesa card vendor
by Henri Verbeet Oct. 13, 2011

Oct. 13, 2011

On 13 October 2011 02:23, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=28684 / > http://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/getstring.c#n88 > Yeah, this makes sense. You'd probably mostly run into this if you're not using the regular dri based drivers, but that's valid, if somewhat obscure.

1 0

Re: [1/4] winex11.drv: Add on-screen PS_USERSTYLE support to pens (take 4)
by Frédéric Delanoy Oct. 13, 2011

Oct. 13, 2011

On Thu, Oct 13, 2011 at 06:08, Daniel <danielfsantos(a)att.net> wrote: > Fixes on-screen portion of http://bugs.winehq.org/show_bug.cgi?id=26091 You should configure your mail/git config so your real name appears in patches, and not just your first name "Daniel"

1 0

Re: mscoree: Register interfaces
by Alexandre Julliard Oct. 13, 2011

Oct. 13, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -10,4 +10,6 @@ C_SRCS = \ > metahost.c \ > mscoree_main.c > > +IDL_R_SRCS = mscoree_v1.idl There's no reason to name the file v1, that's a leftover from stdole.tlb but it doesn't make sense here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] winex11.drv: Add on-screen PS_USERSTYLE support to pens (bugbot feeding #5)
by Alexandre Julliard Oct. 13, 2011

Oct. 13, 2011

Daniel <danielfsantos(a)att.net> writes: > @@ -42,29 +42,23 @@ HPEN X11DRV_SelectPen( PHYSDEV dev, HPEN hpen ) > X11DRV_PDEVICE *physDev = get_x11drv_dev( dev ); > LOGPEN logpen; > int i; > + EXTLOGPEN *elp = NULL; > + INT size = GetObjectW( hpen, 0, NULL ); > > - if (!GetObjectW( hpen, sizeof(logpen), &logpen )) > - { > - /* must be an extended pen */ > - EXTLOGPEN *elp; > - INT size = GetObjectW( hpen, 0, NULL ); > - > - if (!size) return 0; > - > + if (!size) return 0; > + else if (size == sizeof(logpen)) { > + GetObjectW( hpen, sizeof(logpen), &logpen ); > + physDev->pen.ext = 0; > + } else { You are changing too much here, there's no reason to duplicate the GetObject call for the standard case. Also please make sure to include your full name in your mail headers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [msi] initialize variable to placate static analyzers
by Michael Stefaniuc Oct. 13, 2011

Oct. 13, 2011

Hello Dan, Dan Kegel wrote: > Avoids the spurious compiler warning > > msi.c: In function 'MSI_ApplyPatchW': > msi.c:353:10: error: 'r' may be used uninitialized in this function > > Hans says "It's compiler confusion but I'm fine with a patch that initializes > r with ERROR_FUNCTION_FAILED." why don't you just initialize r in the declaration of r? It's the standard way of doing it and doesn't require a suboptimal comment (that warning is gcc version dependent). bye michael

1 0

Re: 79869: [2/4] gdi32: remove PS_USERSTYLE FIXME and work-arounds (take 4)
by Dan Kegel Oct. 12, 2011

Oct. 12, 2011

Still fails tests here. Sorry if I wasn't clear before. The wine tests are supposed to pass after *every* patch in your series. That means you have to merge patches 2 and 3 together, I think. On Wed, Oct 12, 2011 at 9:27 PM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/297 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > alarum: failed command was ../../../wine gdi32_test.exe.so pen.c > pen.c:317: Test succeeded inside todo block: expected 7, got 7 > make: *** [pen.ok] Error 1 > * Call to xpconnect wrapped JSObject produced this error: * > * Call to xpconnect wrapped JSObject produced this error: * > GnuTLS error: GnuTLS internal error. > >

1 0

re: ntdll: Define PATH_MAX when needed
by Dan Kegel Oct. 12, 2011

Oct. 12, 2011

When is PATH_MAX not defined? It's part of posix (see http://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html ) Are you trying to build on Gnu Hurd?

3 2

WineHQ database compromise
by Jeremy White Oct. 12, 2011

Oct. 12, 2011

Hi, I am sad to say that there was a compromise of the WineHQ database system. What we know at this point that someone was able to obtain unauthorized access to the phpmyadmin utility. We do not exactly how they obtained access; it was either by compromising an admins credentials, or by exploiting an unpatched vulnerability in phpmyadmin. We had reluctantly provided access to phpmyadmin to the appdb developers (it is a very handy tool, and something they very much wanted). But it is a prime target for hackers, and apparently our best efforts at obscuring it and patching it were not sufficient. So we have removed all access to phpmyadmin from the outside world. We do not believe the attackers obtained any other form of access to the system. On the one hand, we saw no evidence of harm to any database. We saw no evidence of any attempt to change the database (and candidly, using the real appdb or bugzilla is the easy way to change the database). Unfortunately, the attackers were able to download the full login database for both the appdb and bugzilla. This means that they have all of those emails, as well as the passwords. The passwords are stored encrypted, but with enough effort and depending on the quality of the password, they can be cracked. This, I'm afraid, is a serious threat; it means that anyone who uses the same email / password on other systems is now vulnerable to a malicious attacker using that information to access their account. We are going to be resetting every password and sending a private email to every affected user. This is again another reminder to never use a common username / password pair. This web site provides further advice as well: http://asiknews.wordpress.com/2011/03/02/best-practice-password-management-… I am very sad to have to report this. We have so many challenges in our world today that this is a particularly painful form of salt for our wounds. However, I think it is urgent for everyone to know what happened. Cheers, Jeremy

11 16

Re: [4/3] gdi32/tests: update test for PS_USERSTYLE
by Austin English Oct. 12, 2011

Oct. 12, 2011

On Wed, Oct 12, 2011 at 19:06, Daniel <danielfsantos(a)att.net> wrote: > OK, I hope [4/3] is acceptable. These are the test updates I forgot > (removes a todo_wine). Two problems: A) It needs to be combined with the original patch, so that it passes make test. B) Why remove the test? Just remove 'todo_wine' itself, since the test now passes on wine.. -- -Austin

2 1

re: [4/3] gdi32/tests: update test for PS_USERSTYLE
by Dan Kegel Oct. 12, 2011

Oct. 12, 2011

> OK, I hope [4/3] is acceptable. It's fine for humans, but for buildbot, you really need to send the whole patch series again, with the test fixes right in the same patch as the code that fixes them (so that the wine tree passes all tests after each patch in the series). Otherwise your code will not be tested.

1 0

Re: 79857: [2/3] gdi32: remove PS_USERSTYLE FIXME and work-arounds (take 3)
by Dan Kegel Oct. 12, 2011

Oct. 12, 2011

Fails the gdi32/pen.ok test here, with error pen.c:317: Test succeeded inside todo block: expected 7, got 7 Looks like you need to update a test. On Wed, Oct 12, 2011 at 4:00 PM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/280 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > alarum: failed command was ../../../wine gdi32_test.exe.so pen.c > pen.c:317: Test succeeded inside todo block: expected 7, got 7 > make: *** [pen.ok] Error 1 > * Call to xpconnect wrapped JSObject produced this error: * > * Call to xpconnect wrapped JSObject produced this error: * > GnuTLS error: GnuTLS internal error. > >

2 1

[RFC] Use ICU in wine ?
by Rafał Mużyło Oct. 12, 2011

Oct. 12, 2011

Right now, wine claims to use DUCET data for lingustic sorting, but by section 1.9.2 of that document (as of version 6.0.0), uses it in a wrong way. The result of it are bugs such as #10767 and #9583. A possible way around it would beby using ICU to get language specific tailoring and applying some of wine-specific for the parts addressed by #10767. In a way, wine already *indirectly* depends on icu on many distros (a potential libxml2 dep) - they were quite a few patches already addressing build failures caused by this in recent past. I've cooked up a patch, that's unfortunately isn't working properly yet, it's more of a draft on where to go, if such road were to be taken. Main issue with this patch ain't it's not ignoring the proper list of symbols, as this would be easy to fix, if not for one problem: the part that I put inside 'if (0)' block. For some reason (threading, perhaps ?), if I pass a non-zero lenght string to ucol_openRules, wineboot hangs. Oddly, if the string lenght is 0, the hang doesn't happen. I can't really tell, what going wrong, as the almost same code works in native linux testcase. Also, while in this patch UCOL_ALTERNATE_HANDLING would have been used for NORM_IGNORESYMBOLS, it would be much better to manipulate some of the settings by a custom rule and VariableTop value, but to do that, first such rule would have to be passed and that odd hang prevents it at the moment. It would also be nice, if it was possible to initialize the collator only once for an app instance - after all, in Windows locale change requires a reboot, so while (AFAIK) one wineserver instance can have apps in different locales running, locale can't change for an already running app. So if you have any idea of why exactly the hang happens and how to get around it or know any *technical* reasons of why ICU couldn't be used in wine, CC me with comments.

5 7

Re: wined3d: Report every texture format as filterable and blendable.
by Dan Kegel Oct. 12, 2011

Oct. 12, 2011

Fails d3d9's visual tests here. os: Linux 3.0.0-12-generic, Ubuntu 11.10 gpu: GeForce GT 240/PCI/SSE2 3.3.0 NVIDIA 280.13 On Wed, Oct 12, 2011 at 2:52 PM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/273 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > alarum: failed command was ../../../wine d3d9_test.exe.so visual.c > fixme:win:EnumDisplayDevicesW ((null),0,0x33f0cc,0x00000000), stub! > fixme:d3d_draw:drawPrimitive Using software emulation because manual fog coordinates are provided > fixme:d3d:state_shademode WINED3DSHADE_PHONG isn't supported > fixme:d3d:state_shademode WINED3DSHADE_PHONG isn't supported > visual.c:9147: Tests skipped: D3DFMT_G16R16 textures not supported as render targets. > visual.c:9239: Test failed: Offscreen failed for D3DFMT_R16F: Got color 0x20ffff, expected 0x18ffff. > visual.c:9239: Test failed: Offscreen failed for D3DFMT_G16R16F: Got color 0x2010ff, expected 0x1818ff. > visual.c:9239: Test failed: Offscreen failed for D3DFMT_R32F: Got color 0x20ffff, expected 0x18ffff. > visual.c:9239: Test failed: Offscreen failed for D3DFMT_G32R32F: Got color 0x2010ff, expected 0x1818ff. > visual.c:9239: Test failed: Offscreen failed for D3DFMT_A32B32G32R32F: Got color 0x201000, expected 0x181800. > visual.c:7741: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests > make: *** [visual.ok] Error 5 > * Call to xpconnect wrapped JSObject produced this error: * > * Call to xpconnect wrapped JSObject produced this error: * > GnuTLS error: GnuTLS internal error. > >

2 1

Please Test again, user32: use uniscribe in the single line edit control
by Aric Stewart Oct. 12, 2011

Oct. 12, 2011

Apologies I sent this to the wrong list just now. Ok, Thanks to Dan I have found and corrected the issues that this created with the tests. I believe all the tests should continue to pass with this version of the patch. Has anyone tried it live in any applications? -aric --- dlls/user32/edit.c | 252 +++++++++++++++++++++++++++++----------------------- 1 files changed, 142 insertions(+), 110 deletions(-)

1 0

Re: shell32/tests: Better check the result of SHGetDesktopFolder
by Austin English Oct. 12, 2011

Oct. 12, 2011

2011/10/12 André Hentschel <nerv(a)dawncrow.de>: > Might fix the crash in some NT4 systems > --- > dlls/shell32/tests/brsfolder.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/tests/brsfolder.c b/dlls/shell32/tests/brsfolder.c > index 7b87967..6e5e73b 100644 > --- a/dlls/shell32/tests/brsfolder.c > +++ b/dlls/shell32/tests/brsfolder.c > @@ -331,7 +331,8 @@ static void test_selection(void) > > hr = SHGetDesktopFolder(&desktop_object); > ok (SUCCEEDED(hr), "SHGetDesktopFolder failed with hr 0x%08x\n", hr); > - if (FAILED(hr)) { > + ok (desktop_object, "Expected desktop_object to be a valid interface\n"); > + if (FAILED(hr) || !desktop_object) { > skip("SHGetDesktopFolder failed - skipping\n"); > return; > } > -- > > Best Regards, André Hentschel Causes a compiler warning on Buildbot: Errors: brsfolder.c: In function 'test_selection': brsfolder.c:334:5: error: passing argument 1 of 'winetest_ok' makes integer from pointer without a cast [-Werror] make[1]: *** [brsfolder.o] Error 1 -- -Austin

1 0

Warning report for wine-1.3.30-55-g583e887
by Jerome Leclanche Oct. 12, 2011

Oct. 12, 2011

It would be nice to fix the "array subscript is above array bounds" warning spam for 1.4.0. They make up 90% of the warnings. Apart from those, theres 25 more warning blocks to fix, most of them unused-but-set-variables. JL

5 5

Re: [Corrected^2] dlls/ntdll/serial.c: Generate a single EV_TXEMPTY when the\ TX buffer turns empty
by Alexandre Julliard Oct. 12, 2011

Oct. 12, 2011

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > @@ -807,8 +808,22 @@ typedef struct async_commio > static NTSTATUS get_irq_info(int fd, serial_irq_info *irq_info) > { > NTSTATUS status = STATUS_NOT_IMPLEMENTED; > -#ifdef TIOCGICOUNT > struct serial_icounter_struct einfo; You can't move this out of the #idef. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d8/tests: skip the visual test if d3d cannot be initialized
by Henri Verbeet Oct. 12, 2011

Oct. 12, 2011

On 12 October 2011 01:51, Austin English <austinenglish(a)gmail.com> wrote: > Current d3d8 does a win_skip(), while d3d9 does a skip(). This unifies > the behavior to match the d3d9 behavior. > I seem to recall this being intentional, so that you get a failure if your setup has e.g. no OpenGL.

2 1

Re: [4/4] wined3d: Don't allow fbo blits to frontbuffers that need fixups.
by Henri Verbeet Oct. 12, 2011

Oct. 12, 2011

On 11 October 2011 22:31, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > static BOOL fbo_blit_supported(const struct wined3d_gl_info *gl_info, enum wined3d_blit_op blit_op, > const RECT *src_rect, DWORD src_usage, WINED3DPOOL src_pool, const struct wined3d_format *src_format, > - const RECT *dst_rect, DWORD dst_usage, WINED3DPOOL dst_pool, const struct wined3d_format *dst_format) > + const RECT *dst_rect, DWORD dst_usage, WINED3DPOOL dst_pool, const struct wined3d_format *dst_format, > + const struct wined3d_surface *dst_surface) I don't think we want this. Does this actually ever happen?

2 1