October 2011 - Wine-Devel - list.winehq.org

Re: [3/6] wined3d: Use the destination palette when blitting between P8 surfaces
by Henri Verbeet Oct. 13, 2011

Oct. 13, 2011

On 13 October 2011 01:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Native transfers the 8 bit data without modifications to the destination > surface and does the palette lookup when showing the final front buffer > contents on the screen. Which makes much more sense.

2 2

Re: [1/6] wined3d: YUV formats are block-based
by Henri Verbeet Oct. 13, 2011

Oct. 13, 2011

On 13 October 2011 01:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/d3d9/tests/surface.c b/dlls/d3d9/tests/surface.c > diff --git a/dlls/ddraw/tests/overlay.c b/dlls/ddraw/tests/overlay.c These tests don't prove anything, they pass on current Wine as well. > + {WINED3DFMT_YUY2, 2, 1, 4, FALSE }, > + {WINED3DFMT_UYVY, 2, 1, 4, FALSE }, > + /* YV12 actually has 2x2 blocks with 6 bytes per block, but the blocks > + * are spread across the surface. */ > + {WINED3DFMT_YV12, 1, 1, 1, FALSE}, Blocks with 1 height aren't really blocks.

2 1

Re: wined3d: Refuse to create a shader unsupported by the backend.
by Alexandre Julliard Oct. 13, 2011

Oct. 13, 2011

Matteo Bruni <mbruni(a)codeweavers.com> writes: > --- > dlls/d3d9/tests/shader.c | 22 ++++++++++++++++++++-- > dlls/wined3d/device.c | 2 ++ > dlls/wined3d/shader.c | 19 +++++++++++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 4 files changed, 42 insertions(+), 2 deletions(-) It breaks the tests here: ../../../tools/runtest -q -P wine -M d3d10.dll -T ../../.. -p d3d10_test.exe.so effect.c && touch effect.ok effect.c:2661: Test failed: D3D10CreateEffectFromMemory failed! wine: Unhandled page fault on read access to 0x00000000 at address 0x6869a2a3 (thread 0024), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] server/named_pipe.c: remove the ps_disconnected_server state, if DisconnectNamedPipe is called, the server i
by Marvin Oct. 13, 2011

Oct. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14877 Your paranoid android. === WXPPROSP3 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K3R2SESP2 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === WVISTAADM (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K8SE (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PRO (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (32 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (64 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (64 bit pipe) === pipe.c:1605: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368

1 0

Re: [PATCH 4/5] kernel32, ntdll: implement most of GetNamedPipeHandleState (try 3)
by Marvin Oct. 13, 2011

Oct. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14876 Your paranoid android. === WXPPROSP3 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K3R2SESP2 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === WVISTAADM (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W2K8SE (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PRO (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (32 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === W7PROX64 (64 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368 === TEST64_W7SP1 (64 bit pipe) === pipe.c:1561: Test failed: expected ERROR_CANNOT_IMPERSONATE, got 1368

1 0

For review please: wineps.drv: Implement PS_USERSTYLE on printers
by Daniel Oct. 13, 2011

Oct. 13, 2011

Hello guys. I would like to get a little review on this patch, a follow up to the patches that fix this problem on the screen. Specifically, I'm most concerned about making sure my dynamically allocated memory is freed under all conditions and there's no potential snafus that I'm not aware of. Then, of course, if somebody sees something off, please do comment. It does indeed completely fix http://bugs.winehq.org/show_bug.cgi?id=26091 (printed a cute piece of music with dashed lines). Thanks all! Daniel

2 1

Re: wined3d: recognize "Brian Paul" as a mesa card vendor
by Henri Verbeet Oct. 13, 2011

Oct. 13, 2011

On 13 October 2011 02:23, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=28684 / > http://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/getstring.c#n88 > Yeah, this makes sense. You'd probably mostly run into this if you're not using the regular dri based drivers, but that's valid, if somewhat obscure.

1 0

Re: [1/4] winex11.drv: Add on-screen PS_USERSTYLE support to pens (take 4)
by Frédéric Delanoy Oct. 13, 2011

Oct. 13, 2011

On Thu, Oct 13, 2011 at 06:08, Daniel <danielfsantos(a)att.net> wrote: > Fixes on-screen portion of http://bugs.winehq.org/show_bug.cgi?id=26091 You should configure your mail/git config so your real name appears in patches, and not just your first name "Daniel"

1 0

Re: mscoree: Register interfaces
by Alexandre Julliard Oct. 13, 2011

Oct. 13, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -10,4 +10,6 @@ C_SRCS = \ > metahost.c \ > mscoree_main.c > > +IDL_R_SRCS = mscoree_v1.idl There's no reason to name the file v1, that's a leftover from stdole.tlb but it doesn't make sense here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] winex11.drv: Add on-screen PS_USERSTYLE support to pens (bugbot feeding #5)
by Alexandre Julliard Oct. 13, 2011

Oct. 13, 2011

Daniel <danielfsantos(a)att.net> writes: > @@ -42,29 +42,23 @@ HPEN X11DRV_SelectPen( PHYSDEV dev, HPEN hpen ) > X11DRV_PDEVICE *physDev = get_x11drv_dev( dev ); > LOGPEN logpen; > int i; > + EXTLOGPEN *elp = NULL; > + INT size = GetObjectW( hpen, 0, NULL ); > > - if (!GetObjectW( hpen, sizeof(logpen), &logpen )) > - { > - /* must be an extended pen */ > - EXTLOGPEN *elp; > - INT size = GetObjectW( hpen, 0, NULL ); > - > - if (!size) return 0; > - > + if (!size) return 0; > + else if (size == sizeof(logpen)) { > + GetObjectW( hpen, sizeof(logpen), &logpen ); > + physDev->pen.ext = 0; > + } else { You are changing too much here, there's no reason to duplicate the GetObject call for the standard case. Also please make sure to include your full name in your mail headers. -- Alexandre Julliard julliard(a)winehq.org

1 0