November 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] jscript: Added tests of unary '+' on not existent property
by Marvin Nov. 22, 2011

Nov. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15587 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [4/5] ntdll: Remove an invalid test.
by Alexandre Julliard Nov. 22, 2011

Nov. 22, 2011

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > The test initializers that call GetProcAddress() do write to the same section > where the static buffer resides, which leads to the image section protection > change. That doesn't make the test invalid. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL
by Henri Verbeet Nov. 22, 2011

Nov. 22, 2011

On 22 November 2011 00:42, Eduard - Gabriel Munteanu <eduard.munteanu(a)linux360.ro> wrote: > This fixes a division by zero generated in Unigine Tropics in D3D10 > mode. It also adds a helper to handle such conversions, which takes the > form of a macro so we don't need to worry about the result's type. > I'd prefer an actual function. A small test for this probably wouldn't hurt either.

1 0

Re: winefile: Make it possible to translate the disk size units.
by Francois Gouget Nov. 22, 2011

Nov. 22, 2011

On Sat, 19 Nov 2011, Francois Gouget wrote: [...] > - static const WCHAR sFmtGB[] = {'%', '.', '1', 'f', ' ', 'G', 'B', '\0'}; > - static const WCHAR sFmtMB[] = {'%', '.', '1', 'f', ' ', 'M', 'B', '\0'}; > - static const WCHAR sFmtkB[] = {'%', '.', '1', 'f', ' ', 'k', 'B', '\0'}; To be totally correct these should actually be 'GiB', 'MiB' and 'kiB' (the code divides by powers of 1024). However that may be too geeky for regular users so I'm not sure we want to do that. But now is probably a good time to debate this. Here are two reference points: * On Windows winefile and explorer use 'KB' & co for the disk space although they divide by '1024'. * Nautilus uses 'kiB' & co. Another point is that we always display the exact byte count for file sizes instead of converting it to 'KB', 'MB', etc. That actually matches winfile but seems pretty cubersome. On Windows Explorer does show file sizes as 'KB', 'MB', etc. so that's what users would expect and I think it's a place where we could follow suite. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

3 2

regression bisected to commit: gdi32: Implement nulldrv_StretchDIBits using the PutImage gdi driver function.
by Wolfgang Walter Nov. 21, 2011

Nov. 21, 2011

Hello, I just tested version 1.3.33. With this version an application we use shows its icons with wrong colors. The background of the icons is wrong, too. I bisected it to commit c9a7bb715d2db1512db30deb11e4676e76791a07. I then checked that by replacing nulldrv_StretchDIBits in 1.3.33 with its older implementation. c9a7bb715d2db1512db30deb11e4676e76791a07 is the first bad commit commit c9a7bb715d2db1512db30deb11e4676e76791a07 Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Oct 17 15:46:07 2011 +0100 gdi32: Implement nulldrv_StretchDIBits using the PutImage gdi driver function. :040000 040000 e4cfeee3adcb0fe2c0502909c87b2740a8de08e5 00851b246b095bdf4cafd3e6f9965c811d1c87a4 M dlls Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Abteilungsleiter IT Leopoldstraße 15 80802 München

2 1

Question about messages and the windows these need.
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 21, 2011

Nov. 21, 2011

Hi, Alexandre Julliard wrote in http://www.winehq.org/pipermail/wine-devel/2011-July/090969.html >If you are going to wait for a reply it would be better to create a >HWND_MESSAGE window and do a SendMessage to it, then you get all the >synchronization for free. MMSYSTEM_MidiStream_Player needs a patch to fix bug #28388. Such a patch will likely introduce sending Suspend & Resume messages to the MIDI player (to be able to wait for the resume signal). So I believe this same advice applies. MMSYSTEM_MidiStream_PostMessage already contains a PostThreadMessage + MsgWait pair that looks like it should be replaced, correct? OTOH, I'm unsettled whether MidiStreamSuspend & -Restart should wait for a reply to the message, so PostThreadMessage may be enough. Furthermore, I'm unsure about the implications of adding a dummy window and message queue. The MSDN blogs contain repeated warnings about the obligation to pump the message queue and GUI apps hanging when some random app fails to do so in all situations. Won't that window receive all kinds of broadcast messages? No, says MSDN http://msdn.microsoft.com/en-us/library/windows/desktop/ms632599%28v=vs.85%… The MIDI sequencer uses simplistic timing based on GetTickCount. Won't that allow arbitrary foreign window callbacks to disturb the timing of the MIDI sequencer? Instead of inventing message names like #define WINE_MSM_STOP (WM_USER+1) Why not re-use message names like MCI_STOP even if it's not in MCI format? (sounds like a hack...) Thank you for your help, Jörg Höhle

1 0

Re: [PATCH 1/1] user32: Fix 64-bit 'msg' test hang in test_timers.
by Alexandre Julliard Nov. 21, 2011

Nov. 21, 2011

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > > Description: > The TestBot ran into a hanging issue (noticed with, but unrelated > to, my previous user32 patch) and I took some time today to track the > problem down. Currently, on the 64-bit test system the test_timers() > tests hang waiting for PeekMessage() to clear the message queue. The > attached patch kills the timer just prior to the PeekMessage() call, > thereby keeping the test from hanging indefinitely. > > Changelog: > user32: Fix 64-bit 'msg' test hang in test_timers. That defeats the purpose of the test. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation
by Jacek Caban Nov. 21, 2011

Nov. 21, 2011

Hi Nikolay, On 11/21/11 08:24, Nikolay Sivov wrote: > Added common ISupportErrorInfo implementation +/* common ISupportErrorInfo implementation */ +typedef struct { + ISupportErrorInfo ISupportErrorInfo_iface; + LONG ref; + + const tid_t* iids; +} SupportErrorInfo; + +static inline SupportErrorInfo *impl_from_ISupportErrorInfo(ISupportErrorInfo *iface) +{ + return CONTAINING_RECORD(iface, SupportErrorInfo, ISupportErrorInfo_iface); +} + +static HRESULT WINAPI SupportErrorInfo_QueryInterface(ISupportErrorInfo *iface, REFIID riid, void **obj) +{ + SupportErrorInfo *This = impl_from_ISupportErrorInfo(iface); + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), obj); + + *obj = NULL; + + if (IsEqualGUID(riid,&IID_IUnknown) || IsEqualGUID(riid,&IID_ISupportErrorInfo)) { + *obj = iface; + ISupportErrorInfo_AddRef(iface); + return S_OK; + } + + return E_NOINTERFACE; +} This doesn't seem to be the right approach. You need to return here interfaces of an object that inherits your ISupportErrorInfo implementation - that's the COM rule. Also you probably don't want to create new SupportErrorInfo instance on each QI call. I'd suggest DispatchEx-like approach in this case (or even abuse DispatchEx object and add ISupportErrorInfo there). Jacek

2 5

Re: [PATCH 1/2] jscript: Use bytecode for binary negation implementation
by Marvin Nov. 21, 2011

Nov. 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15559 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: qedit/tests: Add SampleGrabber COM aggregation test.
by Marvin Nov. 21, 2011

Nov. 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15558 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:147: Test failed: CoCreateInstance failed with 80040154 mediadet.c:148: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 004015A2 === W2KPROSP4 (32 bit mediadet) === mediadet.c:147: Test failed: CoCreateInstance failed with 80040154 mediadet.c:148: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 004015A2 === W2K8SE (32 bit mediadet) === mediadet.c:147: Test failed: CoCreateInstance failed with 80040154 mediadet.c:148: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 004015A2

2 1

Re: user32/tests: Drop superfluous function pointer casts.
by Marvin Nov. 21, 2011

Nov. 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15553 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

2 1

re: ID3DXEffect test on win
by Dan Kegel Nov. 20, 2011

Nov. 20, 2011

Hi Rico, I compiled the 32 bit wine tests on win7 64 bit using cygwin, and sure enough, there are 40 test failures there. You should probably avoid doing direct equality tests on floats; see e.g. compare() at line 47 of d3dx9_36/tests/mesh.c. You may have to tweak the slop value. (Google floating point comparison if you want the gory details of how tools like google test and boost's test_tools do it right.) effect.c:894: Test failed: 0 - f3: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 0 - f3: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 0 - f3: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 0 - f3: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 0 - f4: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 0 - f4: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 0 - f4: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 0 - f4: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 0 - f4: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 0 - f4: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 0 - f4: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 0 - f4: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 0 - f31: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 0 - f31: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1321: Test failed: 0 - f31: GetMatrix fvalue[8] failed, got 0.203922, expected 0.203922 effect.c:1438: Test failed: 0 - f31: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 0 - f41: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 0 - f41: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 0 - f41: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 0 - f41: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1321: Test failed: 0 - f41: GetMatrix fvalue[8] failed, got 0.203922, expected 0.203922 effect.c:1321: Test failed: 0 - f41: GetMatrix fvalue[12] failed, got 0.121569, expected 0.121569 effect.c:1438: Test failed: 0 - f41: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1438: Test failed: 0 - f41: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f3: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f3min: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3min: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3min: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3min: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f3max: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3max: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3max: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3max: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f4: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f4min: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4min: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4min: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4min: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4min: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4min: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4min: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4min: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f4max: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4max: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4max: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4max: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4max: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4max: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4max: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4max: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect: 1222410 tests executed (0 marked as todo, 60 failures), 0 skipped.

2 1

Re: [3/4] winemaker: Be less picky when detecting the target type (try 2)
by Vitaliy Margolen Nov. 20, 2011

Nov. 20, 2011

On 11/19/2011 11:42 AM, André Hentschel wrote: > this catches more than one 0 after the space and possible 0s after the x > + if (/[[:space:]]0+x0*101$/) { For more then one you should use "+" not "*". "*" means any number, including 0. Vitaliy

2 1

Re: added moethod stub for HttpPrepareUrl in dlls/httpapi/httpapi_main.c
by Bruno Jesus Nov. 20, 2011

Nov. 20, 2011

You have to use your full name (as advised before). See http://wiki.winehq.org/SubmittingPatches for more information. Also, gmail is breaking your patch, attach the patch file instead of pasting it to the email body. Best wishes, Bruno On Sat, Nov 19, 2011 at 09:24, ArasH <arash.cordi(a)gmail.com> wrote: > --- > dlls/httpapi/httpapi_main.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c > index 3375cb6..c5c8cda 100644 > --- a/dlls/httpapi/httpapi_main.c > +++ b/dlls/httpapi/httpapi_main.c > @@ -85,6 +85,27 @@ ULONG WINAPI HttpTerminate( ULONG flags, PVOID reserved ) > } > > /*********************************************************************** > + * HttpPrepareUrl (HTTPAPI.@) > + * parses, analyzes, and normalizes a non-normalized Unicode or punycode URL > + * so it is safe and valid to use in other HTTP functions. > + * > + * PARAMS > + * reserved [IO] reserved, must be NULL > + * flags [ I] reserved. must be zero > + * url [ I] a pointer to a string that represents the > non-normalized URL > + * prepared_url [ O] on success, a pointer to a string > representing the normalized URL. > + * > + * RETURNS > + * ERROR_SUCCESS if function succeeds, or error code if function fails > + * > + */ > +ULONG WINAPI HttpPrepareUrl( PVOID reserved, ULONG flags, PCWSTR url, > PWSTR *prepared_url) > +{ > + FIXME( "(%p, 0x%x, %p): stub!\n", reserved, flags, url ); > + return ERROR_SUCCESS; > +} > + > +/*********************************************************************** > * HttpDeleteServiceConfiguration (HTTPAPI.@) > * > * Remove configuration record from HTTP Server API configuration store > -- > 1.6.2.2 > > >

1 0

ID3DXEffect test on win
by Rico Schüller Nov. 19, 2011

Nov. 19, 2011

Hi, I've written some tests for the ID3DXEffect interface. The test is attached as source. What I'd like to know is if there are some rounding issues on some win versions. The test needs d3dx9_36.dll. I tried it on wine with native d3dx9_36.dll and got around 60 rounding errors (only on the combination SetInt() and GetValue/FloatArray/Vector/Matrix/MatrixTranspose). It would be nice if there is anyone interested in running those and would report the result. I'm looking for results on XP/W7/Vista. If you don't have a cross compiler and like to try the test, I could send the executable. Cheers Rico

1 0

Re: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.
by Alexandre Julliard Nov. 18, 2011

Nov. 18, 2011

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > The tests clearly show that this commit is wrong. If there is an application > or a test case which fails because of this, it would be helpful to at least > mention it. It fixes the test for .bss protection, in ntdll:info.c. -- Alexandre Julliard julliard(a)winehq.org

4 8

Translations strangeness
by Luca Bennati Nov. 18, 2011

Nov. 18, 2011

Hi all, I would like to clarify some doubts I have about Wine translations and its po/rc files: 1- Are the following highlighted strings errors from the script converting from rc to po or due to malformatted po files (seems not to recognize msgctx lines)? http://source.winehq.org/transl/resource.php?branch=master&lang=009%3A01&re… http://source.winehq.org/transl/resource.php?branch=master&lang=009%3A01&re… 2- Are the following highlighted strings (and similar) translatable or they were wrongly recognized by script? http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… 3- How is it that the following highlighted strings are translated in po files but seems not to be taken in consideration from script? http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… None here) I took the italian translations as example because I'm its actual volunteer maintainer and I know them. In summary, is it our (the translators) or my fault or is the script lacking? Nonetheless, how can we solve those issues?

2 1

Re: [5/5]usp10: Itemize numbers outside of the basic ascii set in a seperate script.
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15519 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:400: Test failed: 0:Wrong fRTL(1) usp10.c:400: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:400: Test failed: 0:Wrong BidiLevel(1) usp10.c:431: Test failed: 0:Wrong fRTL(1) usp10.c:431: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:431: Test failed: 0:Wrong BidiLevel(1) usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === W2KPROSP4 (32 bit usp10) === usp10.c:400: Test failed: 0:Wrong fRTL(1) usp10.c:400: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:400: Test failed: 0:Wrong BidiLevel(1) usp10.c:431: Test failed: 0:Wrong fRTL(1) usp10.c:431: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:431: Test failed: 0:Wrong BidiLevel(1) usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === WXPPROSP3 (32 bit usp10) === usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === W2K3R2SESP2 (32 bit usp10) === usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos

1 0

Re: [4/5]usp10: Windows breaks punctuation into 2 different script types.
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15518 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:393: Test failed: 0:Wrong fRTL(1) usp10.c:393: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:393: Test failed: 0:Wrong BidiLevel(1) usp10.c:423: Test failed: 0:Wrong fRTL(1) usp10.c:423: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:423: Test failed: 0:Wrong BidiLevel(1) usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === W2KPROSP4 (32 bit usp10) === usp10.c:393: Test failed: 0:Wrong fRTL(1) usp10.c:393: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:393: Test failed: 0:Wrong BidiLevel(1) usp10.c:423: Test failed: 0:Wrong fRTL(1) usp10.c:423: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:423: Test failed: 0:Wrong BidiLevel(1) usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === WXPPROSP3 (32 bit usp10) === usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === W2K3R2SESP2 (32 bit usp10) === usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel

1 0

Re: [3/5]usp10: handle Combining Diacritical Marks
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15517 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:384: Test failed: 0:Wrong fRTL(1) usp10.c:384: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:384: Test failed: 0:Wrong BidiLevel(1) usp10.c:413: Test failed: 0:Wrong fRTL(1) usp10.c:413: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:413: Test failed: 0:Wrong BidiLevel(1) === W2KPROSP4 (32 bit usp10) === usp10.c:384: Test failed: 0:Wrong fRTL(1) usp10.c:384: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:384: Test failed: 0:Wrong BidiLevel(1) usp10.c:413: Test failed: 0:Wrong fRTL(1) usp10.c:413: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:413: Test failed: 0:Wrong BidiLevel(1)

1 0

Re: [PATCH 5/5] jscript: Use bytecode interpreter for logical negation expression
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15516 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: ieframe: Fixed tests on IE9
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15514 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3165: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2750: Test failed: expected TranslateUrl webbrowser.c:2751: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2752: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2758: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3125: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2843: Test failed: expected RequestUIActivate webbrowser.c:2935: Test failed: Got 0x80004002 webbrowser.c:3132: Test failed: doc != doc2 webbrowser.c:3030: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

2 1

Using native msvc*.dll: all or nothing?
by Dan Kegel Nov. 18, 2011

Nov. 18, 2011

Given errors like err:module:find_forwarded_export function not found for forward 'msvcrt.__CxxFrameHandler3' used by L"C:\\windows\\system32\\msvcr90.dll". If you are using builtin L"msvcr90.dll", try using the native one instead. I'm starting to get the feeling that, if you're going to install any flavor of Microsoft C++ runtime libraries, you should install them all. Is that more or less correct? i.e. should winetricks add a verb that installs all of vcrun6, vcrun2003, vcrun2005, vcrun2008, and maybe vcrun2010 and encourage users to do that instead of installing the individual libraries?

2 1

Re: Re: Re: added remaining functions, data structures, definitions required by http api to include/
by Juan Lang Nov. 18, 2011

Nov. 18, 2011

Hi Arash, >> I'm also concerned whether this was the product of copy/paste, which >> isn't allowed. Was it? > about that copy/paste stuff, > well I guess we eventually produce an almost identical header file with one > in the SDK > I mean everything in the header file is already exposed to the user and "IS" > part of API > am I not right? I might agree with you, but lawyers might not. As a result, we don't allow copy/paste code in Wine, even in headers. > just one more question if you don't mind! > should I use winsock for socket programming or native linux's? and > for some library I may need (regex for example) is there any restriction or > convection or something like that or I can use any third party lib? Native linux sockets are typically used, unless there's good reason for them not to be. 3rd party libraries are harder to work with. You typically have to choose something which you expect will be installed on every common platform, built appropriate configure checks to determine if the library is present at compile time, make your code fail gracefully if not, and dynamically load the library at runtime. Static linking is also viable, if you expect the library is commonly available, and if the license is compatible: LGPL and BSD are, GPL is not, just to give a few examples. It'd help more if we knew precisely what you're working on, and what you need e.g. regex for. --Juan

1 0

FOSDEM 2012 - CrossDesktop DevRoom Call for Talks
by Pau Garcia i Quiles Nov. 18, 2011

Nov. 18, 2011

Hi, FOSDEM is one of the largest gatherings of Free Software contributors in the world and happens each February in Brussels (Belgium). One of the tracks will be the CrossDesktop DevRoom, which will host Desktop-related talks. We are now inviting proposals for talks about Free/Libre/Open-source Software on the topics of Desktop development, Desktop applications and interoperativity amongst Desktop Environments. This is a unique opportunity to show novel ideas and developments to a wide technical audience. Topics accepted include, but are not limited to: Enlightenment, Gnome, KDE, XFCE, Windows, Mac OS X, general desktop matters, applications that enhance desktops and web (when related to desktop). Talks can be very specific, such as developing mobile applications with Qt Quick; or as general as predictions for the fusion of Desktop and web in 5 years time. Topics that are of interest to the users and developers of all desktop environments are especially welcome. The FOSDEM 2011 schedule might give you some inspiration: http://archive.fosdem.org/2011/schedule/track/crossdesktop_devroom Please include the following information when submitting a proposal: your name, the title of your talk (please be descriptive, as titles will be listed with around 250 from other projects) and a short abstract of one or two paragraphs. The deadline for submissions is December 20th 2011. FOSDEM will be held on the weekend of 4-5 February 2012. Please submit your proposals to: crossdesktop-devroom(a)lists.fosdem.org ( https://lists.fosdem.org/listinfo/crossdesktop-devroom ) -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)

1 0

Re: mshtml: fix MSVC build in htmllocation.c
by Nikolay Sivov Nov. 17, 2011

Nov. 17, 2011

On 11/17/2011 15:18, Thomas Faber wrote: > This removes the use of two Variable Length Arrays. > Instead of filling a local buffer, then allocating a new one using > SysAllocString[Len], the strings are now directly written to the latter > buffer. > Note that the 'len' variable in hunk 2 does not need to count in the > terminating null in this case because SysAllocStringLen automatically > adds one. > - WCHAR buf[url.dwSchemeLength + 1]; > + WCHAR *buf; > + buf = *p = SysAllocStringLen(NULL, url.dwSchemeLength + 1); > memcpy(buf, url.lpszScheme, url.dwSchemeLength * sizeof(WCHAR)); > buf[url.dwSchemeLength] = ':'; > - *p = SysAllocStringLen(buf, url.dwSchemeLength + 1); You don't need 'buf' variable after that.

1 0

Antw.: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.
by André Hentschel Nov. 17, 2011

Nov. 17, 2011

I would love to see such a tool, i could use it for some actctx tests in ntdll Gesendet mit meinem HTC ----- Reply message ----- Von: "Saulius Krasuckas" <saulius2(a)ar.fi.lt> An: "Alexandre Julliard" <julliard(a)winehq.org> Cc: <wine-devel(a)winehq.org> Betreff: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece. Datum: Do., Nov. 17, 2011 18:49 On Thu, 17 Nov 2011, Alexandre Julliard wrote: > > The test requires a PE binary because obviously we can't test PE > protections on Unix binaries. That doesn't mean it doesn't exist. Just > build a crosstest: > > $ wine ntdll_crosstest.exe info.c > info.c:1296: Test failed: mbi.Protect is 0x8, expected 0x4 IIRC, some of tests already craft minimal PE binaries in manual way. So it would be nice to have some tool inside the tree to generate PEs independetly, no? Several years ago I've tried testing GetStdHandle() from within two PE binaries with different header flags set (IMAGE_SUBSYSTEM_WINDOWS_[GC]UI). For a start I have copied some code of manual PE crafting to build PE header. Then there came .text section's order. I realized it's sufficient to write small assembler file, run it through the gas crosscompiler, disasm it and parse the results to have _not only_ binary data for rebuilding PE, but also symbolic one. I wrote some awk-script then to convert .S file into C-function this way. With it it was easy to adjust options for crosscompiling gas/ld tools to get PE with needed structure. But maybe there is point in creating some universal in-tree tool? Or integrate the functionality into winegcc (or else) so as not to depend on a crosscompiling suite but still have readable and easy changeable source. Guys, what do you think? S.

1 0

Re: Re: added remaining functions, data structures, definitions required by http api to include/http
by Juan Lang Nov. 17, 2011

Nov. 17, 2011

> can you be more specific please? Yes: +#ifndef __HTTP_H__ +#define __HTTP_H__ Don't do that, it's already #ifdef protected. +/*#if _WIN32_WINNT >= 0x0501*/ Dead code, just leave it out. +typedef struct _HTTP_REQUEST_V2 +{ + /* TODO : anonymous structure is not supported by C standard */ + /* struct HTTP_REQUEST_V1; */ For one thing, that's what the DUMMYSTRUCTNAME macro is for. For another, by omitting it, you've made the structure binary incompatible with the PSDK one for C code. Clearly that's wrong. I stopped reviewing here, you have many examples of the above error. I'm also concerned whether this was the product of copy/paste, which isn't allowed. Was it? --Juan

1 0

Re: [PATCH 1/1] ws2_32: Selectively bind UDP sockets to interfaces while still allowing broadcast packets (try 2, resend).
by Juan Lang Nov. 17, 2011

Nov. 17, 2011

Hi Erich, + * Bind the given socket exclusively to a specific interface. I know the style around here is to comment minimally, but I didn't find it clear what the behavior of this function is. For one thing, +static int interface_bind( int fd, struct sockaddr *addr ) (snip) + int ret = FALSE; (snip) + ret = TRUE; You're using #defines used with BOOL, so a BOOL return value would be a little clearer IMO. int, in the context of socket functions, often uses 0 => success, -1 => failure. Still, even with that change, + if (in_sock->sin_addr.s_addr == htonl(WS_INADDR_ANY)) + { + /* Not binding to specific interface, use default route */ + goto cleanup; + } + optlen = sizeof(sock_type); + if (getsockopt(fd, SOL_SOCKET, SO_TYPE, &sock_type, &optlen) == -1 + || sock_type != SOCK_DGRAM) + { + /* Not a UDP socket, interface-specific bind is irrelevant. */ + goto cleanup; These two blocks will use the default return value, FALSE, and it wasn't clear to me from the function name or comment that it should return FALSE in this case. Not that doing so is incorrect: just that it isn't obvious that that's the way it should behave. In this case, I feel a comment indicating that the function returns TRUE iff the function bound to a specific device, and that FALSE doesn't necessarily mean failure, is merited. Also, + /* Obtain the size of the IPv4 adapter list and allocate structure memory */ + if (GetAdaptersInfo(NULL, &adap_size) != ERROR_BUFFER_OVERFLOW) Why do all this outside the #ifdef SO_BINDTODEVICE guard? I'd rather you just had a different implementation of the function when SO_BINDTODEVICE isn't present that issues the warning and does nothing else. I'll let Alexandre comment on whether the approach itself is appropriate. Thanks, --Juan

2 1

Re: [PATCH 2/2] mshtml: Added tests of handling ActiveX objects without IQuickActivate interface implemented
by Alexandre Julliard Nov. 17, 2011

Nov. 17, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/tests/activex.c | 133 > ++++++++++++++++++++++++++++++------------ > 1 files changed, 95 insertions(+), 38 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so activex.c && touch activex.ok wine: Unhandled page fault on read access to 0x00000008 at address 0x6a76d2a6 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x6a76d2a6). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6a76d2a6 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010206( R- -- I - -P- ) EAX:01824650 EBX:00000000 ECX:00000008 EDX:00000000 ESI:01824650 EDI:00000000 Stack dump: 0x0032fab0: 01824650 6ad31584 0182459c 018244c8 0x0032fac0: 018244c8 00000000 0032faf8 6a45f2cd 0x0032fad0: 018244c8 00000003 6ad316db 00000000 0x0032fae0: 018244c8 0032fb28 001ab708 01828bd8 0x0032faf0: 0171af60 00000000 0032fb48 6a4b7d29 0x0032fb00: 018244c8 00000000 0032fb28 6a617b0f Backtrace: =>0 0x6a76d2a6 in xul (+0xb2d2a6) (0x0032fac8) 1 0x6a45f2cd in xul (+0x81f2cc) (0x0032faf8) 2 0x6a4b7d29 in xul (+0x877d28) (0x0032fb48) 3 0x6a4b9648 in xul (+0x879647) (0x0032fb98) 4 0x6a4b73db in xul (+0x8773da) (0x0032fbc8) 5 0x555e04e7 NSContainer_Release+0x76(This=0x17978b8) [/home/julliard/wine/wine/dlls/mshtml/nsembed.c:1886] in mshtml (0x0032fbf8) 6 0x55585435 CustomDoc_Release+0x1c4(iface=0x135c8c) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2315] in mshtml (0x0032fc38) 7 0x5557f2e4 HTMLDocument_Release+0x13(iface=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:433] in mshtml (0x0032fc58) 8 0x687657a4 release_doc+0x23(doc=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:1945] in mshtml_test (0x0032fc78) 9 0x6876a445 func_activex+0x18b4() [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:2060] in mshtml_test (0x0032fd58) 10 0x68763202 main+0x3a1(argc=*** Invalid address 0x00000008 *** , argv=*** Invalid address 0x0000000c *** Internal symbol error: unable to access memory location 0xc) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe28) 11 0x687becf5 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fe70) 12 0x6848858c call_process_entry+0xb() in kernel32 (0x0032fe88) 13 0x6848953f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1090] in kernel32 (0x0032fec8) 14 0x68375dd0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 15 0x68378abd call_thread_func+0x7c(entry=0x684894e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 16 0x68375dae call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 17 0x6834dece start_process+0x1d(kernel_start=0x684894e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 18 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x6a76d2a6: call *0x8(%edx) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dinput: Delete the static critical section when unloading the dll.
by Vitaliy Margolen Nov. 17, 2011

Nov. 17, 2011

On 11/16/2011 08:31 AM, Francois Gouget wrote: > --- > > I moved DllMain() to the end of the file so it comes after the variable > declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead. Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them? Vitaliy.

3 3

re: added remaining functions, data structures, definitions required by http api to include/http.h
by Dan Kegel Nov. 17, 2011

Nov. 17, 2011

That's a lot of stuff. What needs it? Also, please avoid trivial whitespace changes.

2 1

Re: added remaining functions, data structures, definitions required by http api to include/http.h
by Frédéric Delanoy Nov. 16, 2011

Nov. 16, 2011

On Wed, Nov 16, 2011 at 14:15, ArasH <arash.cordi(a)gmail.com> wrote: > --- > include/http.h | 1266 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 1251 insertions(+), 15 deletions(-) The patch should show your full name. See http://wiki.winehq.org/SubmittingPatches for more information.

1 0

Re: mshtml: Fixed some htmldoc.c tests on IE9
by Marvin Nov. 16, 2011

Nov. 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15467 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37

2 1

Re: [PATCH 1/1] user32: Prioritize focus for dialog owner on EndDialog (resend).
by Marvin Nov. 16, 2011

Nov. 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15456 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().
by Matteo Bruni Nov. 15, 2011

Nov. 15, 2011

2011/11/15 Henri Verbeet <hverbeet(a)codeweavers.com>: > --- > + UINT end = start_idx + count; > + start_idx += 7; > + memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3)); Isn't that dangerous if count is < 7 (assuming that is a valid value)?

1 0

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Henri Verbeet Nov. 15, 2011

Nov. 15, 2011

On 15 November 2011 00:12, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Tests show that only LPSURFACE and PIXELFORMAT can be set, and LPSURFACE is required > + * for PIXELFORMAT to work */ This may be ok, but note that the test doesn't actually test this. (E.g. does calling SetSurfaceDesc() with the original surface desc work? What about bits not in DDSD_ALL? Etc.) Also, as a general principle, I'd be happier about the ddraw tests if they actually tested all the different interface versions.

2 4

RFH: Solaris users with IPv6
by Juan Lang Nov. 15, 2011

Nov. 15, 2011

Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I have no way to test it myself. If anyone here has some version of Solaris with a machine with IPv6 addresses, even autoconfigured ones, and feels like testing a patch, please let me know. I'll send the patch and a small test program. Thanks, --Juan

2 1

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts
by Henri Verbeet Nov. 15, 2011

Nov. 15, 2011

That's a fair amount of magic constants in there. The ones in is_indic() are probably Script_Devanagari and Script_Malayalam_Numeric, I didn't look at the other two.

2 1

Re: [4/6] msxml3/dom: Properly return node prefix from get_prefix()
by Jacek Caban Nov. 15, 2011

Nov. 15, 2011

Hi Nikolay, On 11/15/11 07:19, Nikolay Sivov wrote: > - if ((ns = xmlGetNsList(This->node->doc, This->node))) > + switch (This->node->type) > { > - if (ns[0]->prefix) *prefix = bstr_from_xmlChar( ns[0]->prefix ); > - xmlFree(ns); > + case XML_ELEMENT_NODE: > + case XML_ATTRIBUTE_NODE: > + { > + xmlNsPtr ns = This->node->ns; > + if (ns&& ns->prefix) > + *prefix = bstr_from_xmlChar(ns->prefix); > + break; > } > + default: > + FIXME("unsupported type %d\n", This->node->type); > + }; The idea behind node inheritance rewrite was to avoid such switches. If other node types should be handled differently, they simply shouldn't use node_get_prefix or the differences should be moved to child objects. Jacek

2 1

Re: msvcrt: Don't hold FILE critical section in some functions
by Alexandre Julliard Nov. 15, 2011

Nov. 15, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) > */ > int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) > { > - MSVCRT__lock_file(file); > - > /* Flush output buffer */ > if(file->_bufsiz == 0 && !(file->_flag & MSVCRT__IONBF)) { > msvcrt_alloc_buffer(file); > } > if(!(file->_flag & MSVCRT__IOWRT)) { > - if(file->_flag & MSVCRT__IORW) { > + if(file->_flag & MSVCRT__IORW) > file->_flag |= MSVCRT__IOWRT; > - } else { > - MSVCRT__unlock_file(file); > + else That doesn't look safe. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: wininet: Give a name to the critical sections, make them static and delete them when unloading the dll.
by Marvin Nov. 15, 2011

Nov. 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15430 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [4/4] ddraw: Size handling fixes for IDirect3DDevice::GetDesc
by Henri Verbeet Nov. 15, 2011

Nov. 15, 2011

On 15 November 2011 00:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!HWDesc) > + { > + WARN("HWDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > + return DDERR_INVALIDPARAMS; > + } > + else if(!check_d3ddevicedesc_size(HWDesc->dwSize)) > + { > + WARN("HWDesc->dwSize is %u, returning DDERR_INVALIDPARAMS.\n", HWDesc->dwSize); > + return DDERR_INVALIDPARAMS; > + } > + else if (!HelDesc) > + { > + WARN("HelDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > + return DDERR_INVALIDPARAMS; > + } > + else if(!check_d3ddevicedesc_size(HelDesc->dwSize)) > + { > + WARN("HelDesc->dwSize is %u, returning DDERR_INVALIDPARAMS.\n", HelDesc->dwSize); > + return DDERR_INVALIDPARAMS; > + } The "else" is redundant here. Please use consistent formatting. > + hw_caps.dwSize = sizeof(hel_caps) + 1; Strictly speaking that should be "sizeof(hw_caps) + 1". > + case 172: /* DirectX 3, IDirect3DDevice1 */ > + ok(hw_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hw_caps.dwMaxTextureRepeat); > + ok(hel_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hel_caps.dwMaxTextureRepeat); > + /* drop through */ > + case 204: /* DirectX 5, IDirect3DDevice2 */ > + ok(hw_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hw_caps.dwMaxTextureRepeat); > + ok(hel_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hel_caps.dwMaxTextureRepeat); This doesn't make a lot of sense, both cases are the same.

1 0

Re: wined3d: Disable WINED3DFMT_B8G8R8_UNORM.
by Stefan Dösinger Nov. 15, 2011

Nov. 15, 2011

On Tuesday 15 November 2011 14:21:09 Matteo Bruni wrote: > + case WINED3DFMT_B8G8R8_UNORM: /* Usable in <=dx7 but not > enumerated in any case */ > + TRACE_(d3d_caps)("[FAILED] - Not enumerated on Windows\n"); > + return FALSE; The comment "Usable in <=dx7" is misleading. If I remember correctly your attempts at writing a test showed that systemmem surfaces can be created, but not video memory surfaces. I wouldn't be surprised if d3d8/9 also allow systemmem or scratch B8G8R8 surfaces. You can also remove the special handling for D3DFMT_R8G8B8 from d3d8/9's CheckDeviceFormat handling implementation now that wined3d doesn't report it as supported.

1 0

Re: [PATCH 1/2] ntdll: windows refuses to load an image, if sections overlap the header size as given in the SizeOfHeaders field (resend)
by Alexandre Julliard Nov. 15, 2011

Nov. 15, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/kernel32/tests/loader.c | 79 ++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/virtual.c | 5 +++ > 2 files changed, 84 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c > index 4d420ea..bcef492 100644 > --- a/dlls/kernel32/tests/loader.c > +++ b/dlls/kernel32/tests/loader.c > @@ -692,9 +692,88 @@ static void test_section_access(void) > } > } > > +static void test_section_mapping(void) > +{ > + static const char filler[0x2000]; > + static const char section_data[] = "section data 1234567890"; > + DWORD total, written; > + HANDLE hfile; > + HMODULE hlib; > + SYSTEM_INFO si; > + char temp_path[MAX_PATH]; > + char dll_name[MAX_PATH]; > + BOOL ret; > + > + GetSystemInfo(&si); > + > + /* prevent displaying of the "Unable to load this DLL" message box */ > + SetErrorMode(SEM_FAILCRITICALERRORS); > + > + GetTempPath(MAX_PATH, temp_path); > + > + GetTempFileName(temp_path, "ldr", 0, dll_name); Please merge that test case into the existing loader tests instead of adding a new function to do the same thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 11/12] mshtml: Added more navigation tests
by Marvin Nov. 15, 2011

Nov. 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15423 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2692: Test failed: unexpected command 6058 htmldoc.c:4725: Test failed: expected Invoke_AMBIENT_PALETTE htmldoc.c:4726: Test failed: expected GetOptionKeyPath htmldoc.c:2702: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2789: Test failed: unexpected command 143 htmldoc.c:1704: Test failed: unexpected call SetStatusText === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2692: Test failed: unexpected command 6058 htmldoc.c:4725: Test failed: expected Invoke_AMBIENT_PALETTE htmldoc.c:4726: Test failed: expected GetOptionKeyPath htmldoc.c:2702: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2789: Test failed: unexpected command 143 htmldoc.c:1704: Test failed: unexpected call SetStatusText

2 1

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try3)
by Marvin Nov. 15, 2011

Nov. 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15426 Your paranoid android. === WVISTAADM (32 bit userenv) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try2)
by Alexandre Julliard Nov. 15, 2011

Nov. 15, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > +static void set_wow64_environment(WCHAR **env) > +{ > + static const WCHAR archW[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','C','T','U','R','E',0}; > + static const WCHAR arch6432W[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','W','6','4','3','2',0}; This stuff needs to be done depending on the 32/64 architecture of the child process, so it probably shouldn't be done here. The variables will be reset on every process startup anyway. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] urlmon: Improve parsing of SCHEME_MK URIs
by Jacek Caban Nov. 15, 2011

Nov. 15, 2011

Hi Andrew, On 11/14/11 21:12, Andrew Eikum wrote: > --- > dlls/urlmon/tests/uri.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++ > dlls/urlmon/uri.c | 15 +++++++-- > 2 files changed, 93 insertions(+), 3 deletions(-) The patch looks good to me, but could you please add a simpler test using CreateUri (using uri_tests array) as follow up. Thanks, Jacek

1 0

Re: ws2_32: Fix handling of NULL and empty hostname in getaddrinfo/GetAddrInfoW.
by Marvin Nov. 15, 2011

Nov. 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15418 Your paranoid android. === WNT4WSSP6 (32 bit sock) === Timeout === W2KPROSP4 (32 bit sock) === Timeout

1 0