November 2011 - Wine-Devel - list.winehq.org

Re: mscoree: Implement ICorDebug CreateProcess (try 2)
by Alexandre Julliard Nov. 9, 2011

Nov. 9, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Move DuplicateHandle to Create_Process. > Added Makefile.in (missing from first patch) > > Changelog: > mscoree: Implement ICorDebug CreateProcess You should put everything in cordebug.c, there's no need to have a separate file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] ddraw/tests: Add a test for YV12 partial block locks and lock offsets
by Marvin Nov. 9, 2011

Nov. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15324 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [4/4] ddraw: Set correct HEL and HAL color models
by Marvin Nov. 9, 2011

Nov. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15327 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Marvin Nov. 9, 2011

Nov. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15326 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Adopt a patch?
by Michael Ost Nov. 8, 2011

Nov. 8, 2011

I have a patch for a bug that I won't be able to shepherd through the patch submission process for some time. The bug is that GetFileVersionInfoSize doesn't work for files with path names longer than 128 characters. The patch includes an untried unit test. And I've confirmed the behavior in Windows Vista. We use an older version of Wine, and my boss won't let me take the time right now to rework the patch for the newest Wine sources. If someone wants to they can take this patch, tweak it for the new wine, update it to wine-patch requirements and push it through the system. Otherwise I'll submit as soon as I can. Cheers, Michael Ost

2 1

Re: apphelp: add a stub for ApphelpCheckShellObject
by Dmitry Timoshkov Nov. 8, 2011

Nov. 8, 2011

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI ApphelpCheckShellObject(REFCLSID ObjectCLSID, BOOL ShimIfNecessary, ULONGLONG *pullFlags) > +{ > + FIXME("stub: %s %p\n", debugstr_guid(ObjectCLSID), pullFlags ); > + return TRUE; > +} It's a common convention in Wine to avoid hungarian notation by all means. In this case naming variables something like 'clsid, shim, flags' woud be better. -- Dmitry.

1 0

Fwd: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon
by David Adam Nov. 8, 2011

Nov. 8, 2011

Hello, any problem with this patch http://source.winehq.org/patches/data/80433 and this one http://source.winehq.org/patches/data/80434 Thanks in advance David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/10/30 Subject: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon To: wine-patches <wine-patches(a)winehq.org> Fix a possible crash when calling D3DXCreateMeshFVF. A+ David

3 2

Re: [10/11] ddraw/tests: Add assorted D3D3 DrawPrimitive/visual tests.
by Stefan Dösinger Nov. 8, 2011

Nov. 8, 2011

On Tuesday 08 November 2011 01:14:22 Octavian Voicu wrote: > The idea behind using triangles was to fit everything in one screen so > I could debug it visually very easily. I'm thinking I can still have > that if I draw full-screen quads in a loop, like you suggest, then > blit one small rectangle to the primary surface, in different > positions for each test. I don't think that's necessary, I found those one-quad screens easier to debug than multi-quads, although that may be a matter of taste. > I think > we should cover special error cases if there are any (that is, if > D3DERR_INVALIDVERTEXTYPE is not returned for D3DVT_ constants). Well, you can't test them. D3DVT_LVERTEX is 2, and D3DFVF_XYZ is 2. The number 2 doesn't have any tags attached, so what you'd be testing is how drawPrimitive responds to D3DFVF_RESERVED0, not what it does with D3DVT_* enums. The statement in the SDK doesn't make sense with that in mind. > About the ddraw/visual tests: I think we need one structure for each > of d3d, d3d2, d3d3, d3d7, where to have most of the things we store > globally or in local vars now, and make the create/release functions > work with that. Yes, I was about to write something like that as a response to the cleanup patches. PS: You forgot to CC wine-devel, I assume this was by accident so I've added it to the reply again. You may want to resend your original mail to wine- devel.

2 2

Re: [01/11] ddraw/tests: Fix a couple of copy-paste typos in test messages.
by Stefan Dösinger Nov. 8, 2011

Nov. 8, 2011

This patch is OK, the others need some discussion and work.

1 0

Re: [3/3] ddraw/tests: Add a partial block lock test
by Alexandre Julliard Nov. 8, 2011

Nov. 8, 2011

Stefan Dösinger <stefan(a)codeweavers.com> writes: > @@ -4,7 +4,7 @@ > * Copyright (C) 2005 Antoine Chavasse (a.chavasse(a)gmail.com) > * Copyright (C) 2005 Christian Costa > * Copyright 2005 Ivan Leo Puoti > - * Copyright (C) 2007 Stefan Dösinger > + * Copyright (C) 2007-2011 Stefan Dösinger for CodeWeavers Adding a range of years in a copyright notice is usually discouraged, because it's only valid if you have actually made significant changes every year, which doesn't seem to be the case here. -- Alexandre Julliard julliard(a)winehq.org

2 2