November 2011 - Wine-Devel - list.winehq.org

Re: user32/tests: Drop superfluous function pointer casts.
by Marvin Nov. 21, 2011

Nov. 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15553 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

2 1

re: ID3DXEffect test on win
by Dan Kegel Nov. 20, 2011

Nov. 20, 2011

Hi Rico, I compiled the 32 bit wine tests on win7 64 bit using cygwin, and sure enough, there are 40 test failures there. You should probably avoid doing direct equality tests on floats; see e.g. compare() at line 47 of d3dx9_36/tests/mesh.c. You may have to tweak the slop value. (Google floating point comparison if you want the gory details of how tools like google test and boost's test_tools do it right.) effect.c:894: Test failed: 0 - f3: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 0 - f3: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 0 - f3: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 0 - f3: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 0 - f4: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 0 - f4: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 0 - f4: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 0 - f4: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 0 - f4: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 0 - f4: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 0 - f4: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 0 - f4: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 0 - f31: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 0 - f31: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1321: Test failed: 0 - f31: GetMatrix fvalue[8] failed, got 0.203922, expected 0.203922 effect.c:1438: Test failed: 0 - f31: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 0 - f41: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 0 - f41: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 0 - f41: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 0 - f41: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1321: Test failed: 0 - f41: GetMatrix fvalue[8] failed, got 0.203922, expected 0.203922 effect.c:1321: Test failed: 0 - f41: GetMatrix fvalue[12] failed, got 0.121569, expected 0.121569 effect.c:1438: Test failed: 0 - f41: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1438: Test failed: 0 - f41: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f3: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f3min: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3min: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3min: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3min: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f3max: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3max: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3max: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3max: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f4: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f4min: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4min: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4min: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4min: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4min: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4min: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4min: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4min: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f4max: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4max: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4max: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4max: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4max: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4max: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4max: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4max: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect: 1222410 tests executed (0 marked as todo, 60 failures), 0 skipped.

2 1

Re: [3/4] winemaker: Be less picky when detecting the target type (try 2)
by Vitaliy Margolen Nov. 20, 2011

Nov. 20, 2011

On 11/19/2011 11:42 AM, André Hentschel wrote: > this catches more than one 0 after the space and possible 0s after the x > + if (/[[:space:]]0+x0*101$/) { For more then one you should use "+" not "*". "*" means any number, including 0. Vitaliy

2 1

Re: added moethod stub for HttpPrepareUrl in dlls/httpapi/httpapi_main.c
by Bruno Jesus Nov. 20, 2011

Nov. 20, 2011

You have to use your full name (as advised before). See http://wiki.winehq.org/SubmittingPatches for more information. Also, gmail is breaking your patch, attach the patch file instead of pasting it to the email body. Best wishes, Bruno On Sat, Nov 19, 2011 at 09:24, ArasH <arash.cordi(a)gmail.com> wrote: > --- > dlls/httpapi/httpapi_main.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c > index 3375cb6..c5c8cda 100644 > --- a/dlls/httpapi/httpapi_main.c > +++ b/dlls/httpapi/httpapi_main.c > @@ -85,6 +85,27 @@ ULONG WINAPI HttpTerminate( ULONG flags, PVOID reserved ) > } > > /*********************************************************************** > + * HttpPrepareUrl (HTTPAPI.@) > + * parses, analyzes, and normalizes a non-normalized Unicode or punycode URL > + * so it is safe and valid to use in other HTTP functions. > + * > + * PARAMS > + * reserved [IO] reserved, must be NULL > + * flags [ I] reserved. must be zero > + * url [ I] a pointer to a string that represents the > non-normalized URL > + * prepared_url [ O] on success, a pointer to a string > representing the normalized URL. > + * > + * RETURNS > + * ERROR_SUCCESS if function succeeds, or error code if function fails > + * > + */ > +ULONG WINAPI HttpPrepareUrl( PVOID reserved, ULONG flags, PCWSTR url, > PWSTR *prepared_url) > +{ > + FIXME( "(%p, 0x%x, %p): stub!\n", reserved, flags, url ); > + return ERROR_SUCCESS; > +} > + > +/*********************************************************************** > * HttpDeleteServiceConfiguration (HTTPAPI.@) > * > * Remove configuration record from HTTP Server API configuration store > -- > 1.6.2.2 > > >

1 0

ID3DXEffect test on win
by Rico Schüller Nov. 19, 2011

Nov. 19, 2011

Hi, I've written some tests for the ID3DXEffect interface. The test is attached as source. What I'd like to know is if there are some rounding issues on some win versions. The test needs d3dx9_36.dll. I tried it on wine with native d3dx9_36.dll and got around 60 rounding errors (only on the combination SetInt() and GetValue/FloatArray/Vector/Matrix/MatrixTranspose). It would be nice if there is anyone interested in running those and would report the result. I'm looking for results on XP/W7/Vista. If you don't have a cross compiler and like to try the test, I could send the executable. Cheers Rico

1 0

Re: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.
by Alexandre Julliard Nov. 18, 2011

Nov. 18, 2011

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > The tests clearly show that this commit is wrong. If there is an application > or a test case which fails because of this, it would be helpful to at least > mention it. It fixes the test for .bss protection, in ntdll:info.c. -- Alexandre Julliard julliard(a)winehq.org

4 8

Translations strangeness
by Luca Bennati Nov. 18, 2011

Nov. 18, 2011

Hi all, I would like to clarify some doubts I have about Wine translations and its po/rc files: 1- Are the following highlighted strings errors from the script converting from rc to po or due to malformatted po files (seems not to recognize msgctx lines)? http://source.winehq.org/transl/resource.php?branch=master&lang=009%3A01&re… http://source.winehq.org/transl/resource.php?branch=master&lang=009%3A01&re… 2- Are the following highlighted strings (and similar) translatable or they were wrongly recognized by script? http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… 3- How is it that the following highlighted strings are translated in po files but seems not to be taken in consideration from script? http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… None here) I took the italian translations as example because I'm its actual volunteer maintainer and I know them. In summary, is it our (the translators) or my fault or is the script lacking? Nonetheless, how can we solve those issues?

2 1

Re: [5/5]usp10: Itemize numbers outside of the basic ascii set in a seperate script.
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15519 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:400: Test failed: 0:Wrong fRTL(1) usp10.c:400: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:400: Test failed: 0:Wrong BidiLevel(1) usp10.c:431: Test failed: 0:Wrong fRTL(1) usp10.c:431: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:431: Test failed: 0:Wrong BidiLevel(1) usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === W2KPROSP4 (32 bit usp10) === usp10.c:400: Test failed: 0:Wrong fRTL(1) usp10.c:400: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:400: Test failed: 0:Wrong BidiLevel(1) usp10.c:431: Test failed: 0:Wrong fRTL(1) usp10.c:431: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:431: Test failed: 0:Wrong BidiLevel(1) usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === WXPPROSP3 (32 bit usp10) === usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === W2K3R2SESP2 (32 bit usp10) === usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos

1 0

Re: [4/5]usp10: Windows breaks punctuation into 2 different script types.
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15518 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:393: Test failed: 0:Wrong fRTL(1) usp10.c:393: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:393: Test failed: 0:Wrong BidiLevel(1) usp10.c:423: Test failed: 0:Wrong fRTL(1) usp10.c:423: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:423: Test failed: 0:Wrong BidiLevel(1) usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === W2KPROSP4 (32 bit usp10) === usp10.c:393: Test failed: 0:Wrong fRTL(1) usp10.c:393: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:393: Test failed: 0:Wrong BidiLevel(1) usp10.c:423: Test failed: 0:Wrong fRTL(1) usp10.c:423: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:423: Test failed: 0:Wrong BidiLevel(1) usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === WXPPROSP3 (32 bit usp10) === usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === W2K3R2SESP2 (32 bit usp10) === usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel

1 0

Re: [3/5]usp10: handle Combining Diacritical Marks
by Marvin Nov. 18, 2011

Nov. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15517 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:384: Test failed: 0:Wrong fRTL(1) usp10.c:384: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:384: Test failed: 0:Wrong BidiLevel(1) usp10.c:413: Test failed: 0:Wrong fRTL(1) usp10.c:413: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:413: Test failed: 0:Wrong BidiLevel(1) === W2KPROSP4 (32 bit usp10) === usp10.c:384: Test failed: 0:Wrong fRTL(1) usp10.c:384: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:384: Test failed: 0:Wrong BidiLevel(1) usp10.c:413: Test failed: 0:Wrong fRTL(1) usp10.c:413: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:413: Test failed: 0:Wrong BidiLevel(1)

1 0