December 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] wined3d: Introduce a helper function for checking colors against a color key.
by Stefan Dösinger Dec. 9, 2011

Dec. 9, 2011

The patch is OK, this mail is just an answer to Henri's comment. 2011/12/8 Henri Verbeet <hverbeet(a)codeweavers.com> > +static BOOL color_in_range(const struct wined3d_color_key *color_key, > DWORD color) > +{ > + /* FIXME: Is this really how color keys are supposed to work? I think > it > + * makes more sense to compare the individual channels. */ > + return color >= color_key->color_space_low_value > + && color <= color_key->color_space_high_value; > +} > I tried to test this a while ago, but no GPU supported range color keys for blitting, and the HEL doesn't support that either. At least one of my GPUs seems to support this for YUV overlays(DDCKEYCAPS_SRCOVERLAYCLRSPACEYUV), but not RGB overlays or YUV blits. That could satisfy our curiosity, but an automated test is not possible.

1 0

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass.
by Marvin Dec. 9, 2011

Dec. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15856 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass.
by Marvin Dec. 9, 2011

Dec. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15856 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [1/2] user32: Add some SetFocus message tests.
by Marvin Dec. 9, 2011

Dec. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15855 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [PATCH] Fixed a couple of warnings for 64bit targets
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15850 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

how to debug wine
by winepp Dec. 8, 2011

Dec. 8, 2011

Dear sir: I downloaded the source of wine1.3.29.I want to know how does it work,so I must debug the source of wine! Can you tell me how to debug wine? Shall I need to install any other tools? Thank you very much! -- View this message in context: http://wine.1045685.n5.nabble.com/how-to-debug-wine-tp5054956p5054956.html Sent from the Wine - Devel mailing list archive at Nabble.com.

2 1

Re: usp10: add Myanmar script
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15845 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:424: Test failed: 0:Wrong fRTL(1) usp10.c:424: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:424: Test failed: 0:Wrong BidiLevel(1) usp10.c:456: Test failed: 0:Wrong fRTL(1) usp10.c:456: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:456: Test failed: 0:Wrong BidiLevel(1) === W2KPROSP4 (32 bit usp10) === usp10.c:424: Test failed: 0:Wrong fRTL(1) usp10.c:424: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:424: Test failed: 0:Wrong BidiLevel(1) usp10.c:456: Test failed: 0:Wrong fRTL(1) usp10.c:456: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:456: Test failed: 0:Wrong BidiLevel(1)

1 0

Re: [5/6] gdi32: Substitute glyph for vertical font only. (try 2)
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15835 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [4/6] gdi32: Add vertical fonts to font list. (try 2)
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15834 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [3/6] gdi32: Don't remove leading '@' from face name. (try 2)
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15833 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [2/6] gdi32: Don't use preferred family. (try 2)
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15832 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [1/6] gdi32/tests: Add tests for vertical font. (try 2)
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15831 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: Antw.: Remove obsolete and unused cmdlgtst.
by Dmitry Timoshkov Dec. 8, 2011

Dec. 8, 2011

"André Hentschel" <nerv(a)dawncrow.de> wrote: > Yes, i just recently modified it to test a bug, please don't remove it You can always get through git when needed it. Please avoid reposting huge messages without any purpose, strip the content you are not going to comment on. -- Dmitry.

3 2

Re: [6/6] gdi32: Add a helper function to convert a string from A to W.
by Dmitry Timoshkov Dec. 8, 2011

Dec. 8, 2011

Kusanagi Kouichi <slash(a)ac.auone-net.jp> wrote: > +static WCHAR *towstr(const UINT cp, const char * const str) > +{ You are overusing 'const' modifiers. -- Dmitry.

1 0

Re: [1/6] gdi32/tests: Add tests for vertical font.
by Dmitry Timoshkov Dec. 8, 2011

Dec. 8, 2011

Kusanagi Kouichi <slash(a)ac.auone-net.jp> wrote: > @@ -4099,4 +4186,5 @@ START_TEST(font) > * is properly implemented. > */ > test_CreateScalableFontResource(); > + test_vertical_font(); > } Did you read the comment above the added line? -- Dmitry.

1 0

Re: [5/6] gdi32: Substitute glyph for vertical font only.
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15830 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [4/6] gdi32: Add vertical fonts to list.
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15829 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [3/6] gdi32: Don't remove leading '@' from face name.
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15828 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [2/6] gdi32: Don't use preferred family.
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15827 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [1/6] gdi32/tests: Add tests for vertical font.
by Marvin Dec. 8, 2011

Dec. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15826 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [PATCH 3/3] ddraw/tests: Extend the CreateSurface(NULL test), use own function
by Marvin Dec. 7, 2011

Dec. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15825 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:4626: Test failed: SetSurfaceDesc failed, hr 0x80070057. dsurface.c:4630: Test failed: SetSurfaceDesc failed, hr 0x80070057. === W7PRO (32 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E584 === W7PROX64 (32 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E584 === TEST64_W7SP1 (32 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E584 === W7PROX64 (64 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. Timeout

1 0

Re: [PATCH 2/3] ddraw: SetSurfaceDesc can set width, height and pitch under certain conditions
by Marvin Dec. 7, 2011

Dec. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15824 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:4628: Test failed: SetSurfaceDesc failed, hr 0x80070057. dsurface.c:4632: Test failed: SetSurfaceDesc failed, hr 0x80070057. === W7PRO (32 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E5E4 === W7PROX64 (32 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E5E4 === TEST64_W7SP1 (32 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E5E4 === W7PROX64 (64 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. Timeout

1 0

Re: [PATCH 1/3] wininet: Use test.winehq.org instead of crossover.codeweavers.com in test_async_HttpSendRequestEx
by Marvin Dec. 7, 2011

Dec. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15809 Your paranoid android. === WXPPROSP3 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12002 === WVISTAADM (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W2K8SE (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PROX64 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === TEST64_W7SP1 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PROX64 (64 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set

2 1

Re: [PATCH 3/3] wininet: Added more connection failure tests
by Marvin Dec. 7, 2011

Dec. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15810 Your paranoid android. === W2K3R2SESP2 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === WVISTAADM (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W2K8SE (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PROX64 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set

1 0

Re: [PATCH 5/6] jscript: Use bytecode for post-increment expression
by Marvin Dec. 7, 2011

Dec. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15795 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: mshtml: Don't use WINAPI for assembly functions to avoid linker warnings on mingw
by Francois Gouget Dec. 7, 2011

Dec. 7, 2011

> #ifdef __i386__ > > #define DEFINE_WRAPPER_FUNC(n, off, x) \ > HRESULT wrapper_func_##n(IUnknown*); \ [...] > #elif defined(__x86_64__) > > #define DEFINE_WRAPPER_FUNC(n, x, off) \ > HRESULT WINAPI wrapper_func_##n(IUnknown*); \ [...] > #else > > #define DEFINE_WRAPPER_FUNC(n, x, off) \ > static HRESULT WINAPI wrapper_func_##n(IUnknown *iface) { \ [...] Is it normal that these functions are still marked as WINAPI in the 64bit and other platform cases? Also, is there a reason not to mark these functions as static in the Intel cases? Because they are coded in assembly? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: riched20: fix memory leak
by Alexandre Julliard Dec. 7, 2011

Dec. 7, 2011

Pierre Schweitzer <pierre(a)reactos.org> writes: > @@ -102,6 +102,7 @@ ME_UndoItem *ME_AddUndoItem(ME_TextEditor *editor, ME_DIType type, const ME_Disp > } > default: > assert(0 == "AddUndoItem, unsupported item type"); > + ME_DestroyDisplayItem(pItem); > return NULL; It's not useful to free memory in unreachable code paths. -- Alexandre Julliard julliard(a)winehq.org

1 0

dosdevices/c not present.. how is it created?
by Roger Cruz Dec. 7, 2011

Dec. 7, 2011

I'm getting the following error when running Wine. err:process:init_windows_dirs directory L"C:\\windows" could not be created, error 2 err:process:init_windows_dirs directory L"C:\\windows\\system32" could not be created, error 3 Using the debugger, I think I found where the problem is: 2140 int fd = open( unix_name, O_RDONLY | O_DIRECTORY ); (gdb) p unix_name $25 = 0x4040b2e8 "/data/winehome/dosdevices/c:" (gdb) n 2141 if (fd != -1) (gdb) p fd $26 = -1 (gdb) where #0 find_file_in_dir (unix_name=0x4040b2e8 "/data/winehome/dosdevices/c:", pos=29, name=0x4040b2c6, length=7, check_case=0, is_win_dir=0x0) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2141 #1 0x80236cf4 in lookup_unix_name (name=0x4040b2c6, name_len=0, buffer=0xbebc45e4, unix_len=295, pos=28, disposition=2, check_case=0 '\0') at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2759 #2 0x80237ad4 in wine_nt_to_unix_file_name (nameW=0xbebc48f8, unix_name_ret=0xbebc4844, disposition=2, check_case=0 '\0') at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2981 #3 0x80237004 in nt_to_unix_file_name_attr (attr=0xbebc4900, unix_name_ret=0xbebc4844, disposition=2) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2821 #4 0x8023b744 in FILE_CreateFile (handle=0xbebc48ec, access=2147483648, attr=0xbebc4900, io=0xbebc48f0, alloc_size=0x0, attributes=128, sharing=1, disposition=2, options=33, ea_buffer=0x0, ea_length=0) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/file.c:125 #5 0x8023bd40 in NtCreateFile (handle=0xbebc48ec, access=2147483648, attr=0xbebc4900, io=0xbebc48f0, alloc_size=0x0, attributes=128, sharing=1, disposition=2, options=33, ea_buffer=0x0, ea_length=0) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/file.c:271 #6 0x8045d210 in ?? () export WINEPREFIX=/data/winehome When I look in my $WINEPREFIX directory, I can see that the c: directory is not there # ls /data/winehome system.reg dosdevices drive_c user.reg # ls /data/winehome/dosdevices # How does that c: directory get created and by whom? I have deleted the $WINEPREFIX several times already to no avail. Thanks Roger R. Cruz # ls /data/winehome system.reg dosdevices drive_c user.reg # ls /data/winehome/dosdevices #

2 2

Re: cmd: Use FormatMessage() for better internationalization support.
by Frédéric Delanoy Dec. 6, 2011

Dec. 6, 2011

On Tue, Dec 6, 2011 at 17:40, Francois Gouget <fgouget(a)free.fr> wrote: > This makes it possible to reorder the format string placeholders in message translations. > Also add a WCMD_format_string() function to mirror the WCMD_output*() ones and so all resources can use the same formatting style. > This also simplifies the padding code for the 'dir /w' command. > + static const WCHAR empty[] = {'\0'}; There's already a suitable nullW string available

1 0

Re: [2/2] msi/tests: Try harder to remove a shortcut file.
by Marvin Dec. 6, 2011

Dec. 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15780 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5994: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/7] msvcrt: Added _get_current_locale impementation
by Piotr Caban Dec. 6, 2011

Dec. 6, 2011

This patches are broken, please ignore them. I'll need to implement locale reference counters inside msvcrt first.

1 0

Updated Clang static analysis results / Valgrind update
by Austin English Dec. 5, 2011

Dec. 5, 2011

Web space usage was getting a bit high, so I've uploaded a tarball to a file download service: http://www.sendspace.com/file/5hot36 austin(a)aw21 ~ $ sha1sum scan-build-2011-07-02.tar.bz2 ac3cb3920ef97641fff1f5376f8136cef01f15bf scan-build-2011-07-02.tar.bz2 to use, just extract and open in your favorite browser: $ firefox index.html this was run against Clang from svn: clang version 3.0 (trunk 134320) Please send me any false positives that you'd like me to report upstream. Cheers, Austin P.S. For those of you wanting Valgrind results, I'm currently hitting a nasty Valgrind bug, waiting on upstream to fix: https://bugs.kde.org/show_bug.cgi?id=275673 (Thanks to Andrew N for finding the faulty commit)

4 7

Re: wined3d: recognize Nvidia 540M
by Henri Verbeet Dec. 5, 2011

Dec. 5, 2011

On 5 December 2011 21:43, Austin English <austinenglish(a)gmail.com> wrote: > {"GTS 450", CARD_NVIDIA_GEFORCE_GTS450}, /* Geforce 400 - midend low */ > + {"GT 540M", CARD_NVIDIA_GEFORCE_GT540M}, /* Geforce 500 - midend mobile */ > {"GT 440", CARD_NVIDIA_GEFORCE_GT440}, /* Geforce 400 - lowend */ The tables are sorted roughly by generation.

1 0

Re: [PATCH] gdi32: Check get_dc_ptr result (Coverity)
by Alexandre Julliard Dec. 5, 2011

Dec. 5, 2011

Marcus Meissner <meissner(a)suse.de> writes: > Checked 199 out of 204 times, so do it here too. > CID 5484 It cannot fail inside driver functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] jscript: Use bytecode for invalid assignments
by Marvin Dec. 5, 2011

Dec. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15759 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Use bytecode for assignment to identifier
by Marvin Dec. 5, 2011

Dec. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15758 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3] ddraw/tests: Update a copyright line
by Marvin Dec. 4, 2011

Dec. 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15757 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: dinput: Clarify a translatable string
by Vitaliy Margolen Dec. 4, 2011

Dec. 4, 2011

On 12/04/2011 01:33 AM, Frédéric Delanoy wrote: > me> Could you explain what that "Sort Assigned" means? > author> I was planning on sorting the button/action mappings putting the > ones which already have an assigned mapping first, and then all the > others. > --- > + AUTOCHECKBOX "Sort Assigned Mappings", IDC_CHECKBOXSORT, 120, 215, 90, 8 A better way of saying this would be "Show assigned first". Vitaliy.

3 3

Re: user32: Avoid crashing if we can't alloc text buffer
by Nikolay Sivov Dec. 3, 2011

Dec. 3, 2011

On 12/3/2011 04:35, Bruno Jesus wrote: > If LocalLock fails the buffer is not allocated and get_text_length, which is used in several different places, will make wine crash. LocalLock doesn't allocate anything. You need to figure out why buffer is not allocated at this point.

2 1

Re: [PATCH] dsound: Validate format in primary buffer's SetFormat()
by Marvin Dec. 2, 2011

Dec. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15748 Your paranoid android. === WVISTAADM (32 bit dsound) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetCaps (try 4)
by Alexandre Julliard Dec. 2, 2011

Dec. 2, 2011

stefan(a)codeweavers.com writes: > +static inline BOOL check_d3ddevicedesc_size(DWORD size) > +{ > + if (size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 */) return TRUE; > + return FALSE; > +} You should use something like FIELD_OFFSET instead of these magic constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Print error messages on stderr, not on stdout. (try3)
by Frédéric Delanoy Dec. 2, 2011

Dec. 2, 2011

On Fri, Dec 2, 2011 at 10:07, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > I meant to resend this one as [2/2] in my previous series but forgot. > With the resynchronization points we can now handle the fixed output > correctly in the tests this time. > > programs/cmd/builtins.c | 20 ++++++++++---------- > programs/cmd/tests/test_builtins.cmd | 1 - > programs/cmd/tests/test_builtins.cmd.exp | 7 +++---- > 3 files changed, 13 insertions(+), 15 deletions(-) Hi François. Would you mind updating the http://wiki.winehq.org/CmdConformanceTests page with your synchronization stuff? I'm not quite sure what/how it does exactly. There is now a discrepancy between wine output, and testrunner output, e.g. echo ------ eol option for /f "eol=@" %%i in (" ad") do echo %%i echo bar gave ------ eol option Syntax error bar but not gives ------ eol option bar Shouldn't cmd output always give the same as test runner output (which is supposed to run cmd on the input file (test_builtins.cmd), albeit with some preprocessing)? Frédéric

2 5

Re: [PATCH 3/3] user32: If a dialog has no tab-accessible controls, set focus to first control (with tests)
by Marvin Dec. 2, 2011

Dec. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15740 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] winecfg: Bump NT 3.51 to Service Pack 5
by Vitaliy Margolen Dec. 2, 2011

Dec. 2, 2011

On 12/01/2011 12:15 PM, André Hentschel wrote: > --- > - { "nt351", "Windows NT 3.5", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 2", 0, 0, "WinNT"}, > + { "nt351", "Windows NT 3.51", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 5", 5, 0, "WinNT"}, You need to do the same in ntdll/version.c Vitaliy.

1 0

Re: shell32/tests: Initialize all fields of SHFILEOPSTRUCT variables (Coverity)
by Marvin Dec. 2, 2011

Dec. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15738 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:1011: Test failed: Expected aborted operations shlfileop.c:2214: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin Dec. 1, 2011

Dec. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin Dec. 1, 2011

Dec. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] kernel32: Add a bunch of VirtualProtect tests on a memory-mapped file. Resend.
by Alexandre Julliard Dec. 1, 2011

Dec. 1, 2011

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/virtual.c | 187 +++++++++++++++++++++++++++++++++------- > 1 files changed, 154 insertions(+), 33 deletions(-) That's a good start, but it would be interesting to try this with various combinations of CreateFileMapping/MapViewOfFile protections, as I expect that the mapping protections would influence what you can then do in VirtualProtect. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test
by Henri Verbeet Dec. 1, 2011

Dec. 1, 2011

On 1 December 2011 11:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > An IDirect3DDevice3 test will follow once the d3d initialization design has > been approved. > If we're going to redo the way the tests work anyway, we probably shouldn't reuse the same objects for everything either.

2 1

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc (try 3)
by Henri Verbeet Dec. 1, 2011

Dec. 1, 2011

On 1 December 2011 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Subject: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc There is no IDirect3DDevice::GetDesc(). > + if(size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 */) return TRUE; Please fix the formatting here as well.

1 0