December 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetCaps (try 4)
by Alexandre Julliard Dec. 2, 2011

Dec. 2, 2011

stefan(a)codeweavers.com writes: > +static inline BOOL check_d3ddevicedesc_size(DWORD size) > +{ > + if (size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 */) return TRUE; > + return FALSE; > +} You should use something like FIELD_OFFSET instead of these magic constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Print error messages on stderr, not on stdout. (try3)
by Frédéric Delanoy Dec. 2, 2011

Dec. 2, 2011

On Fri, Dec 2, 2011 at 10:07, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > I meant to resend this one as [2/2] in my previous series but forgot. > With the resynchronization points we can now handle the fixed output > correctly in the tests this time. > > programs/cmd/builtins.c | 20 ++++++++++---------- > programs/cmd/tests/test_builtins.cmd | 1 - > programs/cmd/tests/test_builtins.cmd.exp | 7 +++---- > 3 files changed, 13 insertions(+), 15 deletions(-) Hi François. Would you mind updating the http://wiki.winehq.org/CmdConformanceTests page with your synchronization stuff? I'm not quite sure what/how it does exactly. There is now a discrepancy between wine output, and testrunner output, e.g. echo ------ eol option for /f "eol=@" %%i in (" ad") do echo %%i echo bar gave ------ eol option Syntax error bar but not gives ------ eol option bar Shouldn't cmd output always give the same as test runner output (which is supposed to run cmd on the input file (test_builtins.cmd), albeit with some preprocessing)? Frédéric

2 5

Re: [PATCH 3/3] user32: If a dialog has no tab-accessible controls, set focus to first control (with tests)
by Marvin Dec. 2, 2011

Dec. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15740 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] winecfg: Bump NT 3.51 to Service Pack 5
by Vitaliy Margolen Dec. 1, 2011

Dec. 1, 2011

On 12/01/2011 12:15 PM, André Hentschel wrote: > --- > - { "nt351", "Windows NT 3.5", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 2", 0, 0, "WinNT"}, > + { "nt351", "Windows NT 3.51", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 5", 5, 0, "WinNT"}, You need to do the same in ntdll/version.c Vitaliy.

1 0

Re: shell32/tests: Initialize all fields of SHFILEOPSTRUCT variables (Coverity)
by Marvin Dec. 1, 2011

Dec. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15738 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:1011: Test failed: Expected aborted operations shlfileop.c:2214: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin Dec. 1, 2011

Dec. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin Dec. 1, 2011

Dec. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] kernel32: Add a bunch of VirtualProtect tests on a memory-mapped file. Resend.
by Alexandre Julliard Dec. 1, 2011

Dec. 1, 2011

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/virtual.c | 187 +++++++++++++++++++++++++++++++++------- > 1 files changed, 154 insertions(+), 33 deletions(-) That's a good start, but it would be interesting to try this with various combinations of CreateFileMapping/MapViewOfFile protections, as I expect that the mapping protections would influence what you can then do in VirtualProtect. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test
by Henri Verbeet Dec. 1, 2011

Dec. 1, 2011

On 1 December 2011 11:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > An IDirect3DDevice3 test will follow once the d3d initialization design has > been approved. > If we're going to redo the way the tests work anyway, we probably shouldn't reuse the same objects for everything either.

2 1

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc (try 3)
by Henri Verbeet Dec. 1, 2011

Dec. 1, 2011

On 1 December 2011 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Subject: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc There is no IDirect3DDevice::GetDesc(). > + if(size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 */) return TRUE; Please fix the formatting here as well.

1 0