February 2011 - Wine-Devel - list.winehq.org

Patches to fix GetDIBits for top down destination bitmaps
by John Edmonds Feb. 27, 2011

Feb. 27, 2011

Please ignore the patches http://source.winehq.org/patches/data/71716 and http://source.winehq.org/patches/data/71711. I was having trouble with my mail client and accidentally sent the same code 3 times.

1 0

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.
by Nikolay Sivov Feb. 27, 2011

Feb. 27, 2011

On 2/26/2011 23:01, Gerald Pfeifer wrote: > --- > dlls/comctl32/tooltips.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index a2e58e0..445845c 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO *infoPtr, TTTOOLINFOW *ti, BOOL isW) > > > static LRESULT > -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit, > - BOOL isW) > +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit) > { > TTTOOL_INFO *toolPtr; > INT nTool; > @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) > > case TTM_HITTESTA: > case TTM_HITTESTW: > - return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam, > - uMsg == TTM_HITTESTW); > + return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam); > + > case TTM_NEWTOOLRECTA: > case TTM_NEWTOOLRECTW: > return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam); This should properly handle text instead of removing A/W case.

2 1

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)
by Misha Koshelev Feb. 27, 2011

Feb. 27, 2011

> Hi Misha, > > ... > > I'm attaching your patch with some modifications (mostly I took some > missing pieces from my old, way broken, patch). It seems to help a bit > but it's not perfect yet. It fixes handling of > 65520.0 values and > denormalized numbers. The interesting bit was to have some ad-hoc > rounding for the denormalized case. > The current implementation doesn't match native on some rounding > cases, but it's not clear what really the issue is. If you replace >= > with a > in "if (tmp - mantissa >= 0.5f) mantissa++;" you essentially > switch some failing cases with others. Maybe it has something to do > with floating point CPU rounding mode, but that seems unlikely to me. > Some testing under Windows is also needed. > > Ok, that's all. Please continue your work, correct 32/16 bit float > conversion functions are really a good thing to have (and you can fix > the implementation in wined3d after this is done ;)) > Hi Guys, Just thought I'd forward to the list (I hope it's ok Matteo). I'm pretty stumped. Matteo's patches were a big help. I did test on Windows and saw same result. My own (very unhelpful) diagnosis of the pattern is that, for the mantissa values: 2018.5 should round to 2018 2019.5 should round to 2020 2016.5 should round to 2016 2017.5 should round to 2018 2014.5 should round to 2014 2015.5 should round to 2016 2012.5 should round to 2012 2013.5 should round to 2014 1954.5 should round to 1954 1955.5 should round to 1956 1952.5 should round to 1952 1953.5 should round to 1954 1950.5 should round to 1950 1951.5 should round to 1952 1948.5 should round to 1948 1949.5 should round to 1950 I have attached a patch that makes this explicit and has just one failing test. Unfortunately, if we change the increment from 0xfff to 0xff, we seem to have a lot more disagreements. If anyone has any ideas pls let me know. I am stumped. I am going to see if perhaps I can make the relevant game work better by stubbing, and, if so, will submit a stub patch for now. Thank you Misha p.s. Note: the singles2halfp function is not mine, and is licensed under the BSD license. I modified it slightly to see if it would make things better. It didn't. It is not meant to actually be included in Wine but is useful for testing. http://www.mathworks.com/matlabcentral/fileexchange/23173 Thank you

2 2

Re: [3/3] comctl32/tests: Add a statusbar test for setting number of parts to zero.
by Marvin Feb. 27, 2011

Feb. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9486 Your paranoid android. === WNT4WSSP6 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W2KPROSP4 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === WXPPROSP3 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W2K3R2SESP2 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === WVISTAADM (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W2K8SE (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W7PRO (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W7PROX64 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W7PROX64 (64 bit status) === status.c:412: Test failed: Expected 1, got 0

2 1

Re: kernel32/tests: remove win9x hacks (try 2)
by Damjan Jovanovic Feb. 26, 2011

Feb. 26, 2011

On Wed, Feb 23, 2011 at 11:38 AM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > > So test.winehq.org doesn't test Win9x any more, but why are we throwing away perfectly good Win9x tests that took years to get in?

6 10

Re: [wiki] Fix Link to MoinMoin
by John Klehm Feb. 26, 2011

Feb. 26, 2011

2011/2/26 André Hentschel <nerv(a)dawncrow.de>: > - 'Sponsored by <a href="http://lattica.com/">Lattica</a> <a href="http://moinmoin.wikiwikiweb.de/">MoinMoin Powered</a>' > + 'Sponsored by <a href="http://lattica.com/">Lattica</a> <a href="http://www.moinmo.in/">MoinMoin Powered</a>' Death to www? Just http://moinmo.in/ perhaps? Regards, --John

1 0

Slides for Wine talk at Scale tomorrow
by Dan Kegel Feb. 26, 2011

Feb. 26, 2011

Anyone going to be at Scale in Los Angeles this weekend? I'll be giving a talk there tomorrow afternoon, showing off how well Wine works and demonstrating how to use and extend winetricks. Draft slides are up at http://kegel.com/wine/scale9x/ I still have time to tweak them, so if you have suggestions

2 2

Re: gdi32/tests: remove win9x hacks
by Marvin Feb. 25, 2011

Feb. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9519 Your paranoid android. === WVISTAADM (32 bit icm) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: crypt32/tests: remove win9x hacks
by Marvin Feb. 25, 2011

Feb. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9515 Your paranoid android. === WNT4WSSP6 (32 bit store) === store.c:962: Test failed: Expected 1 certificates, got 2 store.c:1761: Test failed: Expected CRYPT_E_ASN1_BADTAG, got 80093005

1 0

Dynamic OpenSSL import library
by Tim Burrell Feb. 25, 2011

Feb. 25, 2011

Hi all, I'm one of TransGaming's R&D developers working on our portability products. We've recently done a cleanup and refactoring to the OpenSSL loading routines; rather than loading the libraries in a few different places we moved the code into an OpenSSL importer that consolidates the loading into a separate library. Our importer does some additional things that might not be overly useful to Wine, such as detecting and loading different versions of the OpenSSL libraries at runtime (rather that using the version detected while configuring), but the cleanup and refactoring worked out quite well, and we think the code would still be valuable to Wine. We could port this code back to the Wine tree, but it will take some effort to do so. Also, our current implementation of the dynamic OpenSSL importer isn't complete; we're only loading the specific functions we've needed up until now. Before going to the effort of completing the library, and porting it back to the Wine tree, I thought I'd reach out first to see if it's even something that's of interest? If it is, great, we can complete the library and submit some patches for review, but if the concept isn't of interest then we'll just continue using it internally. I've attached a copy of the main C file from the OpenSSL import library, so you can get an idea for what it will look like. Keeping in mind that it's not finished yet, and needs some cleaning up, does this approach look acceptable? Also attached is a patch (that won't directly apply) that should give an idea of its intended usage. Anyone have thoughts / questions? Thanks, Tim. -- Tim Burrell TransGaming <http://transgaming.com> Inc. 431 King Street West, Suite 600 Toronto, Ontario, Canada M5V 1K4

3 2

Is the Call for Translators forum sticky still needed?
by Rosanne DiMesio Feb. 25, 2011

Feb. 25, 2011

The original post asked for help leading up to the release of 1.2. That's obviously outdated, and the thread now just attracts spammers. Should it be updated, or simply removed? -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: gdi32: Fix 64-bit pointer issues when copying upside-down bitmaps.
by Marcus Meissner Feb. 25, 2011

Feb. 25, 2011

On Fri, Feb 25, 2011 at 11:41:31PM +1100, Peter Urbanec wrote: > --- > dlls/gdi32/dib.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c > index 0619304..595eb9b 100644 > --- a/dlls/gdi32/dib.c > +++ b/dlls/gdi32/dib.c > @@ -885,7 +885,7 @@ INT WINAPI GetDIBits( > */ > if (bmp->dib->dsBmih.biHeight < 0) > { > - sbits += (srcwidthb * (abs(bmp->dib->dsBmih.biHeight) - 2 * startscan - 1)); > + sbits += (srcwidthb * (LONG)(abs(bmp->dib->dsBmih.biHeight) - 2 * startscan - 1)); Please enlighten us to the problem you are fixing? I see no 64bit pointer relation...? Ciao, Marcus

2 1

Re: winspool.drv: return maximum possible size of the buffer when no buffer is specified
by Alexandre Julliard Feb. 25, 2011

Feb. 25, 2011

Vitaly Perov <vitperov(a)etersoft.ru> writes: > @@ -7247,7 +7247,7 @@ static BOOL get_job_info_2(job_t *job, JOB_INFO_2W *ji2, LPBYTE buf, DWORD cbBuf > else > { > /* align DEVMODE to a DWORD boundary */ > - shift= (4 - ( (DWORD_PTR) ptr & 3)) & 3; > + shift= ptr ? (4 - ( (DWORD_PTR) ptr & 3)) & 3 : 3; It should most likely align from the start of the data, not from the pointer value. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: first look for a printer driver name in the registry (try 5)
by Dmitry Timoshkov Feb. 25, 2011

Feb. 25, 2011

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!hKey) RegCloseKey(hKey); This one is still not fixed. -- Dmitry.

2 1

Re: [PATCH] gdi32: Fix glyph orientation for inverted axis in compatible mode.
by Dmitry Timoshkov Feb. 25, 2011

Feb. 25, 2011

Alexander Kochetkov <al.kochet(a)gmail.com> wrote: > This is for the test application attached to the bug #22996 > I'm not sure, should I remove FT_IS_SCALABLE? How can I test the patch with non > scalable font? Could you please give me some advice? Testing with a non-scalable font should be easy, just use System instead of Arial as a font name. Regaring FT_IS_SCALABLE your patch just follows current logic and changes nothing. -- Dmitry.

1 0

Re: localspl/tests: test cleanup
by Marvin Feb. 25, 2011

Feb. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9481 Your paranoid android. === WVISTAADM (32 bit localmon) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

More FAQ reverts
by Vitaliy Margolen Feb. 25, 2011

Feb. 25, 2011

In case kjensen will start looking why I reverted his changes - they are wrong. Obviously he didn't test them. > $1 "`wine winepath -u "$2"`" | sed 's/ /\\ /' Not sure how piping output of a native command through sed will fix "argument to the program contain spaces it will not work". The argument with spaced does perfectly work with current script. That's why there are two pairs of double quotes. > @="/bin/sh ~/bin/run_linx_program ooffice \"%1\"" This is bogus, Wine does not perform *NIX shell expansions (~ is a shell expansion). Vitaliy.

1 0

GSOC idea to implement the explorer
by Andrew Green Feb. 25, 2011

Feb. 25, 2011

I was just looking at the Google summer of code(GSOC) ideas and noticed "implement the explorer". This grabbed my attention as I have recently been working on a windows xp explorer clone. Also it mentions a reference to ReactOS explorer written in c++. Well there is a second explorer which is planned to be more true to the xp implementation and written in c. Currently it's called explorer new as it is not yet complete and is just a shell. I was wondering if it was possible to share this code. As it would probably be beneficial in the long term. It already has support for shell extensions. When running under windows I can add any extension such as Quick launch, language bar and so on. Here is a pic of my working copy(trunk doesn't have this theming yet. Though I should finish it soon) http://img156.imageshack.us/f/yaytheme.png/ This is just an idea. I know it's very incomplete. Though it is showing promise. Here is a link to the "GSOC implement the explorer" page I mentioned http://wiki.winehq.org/SummerOfCode#head-18241c95194e4e1c597bd2923cf296084f… Any comments and ideas are much appreciated.

4 5

Re: oleaut32/tests: fix a couple todo_wine's
by Marvin Feb. 25, 2011

Feb. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9472 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] user32: Fixed some more sideeffect functions in assert() (Coverity)
by Marvin Feb. 24, 2011

Feb. 24, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9451 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: msvcrt/tests: Don't test function directly when reporting errno
by Marvin Feb. 24, 2011

Feb. 24, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9458 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: urlmon/tests: Add BINDSTATUS_DECODING progress case
by Jacek Caban Feb. 24, 2011

Feb. 24, 2011

Hi André, On 2/24/11 6:52 PM, André Hentschel wrote: > happens on nt, xp and 2k3 That's the effect of switching winehq.org to using gzip. I think we need to change all different http-related tests to use a centralized place for tests. Something like set of PHP scripts on test.winehq.org or a new domain that would give use more control over http headers and content is something I have in minnd. Current solution of using random URLs that happen to be good for specific task has proven to be wrong and results in less strict tests than we could achieve otherwise. Also BINDSTATUS_DECODING should be sent by IE older than 7 and we don't want to allow it on Wine. Anyway, I think the fix should be more sophisticated. Jacek

1 0

Re: gdi32: Use graphics mode specified at the EMF creation time when playing EMR_EXTTEXTOUT record.
by Alexander Kochetkov Feb. 24, 2011

Feb. 24, 2011

> + > + SetGraphicsMode(hdc, old_mode); > break; > } > Hi, Dmitry Timoshkov! Needs to reselect font again after restore old_mode in case pExtTextOutW-> iGraphicsMode != old_mode. Otherwise, the font will remain with the wrong glyph orientation. I can write a test demonstrating the problem. Resect font is needed only if pExtTextOutW-> iGraphicsMode is GM_COMPATIBLE. This is performance optimization for GM_ADVANCED. Thank, you!

1 1

Re: [PATCH 5/7] mshtml: Added attribute object tests
by Marvin Feb. 24, 2011

Feb. 24, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9448 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === W2K8SE (32 bit dom) === dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0

Re: [PATCH 1/7] mshtml: Added IHTMLElement4 stub implementation
by Marvin Feb. 24, 2011

Feb. 24, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9447 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === W2K8SE (32 bit dom) === dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0