February 2011 - Wine-Devel - list.winehq.org

Re: winmm: Simplify MCI_DumpCommandTable a bit. (RETRY)
by Alexandre Julliard Feb. 18, 2011

Feb. 18, 2011

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Ping. Any objection to this, given that this has not been used for > quite a while? The variable is here for documentation, you don't want to remove it. You can comment it out if it's not used. -- Alexandre Julliard julliard(a)winehq.org

2 1

Somewhat barebones patch to implement D3DXCreateRenderToSurface for bug 24899, how much more needs to be implemented?
by Misha Koshelev Feb. 18, 2011

Feb. 18, 2011

Dear All: Looking at d3dx9 bugs, bug 24899 requires D3DXCreateRenderToSurface. This, somewhat barebones, patch, implements core functionality of D3DXCreateRenderToSurface, along with a barebones ID3DXRenderToSurface implementation. I was wondering, in order to get this patch accepted into the wine code base, how much more of ID3DXRenderToSurface needs to be implemented? Thank you Misha

3 3

project help...
by ejaj on resurgence Feb. 17, 2011

Feb. 17, 2011

m a new comer here...its great.....well i just wanna know if wine is gonna be project in GSOC-11....wud be glad if soo...i wanna get into it....so sum 1 plz help me out here...lotsa thnx...

1 0

A patch trying to fix Bug 25999 - wine builtin IE crash while opening file with zero bytes
by Qian Hong Feb. 17, 2011

Feb. 17, 2011

Dear All, I'm trying to fix http://bugs.winehq.org/show_bug.cgi?id=25999 Below is my patch. This my first patch, I wonder weather it is ugly, I'm grateful for any advice. >From 0598dc0acf14a18d28e78e7b924384c46040a81e Mon Sep 17 00:00:00 2001 From: Qian Hong <fracting(a)gmail.com> Date: Fri, 18 Feb 2011 04:46:41 +0800 Subject: modified: dlls/mshtml/navigate.c --- dlls/mshtml/navigate.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb71c79..f978e8e 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -1106,7 +1106,8 @@ static HRESULT async_stop_request(nsChannelBSC *This) IBindStatusCallback_AddRef(&This->bsc.IBindStatusCallback_iface); task->bsc = This; - push_task(&task->header, stop_request_proc, This->bsc.doc->basedoc.doc_obj->basedoc.task_magic); + if(This->bsc.doc) + push_task(&task->header, stop_request_proc, This->bsc.doc->basedoc.doc_obj->basedoc.task_magic); return S_OK; } -- Thanks very much! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: user32: Use the windows created by the SetParent() test to get a more predictable active/focus window state.
by Alexandre Julliard Feb. 17, 2011

Feb. 17, 2011

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Hopefully this should fix recently introduced test failures seen on some > test machines. It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so win.c && touch win.ok win.c:3479: Test failed: GetActiveWindow() = 0x5500c2 win.c:3479: Test failed: GetFocus() = 0x5500c2 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

winmm/tests: remove dead assignment (LLVM/Clang)
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 17, 2011

Feb. 17, 2011

Hi, Austin suggests: >--- a/dlls/winmm/tests/wave.c >- first = FALSE; -1 Some times you value consistency more than elimination of superfluous assignments. All parts are written like this: if ((flags & WAVE_FORMAT_DIRECT) == WAVE_FORMAT_DIRECT) { if (!first) strcat(msg, "|"); strcat(msg, "WAVE_FORMAT_DIRECT"); first = FALSE; } and you don't want to eliminate that one line in the last part just because it happens to be the last one TODAY. What if tomorrow another flag is added last and the programmer oversees that s/he needs to reintroduce that first=FALSE statement? Removing regularity is just error-prone and in the way of maintainability. Try to keep the code regular and all parts alike, without exception for the last one. It reminds me of the annoying issue with the trailing comma in structure initialisations, which lead some people to instead use a style like this (well known in functional programming): ... , value_n , value_n+1 }; Isn't there a way to silence several complains from Clang which I consider stupid? Regards, Jörg

1 0

Re: mshtml: Implement IHTMLAnchorElement_put_href
by Jacek Caban Feb. 17, 2011

Feb. 17, 2011

Hi Alistair, On 2/17/11 10:45 AM, Alistair Leslie-Hughes wrote: > + IHTMLAnchorElement *anchor = _get_anchor_iface(line, unk); > + BSTR str; > + HRESULT hres; > + > + str = a2bstr(exhref); > + hres = IHTMLAnchorElement_put_href(anchor, str); > + ok_(__FILE__,line)(hres == S_OK, "get_href failed: %08x\n", hres); > + > + _test_disp_value(line, unk, exhref); You leak str here. Jacek

1 0

Re: ntdll/signal_arm.c: Implement segv_handler
by Dmitry Timoshkov Feb. 17, 2011

Feb. 17, 2011

chris.nousco(a)gmail.com wrote: > From: JinSung Kang <chris.nousco(a)gmail.com> > > Improve that segv_handler function check page_fault and setting up exception handler. > It is possbible whether read fault or write fault. It looks like the formatting of your patches is messed up because of using a non-standard tab size (4?). -- Dmitry.

1 0

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (try 2)
by Dmitry Timoshkov Feb. 17, 2011

Feb. 17, 2011

Austin English <austinenglish(a)gmail.com> wrote: > + r = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELONG(100,50)); > + ok(r, "failed\n"); Please use a more informative failure message. > r = SendMessage(hwnd, WM_NOTIFYFORMAT, 0, NF_QUERY); > + todo_wine expect(2, r); 2 is NFR_UNICODE. -- Dmitry.

1 0

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (1/6)
by Marvin Feb. 17, 2011

Feb. 17, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9336 Your paranoid android. === WNT4WSSP6 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W2KPROSP4 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === WXPPROSP3 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W2K3R2SESP2 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === WVISTAADM (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W2K8SE (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W7PRO (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W7PROX64 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W7PROX64 (64 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2

2 1

Re: wintrust/tests: Fix a leak (valgrind)
by Marvin Feb. 16, 2011

Feb. 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9309 Your paranoid android. === W2K8SE (32 bit softpub) === softpub.c:742: Test failed: expected TRUST_E_NOSIGNATURE or CRYPT_E_FILE_ERROR, got 80092003

1 0

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)
by Alexandre Julliard Feb. 16, 2011

Feb. 16, 2011

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -381,9 +386,40 @@ static HRESULT WINAPI xslprocessor_Invoke( > static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) > { > xslprocessor *This = impl_from_IXSLProcessor( iface ); > + IXMLDOMNode *input_node; > + HRESULT hr; > > - FIXME("(%p): stub\n", This); > - return E_NOTIMPL; > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&input)); > + > + /* try IXMLDOMNode directly first */ > + if (V_VT(&input) == VT_UNKNOWN) > + hr = IUnknown_QueryInterface(V_UNKNOWN(&input), &IID_IXMLDOMNode, (void**)&input_node); > + else if (V_VT(&input) == VT_DISPATCH) > + hr = IDispatch_QueryInterface(V_DISPATCH(&input), &IID_IXMLDOMNode, (void**)&input_node); > + > + if (hr != S_OK) You need to handle the default case somehow. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)
by Joris Huizer Feb. 16, 2011

Feb. 16, 2011

Hello, I think I found a (possible) little issue in the patch: If one would pass a VARIANT of incorrect type to the xslprocessor_put_input() function (say type BSTR), the first type checks fail and leave hr uninitialised; in case it happened to have the value S_OK the other if block is skipped - assigning the uninitialised input_node; static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) { xslprocessor *This = impl_from_IXSLProcessor( iface ); + IXMLDOMNode *input_node; + HRESULT hr; (assume hr happens to be S_OK) - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + TRACE("(%p)->(%s)\n", This, debugstr_variant(&input)); + + /* try IXMLDOMNode directly first */ + if (V_VT(&input) == VT_UNKNOWN) + hr = IUnknown_QueryInterface(V_UNKNOWN(&input), &IID_IXMLDOMNode, (void**)&input_node); + else if (V_VT(&input) == VT_DISPATCH) + hr = IDispatch_QueryInterface(V_DISPATCH(&input), &IID_IXMLDOMNode, (void**)&input_node); (both false) + + if (hr != S_OK) + { //... + } (skipped) + + if (hr == S_OK) + { + if (This->input) IXMLDOMNode_Release(This->input); + This->input = input_node; + } (executed, assigning garbage to This->input) + + return hr; } HTH, Joris

1 0

Re: gameux/gamestatistics.c: Make sure each VARIANT is cleared after use (valgrind)
by Alexandre Julliard Feb. 16, 2011

Feb. 16, 2011

Joris Huizer <joris_huizer(a)yahoo.com> writes: > @@ -511,24 +511,27 @@ static HRESULT GAMEUX_loadStatisticsFromFile(struct GAMEUX_STATS *data) > > if(SUCCEEDED(hr)) > { > - hr = IXMLDOMElement_getAttribute(categoryElement, bstrIndex, &vValue); > - if( hr == S_OK && V_VT(&vValue) != VT_BSTR) > + VARIANT categoryIndex, categoryName; > + hr = IXMLDOMElement_getAttribute(categoryElement, bstrIndex, &categoryIndex); > + if( hr == S_OK && V_VT(&categoryIndex) != VT_BSTR) > hr = E_FAIL; > > if(SUCCEEDED(hr)) > { > - i = StrToIntW(V_BSTR(&vValue)); > - hr = IXMLDOMElement_getAttribute(categoryElement, bstrName, &vValue); > - if( hr == S_OK && V_VT(&vValue) != VT_BSTR) > + i = StrToIntW(V_BSTR(&categoryIndex)); > + hr = IXMLDOMElement_getAttribute(categoryElement, bstrName, &categoryName); > + if( hr == S_OK && V_VT(&categoryName) != VT_BSTR) > hr = E_FAIL; > } > + VariantClear(&categoryIndex); You should only clear it when it has been successfully set. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine64 issues in dlls/msvcr90/tests/msvcr90.c
by Peter Urbanec Feb. 16, 2011

Feb. 16, 2011

As of a few days ago, I'm seeing the following errors when building wine64 with gcc (Gentoo 4.5.2 p1.0, pie-0.4.5) 4.5.2 dlls/msvcr90/tests/msvcr90.c:137:14: warning: 'do_call_func1' defined but not used dlls/msvcr90/tests/msvcr90.c:147:14: warning: 'do_call_func2' defined but not used dlls/msvcr90/tests/msvcr90.c: Assembler messages: dlls/msvcr90/tests/msvcr90.c:150: Error: invalid instruction suffix for `push' When building wine32, there seem to be no problems. Is anyone else seeing this when building wine64?

1 0

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)
by Jacek Caban Feb. 16, 2011

Feb. 16, 2011

On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: > Changelog: > mshtml: Ignore IActiveScript interface for IXMLHTTPRequest mshtml? + else if ( IsEqualGUID( riid,&IID_IActiveScript)) + { + TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n", This, ppvObject); + *ppvObject = NULL; + return E_NOINTERFACE; + } else { FIXME("Unsupported interface %s\n", debugstr_guid(riid)); As discussed on wine-devel, please just change the later FIXME to TRACE instead. Jacek

2 3

Re: comctl32/tests: Add two casts to avoid comparisons of different int types.
by Marvin Feb. 16, 2011

Feb. 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9229 Your paranoid android. === W7PROX64 (64 bit tab) === tab.c:1330: Test failed: got 69cc80, expected dededede

3 3

[PATCH] Implement software DXT1 compression
by alberto＠mattea.info Feb. 16, 2011

Feb. 16, 2011

This patch adds conversion functions from WINED3DFMT_B8G8R8_UNORM, WINED3DFMT_B5G5R5A1_UNORM and WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_DXT1. It uses code slighty modified from libtxc_dxtn. It fixes at least LEGO Stunt Rally, probably other games too. I didn't implement dxt3 and dxt5 since I haven't got any apps to test, but if someone has similar problems (black textures) with them and wants to test, let me know, and I will add them as well. I would also like some feedback about the patent situation, e.g. if the patch can be mainlined as it is or if it would be better to load libtxc_dxtn directly at runtime. Alberto

3 2

valgrind results - now with better debug info
by Austin English Feb. 15, 2011

Feb. 15, 2011

Howdy all, I've added a few more suppressions, and after a suggestion by Nikolay, added some debugging symbols: austin(a)debian:~/src/winezeug/valgrind$ dpkg -l | grep dbg ii cups-dbg 1.4.5-2 Common UNIX Printing System(tm) - debugging symbols ii libc6-dbg 2.11.2-11 Embedded GNU C Library: detached debugging symbols ii libgsm1-dbg 1.0.13-3 Shared libraries for GSM speech compressor (debug symbols) ii libsane-dbg 1.0.21-9 API development library for scanners [debug symbols] ii libsane-extras-dbg 1.0.21.2 API library for scanners -- extra backends [debug symbols] ii libxml2-dbg 2.7.8.dfsg-2 Debugging symbols for the GNOME XML library ii libxslt1-dbg 1.1.26-6 XSLT 1.0 processing library - debugging symbols ii zlib1g-dbg 1:1.2.3.4.dfsg-3 compression library - development if you need a debugging symbol package to get better info from a crash, please let me know. The current suppressions used are at: http://winezeug.googlecode.com/svn/trunk/valgrind/valgrind-suppressions Please let me know if you have more to add I've filed bugs for most results, see: http://bugs.winehq.org/buglist.cgi?query_format=advanced&emailreporter1=1&s… as always, results are at: http://austinenglish.com/logs/valgrind/ Cheers, Austin

1 0

Re: D3DXCreateTorus patch... thoughts?
by David Adam Feb. 15, 2011

Feb. 15, 2011

Here is cool link to show what D3DXCreateTorus does: http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip A+ David

2 1

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info Feb. 15, 2011

Feb. 15, 2011

Hi Stefan. I'm not really into opengl internals, so I think the best solution for now is to implement 1), and give complete support when the blitting code will be in a better shape. Would this be okay? if (!context->valid) { context_release(context); FIXME("No gl context, cannot perform conversion\n"); return; } Thanks

1 0

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info Feb. 15, 2011

Feb. 15, 2011

> An idea that was proposed before was to delegate the conversion (and the > patents burden) to the OpenGL drivers, something like using > glCompressedTexImage2D() / glGetCompressedTexImage(). Not sure > whether there are hidden issues with that approach (except, well, requiring > an OpenGL driver with compressed textures support), but at a first glance > it doesn't look as something particularly hard to do. Good idea. This new patch implements this approach. It seems to be working perfectly at least with the nvidia blob. It is also much smaller than the previous one, and doesn't require hacks like inverting colors and so on.

2 1

Re: [website] Turn on gzip compression
by Jeremy Newman Feb. 15, 2011

Feb. 15, 2011

Actually, a better way to accomplish this is to add: php_flag zlib.output_compression On to the .htaccess file. I'm a little surprised it was not there already. -N On 02/15/2011 01:02 PM, André Hentschel wrote: > First make sure that works with your server... > --- > site | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/site b/site > index 5a7bd46..a776199 100644 > --- a/site > +++ b/site > @@ -5,6 +5,8 @@ > by Jeremy Newman<jnewman(a)codeweavers.com> > */ > > +ob_start("ob_gzhandler"); > + > // load modules and defines > $file_root = realpath(dirname(__FILE__)); > require("{$file_root}/include/incl.php"); > @@ -114,4 +116,5 @@ $html->page = $html->template("local", PAGE); > $html->showpage(); > > // done > +ob_end_flush(); > ?>

1 0

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.
by Marvin Feb. 15, 2011

Feb. 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9273 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045

3 2

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)
by Alexandre Julliard Feb. 15, 2011

Feb. 15, 2011

Daniel <danielfsantos(a)att.net> writes: > @@ -54,11 +56,13 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) > elp = HeapAlloc( GetProcessHeap(), 0, size ); > > GetObjectW( hpen, size, elp ); > - /* FIXME: add support for user style pens */ > + > logpen.lopnStyle = elp->elpPenStyle; > logpen.lopnWidth.x = elp->elpWidth; > logpen.lopnWidth.y = 0; > logpen.lopnColor = elp->elpColor; > + user_style_size = elp->elpNumEntries; > + user_style = elp->elpStyleEntry; This can't work, the data will be freed before you use it. -- Alexandre Julliard julliard(a)winehq.org

1 0