February 2011 - Wine-Devel - list.winehq.org

test_TCS_OWNERDRAWFIXED in dlls/comctl32/tests/tab ?
by Gerald Pfeifer Feb. 12, 2011

Feb. 12, 2011

test_TCS_OWNERDRAWFIXED in dlls/comctl32/tests/tab has the following code: LPARAM lparam, lparam2; : lparam = 0; memset(&lparam, 0xde, 4); memset(&lparam2, 0xde, sizeof(LPARAM)-1); ok(g_drawitem.itemData == lparam || broken(g_drawitem.itemData == lparam2) /* win98 */, "got 0x%lx, expected 0x%lx\n", g_drawitem.itemData, lparam); I have two questions on this. First, why does the memset use the constant 4 and not sizeof(LPARAM)? Second, why initialize lparam with 0 when this is immediately followed by a memset covering it's fully size? Third, lparam2 is partially uninitialized and will have a couple of random bits from all I can tell since lparam2 is never initialized and the memset only covers a portion of it. I'm wondering, should lparam = 0 just read lparam2 = 0? Whatever may be the case, the current code does not look right. Gerald

1 0

.chm files for builtin programs?
by Dan Kegel Feb. 12, 2011

Feb. 12, 2011

Hi all, The native dxdiag uses a .chm file for its help system, so ours might as well, too. I see there's a .chm file checked in to git (in dlls/itss/tests). Any objection to checking a .chm file into programs/dxdiag, along with its source files and script to build it? I think there's an open source .chm compiler at http://sourceforge.net/projects/chmc/ Haven't tried it yet. If that doesn't work, we can use Microsoft's hhc. - Dan

3 2

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.
by Marvin Feb. 12, 2011

Feb. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8981 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2238: Test failed: Got 7fff, expected 7c00 for index 7. === WVISTAADM (32 bit math) === math.c:2238: Test failed: Got 7fff, expected 7c00 for index 7. === W7PRO (32 bit math) === math.c:2238: Test failed: Got 7fff, expected 7c00 for index 7.

6 25

Please reject patch 71094 it is wrong.
by Alexander Kochetkov Feb. 12, 2011

Feb. 12, 2011

71094 New Alexander Kochetkov [resend] gdi32: Text output of records EMR_EXTTEXTOUTA/W depend on field iGraphicsMode

1 0

Re: [PATCH 2/2] msvcrt: Implement _strnicoll.
by Dmitry Timoshkov Feb. 12, 2011

Feb. 12, 2011

Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > /********************************************************************* > + * _strnicoll (MSVCRT.@) > + */ > +int CDECL MSVCRT__strnicoll(const char* str1, const char* str2, int digits) > +{ > + int res; > + > + res = strncmp(str1, str2, digits); > + if (res > 0) > + res = 1; > + else if (res < 0) > + res = -1; > + > + return res; > +} The API name implies case insensitive comparison, please add the tests for that. -- Dmitry.

2 1

d3dx9_36 [resend]: Add a few tests for D3DXCreateBox
by David Adam Feb. 12, 2011

Feb. 12, 2011

Hello, no feedback available for this patch? It was rejected silently. A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/2/9 Subject: d3dx9_36 [resend]: Add a few tests for D3DXCreateBox To: wine-patches <wine-patches(a)winehq.org> Fixed following Stefan's advices. A+ David

1 0

[rfc] dsound: decrease sound latency
by Maarten Lankhorst Feb. 11, 2011

Feb. 11, 2011

Hi all, Please test this and let me know if it's causing any problems in sound playback, preferably with media applications and games, any feedback would be appreciated. The patch won't fix existing problems, it should just decrease the audio lag. As such I would prefer only to receive feedback on issues INTRODUCED or FIXED by this patch. If it's causing issues, I want to know: 1. Whether pulseaudio is running, and pulseaudio --version 2. What distribution you're using 3. (If you know it) the version of alsa's libraries, packages libasound2 and libasound2-plugins in debian/ubuntu Cheers, Maarten

2 1

Re: iphlpapi: Hint what to do when icmp does not work
by Charles Davis Feb. 11, 2011

Feb. 11, 2011

On 2/11/11 11:12 AM, André Hentschel wrote: > Otherwise the user might try running wine as root or doesn't know that this error can be easily fixed when needed. > --- > dlls/iphlpapi/icmp.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c > index d8ee101..41d1940 100644 > --- a/dlls/iphlpapi/icmp.c > +++ b/dlls/iphlpapi/icmp.c > @@ -155,6 +155,7 @@ HANDLE WINAPI IcmpCreateFile(VOID) > int sid=socket(AF_INET,SOCK_RAW,IPPROTO_ICMP); > if (sid < 0) { > ERR_(winediag)("Failed to use ICMP (network ping), this requires special permissions.\n"); > + ERR_(winediag)("Try running \"sudo setcap cap_net_raw+epi /usr/bin/wine-preloader\".\n"); That only works on systems that support POSIX capabilities (Linux, and maybe OpenBSD). Chip

2 2

[PATCH 01/13] dsound: New sample rate converter core functions.
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 11, 2011

Feb. 11, 2011

Hi, The question how to split is interesting. I haven't found the answer about how to split my future MIDI player rewrite either. Like yours, it will replace old functions with something new. Some guidelines are: - Each patch should be self contained and a logical unit, e.g. + a bug fix, possibly with test e.g. ZeroMemory => FillMemory wBitsPerSample == 8 ? 128 : 0 + a change in configuration (e.g. sampling rate 48000) => split change of default & introduction new of registry key + some refactoring in preparation for future work + changes to logic & functionality e.g. DSDDESC_DONTNEEDWRITELEAD, leadin - It must compile. - It should pass tests (a rule, not a dogma). In this light, [PATCH 08/13] (remove 2x HeapFree) looks wrong, unless it fixed a bug in the old code. It should be part of something else. Try and explain design changes. Your code is not only a resampler, it also changes the way DSound performs mixing, such that DSOUND_MixToTemporary becomes superfluous. What's not so nice -- yet that has happened several times already -- is to have a patch like "Now use the new functions added in the last 12 patches instead of the old ones", because regression testing will irremediably identify that patch as culprit and not help identify which of the 12 introducing patches caused the "actual" regression via a subtle change in behaviour or side effects. Conversely, if you think about how regression testing can work well, you'll find recommendations for patches yourself. About ordering: Move the patch introducing the new registry key towards the end, and work with a constant prior to that. Doing so, this patch becomes working code instead of being ground work not testable until the resampler is in place. I suggest isolating - the FIR generator + Makefile change. - keeping patch 11 -- remove unused files & code last -- so as to minimize size of patches that introduce code. As a side note, I'm wondering whether I'd insert resample.c into mixer.c. + TRACE("resample quality: %d\n", dsb->quality); + TRACE("resample firstep %d\n", dsb->firstep); Logging is expensive (when on) and known to cause race conditions. Hence I'd combine all these into one line. Also keep in mind that your reactions here will influence acceptance of your code -- "Does this person sound like s/he's going to support and fix regressions in her/his code or is it 'take or leave, bye'?" Regards, Jörg Höhle

3 2

Resend: Who does c2man?
by Max TenEyck Woodbury Feb. 11, 2011

Feb. 11, 2011

I have just been going over tools/c2man and have a fair number of questions about it. I can probably dig some of the answers out myself, but it would probably go faster and raise less fuss if I can talk to the person (people) who have worked on it previously. Please send me email with contact information, or indicate that you want this done on some forum. Max

3 3

CD handling on MacOS - the big picture?
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 11, 2011

Feb. 11, 2011

Hi, the last years have seen individual patches by K. Thomases and C. Davis to Mac OSX' CD handling, but I don't see the big picture. Mixed CDs occur in some games, but some audio CDs contain "bonus content" as well. On MacOS, mixed CDs are mounted as two volumes - the audio part, - the data/binary section not unlike Gnome which also displays 2 disc icons on the desktop. On Linux, Wine manages to map both to a single CD-ROM drive letter like D:, such that - D:\data\foo.exe works as well as - MCICDA: open D: type cdaudio alias D; play D work (but see bug 20555), which mimics native's behaviour. On MacOS, we're not there yet. I've no idea how that can be made to work. How would Wine on MacOS join the pieces? Regards, Jörg Höhle

2 1

Re: [PATCH 01/13] dsound: New sample rate converter core functions.
by Krzysztof Nikiel Feb. 11, 2011

Feb. 11, 2011

2011/2/11 Dmitry Timoshkov <dmitry(a)codeweavers.com>: > Krzysztof Nikiel <knik00(a)gmail.com> wrote: > >> > You can't send Makefile changes separately from added/removed >> > files, a patch should not add dead code. >> >> Could you explain "dead code", all 13 parts need to be applied, >> otherwise the code will be broken. > > Wine should compile and be able to pass 'make test' after each separate patch. > You can't add for instance dlls/dsound/resample.c in one patch, and add it to > Makefile or use interfaces provided by it in some later patches. Every patch > should be finished and self-containing. Well, previous version of this patch was rejected as "needs splitting", it's basically too big to be send as a single patch. It can be applied as several smaller chunks or rejected as a whole. I don't think there is any other option.

3 4

Re: [PATCH 01/13] dsound: New sample rate converter core functions. (resend)
by Vitaliy Margolen Feb. 11, 2011

Feb. 11, 2011

Nice job! If it will make Wine's sound better - it would be awesome. Haven't read the entire patch series. But few nit picks so far. On 02/11/2011 04:34 AM, Krzysztof Nikiel wrote: > +typedef double sample_t; > > +static inline sample_t getsample(LPBYTE buf, INT bps) > +{ > + tmp = ((sample_t) (*((BYTE *) buf)) - 128.0); No need to type cast. "buf" already a pointer to the BYTE. You can use it directly as *buf or buf[0], which is even more readable. > +static inline void putsample(LPBYTE buf, INT bps, sample_t smp) > + CLIPSAMPLE(smp, (double) 0x7fff); Typecasts are bad, especially that the type of "smp" is not "double". Please use "32767.0" instead. > + DOUBLE amp[3]; Mixing types again. If you defined your own type then please use it. Or make everything the same type whichever it is. > [PATCH 02/13] dsound: Resample filter table generator. (resend) Don't think compiler helpers should be going into dll directories. The more correct place is tools. But it's up to AJ. And as others noted, your patch series is not split correctly. Each patch will break Wine tree until the very last one. This is against the patch requirements that code tree should compile after every commit. You can put your compile helper with it's make file first. Then add your resampling code with a make file changes to compile it. But not use it yet (it does break another rule for adding dead code, but that's the only way you can split the entire series). After that make use of your new resampler, removing all conflicting code, so Wine will work. Last commit can be a cleanup for all remaining pieces that are no longer used. Vitaliy.

2 1

Testmail
by Detlef Riekenberg Feb. 11, 2011

Feb. 11, 2011

Hi Just a test, as my patches do not show up in the mail archive. Detlef ___________________________________________________________ WEB.DE DSL Doppel-Flat ab 19,99 €/mtl.! Jetzt mit gratis Handy-Flat! http://produkte.web.de/go/DSL_Doppel_Flatrate/2

1 0

Re: [PATCH] dsound: More accurate volume calculation.
by Vitaliy Margolen Feb. 11, 2011

Feb. 11, 2011

On 02/11/2011 02:38 AM, Krzysztof Nikiel wrote: > I have changed this when creating the new resampler patch but it's not > really related to the main patchset. The patch is wrapped. Please send it as attachment. Also please no HTML when sending patches. Vitaliy

2 1

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest
by Nikolay Sivov Feb. 11, 2011

Feb. 11, 2011

On 2/11/2011 10:51, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Ignore IActiveScript interface for IXMLHTTPRequest What's a purpose of this? > > > Best Regards > Alistair Leslie-Hughes

3 6

Re: [PATCH 01/13] dsound: New sample rate converter core functions. (resend)
by Owen Rudge Feb. 11, 2011

Feb. 11, 2011

> It looks like it may be too big to be accepted. Anyway, I will try to > resend it with 4 space indent for new files. > Hopefully these patches won't get wrapped this time. Your patches still appear to be being wrapped by your mail client. Try sending them as an attachment instead of inline (i.e., use the --attach parameter to git format-patch). -- Owen Rudge http://www.owenrudge.net/

1 0

Re: [PATCH 01/13] dsound: New sample rate converter core functions.
by Dmitry Timoshkov Feb. 11, 2011

Feb. 11, 2011

Krzysztof Nikiel <knik00(a)gmail.com> wrote: > High quality sample rate converter. > New code seems simplier and faster despite the big sound quality > improvement. > > This patchset only makes sense when applying all 13 parts. It looks like at least some patches got wrapped by your mailer. You can't send Makefile changes separately from added/removed files, a patch should not add dead code. Could you use 4 space indetation for the new code please? -- Dmitry.

1 0

winspool.drv : Implement AbortPrinter() function
by Loïc Maury Feb. 11, 2011

Feb. 11, 2011

1 0

Re: avifil32: Skip tests when we couldn't create or open the AVI file
by GOUJON Alexandre Feb. 11, 2011

Feb. 11, 2011

On 01/30/2011 07:29 PM, Alexandre Goujon wrote: > --- > dlls/avifil32/tests/api.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/dlls/avifil32/tests/api.c b/dlls/avifil32/tests/api.c > index 14ad4b4..c1ba878 100644 > --- a/dlls/avifil32/tests/api.c > +++ b/dlls/avifil32/tests/api.c > @@ -338,6 +338,12 @@ static void create_avi_file(const COMMON_AVI_HEADERS *cah, char *filename) > > ok(hFile != INVALID_HANDLE_VALUE, "Couldn't create file\n"); > > + if(hFile == INVALID_HANDLE_VALUE) > + { > + win_skip("Could not create the AVI file\n"); > + return; > + } > + > WriteFile(hFile,&cah->fh, sizeof(deffh),&written, NULL); > WriteFile(hFile,&cah->mah, sizeof(MainAVIHeader),&written, NULL); > WriteFile(hFile, streamlist, sizeof(streamlist),&written, NULL); > @@ -380,6 +386,12 @@ static void test_default_data(void) > ok(res != REGDB_E_CLASSNOTREG, "Unable to open file: error5=%u\n", REGDB_E_CLASSNOTREG); > ok(res == 0, "Unable to open file: error=%u\n", res); > > + if(res != 0) > + { > + win_skip("Could not open the file.\n"); > + return; > + } > + > res = AVIFileGetStream(pFile,&pStream0, 0, 0); > ok(res == 0, "Unable to open video stream: error=%u\n", res); I know I sent this patch about two weeks ago but I thought it was pending because of the 1.3.13 release. So, does anyone has an idea how to make this patch applied in the current tree ? The context is that we don't fail when we couldn't create or open the AVI file. (I think the title of the patch is explicit) Thus, we call "WriteFile(hFile" in the first part of the test even if hFile == INVALID_HANDLE_VALUE. In the second part, we call "AVIFileGetStream(pFile" even if "AVIFileOpen(&pFile" failed. I can also resend this appending [resent]. Just let me know what to do. Thanks !

3 3

Re: ole32/tests: make sure to use a return value (LLVM/Clang) (2/3)
by Marvin Feb. 10, 2011

Feb. 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9189 Your paranoid android. === WNT4WSSP6 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W2KPROSP4 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === WXPPROSP3 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W2K3R2SESP2 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === WVISTAADM (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W2K8SE (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W7PRO (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W7PROX64 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W7PROX64 (64 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005

1 0

Re: shell32/tests: make sure return values are used (LLVM/Clang) (4/7)
by Marvin Feb. 10, 2011

Feb. 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9177 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2210: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: msi/tests: make sure to use a return value (LLVM/Clang) (2/2)
by Marvin Feb. 10, 2011

Feb. 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9162 Your paranoid android. === WVISTAADM (32 bit db) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Add test for nested default Button in Dialogs
by Marvin Feb. 10, 2011

Feb. 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9151 Your paranoid android. === WVISTAADM (32 bit dialog) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [3/3] user32: SetParent() needs to map window rectangle to the new parent.
by Marvin Feb. 10, 2011

Feb. 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9136 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0