February 2011 - Wine-Devel - list.winehq.org

Killing WineAPI project on SourceForge.
by Max TenEyck Woodbury Feb. 7, 2011

Feb. 7, 2011

No feedback and apparently no interest in the WineAPI project on SourceForge. Understandable since there is now a WineAPI on the regular Wine Wiki. Unless someone objects, I'm going to ask that it be shutdown on SourceForge. Max

5 6

Including winegcc-built shared library in Debian binary package
by Robert McDonald Feb. 7, 2011

Feb. 7, 2011

I've got a Debian binary package configured. A wrapper script is installed in /usr/bin that invokes wine on the winegcc-built shared library that implements the program. The shared library is installed in /usr/lib and then ldconfig is run during the installation process. The shared library build product seems to be a special case because it is built by winegcc and referenced on the wine command line when run. I've got questions about this even though the product works OK as packaged. Is there a more appropriate installation directory than /usr/lib for the shared library (although lintian complains if I don't put it in /usr/lib)? Does ldconfig need to be run after installing/uninstalling the shared library (other than to satisfy lintian complaints if ldconfig isn't run from postinst/postrm)? Is there any reason to bother with version numbering the shared library (other than using one version number for all library releases just to keep lintian happy by having the version number) since the library is prepared by winegcc and will only be loaded by wine? To look for answers, I've done the following: * searched the web * searched the WineHQ web site and read the FAQ there * scanned the subject lines of a couple of months of this mailing list * read http://wiki.winehq.org/Packaging * used https://wiki.ubuntu.com/PackagingGuide/Complete for some packaging instructions * read http://www.bytehold.com/index.php/projects/176-debian-binary-package-and-re… for general instructions in setting up a Debian binary package * read http://www.pathname.com/fhs/ for recommendations on locating files URLs to relevant resources would be welcome. -- Robert McDonald BitTorrent, Inc.

2 1

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases.
by André Hentschel Feb. 7, 2011

Feb. 7, 2011

Hi, in todo_wine blocks only ok() calls should be made. So consider splitting them down to "todo_wine ok(..." for each. > -CancelIPChangeNotify > CreateProxyArpEntry > DeleteIPAddress > DeleteProxyArpEntry > EnableRouter > FlushIpNetTable > GetAdapterIndex > -NotifyAddrChange > -NotifyRouteChange > +NotifyRouteChange + CancelIPChangeNotify this change regarding CancelIPChangeNotify is also not needed. -- Best Regards, André Hentschel

2 1

Re: oleaut32: Fix copying an array of 0 elements
by Marvin Feb. 7, 2011

Feb. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8987 Your paranoid android. === WNT4WSSP6 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W2KPROSP4 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === WXPPROSP3 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W2K3R2SESP2 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === WVISTAADM (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W2K8SE (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W7PRO (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W7PROX64 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W7PROX64 (64 bit safearray) === Timeout

1 0

Patch to fix ntdll:exception tests on Mac OS
by Charles Davis Feb. 7, 2011

Feb. 7, 2011

Hi, This is a small patch I wrote to fix the exception tests on Mac OS X. Right now, if you look at the Mac results I submitted, you'll notice that there are two failures. The first failure happens because Mach doesn't allow the 'global' flag to be set when setting the debug registers. Changing the test not to set the global flag causes the test to pass. I get the feeling, though, that there is a good reason the global flag was set, so I'm reluctant to send that change in. The other failure happens because 32-bit Mac OS only protects stacks from execution. If you clear PROT_EXEC on any other data, you can still execute code from it. (64-bit Mac OS, on the other hand, always respects the PROT_EXEC flag.) I changed ntdll on 32-bit Mac OS to report DEP as permanently disabled, but I wonder if this was the right change to make. I just want to know: am I doing the right thing here? If not, what should I do instead to fix the tests? Chip

1 0

Re: user32: Don't try to move mouse to (-1,0).
by Vitaliy Margolen Feb. 6, 2011

Feb. 6, 2011

On 02/05/2011 07:10 AM, Jacek Caban wrote: > > This trigers screen edge action on KDE, which is 'Present Windows' in > default configuration. mouse_event() generates relative mouse movement events unless MOUSEEVENTF_ABSOLUTE is specified. If you don't want a pointer to get near the edge then you should use SetCursorPos() instead. Vitaliy.

2 1

re: Wine FAQ edits
by Dan Kegel Feb. 6, 2011

Feb. 6, 2011

Hi Albert, http://wiki.winehq.org/FAQ?action=diff&rev2=384&rev1=383 looks like it was a pretty big edit. Try smaller ones, and try to do just one kind of change per edit.

7 20

re: Pulling Patch
by Dan Kegel Feb. 6, 2011

Feb. 6, 2011

James McKenzie wrote: > Since my Mac is dying I have decided to return to the Windows world. > > Please pull any and all patches. I have envoked the right to copyright > and none of my code can or will be used in Wine. Sorry to see you go, but... why would you want to prohibit people from using your patches? (I only see two typo changes committed: http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=James+Mc… Presumably you don't mean those, since they were trivial comment changes.) I guess you mean patches like http://www.winehq.org/pipermail/wine-patches/2010-June/089537.html When you sent those to wine-patches, weren't you placing them under the LGPL? - Dan

4 5

RE: shell32/tests: Clean make new folder test (Valgrind)
by Michael Mc Donnell Feb. 5, 2011

Feb. 5, 2011

Hi! What is the reason this patch by Nikolay Sivov was not included in the latest version of wine? It fixes a clean-up bug on some Windows XP machines, and tidies up the code nicely. Wine-patches archive link: http://www.winehq.org/pipermail/wine-patches/2011-January/098342.html Regards, Michael Mc Donnell P.S. Thanks Nikolay for fixing my first win32 test.

1 0

Re: user32: Don't try to move mouse to (-1,0).
by Marvin Feb. 5, 2011

Feb. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8925 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Pulling Patch
by James McKenzie Feb. 5, 2011

Feb. 5, 2011

Since my Mac is dying I have decided to return to the Windows world. Please pull any and all patches. I have envoked the right to copyright and none of my code can or will be used in Wine. Thank you. James McKenzie

2 1

Re: winspool.drv: make sure to use return values (LLVM/Clang)
by Marvin Feb. 5, 2011

Feb. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8921 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Wine API documentation questions.
by Max TenEyck Woodbury Feb. 5, 2011

Feb. 5, 2011

I've been going through the Wine API documentation and there seem to be some things that I think should be changed: - There are references to Wine documents that do not include links to the pages. The links should be included. - Some 'implementation' sections claim that the API is not declared but there are declarations, just not in headers that 'c2man' is looking at. It should also look in any sub-directories (except for 'tests') of the '-I' directories it is told about for additional headers. (I have very little skill with Perl at present, so someone else might be able to add this much faster than I will be able to do it.) - There are quite a few APIs implemented but without standard documentation. All accessible APIs should have enough documentation so that there is a page for it, even if it is only a synopsis. - Mangled interface names only appear in their mangled form. The documentation should include the demangled name as well. Should the demangled names also appear in the indexes? - The 'synopsis' does not include needed '#include' directives. This may need to be fixed in each API description rather than trying to get 'c2man' to generate it. - The name of the file containing the implementation is included in each 'implementation' section and includes a link to the appropriate repository source entry. The name of the appropriate header is also included, but does not include a link. A link should be included. Max

1 0

Re: kernel32/process: Add stderr redirection for native linux programs started from windows program
by Austin English Feb. 5, 2011

Feb. 5, 2011

On Fri, Feb 4, 2011 at 18:22, Igor Egorov <atohom(a)gmail.com> wrote: > This is my first patch, not sure if I done all right. I didn't look at the actual change, but: > mode change 100644 => 100755 dlls/kernel32/process.c doesn't seem necessary to me. -- -Austin

2 1

Re: gdi32/tests: make sure to use return value (LLVM/Clang)
by Marvin Feb. 5, 2011

Feb. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8891 Your paranoid android. === WVISTAADM (32 bit font) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Tray icon not showing up if wine was run previously with DISPLAY unset?
by Dan Kegel Feb. 4, 2011

Feb. 4, 2011

So, I've got this shell script that does something like h=`wine winepath -w $HOME` ... wine autohotkey run-setup.ahk Works great. However, if the user has selected to run wine in a virtual desktop, running winepath will start up and then shut down the virtual desktop, which is visually annoying. Second try: unset DISPLAY when running winepath, e.g. h=`DISPLAY= wine winepath -w $HOME` ... wine autohotkey run-setup.ahk Works great; now winepath doesn't pop up the desktop. Except now autohotkey's tray icon doesn't show up at all, which makes it hard to debug the autohotkey script. (The setup that autohotkey runs can access X just fine, so the problem seems confined to the tray icon.) Is the lack of tray icon a wine bug, or a user error? Third try: wait for wineserver to exit before starting autohotkey h=`DISPLAY= wine winepath -w $HOME` ... wineserver -w wine autohotkey run-setup.ahk but that's slower, and will hang if the user is running a wine app. I guess I could do "sleep 5" but that's an awful kludge. Probably I'll go back to letting the ugly virtual desktop pop up. So, what's the proper way to run one app under wine *without* X while letting other apps run wine *with* X? - Dan

2 1

Re: loader: Build the preloader for ARM
by Alexandre Julliard Feb. 4, 2011

Feb. 4, 2011

André Hentschel <nerv(a)dawncrow.de> writes: > +unsigned int wld_modulo( const unsigned int a, const Elf32_Word b ) > +{ > +#ifdef __ARM_EABI__ > + unsigned int i; > + if(b > a) return a; > + for(i = 0; i * b < a + b; i++) > + if(i * b > a - b) return (a - i * b); > + return 0; That's very inefficient, there are better ways... -- Alexandre Julliard julliard(a)winehq.org

4 5

the patches around ok()
by Joris Huizer Feb. 4, 2011

Feb. 4, 2011

Hello Henri Verbeet, and André Hentschel I wasn't (actively) on the mailing list, that's why I couldn't reply directly to your messages. I will try and make sure I have better titles for such patches in future! Regards, Joris

2 1

Re: kernel32/tests/thread.c: Don't call in ok()
by Henri Verbeet Feb. 4, 2011

Feb. 4, 2011

On 4 February 2011 17:15, Joris Huizer <joris_huizer(a)yahoo.com> wrote: > Subject: kernel32/tests/thread.c: Don't call in ok() Why not?

2 1

Try to Implement my first Stub function - AbortPrinter().
by Loïc Maury Feb. 4, 2011

Feb. 4, 2011

Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document spool file for a printer, created by StartDocPrinter(), who indicate that a document was spooled. I saw that the API printer functions are in dlls/winspool.drv/info.c I understood that there are 4 structures used, *opened_printer_t* for manage a printer, *jobqueue_t* for a list of job for a printer, *started_doc_t* who manage a document, and *job_t* for manage a job. I am on Mac Os 10.6, with CUPS. Here is the code, what do you think ? BOOL WINAPI AbortPrinter(HANDLE hPrinter) { PRINTER_INFO_5W *pi5 = NULL; BOOL ret = FALSE; opened_printer_t *printer; struct list *cursor, *cursor2; job_t *job = 0; DWORD jobDocId; DWORD needed; LPWSTR portname; #if defined(__APPLE__) EnterCriticalSection(&printer_handles_cs); printer = get_opened_printer(hPrinter); if(!printer) { ERR("The handle for the printer is invalid.\n"); SetLastError(ERROR_INVALID_HANDLE); goto end; } TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name) ,debugstr_w(printer->printername) ,printer->backend_printer ,printer->queue->ref ,list_count(&printer->queue->jobs)); /* No jobs to manage. */ if(list_count(&printer->queue->jobs) == 0) { ERR("No job in the list.\n"); SetLastError(ERROR_SPL_NO_STARTDOC); goto end; } if(printer->doc) { TRACE("Document inside for job id : %d\n", printer->doc->job_id); jobDocId = printer->doc->job_id; } else { ERR("No document.\n"); SetLastError(ERROR_SPL_NO_STARTDOC); goto end; } /* For each jobs, get the job document in the double linked list */ LIST_FOR_EACH_SAFE(cursor, cursor2, &printer->queue->jobs) { /* Take a job. */ job = LIST_ENTRY(cursor, job_t, entry); TRACE("(job id : %d, filename : %s, portname : %s, document title : %s, printer name %s)\n",job->job_id ,debugstr_w(job->filename) ,debugstr_w(job->portname) ,debugstr_w(job->document_title) ,debugstr_w(job->printer_name)); if(jobDocId == job->job_id) { TRACE("(hf : %p, job id : %d)\n",printer->doc->hf ,printer->doc->job_id); /* Get portname. */ if (!job->portname) { GetPrinterW(hPrinter, 5, NULL, 0, &needed); pi5 = HeapAlloc(GetProcessHeap(), 0, needed); GetPrinterW(hPrinter, 5, (LPBYTE)pi5, needed, &needed); portname = pi5->pPortName; } TRACE("portname : %s\n", debugstr_w(portname)); /* Cups Port */ if(!strncmpW(portname, CUPS_Port, strlenW(CUPS_Port))) { TRACE("Remove job from the list.\n"); list_remove(cursor); CloseHandle(printer->doc->hf); DeleteFileW(job->filename); HeapFree(GetProcessHeap(), 0, job->document_title); HeapFree(GetProcessHeap(), 0, job->printer_name); HeapFree(GetProcessHeap(), 0, job->portname); HeapFree(GetProcessHeap(), 0, job->filename); HeapFree(GetProcessHeap(), 0, job->devmode); HeapFree(GetProcessHeap(), 0, job); job = 0; ret = TRUE; if(pi5) HeapFree(GetProcessHeap(), 0, pi5); } else FIXME("only CUPS for now.\n"); } } end: LeaveCriticalSection(&printer_handles_cs); TRACE("return %d\n", ret); return ret; #else TRACE("Only CUPS for Mac Os is managed for now.\n"); return FALSE; #endif } Merci Loïc

4 4

Re: msvcr90: Fixed a typo
by Nikolay Sivov Feb. 4, 2011

Feb. 4, 2011

On 2/4/2011 18:33, André Hentschel wrote: > --- > dlls/msvcr90/msvcr90.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msvcr90/msvcr90.c b/dlls/msvcr90/msvcr90.c > index 2c811cb..d2a61dd 100644 > --- a/dlls/msvcr90/msvcr90.c > +++ b/dlls/msvcr90/msvcr90.c > @@ -315,7 +315,7 @@ const char * __thiscall MSVCRT_type_info_name_internal_method(type_info * _this, > if (!_this->name) > { > /* Create and set the demangled name */ > - /* Nota: mangled name in type_info struct always start with a '.', while > + /* Note: mangled name in type_info struct always start with a '.', while > * it isn't valid for mangled name. > * Is this '.' really part of the mangled name, or has it some other meaning ? > */ Maybe 'starts with' ?

2 1

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent.
by Alexandre Julliard Feb. 4, 2011

Feb. 4, 2011

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + SetLastError(0xdeadbeef); > +todo_wine > + ok(SetForegroundWindow(popup), "SetForegroundWindow() error %d\n", GetLastError()); It would be interesting to test what the foreground window is actually set to. > + SetLastError(0xdeadbeef); > + ok(DestroyWindow(parent), "DestroyWindow() error %d\n", GetLastError()); Please don't add invalid uses of GetLastError again, this was cleaned up recently. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent.
by Joris Huizer Feb. 4, 2011

Feb. 4, 2011

Hello Dmitry Timoshkov, I noticed a small issue in your patch: > > - ret = DestroyWindow(parent); > - ok( ret, "DestroyWindow() error %d\n", > GetLastError()); > + ok(DestroyWindow(parent), "DestroyWindow() > error %d\n", GetLastError()); Please don't merge the call with the ok() statement; the GetLastError() call might be executed before the function to be tested, thus giving the old value. (There has been some cleaning up for this issue recently) The same goes for a few tests you added: > + SetLastError(0xdeadbeef); > + ok(SetForegroundWindow(popup), > "SetForegroundWindow() error %d\n", GetLastError()); > + SetLastError(0xdeadbeef); > +todo_wine > + ok(SetForegroundWindow(popup), > "SetForegroundWindow() error %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ok(DestroyWindow(parent), "DestroyWindow() > error %d\n", GetLastError()); > + HTH, Joris

2 1

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen Feb. 4, 2011

Feb. 4, 2011

> > It doesn't need a try-except block, just better wrap-around handling. > Ah, you mean to enhance the if-check? Well..., to me it seems that there is a problem with the 2nd check: "(void *)(frame + 1) >= NtCurrentTeb()->Tib.StackBase" If frame is 0xffffffff or close to it (e.g. 0xfffffffc), adding 1 to its address makes it overflow and the left side becomes 0x3, or 0x0 in 0xfffffffc's case. And that would make the check fail. I would propose that this would be corrected with an additional overflow check. There are two 4 byte values that needs to be read: next frame address and return address. So, it would be checked that address of last byte of return address (frame + 7 bytes) is not smaller than current frame address, right? The if-check would then be as follows: if (((void *)frame < NtCurrentTeb()->Tib.StackLimit) || ((void *)(frame + 1) >= NtCurrentTeb()->Tib.StackBase) || ((ULONG_PTR)frame & 3) || ((ULONG)((char *)frame + 7) < (ULONG)frame)) ... I'm not quite sure if casting pointers to ULONG for comparison is wise move, but can't think anything else for that. Do you think there is any problems with this approach? Other alternative could be to just simply check if the frame pointer equals to 0xfffffffc, that, combined with "(ULONG_PTR)frame & 3" should handle all cases near 0xffffffff. Best Regards, Janne

2 3

Re: wined3d/arb_program_shader: Small optimization in state_texfactor_arbfp().
by Stefan Dösinger Feb. 4, 2011

Feb. 4, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 03.02.2011 um 23:01 schrieb Adam Martinson: > > Oddly enough this gives us an average 1.8% boost in the 3DMark06 batch size tests. Impressive. One more thing you could investigate(but that doesn't affect this patch): Try to figure out why this code is called in the first place. The only situation when this should happen is if the app is using fixed function fragment processing. I wouldn't expect that 3Dmark06 does that. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNS8aYAAoJEN0/YqbEcdMwI1AQAJder+8LZILzdT+8tA2YiwZ+ ZEVOi4S2voFASHUVJbYuWIXkzzVu6fQlZXw/KCyvdQaslpTWQFFc/cOMXcCVjVs5 puJJDydjCyI8FZF7ec8dCIjCHqBH4S91kxDjRmWGifdp1Qd6h/f7o1xyhOHG62xG XZbY1xx3DhQ7lRxRtsdqqq22MM5cOqR4mCen2YPGsd04rlwsxW6zuxZ32oBof0rO ggzBW1F2WdDHeT6rcDK5Iv7R4zdSCtl6IXfsMaT1frTcd8Mo/9jLj7GaLMnQ/UtG JkyQbCP59AOtEKU8nwrISn71YMRkCBHOttaIAVhr6Nq02eNmcxWomSbIsb293LzP fQHFDPJ2aO161AimO/7Nk6DbGniUtlgRGhPhrK+YJvrAhftrtZ2gFUaN3QLJgcKA HHhkU00NsBXOJvz8YuGFDRVmpPpCLcGM7gvMIyjYy3x3W1FWO4giNxnj6CxqHmLs ohkAbsLEnJohhpTyVEaQKTG0Zq49s5WcvkjQbmncqKdP2D9NHmi50FI8MbJJxXAu mMW6sA6oExn31Fnm1/pQOWCZk8hidK1hRN7f25nSRa58q7bSvNT/Gw3kk6S8T5CU yL3r5UIb64ss4QmtXY8SPIR9IDNvmnYUX4/Av/iKpZrSRHCHzpYX7Eecp2jdV/ta jgKpR4VaDyemyij093oW =LXas -----END PGP SIGNATURE-----

1 1

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (resend)
by Paul Vriens Feb. 4, 2011

Feb. 4, 2011

On 02/04/2011 09:32 AM, Austin English wrote: > - ret = funcs->pfnObjectTrust(&data); > + funcs->pfnObjectTrust(&data); > + ok(ret == S_FALSE, "Expected S_FALSE, got %08x\n", ret); This doesn't look correct (you are removing the assignment and then check it). I know that this code path will never be taken, but still. -- Cheers, Paul.

2 1

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (1/4)
by Juan Lang Feb. 4, 2011

Feb. 4, 2011

Hey Austin, + ok(ret == S_FALSE, "Expected S_OK, got %08x\n", ret); Copy/pasto. --Juan

2 1

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (3/4)
by Juan Lang Feb. 4, 2011

Feb. 4, 2011

Hey Austin, ok(ret, "WintrustSetRegPolicyFlags failed: %d\n", GetLastError()); size = sizeof(flags1); r = RegQueryValueExA(key, State, NULL, NULL, (LPBYTE)&flags1, &size); - ok(flags1 == flags3, "Got %08x flags instead of %08x\n", flags1, flags3); + ok(!r || r == ERROR_FILE_NOT_FOUND, "RegQueryValueEx failed: %d\n", r); + if (!r) + ok(flags1 == flags3, "Got %08x flags instead of %08x\n", flags1, flags3); It seems to me that the introduction of ERROR_FILE_NOT_FOUND weakens the test. (Testing r should be done, thanks for fixing that.) I assume that, since WintrustSetRegPolicyFlags should have succeeded, the registry value should now exist. Is there a test failure you're also trying to fix? Thanks, --Juan

2 1

updated LLVM/Clang static analysis results (and valgirind :-))
by Austin English Feb. 4, 2011

Feb. 4, 2011

Original results: Date: Thu Jan 20 22:59:57 2011 All Bugs 2922 Argument with 'nonnull' attribute passed null 99 Idempotent operation 154 Dead assignment 1464 Dead increment 155 Dead initialization 22 Array subscript is undefined 5 Assigned value is garbage or undefined 96 Branch condition evaluates to a garbage value 10 Called function pointer is null (null dereference) 6 Dereference of null pointer 757 Dereference of undefined pointer value 8 Division by zero 12 Function call argument is an uninitialized value 49 Garbage return value 9 Result of operation is garbage or undefined 74 Undefined allocation of 0 bytes 2 New results: All Bugs 2817 Argument with 'nonnull' attribute passed null 100 Idempotent operation 156 Dead assignment 1368 Dead increment 152 Dead initialization 22 Array subscript is undefined 4 Assigned value is garbage or undefined 96 Branch condition evaluates to a garbage value 9 Called function pointer is null (null dereference) 6 Dereference of null pointer 757 Dereference of undefined pointer value 8 Division by zero 12 Function call argument is an uninitialized value 46 Garbage return value 7 Result of operation is garbage or undefined 72 Undefined allocation of 0 bytes 2 Available at: http://austinenglish.com/logs/clang_analyzer/index.html and valgrind logs: http://austinenglish.com/logs/valgrind/ if you've looked at valgrind logs and see errors that should be suppressed, please email me and I'll add them. Cheers, Austin

1 0

Re: Re: user32/tests: Test for behavior of WM_SETTEXT handler (try 2)
by Marvin Feb. 4, 2011

Feb. 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8839 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: Re: user32/tests: Test for behavior of WM_SETTEXT handler
by Marvin Feb. 4, 2011

Feb. 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8838 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg.c:5649: Test failed: WM_SETTEXT on a button: 3: the msg 0x0138 was expected, but got msg 0x8000 instead === W7PROX64 (64 bit msg) === Timeout

1 0

Re: RFC: Adding Mac support to secur32/schannel.c
by James Mckenzie Feb. 3, 2011

Feb. 3, 2011

Juan Lang <juan.lang(a)gmail.com> wrote: I'll make this quick and address a comment here from Juan from the viewpoint of someone building Wine from scratch using one of the porting services: Fink. > >Besides, I'm still not convinced that GnuTLS on the Mac is such an >onerous problem. This is not just a Codeweavers' problem but a problem that: 1. MacOSX provides native TLS support. 2. Building ANYTHING Unix'y on a Mac may require 'hacky' patches to get around some of the code issues. Both of the known UNIX to MacOSX porting projects provide GnuTLS but have to patch it to build and work on MacOSX without stepping on the existing capabilities. Interfacing the existing TLS capabilities to appear as the GNU product may be a solution to this. I tend to agree with Ken Thomases for MacOSX we should be using the native code vice adding a package that may not provide full TLS functionality and moving towards schannel functionality to the higher levels of code in Wine. Thank you for reading this. James McKenzie

4 5

Re: RFC: Adding Mac support to secur32/schannel.c
by James Mckenzie Feb. 3, 2011

Feb. 3, 2011

Charles Davis <cdavis(a)mymail.mines.edu> wrote: > >On 2/3/11 9:22 AM, James Mckenzie wrote: >> 2. Building ANYTHING Unix'y on a Mac may require 'hacky' patches to get around some of the code issues. Both of the >>known UNIX to MacOSX porting projects provide GnuTLS but have to patch it to build and work on MacOSX without stepping on >>the existing capabilities. >What are you talking about? MacPorts doesn't need patches for GnuTLS anymore. Looking at GnuTLS's Portfile, there are no >patch files pulled in and no reinplace (i.e. sed -ie) operations. It was my understanding that MacPorts did have them. I'll look at Fink tonight and see if there still is a patch file needed with the latest version. In any case, Mac users should be using build in functionality and as few as possible (none if possible) external 'Unix' add-on packages. For a while, they will be needed. >> I tend to agree with Ken Thomases for MacOSX we should be using the native code vice adding a package that may not provide full TLS functionality and moving towards schannel functionality to the higher levels of code in Wine. >I'm for that. In fact, my humble opinion is that Wine on Mac should only use libraries that are part of the OS (i.e. only >dylibs in /usr/lib and frameworks in /System/Library/Frameworks). There are a whole host of benefits, not the least of >which is that it makes binary distribution easier (to date, Mac OS is one of the few platforms that does not have >an official binary distribution) and it could potentially expand our user-base (since users would no longer have to have >MacPorts or Fink or Gentoo Prefix or use a third-party distro just to run Wine). +1 :) It would be a great thing if we did not have to have 'special' builds for MacOSX and we could send out either an installable package or a disk image as the project. James McKenzie > >We've got a long way to go in that department, unfortunately. :( > >Chip > >

1 0

RFC: Adding Mac support to secur32/schannel.c
by Ken Thomases Feb. 3, 2011

Feb. 3, 2011

Hi, I'm planning to add an alternative implementation of schannel (SSL/TLS) support for the Mac. The current implementation is based on GnuTLS. That library is not typically found on Mac OS X. Although packagers can build it and ship it and its dependencies with Wine for Mac OS X, I think it's better (especially for security-related functionality) to use the system-provided library. I'm attaching a patch. It is _not_ intended as a proposed commit. It's just a proof-of-concept that shows the direction that I'm going. I plan to introduce a new internal interface (the schan_imp_* stuff in my patch) and incrementally refactor the code to hide uses of GnuTLS behind that interface. Then, I'm thinking of breaking the GnuTLS implementation out into a separate module, schannel_gnutls.c. Then, I'd add a second implementation module, schannel_mac.c, based on the Mac Secure Transport API (as shown in the patch). Each of the two modules would be made "empty" by preprocessor conditionals, as appropriate. I'd appreciate a review of this general plan. Thanks, Ken

8 18

Re: user32/tests: Test for behavior of WM_SETTEXT handler
by Alexandre Julliard Feb. 3, 2011

Feb. 3, 2011

Alexander LAW <exclusion(a)gmail.com> writes: > + { WM_CTLCOLORSTATIC, sent|parent|optional}, /*Windows sends it, Wine doesn't*/ > + { WM_CTLCOLORSTATIC, sent|parent|optional}, /*Windows sends it, Wine doesn't*/ > + { WM_APP, sent|wparam|lparam, 0, 0 }, > + { WM_PAINT, sent }, > + { WM_NCPAINT, sent|defwinproc|optional }, /* FIXME: Wine sends it */ You can't add 'optional' to hide Wine bugs; if the message is sent on Windows it should be a todo_wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: gdi32: Upper 24 bits of a character range must be same.
by Greg Geldorp Feb. 3, 2011

Feb. 3, 2011

Hi, I'm sure you've noticed that this change causes some failures on a Simplified Chinese-language test machine, see http://test.winehq.org/data/5ae2b0f219cb5aed2bdf32746a57a699a32767a2/xp_wtb… Can you take a look at that please? I'm wondering if it wouldn't make more sense to use GetCharABCWidthsW instead of the Ansi version for this test? Thanks, Greg.

2 1

Re: msvcrt: Partially implement type_info::name_internal_method()
by Alexandre Julliard Feb. 3, 2011

Feb. 3, 2011

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -260,3 +307,24 @@ int CDECL _atoflt( _CRT_FLOAT *value, char *str ) > { > return _atoflt_l( value, str, NULL ); > } > + > +/********************************************************************* > + * ?_name_internal_method(a)type_info@@QBEPBDPAU__type_info_node@@@Z (MSVCR90.@) > + */ > +DEFINE_THISCALL_WRAPPER(MSVCRT_type_info_name_internal_method,8) > +const char * __thiscall MSVCRT_type_info_name_internal_method(type_info * _this, struct __type_info_node *node) > +{ > + /* this is a forward to type_info::name() */ > +#ifdef __i386__ > + static const char *typeinfo_name = "?name(a)type_info@@QBEPBDXZ"; > + void* (WINAPI *p)(void*); > +#else > + static const char typeinfo_name[] = "?name(a)type_info@@QEBAPEBDXZ"; > + void* (__cdecl *p)(void*); > +#endif > + static int once; > + > + if (node && !once++) FIXME("type_info_node parameter ignored\n"); > + p = (void*)GetProcAddress(GetModuleHandleA("msvcrt.dll"), typeinfo_name); > + return call_func1(p, _this); > +} I think it would be better to duplicate the implementation after all. Sorry for misleading you with the GetProcAddress suggestion, I hadn't realized that it would require the thiscall mess. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.
by Henri Verbeet Feb. 3, 2011

Feb. 3, 2011

On 3 February 2011 01:00, Tobias Jakobi <liquid.acid(a)gmx.net> wrote: > *bumping* > > This patch never went into master, although it's _very_ important. Wine > users see a lot of D3D problems (mostly missing textures) since mesa drivers > don't support s3tc "out-of-the-box" (libtxc_dxtn needs to be available). > This leads to a lot of 'false' bug reports, which are in fact driver issues. > > Requesting to finally push this to master. > I'm not entirely sure on how to do this properly. Making it an ERR would be too loud for applications that never use s3tc textures, as a WARN it's never going to be seen unless you look at the debug channel. Printing a message in wined3d in CreateSurface() would probably work, but the resulting check would end up being pretty ugly because we'd have to check 5 different formats. You can't do much more than a WARN for a generic check either, because some formats may be legitimately missing / unimplemented. Note that the situation with floating point formats isn't much better.

2 1

Re: wined3d: Update clip planes when switching to/from offscreen rendering.
by Stefan Dösinger Feb. 2, 2011

Feb. 2, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 31.01.2011 um 15:13 schrieb Matteo Bruni: > It should fix http://bugs.winehq.org/show_bug.cgi?id=25877 > <0001-wined3d-Update-clip-planes-when-switching-to-from-offs.txt> If we change the shader code to write gl_ClipVertex and result.clip before applying the y inversion then we should be able to avoid this. That should also make it more compatible to fixed function vertex processing - here the clipping is performed before the projection matrix is applied. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNRssNAAoJEN0/YqbEcdMwZv8P+wbbhcamRsg42fMzJ02jKLcT s4p19OqKPZEdVvzsfQCe4e7KGgGdZUefMWsY2ib9AK21cQXB3R9fnyl5TMDcuxuh EojJvAQCVd/hgnz7tserUJT6rS/W08BPsdHM4dgxdnhRTzi2FAc7l3NgFOONJXpG i8HfcmD2AgaGOam6Wriv3SD8fM0zrfmpZdJDH1moCefqptEEWD9adwWRSMhaMvTl rlj1gDR9cRC9fsxur2U1f5NuXN0AY+a+5VPQHElZV2bP9ulheoa9nYuXU+8F7OhK RyIJ2DO4vpaLpEbXW/amtUWnlBSk0n7k3F9w/fcthOmUvlPHOBY7i2Ukf4j84vQD AhpN7Yf4cFZaSV8q/gww+U9H1udelidiTEL05OKQJUohnM1F9/cRnXbXmmA5Nuia rQlcCnm12cw1ClykdrY7B/hDCqGOPnnmPp580kW1LlEtidYyGbG35seyHxNqcNcQ RWlvVsGwvlzgex7qWf9hT34KOcUzMKZdlehfvtQn0Fjrcf+/3s5EvrtG4Mw6qHNh aBFNaeB8LkV36hu71r/1yxsqHO+taYt1/Ho8poANYbOplV9FCpd0nXeK8n7rqCPx L5TVgSJVd4n354FlguuIUAiFlXxcxFN2CJlN2Hd4dwhZZhGBh+4LH+XhjUtzX4ge 15usBq4VUhhssvv6dVys =urcm -----END PGP SIGNATURE-----

3 5

Wine FAQ edits
by Albert Lee Feb. 2, 2011

Feb. 2, 2011

Hi Vitaliy, I notice you have reverted my edits to the FAQ on the wiki ( http://wiki.winehq.org/FAQ?action=info ). As I was trying to clarify the shell metacharacter information and operating system/platform support, and add new file association instructions, I would like to know why this happened and what changes should be done. -Albert

2 3

re: ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Dan Kegel Feb. 2, 2011

Feb. 2, 2011

Qian wrote: >1. If a function is implemented in wine dll as a stup, then usually >this function won't cause crash, >and the wine debug will output "fix:me ...stup" rather then >"Unimplemented function", is it right? I think "stub" is somewhat ambiguous, it can mean either something without an implementation, or something with a very minimal implementation. But yes, if something is listed in dlls/*/*.spec as a stub, you get 'Unimplemented function', and if something is listed in grep FIXME.*stub dlls/*/*.c as a stub, you get "fixme: ... stub". >2. If a function is listed in the Wine API guide, >http://source.winehq.org/WineAPI/ , and marked as stup, >then this function must be implemented as a stup in wine source code, >is it right? The Wine API guide is not a very reliable guide, it might be out of date. Better to just look in the source code. - Dan

2 1

Re: crypt32: Fix quoting-behaviour
by Juan Lang Feb. 1, 2011

Feb. 1, 2011

Hi Christian, I'm afraid this patch is incorrect. In particular, - chars = CertRDNValueToStrA( - rdn->rgRDNAttr[j].dwValueType, - &rdn->rgRDNAttr[j].Value, psz ? psz + ret : NULL, - psz ? csz - ret : 0); + if ((dwStrType & 0x000000ff) == CERT_X500_NAME_STR) + chars = quote_string_a( + rdn->rgRDNAttr[j].dwValueType, + &rdn->rgRDNAttr[j].Value, psz ? psz + ret : NULL, + psz ? csz - ret : 0); + else + chars = CertRDNValueToStrA( + rdn->rgRDNAttr[j].dwValueType, + &rdn->rgRDNAttr[j].Value, psz ? psz + ret : NULL, + psz ? csz - ret : 0); This change (and the corresponding one to CertNameToStrW) is incorrect. I tested a couple of strings with CERT_SIMPLE_NAME_STR, and they are also quoted. I can try to take these over if you like, or you can continue to work on them. Let me know what you prefer. --Juan

1 0

Re: [dlls/shdocvw] Initialize variable (Coverity)
by Nikolay Sivov Feb. 1, 2011

Feb. 1, 2011

On 2/1/2011 17:14, Paul Vriens wrote: > Hi, > > Addresses Coverity #1090. > > If CoCreateInstance() fails we check the uninitialized urlfile variable. Same story with urlobj. In fact it looks better to try CoCreateInstance first, before anything else like lstrcpy and just return earlier on failure.

2 2

Re: gdiplus: C++ fixes for headers
by Paul Chitescu Feb. 1, 2011

Feb. 1, 2011

On Tuesday 01 February 2011 09:49:46 am Iain Arnell wrote: > To fix inclusion of gdiplus.h under C++, this patch: > * adds missing class declaration for GpPen > * adds missing class declaration for CharacterRange > * fixes PenAlignment/GpPenAlignment declaration > * avoids redeclaration of PixelFormat > > Simple testcase: > > cat >test.cpp <<EOF > #include <windows.h> > #include <gdiplus.h> > EOF > wineg++ -c test.cpp > --- > include/gdiplusenums.h | 2 +- > include/gdiplusgpstubs.h | 2 ++ > include/gdiplusimaging.h | 4 ++-- > include/gdiplustypes.h | 25 +++++++++++++++++++++++++ > 4 files changed, 30 insertions(+), 3 deletions(-) > > diff --git a/include/gdiplusenums.h b/include/gdiplusenums.h > index 82f20eb..dc03b29 100644 > --- a/include/gdiplusenums.h > +++ b/include/gdiplusenums.h > @@ -734,7 +734,7 @@ typedef enum StringTrimming StringTrimming; > typedef enum FontStyle FontStyle; > typedef enum StringFormatFlags StringFormatFlags; > typedef enum HotkeyPrefix HotkeyPrefix; > -typedef enum PenAlignment GpPenAlignment; > +typedef enum PenAlignment PenAlignment; > typedef enum PaletteFlags PaletteFlags; > typedef enum ImageCodecFlags ImageCodecFlags; > typedef enum CombineMode CombineMode; > diff --git a/include/gdiplusgpstubs.h b/include/gdiplusgpstubs.h > index 3edc1f4..5a65cd8 100644 > --- a/include/gdiplusgpstubs.h > +++ b/include/gdiplusgpstubs.h > @@ -22,6 +22,7 @@ > #ifdef __cplusplus > > class GpGraphics {}; > +class GpPen {}; > class GpBrush {}; > class GpHatch : public GpBrush {}; > class GpSolidFill : public GpBrush {}; > @@ -92,6 +93,7 @@ typedef WrapMode GpWrapMode; > typedef Color GpColor; > typedef FlushIntention GpFlushIntention; > typedef CoordinateSpace GpCoordinateSpace; > +typedef PenAlignment GpPenAlignment; > typedef PenType GpPenType; > > #endif > diff --git a/include/gdiplusimaging.h b/include/gdiplusimaging.h > index 42a00cb..3e9f6ee 100644 > --- a/include/gdiplusimaging.h > +++ b/include/gdiplusimaging.h > @@ -110,7 +110,7 @@ public: > UINT Width; > UINT Height; > INT Stride; > - PixelFormat PixelFormat; > + INT PixelFormat; /* MSDN: "PixelFormat PixelFormat;" */ > VOID* Scan0; > UINT_PTR Reserved; > }; > @@ -177,7 +177,7 @@ typedef struct BitmapData > UINT Width; > UINT Height; > INT Stride; > - PixelFormat PixelFormat; > + INT PixelFormat; /* MSDN: "PixelFormat PixelFormat;" */ > VOID* Scan0; > UINT_PTR Reserved; /* undocumented: stores the lock mode */ > } BitmapData; > diff --git a/include/gdiplustypes.h b/include/gdiplustypes.h > index 4f97432..b84c74e 100644 > --- a/include/gdiplustypes.h > +++ b/include/gdiplustypes.h > @@ -199,6 +199,31 @@ public: > INT Height; > }; > > +class CharacterRange > +{ > +public: > + CharacterRange() > + { > + First = Length = 0; > + } > + > + CharacterRange(IN INT first, IN INT length) > + { > + First = first; > + Length = length; > + } > + > + CharacterRange& operator=(IN const CharacterRange& rhs) > + { > + First = rhs.First; > + Length = rhs.Length; > + return *this; > + } > +public: > + INT First; > + INT Length; > +}; > + > #else /* end of c++ typedefs */ > > typedef struct Point Wouldn't be better to wrap the offending C with: #ifdef __cplusplus extern "C" { #endif ... #ifdef __cplusplus } #endif

2 1

Re: programs: Add winemsibuilder.
by Joris Huizer Feb. 1, 2011

Feb. 1, 2011

While skimming through the new patches, I found: > +WCHAR *encode_stream( const WCHAR *in ) > +{ > + DWORD c, next, count; > + WCHAR *out, *p; > + > + count = strlenW( in ); > + if (count > MAX_STREAM_NAME) > + return NULL; > + > + count += 2; > + out = HeapAlloc( GetProcessHeap(), 0, count > * sizeof(WCHAR) ); > + p = out; You aren't checking for out-of-memory condition here. As you seem to cover all the other possible errors, I thought to let you know HTH, Joris

1 0

Re: [PATCH 1/5] shell32: Added SHCNRF_InterruptLevel flag support to SHChangeNotifyRegister
by Alexandre Julliard Feb. 1, 2011

Feb. 1, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > void InitChangeNotifications(void) > { > + watched_directories = 0; > + interrupts_server_terminate = CreateEventW(NULL, FALSE, FALSE, NULL); > + interrupts_server = CreateThread(NULL, 0, interrupts_server_thread, NULL, 0, NULL); > } This needs to be done on demand. You can't create a thread in every process on the off chance that it would use interrupt notifications. Probably you can use the thread pool for this. -- Alexandre Julliard julliard(a)winehq.org

1 0