February 2011 - Wine-Devel - list.winehq.org

Re: wintrust/tests: Fix a leak (valgrind)
by Marvin Feb. 16, 2011

Feb. 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9309 Your paranoid android. === W2K8SE (32 bit softpub) === softpub.c:742: Test failed: expected TRUST_E_NOSIGNATURE or CRYPT_E_FILE_ERROR, got 80092003

1 0

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)
by Alexandre Julliard Feb. 16, 2011

Feb. 16, 2011

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -381,9 +386,40 @@ static HRESULT WINAPI xslprocessor_Invoke( > static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) > { > xslprocessor *This = impl_from_IXSLProcessor( iface ); > + IXMLDOMNode *input_node; > + HRESULT hr; > > - FIXME("(%p): stub\n", This); > - return E_NOTIMPL; > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&input)); > + > + /* try IXMLDOMNode directly first */ > + if (V_VT(&input) == VT_UNKNOWN) > + hr = IUnknown_QueryInterface(V_UNKNOWN(&input), &IID_IXMLDOMNode, (void**)&input_node); > + else if (V_VT(&input) == VT_DISPATCH) > + hr = IDispatch_QueryInterface(V_DISPATCH(&input), &IID_IXMLDOMNode, (void**)&input_node); > + > + if (hr != S_OK) You need to handle the default case somehow. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)
by Joris Huizer Feb. 16, 2011

Feb. 16, 2011

Hello, I think I found a (possible) little issue in the patch: If one would pass a VARIANT of incorrect type to the xslprocessor_put_input() function (say type BSTR), the first type checks fail and leave hr uninitialised; in case it happened to have the value S_OK the other if block is skipped - assigning the uninitialised input_node; static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) { xslprocessor *This = impl_from_IXSLProcessor( iface ); + IXMLDOMNode *input_node; + HRESULT hr; (assume hr happens to be S_OK) - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + TRACE("(%p)->(%s)\n", This, debugstr_variant(&input)); + + /* try IXMLDOMNode directly first */ + if (V_VT(&input) == VT_UNKNOWN) + hr = IUnknown_QueryInterface(V_UNKNOWN(&input), &IID_IXMLDOMNode, (void**)&input_node); + else if (V_VT(&input) == VT_DISPATCH) + hr = IDispatch_QueryInterface(V_DISPATCH(&input), &IID_IXMLDOMNode, (void**)&input_node); (both false) + + if (hr != S_OK) + { //... + } (skipped) + + if (hr == S_OK) + { + if (This->input) IXMLDOMNode_Release(This->input); + This->input = input_node; + } (executed, assigning garbage to This->input) + + return hr; } HTH, Joris

1 0

Re: gameux/gamestatistics.c: Make sure each VARIANT is cleared after use (valgrind)
by Alexandre Julliard Feb. 16, 2011

Feb. 16, 2011

Joris Huizer <joris_huizer(a)yahoo.com> writes: > @@ -511,24 +511,27 @@ static HRESULT GAMEUX_loadStatisticsFromFile(struct GAMEUX_STATS *data) > > if(SUCCEEDED(hr)) > { > - hr = IXMLDOMElement_getAttribute(categoryElement, bstrIndex, &vValue); > - if( hr == S_OK && V_VT(&vValue) != VT_BSTR) > + VARIANT categoryIndex, categoryName; > + hr = IXMLDOMElement_getAttribute(categoryElement, bstrIndex, &categoryIndex); > + if( hr == S_OK && V_VT(&categoryIndex) != VT_BSTR) > hr = E_FAIL; > > if(SUCCEEDED(hr)) > { > - i = StrToIntW(V_BSTR(&vValue)); > - hr = IXMLDOMElement_getAttribute(categoryElement, bstrName, &vValue); > - if( hr == S_OK && V_VT(&vValue) != VT_BSTR) > + i = StrToIntW(V_BSTR(&categoryIndex)); > + hr = IXMLDOMElement_getAttribute(categoryElement, bstrName, &categoryName); > + if( hr == S_OK && V_VT(&categoryName) != VT_BSTR) > hr = E_FAIL; > } > + VariantClear(&categoryIndex); You should only clear it when it has been successfully set. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine64 issues in dlls/msvcr90/tests/msvcr90.c
by Peter Urbanec Feb. 16, 2011

Feb. 16, 2011

As of a few days ago, I'm seeing the following errors when building wine64 with gcc (Gentoo 4.5.2 p1.0, pie-0.4.5) 4.5.2 dlls/msvcr90/tests/msvcr90.c:137:14: warning: 'do_call_func1' defined but not used dlls/msvcr90/tests/msvcr90.c:147:14: warning: 'do_call_func2' defined but not used dlls/msvcr90/tests/msvcr90.c: Assembler messages: dlls/msvcr90/tests/msvcr90.c:150: Error: invalid instruction suffix for `push' When building wine32, there seem to be no problems. Is anyone else seeing this when building wine64?

1 0

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)
by Jacek Caban Feb. 16, 2011

Feb. 16, 2011

On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: > Changelog: > mshtml: Ignore IActiveScript interface for IXMLHTTPRequest mshtml? + else if ( IsEqualGUID( riid,&IID_IActiveScript)) + { + TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n", This, ppvObject); + *ppvObject = NULL; + return E_NOINTERFACE; + } else { FIXME("Unsupported interface %s\n", debugstr_guid(riid)); As discussed on wine-devel, please just change the later FIXME to TRACE instead. Jacek

2 3

Re: comctl32/tests: Add two casts to avoid comparisons of different int types.
by Marvin Feb. 16, 2011

Feb. 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9229 Your paranoid android. === W7PROX64 (64 bit tab) === tab.c:1330: Test failed: got 69cc80, expected dededede

3 3

[PATCH] Implement software DXT1 compression
by alberto＠mattea.info Feb. 16, 2011

Feb. 16, 2011

This patch adds conversion functions from WINED3DFMT_B8G8R8_UNORM, WINED3DFMT_B5G5R5A1_UNORM and WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_DXT1. It uses code slighty modified from libtxc_dxtn. It fixes at least LEGO Stunt Rally, probably other games too. I didn't implement dxt3 and dxt5 since I haven't got any apps to test, but if someone has similar problems (black textures) with them and wants to test, let me know, and I will add them as well. I would also like some feedback about the patent situation, e.g. if the patch can be mainlined as it is or if it would be better to load libtxc_dxtn directly at runtime. Alberto

3 2

valgrind results - now with better debug info
by Austin English Feb. 15, 2011

Feb. 15, 2011

Howdy all, I've added a few more suppressions, and after a suggestion by Nikolay, added some debugging symbols: austin(a)debian:~/src/winezeug/valgrind$ dpkg -l | grep dbg ii cups-dbg 1.4.5-2 Common UNIX Printing System(tm) - debugging symbols ii libc6-dbg 2.11.2-11 Embedded GNU C Library: detached debugging symbols ii libgsm1-dbg 1.0.13-3 Shared libraries for GSM speech compressor (debug symbols) ii libsane-dbg 1.0.21-9 API development library for scanners [debug symbols] ii libsane-extras-dbg 1.0.21.2 API library for scanners -- extra backends [debug symbols] ii libxml2-dbg 2.7.8.dfsg-2 Debugging symbols for the GNOME XML library ii libxslt1-dbg 1.1.26-6 XSLT 1.0 processing library - debugging symbols ii zlib1g-dbg 1:1.2.3.4.dfsg-3 compression library - development if you need a debugging symbol package to get better info from a crash, please let me know. The current suppressions used are at: http://winezeug.googlecode.com/svn/trunk/valgrind/valgrind-suppressions Please let me know if you have more to add I've filed bugs for most results, see: http://bugs.winehq.org/buglist.cgi?query_format=advanced&emailreporter1=1&s… as always, results are at: http://austinenglish.com/logs/valgrind/ Cheers, Austin

1 0

Re: D3DXCreateTorus patch... thoughts?
by David Adam Feb. 15, 2011

Feb. 15, 2011

Here is cool link to show what D3DXCreateTorus does: http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip A+ David

2 1