February 2011 - Wine-Devel - list.winehq.org

Pulling Patch
by James McKenzie Feb. 5, 2011

Feb. 5, 2011

Since my Mac is dying I have decided to return to the Windows world. Please pull any and all patches. I have envoked the right to copyright and none of my code can or will be used in Wine. Thank you. James McKenzie

2 1

Re: winspool.drv: make sure to use return values (LLVM/Clang)
by Marvin Feb. 5, 2011

Feb. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8921 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Wine API documentation questions.
by Max TenEyck Woodbury Feb. 5, 2011

Feb. 5, 2011

I've been going through the Wine API documentation and there seem to be some things that I think should be changed: - There are references to Wine documents that do not include links to the pages. The links should be included. - Some 'implementation' sections claim that the API is not declared but there are declarations, just not in headers that 'c2man' is looking at. It should also look in any sub-directories (except for 'tests') of the '-I' directories it is told about for additional headers. (I have very little skill with Perl at present, so someone else might be able to add this much faster than I will be able to do it.) - There are quite a few APIs implemented but without standard documentation. All accessible APIs should have enough documentation so that there is a page for it, even if it is only a synopsis. - Mangled interface names only appear in their mangled form. The documentation should include the demangled name as well. Should the demangled names also appear in the indexes? - The 'synopsis' does not include needed '#include' directives. This may need to be fixed in each API description rather than trying to get 'c2man' to generate it. - The name of the file containing the implementation is included in each 'implementation' section and includes a link to the appropriate repository source entry. The name of the appropriate header is also included, but does not include a link. A link should be included. Max

1 0

Re: kernel32/process: Add stderr redirection for native linux programs started from windows program
by Austin English Feb. 5, 2011

Feb. 5, 2011

On Fri, Feb 4, 2011 at 18:22, Igor Egorov <atohom(a)gmail.com> wrote: > This is my first patch, not sure if I done all right. I didn't look at the actual change, but: > mode change 100644 => 100755 dlls/kernel32/process.c doesn't seem necessary to me. -- -Austin

2 1

Re: gdi32/tests: make sure to use return value (LLVM/Clang)
by Marvin Feb. 5, 2011

Feb. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8891 Your paranoid android. === WVISTAADM (32 bit font) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Tray icon not showing up if wine was run previously with DISPLAY unset?
by Dan Kegel Feb. 4, 2011

Feb. 4, 2011

So, I've got this shell script that does something like h=`wine winepath -w $HOME` ... wine autohotkey run-setup.ahk Works great. However, if the user has selected to run wine in a virtual desktop, running winepath will start up and then shut down the virtual desktop, which is visually annoying. Second try: unset DISPLAY when running winepath, e.g. h=`DISPLAY= wine winepath -w $HOME` ... wine autohotkey run-setup.ahk Works great; now winepath doesn't pop up the desktop. Except now autohotkey's tray icon doesn't show up at all, which makes it hard to debug the autohotkey script. (The setup that autohotkey runs can access X just fine, so the problem seems confined to the tray icon.) Is the lack of tray icon a wine bug, or a user error? Third try: wait for wineserver to exit before starting autohotkey h=`DISPLAY= wine winepath -w $HOME` ... wineserver -w wine autohotkey run-setup.ahk but that's slower, and will hang if the user is running a wine app. I guess I could do "sleep 5" but that's an awful kludge. Probably I'll go back to letting the ugly virtual desktop pop up. So, what's the proper way to run one app under wine *without* X while letting other apps run wine *with* X? - Dan

2 1

Re: loader: Build the preloader for ARM
by Alexandre Julliard Feb. 4, 2011

Feb. 4, 2011

André Hentschel <nerv(a)dawncrow.de> writes: > +unsigned int wld_modulo( const unsigned int a, const Elf32_Word b ) > +{ > +#ifdef __ARM_EABI__ > + unsigned int i; > + if(b > a) return a; > + for(i = 0; i * b < a + b; i++) > + if(i * b > a - b) return (a - i * b); > + return 0; That's very inefficient, there are better ways... -- Alexandre Julliard julliard(a)winehq.org

4 5

the patches around ok()
by Joris Huizer Feb. 4, 2011

Feb. 4, 2011

Hello Henri Verbeet, and André Hentschel I wasn't (actively) on the mailing list, that's why I couldn't reply directly to your messages. I will try and make sure I have better titles for such patches in future! Regards, Joris

2 1

Re: kernel32/tests/thread.c: Don't call in ok()
by Henri Verbeet Feb. 4, 2011

Feb. 4, 2011

On 4 February 2011 17:15, Joris Huizer <joris_huizer(a)yahoo.com> wrote: > Subject: kernel32/tests/thread.c: Don't call in ok() Why not?

2 1

Try to Implement my first Stub function - AbortPrinter().
by Loïc Maury Feb. 4, 2011

Feb. 4, 2011

Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document spool file for a printer, created by StartDocPrinter(), who indicate that a document was spooled. I saw that the API printer functions are in dlls/winspool.drv/info.c I understood that there are 4 structures used, *opened_printer_t* for manage a printer, *jobqueue_t* for a list of job for a printer, *started_doc_t* who manage a document, and *job_t* for manage a job. I am on Mac Os 10.6, with CUPS. Here is the code, what do you think ? BOOL WINAPI AbortPrinter(HANDLE hPrinter) { PRINTER_INFO_5W *pi5 = NULL; BOOL ret = FALSE; opened_printer_t *printer; struct list *cursor, *cursor2; job_t *job = 0; DWORD jobDocId; DWORD needed; LPWSTR portname; #if defined(__APPLE__) EnterCriticalSection(&printer_handles_cs); printer = get_opened_printer(hPrinter); if(!printer) { ERR("The handle for the printer is invalid.\n"); SetLastError(ERROR_INVALID_HANDLE); goto end; } TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name) ,debugstr_w(printer->printername) ,printer->backend_printer ,printer->queue->ref ,list_count(&printer->queue->jobs)); /* No jobs to manage. */ if(list_count(&printer->queue->jobs) == 0) { ERR("No job in the list.\n"); SetLastError(ERROR_SPL_NO_STARTDOC); goto end; } if(printer->doc) { TRACE("Document inside for job id : %d\n", printer->doc->job_id); jobDocId = printer->doc->job_id; } else { ERR("No document.\n"); SetLastError(ERROR_SPL_NO_STARTDOC); goto end; } /* For each jobs, get the job document in the double linked list */ LIST_FOR_EACH_SAFE(cursor, cursor2, &printer->queue->jobs) { /* Take a job. */ job = LIST_ENTRY(cursor, job_t, entry); TRACE("(job id : %d, filename : %s, portname : %s, document title : %s, printer name %s)\n",job->job_id ,debugstr_w(job->filename) ,debugstr_w(job->portname) ,debugstr_w(job->document_title) ,debugstr_w(job->printer_name)); if(jobDocId == job->job_id) { TRACE("(hf : %p, job id : %d)\n",printer->doc->hf ,printer->doc->job_id); /* Get portname. */ if (!job->portname) { GetPrinterW(hPrinter, 5, NULL, 0, &needed); pi5 = HeapAlloc(GetProcessHeap(), 0, needed); GetPrinterW(hPrinter, 5, (LPBYTE)pi5, needed, &needed); portname = pi5->pPortName; } TRACE("portname : %s\n", debugstr_w(portname)); /* Cups Port */ if(!strncmpW(portname, CUPS_Port, strlenW(CUPS_Port))) { TRACE("Remove job from the list.\n"); list_remove(cursor); CloseHandle(printer->doc->hf); DeleteFileW(job->filename); HeapFree(GetProcessHeap(), 0, job->document_title); HeapFree(GetProcessHeap(), 0, job->printer_name); HeapFree(GetProcessHeap(), 0, job->portname); HeapFree(GetProcessHeap(), 0, job->filename); HeapFree(GetProcessHeap(), 0, job->devmode); HeapFree(GetProcessHeap(), 0, job); job = 0; ret = TRUE; if(pi5) HeapFree(GetProcessHeap(), 0, pi5); } else FIXME("only CUPS for now.\n"); } } end: LeaveCriticalSection(&printer_handles_cs); TRACE("return %d\n", ret); return ret; #else TRACE("Only CUPS for Mac Os is managed for now.\n"); return FALSE; #endif } Merci Loïc

4 4