February 2011 - Wine-Devel - list.winehq.org

Re: comctl32: Add missing break (Coverity)
by Marcus Meissner Feb. 23, 2011

Feb. 23, 2011

On Wed, Feb 23, 2011 at 05:28:28PM +0100, Amine Khaldi wrote: > CIDs 1581 and 1583. > > Regards, > Amine. the comboex one seems to be intended to fall through to the next case. Ciao, Marcus

1 0

Re: [PATCH] cryptui: fixed bad sizeof() (Coverity)
by Vitaliy Margolen Feb. 23, 2011

Feb. 23, 2011

On 02/22/2011 09:30 PM, Marcus Meissner wrote: > Hi, > > CID 1181. copying a pointer to a struct into a struct is likely bad, > fixed. > > - memcpy(&infoW,&info, sizeof(info)); > + memcpy(&infoW, info, sizeof(*info)); Should probably use direct struct copying instead: infoW = *info; Vitaliy.

2 1

Re: [2/5] msxml3: Remove appendChild() forward (try2)
by Jacek Caban Feb. 23, 2011

Feb. 23, 2011

On 2/23/11 1:21 PM, Nikolay Sivov wrote: > - TRACE("(%p)->(%p %p)\n", This, newChild, outNewChild); > - > - hr = IXMLDOMNode_get_nodeType(newChild,&type); > + hr = IXMLDOMNode_get_nodeType(child,&type); > if(FAILED(hr) || type == NODE_ATTRIBUTE) { > - if(outNewChild) *outNewChild = NULL; > + if (outChild) *outChild = NULL; > return E_FAIL; > } This check for an attribute node shouldn't be needed here. Attribute node may just return failure instead of forwarding the call. Also I'd expect the same from other nodes that can't have children, like text node. Jacek

2 2

Re: [1/5] msxml3: Remove forward to removeChild() method for nodes
by Nikolay Sivov Feb. 23, 2011

Feb. 23, 2011

On 2/23/2011 03:33, Nikolay Sivov wrote: > Remove forward to removeChild() method for nodes > > Ignore that please, I'll resend all 5 patches soon.

1 0

Coverity Scans Revived
by Amine Khaldi Feb. 23, 2011

Feb. 23, 2011

Hello folks, Recently we (myself and Urias from Haiku) have been working on getting the coverity scans up and running again. I'm happy to announce that we succeeded ! :) I submitted a scan and the results are up online. I'll submit further scans when necessary, like it's already done with clang analyzer scans. Have fun ! Regards, Amine.

1 0

New winetricks-alpha 20110222-alpha: new verbs d3dx11_43, dragonage2_demo, regedit, shell, taskmgr, winecfg
by Dan Kegel Feb. 23, 2011

Feb. 23, 2011

Right, it's only been a couple days, but here's a new winetricks already. This release adds dragonage2_demo (released earlier today -- hey, we're starting to keep up!) as well as the handy verbs d3dx11_43, regedit, shell, taskmgr, and winecfg, and a few bugfixes. Download url: http://winetricks.org/winetricks-alpha svn repository / bug tracker: http://winetricks.org Changes since 20110219b-alpha: Dan Kegel: Added Status column to gui, containing 'cached' if game installer is cached. bioshock_demo: add mwo=force for bug 6971 cnc3_demo: fixed install check d3dx11_43: new verb dragonage2_demo: new verb Display install size and time for (some) games. Fix 'winetricks-alpha list'. Thanks to doh123 for pointing out the problem. Pre-check checkboxes for things that are already installed. (winezeug bug 128) regedit: new verb shell: new verb (handy for debugging) taskmgr: new verb tmnationsforever: mention portaudio workaround for choppiness winecfg: new verb Changes since 20110219-alpha: hko: removed, since they no longer offer the torrent download. utorrent: updated to 2.2.1beta. hegemony_demo: update sha1sum gecko is no longer a real verb, so remove media type. Fixes one reported failure in test suite. dc2ba_demo: updated sha1sum d3dxof: fix location of downloaded file msls31: fix typo that broke downloading with clean cache. Fixes ie6. Also mention where files are being downloaded to in console.

1 0

Re: gdi32: first look for a printer driver name in the registry (try 2)
by Vitaliy Margolen Feb. 23, 2011

Feb. 23, 2011

On 02/22/2011 09:28 AM, Vitaly Perov wrote: > Fixed possible hKey leak since last send > > + static const WCHAR user_printers_reg_key[] = { 'S','o','f','t','w','a','r','e','\\', The actual key doesn't look like have anything to do with printers. Please use variable name that more corresponds to the actual content of the unicode string. > + if (!res && !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size)) > + { > + TRACE("Get value from registry\n"); > + } Message is not really helpful. And just hides empty if() case. It's better to reverse logic to check for error and combine with the win.ini check. Something like: if ((RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ, &hKey) || RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size) && !GetProfileStringW(devicesW, device, empty_strW, driver, size)) > WARN("Unable to find %s in [devices] section of win.ini\n", debugstr_w(device)); This should also mention registry. > + if (!res) RegCloseKey(hKey); Instead of using res, initialize hKey to NULL and close it if it's not NULL. It's more foolproof. Vitaliy

1 0

RFC: Patch to change what sets the is_win9x in riched20/tests
by James McKenzie Feb. 23, 2011

Feb. 23, 2011

All: Upon examining other test code that creates a variable called is_win9x, I realized that using get_version and comparing it to a fixed value may not be best for the riched20 tests and have attached a proposed change to how this variable is set. It uses a called function, lstrcmpW and if it does not exist, the variable is set to a false value. This change has been tested on the testbot for Windows95/98/98SE/2K/2K3/XP/XP_64/Vista/Vista64/Win7/Win7_64 and no discrepancies were found. Comments on this patch are appreciated. I would like to submit this for inclusion into the Wine code base on Friday. James McKenzie

2 2

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)
by Rico Schüller Feb. 22, 2011

Feb. 22, 2011

Hi, I have a small hint to the D3DXFloat32To16Array function. It seems that some values are handled in some other way. A small test: D3DXFLOAT16 res; union p { float f; DWORD d; } x; x.d = 0x33000800; D3DXFloat32To16Array(&res, &x.f, 1); ok(res.value == 1, "Failed %f %x\n", x.f, res.value); This fails with the current implementation. It's not the only value, there are a couple of them which are of by one. This could be easily seen by loading both d3dx36.dll (wine and native) and comparing the values directly. Cheers Rico Am 18.02.2011 02:18, schrieb Misha Koshelev: > Fixes bug 25769. Extensively vetted by Stefan Dosinger. Passes winetestbot: > https://testbot.winehq.org/JobDetails.pl?Key=9366 > > Thank you > Misha > --- > dlls/d3dx9_36/d3dx9_36.spec | 4 +- > dlls/d3dx9_36/math.c | 105 +++++++++++++++++++++++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 69 ++++++++++++++++++++++++++++ > include/d3dx9math.h | 18 +++++++ > include/d3dx9math.inl | 31 +++++++++++++ > 5 files changed, 225 insertions(+), 2 deletions(-) > > >

2 3

Re: gdi32: first look for a printer driver name in the registry
by Dmitry Timoshkov Feb. 22, 2011

Feb. 22, 2011

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ, &hKey) > + && !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size)) > + { > + TRACE("Get value from registry\n"); > + RegCloseKey(hKey); > + } You are leaking hKey if RegOpenKeyExW() succeeds but RegQueryValueExW() does not. -- Dmitry.

1 0