March 2011 - Wine-Devel - list.winehq.org

New winetricks-alpha 20110306: new game Crysis 2 Demo and seven others, new dll dinput, lots of bug fixes; ie8 now works
by Dan Kegel March 8, 2011

March 8, 2011

Another fortnight, another Winetricks. Version 20110306-alpha has a slightly cleaned up gui, a handful of bugfixes and sha1sum updates, eight new games (crysis2_demo_mp, diablo2, dragonage, masseffect2_demo, penpenxmas, rayman2_demo, sammax301_demo, and secondlife), one new dll (dinput), and one new setting (vd=640x480). It removes ie68, which is no longer needed, now that ie8 works. It isolates all apps in their own wineprefix by default now, not just games. The option --isolate-games is gone, and a new option --no-isolate was added. And finally, it's not quite as slow at putting up menus. Also, there's some real doc at http://winetricks.org for end users as well as for developers. Download url: http://winetricks.org/winetricks-alpha svn repository / bug tracker: http://winetricks.org Changes since 20110222: Update disk space & time install requirements diablo2: waiting for updater window isn't enough, you have to wait for it to say it's finished! Cope with empty USERNAME, which happens when using startx. hegemony_gold: updated sha1sum Added 'folder' verb to open current wineprefix with xdg-open Show title of installed app rather than absolute path in comment at top, give example of how to install all prereqs firefox: update to 3.6.15, fix system menu. corefonts: Trebuc filenames have mixed case. Fixes bug winezeug-203. Install apps and benchmarks into their own prefixes, too. Show prefix name uniformly in window title. Move ie to dlls, call dlls 'Windows dlls or components'. Add option --no-isolate-games, make --isolate-games the default annihilate: actually ask permission before annihilating the wineprefix. gta_vc: ported, updated. Better fix for bug winezeug-25, should fix new bug winezeug-229 w_download: fix progress indicator gui for locales that use , as a decimal separator. Pointed out by kmiksi. Fixes bug winezeug-232. Add a paragraph at the top about what tools this script uses. Cleaned up comments at top. Moved version ID to very top. vc2005trial: update workarounds for wine-1.3.15 Last changeset was missing wildcards on two patterns Speed up common case of w_pathconv -u 3x by writing it in shell. Suggestion by Christian Storgaard. rayman2_demo: new verb. Based on a patch by Shannon. Make --optout take effect earlier. winetricks_stats_init: always quote W_CACHE dinput: new verb by Shannon, for winehq bug 21159 vd=640x480: new verb, by Shannon diablo2: ported and updated. (Next up: diablo2bc, battle chest version.) crysis2_demo_mp: fix non-q mode, use SetWinDelay to simplify. Patch by Phil. W_CACHE_WIN should just be a drive letter and colon in wine penpenxmas: new verb (based on a patch by Manpreet Sangha) crysis2_demo_mp: new verb by Austin sammax301_demo: new verb by Phil secondlife: ported and updated w_download: autohotkey's download server doesn't like curl's user agent, so use a more common one masseffect2_demo: partly fix windows install. (Clicks still not working.) w_mount: Port support for windows mounts of iso volumes. winetricks_read_volume_name: hexdump is not portable, use od instead w_read_key: create directory before storing key sims3: update to latest version, mention drm problem as showstopper masseffect2: mark as broken drm. masseffect2, masseffect2_demo: move workaround descriptions into w_workaround arg. masseffect2_demo: port verb firefox4: updated to beta12 dragonage: ported verb. Flickers terribly in movies for me :-( osmos_demo: bug 24416 fixed in 1.3.8 w_warn: in -q mode, time out after 5 seconds. Get rid of debug print. sims3: if we want menus to work, we have to install dotnet20. Move sudo detect after gui detect; fixes running winetricks-alpha from system menu ie68: no longer needed, now that ie8 works w_warn: text passed to zenity must be escaped ie8: make -q not fail install test. Fix --gui option, which was ignored because variable was reset after option was processed winetricks_set_wineprefix: Comment out debug print annihilate: only delete .desktop files. Use localized name for Desktop directory. Move silent option to top level menu ie8: set TabProcGrowth=0 to avoid hang. Fixes winezeug bug 159. Thanks to MatthiasLichter. Fix running on cygwin (W_DRIVE_C was wrong)

2 7

Try to fix bug 25999 , patch for dlls/mshtml/navigate.c
by Qian Hong March 7, 2011

March 7, 2011

Hi Jacek, It seems http://bugs.winehq.org/show_bug.cgi?id=25999 has no update from Wine developers, my friend Zhuo Wei has write a patch for it, tests in dlls/mshtml/tests are run on Wine, ( according to http://www.winehq.org/docs/winedev-guide/testing-wine ), every test passes successfully, could you help to review it ? Thanks a lot! >From c5ee98396123c6cccdd295025a6b5aceb87dc0f7 Mon Sep 17 00:00:00 2001 From: Zhuo Wei <zhuo.wei.math(a)gmail.com> Date: Mon, 7 Mar 2011 23:58:09 +0800 Subject: Make sure This->bsc.doc will be initialized while opening a zero byte html file, fix bug 25999 . modified: dlls/mshtml/navigate.c --- dlls/mshtml/navigate.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb71c79..0e7a298 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -985,8 +985,6 @@ static HRESULT read_stream_data(nsChannelBSC *This, IStream *stream) read = 0; hres = IStream_Read(stream, This->nsstream->buf+This->nsstream->buf_size, sizeof(This->nsstream->buf)-This->nsstream->buf_size, &read); - if(!read) - break; This->nsstream->buf_size += read; @@ -1014,6 +1012,9 @@ static HRESULT read_stream_data(nsChannelBSC *This, IStream *stream) on_start_nsrequest(This); } + if(!read) + break; + This->bsc.readed += This->nsstream->buf_size; nsres = nsIStreamListener_OnDataAvailable(This->nslistener, -- 1.7.1 -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [5/5] msi: Manage one assembly cache per major version of the .NET runtime.
by Vincent Povirk March 7, 2011

March 7, 2011

> + static const WCHAR szVersion11[] = {'v','1','.','1','.','4','3','2','2',0}; > + static const WCHAR szVersion20[] = {'v','2','.','0','.','5','0','7','2','7',0}; No v4.0.30319 ?

2 1

Re: [1/5] msi/tests: Check the result of get_system_dirs and get_user_dirs.
by Marvin March 7, 2011

March 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9724 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5967: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] NTDLL atom.c documentation.
by Juan Lang March 7, 2011

March 7, 2011

Hi Max, + * http://www.geoffchappell.com/studies/windows/win32/ntdll/history/names40.htm Please don't link to his site. As I said in an unrelated message to wine-patches last week, he used disassembly when performing his analysis: http://www.geoffchappell.com/viewer.htm?doc=notes/index.htm I wouldn't want to endorse such an effort implicitly by linking to him: future Wine developers could be misled. Thanks, --Juan

3 3

d3dcompiler_41: reflection interface.
by Rico Schüller March 6, 2011

March 6, 2011

Hi, attached is a hacky patch which forwards the reflection interface from d3dcompiler_41 to d3dcompiler_43. I have a question to that implementation: DEFINE_GUID is used twice (dlls/dxguid/dx10guid.c and dlls/d3dcompiler_41/reflection.c) which could be bad. But the define was removed from the d3d11shader.h from ms, so it isn't officially available anymore. Should that be in a separate header to reduce redundancy or is the usage of both defines fine here? Cheers Rico

2 2

Re: d3dx9_36 [patch 2/3, resend]: Add tests for D3DXcreateTeapot
by Marvin March 6, 2011

March 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9720 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 1/3, resend]: Add tests for D3DXCreateBox
by Marvin March 6, 2011

March 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9719 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

USB Osciloscope
by Archie Robertson March 6, 2011

March 6, 2011

I have a USB osciloscope (Link Instruments DSO 8002) that I am quite motivated to get working in wine. I have followed the instructions to install the USB patches. The osciloscope software works fine in demo mode, but it still cannot find the device. I have spent some time messing around with this, but I am new to wine, so I am a little lost. I am a half decent c programmer, so If somebody could point me in the right direction I should be able to get this working. I have gotten error message usbd.sys failed to load. I don't know if this program requires functions that wine does not support or I have just failed to install something correctly. I have attached lsusb and winedump -x output Any help would be greatly appreciated.

6 5

Re: urlmon/tests: Add a '\n' to an ok() call.
by Marvin March 5, 2011

March 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9680 Your paranoid android. === WVISTAADM (32 bit url) === url.c:1535: Test failed: unexpected call OnProgress_SENDINGREQUEST

1 0

Re: olefont - fixed initial cyLogical value in IFont constructor. fixed get_Size to return same value as Window. (try 2)
by Marvin March 5, 2011

March 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9673 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: WineHQ Bug 26271
by Dan Kegel March 4, 2011

March 4, 2011

Dmitry Timoshkov wrote: > Are you going to encourage packagers to include whatever patches > they deem to be "an important feature" for the users, and still claim > that provide an official Wine binary package? There's a middle ground: ship both vanilla and patched wine, and make vanilla the default. I can even imagine distros packaging them up so they can both be installed at the same time. For instance, vanilla wine might be /usr/bin/wine as usual, but one patched for bug 6971 might be /usr/libexec/wine/wine-1.3-hotfix-6971/bin/wine. The patched one would be buried (kind of like gcc's internal files are buried) so they're easy for frontends like winetricks to use when present, but hard for casual users to accidentally use. Bug 6971 is the only one that comes to mind immediately as worth the effort, as it makes many games unplayable ( http://appdb.winehq.org/viewbugs.php?bug_id=6971 ). It occurs to me that fixing or providing a hotfix for this one bug, would get rid of most of PlayOnLinux's incentive to provide their own patched builds of wine. - Dan

1 0

Re: ws2_32: sendmsg on OS/X and BSD returns EMSGSIZE error for size 0
by Alexandre Julliard March 4, 2011

March 4, 2011

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1781,6 +1781,9 @@ static int WS2_send( int fd, struct ws2_async *wsa ) > wsa->iovec[wsa->first_iovec].iov_len -= n; > } > } > + /* BSD and OS/X return EMSGSIZE if hdr.msg_iovlen is 0 */ > + else if ( hdr.msg_iovlen == 0 && errno == EMSGSIZE) > + ret = 0; This should never happen. We should always have at least one iov at that point, the callers should make sure of that. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: wininet(5/6): Obey cache directives and flags regarding caching
by Alexandre Julliard March 4, 2011

March 4, 2011

Juan Lang <juan.lang(a)gmail.com> writes: > From 13fce7b5e1efa74219d334bbce6661bd49a00601 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Wed, 2 Mar 2011 10:41:12 -0800 > Subject: [PATCH 08/19] Obey cache directives and flags regarding caching It fails here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:661: Test failed: expected ReportProgress_CACHEFILENAMEAVAILABLE Also the url.c test hangs forever. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Implement FindNextUrlCacheEntryW
by Alexandre Julliard March 4, 2011

March 4, 2011

Juan Lang <juan.lang(a)gmail.com> writes: > Brought to you by copy and paste. There's no reason to duplicate all that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fixed default cyLogical in IFont constructor
by Marvin March 4, 2011

March 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9650 Your paranoid android. === WNT4WSSP6 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2KPROSP4 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === WXPPROSP3 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2K3R2SESP2 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === WVISTAADM (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2K8SE (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PRO (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PROX64 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PROX64 (64 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0.

1 0

RFC: mmap override patch #2
by Chris Robinson March 3, 2011

March 3, 2011

An updated attempt at the mmap override patch that I previously sent. This version properly uses a signed type for the mmap wrapper (as off_t/off64_t are signed types), fixes a few things with the munmap wrapper relating to truncated and sliced file_views, and implements a mremap wrapper for Linux. There's some debugging stuff left in the mremap wrapper since I have yet to catch anything that uses it, particularly using ERR instead of TRACE and an explicit abort() call so it isn't missed. There's also a %lld formatter in the mmap wrapper that will be fixed later. I'd be interested to hear how well it does or doesn't work, as well as any comments or critiques on the code.

1 0

Please help me with document extraction.
by Max TenEyck Woodbury March 3, 2011

March 3, 2011

As my previous efforts have probably informed you, I am interested in documentation. My initial efforts were _not_ on target and had missed the existing 'c2man.pl' tool. I am in the process of correcting my failure on that. I've picked up Perl in the last couple weeks. An interesting language with lots of adopted features. It's been easy to learn, so I think I will _not_ need help with the language itself, but I will listen to any advice. The c2man.pl code is extensive and sparsely commented. In order to understand what it does, I've made a transcription of it with a more compact style and lots more comments. I check the rewrite against the source code so there should not be any serious errors. There are also a number of what I believe to be defects in the original and places where my comments may be inappropriate or my style may be very objectionable. _This_ is what I need help with. Would someone be willing to review my rewrite? If so, send me e-mail so I can arrange to get a copy of it to you. P.S. to AJ et al. There is a _lot_ of documentation embedded in the wine code, but it is hard to find at the moment. I'd like to see it indexed and this is the program that does the extraction and indexing. Advice on making this new version available and active are in order. Max

4 11

Re: wininet(2/6): Store entries in url cache with valid expiration date
by Alexandre Julliard March 3, 2011

March 3, 2011

Juan Lang <juan.lang(a)gmail.com> writes: > + if (ret) > + { > + ret = FALSE; > + num = strtoulW(ptr, &nextPtr, 10); > + if (nextPtr > ptr && *nextPtr == ':' && num <= 59) > + { > + ptr = nextPtr + 1; > + st.wMinute = (WORD)num; > + ret = TRUE; > + } > + } > + if (ret) > + { > + ret = FALSE; > + num = strtoulW(ptr, &nextPtr, 10); > + if (nextPtr > ptr && isspaceW(*nextPtr) && num <= 59) > + { > + ptr = nextPtr + 1; > + st.wSecond = (WORD)num; > + ret = TRUE; > + } > + } > + if (ret) > + { > + static const WCHAR gmt[]= { 'G','M','T',0 }; > + > + ret = FALSE; > + while (isspaceW(*ptr)) > + ptr++; > + if (!strcmpW(ptr, gmt)) > + ret = TRUE; > + } You may want to consider using 'return', it's quite convenient... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements
by Alexandre Julliard March 3, 2011

March 3, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > + /* FIXME: Implement in more generic and safe way */ > + for(ptr = name; *ptr && isdigitW(*ptr); ptr++) > + i = i*10 + (*ptr-'0'); What's wrong with strtoulW? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: mountmgr.sys: start detecting USB devices
by Maarten Lankhorst March 3, 2011

March 3, 2011

Hi Damjan, Op 02-03-11 18:52, Damjan Jovanovic schreef: > Changelog: > * mountmgr.sys: start detecting USB devices I'd love to get this kind of work in, but since libhal has been deprecated for a while, wouldn't it be better to use libudev directly instead of expanding our usage of libhal? Cheers, Maarten

2 1

Why am I getting create_view out of memory?
by Peter Urbanec March 3, 2011

March 3, 2011

I've got a heavily multithreaded 64-bit app that uses a lot of memory. After a while, I see this: fixme:virtual:create_view out of memory in virtual heap for 0x7f94465b0000-0x7f94466d6000 fixme:virtual:create_view out of memory in virtual heap for 0x7f9446640000-0x7f94466d3000 fixme:virtual:create_view out of memory in virtual heap for 0x7f9446690000-0x7f94466da000 fixme:virtual:create_view out of memory in virtual heap for 0x7f94466b0000-0x7f94466d5000 Could someone please explain to me what's going on here? Quick look at the code indicates that there is a 4MB heap used for "views" (I have no idea what these are) and presumably that heap is exhausted. Is this likely a resource leak somewhere? Some memory stats on the app I'm running: Process: PeakVirtualSize 3f2baf000, VirtualSize 3eccd0000 PeakWorkingSetSize 3762d6000, WorkingSetSize 3689ac000 PeakPagefileUsage 3f2baf000, PagefileUsage 3eccd0000 Global: TotalPhys 3eb4f2000, AvailPhys 0c4d8000 TotalPageFile 66b984000, AvailPageFile 1733eb000 TotalVirtual 7ffffffdffff, AvailVirtual 7ffc1330ffff Cheers, Peter Urbanec

2 1

Re: WineHQ Bug 26271
by Dmitry Timoshkov March 3, 2011

March 3, 2011

[Please do not exclude wine-devel when repying] Andreas Bierfert <andreas.bierfert(a)lowlatency.de> wrote: > > That's precisely my point. How many users are prepared to compile Wine > > from source when they report a bug with such a Wine build, and > > somebody > > asks them to either use a package without custom patches or compile > > Wine > > om their own instead? > > I am not a normal user but the packager. Hence I at least hope to have a > better understanding of what bugs should go upstream and what bugs are > related to some packaging issues or custom patches. In this way I have > no problem to rebuild or try fixes or whatever seems necessary to get > the bug fixed. The question was not about the packager, but about the normal users who has a problem and wants to report a bug. What is a difference between users using your package and crossover/ies4linux/playonlinux/etc. or whatever packager who includes say unofficial DIB engine patches? > > It's very doubtful in the first > > place that the term "official" should be used for such packages. Are > > you going > > to encourage packagers to include whatever patches they deem to be "an > > important > > feature" for the users, and still claim that provide an official Wine > > binary > > package? > > That raises more interesting questions: How would you describe an > official build? What do you do if some libraries are not available and > hence cannot build a full featured wine? But is this really the > important question? There is a Wine wiki page for packagers, and the bugs reporting instructions I pointed out already. Both of them imply using "not modified in any way Wine source". > Of course you may ask the question: Why does the fedora maintainer > include pulseaudio patches in the fedora wine package. And I am glad to > give you an answer: The default fedora spin has been using pulseaudio > for quite some time. It is an important feature of fedora. As I like to > provide users with an out-of-the-box experience wherever possible, it is > my duty to see and investigate where this can be provided for users. In the first place you should ask yourself, what makes you feel that those pulseaudio patches are really necessary? What doesn't work? Have you reported bugs? Where? Have you tested without pulseaudio in the system and can claim that it's the problems implied by Wine and not pulseaudio bugs? > I never understood why wine upstream was so reluctant about including > the pulseaudio patches. They do work well, there are people who maintain > the patches and there is a big userbase for pulseaudio these days. See the relevant bug report about pulseaudio support in Wine, it's been explain many times already. [skipped] -- Dmitry.

1 0

Re: wininet(3/6): Default to 10 minutes expiration for cache entries
by Dmitry Timoshkov March 3, 2011

March 3, 2011

Juan Lang <juan.lang(a)gmail.com> wrote: > + if (!expirationFound) > + { > + SYSTEMTIME st; > + > + /* With no known age, default to 10 minutes until expiration. */ > + GetSystemTime(&st); > + if (st.wMinute < 50) > + st.wMinute += 10; > + else > + { > + st.wHour += 1; > + st.wMinute -= 50; > + } > + SystemTimeToFileTime(&st, &request->expires); > } Well, st.wHour could also everflow, it shuild be easier to add an appropriate period to the resulting 64-bit number. -- Dmitry.

1 0

Re: winex11.drv: Ensure that wintab xinput_handle is not NULL.
by John Klehm March 3, 2011

March 3, 2011

On Mon, Feb 28, 2011 at 8:50 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > --- > dlls/winex11.drv/wintab.c | 13 ++++++++++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > Nice find on this code path being able to run without loading xinput. I have a couple comments: You don't need to guard inside GetCurrentPacket. It's only called when WT_PACKET is passed to the global tablet event hwnd message queue. WT_PACKET is only sent to that queue from XInput event handlers that get registered when xinput is loaded. In short GetCurrentPacket won't get called if xinput isn't loaded so I don't believe it needs the xinput check. As for the AttachEventQueue and WTInfoW checks: I think we'd achieve the same end by having a loaded check in WTOpen just like we do in WTInfo. The benefit would be that we'd let the app know sooner that something was wrong. As it is right now we try to load but don't return 0 if we fail to load in dll/wintab32/context.c:WTInfoT: 370 if (gLoaded == FALSE) 371 LoadTablet(); 372 If we return 0 when loading fails in the dll/wintab32 WTInfo and WTOpen entry points we save the trouble of running through a bunch of function calls that are doomed to fail anyway. Even worse in most places in the wintab code we don't check if the winex11 calls succeed or fail. This would require modifications to LoadTablet and its winex11 buddy LoadTabletInfo so they could bubble up the failure. Regards, --John Klehm

2 1

Re: WineHQ Bug 26271
by Dmitry Timoshkov March 3, 2011

March 3, 2011

Andreas Bierfert <andreas.bierfert(a)lowlatency.de> wrote: > could you please stop arguing about the validity of the bug. What you > are stating in comment 6 is really not exclusive. The Fedora wine > packages are in fact 'prepackaged binary'. Using the term 'prepackaged binary' doesn't make the package suddenly valid for WineHQ bugzilla, since it clearly contains not supported patches. Same applies for instance to crossover, ies4linux, wineskin or any other. > For the Fedora users pulse support in wine is an important feature. This > is why the patches are in the Fedora build in the first place. I'd much > rather have them included with upstream... Maybe sometime wine will gain > openal support for audio input/output and this issue will go away. Once again, packages with custom patches can't be supported through WineHQ bugzilla for obvious reasons. If the packager knows what he/she is dooing by including such patches - he/she should take the full resposibility for that, including accepting bug reports for his package. If he/she doesn't want to carry the support burden then using Wine source without any custom patches is the way to go. -- Dmitry.

4 6

Re: [PATCH] shldocvw: Fixed typo = vs == (Coverity)
by Marcus Meissner March 2, 2011

March 2, 2011

On Fri, Feb 25, 2011 at 09:30:21PM +0100, Eric Pouech wrote: > Le 25/02/2011 14:16, Marcus Meissner a écrit : > >CID1801 > >--- > > dlls/shdocvw/shlinstobj.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/dlls/shdocvw/shlinstobj.c b/dlls/shdocvw/shlinstobj.c > >index d272c91..067e678 100644 > >--- a/dlls/shdocvw/shlinstobj.c > >+++ b/dlls/shdocvw/shlinstobj.c > >@@ -376,7 +376,7 @@ HRESULT SHDOCVW_GetShellInstanceObjectClassObject(REFCLSID rclsid, REFIID riid, > > > > /* Figure if there is an 'Instance' subkey for the given CLSID and acquire a handle. */ > > if (!StringFromGUID2(rclsid, wszInstanceKey + 6, CHARS_IN_GUID) || > >- !(wszInstanceKey[5+CHARS_IN_GUID]='\\') || /* Repair the null-termination. */ > >+ !(wszInstanceKey[5+CHARS_IN_GUID] == '\\') || /* Repair the null-termination. */ > > ERROR_SUCCESS != RegOpenKeyExW(HKEY_CLASSES_ROOT, wszInstanceKey, 0, KEY_READ,&hInstanceKey)) > > { > > /* If there is no 'Instance' subkey, then it's not a Shell Instance Object. */ > are you sure about the fix ? > it looks like it's intentional that the test always succeed (it just > replaces the null termination char written in StringFromGUID2 with a > '\\') > (and this would explain the comment as well ;-) > I'm not familiar with the code... just being suspicious This was right, I fixed it. :) Ciao, Marcus

1 0

Re: t2embed: Add stub for _TTEmbedFont
by Dmitry Timoshkov March 2, 2011

March 2, 2011

André Hentschel <nerv(a)dawncrow.de> wrote: > diff --git a/dlls/t2embed/t2embed.spec b/dlls/t2embed/t2embed.spec > index 2566fa2..729a71b 100644 > --- a/dlls/t2embed/t2embed.spec > +++ b/dlls/t2embed/t2embed.spec > @@ -11,7 +11,7 @@ > @ stub TTRunValidationTests > @ stub _TTCharToUnicode(a)24 > @ stub _TTDeleteEmbeddedFont(a)12 > -@ stub _TTEmbedFont(a)44 > +@ stdcall _TTEmbedFont(ptr long long ptr ptr ptr ptr ptr long long ptr) This change is not correct, the exported name is _TTEmbedFont(a)44. -- Dmitry.

1 0

Re: [PATCH 5/5] mshtml: Added more attribute object tests
by Marvin March 2, 2011

March 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9625 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === Timeout === W2K8SE (32 bit dom) === Timeout

1 0

Problems with change to cursor and keyboard handling
by Erich Hoover March 2, 2011

March 2, 2011

The recent changes to the cursor and keyboard handling absolutely kill performance in Fallout: New Vegas. The cursor changes cause the mouse to jump around (when you move the mouse while using the keyboard) and the keyboard-specific changes cause the entire game to lock up temporarily about once a second when moving solely by keyboard. I believe I've narrowed down the problem with the keyboard changes (the issue is caused by commit bc4afb078677095468d4ee8f9a15c18cbb47bbbf, see attached proposed fix), but I did not have time this evening to explore the root cause of the cursor problem. Since I'm not certain why this particular line in the commit was changed in the first place, I figured I'd bring it up here, in case I'm missing something, before sending the attached to wine-patches. Erich Hoover ehoover(a)mines.edu

1 0

Re: hhctrl.ocx: Decode HTML entities in contents and index
by Alexandre Julliard March 1, 2011

March 1, 2011

Owen Rudge <orudge(a)codeweavers.com> writes: > +static int cmp(const void *key, const void *element) > +{ > + HtmlEntity *entity = (HtmlEntity *) element; > + return strncmpW((LPCWSTR) key, entity->string, lstrlenW(entity->string)); > +} This won't work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Check for the Palette before using it
by Henri Verbeet March 1, 2011

March 1, 2011

2011/2/28 André Hentschel <nerv(a)dawncrow.de>: > *Pal = wined3d_palette_get_parent(wined3d_palette); > - IDirectDrawPalette_AddRef(*Pal); > + if (*Pal) IDirectDrawPalette_AddRef(*Pal); > + else hr = DDERR_NOPALETTEATTACHED; This doesn't make sense, the parent shouldn't be NULL. You should figure out what sets it to NULL. You also may want to try warn+heap to see if it's getting free'd or corrupted somewhere.

1 0

Fwd: Applications for Mentoring Organizations Now Being Accepted
by Dan Kegel March 1, 2011

March 1, 2011

So, shall I do the honors? ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Feb 28, 2011 at 12:35 PM Subject: Applications for Mentoring Organizations Now Being Accepted To: Google Summer of Code Announce <google-summer-of-code-announce(a)googlegroups.com> Hi all, We're pleased to announce the applications for mentoring organizations for Google Summer of Code 2011 are now being accepted [1]. Please go Melange [2] to apply on behalf of your organization. Please note that the application period [3] closes on 11 March at 23:00 UTC [4]. [1] - http://google-opensource.blogspot.com/2011/02/mentoring-organization-applic… [2] - http://www.google-melange.com [3] - http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/ti… [4] - http://goo.gl/paMZU Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Announce" group. To post to this group, send email to google-summer-of-code-announce(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-announce+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-announce?hl=en.

2 1