March 2011 - Wine-Devel - list.winehq.org

Re: WineHQ Bug 26271
by Dmitry Timoshkov March 3, 2011

March 3, 2011

Andreas Bierfert <andreas.bierfert(a)lowlatency.de> wrote: > could you please stop arguing about the validity of the bug. What you > are stating in comment 6 is really not exclusive. The Fedora wine > packages are in fact 'prepackaged binary'. Using the term 'prepackaged binary' doesn't make the package suddenly valid for WineHQ bugzilla, since it clearly contains not supported patches. Same applies for instance to crossover, ies4linux, wineskin or any other. > For the Fedora users pulse support in wine is an important feature. This > is why the patches are in the Fedora build in the first place. I'd much > rather have them included with upstream... Maybe sometime wine will gain > openal support for audio input/output and this issue will go away. Once again, packages with custom patches can't be supported through WineHQ bugzilla for obvious reasons. If the packager knows what he/she is dooing by including such patches - he/she should take the full resposibility for that, including accepting bug reports for his package. If he/she doesn't want to carry the support burden then using Wine source without any custom patches is the way to go. -- Dmitry.

4 6

Re: [PATCH] shldocvw: Fixed typo = vs == (Coverity)
by Marcus Meissner March 2, 2011

March 2, 2011

On Fri, Feb 25, 2011 at 09:30:21PM +0100, Eric Pouech wrote: > Le 25/02/2011 14:16, Marcus Meissner a écrit : > >CID1801 > >--- > > dlls/shdocvw/shlinstobj.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/dlls/shdocvw/shlinstobj.c b/dlls/shdocvw/shlinstobj.c > >index d272c91..067e678 100644 > >--- a/dlls/shdocvw/shlinstobj.c > >+++ b/dlls/shdocvw/shlinstobj.c > >@@ -376,7 +376,7 @@ HRESULT SHDOCVW_GetShellInstanceObjectClassObject(REFCLSID rclsid, REFIID riid, > > > > /* Figure if there is an 'Instance' subkey for the given CLSID and acquire a handle. */ > > if (!StringFromGUID2(rclsid, wszInstanceKey + 6, CHARS_IN_GUID) || > >- !(wszInstanceKey[5+CHARS_IN_GUID]='\\') || /* Repair the null-termination. */ > >+ !(wszInstanceKey[5+CHARS_IN_GUID] == '\\') || /* Repair the null-termination. */ > > ERROR_SUCCESS != RegOpenKeyExW(HKEY_CLASSES_ROOT, wszInstanceKey, 0, KEY_READ,&hInstanceKey)) > > { > > /* If there is no 'Instance' subkey, then it's not a Shell Instance Object. */ > are you sure about the fix ? > it looks like it's intentional that the test always succeed (it just > replaces the null termination char written in StringFromGUID2 with a > '\\') > (and this would explain the comment as well ;-) > I'm not familiar with the code... just being suspicious This was right, I fixed it. :) Ciao, Marcus

1 0

Re: t2embed: Add stub for _TTEmbedFont
by Dmitry Timoshkov March 2, 2011

March 2, 2011

André Hentschel <nerv(a)dawncrow.de> wrote: > diff --git a/dlls/t2embed/t2embed.spec b/dlls/t2embed/t2embed.spec > index 2566fa2..729a71b 100644 > --- a/dlls/t2embed/t2embed.spec > +++ b/dlls/t2embed/t2embed.spec > @@ -11,7 +11,7 @@ > @ stub TTRunValidationTests > @ stub _TTCharToUnicode(a)24 > @ stub _TTDeleteEmbeddedFont(a)12 > -@ stub _TTEmbedFont(a)44 > +@ stdcall _TTEmbedFont(ptr long long ptr ptr ptr ptr ptr long long ptr) This change is not correct, the exported name is _TTEmbedFont(a)44. -- Dmitry.

1 0

Re: [PATCH 5/5] mshtml: Added more attribute object tests
by Marvin March 2, 2011

March 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9625 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === Timeout === W2K8SE (32 bit dom) === Timeout

1 0

Problems with change to cursor and keyboard handling
by Erich Hoover March 2, 2011

March 2, 2011

The recent changes to the cursor and keyboard handling absolutely kill performance in Fallout: New Vegas. The cursor changes cause the mouse to jump around (when you move the mouse while using the keyboard) and the keyboard-specific changes cause the entire game to lock up temporarily about once a second when moving solely by keyboard. I believe I've narrowed down the problem with the keyboard changes (the issue is caused by commit bc4afb078677095468d4ee8f9a15c18cbb47bbbf, see attached proposed fix), but I did not have time this evening to explore the root cause of the cursor problem. Since I'm not certain why this particular line in the commit was changed in the first place, I figured I'd bring it up here, in case I'm missing something, before sending the attached to wine-patches. Erich Hoover ehoover(a)mines.edu

1 0

Re: hhctrl.ocx: Decode HTML entities in contents and index
by Alexandre Julliard March 1, 2011

March 1, 2011

Owen Rudge <orudge(a)codeweavers.com> writes: > +static int cmp(const void *key, const void *element) > +{ > + HtmlEntity *entity = (HtmlEntity *) element; > + return strncmpW((LPCWSTR) key, entity->string, lstrlenW(entity->string)); > +} This won't work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Check for the Palette before using it
by Henri Verbeet March 1, 2011

March 1, 2011

2011/2/28 André Hentschel <nerv(a)dawncrow.de>: > *Pal = wined3d_palette_get_parent(wined3d_palette); > - IDirectDrawPalette_AddRef(*Pal); > + if (*Pal) IDirectDrawPalette_AddRef(*Pal); > + else hr = DDERR_NOPALETTEATTACHED; This doesn't make sense, the parent shouldn't be NULL. You should figure out what sets it to NULL. You also may want to try warn+heap to see if it's getting free'd or corrupted somewhere.

1 0

Fwd: Applications for Mentoring Organizations Now Being Accepted
by Dan Kegel March 1, 2011

March 1, 2011

So, shall I do the honors? ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Feb 28, 2011 at 12:35 PM Subject: Applications for Mentoring Organizations Now Being Accepted To: Google Summer of Code Announce <google-summer-of-code-announce(a)googlegroups.com> Hi all, We're pleased to announce the applications for mentoring organizations for Google Summer of Code 2011 are now being accepted [1]. Please go Melange [2] to apply on behalf of your organization. Please note that the application period [3] closes on 11 March at 23:00 UTC [4]. [1] - http://google-opensource.blogspot.com/2011/02/mentoring-organization-applic… [2] - http://www.google-melange.com [3] - http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/ti… [4] - http://goo.gl/paMZU Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Announce" group. To post to this group, send email to google-summer-of-code-announce(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-announce+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-announce?hl=en.

2 1