March 2011 - Wine-Devel - list.winehq.org

d3dx10: Float16To32Array and Float32To16Array (GSoC)
by Joshua Beck March 20, 2011

March 20, 2011

I'm looking for feedback on an idea for a Google Summer of Code project. I looked at bugzilla and found that the D3DX9 versions of Float16To32Array and Float32To16Array were needed for some games to run. I thought that implementing those functions would make a good Google Summer of Code project, but later discovered that Misha Koshelev had already implemented them in a patch that wasn’t committed yet. In looking up documentation on half floats and these functions gave me ideas for other improvements. For instance, the functions may be implemented differently in D3DX10. A post in this thread: http://www.devmaster.net/forums/showthread.php?t=10924 says that D3DX10 uses different rounding rules and can store NaNs and infinities. I have access to computers running Vista and 7 so I would be able to test how the D3DX10 versions of the functions convert floating point numbers. After doing so, I could make the D3DX10 versions of the functions by modifying the D3DX9 patch’s code. I could also write a conformance test to make sure that the functions are implemented correctly in D3DX10. Joshua Beck

2 2

GSoC: Cygwin and the file system
by Jay Yang March 20, 2011

March 20, 2011

Hello, First an introduction, My name is Jay Yang, I'm currently an undergraduate at the University of Michigan, and as this email indicates, I'm interested in participating in Google Summer of Code. I've been looking at the Cygwin project idea listed on the Summer of Code page, and after looking at some bug reports, I found at least three bugs related to Cygwin that seem to have something to do with the file system. I also saw that the Cygwin page on the wine wiki seems to note that symlinks are one thing that do not work correctly. Is there some underlying bug or unimplemented feature that is causing these failures or are they each their own problem? Also would fixing some of these file system related issues be a good project? Thanks -- Jay Yang

1 0

testing sending to mailing list
by Joshua Beck March 20, 2011

March 20, 2011

My last two emails to this list haven't been accepted. I think I figured out the reason why. Instead of resending the last email I sent, which might make it look like I'm spamming, I'm sending this test email instead.

2 1

Re: [PATCH] Label verbosity levels.
by max＠mtew.isa-geek.net March 20, 2011

March 20, 2011

From: max <max(a)mtew.isa-geek.net> On 03/19/2011 08:42 PM, Joris Huizer wrote: > On 03/19/2011 11:32 PM, Vitaliy Margolen wrote: >> On 03/18/2011 09:24 PM, max(a)mtew.isa-geek.net wrote: >>> - if ($opt_verbose> 0) >>> - { >>> - print "Processing ".$spec_name."\n"; >>> - } >>> + print "Processing ".$spec_name."\n" >>> + if $opt_verbose q>= $VERBOSE_INPUT; >> >> Please don't do this reverse notation. It's much more confusing to most people who are not too familiar with Perl. >> >> Also you changing logic, by replacing ">" (greater then) with ">=" (greater of equal. This is a big no-no to combine any logical changes with cleanup changes. > > This doesn't seem to change logic as $VERBOSE_INPUT equals 1 ( $VERBOSE_QUIET equals 0 ) > Correct. The clean-up involves two counter-acting logic changes. The change from > to >= is countered by increasing the target number by one. The result is that the number itself has the designated meaning. Before the number was one less than level needed to change the affect. There is no _functional_ change. The suffix logical form is not that difficult to understand. It shifts the emphasis from the conditional as the thing of primary import to the message being conveyed, where it belongs. On the other hand if anybody can come up with better names for the levels, PLEASE comment! Max

2 1

d3dx10: Float16To32Array and Float32To16Array (GSoC)
by Joshua Beck March 20, 2011

March 20, 2011

I'm looking for feedback on an idea for a Google Summer of Code project. I looked at bugzilla and found that the D3DX9 versions of Float16To32Array and Float32To16Array were needed for some games to run. I thought that implementing those functions would make a good Google Summer of Code project, but later discovered that Misha Koshelev had already implemented them in a patch that wasn’t committed yet. In looking up documentation on half floats and these functions gave me ideas for other improvements. For instance, the functions may be implemented differently in D3DX10. A post in this thread: http://www.devmaster.net/forums/showthread.php?t=10924 says that D3DX10 uses different rounding rules and can store NaNs and infinities. I have access to computers running Vista and 7 so I would be able to test how the D3DX10 versions of the functions convert floating point numbers. After doing so, I could make the D3DX10 versions of the functions by modifying the D3DX9 patch’s code. I could also write a conformance test to make sure that the functions are implemented correctly in D3DX10. Joshua Beck

1 0

[GSOC] d3dx10: Float16To32Array and Float32To16Array
by Joshua Beck March 20, 2011

March 20, 2011

I'm looking for feedback on an idea for a Google Summer of Code project. I looked at bugzilla and found that the D3DX9 versions of Float16To32Array and Float32To16Array were needed for some games to run. I thought that implementing those functions would make a good Google Summer of Code project, but later discovered that Misha Koshelev had already implemented them in a patch that wasn't committed yet. In looking up documentation on half floats and these functions gave me ideas for other improvements. For instance, the functions may be implemented differently in D3DX10. A post in this thread: http://www.devmaster.net/forums/showthread.php?t=10924 says that D3DX10 uses different rounding rules and can store NaNs and infinities. I have access to computers running Vista and 7 so I would be able to test how the D3DX10 versions of the functions convert floating point numbers. After doing so, I could make the D3DX10 versions of the functions by modifying the D3DX9 patch's code. I could also write a conformance test to make sure that the functions are implemented correctly in D3DX10. Joshua Beck

1 0

re: [1/2] msvcrt: Implement _mbsupr_s (try2).
by Dan Kegel March 20, 2011

March 20, 2011

Konrad wrote: > + c = _mbctoupper(_mbsnextc(s)); > + /* Note that I assume that the size of the character is unchanged */ > + if (c > 255) > + { > + *s++=(c>>8); > + c=c & 0xff; > + } > + *s++=c; Tests might be in order... (Here's one possible interesting test case: http://blogs.msdn.com/b/michkap/archive/2009/08/11/9864576.aspx ) - Dan

2 3

Re: [PATCH] Label verbosity levels.
by Vitaliy Margolen March 20, 2011

March 20, 2011

On 03/18/2011 09:24 PM, max(a)mtew.isa-geek.net wrote: > - if ($opt_verbose> 0) > - { > - print "Processing ".$spec_name."\n"; > - } > + print "Processing ".$spec_name."\n" > + if $opt_verbose>= $VERBOSE_INPUT; Please don't do this reverse notation. It's much more confusing to most people who are not too familiar with Perl. Also you changing logic, by replacing ">" (greater then) with ">=" (greater of equal. This is a big no-no to combine any logical changes with cleanup changes.

2 1

GSOC-Introduction
by Sanket Patel March 19, 2011

March 19, 2011

Hi there I am Sanket Patel I can code well in C If Anything is say to Implement I have good skill in coding in C At all And can Use Efficient C help topics.

1 0

Summer of Code 2011 is on!
by Maarten Lankhorst March 19, 2011

March 19, 2011

Hi all, As you may have known wine has been accepted for summer of code 2011 as a mentoring organization. As such the wine project is now looking for students to participate this year with wine. On our wiki page[1] you can find some ideas, but if you come up with your own idea you will have a lot better chance of getting accepted, as long as you listen to feedback. Summer of code is not just learning to code, but also getting your code accepted into the wine git tree. We'll try to help with that, but the interaction with the wine community is definitely required. For some advice you can read [2] for example. [1] http://wiki.winehq.org/SummerOfCode [2] http://bit.ly/efXVqz Cheers, Maarten PS1: Is anyone willing to add a 'news' blurb about summer of code to the main site? PS2: Also looking for mentor applies.

1 0

Re: clusapi: add stub for GetClusterInformation
by Dmitry Timoshkov March 18, 2011

March 18, 2011

Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: > +/*********************************************************************** > + * GetClusterInformation (CLUSAPI.@) > + * > + */ > +DWORD WINAPI GetClusterInformation(HCLUSTER hCluster, LPWSTR > lpszClusterName, LPDWORD lpcchClusterName, LPCLUSTERVERSIONINFO > lpClusterInfo) It looks like your mailer has wrapped all your patches. -- Dmitry.

5 4

Vacation
by Alexandre Julliard March 18, 2011

March 18, 2011

Folks, There won't be any commits next week, since I'll be busy skiing. Next release should be on schedule two weeks from now. See you all in a week! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Use unescaped Urls for FTP actions (try 2)
by Jacek Caban March 18, 2011

March 18, 2011

Hi André, On 3/17/11 8:58 PM, André Hentschel wrote: > ...don't leak path... > --- > dlls/urlmon/ftp.c | 16 ++++++++++++---- > 1 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dlls/urlmon/ftp.c b/dlls/urlmon/ftp.c > index c9d43b8..a27d84c 100644 > --- a/dlls/urlmon/ftp.c > +++ b/dlls/urlmon/ftp.c > @@ -59,22 +59,30 @@ static HRESULT FtpProtocol_open_request(Protocol *prot, IUri *uri, DWORD request > HINTERNET internet_session, IInternetBindInfo *bind_info) > { > FtpProtocol *This = impl_from_Protocol(prot); > - BSTR url; > + DWORD path_size = INTERNET_MAX_URL_LENGTH; > + BSTR url, path; > HRESULT hres; > > hres = IUri_GetAbsoluteUri(uri,&url); > if(FAILED(hres)) > return hres; > + path = heap_alloc(path_size); > + hres = UrlUnescapeW((LPWSTR)url, path,&path_size, 0); It looks like using GetDisplayUri is what you need. Jacek

1 0

Re: msxml3: Prevent a crash at second call to vsnprintf
by Nikolay Sivov March 17, 2011

March 17, 2011

On 3/18/2011 02:00, André Hentschel wrote: > i did test that now for a while and if the first time the buffer isn't enough and len gets incremented (no matter how much) then the next call to vnsprintf crashes. > that seems to happen only with 64 bits and i would blame Ubuntu for it :) > see http://test.winehq.org/data/12b24af8d7bbb515c4cc678eef45c396487816a4/wine_a… > > so bumping the buffer length to 64 is enough to not trigger that case with our testsuite > --- > dlls/msxml3/main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c > index 01eabab..d3fda99 100644 > --- a/dlls/msxml3/main.c > +++ b/dlls/msxml3/main.c > @@ -63,7 +63,7 @@ HINSTANCE MSXML_hInstance = NULL; > void wineXmlCallbackLog(char const* caller, xmlErrorLevel lvl, char const* msg, va_list ap) > { > char* buf = NULL; > - int len = 32, needed; > + int len = 64, needed; > enum __wine_debug_class dbcl = __WINE_DBCL_ERR; > switch (lvl) > { I feel like you need to figure out why it crashes.

1 0

Spammer on AppDB
by Erich Hoover March 17, 2011

March 17, 2011

Account named "AnnaT": http://appdb.winehq.org/objectManager.php?sClass=version&iId=7440#Comment-6…

2 1

Re: wineport: Add support for ctz().
by Adam Martinson March 17, 2011

March 17, 2011

On 03/17/2011 02:04 PM, Alexander Kochetkov wrote: >> For my purposes the 'return -1' path will never be taken, so it's not >> needed. I want to be able to do: >> >> while (bitmap) >> { >> i = ctz(bitmap); /* get the LSB index */ >> bitmap ^= 1<< i; /* zero LSB */ >> >> /* for each set bit i... */ >> } >> >> If there's a faster way to do this I'm all ears. >> > while (bitmap) > { > bitmap = (bitmap& (bitmap - 1)); /* zero LSB */ > > /* for each set bit i... */ > } > > You could try this solution to zero lsb. > Yes, that's another way to zero the LSB, but I need the index (i).

1 0

Re: msvcrt: add implementation of _mbsupr_s and _mbslwr_s
by Austin English March 17, 2011

March 17, 2011

On Thu, Mar 17, 2011 at 09:39, Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: > --- > dlls/msvcr100/msvcr100.spec | 4 +- > dlls/msvcr80/msvcr80.spec | 4 +- > dlls/msvcr90/msvcr90.spec | 4 +- > dlls/msvcrt/mbcs.c | 72 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 4 +- > 5 files changed, 80 insertions(+), 8 deletions(-) These should be two separate patches, one for each function. Thanks for working on Wine! -- -Austin

1 0

Re: wineport: Add support for ctz().
by Alexandre Julliard March 17, 2011

March 17, 2011

Adam Martinson <amartinson(a)codeweavers.com> writes: > @@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const *___argv, > int ffs( int x ); > #endif > > +#if defined(__GNUC__) && (GCC_VERSION >= 30406) > + #define ctz(x) __builtin_ctz(x) > +#elif defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) > + static inline int ctz( unsigned int x ) > + { > + int ret; > + __asm__("bsfl %1, %0" : "=r" (ret) : "r" (x)); > + return ret; > + } > +#else > + #define ctz(x) (ffs(x)-1) > +#endif There's no reason to add this. Just use ffs(). -- Alexandre Julliard julliard(a)winehq.org

4 5

Re: usp10: corrections to ScriptXtoCP
by Nikolay Sivov March 17, 2011

March 17, 2011

On 3/17/2011 18:20, Aric Stewart wrote: > > It is correct for both LRT and RTL runs > --- > dlls/usp10/tests/usp10.c | 211 > +++++++++++++++++++++++++++++++++------------- > dlls/usp10/usp10.c | 128 +++++++++++++++++++++++----- > 2 files changed, 259 insertions(+), 80 deletions(-) > Maybe it's better to store test data in a table, cause looks like you do similar calls over and over again.

1 0

re: Please ban this spammer from the forum
by Dan Kegel March 17, 2011

March 17, 2011

Done.

1 0

Please ban this spammer from the forum
by Rosanne DiMesio March 17, 2011

March 17, 2011

We've had repeated spam posts from user darlingntq9 over the past couple of days. Please ban him/her from the forum. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: [2/2] server: Make sure that CreateFile(CREATE_ALWAYS) overwrites existing file attributes.
by Alexandre Julliard March 17, 2011

March 17, 2011

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1829,6 +1828,11 @@ struct fd *open_fd( struct fd *root, const char *name, int flags, mode_t *mode, > return NULL; > } > ftruncate( fd->unix_fd, 0 ); > + if (flags & O_CREAT) > + { > + fchmod( fd->unix_fd, *mode ); > + fstat( fd->unix_fd, &st ); > + } You'd have to take umask into account. And I'd like to see some tests for this at the ntdll level. > @@ -178,7 +178,7 @@ static struct object *create_file( struct fd *root, const char *nameptr, data_si > switch(create) > { > case FILE_CREATE: flags = O_CREAT | O_EXCL; break; > - case FILE_OVERWRITE_IF: /* FIXME: the difference is whether we trash existing attr or not */ > + case FILE_OVERWRITE_IF: /* the difference is whether we trash existing attr or not */ It's still a FIXME. -- Alexandre Julliard julliard(a)winehq.org

1 0

Solution for "Could not find dependent assembly" error
by Alexandru Bolboaca-Diaconu March 17, 2011

March 17, 2011

1 0

Re: mshtml,shdocvw: Initialize OLEINPLACEFRAMEINFO.cb for IOleInPlaceSite::GetWindowContext (try 2)
by Dmitry Timoshkov March 17, 2011

March 17, 2011

Thomas Faber <thfabba(a)gmx.de> wrote: > ip_frame = NULL; > ip_uiwindow = NULL; > + frame_info.cb = sizeof(OLEINPLACEFRAMEINFO); Using sizeof(frame_info) here and in other places instead of sizeof(OLEINPLACEFRAMEINFO) would be better IMHO. -- Dmitry.

1 0

Re: wined3d/device: Avoid repeated calculations of idx and shift in IWineD3DDeviceImpl_MarkStateDirty(). (resend)
by Adam Martinson March 16, 2011

March 16, 2011

On 03/16/2011 02:24 PM, Alexandre Julliard wrote: > Adam Martinson<amartinson(a)codeweavers.com> writes: > >> Look at any d3d app with oprofile. That function is called >> EVERYWHERE. In my testing this reduces >> IWineD3DDeviceImpl_MarkStateDirty() from 4.8% of wined3d CPU time to >> 3.3%. > What compiler are you using? I don't see any difference here. > GCC 4.4.5, running the 3DMark06 batch size tests.

2 2