March 2011 - Wine-Devel - list.winehq.org

Re: clusapi: add stub for GetClusterInformation
by Dmitry Timoshkov March 18, 2011

March 18, 2011

Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: > +/*********************************************************************** > + * GetClusterInformation (CLUSAPI.@) > + * > + */ > +DWORD WINAPI GetClusterInformation(HCLUSTER hCluster, LPWSTR > lpszClusterName, LPDWORD lpcchClusterName, LPCLUSTERVERSIONINFO > lpClusterInfo) It looks like your mailer has wrapped all your patches. -- Dmitry.

5 4

Vacation
by Alexandre Julliard March 18, 2011

March 18, 2011

Folks, There won't be any commits next week, since I'll be busy skiing. Next release should be on schedule two weeks from now. See you all in a week! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Use unescaped Urls for FTP actions (try 2)
by Jacek Caban March 18, 2011

March 18, 2011

Hi André, On 3/17/11 8:58 PM, André Hentschel wrote: > ...don't leak path... > --- > dlls/urlmon/ftp.c | 16 ++++++++++++---- > 1 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dlls/urlmon/ftp.c b/dlls/urlmon/ftp.c > index c9d43b8..a27d84c 100644 > --- a/dlls/urlmon/ftp.c > +++ b/dlls/urlmon/ftp.c > @@ -59,22 +59,30 @@ static HRESULT FtpProtocol_open_request(Protocol *prot, IUri *uri, DWORD request > HINTERNET internet_session, IInternetBindInfo *bind_info) > { > FtpProtocol *This = impl_from_Protocol(prot); > - BSTR url; > + DWORD path_size = INTERNET_MAX_URL_LENGTH; > + BSTR url, path; > HRESULT hres; > > hres = IUri_GetAbsoluteUri(uri,&url); > if(FAILED(hres)) > return hres; > + path = heap_alloc(path_size); > + hres = UrlUnescapeW((LPWSTR)url, path,&path_size, 0); It looks like using GetDisplayUri is what you need. Jacek

1 0

Re: msxml3: Prevent a crash at second call to vsnprintf
by Nikolay Sivov March 17, 2011

March 17, 2011

On 3/18/2011 02:00, André Hentschel wrote: > i did test that now for a while and if the first time the buffer isn't enough and len gets incremented (no matter how much) then the next call to vnsprintf crashes. > that seems to happen only with 64 bits and i would blame Ubuntu for it :) > see http://test.winehq.org/data/12b24af8d7bbb515c4cc678eef45c396487816a4/wine_a… > > so bumping the buffer length to 64 is enough to not trigger that case with our testsuite > --- > dlls/msxml3/main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c > index 01eabab..d3fda99 100644 > --- a/dlls/msxml3/main.c > +++ b/dlls/msxml3/main.c > @@ -63,7 +63,7 @@ HINSTANCE MSXML_hInstance = NULL; > void wineXmlCallbackLog(char const* caller, xmlErrorLevel lvl, char const* msg, va_list ap) > { > char* buf = NULL; > - int len = 32, needed; > + int len = 64, needed; > enum __wine_debug_class dbcl = __WINE_DBCL_ERR; > switch (lvl) > { I feel like you need to figure out why it crashes.

1 0

Spammer on AppDB
by Erich Hoover March 17, 2011

March 17, 2011

Account named "AnnaT": http://appdb.winehq.org/objectManager.php?sClass=version&iId=7440#Comment-6…

2 1

Re: wineport: Add support for ctz().
by Adam Martinson March 17, 2011

March 17, 2011

On 03/17/2011 02:04 PM, Alexander Kochetkov wrote: >> For my purposes the 'return -1' path will never be taken, so it's not >> needed. I want to be able to do: >> >> while (bitmap) >> { >> i = ctz(bitmap); /* get the LSB index */ >> bitmap ^= 1<< i; /* zero LSB */ >> >> /* for each set bit i... */ >> } >> >> If there's a faster way to do this I'm all ears. >> > while (bitmap) > { > bitmap = (bitmap& (bitmap - 1)); /* zero LSB */ > > /* for each set bit i... */ > } > > You could try this solution to zero lsb. > Yes, that's another way to zero the LSB, but I need the index (i).

1 0

Re: msvcrt: add implementation of _mbsupr_s and _mbslwr_s
by Austin English March 17, 2011

March 17, 2011

On Thu, Mar 17, 2011 at 09:39, Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: > --- > dlls/msvcr100/msvcr100.spec | 4 +- > dlls/msvcr80/msvcr80.spec | 4 +- > dlls/msvcr90/msvcr90.spec | 4 +- > dlls/msvcrt/mbcs.c | 72 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 4 +- > 5 files changed, 80 insertions(+), 8 deletions(-) These should be two separate patches, one for each function. Thanks for working on Wine! -- -Austin

1 0

Re: wineport: Add support for ctz().
by Alexandre Julliard March 17, 2011

March 17, 2011

Adam Martinson <amartinson(a)codeweavers.com> writes: > @@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const *___argv, > int ffs( int x ); > #endif > > +#if defined(__GNUC__) && (GCC_VERSION >= 30406) > + #define ctz(x) __builtin_ctz(x) > +#elif defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) > + static inline int ctz( unsigned int x ) > + { > + int ret; > + __asm__("bsfl %1, %0" : "=r" (ret) : "r" (x)); > + return ret; > + } > +#else > + #define ctz(x) (ffs(x)-1) > +#endif There's no reason to add this. Just use ffs(). -- Alexandre Julliard julliard(a)winehq.org

4 5

Re: usp10: corrections to ScriptXtoCP
by Nikolay Sivov March 17, 2011

March 17, 2011

On 3/17/2011 18:20, Aric Stewart wrote: > > It is correct for both LRT and RTL runs > --- > dlls/usp10/tests/usp10.c | 211 > +++++++++++++++++++++++++++++++++------------- > dlls/usp10/usp10.c | 128 +++++++++++++++++++++++----- > 2 files changed, 259 insertions(+), 80 deletions(-) > Maybe it's better to store test data in a table, cause looks like you do similar calls over and over again.

1 0

re: Please ban this spammer from the forum
by Dan Kegel March 17, 2011

March 17, 2011

Done.

1 0